@productbrain/cli 0.1.0-beta.36 → 0.1.0-beta.3603

package/dist/__tests__/method-registry.integration.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"method-registry.integration.test.d.ts","sourceRoot":"","sources":["../../src/__tests__/method-registry.integration.test.ts"],"names":[],"mappings":"AAAA;;;GAGG"}

package/dist/__tests__/method-registry.integration.test.js

@@ -0,0 +1,17 @@
+/**
+ * Integration test: loadMethodRegistry reads the actual templates/method-registry.json
+ * from the package root. No fs mocking — exercises the real file path resolution.
+ */
+import { describe, expect, it } from 'vitest';
+import { loadMethodRegistry } from '../lib/method-registry.js';
+describe('method-registry (integration — real fs)', () => {
+    it('loads actual bundled registry from package-root templates/ using real fs', async () => {
+        const result = await loadMethodRegistry();
+        expect(result.source).toBe('bundled');
+        expect(result.registry.version).toBe('1.0');
+        expect(result.registry.methods.length).toBeGreaterThan(0);
+        expect(typeof result.registry.methods[0].name).toBe('string');
+        expect(typeof result.registry.generatedAt).toBe('string');
+    });
+});
+//# sourceMappingURL=method-registry.integration.test.js.map

package/dist/__tests__/method-registry.integration.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"method-registry.integration.test.js","sourceRoot":"","sources":["../../src/__tests__/method-registry.integration.test.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,kBAAkB,EAAE,MAAM,2BAA2B,CAAC;AAE/D,QAAQ,CAAC,yCAAyC,EAAE,GAAG,EAAE;IACvD,EAAE,CAAC,0EAA0E,EAAE,KAAK,IAAI,EAAE;QACxF,MAAM,MAAM,GAAG,MAAM,kBAAkB,EAAE,CAAC;QAC1C,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QACtC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAC5C,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;QAC1D,MAAM,CAAC,OAAO,MAAM,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAC9D,MAAM,CAAC,OAAO,MAAM,CAAC,QAAQ,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;IAC5D,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/__tests__/method-registry.test.d.ts

@@ -0,0 +1,12 @@
+/**
+ * method-registry.test.ts — unit tests for WP-310 E4: method registry loader.
+ *
+ * TEN-2783: the loader is now BUNDLED-ONLY. The former "Chain-first" path
+ * (`chain.getMethodRegistry`) was a route that never existed in the gateway, so it threw on
+ * every handshake and the bundled path was always the real one. Removing it means:
+ *  - `loadMethodRegistry()` takes no arguments and never touches the gateway;
+ *  - `source` is always 'bundled';
+ *  - stale detection + bundled-JSON structure still hold.
+ */
+export {};
+//# sourceMappingURL=method-registry.test.d.ts.map

package/dist/__tests__/method-registry.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"method-registry.test.d.ts","sourceRoot":"","sources":["../../src/__tests__/method-registry.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;GASG"}

package/dist/__tests__/method-registry.test.js

@@ -0,0 +1,86 @@
+/**
+ * method-registry.test.ts — unit tests for WP-310 E4: method registry loader.
+ *
+ * TEN-2783: the loader is now BUNDLED-ONLY. The former "Chain-first" path
+ * (`chain.getMethodRegistry`) was a route that never existed in the gateway, so it threw on
+ * every handshake and the bundled path was always the real one. Removing it means:
+ *  - `loadMethodRegistry()` takes no arguments and never touches the gateway;
+ *  - `source` is always 'bundled';
+ *  - stale detection + bundled-JSON structure still hold.
+ */
+import { beforeEach, describe, expect, it, vi } from 'vitest';
+// Stable bundled registry fixture used across tests
+const BUNDLED_REGISTRY = {
+    version: '1.0',
+    generatedAt: new Date(Date.now() - 1 * 24 * 60 * 60 * 1000).toISOString(), // 1 day ago — fresh
+    methods: [
+        { name: 'session start', usage: 'pb session start', description: 'Open a tracked write session.' },
+        { name: 'capture', usage: 'pb capture "TYPE: text"', description: 'Capture a draft entry.' },
+    ],
+};
+const STALE_BUNDLED_REGISTRY = {
+    ...BUNDLED_REGISTRY,
+    generatedAt: new Date(Date.now() - 8 * 24 * 60 * 60 * 1000).toISOString(), // 8 days ago — stale
+};
+// Mock fs before importing the module under test
+vi.mock('fs', () => ({
+    readFileSync: vi.fn(() => JSON.stringify(BUNDLED_REGISTRY)),
+}));
+import { loadMethodRegistry } from '../lib/method-registry.js';
+import { readFileSync } from 'fs';
+const mockReadFileSync = vi.mocked(readFileSync);
+beforeEach(() => {
+    vi.clearAllMocks();
+    // Default: readFileSync returns fresh bundled registry
+    mockReadFileSync.mockReturnValue(JSON.stringify(BUNDLED_REGISTRY));
+});
+describe('loadMethodRegistry()', () => {
+    describe('bundled-only (TEN-2783)', () => {
+        it("returns source: 'bundled' and the registry", async () => {
+            const result = await loadMethodRegistry();
+            expect(result.source).toBe('bundled');
+            expect(result.registry).toEqual(BUNDLED_REGISTRY);
+        });
+        it('reads the bundled JSON exactly once (no gateway call path)', async () => {
+            await loadMethodRegistry();
+            expect(mockReadFileSync).toHaveBeenCalledTimes(1);
+        });
+        it('takes no arguments (the chain fetch parameter is gone)', () => {
+            expect(loadMethodRegistry.length).toBe(0);
+        });
+        it('returns stale: false when bundled registry generatedAt is recent', async () => {
+            const result = await loadMethodRegistry();
+            expect(result.stale).toBe(false);
+        });
+        it('returns stale: true when bundled registry generatedAt is older than 7 days', async () => {
+            mockReadFileSync.mockReturnValue(JSON.stringify(STALE_BUNDLED_REGISTRY));
+            const result = await loadMethodRegistry();
+            expect(result.stale).toBe(true);
+        });
+        it('rejects (caller catches) when the bundled JSON cannot be read', async () => {
+            mockReadFileSync.mockImplementation(() => {
+                throw new Error('ENOENT');
+            });
+            await expect(loadMethodRegistry()).rejects.toThrow('ENOENT');
+        });
+    });
+    describe('bundled JSON structure', () => {
+        it('bundled registry fixture has all required top-level fields', () => {
+            expect(BUNDLED_REGISTRY).toHaveProperty('version');
+            expect(BUNDLED_REGISTRY).toHaveProperty('generatedAt');
+            expect(BUNDLED_REGISTRY).toHaveProperty('methods');
+            expect(Array.isArray(BUNDLED_REGISTRY.methods)).toBe(true);
+        });
+        it('each method in bundled registry has name, usage, and description', () => {
+            for (const method of BUNDLED_REGISTRY.methods) {
+                expect(method).toHaveProperty('name');
+                expect(method).toHaveProperty('usage');
+                expect(method).toHaveProperty('description');
+                expect(typeof method.name).toBe('string');
+                expect(typeof method.usage).toBe('string');
+                expect(typeof method.description).toBe('string');
+            }
+        });
+    });
+});
+//# sourceMappingURL=method-registry.test.js.map

package/dist/__tests__/method-registry.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"method-registry.test.js","sourceRoot":"","sources":["../../src/__tests__/method-registry.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;GASG;AAEH,OAAO,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAE9D,oDAAoD;AACpD,MAAM,gBAAgB,GAAG;IACvB,OAAO,EAAE,KAAK;IACd,WAAW,EAAE,IAAI,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,GAAG,CAAC,GAAG,EAAE,GAAG,EAAE,GAAG,EAAE,GAAG,IAAI,CAAC,CAAC,WAAW,EAAE,EAAE,oBAAoB;IAC/F,OAAO,EAAE;QACP,EAAE,IAAI,EAAE,eAAe,EAAE,KAAK,EAAE,kBAAkB,EAAE,WAAW,EAAE,+BAA+B,EAAE;QAClG,EAAE,IAAI,EAAE,SAAS,EAAE,KAAK,EAAE,yBAAyB,EAAE,WAAW,EAAE,wBAAwB,EAAE;KAC7F;CACF,CAAC;AAEF,MAAM,sBAAsB,GAAG;IAC7B,GAAG,gBAAgB;IACnB,WAAW,EAAE,IAAI,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,GAAG,CAAC,GAAG,EAAE,GAAG,EAAE,GAAG,EAAE,GAAG,IAAI,CAAC,CAAC,WAAW,EAAE,EAAE,qBAAqB;CACjG,CAAC;AAEF,iDAAiD;AACjD,EAAE,CAAC,IAAI,CAAC,IAAI,EAAE,GAAG,EAAE,CAAC,CAAC;IACnB,YAAY,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAC;CAC5D,CAAC,CAAC,CAAC;AAEJ,OAAO,EAAE,kBAAkB,EAAE,MAAM,2BAA2B,CAAC;AAC/D,OAAO,EAAE,YAAY,EAAE,MAAM,IAAI,CAAC;AAElC,MAAM,gBAAgB,GAAG,EAAE,CAAC,MAAM,CAAC,YAAY,CAAC,CAAC;AAEjD,UAAU,CAAC,GAAG,EAAE;IACd,EAAE,CAAC,aAAa,EAAE,CAAC;IACnB,uDAAuD;IACvD,gBAAgB,CAAC,eAAe,CAAC,IAAI,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAC,CAAC;AACrE,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,sBAAsB,EAAE,GAAG,EAAE;IACpC,QAAQ,CAAC,yBAAyB,EAAE,GAAG,EAAE;QACvC,EAAE,CAAC,4CAA4C,EAAE,KAAK,IAAI,EAAE;YAC1D,MAAM,MAAM,GAAG,MAAM,kBAAkB,EAAE,CAAC;YAE1C,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;YACtC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,gBAAgB,CAAC,CAAC;QACpD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,4DAA4D,EAAE,KAAK,IAAI,EAAE;YAC1E,MAAM,kBAAkB,EAAE,CAAC;YAE3B,MAAM,CAAC,gBAAgB,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;QACpD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,wDAAwD,EAAE,GAAG,EAAE;YAChE,MAAM,CAAC,kBAAkB,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAC5C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,kEAAkE,EAAE,KAAK,IAAI,EAAE;YAChF,MAAM,MAAM,GAAG,MAAM,kBAAkB,EAAE,CAAC;YAE1C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACnC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,4EAA4E,EAAE,KAAK,IAAI,EAAE;YAC1F,gBAAgB,CAAC,eAAe,CAAC,IAAI,CAAC,SAAS,CAAC,sBAAsB,CAAC,CAAC,CAAC;YAEzE,MAAM,MAAM,GAAG,MAAM,kBAAkB,EAAE,CAAC;YAE1C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,+DAA+D,EAAE,KAAK,IAAI,EAAE;YAC7E,gBAAgB,CAAC,kBAAkB,CAAC,GAAG,EAAE;gBACvC,MAAM,IAAI,KAAK,CAAC,QAAQ,CAAC,CAAC;YAC5B,CAAC,CAAC,CAAC;YAEH,MAAM,MAAM,CAAC,kBAAkB,EAAE,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;QAC/D,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;QACtC,EAAE,CAAC,4DAA4D,EAAE,GAAG,EAAE;YACpE,MAAM,CAAC,gBAAgB,CAAC,CAAC,cAAc,CAAC,SAAS,CAAC,CAAC;YACnD,MAAM,CAAC,gBAAgB,CAAC,CAAC,cAAc,CAAC,aAAa,CAAC,CAAC;YACvD,MAAM,CAAC,gBAAgB,CAAC,CAAC,cAAc,CAAC,SAAS,CAAC,CAAC;YACnD,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,gBAAgB,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC7D,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,kEAAkE,EAAE,GAAG,EAAE;YAC1E,KAAK,MAAM,MAAM,IAAI,gBAAgB,CAAC,OAAO,EAAE,CAAC;gBAC9C,MAAM,CAAC,MAAM,CAAC,CAAC,cAAc,CAAC,MAAM,CAAC,CAAC;gBACtC,MAAM,CAAC,MAAM,CAAC,CAAC,cAAc,CAAC,OAAO,CAAC,CAAC;gBACvC,MAAM,CAAC,MAAM,CAAC,CAAC,cAAc,CAAC,aAAa,CAAC,CAAC;gBAC7C,MAAM,CAAC,OAAO,MAAM,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;gBAC1C,MAAM,CAAC,OAAO,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;gBAC3C,MAAM,CAAC,OAAO,MAAM,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;YACnD,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/__tests__/notice-marker.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=notice-marker.test.d.ts.map

package/dist/__tests__/notice-marker.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"notice-marker.test.d.ts","sourceRoot":"","sources":["../../src/__tests__/notice-marker.test.ts"],"names":[],"mappings":""}

package/dist/__tests__/notice-marker.test.js

@@ -0,0 +1,41 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+const files = new Map();
+vi.mock('node:os', () => ({ homedir: () => '/mock-home' }));
+vi.mock('node:fs', () => ({
+    existsSync: (p) => files.has(p),
+    mkdirSync: vi.fn(),
+    statSync: () => ({ mtimeMs: Date.now() }),
+    readdirSync: () => [...files.keys()].map((p) => p.split('/').pop()),
+    unlinkSync: (p) => { files.delete(p); },
+    openSync: (p) => { if (files.has(p)) {
+        const e = new Error('EEXIST');
+        e.code = 'EEXIST';
+        throw e;
+    } files.set(p, ''); return 1; },
+    closeSync: vi.fn(),
+}));
+vi.mock('../lib/session.js', () => ({ readSession: vi.fn(() => ({ sessionId: 'sess-abc' })) }));
+import { claimNotice } from '../lib/notice-marker.js';
+import { readSession } from '../lib/session.js';
+describe('notice-marker', () => {
+    beforeEach(() => files.clear());
+    afterEach(() => vi.clearAllMocks());
+    it('first claim in a session wins, second is silent', () => {
+        expect(claimNotice('agent')).toBe(true);
+        expect(claimNotice('agent')).toBe(false);
+    });
+    it('agent and human channels are independent', () => {
+        expect(claimNotice('agent')).toBe(true);
+        expect(claimNotice('human')).toBe(true);
+    });
+});
+describe('notice-marker — null session (daily fallback key)', () => {
+    beforeEach(() => files.clear());
+    afterEach(() => vi.clearAllMocks());
+    it('missing sessionId → daily fallback key: first call true, second false same UTC day', () => {
+        vi.mocked(readSession).mockReturnValue(null);
+        expect(claimNotice('agent')).toBe(true);
+        expect(claimNotice('agent')).toBe(false);
+    });
+});
+//# sourceMappingURL=notice-marker.test.js.map

package/dist/__tests__/notice-marker.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"notice-marker.test.js","sourceRoot":"","sources":["../../src/__tests__/notice-marker.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAEzE,MAAM,KAAK,GAAG,IAAI,GAAG,EAAkB,CAAC;AACxC,EAAE,CAAC,IAAI,CAAC,SAAS,EAAE,GAAG,EAAE,CAAC,CAAC,EAAE,OAAO,EAAE,GAAG,EAAE,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC;AAC5D,EAAE,CAAC,IAAI,CAAC,SAAS,EAAE,GAAG,EAAE,CAAC,CAAC;IACxB,UAAU,EAAE,CAAC,CAAS,EAAE,EAAE,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC;IACvC,SAAS,EAAE,EAAE,CAAC,EAAE,EAAE;IAClB,QAAQ,EAAE,GAAG,EAAE,CAAC,CAAC,EAAE,OAAO,EAAE,IAAI,CAAC,GAAG,EAAE,EAAE,CAAC;IACzC,WAAW,EAAE,GAAG,EAAE,CAAC,CAAC,GAAG,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,GAAG,EAAE,CAAC;IACnE,UAAU,EAAE,CAAC,CAAS,EAAE,EAAE,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;IAC/C,QAAQ,EAAE,CAAC,CAAS,EAAE,EAAE,GAAG,IAAI,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC;QAAC,MAAM,CAAC,GAAQ,IAAI,KAAK,CAAC,QAAQ,CAAC,CAAC;QAAC,CAAC,CAAC,IAAI,GAAG,QAAQ,CAAC;QAAC,MAAM,CAAC,CAAC;IAAC,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC;IAC9I,SAAS,EAAE,EAAE,CAAC,EAAE,EAAE;CACnB,CAAC,CAAC,CAAC;AACJ,EAAE,CAAC,IAAI,CAAC,mBAAmB,EAAE,GAAG,EAAE,CAAC,CAAC,EAAE,WAAW,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,SAAS,EAAE,UAAU,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;AAEhG,OAAO,EAAE,WAAW,EAAE,MAAM,yBAAyB,CAAC;AACtD,OAAO,EAAE,WAAW,EAAE,MAAM,mBAAmB,CAAC;AAEhD,QAAQ,CAAC,eAAe,EAAE,GAAG,EAAE;IAC7B,UAAU,CAAC,GAAG,EAAE,CAAC,KAAK,CAAC,KAAK,EAAE,CAAC,CAAC;IAChC,SAAS,CAAC,GAAG,EAAE,CAAC,EAAE,CAAC,aAAa,EAAE,CAAC,CAAC;IAEpC,EAAE,CAAC,iDAAiD,EAAE,GAAG,EAAE;QACzD,MAAM,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACxC,MAAM,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAC3C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0CAA0C,EAAE,GAAG,EAAE;QAClD,MAAM,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACxC,MAAM,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC1C,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,mDAAmD,EAAE,GAAG,EAAE;IACjE,UAAU,CAAC,GAAG,EAAE,CAAC,KAAK,CAAC,KAAK,EAAE,CAAC,CAAC;IAChC,SAAS,CAAC,GAAG,EAAE,CAAC,EAAE,CAAC,aAAa,EAAE,CAAC,CAAC;IAEpC,EAAE,CAAC,oFAAoF,EAAE,GAAG,EAAE;QAC5F,EAAE,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC,eAAe,CAAC,IAAI,CAAC,CAAC;QAC7C,MAAM,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACxC,MAAM,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAC3C,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/__tests__/onboarding-path-b.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=onboarding-path-b.test.d.ts.map

package/dist/__tests__/onboarding-path-b.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"onboarding-path-b.test.d.ts","sourceRoot":"","sources":["../../src/__tests__/onboarding-path-b.test.ts"],"names":[],"mappings":""}

package/dist/__tests__/onboarding-path-b.test.js

@@ -0,0 +1,46 @@
+import { describe, it, expect } from 'vitest';
+import { mergeExtractions, dedupe } from '../lib/onboarding-path-b.js';
+describe('Path B onboarding', () => {
+    describe('mergeExtractions', () => {
+        it('second extraction vision wins over first', () => {
+            const merged = mergeExtractions({ vision: 'first vision' }, { vision: 'second vision' });
+            expect(merged.vision).toBe('second vision');
+        });
+        it('falls back to first vision if second is empty', () => {
+            const merged = mergeExtractions({ vision: 'first vision' }, { vision: '' });
+            expect(merged.vision).toBe('first vision');
+        });
+        it('concatenates and deduplicates arrays', () => {
+            const merged = mergeExtractions({ vision: 'v', keyTerms: ['API', 'SDK'] }, { vision: 'v', keyTerms: ['SDK', 'REST'] });
+            expect(merged.keyTerms).toHaveLength(3);
+            expect(merged.keyTerms).toContain('API');
+            expect(merged.keyTerms).toContain('REST');
+        });
+        it('handles null first extraction', () => {
+            const merged = mergeExtractions(null, { vision: 'only vision' });
+            expect(merged.vision).toBe('only vision');
+        });
+        it('merges multiple array fields independently', () => {
+            const merged = mergeExtractions({ vision: 'v', keyTerms: ['API'], tensions: ['scaling'] }, { vision: 'v', keyTerms: ['SDK'], keyDecisions: ['use REST'] });
+            expect(merged.keyTerms).toEqual(['API', 'SDK']);
+            expect(merged.tensions).toEqual(['scaling']);
+            expect(merged.keyDecisions).toEqual(['use REST']);
+        });
+    });
+    describe('dedupe', () => {
+        it('removes case-insensitive duplicates', () => {
+            expect(dedupe(['React', 'react', 'Vue'])).toHaveLength(2);
+        });
+        it('preserves original casing of first occurrence', () => {
+            const result = dedupe(['TypeScript', 'typescript']);
+            expect(result[0]).toBe('TypeScript');
+        });
+        it('returns empty array for empty input', () => {
+            expect(dedupe([])).toEqual([]);
+        });
+        it('handles single-element arrays', () => {
+            expect(dedupe(['React'])).toEqual(['React']);
+        });
+    });
+});
+//# sourceMappingURL=onboarding-path-b.test.js.map

package/dist/__tests__/onboarding-path-b.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"onboarding-path-b.test.js","sourceRoot":"","sources":["../../src/__tests__/onboarding-path-b.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,gBAAgB,EAAE,MAAM,EAAE,MAAM,6BAA6B,CAAC;AAEvE,QAAQ,CAAC,mBAAmB,EAAE,GAAG,EAAE;IACjC,QAAQ,CAAC,kBAAkB,EAAE,GAAG,EAAE;QAChC,EAAE,CAAC,0CAA0C,EAAE,GAAG,EAAE;YAClD,MAAM,MAAM,GAAG,gBAAgB,CAC7B,EAAE,MAAM,EAAE,cAAc,EAAE,EAC1B,EAAE,MAAM,EAAE,eAAe,EAAE,CAC5B,CAAC;YACF,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC;QAC9C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;YACvD,MAAM,MAAM,GAAG,gBAAgB,CAC7B,EAAE,MAAM,EAAE,cAAc,EAAE,EAC1B,EAAE,MAAM,EAAE,EAAE,EAAE,CACf,CAAC;YACF,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC;QAC7C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,sCAAsC,EAAE,GAAG,EAAE;YAC9C,MAAM,MAAM,GAAG,gBAAgB,CAC7B,EAAE,MAAM,EAAE,GAAG,EAAE,QAAQ,EAAE,CAAC,KAAK,EAAE,KAAK,CAAC,EAAE,EACzC,EAAE,MAAM,EAAE,GAAG,EAAE,QAAQ,EAAE,CAAC,KAAK,EAAE,MAAM,CAAC,EAAE,CAC3C,CAAC;YACF,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;YACxC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;YACzC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QAC5C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,+BAA+B,EAAE,GAAG,EAAE;YACvC,MAAM,MAAM,GAAG,gBAAgB,CAAC,IAAI,EAAE,EAAE,MAAM,EAAE,aAAa,EAAE,CAAC,CAAC;YACjE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC;QAC5C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;YACpD,MAAM,MAAM,GAAG,gBAAgB,CAC7B,EAAE,MAAM,EAAE,GAAG,EAAE,QAAQ,EAAE,CAAC,KAAK,CAAC,EAAE,QAAQ,EAAE,CAAC,SAAS,CAAC,EAAE,EACzD,EAAE,MAAM,EAAE,GAAG,EAAE,QAAQ,EAAE,CAAC,KAAK,CAAC,EAAE,YAAY,EAAE,CAAC,UAAU,CAAC,EAAE,CAC/D,CAAC;YACF,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC,CAAC;YAChD,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC;YAC7C,MAAM,CAAC,MAAM,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC;QACpD,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,QAAQ,EAAE,GAAG,EAAE;QACtB,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;YAC7C,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,EAAE,OAAO,EAAE,KAAK,CAAC,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QAC5D,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;YACvD,MAAM,MAAM,GAAG,MAAM,CAAC,CAAC,YAAY,EAAE,YAAY,CAAC,CAAC,CAAC;YACpD,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;QACvC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;YAC7C,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QACjC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,+BAA+B,EAAE,GAAG,EAAE;YACvC,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC;QAC/C,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/__tests__/onboarding.test.js

@@ -3,17 +3,10 @@
  * WP-304: extractionToEntries, signal detection, phase engine, post-processing.
  */
 import { describe, it, expect } from 'vitest';
-// ── Helpers under test (copied for unit testing) ────────────────────────────
-// SYNC: Must match packages/cli/src/lib/*.ts
-function truncate(str, maxLen) {
-    return str.length <= maxLen ? str : str.slice(0, maxLen);
-}
-function firstNWords(str, n) {
-    return str.split(/\s+/).slice(0, n).join(' ');
-}
-function countWords(text) {
-    return text.trim().split(/\s+/).filter(Boolean).length;
-}
+import { truncate, firstNWords, countWords, validateExtractedEntries, } from '../lib/onboarding-shared.js';
+import { detectSignals } from '../lib/conversation-signals.js';
+import { buildTopicDirective, evaluateTopic, shouldSkipTopic } from '../lib/conversation-engine.js';
+import { ONBOARDING_TOPICS } from '../lib/onboarding-topics.js';
 // Signal detection patterns (from conversation-signals.ts)
 const PRODUCT_PATTERNS = [
     /\b(?:building|making|creating|working on|developing)\b/i,
@@ -29,6 +22,10 @@ const WHY_PB_PATTERNS = [
     /\b(?:context|memory|decisions?|knowledge|source of truth|ssot)\b/i,
     /\b(?:ai|llm|claude|cursor|copilot|agent)\b.*\b(?:context|remember|forget|know)\b/i,
     /\b(?:remember|forget|consistent|prompt)\b.*\b(?:ai|llm|agent|tool)\b/i,
+    // Broader: user describes the problem PB solves without naming PB
+    /\b(?:re-?explain|repeat myself|start from (?:zero|scratch)|re-?tell)\b/i,
+    /\b(?:docs?|documentation|md files?)\b.*\b(?:outdated|stale|rot|drift|wrong|maintain)\b/i,
+    /\b(?:cost|waste|spend)\b.*\b(?:tokens?|context|time)\b.*\b(?:re-?explain|repeat|maintain)\b/i,
 ];
 function detectSignal(patterns, text) {
     return patterns.some((p) => p.test(text));
@@ -47,40 +44,6 @@ function sanitizeResponse(text) {
     }
     return cleaned.replace(/\s{2,}/g, ' ').replace(/^\s*[.,]\s*/, '').trim();
 }
-function extractionToEntries(extracted) {
-    const entries = [];
-    if (extracted.vision?.trim()) {
-        entries.push({ collection: 'strategy', name: 'Product Vision', description: extracted.vision });
-    }
-    if (extracted.audience) {
-        entries.push({ collection: 'audiences', name: firstNWords(extracted.audience, 6), description: extracted.audience });
-    }
-    if (extracted.techStack?.length) {
-        entries.push({ collection: 'architecture', name: 'Tech Stack', description: `Technology choices: ${extracted.techStack.join(', ')}` });
-        for (const tech of extracted.techStack.slice(0, 3)) {
-            entries.push({ collection: 'glossary', name: tech, description: `${tech} — part of the tech stack` });
-        }
-    }
-    if (extracted.keyTerms?.length) {
-        for (const term of extracted.keyTerms) {
-            const alreadyAdded = entries.some((e) => e.collection === 'glossary' && e.name.toLowerCase() === term.toLowerCase());
-            if (!alreadyAdded) {
-                entries.push({ collection: 'glossary', name: term, description: `Core domain term: ${term}` });
-            }
-        }
-    }
-    if (extracted.keyDecisions?.length) {
-        for (const decision of extracted.keyDecisions) {
-            entries.push({ collection: 'decisions', name: truncate(decision, 80), description: decision });
-        }
-    }
-    if (extracted.tensions?.length) {
-        for (const tension of extracted.tensions) {
-            entries.push({ collection: 'tensions', name: truncate(tension, 80), description: tension });
-        }
-    }
-    return entries;
-}
 // ── Tests ───────────────────────────────────────────────────────────────────
 describe('truncate', () => {
     it('returns string unchanged when within limit', () => {
@@ -110,7 +73,7 @@ describe('countWords', () => {
         expect(countWords('   ')).toBe(0);
     });
 });
-describe('signal detection', () => {
+describe('signal detection (pattern matching)', () => {
     it('detects product mentions', () => {
         expect(detectSignal(PRODUCT_PATTERNS, 'I am building an app for accounting')).toBe(true);
         expect(detectSignal(PRODUCT_PATTERNS, 'something big')).toBe(false);
@@ -125,6 +88,38 @@ describe('signal detection', () => {
         expect(detectSignal(WHY_PB_PATTERNS, 'we need a source of truth for decisions')).toBe(true);
         expect(detectSignal(WHY_PB_PATTERNS, 'I just saw an ad')).toBe(false);
     });
+    it('detects why-PB from reexplaining pattern', () => {
+        expect(detectSignal(WHY_PB_PATTERNS, 'i have to reexplain everything to my ai tools')).toBe(true);
+    });
+    it('detects why-PB from outdated docs pattern', () => {
+        expect(detectSignal(WHY_PB_PATTERNS, 'my md docs get outdated quickly')).toBe(true);
+    });
+});
+describe('detectSignals (integrated thresholds)', () => {
+    it('requires >= 10 words for mentionedProduct — short pattern match is not enough', () => {
+        const shortMsg = [{ role: 'user', content: 'I am building an app' }]; // 5 words, pattern matches
+        expect(detectSignals(shortMsg).mentionedProduct).toBe(false);
+        const longMsg = [{ role: 'user', content: 'I am building an app that connects to Revolut for bank transactions' }]; // 12 words
+        expect(detectSignals(longMsg).mentionedProduct).toBe(true);
+    });
+    it('requires >= 15 words for hasSubstantiveAnswer', () => {
+        const shortMsg = [{ role: 'user', content: 'it connects to revolut and gets my bank transactions automatically' }]; // 10 words
+        expect(detectSignals(shortMsg).hasSubstantiveAnswer).toBe(false);
+        const longMsg = [{ role: 'user', content: 'it connects to revolut and gets my bank transactions then matches them to invoices from gmail automatically' }]; // 17 words
+        expect(detectSignals(longMsg).hasSubstantiveAnswer).toBe(true);
+    });
+    it('counts substantive messages as >= 8 words', () => {
+        const msgs = [
+            { role: 'user', content: 'a cool app' }, // 3 words — not substantive
+            { role: 'user', content: 'me and my team use it daily for tracking' }, // 9 words — substantive
+            { role: 'user', content: 'yes' }, // 1 word — not substantive
+        ];
+        expect(detectSignals(msgs).substantiveMessageCount).toBe(1);
+    });
+    it('does not flag mentionedProduct without a pattern match even with many words', () => {
+        const noPattern = [{ role: 'user', content: 'I just want to try this out and see how it goes for my daily workflow' }]; // 16 words, no product pattern
+        expect(detectSignals(noPattern).mentionedProduct).toBe(false);
+    });
 });
 describe('sanitizeResponse', () => {
     it('strips "sounds like"', () => {
@@ -140,55 +135,213 @@ describe('sanitizeResponse', () => {
         expect(sanitizeResponse('What problem are you trying to solve?')).toBe('What problem are you trying to solve?');
     });
 });
-describe('extractionToEntries', () => {
-    it('returns empty array for blank vision', () => {
-        expect(extractionToEntries({ vision: '  ' })).toEqual([]);
+describe('validateExtractedEntries', () => {
+    it('returns empty array for non-array input', () => {
+        expect(validateExtractedEntries(null)).toEqual([]);
+        expect(validateExtractedEntries(undefined)).toEqual([]);
+    });
+    it('returns empty array for empty entries', () => {
+        expect(validateExtractedEntries([])).toEqual([]);
     });
-    it('maps vision-only extraction', () => {
-        const result = extractionToEntries({ vision: 'Build the best product tool' });
+    it('validates and passes through well-formed entries', () => {
+        const result = validateExtractedEntries([
+            { collection: 'strategy', name: 'Product Vision', description: 'Automate bank transactions', typeLabel: "What you're building" },
+        ]);
         expect(result).toHaveLength(1);
-        expect(result[0].collection).toBe('strategy');
-    });
-    it('maps full extraction to correct collections', () => {
-        const result = extractionToEntries({
-            vision: 'AI-powered product intelligence',
-            audience: 'Solo product builders who ship fast',
-            techStack: ['SvelteKit', 'Convex', 'TypeScript'],
-            keyTerms: ['Chain', 'Product Brain'],
-            keyDecisions: ['Go with Convex over Supabase'],
-            tensions: ['Onboarding is too complex'],
-        });
-        const collections = result.map((e) => e.collection);
-        expect(collections).toContain('strategy');
-        expect(collections).toContain('audiences');
-        expect(collections).toContain('architecture');
-        expect(collections).toContain('glossary');
-        expect(collections).toContain('decisions');
-        expect(collections).toContain('tensions');
-    });
-    it('caps tech stack glossary at 3', () => {
-        const result = extractionToEntries({
-            vision: 'A tool',
-            techStack: ['React', 'Vue', 'Angular', 'Svelte', 'Solid'],
+        expect(result[0].name).toBe('Product Vision');
+        expect(result[0].description).toBe('Automate bank transactions');
+        expect(result[0].typeLabel).toBe("What you're building");
+    });
+    it('rejects entries with invalid collection', () => {
+        const result = validateExtractedEntries([
+            { collection: 'invalid', name: 'Something Good', description: 'desc', typeLabel: 'label' },
+        ]);
+        expect(result).toEqual([]);
+    });
+    it('rejects entries with empty name or description', () => {
+        const result = validateExtractedEntries([
+            { collection: 'strategy', name: '', description: 'desc', typeLabel: 'label' },
+            { collection: 'strategy', name: 'Some Name', description: '', typeLabel: 'label' },
+        ]);
+        expect(result).toEqual([]);
+    });
+    it('deduplicates by name (case-insensitive)', () => {
+        const result = validateExtractedEntries([
+            { collection: 'glossary', name: 'Supabase', description: 'Database option', typeLabel: 'Term' },
+            { collection: 'glossary', name: 'supabase', description: 'Another desc', typeLabel: 'Term' },
+        ]);
+        expect(result).toHaveLength(1);
+    });
+    it('caps at 7 entries', () => {
+        const entries = Array.from({ length: 10 }, (_, i) => ({
+            collection: 'tensions',
+            name: `Challenge number ${i + 1}`,
+            description: `Description ${i + 1}`,
+            typeLabel: 'A challenge',
+        }));
+        expect(validateExtractedEntries(entries)).toHaveLength(7);
+    });
+    it('truncates long names to 120 chars', () => {
+        const longName = 'A '.repeat(100);
+        const result = validateExtractedEntries([
+            { collection: 'decisions', name: longName, description: 'desc', typeLabel: 'label' },
+        ]);
+        expect(result[0].name.length).toBeLessThanOrEqual(120);
+    });
+    it('skips single-word names except for glossary', () => {
+        const result = validateExtractedEntries([
+            { collection: 'strategy', name: 'Vision', description: 'desc', typeLabel: 'label' },
+            { collection: 'glossary', name: 'Supabase', description: 'A database', typeLabel: 'Term' },
+        ]);
+        expect(result).toHaveLength(1);
+        expect(result[0].collection).toBe('glossary');
+    });
+    it('falls back to collection name when typeLabel is empty', () => {
+        const result = validateExtractedEntries([
+            { collection: 'strategy', name: 'Product Vision', description: 'desc', typeLabel: '' },
+        ]);
+        expect(result[0].typeLabel).toBe('strategy');
+    });
+    it('passes descriptions through without template wrapping', () => {
+        const result = validateExtractedEntries([
+            { collection: 'architecture', name: 'Evaluating supabase vs liteSQL', description: 'Need to decide between liteSQL and supabase for production', typeLabel: 'A technology choice' },
+        ]);
+        expect(result[0].description).toBe('Need to decide between liteSQL and supabase for production');
+        expect(result[0].description).not.toContain('Technology choices:');
+        expect(result[0].description).not.toContain('part of the tech stack');
+    });
+});
+// ── Coach pattern: topic engine ─────────────────────────────────────────────
+function makeState(overrides = {}) {
+    return {
+        messages: [],
+        userMessageCount: 0,
+        totalUserWords: 0,
+        topicExchanges: {},
+        phaseExchanges: {},
+        completedTopics: new Set(),
+        completedPhases: new Set(),
+        currentTopicId: 'why_here',
+        currentPhaseId: 'why_here',
+        completedQA: [],
+        signals: {
+            mentionedProduct: false,
+            mentionedChallenge: false,
+            mentionedWhyPB: false,
+            hasSubstantiveAnswer: false,
+            substantiveMessageCount: 0,
+        },
+        refusalStreak: 0,
+        ...overrides,
+    };
+}
+describe('shouldSkipTopic', () => {
+    it('returns false when skipIfSignal is null (always runs)', () => {
+        const topic = ONBOARDING_TOPICS[0]; // why_here — skipIfSignal: null
+        expect(shouldSkipTopic(topic, makeState().signals, 50)).toBe(false);
+    });
+    it('returns true when skipIfSignal is present and enough words', () => {
+        const topic = ONBOARDING_TOPICS[1]; // what_they_build — skipIfSignal: mentionedProduct
+        const signals = { ...makeState().signals, mentionedProduct: true };
+        expect(shouldSkipTopic(topic, signals, 25)).toBe(true);
+    });
+    it('returns false when skipIfSignal is not present', () => {
+        const topic = ONBOARDING_TOPICS[1]; // what_they_build — skipIfSignal: mentionedProduct
+        expect(shouldSkipTopic(topic, makeState().signals, 50)).toBe(false);
+    });
+    it('returns false when content is too thin even if signal is present', () => {
+        const topic = ONBOARDING_TOPICS[1]; // what_they_build — skipIfSignal: mentionedProduct
+        const signals = { ...makeState().signals, mentionedProduct: true };
+        expect(shouldSkipTopic(topic, signals, 10)).toBe(false); // < 20 words
+    });
+});
+describe('evaluateTopic', () => {
+    const topic = ONBOARDING_TOPICS[1]; // what_they_build — maxExchanges: 2, heuristic: mentionedProduct
+    it('skips when skipIfSignal is present and enough words', () => {
+        const state = makeState({ totalUserWords: 25, signals: { ...makeState().signals, mentionedProduct: true } });
+        const result = evaluateTopic(topic, state, false);
+        expect(result).toEqual({ complete: true, forced: false, skip: true });
+    });
+    it('completes when LLM says complete and at least 1 exchange', () => {
+        const state = makeState({ topicExchanges: { what_they_build: 1 } });
+        const result = evaluateTopic(topic, state, true);
+        expect(result).toEqual({ complete: true, forced: false, skip: false });
+    });
+    it('does NOT complete when LLM says complete but 0 exchanges', () => {
+        const state = makeState();
+        const result = evaluateTopic(topic, state, true);
+        expect(result).toEqual({ complete: false, forced: false, skip: false });
+    });
+    it('completes via heuristic backup when signal present but low words (no skip)', () => {
+        const state = makeState({
+            topicExchanges: { what_they_build: 1 },
+            signals: { ...makeState().signals, mentionedProduct: true },
         });
-        const glossary = result.filter((e) => e.collection === 'glossary');
-        expect(glossary).toHaveLength(3);
-    });
-    it('deduplicates glossary terms', () => {
-        const result = extractionToEntries({
-            vision: 'A tool',
-            techStack: ['TypeScript'],
-            keyTerms: ['TypeScript', 'Chain'],
+        // totalUserWords=0 < 20, so skip is blocked, but heuristic still completes the topic
+        const result = evaluateTopic(topic, state, false);
+        expect(result).toEqual({ complete: true, forced: false, skip: false });
+    });
+    it('forces completion at maxExchanges', () => {
+        const state = makeState({ topicExchanges: { what_they_build: 2 } });
+        const result = evaluateTopic(topic, state, false);
+        expect(result).toEqual({ complete: true, forced: true, skip: false });
+    });
+    it('continues when nothing is met', () => {
+        const state = makeState({ topicExchanges: { what_they_build: 1 } });
+        const result = evaluateTopic(topic, state, false);
+        expect(result).toEqual({ complete: false, forced: false, skip: false });
+    });
+});
+describe('evaluateTopic — why_here (no skip)', () => {
+    const topic = ONBOARDING_TOPICS[0]; // why_here — heuristic: hasSubstantiveAnswer
+    it('completes via heuristic when hasSubstantiveAnswer', () => {
+        const state = makeState({
+            topicExchanges: { why_here: 1 },
+            signals: { ...makeState().signals, hasSubstantiveAnswer: true },
         });
-        const glossary = result.filter((e) => e.collection === 'glossary');
-        expect(glossary).toHaveLength(2);
+        const result = evaluateTopic(topic, state, false);
+        expect(result).toEqual({ complete: true, forced: false, skip: false });
     });
-    it('handles null optional fields', () => {
-        const result = extractionToEntries({
-            vision: 'A product',
-            audience: null, techStack: null, keyTerms: null, keyDecisions: null, tensions: null,
+    it('never skips (skipIfSignal is null)', () => {
+        const state = makeState({
+            signals: { ...makeState().signals, hasSubstantiveAnswer: true, mentionedProduct: true, mentionedChallenge: true },
         });
-        expect(result).toHaveLength(1);
+        const result = evaluateTopic(topic, state, false);
+        // Even with all signals true, why_here doesn't skip — it always runs
+        // But it completes via heuristic if exchanges >= 1
+        expect(result.skip).toBe(false);
+    });
+});
+describe('buildTopicDirective', () => {
+    it('renders XML with goal, behaviour, criteria', () => {
+        const topic = ONBOARDING_TOPICS[0];
+        const result = buildTopicDirective(topic, 0, 3, [], 'TestWorkspace');
+        expect(result).toContain('<topic id="why_here" index="1" of="3">');
+        expect(result).toContain('<goal>');
+        expect(result).toContain('<behaviour>');
+        expect(result).toContain('<criteria>');
+        expect(result).toContain('</topic>');
+    });
+    it('includes topic behaviour text', () => {
+        const topic = ONBOARDING_TOPICS[0];
+        const result = buildTopicDirective(topic, 0, 3, [], 'Acme Corp');
+        expect(result).toContain('Hey, what brings you to Product Brain?');
+    });
+    it('includes accumulated_context when completedQA is non-empty', () => {
+        const qa = [
+            { topicId: 'why_here', question: 'What brings you here?', answer: 'Building a finance tool' },
+        ];
+        const topic = ONBOARDING_TOPICS[1];
+        const result = buildTopicDirective(topic, 1, 3, qa, 'TestWS');
+        expect(result).toContain('<accumulated_context>');
+        expect(result).toContain('<topic_qa id="why_here">');
+        expect(result).toContain('Building a finance tool');
+        expect(result).toContain('</accumulated_context>');
+    });
+    it('omits accumulated_context when completedQA is empty', () => {
+        const topic = ONBOARDING_TOPICS[0];
+        const result = buildTopicDirective(topic, 0, 3, [], 'TestWS');
+        expect(result).not.toContain('<accumulated_context>');
     });
 });
 //# sourceMappingURL=onboarding.test.js.map