@produck/agent-toolkit 0.2.0 → 0.2.1

package/bin/command/validate-commit-msg/index.mjs

@@ -0,0 +1,152 @@
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+import { getSingle } from '../shared/args.mjs';
+import { printTextResource } from '../shared/text-resource.mjs';
+
+const ALLOWED_TAGS = ['INIT', 'ADD', 'REMOVE', 'FIX', 'REFACTOR', 'UPGRADE', 'PUBLISH'];
+const ALLOWED_TARGETS = ['docs', 'test', 'ci', 'deps', 'api', 'schema', 'infra', 'fmt'];
+const SECTION_HEADER_RE = /^(?:@[\w.-]+\/)?[\w.-]+:$/;
+const COMMAND_DIR = path.dirname(fileURLToPath(import.meta.url));
+const HELP_FILE = path.resolve(COMMAND_DIR, 'help.txt');
+
+export function printValidateCommitMsgHelp() {
+  printTextResource(HELP_FILE);
+}
+
+function validateCommitLine(line, lineNo) {
+  if (line.trim() === '') {
+    return `Line ${lineNo}: empty line is not allowed`;
+  }
+
+  const head = line.match(/^\[([A-Z]+)\]\s+/);
+  if (!head) {
+    return `Line ${lineNo}: must start with [TAG] followed by a space`;
+  }
+
+  const tag = head[1];
+  if (!ALLOWED_TAGS.includes(tag)) {
+    return `Line ${lineNo}: tag [${tag}] is not allowed`;
+  }
+
+  const rest = line.slice(head[0].length);
+  if (rest.trim() === '') {
+    return `Line ${lineNo}: summary is required after tag`;
+  }
+
+  const targetMatch = rest.match(/^<([^>]+)>:\s+(.+)$/);
+  if (targetMatch) {
+    const target = targetMatch[1];
+    const summary = targetMatch[2];
+    if (!ALLOWED_TARGETS.includes(target)) {
+      return `Line ${lineNo}: target <${target}> is not allowed`;
+    }
+    if (summary.trim() === '') {
+      return `Line ${lineNo}: summary is required after target`;
+    }
+  }
+
+  return null;
+}
+
+function isSectionHeaderLine(line) {
+  return SECTION_HEADER_RE.test(line.trim());
+}
+
+function validateSectionFormat(lines) {
+  const errors = [];
+  let currentSection = '';
+  let currentSectionLineNo = 0;
+  let currentSectionHasTaggedLine = false;
+
+  for (let i = 0; i < lines.length; i += 1) {
+    const lineNo = i + 1;
+    const line = lines[i];
+
+    if (line.trim() === '') {
+      errors.push(`Line ${lineNo}: empty line is not allowed`);
+      continue;
+    }
+
+    if (isSectionHeaderLine(line)) {
+      if (currentSection && !currentSectionHasTaggedLine) {
+        errors.push(
+          `Line ${currentSectionLineNo}: section header "${currentSection}" must be followed by at least one tagged line`,
+        );
+      }
+
+      currentSection = line.trim();
+      currentSectionLineNo = lineNo;
+      currentSectionHasTaggedLine = false;
+      continue;
+    }
+
+    if (!currentSection) {
+      errors.push(
+        `Line ${lineNo}: section header is required before tagged lines when package/workspace sections are used`,
+      );
+      continue;
+    }
+
+    const err = validateCommitLine(line, lineNo);
+    if (err) {
+      errors.push(err);
+      continue;
+    }
+
+    currentSectionHasTaggedLine = true;
+  }
+
+  if (currentSection && !currentSectionHasTaggedLine) {
+    errors.push(
+      `Line ${currentSectionLineNo}: section header "${currentSection}" must be followed by at least one tagged line`,
+    );
+  }
+
+  return errors;
+}
+
+export function runValidateCommitMsg(options) {
+  const file = getSingle(options, '--file', '');
+  if (!file) {
+    printValidateCommitMsgHelp();
+    process.exit(2);
+  }
+
+  const filePath = path.resolve(file);
+  if (!fs.existsSync(filePath)) {
+    console.error(`Message file not found: ${filePath}`);
+    process.exit(2);
+  }
+
+  const raw = fs.readFileSync(filePath, 'utf8').replace(/\r\n/g, '\n');
+  const lines = raw.endsWith('\n') ? raw.slice(0, -1).split('\n') : raw.split('\n');
+
+  if (lines.length === 0 || (lines.length === 1 && lines[0].trim() === '')) {
+    console.error('Commit message is empty');
+    process.exit(2);
+  }
+
+  const hasSectionHeaders = lines.some((line) => isSectionHeaderLine(line));
+
+  const errors = hasSectionHeaders ? validateSectionFormat(lines) : [];
+  if (!hasSectionHeaders) {
+    for (let i = 0; i < lines.length; i += 1) {
+      const err = validateCommitLine(lines[i], i + 1);
+      if (err) {
+        errors.push(err);
+      }
+    }
+  }
+
+  if (errors.length > 0) {
+    console.error('Commit message validation failed:');
+    for (const err of errors) {
+      console.error(`- ${err}`);
+    }
+    process.exit(1);
+  }
+
+  console.log('Commit message validation passed');
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@produck/agent-toolkit",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "Central CLI toolkit for organization AI execution workflows",
   "type": "module",
   "repository": {
@@ -13,12 +13,14 @@
   },
   "scripts": {
     "prepack": "node ./bin/build-publish-assets.mjs",
+    "coverage": "npm exec --yes -- c8 --reporter=lcov --reporter=html --reporter=text-summary node --test test/index.mjs",
+    "coverage:check": "npm exec --yes -- c8 --check-coverage --lines 100 --functions 100 --branches 100 --statements 100 node --test test/index.mjs",
+    "test": "node --test test/index.mjs",
     "verify": "node ./bin/agent-toolkit.mjs --help && node ./bin/agent-toolkit.mjs preflight --cwd . --require package.json",
     "pack:check": "npm pack --dry-run"
   },
   "files": [
     "bin",
-    "templates",
     "publish-assets"
   ],
   "publishConfig": {
@@ -28,5 +30,5 @@
     "node": ">=18.0.0"
   },
   "license": "MIT",
-  "gitHead": "8fbe9d26ada86a17e4f0444c2342e3904ba0f7f2"
+  "gitHead": "555d39b0f0ed95f59d457230f784c9dafe7b84d2"
 }

package/publish-assets/instructions/produck/00-produck-base.instructions.md

@@ -118,8 +118,11 @@ max_line_length = 80
   be present in repository lint configuration.
 - Apply minimal patching only: keep existing repository/framework structure and
   add the smallest necessary changes.
-- Repository-specific overrides are allowed, but should layer on top of
-  `@produck/eslint-rules` instead of bypassing it.
+- Repository-specific overrides are optional and should be added only when
+  behavior intentionally differs from shared presets.
+- In ESLint flat config, "layer on top" means local override items must appear
+  after shared preset items in exported order.
+- No-op overrides that repeat inherited values should be avoided.
 
 ## Language conventions
 
@@ -144,16 +147,10 @@ max_line_length = 80
 - Recommended local validation:
   `npm exec --package=@produck/agent-toolkit@latest agent-toolkit
 validate-commit-msg --file <message-file>`.
-- Use uppercase tags from this whitelist: `[INIT]`, `[ADD]`, `[REMOVE]`,
-  `[FIX]`, `[REFACTOR]`, `[UPGRADE]`.
-- Legacy tag mapping for migration is `[ADDED]` -> `[ADD]`, `[REMOVED]` ->
-  `[REMOVE]`, and `[FIXED]` -> `[FIX]`.
-- To express content domain, summary may use target syntax: `[TAG] <target>:
-  <summary>`.
-- Allowed targets are `docs`, `test`, `ci`, `deps`, `api`, `schema`, and
-  `infra`.
-- If target syntax is used, target must be wrapped in angle brackets and must be
-  from the allowed target list.
+- Canonical source for commit tag/target whitelists, legacy mapping, and
+  target syntax is
+  `.github/distribution/produck/20-produck-commit.instructions.md`.
+- Do not redefine commit tag or target whitelists in other instruction files.
 - For non-monorepo repositories, use `[TAG] summary` directly (no
   package/workspace section headers).
 - Bracketed commit summaries should be in English
@@ -247,6 +244,9 @@ When CI enforcement is deferred, use manual sync per repository:
    `.github/instructions/produck/`.
 2. Keep repository-specific exceptions in `.github/copilot-instructions.md`.
 3. Validate critical policies manually in each update cycle.
+4. After instruction sync, validate duplicated policy sections remain
+   consistent across instruction files, especially commit tag and target
+   whitelists.
 
 Recommended command:
 

package/publish-assets/instructions/produck/15-produck-workspace.instructions.md

@@ -34,6 +34,12 @@ This document is maintained directly as a downstream-distributable source.
 - Semicolons: Always required (error)
 - Trailing commas: Always in multiline (error)
 - No inline config allowed: `noInlineConfig: true`
+- The listed ESLint rules can be satisfied either by explicit local
+  declarations or by inherited shared presets.
+- Repositories are not required to redeclare rules locally when those rules are
+  already provided by inherited presets.
+- If a repository overrides inherited rules, include only the deltas and
+  document the rationale.
 
 **Usage in packages:**
 

package/publish-assets/instructions/produck/20-produck-commit.instructions.md

@@ -163,6 +163,9 @@ Avoid vague or low-signal messages such as:
 
 Use the local validator before commit:
 
+- Validation is required before both `git commit` and `git commit --amend`.
+- Do not create or amend a commit when validation fails.
+
 - `npm exec --package=@produck/agent-toolkit@latest agent-toolkit
 validate-commit-msg --file <message-file>`
 

package/templates/help/validate-commit-msg.txt

@@ -1,7 +0,0 @@
-Usage:
-  agent-toolkit validate-commit-msg --file <message-file>
-
-Rules:
-  - Every line must start with [TAG]
-  - No empty lines are allowed
-  - Optional target form: [TAG] <target>: <summary>