@procore/data-table 13.3.1 → 13.3.3-next.0

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Change Log
 
+## 13.3.3-next.0
+
+### Patch Changes
+
+- 9f1f67196c: Remove all console statements to prevent them from being reported to bugsnag
+
+## 13.3.2
+
+### Patch Changes
+
+- 3bc44eccc3: Safely remove event listeners when table is destroyed
+
 ## 13.3.1
 
 ### Patch Changes

package/README.md

@@ -4,7 +4,7 @@ The description.
 
 ## Installation
 
-`yarn add @procore/labs-data-table`
+`yarn add @procore/data-table`
 
 ### Dependencies
 

package/dist/legacy/index.js

@@ -1011,6 +1011,43 @@ var rowHeightMap = {
   [rowSize.md]: "medium",
   [rowSize.lg]: "large"
 };
+var Spinner = ({
+  loading,
+  ...rest
+}) => /* @__PURE__ */ React82__default.default.createElement(coreReact.Box, { "data-qa": loading ? "loading" : "loaded", display: "flex-row", flex: 1 }, /* @__PURE__ */ React82__default.default.createElement(coreReact.Spinner, { loading, size: "md", centered: true, ...rest }));
+function isNestedColumnDefinition(Column2) {
+  return "children" in Column2;
+}
+function isNestedColDef(colDef) {
+  if (!colDef.groupId) {
+    return false;
+  }
+  return "groupId" in colDef;
+}
+function getLeafColDefs(columnDefinitions) {
+  return columnDefinitions.flatMap((colDef) => {
+    return isNestedColDef(colDef) ? getLeafColDefs(colDef.children) : [colDef];
+  });
+}
+function isFirstColumn(params) {
+  var _a;
+  const displayedColumns = ((_a = params == null ? void 0 : params.columnApi) == null ? void 0 : _a.getAllDisplayedColumns()) || [];
+  return displayedColumns.length ? displayedColumns[0] === params.column : false;
+}
+function getCheckboxColumn(columnApi) {
+  var _a, _b;
+  const isGrouping = ((_b = (_a = columnApi == null ? void 0 : columnApi.getRowGroupColumns) == null ? void 0 : _a.call(columnApi)) == null ? void 0 : _b.length) !== 0;
+  if (isGrouping) {
+    return null;
+  }
+  const displayedColumns = (columnApi == null ? void 0 : columnApi.getAllDisplayedColumns()) || [];
+  return displayedColumns.length ? displayedColumns[0] : null;
+}
+function removeEventListenerFromGrid(event, listener, gridApi) {
+  if (!gridApi || (gridApi == null ? void 0 : gridApi.destroyCalled))
+    return;
+  gridApi == null ? void 0 : gridApi.removeEventListener(event, listener);
+}
 
 // src/styles.scss
 var styles_exports = {};
@@ -8542,9 +8579,6 @@ var DateFilterRenderer = (props) => {
   if (onServerSideDataRequest) {
     return /* @__PURE__ */ React82__default.default.createElement(ServerSideDateSelectFilterRenderer, { ...props });
   }
-  console.error(
-    "Warning: Date Filters are currently only implemented for the serverside row model"
-  );
   return null;
 };
 var DateFilterTokenText = ({
@@ -53977,9 +54011,6 @@ var LocationFilterRenderer = (props) => {
   if (onServerSideDataRequest) {
     return /* @__PURE__ */ React82__default.default.createElement(ServerSideLocationFilterRenderer, { ...props });
   }
-  console.error(
-    "Warning: Location Filters are currently only implemented for the serverside row model"
-  );
   return null;
 };
 
@@ -54053,8 +54084,16 @@ function useFilterState({
     }
     return () => {
       listenersEnabled.current = false;
-      gridApi == null ? void 0 : gridApi.removeEventListener("filterChanged", filterEventFunction);
-      gridApi == null ? void 0 : gridApi.removeEventListener("rowDataUpdated", filterEventFunction);
+      removeEventListenerFromGrid(
+        "filterChanged",
+        filterEventFunction,
+        gridApi
+      );
+      removeEventListenerFromGrid(
+        "rowDataUpdated",
+        filterEventFunction,
+        gridApi
+      );
     };
   }, [gridApi, columnDefinitions]);
   return { allAvailableFilters, changeFilterValue, filterableColumns };
@@ -54166,9 +54205,6 @@ var MultiSelectFilterRenderer = (props) => {
   const { onServerSideDataRequest } = useInternalTableContext();
   const Renderer13 = onServerSideDataRequest ? ServerSideMultiSelectFilterRenderer : ClientSideMultiSelectFilterRenderer;
   if (isNumberFilterModel(value)) {
-    console.warn(
-      "a value was set that is not compatible with this MultiSelectFilterRenderer"
-    );
     return null;
   }
   return /* @__PURE__ */ React82__default.default.createElement(Renderer13, { value, ...otherProps });
@@ -54520,9 +54556,6 @@ var ServerSideFilter = ({
     value
   } = useServerSideFilter({ columnDefinition });
   if (columnDefinition === void 0 || columnDefinition === null) {
-    console.warn(
-      `Unable to find the columnDefinition (${columnDefinition}) for fieldName: ${fieldName}`
-    );
     return null;
   }
   return /* @__PURE__ */ React82__default.default.createElement(
@@ -54548,38 +54581,6 @@ var ServerSideFilter = ({
     )
   );
 };
-var Spinner2 = ({
-  loading,
-  ...rest
-}) => /* @__PURE__ */ React82__default.default.createElement(coreReact.Box, { "data-qa": loading ? "loading" : "loaded", display: "flex-row", flex: 1 }, /* @__PURE__ */ React82__default.default.createElement(coreReact.Spinner, { loading, size: "md", centered: true, ...rest }));
-function isNestedColumnDefinition(Column2) {
-  return "children" in Column2;
-}
-function isNestedColDef(colDef) {
-  if (!colDef.groupId) {
-    return false;
-  }
-  return "groupId" in colDef;
-}
-function getLeafColDefs(columnDefinitions) {
-  return columnDefinitions.flatMap((colDef) => {
-    return isNestedColDef(colDef) ? getLeafColDefs(colDef.children) : [colDef];
-  });
-}
-function isFirstColumn(params) {
-  var _a;
-  const displayedColumns = ((_a = params == null ? void 0 : params.columnApi) == null ? void 0 : _a.getAllDisplayedColumns()) || [];
-  return displayedColumns.length ? displayedColumns[0] === params.column : false;
-}
-function getCheckboxColumn(columnApi) {
-  var _a, _b;
-  const isGrouping = ((_b = (_a = columnApi == null ? void 0 : columnApi.getRowGroupColumns) == null ? void 0 : _a.call(columnApi)) == null ? void 0 : _b.length) !== 0;
-  if (isGrouping) {
-    return null;
-  }
-  const displayedColumns = (columnApi == null ? void 0 : columnApi.getAllDisplayedColumns()) || [];
-  return displayedColumns.length ? displayedColumns[0] : null;
-}
 
 // src/utils/transformers.ts
 var emptyObject = {};
@@ -55294,7 +55295,7 @@ function ClientSideRowCheckbox(props) {
   React82.useEffect(() => {
     props.api.addEventListener("rowSelected", handleRowSelection);
     return () => {
-      props.api.removeEventListener("rowSelected", handleRowSelection);
+      removeEventListenerFromGrid("rowSelected", handleRowSelection, props.api);
     };
   }, []);
   return /* @__PURE__ */ React82__default.default.createElement(coreReact.Box, { paddingRight: "md" }, /* @__PURE__ */ React82__default.default.createElement(
@@ -55408,7 +55409,11 @@ function GroupCaret(props) {
     props.api.addEventListener("rowGroupOpened", handleRowGroupToggle);
     return () => {
       mounted.current = false;
-      props.api.removeEventListener("rowGroupOpened", handleRowGroupToggle);
+      removeEventListenerFromGrid(
+        "rowGroupOpened",
+        handleRowGroupToggle,
+        props.api
+      );
     };
   }, []);
   return /* @__PURE__ */ React82__default.default.createElement(coreReact.Box, { className: AutoGroupCell_default.expandableCaret }, props.node.isExpandable() && /* @__PURE__ */ React82__default.default.createElement(
@@ -55435,7 +55440,11 @@ var AutoGroupCellRenderer = (props) => {
   React82.useEffect(() => {
     props.api.addEventListener("cellValueChanged", handleCellValueChange);
     return () => {
-      props.api.removeEventListener("cellValueChanged", handleCellValueChange);
+      removeEventListenerFromGrid(
+        "cellValueChanged",
+        handleCellValueChange,
+        props.api
+      );
     };
   }, []);
   const adjustedLevel = props.node.footer ? props.node.level + 1 : props.node.level;
@@ -56297,7 +56306,7 @@ var GenericHeaderRenderer = (props) => {
     props.api.addEventListener("columnMoved", calculatePosition);
     calculatePosition();
     return () => {
-      props.api.removeEventListener("columnMoved", calculatePosition);
+      removeEventListenerFromGrid("columnMoved", calculatePosition, props.api);
     };
   }, []);
   const onSortToggled = (event) => {
@@ -56376,8 +56385,11 @@ var GenericHeaderRenderer = (props) => {
     };
     (_a2 = props.api) == null ? void 0 : _a2.addEventListener("expandOrCollapseAll", onExpandAllChange);
     return () => {
-      var _a3;
-      (_a3 = props.api) == null ? void 0 : _a3.removeEventListener("expandOrCollapseAll", onExpandAllChange);
+      removeEventListenerFromGrid(
+        "expandOrCollapseAll",
+        onExpandAllChange,
+        props.api
+      );
     };
   }, [props.api]);
   React82__default.default.useEffect(() => {
@@ -56468,7 +56480,11 @@ var GenericHeaderRenderer = (props) => {
     props.api.addEventListener(selectionChanged, onSelectionChanged);
     onSelectionChanged();
     return () => {
-      props.api.removeEventListener(selectionChanged, onSelectionChanged);
+      removeEventListenerFromGrid(
+        selectionChanged,
+        onSelectionChanged,
+        props.api
+      );
     };
   }, [isFirstColumn2, selectAll]);
   const { ref, isOverflowing, recalculate } = useOverflowObserver();
@@ -56480,8 +56496,8 @@ var GenericHeaderRenderer = (props) => {
     props.api.addEventListener("cellMouseOver", handler);
     props.api.addEventListener("columnResized", handler);
     return () => {
-      props.api.removeEventListener("cellMouseOver", handler);
-      props.api.removeEventListener("columnResized", handler);
+      removeEventListenerFromGrid("cellMouseOver", handler, props.api);
+      removeEventListenerFromGrid("columnResized", handler, props.api);
     };
   }, []);
   React82__default.default.useEffect(() => {
@@ -56507,8 +56523,16 @@ var GenericHeaderRenderer = (props) => {
     props.api.addEventListener(selectionChanged, updateSelectAllCheckbox);
     props.api.addEventListener(paginationChanged, updateSelectAllCheckbox);
     return () => {
-      props.api.removeEventListener(selectionChanged, updateSelectAllCheckbox);
-      props.api.removeEventListener(paginationChanged, updateSelectAllCheckbox);
+      removeEventListenerFromGrid(
+        selectionChanged,
+        updateSelectAllCheckbox,
+        props.api
+      );
+      removeEventListenerFromGrid(
+        paginationChanged,
+        updateSelectAllCheckbox,
+        props.api
+      );
     };
   }, [isFirstColumn2, props.selectionSSREnabled, props.api, onSSDR]);
   const toggleSelectAll = React82__default.default.useCallback(() => {
@@ -56719,7 +56743,7 @@ function CustomLoader(params) {
         level: params.node.level,
         lastRowInGroup: params.node === groupNodes.last
       }
-    ), /* @__PURE__ */ React82__default.default.createElement(Spinner2, { loading: true, size: "sm" }), /* @__PURE__ */ React82__default.default.createElement(coreReact.Box, { paddingLeft: "sm" }, /* @__PURE__ */ React82__default.default.createElement(coreReact.Typography, { color: "gray15", italic: true, intent: "small" }, I18n.t(
+    ), /* @__PURE__ */ React82__default.default.createElement(Spinner, { loading: true, size: "sm" }), /* @__PURE__ */ React82__default.default.createElement(coreReact.Box, { paddingLeft: "sm" }, /* @__PURE__ */ React82__default.default.createElement(coreReact.Typography, { color: "gray15", italic: true, intent: "small" }, I18n.t(
       `dataTable.loading.${params.node === groupNodes.first ? "initial" : "secondary"}`
     ))));
   }
@@ -56729,7 +56753,7 @@ var DefaultFrameworkComponents = {
   agColumnHeader: GenericHeaderRenderer,
   agLoadingCellRenderer: CustomLoader,
   agColumnGroupHeader: GenericColumnGroupHeader,
-  loadingOverlayRenderer: Spinner2,
+  loadingOverlayRenderer: Spinner,
   emptyStateRenderer: EmptyState
 };
 function getFrameworkComponents(headerMenuConfig, onSelectAll, selectionSSREnabled) {
@@ -56893,9 +56917,8 @@ var MultiSelectCellRenderer = withDataTableRenderer(
 // src/FilterRenderers/useServerSideFilterStorage.tsx
 var emptyArray2 = [];
 var emptyObj = {};
-function logNoOp(text, returns) {
+function logNoOp(_text, returns) {
   return function() {
-    console.log("No-op", text);
     return returns;
   };
 }
@@ -57073,12 +57096,12 @@ var defaultServerSideFiltersContext = {
   getSelected: logNoOp("ServerSideFiltersContext getSelected", emptyObj),
   hasDefinedFilters: false,
   hasSelectedFilters: false,
-  onChangeFilterValue: logNoOp("ServerSideFiltersContext onChangeFilterValue"),
-  onClearAllFilters: logNoOp("ServerSideFiltersContext onClearAllFilters"),
-  onClearFilter: logNoOp("ServerSideFiltersContext onClearFilter"),
+  onChangeFilterValue: logNoOp(),
+  onClearAllFilters: logNoOp(),
+  onClearFilter: logNoOp(),
   possibleFilters: emptyArray2,
   selectedFilters: emptyObj,
-  setSelectedFilters: logNoOp("ServerSideFiltersContext setSelectedFilters"),
+  setSelectedFilters: logNoOp(),
   waitForStoredOptions: logNoOp(
     "ServerSideFiltersContext waitForStoredOptions",
     true
@@ -58876,12 +58899,18 @@ var useRowSelectionState = () => {
   const { gridApi, rowSelectionRef } = useInternalTableContext();
   React82__default.default.useEffect(() => {
     function selectionEventFunction() {
-      setSelectedRows(getSelectedRows({ gridApi, rowSelectionRef }));
+      if (!(gridApi == null ? void 0 : gridApi.destroyCalled)) {
+        setSelectedRows(getSelectedRows({ gridApi, rowSelectionRef }));
+      }
     }
     selectionEventFunction();
     gridApi == null ? void 0 : gridApi.addEventListener("selectionChanged", selectionEventFunction);
     return () => {
-      gridApi == null ? void 0 : gridApi.removeEventListener("selectionChanged", selectionEventFunction);
+      removeEventListenerFromGrid(
+        "selectionChanged",
+        selectionEventFunction,
+        gridApi
+      );
     };
   }, [gridApi]);
   return selectedRows;
@@ -76718,9 +76747,6 @@ var BulkEditInput = (props) => {
           }
         );
       } else {
-        console.warn(
-          `@procore/labs-data-table: Unable to find the field for ${props.editor}. Will fallback to a Form.Text.`
-        );
         return defaultField;
       }
   }
@@ -77194,9 +77220,10 @@ var ConfigurationColumns = React82__default.default.forwardRef(
         onDisplayedColumnsChanged
       );
       return () => {
-        gridApi == null ? void 0 : gridApi.removeEventListener(
+        removeEventListenerFromGrid(
           "displayedColumnsChanged",
-          onDisplayedColumnsChanged
+          onDisplayedColumnsChanged,
+          gridApi
         );
       };
     }, [gridApi, colDefs]);
@@ -77369,16 +77396,11 @@ function groupFiltersByGroupName(props) {
   }
   const filterGroupNames = filterGroups == null ? void 0 : filterGroups.map((filterGroup) => filterGroup.name);
   let filterIndex = 0;
-  return ramda.groupBy((filterRecord) => {
+  return ramda.groupBy((_filterRecord) => {
     const filterProps = availableFilterProps[filterIndex];
     const groupName = filterProps == null ? void 0 : filterProps.groupName;
     filterIndex++;
     if (groupName && !(filterGroupNames == null ? void 0 : filterGroupNames.includes(groupName))) {
-      console.warn(
-        'filter "%s" is being associated with a filter group "%s" that does not exist',
-        filterRecord.field,
-        groupName
-      );
       return FILTER_GROUP_NO_KEY;
     }
     return (groupName == null ? void 0 : groupName.toString()) || FILTER_GROUP_NO_KEY;
@@ -77494,7 +77516,6 @@ function FilterListItems(props) {
       "data-qa": "data-table-possible-filters-list"
     },
     filtersInGroup.map((filterRecord) => {
-      console.log("filterRecord ", filterRecord);
       const { columnDefinition } = filterRecord;
       if (!columnDefinition) {
         return null;
@@ -77554,10 +77575,6 @@ function FiltersList(props) {
     },
     filterGroups == null ? void 0 : filterGroups.map((group) => {
       if (!filterGroupsMap[group.name]) {
-        console.warn(
-          'filters group "%s" is not associated with any filter',
-          group.name
-        );
         return null;
       }
       return /* @__PURE__ */ React82__default.default.createElement(FilterGroupWrapper, { filterGroup: group, key: group.name }, /* @__PURE__ */ React82__default.default.createElement(
@@ -78065,9 +78082,10 @@ var RowGroupSelector = ({ localeText }) => {
       onDisplayedColumnsChanged
     );
     return () => {
-      gridApi == null ? void 0 : gridApi.removeEventListener(
+      removeEventListenerFromGrid(
         "displayedColumnsChanged",
-        onDisplayedColumnsChanged
+        onDisplayedColumnsChanged,
+        gridApi
       );
     };
   }, [gridApi]);
@@ -78289,12 +78307,6 @@ var buildDetailRowsConfig = ({
   if (detailRowConfigs === void 0 || !detailRowConfigs[0]) {
     return {};
   }
-  if (detailRowConfigs.length > 1) {
-    console.warn(`
-      DataTable: "detailRowConfigs" of length ${detailRowConfigs.length} was provided, while it only supports an array of length 1.
-      Please use "detailRowConfig", as "detailRowConfigs" is deprecated.
-    `);
-  }
   return buildDetailRowsConfig_(detailRowConfigs[0], {
     defaultColDef,
     frameworkComponents,
@@ -81376,7 +81388,6 @@ var DataTable = ({
   const missingTranslation = internalI18n.missingTranslation.bind(internalI18n);
   internalI18n.missingTranslation = (scope2, options) => {
     if (scope2.match(/core\.dataTable/)) {
-      console.warn(`[DataTable] Missing Translation: ${scope2}`);
       return "";
     }
     if (dataTableTranslationKeys.includes(scope2)) {
@@ -81750,7 +81761,9 @@ var Table = (props) => {
         maxHeight = nodeHeight;
       }
     });
-    gridApi == null ? void 0 : gridApi.setHeaderHeight(maxHeight);
+    if (!(gridApi == null ? void 0 : gridApi.destroyCalled)) {
+      gridApi == null ? void 0 : gridApi.setHeaderHeight(maxHeight);
+    }
   }
   React82__default.default.useEffect(() => {
     var _a2, _b2;
@@ -81763,7 +81776,11 @@ var Table = (props) => {
       gridApi.addEventListener("firstDataRendered", setHeaderHeight);
       setHeaderHeight();
       return () => {
-        gridApi.removeEventListener("firstDataRendered", setHeaderHeight);
+        removeEventListenerFromGrid(
+          "firstDataRendered",
+          setHeaderHeight,
+          gridApi
+        );
       };
     }
     return;
@@ -81835,7 +81852,6 @@ var Table = (props) => {
   ]);
   React82__default.default.useEffect(() => {
     if (frameworkComponentsInitialized.current === true) {
-      console.warn("Don't update custom cells after the initial render.");
       setFrameworkComponents(
         getFrameworkComponents(
           headerMenuConfig,
@@ -82005,7 +82021,10 @@ var Table = (props) => {
   }, [internalTableContext.onTableConfigChange]);
   const onDisplayedColumnsChanged = React82__default.default.useCallback(
     (event) => {
+      var _a2;
       if (props.onRowDragEnd) {
+        if ((_a2 = event.columnApi) == null ? void 0 : _a2.destroyCalled)
+          return;
         const firstVisibleColumn = event.columnApi.getAllGridColumns().find((col) => col.isVisible());
         if (!(firstVisibleColumn == null ? void 0 : firstVisibleColumn.getColDef().rowDrag)) {
           adjustRowDragIcon(event.api, event.columnApi);
@@ -82307,7 +82326,7 @@ var Table = (props) => {
     props.UNSAFE_internalAGGridOverrides ?? {}
   );
   return /* @__PURE__ */ React82__default.default.createElement(
-    Spinner2,
+    Spinner,
     {
       loading: loadingStatus.loading,
       label: loadingStatus.message,
@@ -82474,7 +82493,11 @@ var TablePagination = ({
     }
     gridApi == null ? void 0 : gridApi.addEventListener("paginationChanged", onPaginationChanged);
     return () => {
-      gridApi == null ? void 0 : gridApi.removeEventListener("paginationChanged", onPaginationChanged);
+      removeEventListenerFromGrid(
+        "paginationChanged",
+        onPaginationChanged,
+        gridApi
+      );
     };
   }, []);
   return /* @__PURE__ */ React82__default.default.createElement(
@@ -82841,9 +82864,6 @@ var QuickDateFilterRenderer = (props) => {
   if (onServerSideDataRequest) {
     return /* @__PURE__ */ React82__default.default.createElement(ServerSideQuickDateFilterRenderer, { ...props });
   }
-  console.error(
-    "Warning: Date Filters are currently only implemented for the serverside row model"
-  );
   return null;
 };
 var dateInputLocales = {
@@ -82940,9 +82960,6 @@ var LocationQuickFilterOverlay = React82__default.default.forwardRef(
     value
   }, ref) => {
     if (value && !Array.isArray(value)) {
-      console.warn(
-        "a value was set that is not compatible with this LocationQuickFilterRenderer"
-      );
       return null;
     }
     const [items, setItems] = React82__default.default.useState(options);