@procore/data-table 13.3.1 → 13.3.2

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change Log
 
+## 13.3.2
+
+### Patch Changes
+
+- 3bc44eccc3: Safely remove event listeners when table is destroyed
+
 ## 13.3.1
 
 ### Patch Changes

package/README.md

@@ -4,7 +4,7 @@ The description.
 
 ## Installation
 
-`yarn add @procore/labs-data-table`
+`yarn add @procore/data-table`
 
 ### Dependencies
 

package/dist/legacy/index.js

@@ -1011,6 +1011,43 @@ var rowHeightMap = {
   [rowSize.md]: "medium",
   [rowSize.lg]: "large"
 };
+var Spinner = ({
+  loading,
+  ...rest
+}) => /* @__PURE__ */ React82__default.default.createElement(coreReact.Box, { "data-qa": loading ? "loading" : "loaded", display: "flex-row", flex: 1 }, /* @__PURE__ */ React82__default.default.createElement(coreReact.Spinner, { loading, size: "md", centered: true, ...rest }));
+function isNestedColumnDefinition(Column2) {
+  return "children" in Column2;
+}
+function isNestedColDef(colDef) {
+  if (!colDef.groupId) {
+    return false;
+  }
+  return "groupId" in colDef;
+}
+function getLeafColDefs(columnDefinitions) {
+  return columnDefinitions.flatMap((colDef) => {
+    return isNestedColDef(colDef) ? getLeafColDefs(colDef.children) : [colDef];
+  });
+}
+function isFirstColumn(params) {
+  var _a;
+  const displayedColumns = ((_a = params == null ? void 0 : params.columnApi) == null ? void 0 : _a.getAllDisplayedColumns()) || [];
+  return displayedColumns.length ? displayedColumns[0] === params.column : false;
+}
+function getCheckboxColumn(columnApi) {
+  var _a, _b;
+  const isGrouping = ((_b = (_a = columnApi == null ? void 0 : columnApi.getRowGroupColumns) == null ? void 0 : _a.call(columnApi)) == null ? void 0 : _b.length) !== 0;
+  if (isGrouping) {
+    return null;
+  }
+  const displayedColumns = (columnApi == null ? void 0 : columnApi.getAllDisplayedColumns()) || [];
+  return displayedColumns.length ? displayedColumns[0] : null;
+}
+function removeEventListenerFromGrid(event, listener, gridApi) {
+  if (!gridApi || (gridApi == null ? void 0 : gridApi.destroyCalled))
+    return;
+  gridApi == null ? void 0 : gridApi.removeEventListener(event, listener);
+}
 
 // src/styles.scss
 var styles_exports = {};
@@ -54053,8 +54090,16 @@ function useFilterState({
     }
     return () => {
       listenersEnabled.current = false;
-      gridApi == null ? void 0 : gridApi.removeEventListener("filterChanged", filterEventFunction);
-      gridApi == null ? void 0 : gridApi.removeEventListener("rowDataUpdated", filterEventFunction);
+      removeEventListenerFromGrid(
+        "filterChanged",
+        filterEventFunction,
+        gridApi
+      );
+      removeEventListenerFromGrid(
+        "rowDataUpdated",
+        filterEventFunction,
+        gridApi
+      );
     };
   }, [gridApi, columnDefinitions]);
   return { allAvailableFilters, changeFilterValue, filterableColumns };
@@ -54548,38 +54593,6 @@ var ServerSideFilter = ({
     )
   );
 };
-var Spinner2 = ({
-  loading,
-  ...rest
-}) => /* @__PURE__ */ React82__default.default.createElement(coreReact.Box, { "data-qa": loading ? "loading" : "loaded", display: "flex-row", flex: 1 }, /* @__PURE__ */ React82__default.default.createElement(coreReact.Spinner, { loading, size: "md", centered: true, ...rest }));
-function isNestedColumnDefinition(Column2) {
-  return "children" in Column2;
-}
-function isNestedColDef(colDef) {
-  if (!colDef.groupId) {
-    return false;
-  }
-  return "groupId" in colDef;
-}
-function getLeafColDefs(columnDefinitions) {
-  return columnDefinitions.flatMap((colDef) => {
-    return isNestedColDef(colDef) ? getLeafColDefs(colDef.children) : [colDef];
-  });
-}
-function isFirstColumn(params) {
-  var _a;
-  const displayedColumns = ((_a = params == null ? void 0 : params.columnApi) == null ? void 0 : _a.getAllDisplayedColumns()) || [];
-  return displayedColumns.length ? displayedColumns[0] === params.column : false;
-}
-function getCheckboxColumn(columnApi) {
-  var _a, _b;
-  const isGrouping = ((_b = (_a = columnApi == null ? void 0 : columnApi.getRowGroupColumns) == null ? void 0 : _a.call(columnApi)) == null ? void 0 : _b.length) !== 0;
-  if (isGrouping) {
-    return null;
-  }
-  const displayedColumns = (columnApi == null ? void 0 : columnApi.getAllDisplayedColumns()) || [];
-  return displayedColumns.length ? displayedColumns[0] : null;
-}
 
 // src/utils/transformers.ts
 var emptyObject = {};
@@ -55294,7 +55307,7 @@ function ClientSideRowCheckbox(props) {
   React82.useEffect(() => {
     props.api.addEventListener("rowSelected", handleRowSelection);
     return () => {
-      props.api.removeEventListener("rowSelected", handleRowSelection);
+      removeEventListenerFromGrid("rowSelected", handleRowSelection, props.api);
     };
   }, []);
   return /* @__PURE__ */ React82__default.default.createElement(coreReact.Box, { paddingRight: "md" }, /* @__PURE__ */ React82__default.default.createElement(
@@ -55408,7 +55421,11 @@ function GroupCaret(props) {
     props.api.addEventListener("rowGroupOpened", handleRowGroupToggle);
     return () => {
       mounted.current = false;
-      props.api.removeEventListener("rowGroupOpened", handleRowGroupToggle);
+      removeEventListenerFromGrid(
+        "rowGroupOpened",
+        handleRowGroupToggle,
+        props.api
+      );
     };
   }, []);
   return /* @__PURE__ */ React82__default.default.createElement(coreReact.Box, { className: AutoGroupCell_default.expandableCaret }, props.node.isExpandable() && /* @__PURE__ */ React82__default.default.createElement(
@@ -55435,7 +55452,11 @@ var AutoGroupCellRenderer = (props) => {
   React82.useEffect(() => {
     props.api.addEventListener("cellValueChanged", handleCellValueChange);
     return () => {
-      props.api.removeEventListener("cellValueChanged", handleCellValueChange);
+      removeEventListenerFromGrid(
+        "cellValueChanged",
+        handleCellValueChange,
+        props.api
+      );
     };
   }, []);
   const adjustedLevel = props.node.footer ? props.node.level + 1 : props.node.level;
@@ -56297,7 +56318,7 @@ var GenericHeaderRenderer = (props) => {
     props.api.addEventListener("columnMoved", calculatePosition);
     calculatePosition();
     return () => {
-      props.api.removeEventListener("columnMoved", calculatePosition);
+      removeEventListenerFromGrid("columnMoved", calculatePosition, props.api);
     };
   }, []);
   const onSortToggled = (event) => {
@@ -56376,8 +56397,11 @@ var GenericHeaderRenderer = (props) => {
     };
     (_a2 = props.api) == null ? void 0 : _a2.addEventListener("expandOrCollapseAll", onExpandAllChange);
     return () => {
-      var _a3;
-      (_a3 = props.api) == null ? void 0 : _a3.removeEventListener("expandOrCollapseAll", onExpandAllChange);
+      removeEventListenerFromGrid(
+        "expandOrCollapseAll",
+        onExpandAllChange,
+        props.api
+      );
     };
   }, [props.api]);
   React82__default.default.useEffect(() => {
@@ -56468,7 +56492,11 @@ var GenericHeaderRenderer = (props) => {
     props.api.addEventListener(selectionChanged, onSelectionChanged);
     onSelectionChanged();
     return () => {
-      props.api.removeEventListener(selectionChanged, onSelectionChanged);
+      removeEventListenerFromGrid(
+        selectionChanged,
+        onSelectionChanged,
+        props.api
+      );
     };
   }, [isFirstColumn2, selectAll]);
   const { ref, isOverflowing, recalculate } = useOverflowObserver();
@@ -56480,8 +56508,8 @@ var GenericHeaderRenderer = (props) => {
     props.api.addEventListener("cellMouseOver", handler);
     props.api.addEventListener("columnResized", handler);
     return () => {
-      props.api.removeEventListener("cellMouseOver", handler);
-      props.api.removeEventListener("columnResized", handler);
+      removeEventListenerFromGrid("cellMouseOver", handler, props.api);
+      removeEventListenerFromGrid("columnResized", handler, props.api);
     };
   }, []);
   React82__default.default.useEffect(() => {
@@ -56507,8 +56535,16 @@ var GenericHeaderRenderer = (props) => {
     props.api.addEventListener(selectionChanged, updateSelectAllCheckbox);
     props.api.addEventListener(paginationChanged, updateSelectAllCheckbox);
     return () => {
-      props.api.removeEventListener(selectionChanged, updateSelectAllCheckbox);
-      props.api.removeEventListener(paginationChanged, updateSelectAllCheckbox);
+      removeEventListenerFromGrid(
+        selectionChanged,
+        updateSelectAllCheckbox,
+        props.api
+      );
+      removeEventListenerFromGrid(
+        paginationChanged,
+        updateSelectAllCheckbox,
+        props.api
+      );
     };
   }, [isFirstColumn2, props.selectionSSREnabled, props.api, onSSDR]);
   const toggleSelectAll = React82__default.default.useCallback(() => {
@@ -56719,7 +56755,7 @@ function CustomLoader(params) {
         level: params.node.level,
         lastRowInGroup: params.node === groupNodes.last
       }
-    ), /* @__PURE__ */ React82__default.default.createElement(Spinner2, { loading: true, size: "sm" }), /* @__PURE__ */ React82__default.default.createElement(coreReact.Box, { paddingLeft: "sm" }, /* @__PURE__ */ React82__default.default.createElement(coreReact.Typography, { color: "gray15", italic: true, intent: "small" }, I18n.t(
+    ), /* @__PURE__ */ React82__default.default.createElement(Spinner, { loading: true, size: "sm" }), /* @__PURE__ */ React82__default.default.createElement(coreReact.Box, { paddingLeft: "sm" }, /* @__PURE__ */ React82__default.default.createElement(coreReact.Typography, { color: "gray15", italic: true, intent: "small" }, I18n.t(
       `dataTable.loading.${params.node === groupNodes.first ? "initial" : "secondary"}`
     ))));
   }
@@ -56729,7 +56765,7 @@ var DefaultFrameworkComponents = {
   agColumnHeader: GenericHeaderRenderer,
   agLoadingCellRenderer: CustomLoader,
   agColumnGroupHeader: GenericColumnGroupHeader,
-  loadingOverlayRenderer: Spinner2,
+  loadingOverlayRenderer: Spinner,
   emptyStateRenderer: EmptyState
 };
 function getFrameworkComponents(headerMenuConfig, onSelectAll, selectionSSREnabled) {
@@ -58876,12 +58912,18 @@ var useRowSelectionState = () => {
   const { gridApi, rowSelectionRef } = useInternalTableContext();
   React82__default.default.useEffect(() => {
     function selectionEventFunction() {
-      setSelectedRows(getSelectedRows({ gridApi, rowSelectionRef }));
+      if (!(gridApi == null ? void 0 : gridApi.destroyCalled)) {
+        setSelectedRows(getSelectedRows({ gridApi, rowSelectionRef }));
+      }
     }
     selectionEventFunction();
     gridApi == null ? void 0 : gridApi.addEventListener("selectionChanged", selectionEventFunction);
     return () => {
-      gridApi == null ? void 0 : gridApi.removeEventListener("selectionChanged", selectionEventFunction);
+      removeEventListenerFromGrid(
+        "selectionChanged",
+        selectionEventFunction,
+        gridApi
+      );
     };
   }, [gridApi]);
   return selectedRows;
@@ -76719,7 +76761,7 @@ var BulkEditInput = (props) => {
         );
       } else {
         console.warn(
-          `@procore/labs-data-table: Unable to find the field for ${props.editor}. Will fallback to a Form.Text.`
+          `@procore/data-table: Unable to find the field for ${props.editor}. Will fallback to a Form.Text.`
         );
         return defaultField;
       }
@@ -77194,9 +77236,10 @@ var ConfigurationColumns = React82__default.default.forwardRef(
         onDisplayedColumnsChanged
       );
       return () => {
-        gridApi == null ? void 0 : gridApi.removeEventListener(
+        removeEventListenerFromGrid(
           "displayedColumnsChanged",
-          onDisplayedColumnsChanged
+          onDisplayedColumnsChanged,
+          gridApi
         );
       };
     }, [gridApi, colDefs]);
@@ -78065,9 +78108,10 @@ var RowGroupSelector = ({ localeText }) => {
       onDisplayedColumnsChanged
     );
     return () => {
-      gridApi == null ? void 0 : gridApi.removeEventListener(
+      removeEventListenerFromGrid(
         "displayedColumnsChanged",
-        onDisplayedColumnsChanged
+        onDisplayedColumnsChanged,
+        gridApi
       );
     };
   }, [gridApi]);
@@ -81750,7 +81794,9 @@ var Table = (props) => {
         maxHeight = nodeHeight;
       }
     });
-    gridApi == null ? void 0 : gridApi.setHeaderHeight(maxHeight);
+    if (!(gridApi == null ? void 0 : gridApi.destroyCalled)) {
+      gridApi == null ? void 0 : gridApi.setHeaderHeight(maxHeight);
+    }
   }
   React82__default.default.useEffect(() => {
     var _a2, _b2;
@@ -81763,7 +81809,11 @@ var Table = (props) => {
       gridApi.addEventListener("firstDataRendered", setHeaderHeight);
       setHeaderHeight();
       return () => {
-        gridApi.removeEventListener("firstDataRendered", setHeaderHeight);
+        removeEventListenerFromGrid(
+          "firstDataRendered",
+          setHeaderHeight,
+          gridApi
+        );
       };
     }
     return;
@@ -82005,7 +82055,10 @@ var Table = (props) => {
   }, [internalTableContext.onTableConfigChange]);
   const onDisplayedColumnsChanged = React82__default.default.useCallback(
     (event) => {
+      var _a2;
       if (props.onRowDragEnd) {
+        if ((_a2 = event.columnApi) == null ? void 0 : _a2.destroyCalled)
+          return;
         const firstVisibleColumn = event.columnApi.getAllGridColumns().find((col) => col.isVisible());
         if (!(firstVisibleColumn == null ? void 0 : firstVisibleColumn.getColDef().rowDrag)) {
           adjustRowDragIcon(event.api, event.columnApi);
@@ -82307,7 +82360,7 @@ var Table = (props) => {
     props.UNSAFE_internalAGGridOverrides ?? {}
   );
   return /* @__PURE__ */ React82__default.default.createElement(
-    Spinner2,
+    Spinner,
     {
       loading: loadingStatus.loading,
       label: loadingStatus.message,
@@ -82474,7 +82527,11 @@ var TablePagination = ({
     }
     gridApi == null ? void 0 : gridApi.addEventListener("paginationChanged", onPaginationChanged);
     return () => {
-      gridApi == null ? void 0 : gridApi.removeEventListener("paginationChanged", onPaginationChanged);
+      removeEventListenerFromGrid(
+        "paginationChanged",
+        onPaginationChanged,
+        gridApi
+      );
     };
   }, []);
   return /* @__PURE__ */ React82__default.default.createElement(