@proconnect-gouv/proconnect.identite 3.0.0 → 4.0.0

package/src/managers/certification/process-certification-dirigeant.test.ts

@@ -1,6 +1,12 @@
 //
 
 import { IdentityVectorSchema } from "#src/types";
+import {
+  api_entreprise_mock_client,
+  api_insee_mock_client,
+  api_registre_national_entreprises_mock_client,
+  context,
+} from "#testing";
 import {
   AmberleyVailFranceConnectUserInfo,
   LiElJonsonFranceConnectUserInfo,
@@ -32,19 +38,14 @@ import { processCertificationDirigeantFactory } from "./process-certification-di
 
 //
 
+const processCertificationDirigeant =
+  processCertificationDirigeantFactory(context);
+
 describe("processCertificationDirigeantFactory", () => {
   it("should recognize a user as executive of a auto-entrepreneur", async () => {
-    const processCertificationDirigeant = processCertificationDirigeantFactory({
-      ApiEntrepriseClient: {
-        findMandatairesSociauxBySiren: () => Promise.reject(new Error("💣")),
-      },
-      RegistreNationalEntreprisesApiClient: {
-        findPouvoirsBySiren: () => Promise.reject(new Error("💣")),
-      },
-      InseeApiClient: {
-        findBySiren: () => Promise.resolve(LiElJonsonEstablishment),
-      },
-    });
+    api_insee_mock_client.findBySiren.mock.mockImplementationOnce(() =>
+      Promise.resolve(LiElJonsonEstablishment),
+    );
 
     const certificationDirigeantResult = await processCertificationDirigeant(
       rogal_dorn_org_info,
@@ -70,18 +71,9 @@ describe("processCertificationDirigeantFactory", () => {
   });
 
   it("should recognize a foreign user as executive of a auto-entrepreneur", async () => {
-    const processCertificationDirigeant = processCertificationDirigeantFactory({
-      ApiEntrepriseClient: {
-        findMandatairesSociauxBySiren: () => Promise.reject(new Error("💣")),
-      },
-      RegistreNationalEntreprisesApiClient: {
-        findPouvoirsBySiren: () => Promise.reject(new Error("💣")),
-      },
-      InseeApiClient: {
-        findBySiren: () => Promise.resolve(RogalDornEstablishment),
-      },
-    });
-
+    api_insee_mock_client.findBySiren.mock.mockImplementationOnce(() =>
+      Promise.resolve(RogalDornEstablishment),
+    );
     const certificationDirigeantResult = await processCertificationDirigeant(
       rogal_dorn_org_info,
       RogalDornFranceConnectUserInfo,
@@ -106,17 +98,9 @@ describe("processCertificationDirigeantFactory", () => {
   });
 
   it("should not match another mandataire", async () => {
-    const processCertificationDirigeant = processCertificationDirigeantFactory({
-      ApiEntrepriseClient: {
-        findMandatairesSociauxBySiren: () => Promise.reject(new Error("💣")),
-      },
-      RegistreNationalEntreprisesApiClient: {
-        findPouvoirsBySiren: () => Promise.reject(new Error("💣")),
-      },
-      InseeApiClient: {
-        findBySiren: () => Promise.resolve(LiElJonsonEstablishment),
-      },
-    });
+    api_insee_mock_client.findBySiren.mock.mockImplementationOnce(() =>
+      Promise.resolve(LiElJonsonEstablishment),
+    );
 
     const certificationDirigeantResult = await processCertificationDirigeant(
       rogal_dorn_org_info,
@@ -136,18 +120,9 @@ describe("processCertificationDirigeantFactory", () => {
   });
 
   it("should match Rogal Dorn among the executive of Papillon in RNE", async () => {
-    const processCertificationDirigeant = processCertificationDirigeantFactory({
-      ApiEntrepriseClient: {
-        findMandatairesSociauxBySiren: () => Promise.reject(new Error("💣")),
-      },
-      RegistreNationalEntreprisesApiClient: {
-        findPouvoirsBySiren: () =>
-          Promise.resolve([UlysseTosiPouvoir, RogalDornPouvoir]),
-      },
-      InseeApiClient: {
-        findBySiren: () => Promise.reject(new Error("💣")),
-      },
-    });
+    api_registre_national_entreprises_mock_client.findPouvoirsBySiren.mock.mockImplementationOnce(
+      () => Promise.resolve([UlysseTosiPouvoir, RogalDornPouvoir]),
+    );
 
     const certificationDirigeantResult = await processCertificationDirigeant(
       papillon_org_info,
@@ -173,18 +148,9 @@ describe("processCertificationDirigeantFactory", () => {
   });
 
   it("should match Amberley Vail among the executive of Papillon in RNE", async () => {
-    const processCertificationDirigeant = processCertificationDirigeantFactory({
-      ApiEntrepriseClient: {
-        findMandatairesSociauxBySiren: () => Promise.reject(new Error("💣")),
-      },
-      RegistreNationalEntreprisesApiClient: {
-        findPouvoirsBySiren: () =>
-          Promise.resolve([UlysseTosiPouvoir, AmberleyVailPouvoir]),
-      },
-      InseeApiClient: {
-        findBySiren: () => Promise.reject(new Error("💣")),
-      },
-    });
+    api_registre_national_entreprises_mock_client.findPouvoirsBySiren.mock.mockImplementationOnce(
+      () => Promise.resolve([UlysseTosiPouvoir, AmberleyVailPouvoir]),
+    );
 
     const certificationDirigeantResult = await processCertificationDirigeant(
       papillon_org_info,
@@ -210,18 +176,9 @@ describe("processCertificationDirigeantFactory", () => {
   });
 
   it("should match Rogal Dorn among the executive of Papillon in Infogreffe", async () => {
-    const processCertificationDirigeant = processCertificationDirigeantFactory({
-      ApiEntrepriseClient: {
-        findMandatairesSociauxBySiren: () =>
-          Promise.resolve([UlysseToriMandataire, RogalDornMandataire]),
-      },
-      RegistreNationalEntreprisesApiClient: {
-        findPouvoirsBySiren: () => Promise.reject(new Error("💣")),
-      },
-      InseeApiClient: {
-        findBySiren: () => Promise.reject(new Error("💣")),
-      },
-    });
+    api_entreprise_mock_client.findMandatairesSociauxBySiren.mock.mockImplementationOnce(
+      () => Promise.resolve([UlysseToriMandataire, RogalDornMandataire]),
+    );
 
     const certificationDirigeantResult = await processCertificationDirigeant(
       papillon_org_info,
@@ -248,17 +205,9 @@ describe("processCertificationDirigeantFactory", () => {
   });
 
   it("❎ fail with no mandataires", async () => {
-    const processCertificationDirigeant = processCertificationDirigeantFactory({
-      ApiEntrepriseClient: {
-        findMandatairesSociauxBySiren: () => Promise.reject(new Error("💣")),
-      },
-      RegistreNationalEntreprisesApiClient: {
-        findPouvoirsBySiren: () => Promise.resolve([]),
-      },
-      InseeApiClient: {
-        findBySiren: () => Promise.reject(new Error("💣")),
-      },
-    });
+    api_registre_national_entreprises_mock_client.findPouvoirsBySiren.mock.mockImplementationOnce(
+      () => Promise.resolve([]),
+    );
 
     const certificationDirigeantResult = await processCertificationDirigeant(
       papillon_org_info,

package/src/managers/certification/process-certification-dirigeant.ts

@@ -1,5 +1,6 @@
 //
 
+import type { Context } from "#src/connectors";
 import { isOrganizationCoveredByCertificationDirigeant } from "#src/services/organization";
 import {
   NullIdentityVector,
@@ -7,9 +8,6 @@ import {
   type IdentityVector,
   type Organization,
 } from "#src/types";
-import type { ApiEntrepriseClient } from "@proconnect-gouv/proconnect.api_entreprise/api";
-import type { ApiInseeClient } from "@proconnect-gouv/proconnect.insee/api";
-import type { FindPouvoirsBySirenHandler } from "@proconnect-gouv/proconnect.registre_national_entreprises/api";
 import { match } from "ts-pattern";
 import z from "zod/v4";
 import * as ApiEntreprise from "./adapters/api_entreprise.js";
@@ -20,17 +18,6 @@ import { certificationScore } from "./certification-score.js";
 
 //
 
-type ProcessCertificationDirigeantConfig = {
-  ApiEntrepriseClient: Pick<
-    ApiEntrepriseClient,
-    "findMandatairesSociauxBySiren"
-  >;
-  InseeApiClient: ApiInseeClient;
-  RegistreNationalEntreprisesApiClient: {
-    findPouvoirsBySiren: FindPouvoirsBySirenHandler;
-  };
-};
-
 export const CertificationDirigeantDataSource = z.enum([
   "api.insee.fr/api-sirene/private",
   "entreprise.api.gouv.fr/v3/infogreffe/rcs/unites_legales/{siren}/mandataires_sociaux",
@@ -59,15 +46,11 @@ export function getCertificationDirigeantDataSourceLabels(
 //
 
 async function getMandatairesSociaux(
-  {
-    RegistreNationalEntreprisesApiClient,
-    ApiEntrepriseClient,
-  }: ProcessCertificationDirigeantConfig,
+  { client: { api_entreprise, rne } }: Context,
   siren: string,
 ) {
   try {
-    const pouvoirs =
-      await RegistreNationalEntreprisesApiClient.findPouvoirsBySiren(siren);
+    const pouvoirs = await rne.findPouvoirsBySiren(siren);
     const dirigeants = pouvoirs.map(RNE.toIdentityVector);
 
     return {
@@ -80,7 +63,7 @@ async function getMandatairesSociaux(
   } catch (error) {
     console.error(error);
     const mandataires =
-      await ApiEntrepriseClient.findMandatairesSociauxBySiren(siren);
+      await api_entreprise.findMandatairesSociauxBySiren(siren);
     const dirigeants = mandataires.map(ApiEntreprise.toIdentityVector);
 
     return {
@@ -126,10 +109,10 @@ function match_identity_to_dirigeant(
     }));
 }
 
-export function processCertificationDirigeantFactory(
-  config: ProcessCertificationDirigeantConfig,
-) {
-  const { InseeApiClient } = config;
+export function processCertificationDirigeantFactory(context: Context) {
+  const {
+    client: { insee },
+  } = context;
 
   return async function processCertificationDirigeant(
     organization: Organization,
@@ -163,7 +146,8 @@ export function processCertificationDirigeantFactory(
 
     const { dirigeants, source } = await match(preferredDataSource)
       .with("api.insee.fr/api-sirene/private", async () => ({
-        dirigeants: await InseeApiClient.findBySiren(siren)
+        dirigeants: await insee
+          .findBySiren(siren)
           .then(INSEE.toIdentityVector)
           .then((vector) => [vector]),
         source:
@@ -172,7 +156,7 @@ export function processCertificationDirigeantFactory(
           ],
       }))
       .with("registre-national-entreprises.inpi.fr/api", () =>
-        getMandatairesSociaux(config, siren),
+        getMandatairesSociaux(context, siren),
       )
       .exhaustive();
 

package/testing/index.ts

@@ -1,18 +1,27 @@
 //
 
 import { PGlite } from "@electric-sql/pglite";
+import type { FindMandatairesSociauxBySirenHandler } from "@proconnect-gouv/proconnect.api_entreprise/api/infogreffe";
+import type {
+  FindBySirenHandler,
+  FindBySiretHandler,
+} from "@proconnect-gouv/proconnect.api_entreprise/api/insee";
+import type { FindPouvoirsBySirenHandler } from "@proconnect-gouv/proconnect.registre_national_entreprises/api";
 import { noop } from "lodash-es";
 import { runner } from "node-pg-migrate";
+import { mock } from "node:test";
 import { join } from "path";
+import type { Pool } from "pg";
+import type { FindUniteLegaleBySirenHandler } from "../../insee/src/api/find-by-siren.js";
+import type { FindUniteLegaleBySiretHandler } from "../../insee/src/api/find-by-siret.js";
 import { createContext } from "../src/connectors/index.js";
 
 //
 
 export const pg = new PGlite();
-export const context = createContext(pg as any);
 
-export function migrate() {
-  return runner({
+export async function migrate() {
+  await runner({
     dbClient: pg as any,
     dir: join(import.meta.dirname, "../../../migrations"),
     direction: "up",
@@ -31,3 +40,34 @@ export async function emptyDatabase() {
   await pg.sql`delete from email_domains;`;
   await pg.sql`ALTER SEQUENCE email_domains_id_seq RESTART WITH 1`;
 }
+
+//
+
+const should_not_been_called = () => Promise.reject(new Error("💣"));
+
+export const api_entreprise_mock_client = {
+  findBySiren: mock.fn<FindBySirenHandler>(should_not_been_called),
+  findBySiret: mock.fn<FindBySiretHandler>(should_not_been_called),
+  findMandatairesSociauxBySiren: mock.fn<FindMandatairesSociauxBySirenHandler>(
+    should_not_been_called,
+  ),
+};
+
+export const api_insee_mock_client = {
+  findBySiret: mock.fn<FindUniteLegaleBySiretHandler>(should_not_been_called),
+  findBySiren: mock.fn<FindUniteLegaleBySirenHandler>(should_not_been_called),
+};
+
+export const api_registre_national_entreprises_mock_client = {
+  findPouvoirsBySiren: mock.fn<FindPouvoirsBySirenHandler>(
+    should_not_been_called,
+  ),
+};
+
+export const context = createContext({
+  api_entreprise_client: api_entreprise_mock_client,
+  api_insee_client: api_insee_mock_client,
+  api_registre_national_entreprises_client:
+    api_registre_national_entreprises_mock_client,
+  pg: pg as Pool & PGlite,
+});

package/tsconfig.json

@@ -12,10 +12,11 @@
   },
   "extends": "@proconnect-gouv/proconnect.devtools.typescript/base/tsconfig.json",
   "references": [
-    { "path": "../annuaire_entreprises/tsconfig.lib.json" },
-    { "path": "../core/tsconfig.lib.json" },
-    { "path": "../entreprise/tsconfig.lib.json" },
-    { "path": "../insee/tsconfig.lib.json" }
+    { "path": "../annuaire_entreprises" },
+    { "path": "../core" },
+    { "path": "../entreprise" },
+    { "path": "../insee" },
+    { "path": "../registre_national_entreprises" }
   ],
   "include": ["./src/**/*", "./src/**/*.json", "testing"]
 }