npm - @proconnect-gouv/proconnect.identite - Versions diffs - 1.5.0 → 1.6.0 - Mend

@proconnect-gouv/proconnect.identite 1.5.0 → 1.6.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (18) hide show

package/CHANGELOG.md CHANGED Viewed

@@ -1,5 +1,11 @@
 # @proconnect-gouv/proconnect.identite
+## 1.6.0
+### Minor Changes
+- [#1764](https://github.com/proconnect-gouv/proconnect-identite/pull/1764) [`6484e64`](https://github.com/proconnect-gouv/proconnect-identite/commit/6484e64f558493b5963d32681dab645484b87693) Thanks [@rdubigny](https://github.com/rdubigny)! - Ajout d'une catégorie SuperWeakLinkTypes pour gérer les cas des domaines non vérifiés
 ## 1.5.0
 ### Minor Changes

package/dist/managers/certification/certification-score.js CHANGED Viewed

@@ -71,8 +71,8 @@ export function certificationScore(identitePivot, sourceDirigeant) {
     else {
         // For foreigners: check country code (with conversion if needed from RNE)
         // Both should already be in COG format (99XXX)
-        if (identitePivot.birthcountry &&
-            sourceDirigeant.birthcountry &&
+        if (identitePivot.birthcountry === null ||
+            sourceDirigeant.birthcountry === null ||
             identitePivot.birthcountry === sourceDirigeant.birthcountry) {
             matches.add(MatchCriteria.enum.birth_country);
         }

package/dist/managers/organization/force-join-organization.d.ts CHANGED Viewed

@@ -13,7 +13,7 @@ export declare function forceJoinOrganizationFactory({ findEmailDomainsByOrganiz
     is_external?: boolean;
 }) => Promise<{
     is_external: boolean;
-    verification_type: "code_sent_to_official_contact_email" | "domain" | "domain_not_verified_yet" | "imported_from_coop_mediation_numerique" | "imported_from_inclusion_connect" | "in_liste_dirigeants_rna" | "in_liste_dirigeants_rne" | "official_contact_email" | "ordre_professionnel_domain" | "proof_received" | "verified_by_coop_mediation_numerique" | "bypassed" | "organization_dirigeant" | "no_validation_means_available" | "no_verification_means_for_entreprise_unipersonnelle" | "no_verification_means_for_small_association";
+    verification_type: "organization_dirigeant" | "code_sent_to_official_contact_email" | "domain" | "imported_from_coop_mediation_numerique" | "imported_from_inclusion_connect" | "in_liste_dirigeants_rna" | "in_liste_dirigeants_rne" | "official_contact_email" | "ordre_professionnel_domain" | "proof_received" | "verified_by_coop_mediation_numerique" | "bypassed" | "domain_not_verified_yet" | "no_validation_means_available" | "no_verification_means_for_entreprise_unipersonnelle" | "no_verification_means_for_small_association";
     verified_at: Date | null;
     has_been_greeted: boolean;
     needs_official_contact_email_verification: boolean;

package/dist/managers/user/assign-user-verification-type-to-domain.js CHANGED Viewed

@@ -1,5 +1,5 @@
 //
-import { LinkTypes, UnverifiedLinkTypes } from "#src/types";
+import { LinkTypes, SuperWeakLinkTypes, UnverifiedLinkTypes } from "#src/types";
 import { getEmailDomain } from "@proconnect-gouv/proconnect.core/services/email";
 import { match } from "ts-pattern";
 export function assignUserVerificationTypeToDomainFactory({ getUsers, updateUserOrganizationLink, }) {
@@ -9,7 +9,7 @@ export function assignUserVerificationTypeToDomainFactory({ getUsers, updateUser
             const userDomain = getEmailDomain(email);
             if (userDomain === domain &&
                 match(link_verification_type)
-                    .with(...UnverifiedLinkTypes, () => true)
+                    .with(...UnverifiedLinkTypes, ...SuperWeakLinkTypes, () => true)
                     .otherwise(() => false)) {
                 return updateUserOrganizationLink(organization_id, id, {
                     verification_type: LinkTypes.enum.domain,

package/dist/repositories/organization/find-by-user-id.d.ts CHANGED Viewed

@@ -1,7 +1,7 @@
 import type { DatabaseContext, Organization } from "#src/types";
 export declare function findByUserIdFactory({ pg }: DatabaseContext): (userId: number) => Promise<(Organization & {
     is_external: boolean;
-    verification_type: "code_sent_to_official_contact_email" | "domain" | "domain_not_verified_yet" | "imported_from_coop_mediation_numerique" | "imported_from_inclusion_connect" | "in_liste_dirigeants_rna" | "in_liste_dirigeants_rne" | "official_contact_email" | "ordre_professionnel_domain" | "proof_received" | "verified_by_coop_mediation_numerique" | "bypassed" | "organization_dirigeant" | "no_validation_means_available" | "no_verification_means_for_entreprise_unipersonnelle" | "no_verification_means_for_small_association";
+    verification_type: "organization_dirigeant" | "code_sent_to_official_contact_email" | "domain" | "imported_from_coop_mediation_numerique" | "imported_from_inclusion_connect" | "in_liste_dirigeants_rna" | "in_liste_dirigeants_rne" | "official_contact_email" | "ordre_professionnel_domain" | "proof_received" | "verified_by_coop_mediation_numerique" | "bypassed" | "domain_not_verified_yet" | "no_validation_means_available" | "no_verification_means_for_entreprise_unipersonnelle" | "no_verification_means_for_small_association";
     verified_at: Date | null;
     has_been_greeted: boolean;
     needs_official_contact_email_verification: boolean;

package/dist/repositories/organization/get-users-by-organization.d.ts CHANGED Viewed

@@ -1,7 +1,7 @@
 import type { DatabaseContext, User } from "#src/types";
 export declare function getUsersByOrganizationFactory({ pg }: DatabaseContext): (organization_id: number, additionalWhereClause?: string, additionalParams?: any[]) => Promise<(User & {
     is_external: boolean;
-    verification_type: "code_sent_to_official_contact_email" | "domain" | "domain_not_verified_yet" | "imported_from_coop_mediation_numerique" | "imported_from_inclusion_connect" | "in_liste_dirigeants_rna" | "in_liste_dirigeants_rne" | "official_contact_email" | "ordre_professionnel_domain" | "proof_received" | "verified_by_coop_mediation_numerique" | "bypassed" | "organization_dirigeant" | "no_validation_means_available" | "no_verification_means_for_entreprise_unipersonnelle" | "no_verification_means_for_small_association";
+    verification_type: "organization_dirigeant" | "code_sent_to_official_contact_email" | "domain" | "imported_from_coop_mediation_numerique" | "imported_from_inclusion_connect" | "in_liste_dirigeants_rna" | "in_liste_dirigeants_rne" | "official_contact_email" | "ordre_professionnel_domain" | "proof_received" | "verified_by_coop_mediation_numerique" | "bypassed" | "domain_not_verified_yet" | "no_validation_means_available" | "no_verification_means_for_entreprise_unipersonnelle" | "no_verification_means_for_small_association";
     verified_at: Date | null;
     has_been_greeted: boolean;
     needs_official_contact_email_verification: boolean;

package/dist/repositories/organization/link-user-to-organization.d.ts CHANGED Viewed

@@ -1,7 +1,7 @@
 import type { DatabaseContext, InsertUserOrganizationLink } from "#src/types";
 export declare function linkUserToOrganizationFactory({ pg }: DatabaseContext): ({ is_external, needs_official_contact_email_verification, organization_id, user_id, verification_type, }: InsertUserOrganizationLink) => Promise<{
     is_external: boolean;
-    verification_type: "code_sent_to_official_contact_email" | "domain" | "domain_not_verified_yet" | "imported_from_coop_mediation_numerique" | "imported_from_inclusion_connect" | "in_liste_dirigeants_rna" | "in_liste_dirigeants_rne" | "official_contact_email" | "ordre_professionnel_domain" | "proof_received" | "verified_by_coop_mediation_numerique" | "bypassed" | "organization_dirigeant" | "no_validation_means_available" | "no_verification_means_for_entreprise_unipersonnelle" | "no_verification_means_for_small_association";
+    verification_type: "organization_dirigeant" | "code_sent_to_official_contact_email" | "domain" | "imported_from_coop_mediation_numerique" | "imported_from_inclusion_connect" | "in_liste_dirigeants_rna" | "in_liste_dirigeants_rne" | "official_contact_email" | "ordre_professionnel_domain" | "proof_received" | "verified_by_coop_mediation_numerique" | "bypassed" | "domain_not_verified_yet" | "no_validation_means_available" | "no_verification_means_for_entreprise_unipersonnelle" | "no_verification_means_for_small_association";
     verified_at: Date | null;
     has_been_greeted: boolean;
     needs_official_contact_email_verification: boolean;

package/dist/repositories/user/update-user-organization-link.d.ts CHANGED Viewed

@@ -1,7 +1,7 @@
 import type { DatabaseContext, UserOrganizationLink } from "#src/types";
 export declare function updateUserOrganizationLinkFactory({ pg }: DatabaseContext): (organization_id: number, user_id: number, fieldsToUpdate: Partial<UserOrganizationLink>) => Promise<{
     is_external: boolean;
-    verification_type: "code_sent_to_official_contact_email" | "domain" | "domain_not_verified_yet" | "imported_from_coop_mediation_numerique" | "imported_from_inclusion_connect" | "in_liste_dirigeants_rna" | "in_liste_dirigeants_rne" | "official_contact_email" | "ordre_professionnel_domain" | "proof_received" | "verified_by_coop_mediation_numerique" | "bypassed" | "organization_dirigeant" | "no_validation_means_available" | "no_verification_means_for_entreprise_unipersonnelle" | "no_verification_means_for_small_association";
+    verification_type: "organization_dirigeant" | "code_sent_to_official_contact_email" | "domain" | "imported_from_coop_mediation_numerique" | "imported_from_inclusion_connect" | "in_liste_dirigeants_rna" | "in_liste_dirigeants_rne" | "official_contact_email" | "ordre_professionnel_domain" | "proof_received" | "verified_by_coop_mediation_numerique" | "bypassed" | "domain_not_verified_yet" | "no_validation_means_available" | "no_verification_means_for_entreprise_unipersonnelle" | "no_verification_means_for_small_association";
     verified_at: Date | null;
     has_been_greeted: boolean;
     needs_official_contact_email_verification: boolean;

package/dist/types/user-organization-link.d.ts CHANGED Viewed

@@ -1,12 +1,12 @@
 import { z } from "zod";
-export declare const WeakLinkTypes: readonly ["code_sent_to_official_contact_email", "domain", "domain_not_verified_yet", "imported_from_coop_mediation_numerique", "imported_from_inclusion_connect", "in_liste_dirigeants_rna", "in_liste_dirigeants_rne", "official_contact_email", "ordre_professionnel_domain", "proof_received", "verified_by_coop_mediation_numerique", "bypassed"];
 export declare const StrongLinkTypes: readonly ["organization_dirigeant"];
-export declare const VerifiedLinkTypes: readonly ["code_sent_to_official_contact_email", "domain", "domain_not_verified_yet", "imported_from_coop_mediation_numerique", "imported_from_inclusion_connect", "in_liste_dirigeants_rna", "in_liste_dirigeants_rne", "official_contact_email", "ordre_professionnel_domain", "proof_received", "verified_by_coop_mediation_numerique", "bypassed", "organization_dirigeant"];
+export declare const WeakLinkTypes: readonly ["code_sent_to_official_contact_email", "domain", "imported_from_coop_mediation_numerique", "imported_from_inclusion_connect", "in_liste_dirigeants_rna", "in_liste_dirigeants_rne", "official_contact_email", "ordre_professionnel_domain", "proof_received", "verified_by_coop_mediation_numerique", "bypassed"];
+export declare const SuperWeakLinkTypes: readonly ["domain_not_verified_yet"];
 export declare const UnverifiedLinkTypes: readonly ["no_validation_means_available", "no_verification_means_for_entreprise_unipersonnelle", "no_verification_means_for_small_association"];
 export declare const LinkTypes: z.ZodEnum<{
+    organization_dirigeant: "organization_dirigeant";
     code_sent_to_official_contact_email: "code_sent_to_official_contact_email";
     domain: "domain";
-    domain_not_verified_yet: "domain_not_verified_yet";
     imported_from_coop_mediation_numerique: "imported_from_coop_mediation_numerique";
     imported_from_inclusion_connect: "imported_from_inclusion_connect";
     in_liste_dirigeants_rna: "in_liste_dirigeants_rna";
@@ -16,7 +16,7 @@ export declare const LinkTypes: z.ZodEnum<{
     proof_received: "proof_received";
     verified_by_coop_mediation_numerique: "verified_by_coop_mediation_numerique";
     bypassed: "bypassed";
-    organization_dirigeant: "organization_dirigeant";
+    domain_not_verified_yet: "domain_not_verified_yet";
     no_validation_means_available: "no_validation_means_available";
     no_verification_means_for_entreprise_unipersonnelle: "no_verification_means_for_entreprise_unipersonnelle";
     no_verification_means_for_small_association: "no_verification_means_for_small_association";
@@ -24,9 +24,9 @@ export declare const LinkTypes: z.ZodEnum<{
 export declare const BaseUserOrganizationLinkSchema: z.ZodObject<{
     is_external: z.ZodBoolean;
     verification_type: z.ZodEnum<{
+        organization_dirigeant: "organization_dirigeant";
         code_sent_to_official_contact_email: "code_sent_to_official_contact_email";
         domain: "domain";
-        domain_not_verified_yet: "domain_not_verified_yet";
         imported_from_coop_mediation_numerique: "imported_from_coop_mediation_numerique";
         imported_from_inclusion_connect: "imported_from_inclusion_connect";
         in_liste_dirigeants_rna: "in_liste_dirigeants_rna";
@@ -36,7 +36,7 @@ export declare const BaseUserOrganizationLinkSchema: z.ZodObject<{
         proof_received: "proof_received";
         verified_by_coop_mediation_numerique: "verified_by_coop_mediation_numerique";
         bypassed: "bypassed";
-        organization_dirigeant: "organization_dirigeant";
+        domain_not_verified_yet: "domain_not_verified_yet";
         no_validation_means_available: "no_validation_means_available";
         no_verification_means_for_entreprise_unipersonnelle: "no_verification_means_for_entreprise_unipersonnelle";
         no_verification_means_for_small_association: "no_verification_means_for_small_association";
@@ -51,9 +51,9 @@ export type BaseUserOrganizationLink = z.output<typeof BaseUserOrganizationLinkS
 export declare const UserOrganizationLinkSchema: z.ZodObject<{
     is_external: z.ZodBoolean;
     verification_type: z.ZodEnum<{
+        organization_dirigeant: "organization_dirigeant";
         code_sent_to_official_contact_email: "code_sent_to_official_contact_email";
         domain: "domain";
-        domain_not_verified_yet: "domain_not_verified_yet";
         imported_from_coop_mediation_numerique: "imported_from_coop_mediation_numerique";
         imported_from_inclusion_connect: "imported_from_inclusion_connect";
         in_liste_dirigeants_rna: "in_liste_dirigeants_rna";
@@ -63,7 +63,7 @@ export declare const UserOrganizationLinkSchema: z.ZodObject<{
         proof_received: "proof_received";
         verified_by_coop_mediation_numerique: "verified_by_coop_mediation_numerique";
         bypassed: "bypassed";
-        organization_dirigeant: "organization_dirigeant";
+        domain_not_verified_yet: "domain_not_verified_yet";
         no_validation_means_available: "no_validation_means_available";
         no_verification_means_for_entreprise_unipersonnelle: "no_verification_means_for_entreprise_unipersonnelle";
         no_verification_means_for_small_association: "no_verification_means_for_small_association";
@@ -83,9 +83,9 @@ export declare const InsertUserOrganizationLinkSchema: z.ZodObject<{
     user_id: z.ZodNumber;
     organization_id: z.ZodNumber;
     verification_type: z.ZodEnum<{
+        organization_dirigeant: "organization_dirigeant";
         code_sent_to_official_contact_email: "code_sent_to_official_contact_email";
         domain: "domain";
-        domain_not_verified_yet: "domain_not_verified_yet";
         imported_from_coop_mediation_numerique: "imported_from_coop_mediation_numerique";
         imported_from_inclusion_connect: "imported_from_inclusion_connect";
         in_liste_dirigeants_rna: "in_liste_dirigeants_rna";
@@ -95,7 +95,7 @@ export declare const InsertUserOrganizationLinkSchema: z.ZodObject<{
         proof_received: "proof_received";
         verified_by_coop_mediation_numerique: "verified_by_coop_mediation_numerique";
         bypassed: "bypassed";
-        organization_dirigeant: "organization_dirigeant";
+        domain_not_verified_yet: "domain_not_verified_yet";
         no_validation_means_available: "no_validation_means_available";
         no_verification_means_for_entreprise_unipersonnelle: "no_verification_means_for_entreprise_unipersonnelle";
         no_verification_means_for_small_association: "no_verification_means_for_small_association";

package/dist/types/user-organization-link.d.ts.map CHANGED Viewed

	@@ -1 +1 @@
1	- {"version":3,"file":"user-organization-link.d.ts","sourceRoot":"","sources":["../../src/types/user-organization-link.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AAExB,eAAO,MAAM,~~aAAa~~,~~wVAchB~~,CAAC;~~AAEX~~,eAAO,MAAM,~~eAAe~~,~~qCAAsC~~,CAAC;~~AAEnE~~,eAAO,MAAM,~~iBAAiB~~,~~kXAGpB~~,CAAC;~~AAEX~~,eAAO,MAAM,mBAAmB,kJAItB,CAAC;AAEX,eAAO,MAAM,SAAS;;;;;;;;;;;;;;;;;EAAyD,CAAC;AAEhF,eAAO,MAAM,8BAA8B;;;;;;;;;;;;;;;;;;;;;;;;;iBASzC,CAAC;AAEH,MAAM,MAAM,wBAAwB,GAAG,CAAC,CAAC,MAAM,CAC7C,OAAO,8BAA8B,CACtC,CAAC;AAIF,eAAO,MAAM,0BAA0B;;;;;;;;;;;;;;;;;;;;;;;;;;;;;iBAOtC,CAAC;AAEF,MAAM,MAAM,oBAAoB,GAAG,CAAC,CAAC,MAAM,CAAC,OAAO,0BAA0B,CAAC,CAAC;AAI/E,eAAO,MAAM,gCAAgC;;;;;;;;;;;;;;;;;;;;;;;iBAW5C,CAAC;AAEF,MAAM,MAAM,0BAA0B,GAAG,CAAC,CAAC,MAAM,CAC/C,OAAO,gCAAgC,CACxC,CAAC"}
1	+ {"version":3,"file":"user-organization-link.d.ts","sourceRoot":"","sources":["../../src/types/user-organization-link.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AAExB,eAAO,MAAM,eAAe,qCAAsC,CAAC;AAEnE,eAAO,MAAM,aAAa,6TAahB,CAAC;AAMX,eAAO,MAAM,kBAAkB,sCAAuC,CAAC;AAQvE,eAAO,MAAM,mBAAmB,kJAItB,CAAC;AAEX,eAAO,MAAM,SAAS;;;;;;;;;;;;;;;;;EAAyD,CAAC;AAEhF,eAAO,MAAM,8BAA8B;;;;;;;;;;;;;;;;;;;;;;;;;iBASzC,CAAC;AAEH,MAAM,MAAM,wBAAwB,GAAG,CAAC,CAAC,MAAM,CAC7C,OAAO,8BAA8B,CACtC,CAAC;AAIF,eAAO,MAAM,0BAA0B;;;;;;;;;;;;;;;;;;;;;;;;;;;;;iBAOtC,CAAC;AAEF,MAAM,MAAM,oBAAoB,GAAG,CAAC,CAAC,MAAM,CAAC,OAAO,0BAA0B,CAAC,CAAC;AAI/E,eAAO,MAAM,gCAAgC;;;;;;;;;;;;;;;;;;;;;;;iBAW5C,CAAC;AAEF,MAAM,MAAM,0BAA0B,GAAG,CAAC,CAAC,MAAM,CAC/C,OAAO,gCAAgC,CACxC,CAAC"}

package/dist/types/user-organization-link.js CHANGED Viewed

@@ -1,8 +1,8 @@
 import { z } from "zod";
+export const StrongLinkTypes = ["organization_dirigeant"];
 export const WeakLinkTypes = [
     "code_sent_to_official_contact_email",
     "domain",
-    "domain_not_verified_yet",
     "imported_from_coop_mediation_numerique",
     "imported_from_inclusion_connect",
     "in_liste_dirigeants_rna",
@@ -14,10 +14,15 @@ export const WeakLinkTypes = [
     // Used in the sandbox environment to bypass the verification process
     "bypassed",
 ];
-export const StrongLinkTypes = ["organization_dirigeant"];
-export const VerifiedLinkTypes = [
-    ...WeakLinkTypes,
+// This link type should be considered as unverified.
+// However, doing so would trigger a FranceConnect authentication requirement for the user.
+// Users shouldn't face inconvenience while waiting for domain review completion.
+// Instead, we should remove these unverified domains and then eliminate this special case from the codebase.
+export const SuperWeakLinkTypes = ["domain_not_verified_yet"];
+const VerifiedLinkTypes = [
     ...StrongLinkTypes,
+    ...WeakLinkTypes,
+    ...SuperWeakLinkTypes,
 ];
 export const UnverifiedLinkTypes = [
     "no_validation_means_available",

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@proconnect-gouv/proconnect.identite",
-  "version": "1.5.0",
+  "version": "1.6.0",
   "homepage": "https://github.com/proconnect-gouv/proconnect-identite/tree/main/packages/identite#readme",
   "bugs": "https://github.com/proconnect-gouv/proconnect-identite/issues",
   "repository": {

package/src/managers/certification/certification-score.ts CHANGED Viewed

@@ -96,8 +96,8 @@ export function certificationScore(
     // For foreigners: check country code (with conversion if needed from RNE)
     // Both should already be in COG format (99XXX)
     if (
-      identitePivot.birthcountry &&
-      sourceDirigeant.birthcountry &&
+      identitePivot.birthcountry === null ||
+      sourceDirigeant.birthcountry === null ||
       identitePivot.birthcountry === sourceDirigeant.birthcountry
     ) {
       matches.add(MatchCriteria.enum.birth_country);

package/src/managers/certification/process-certification-dirigeant.test.ts CHANGED Viewed

@@ -2,6 +2,7 @@
 import { IdentityVectorSchema } from "#src/types";
 import {
+  AmberleyVailFranceConnectUserInfo,
   LiElJonsonFranceConnectUserInfo,
   RogalDornFranceConnectUserInfo,
 } from "#testing/seed/franceconnect";
@@ -18,17 +19,57 @@ import {
   RogalDornEstablishment,
 } from "@proconnect-gouv/proconnect.insee/testing/seed";
 import {
+  AmberleyVailPouvoir,
   RogalDornPouvoir,
   UlysseTosiPouvoir,
 } from "@proconnect-gouv/proconnect.registre_national_entreprises/testing/seed";
 import assert from "node:assert/strict";
 import { describe, it } from "node:test";
+import * as ApiEntreprise from "./adapters/api_entreprise.js";
+import * as INSEE from "./adapters/insee.js";
+import * as RNE from "./adapters/rne.js";
 import { processCertificationDirigeantFactory } from "./process-certification-dirigeant.js";
 //
 describe("processCertificationDirigeantFactory", () => {
   it("should recognize a user as executive of a auto-entrepreneur", async () => {
+    const processCertificationDirigeant = processCertificationDirigeantFactory({
+      ApiEntrepriseInfogreffeRepository: {
+        findMandatairesSociauxBySiren: () => Promise.reject(new Error("💣")),
+      },
+      RegistreNationalEntreprisesApiRepository: {
+        findPouvoirsBySiren: () => Promise.reject(new Error("💣")),
+      },
+      InseeApiRepository: {
+        findBySiren: () => Promise.resolve(LiElJonsonEstablishment),
+      },
+    });
+    const certificationDirigeantResult = await processCertificationDirigeant(
+      rogal_dorn_org_info,
+      LiElJonsonFranceConnectUserInfo,
+    );
+    assert.deepEqual(certificationDirigeantResult, {
+      cause: "exact_match",
+      details: {
+        dirigeant: INSEE.toIdentityVector(LiElJonsonEstablishment),
+        matches: new Set([
+          "family_name",
+          "first_name",
+          "gender",
+          "birth_date",
+          "birth_place",
+        ]),
+        identity: IdentityVectorSchema.parse(LiElJonsonFranceConnectUserInfo),
+        source: "api.insee.fr/api-sirene/private",
+      },
+      ok: true,
+    });
+  });
+  it("should recognize a foreign user as executive of a auto-entrepreneur", async () => {
     const processCertificationDirigeant = processCertificationDirigeantFactory({
       ApiEntrepriseInfogreffeRepository: {
         findMandatairesSociauxBySiren: () => Promise.reject(new Error("💣")),
@@ -49,10 +90,7 @@ describe("processCertificationDirigeantFactory", () => {
     assert.deepEqual(certificationDirigeantResult, {
       cause: "exact_match",
       details: {
-        dirigeant: {
-          ...IdentityVectorSchema.parse(RogalDornFranceConnectUserInfo),
-          birthplace: null, // INSEE adapter returns null for foreigners
-        },
+        dirigeant: INSEE.toIdentityVector(RogalDornEstablishment),
         matches: new Set([
           "family_name",
           "first_name",
@@ -88,11 +126,8 @@ describe("processCertificationDirigeantFactory", () => {
     assert.deepEqual(certificationDirigeantResult, {
       cause: "below_threshold",
       details: {
-        dirigeant: {
-          ...IdentityVectorSchema.parse(LiElJonsonFranceConnectUserInfo),
-          birthcountry: null, // INSEE adapter returns null for French people
-        },
-        matches: new Set(["gender"]),
+        dirigeant: INSEE.toIdentityVector(LiElJonsonEstablishment),
+        matches: new Set(["gender", "birth_country"]),
         identity: IdentityVectorSchema.parse(RogalDornFranceConnectUserInfo),
         source: "api.insee.fr/api-sirene/private",
       },
@@ -122,10 +157,7 @@ describe("processCertificationDirigeantFactory", () => {
     assert.deepEqual(certificationDirigeantResult, {
       cause: "exact_match",
       details: {
-        dirigeant: {
-          ...IdentityVectorSchema.parse(RogalDornFranceConnectUserInfo),
-          birthplace: null, // RNE adapter returns null for foreigners
-        },
+        dirigeant: RNE.toIdentityVector(RogalDornPouvoir),
         matches: new Set([
           "family_name",
           "first_name",
@@ -140,6 +172,43 @@ describe("processCertificationDirigeantFactory", () => {
     });
   });
+  it("should match Amberley Vail among the executive of Papillon in RNE", async () => {
+    const processCertificationDirigeant = processCertificationDirigeantFactory({
+      ApiEntrepriseInfogreffeRepository: {
+        findMandatairesSociauxBySiren: () => Promise.reject(new Error("💣")),
+      },
+      RegistreNationalEntreprisesApiRepository: {
+        findPouvoirsBySiren: () =>
+          Promise.resolve([UlysseTosiPouvoir, AmberleyVailPouvoir]),
+      },
+      InseeApiRepository: {
+        findBySiren: () => Promise.reject(new Error("💣")),
+      },
+    });
+    const certificationDirigeantResult = await processCertificationDirigeant(
+      papillon_org_info,
+      AmberleyVailFranceConnectUserInfo,
+    );
+    assert.deepEqual(certificationDirigeantResult, {
+      cause: "exact_match",
+      details: {
+        dirigeant: RNE.toIdentityVector(AmberleyVailPouvoir),
+        matches: new Set([
+          "family_name",
+          "first_name",
+          "gender",
+          "birth_date",
+          "birth_country",
+        ]),
+        identity: IdentityVectorSchema.parse(AmberleyVailFranceConnectUserInfo),
+        source: "registre-national-entreprises.inpi.fr/api",
+      },
+      ok: true,
+    });
+  });
   it("should match Rogal Dorn among the executive of Papillon in Infogreffe", async () => {
     const processCertificationDirigeant = processCertificationDirigeantFactory({
       ApiEntrepriseInfogreffeRepository: {
@@ -162,11 +231,7 @@ describe("processCertificationDirigeantFactory", () => {
     assert.deepEqual(certificationDirigeantResult, {
       cause: "exact_match",
       details: {
-        dirigeant: {
-          ...IdentityVectorSchema.parse(RogalDornFranceConnectUserInfo),
-          birthplace: null, // API Entreprise adapter doesn't provide birthplace
-          gender: null, // API Entreprise adapter doesn't provide gender
-        },
+        dirigeant: ApiEntreprise.toIdentityVector(RogalDornMandataire),
         matches: new Set([
           "family_name",
           "first_name",

package/src/managers/user/assign-user-verification-type-to-domain.ts CHANGED Viewed

@@ -2,7 +2,7 @@
 import type { GetUsersByOrganizationHandler } from "#src/repositories/organization";
 import type { UpdateUserOrganizationLinkHandler } from "#src/repositories/user";
-import { LinkTypes, UnverifiedLinkTypes } from "#src/types";
+import { LinkTypes, SuperWeakLinkTypes, UnverifiedLinkTypes } from "#src/types";
 import { getEmailDomain } from "@proconnect-gouv/proconnect.core/services/email";
 import { match } from "ts-pattern";
@@ -30,7 +30,7 @@ export function assignUserVerificationTypeToDomainFactory({
           if (
             userDomain === domain &&
             match(link_verification_type)
-              .with(...UnverifiedLinkTypes, () => true)
+              .with(...UnverifiedLinkTypes, ...SuperWeakLinkTypes, () => true)
               .otherwise(() => false)
           ) {
             return updateUserOrganizationLink(organization_id, id, {

package/src/types/user-organization-link.ts CHANGED Viewed

@@ -1,9 +1,10 @@
 import { z } from "zod";
+export const StrongLinkTypes = ["organization_dirigeant"] as const;
 export const WeakLinkTypes = [
   "code_sent_to_official_contact_email",
   "domain",
-  "domain_not_verified_yet",
   "imported_from_coop_mediation_numerique",
   "imported_from_inclusion_connect",
   "in_liste_dirigeants_rna",
@@ -16,11 +17,16 @@ export const WeakLinkTypes = [
   "bypassed",
 ] as const;
-export const StrongLinkTypes = ["organization_dirigeant"] as const;
+// This link type should be considered as unverified.
+// However, doing so would trigger a FranceConnect authentication requirement for the user.
+// Users shouldn't face inconvenience while waiting for domain review completion.
+// Instead, we should remove these unverified domains and then eliminate this special case from the codebase.
+export const SuperWeakLinkTypes = ["domain_not_verified_yet"] as const;
-export const VerifiedLinkTypes = [
-  ...WeakLinkTypes,
+const VerifiedLinkTypes = [
   ...StrongLinkTypes,
+  ...WeakLinkTypes,
+  ...SuperWeakLinkTypes,
 ] as const;
 export const UnverifiedLinkTypes = [

package/testing/seed/franceconnect/index.ts CHANGED Viewed

@@ -41,3 +41,17 @@ export const RogalDornFranceConnectUserInfo: FranceConnectUserInfo = {
   updated_at: new Date(),
   user_id: NaN,
 };
+export const AmberleyVailFranceConnectUserInfo: FranceConnectUserInfo = {
+  birthcountry: "99102",
+  birthdate: new Date(Date.UTC(29000, 6, 7)),
+  birthplace: "",
+  created_at: new Date("2023-04-10"),
+  family_name: "Vail",
+  gender: "female",
+  given_name: "Amberley",
+  preferred_username: "Holy Inquisition",
+  sub: "ORDOS546",
+  updated_at: new Date(),
+  user_id: NaN,
+};