@proconnect-gouv/proconnect.identite 1.2.0 → 1.3.0

package/src/data/certification/index.ts

@@ -1,4 +1,5 @@
 //
 
+export * from "./categories-juridiques-sources.js";
 export * from "./commune-code-conversion.js";
 export * from "./country-iso-to-cog.js";

package/src/errors/index.ts

@@ -1,12 +1,5 @@
 //
 
-export class InvalidCertificationError extends Error {
-  constructor(message?: string, options?: ErrorOptions) {
-    super(message, options);
-    this.name = "InvalidCertificationError";
-  }
-}
-
 export class InvalidSiretError extends Error {
   constructor(message?: string, options?: ErrorOptions) {
     super(message, options);
@@ -21,13 +14,6 @@ export class NotFoundError extends Error {
   }
 }
 
-export class OrganizationNotActiveError extends Error {
-  constructor(message?: string, options?: ErrorOptions) {
-    super(message, options);
-    this.name = "OrganizationNotActiveError";
-  }
-}
-
 export class OrganizationNotFoundError extends Error {
   constructor(message?: string, options?: ErrorOptions) {
     super(message, options);
@@ -41,10 +27,3 @@ export class UserNotFoundError extends Error {
     this.name = "UserNotFoundError";
   }
 }
-
-export class ModerationNotFoundError extends Error {
-  constructor(message?: string, options?: ErrorOptions) {
-    super(message, options);
-    this.name = "ModerationNotFoundError";
-  }
-}

package/src/managers/certification/certification-score.test.ts

@@ -9,7 +9,7 @@ import { certificationScore } from "./certification-score.js";
 describe("certification scoring", () => {
   it("perfect match - all 5 criteria", () => {
     // All criteria match: family name, first name, gender, birthdate, birthplace
-    assert.equal(
+    assert.deepStrictEqual(
       certificationScore(
         {
           birthcountry: null,
@@ -28,13 +28,19 @@ describe("certification scoring", () => {
           given_name: "Stéphane",
         },
       ),
-      5,
+      new Set([
+        "family_name",
+        "first_name",
+        "gender",
+        "birth_date",
+        "birth_place",
+      ]),
     );
   });
 
   it("family name mismatch", () => {
-    // Different family name = -1 point
-    assert.equal(
+    // Different family name = missing family_name
+    assert.deepStrictEqual(
       certificationScore(
         {
           birthcountry: null,
@@ -53,13 +59,13 @@ describe("certification scoring", () => {
           given_name: "Stéphane",
         },
       ),
-      4,
+      new Set(["first_name", "gender", "birth_date", "birth_place"]),
     );
   });
 
   it("different birthdate", () => {
-    // Different birthdate = -1 point
-    assert.equal(
+    // Different birthdate = missing birth_date
+    assert.deepStrictEqual(
       certificationScore(
         {
           birthcountry: null,
@@ -78,13 +84,13 @@ describe("certification scoring", () => {
           given_name: "Stéphane",
         },
       ),
-      4,
+      new Set(["family_name", "first_name", "gender", "birth_place"]),
     );
   });
 
   it("different birthplace", () => {
-    // Different birthplace = -1 point
-    assert.equal(
+    // Different birthplace = missing birth_place
+    assert.deepStrictEqual(
       certificationScore(
         {
           birthcountry: null,
@@ -103,13 +109,13 @@ describe("certification scoring", () => {
           given_name: "Stéphane",
         },
       ),
-      4,
+      new Set(["family_name", "first_name", "gender", "birth_date"]),
     );
   });
 
   it("swapped first and family names", () => {
-    // Both names don't match = -2 points
-    assert.equal(
+    // Both names don't match = missing both name criteria
+    assert.deepStrictEqual(
       certificationScore(
         {
           birthcountry: null,
@@ -128,13 +134,13 @@ describe("certification scoring", () => {
           given_name: "Stéphane",
         },
       ),
-      3,
+      new Set(["gender", "birth_date", "birth_place"]),
     );
   });
 
   it("different gender still matches when source gender is null", () => {
-    // Gender is null in source = still gets point
-    assert.equal(
+    // Gender is null in source = still gets gender match
+    assert.deepStrictEqual(
       certificationScore(
         {
           birthcountry: null,
@@ -153,13 +159,19 @@ describe("certification scoring", () => {
           given_name: "Stéphane",
         },
       ),
-      5,
+      new Set([
+        "family_name",
+        "first_name",
+        "gender",
+        "birth_date",
+        "birth_place",
+      ]),
     );
   });
 
   it("different gender when source has gender", () => {
-    // Different gender = -1 point
-    assert.equal(
+    // Different gender = missing gender
+    assert.deepStrictEqual(
       certificationScore(
         {
           birthcountry: null,
@@ -178,13 +190,13 @@ describe("certification scoring", () => {
           given_name: "Stéphane",
         },
       ),
-      4,
+      new Set(["family_name", "first_name", "birth_date", "birth_place"]),
     );
   });
 
   it("matches first name with hyphen normalization", () => {
-    // Jean-Pierre and Jean Pierre should match (first name is "Jean")
-    assert.equal(
+    // Jean-Pierre and Jean Marc should match (first name is "Jean")
+    assert.deepStrictEqual(
       certificationScore(
         {
           birthcountry: null,
@@ -203,13 +215,19 @@ describe("certification scoring", () => {
           given_name: "Jean Marc",
         },
       ),
-      5,
+      new Set([
+        "family_name",
+        "first_name",
+        "gender",
+        "birth_date",
+        "birth_place",
+      ]),
     );
   });
 
   it("birthplace with commune code conversion", () => {
     // 75050 should convert to 92050
-    assert.equal(
+    assert.deepStrictEqual(
       certificationScore(
         {
           birthcountry: null,
@@ -228,13 +246,19 @@ describe("certification scoring", () => {
           given_name: "Stéphane",
         },
       ),
-      5,
+      new Set([
+        "family_name",
+        "first_name",
+        "gender",
+        "birth_date",
+        "birth_place",
+      ]),
     );
   });
 
   it("null birthplace in source still matches", () => {
-    // Null birthplace in source = still gets point
-    assert.equal(
+    // Null birthplace in source = still gets birth_place match
+    assert.deepStrictEqual(
       certificationScore(
         {
           birthcountry: null,
@@ -253,13 +277,19 @@ describe("certification scoring", () => {
           given_name: "Stéphane",
         },
       ),
-      5,
+      new Set([
+        "family_name",
+        "first_name",
+        "gender",
+        "birth_date",
+        "birth_place",
+      ]),
     );
   });
 
   it("foreign person with matching country", () => {
     // For foreigners, check country code
-    assert.equal(
+    assert.deepStrictEqual(
       certificationScore(
         {
           birthcountry: "99136",
@@ -278,13 +308,19 @@ describe("certification scoring", () => {
           given_name: "Patrick",
         },
       ),
-      5,
+      new Set([
+        "family_name",
+        "first_name",
+        "gender",
+        "birth_date",
+        "birth_country",
+      ]),
     );
   });
 
   it("foreign person with different country", () => {
-    // Different country = -1 point
-    assert.equal(
+    // Different country = missing birth_country
+    assert.deepStrictEqual(
       certificationScore(
         {
           birthcountry: "99136", // Ireland
@@ -303,7 +339,7 @@ describe("certification scoring", () => {
           given_name: "Patrick",
         },
       ),
-      4,
+      new Set(["family_name", "first_name", "gender", "birth_date"]),
     );
   });
 });

package/src/managers/certification/certification-score.ts

@@ -1,11 +1,22 @@
 //
 
 import type { IdentityVector } from "#src/types";
+import z from "zod/v4";
 import { convertCommuneCode } from "./birthplace-conversion.js";
 import { extractFirstName, normalizeText } from "./normalize.js";
 
 //
 
+export const MatchCriteria = z.enum([
+  "birth_country",
+  "birth_date",
+  "birth_place",
+  "family_name",
+  "first_name",
+  "gender",
+]);
+export type MatchCriteria = z.output<typeof MatchCriteria>;
+
 /**
  * Calculates a certification score between identity from FranceConnect (IdentitePivot)
  * and executive identity from business registries (SourceDirigeant).
@@ -28,8 +39,8 @@ import { extractFirstName, normalizeText } from "./normalize.js";
 export function certificationScore(
   identitePivot: IdentityVector,
   sourceDirigeant: IdentityVector,
-): number {
-  let score = 0;
+) {
+  const matches = new Set<MatchCriteria>();
 
   // 1. Family name match (after normalization)
   const normalizedFamilyNamePivot = normalizeText(identitePivot.family_name);
@@ -40,7 +51,7 @@ export function certificationScore(
     normalizedFamilyNameSource &&
     normalizedFamilyNamePivot === normalizedFamilyNameSource
   ) {
-    score += 1;
+    matches.add(MatchCriteria.enum.family_name);
   }
 
   // 2. First name match (first name only, after normalization)
@@ -48,7 +59,7 @@ export function certificationScore(
   const firstNameSource = extractFirstName(sourceDirigeant.given_name);
 
   if (firstNamePivot && firstNameSource && firstNamePivot === firstNameSource) {
-    score += 1;
+    matches.add(MatchCriteria.enum.first_name);
   }
 
   // 3. Gender match (match or absent in source)
@@ -56,7 +67,7 @@ export function certificationScore(
     !sourceDirigeant.gender ||
     identitePivot.gender === sourceDirigeant.gender
   ) {
-    score += 1;
+    matches.add(MatchCriteria.enum.gender);
   }
 
   // 4. Birth date match (exact match)
@@ -65,7 +76,7 @@ export function certificationScore(
     sourceDirigeant.birthdate &&
     identitePivot.birthdate.getTime() === sourceDirigeant.birthdate.getTime()
   ) {
-    score += 1;
+    matches.add(MatchCriteria.enum.birth_date);
   }
 
   // 5. Birth place match (different logic for French vs foreigners)
@@ -79,7 +90,7 @@ export function certificationScore(
 
     // Match if equal or if source has no commune data
     if (!communeSource || (communePivot && communePivot === communeSource)) {
-      score += 1;
+      matches.add(MatchCriteria.enum.birth_place);
     }
   } else {
     // For foreigners: check country code (with conversion if needed from RNE)
@@ -89,9 +100,9 @@ export function certificationScore(
       sourceDirigeant.birthcountry &&
       identitePivot.birthcountry === sourceDirigeant.birthcountry
     ) {
-      score += 1;
+      matches.add(MatchCriteria.enum.birth_country);
     }
   }
 
-  return score;
+  return matches;
 }

package/src/managers/certification/index.ts

@@ -1,4 +1,4 @@
 //
 
 export * from "./certification-score.js";
-export * from "./is-organization-dirigeant.js";
+export * from "./process-certification-dirigeant.js";

package/src/managers/certification/{is-organization-dirigeant.test.ts → process-certification-dirigeant.test.ts}

@@ -1,6 +1,5 @@
 //
 
-import { InvalidCertificationError, NotFoundError } from "#src/errors";
 import { IdentityVectorSchema } from "#src/types";
 import {
   LiElJonsonFranceConnectUserInfo,
@@ -24,13 +23,13 @@ import {
 } from "@proconnect-gouv/proconnect.registre_national_entreprises/testing/seed";
 import assert from "node:assert/strict";
 import { describe, it } from "node:test";
-import { isOrganizationDirigeantFactory } from "./is-organization-dirigeant.js";
+import { processCertificationDirigeantFactory } from "./process-certification-dirigeant.js";
 
 //
 
-describe("isOrganizationDirigeantFactory", () => {
+describe("processCertificationDirigeantFactory", () => {
   it("should recognize a user as executive of a auto-entrepreneur", async () => {
-    const isOrganizationDirigeant = isOrganizationDirigeantFactory({
+    const processCertificationDirigeant = processCertificationDirigeantFactory({
       ApiEntrepriseInfogreffeRepository: {
         findMandatairesSociauxBySiren: () => Promise.reject(new Error("💣")),
       },
@@ -40,22 +39,27 @@ describe("isOrganizationDirigeantFactory", () => {
       InseeApiRepository: {
         findBySiren: () => Promise.resolve(RogalDornEstablishment),
       },
-      FranceConnectApiRepository: {
-        getFranceConnectUserInfo: () =>
-          Promise.resolve(RogalDornFranceConnectUserInfo),
-      },
     });
 
-    const isDirigeant = await isOrganizationDirigeant(rogal_dorn_org_info, 1);
+    const certificationDirigeantResult = await processCertificationDirigeant(
+      rogal_dorn_org_info,
+      RogalDornFranceConnectUserInfo,
+    );
 
-    assert.deepEqual(isDirigeant, {
+    assert.deepEqual(certificationDirigeantResult, {
       cause: "exact_match",
       details: {
         dirigeant: {
           ...IdentityVectorSchema.parse(RogalDornFranceConnectUserInfo),
           birthplace: null, // INSEE adapter returns null for foreigners
         },
-        score: 5,
+        matches: new Set([
+          "family_name",
+          "first_name",
+          "gender",
+          "birth_date",
+          "birth_country",
+        ]),
         identity: IdentityVectorSchema.parse(RogalDornFranceConnectUserInfo),
         source: "api.insee.fr/api-sirene/private",
       },
@@ -64,7 +68,7 @@ describe("isOrganizationDirigeantFactory", () => {
   });
 
   it("should not match another mandataire", async () => {
-    const isOrganizationDirigeant = isOrganizationDirigeantFactory({
+    const processCertificationDirigeant = processCertificationDirigeantFactory({
       ApiEntrepriseInfogreffeRepository: {
         findMandatairesSociauxBySiren: () => Promise.reject(new Error("💣")),
       },
@@ -74,22 +78,21 @@ describe("isOrganizationDirigeantFactory", () => {
       InseeApiRepository: {
         findBySiren: () => Promise.resolve(LiElJonsonEstablishment),
       },
-      FranceConnectApiRepository: {
-        getFranceConnectUserInfo: () =>
-          Promise.resolve(RogalDornFranceConnectUserInfo),
-      },
     });
 
-    const isDirigeant = await isOrganizationDirigeant(rogal_dorn_org_info, 1);
+    const certificationDirigeantResult = await processCertificationDirigeant(
+      rogal_dorn_org_info,
+      RogalDornFranceConnectUserInfo,
+    );
 
-    assert.deepEqual(isDirigeant, {
+    assert.deepEqual(certificationDirigeantResult, {
       cause: "below_threshold",
       details: {
         dirigeant: {
           ...IdentityVectorSchema.parse(LiElJonsonFranceConnectUserInfo),
           birthcountry: null, // INSEE adapter returns null for French people
         },
-        score: 1,
+        matches: new Set(["gender"]),
         identity: IdentityVectorSchema.parse(RogalDornFranceConnectUserInfo),
         source: "api.insee.fr/api-sirene/private",
       },
@@ -98,7 +101,7 @@ describe("isOrganizationDirigeantFactory", () => {
   });
 
   it("should match Rogal Dorn among the executive of Papillon in RNE", async () => {
-    const isOrganizationDirigeant = isOrganizationDirigeantFactory({
+    const processCertificationDirigeant = processCertificationDirigeantFactory({
       ApiEntrepriseInfogreffeRepository: {
         findMandatairesSociauxBySiren: () => Promise.reject(new Error("💣")),
       },
@@ -109,22 +112,27 @@ describe("isOrganizationDirigeantFactory", () => {
       InseeApiRepository: {
         findBySiren: () => Promise.reject(new Error("💣")),
       },
-      FranceConnectApiRepository: {
-        getFranceConnectUserInfo: () =>
-          Promise.resolve(RogalDornFranceConnectUserInfo),
-      },
     });
 
-    const isDirigeant = await isOrganizationDirigeant(papillon_org_info, 1);
+    const certificationDirigeantResult = await processCertificationDirigeant(
+      papillon_org_info,
+      RogalDornFranceConnectUserInfo,
+    );
 
-    assert.deepEqual(isDirigeant, {
+    assert.deepEqual(certificationDirigeantResult, {
       cause: "exact_match",
       details: {
         dirigeant: {
           ...IdentityVectorSchema.parse(RogalDornFranceConnectUserInfo),
           birthplace: null, // RNE adapter returns null for foreigners
         },
-        score: 5,
+        matches: new Set([
+          "family_name",
+          "first_name",
+          "gender",
+          "birth_date",
+          "birth_country",
+        ]),
         identity: IdentityVectorSchema.parse(RogalDornFranceConnectUserInfo),
         source: "registre-national-entreprises.inpi.fr/api",
       },
@@ -133,7 +141,7 @@ describe("isOrganizationDirigeantFactory", () => {
   });
 
   it("should match Rogal Dorn among the executive of Papillon in Infogreffe", async () => {
-    const isOrganizationDirigeant = isOrganizationDirigeantFactory({
+    const processCertificationDirigeant = processCertificationDirigeantFactory({
       ApiEntrepriseInfogreffeRepository: {
         findMandatairesSociauxBySiren: () =>
           Promise.resolve([UlysseToriMandataire, RogalDornMandataire]),
@@ -144,15 +152,14 @@ describe("isOrganizationDirigeantFactory", () => {
       InseeApiRepository: {
         findBySiren: () => Promise.reject(new Error("💣")),
       },
-      FranceConnectApiRepository: {
-        getFranceConnectUserInfo: () =>
-          Promise.resolve(RogalDornFranceConnectUserInfo),
-      },
     });
 
-    const isDirigeant = await isOrganizationDirigeant(papillon_org_info, 1);
+    const certificationDirigeantResult = await processCertificationDirigeant(
+      papillon_org_info,
+      RogalDornFranceConnectUserInfo,
+    );
 
-    assert.deepEqual(isDirigeant, {
+    assert.deepEqual(certificationDirigeantResult, {
       cause: "exact_match",
       details: {
         dirigeant: {
@@ -160,7 +167,13 @@ describe("isOrganizationDirigeantFactory", () => {
           birthplace: null, // API Entreprise adapter doesn't provide birthplace
           gender: null, // API Entreprise adapter doesn't provide gender
         },
-        score: 5,
+        matches: new Set([
+          "family_name",
+          "first_name",
+          "gender",
+          "birth_date",
+          "birth_country",
+        ]),
         identity: IdentityVectorSchema.parse(RogalDornFranceConnectUserInfo),
         source:
           "entreprise.api.gouv.fr/v3/infogreffe/rcs/unites_legales/{siren}/mandataires_sociaux",
@@ -169,48 +182,33 @@ describe("isOrganizationDirigeantFactory", () => {
     });
   });
 
-  it("❎ fail with no franceconnect user info", async () => {
-    const isOrganizationDirigeant = isOrganizationDirigeantFactory({
+  it("❎ fail with no mandataires", async () => {
+    const processCertificationDirigeant = processCertificationDirigeantFactory({
       ApiEntrepriseInfogreffeRepository: {
         findMandatairesSociauxBySiren: () => Promise.reject(new Error("💣")),
       },
       RegistreNationalEntreprisesApiRepository: {
-        findPouvoirsBySiren: () => Promise.reject(new Error("💣")),
+        findPouvoirsBySiren: () => Promise.resolve([]),
       },
       InseeApiRepository: {
         findBySiren: () => Promise.reject(new Error("💣")),
       },
-      FranceConnectApiRepository: {
-        getFranceConnectUserInfo: () => Promise.resolve(undefined),
-      },
     });
 
-    await assert.rejects(
-      isOrganizationDirigeant(rogal_dorn_org_info, 1),
-      new NotFoundError("FranceConnect UserInfo not found"),
+    const certificationDirigeantResult = await processCertificationDirigeant(
+      papillon_org_info,
+      LiElJonsonFranceConnectUserInfo,
     );
-  });
 
-  it("❎ fail with no mandataires", async () => {
-    const isOrganizationDirigeant = isOrganizationDirigeantFactory({
-      ApiEntrepriseInfogreffeRepository: {
-        findMandatairesSociauxBySiren: () => Promise.reject(new Error("💣")),
-      },
-      RegistreNationalEntreprisesApiRepository: {
-        findPouvoirsBySiren: () => Promise.resolve([]),
-      },
-      InseeApiRepository: {
-        findBySiren: () => Promise.reject(new Error("💣")),
-      },
-      FranceConnectApiRepository: {
-        getFranceConnectUserInfo: () =>
-          Promise.resolve(LiElJonsonFranceConnectUserInfo),
+    assert.deepEqual(certificationDirigeantResult, {
+      cause: "no_candidates",
+      details: {
+        dirigeant: undefined,
+        identity: IdentityVectorSchema.parse(LiElJonsonFranceConnectUserInfo),
+        matches: new Set(),
+        source: "registre-national-entreprises.inpi.fr/api",
       },
+      ok: false,
     });
-
-    await assert.rejects(
-      isOrganizationDirigeant(papillon_org_info, 1),
-      new InvalidCertificationError("No candidates found"),
-    );
   });
 });