@probolabs/playwright 1.4.0-rc.3 → 1.4.0-rc.5

package/dist/index.d.ts

@@ -433,6 +433,11 @@ declare class ProboCodeGenerator {
      * Get default viewport dimensions
      */
     private static getDefaultViewPort;
+    /**
+     * Validate and normalize viewport dimensions
+     * Returns a valid viewport object with numeric width and height, falling back to defaults if invalid
+     */
+    private static normalizeViewPort;
     /**
      * Generate code for a single scenario
      * Fetches scenario data, converts to Interaction[], generates code
@@ -470,6 +475,7 @@ interface TestStatistics {
 interface TestSuiteRunOptions {
     outputDir?: string;
     includeReporter?: boolean;
+    playwrightArgs?: string[];
     onStatusUpdate?: (updates: Partial<{
         status: string;
         exit_code: number;

package/dist/index.js

@@ -1656,7 +1656,6 @@ export default defineConfig({
   // Keep Playwright's default console output, plus HTML report${includeReporter ? ', plus Probo live progress reporter' : ''}.
   reporter: ${JSON.stringify(reporters)},
   use: {
-    headless: true,
     ignoreHTTPSErrors: true,
     actionTimeout: 30000,
     navigationTimeout: 30000,
@@ -1665,7 +1664,6 @@ export default defineConfig({
     trace: 'on',
   },
   retries: 0,
-  workers: 1,
 });
 `;
 }
@@ -5850,6 +5848,19 @@ class ProboCodeGenerator {
     static getDefaultViewPort() {
         return { width: 1280, height: 720 };
     }
+    /**
+     * Validate and normalize viewport dimensions
+     * Returns a valid viewport object with numeric width and height, falling back to defaults if invalid
+     */
+    static normalizeViewPort(viewPort) {
+        const defaultViewPort = this.getDefaultViewPort();
+        if (!viewPort) {
+            return defaultViewPort;
+        }
+        const width = typeof viewPort.width === 'number' && !isNaN(viewPort.width) ? viewPort.width : defaultViewPort.width;
+        const height = typeof viewPort.height === 'number' && !isNaN(viewPort.height) ? viewPort.height : defaultViewPort.height;
+        return { width, height };
+    }
     /**
      * Generate code for a single scenario
      * Fetches scenario data, converts to Interaction[], generates code
@@ -5868,7 +5879,7 @@ class ProboCodeGenerator {
         const interactions = this.convertBackendInteractionsToInteractionFormat(scenarioData.interactions || []);
         // Get settings and viewport
         const settings = (options === null || options === void 0 ? void 0 : options.recorderSettings) || this.getDefaultRecorderSettings();
-        const viewPort = (options === null || options === void 0 ? void 0 : options.viewPort) || scenarioData.viewPort || this.getDefaultViewPort();
+        const viewPort = this.normalizeViewPort((options === null || options === void 0 ? void 0 : options.viewPort) || scenarioData.viewPort);
         // Get parameter table rows
         const rows = scenarioData.parameterTable || [];
         // Generate code
@@ -6054,6 +6065,22 @@ class TestSuiteRunner {
             throw new Error(`Failed to lookup test suite: ${response.status} ${errorText}`);
         }
         const data = await response.json();
+        // TEMPORARY DEBUG: Output the full response
+        console.log('🔍 DEBUG: API Response URL:', url);
+        console.log('🔍 DEBUG: API Response Status:', response.status);
+        console.log('🔍 DEBUG: API Response Data:', JSON.stringify(data, null, 2));
+        console.log('🔍 DEBUG: Is Array?', Array.isArray(data));
+        console.log('🔍 DEBUG: Array length:', Array.isArray(data) ? data.length : 'N/A');
+        console.log('🔍 DEBUG: Has results?', !!data.results);
+        console.log('🔍 DEBUG: Results is Array?', Array.isArray(data.results));
+        console.log('🔍 DEBUG: Results length:', Array.isArray(data.results) ? data.results.length : 'N/A');
+        if (Array.isArray(data) && data.length > 0) {
+            console.log('🔍 DEBUG: First item:', JSON.stringify(data[0], null, 2));
+        }
+        if (data.results && Array.isArray(data.results) && data.results.length > 0) {
+            console.log('🔍 DEBUG: First result:', JSON.stringify(data.results[0], null, 2));
+        }
+        console.log('');
         if (Array.isArray(data) && data.length > 0) {
             return data[0].id;
         }
@@ -6072,7 +6099,52 @@ class TestSuiteRunner {
         if (codeGenResult.scenarios.length === 0) {
             throw new Error(`No scenarios found in test suite ${testSuiteId}. Cannot generate test files.`);
         }
-        // Ensure directories exist
+        // Delete everything in the test suite directory except node_modules
+        // This ensures a clean state while preserving dependencies for faster subsequent runs
+        if (fs.existsSync(testSuiteDir)) {
+            try {
+                const nodeModulesPath = path.join(testSuiteDir, 'node_modules');
+                const hasNodeModules = fs.existsSync(nodeModulesPath);
+                // Temporarily move node_modules out of the way if it exists
+                let tempNodeModulesPath = null;
+                if (hasNodeModules) {
+                    tempNodeModulesPath = path.join(testSuiteDir, '..', `node_modules.temp.${testSuiteId}`);
+                    // Remove temp directory if it exists from a previous failed run
+                    if (fs.existsSync(tempNodeModulesPath)) {
+                        fs.rmSync(tempNodeModulesPath, { recursive: true, force: true });
+                    }
+                    fs.renameSync(nodeModulesPath, tempNodeModulesPath);
+                    console.log(`📦 Preserved node_modules temporarily`);
+                }
+                // Delete everything in the directory
+                const entries = fs.readdirSync(testSuiteDir, { withFileTypes: true });
+                for (const entry of entries) {
+                    const entryPath = path.join(testSuiteDir, entry.name);
+                    try {
+                        if (entry.isDirectory()) {
+                            fs.rmSync(entryPath, { recursive: true, force: true });
+                        }
+                        else {
+                            fs.unlinkSync(entryPath);
+                        }
+                    }
+                    catch (error) {
+                        console.warn(`⚠️  Failed to delete ${entry.name}:`, error);
+                    }
+                }
+                console.log(`🗑️  Cleaned test suite directory (preserved node_modules)`);
+                // Move node_modules back
+                if (hasNodeModules && tempNodeModulesPath) {
+                    fs.renameSync(tempNodeModulesPath, nodeModulesPath);
+                    console.log(`📦 Restored node_modules`);
+                }
+            }
+            catch (error) {
+                console.warn(`⚠️  Failed to clean test suite directory ${testSuiteDir}:`, error);
+                // Continue anyway - we'll overwrite files as needed
+            }
+        }
+        // Ensure directories exist (will recreate after deletion)
         ensureDirectoryExists(testSuiteDir);
         const testsDir = path.join(testSuiteDir, 'tests');
         ensureDirectoryExists(testsDir);
@@ -6159,7 +6231,7 @@ class TestSuiteRunner {
      * Generates files, installs dependencies, and executes tests
      */
     static async runTestSuite(testSuiteId, apiToken, apiUrl, testSuiteName, runId, options = {}) {
-        const { outputDir, includeReporter = true, onStatusUpdate, onStdout, onStderr, onReporterEvent, } = options;
+        const { outputDir, includeReporter = true, playwrightArgs = [], onStatusUpdate, onStdout, onStderr, onReporterEvent, } = options;
         const testSuiteDir = outputDir || getDefaultTestSuiteDir(testSuiteId, testSuiteName);
         let currentRunId = runId;
         try {
@@ -6238,6 +6310,9 @@ class TestSuiteRunner {
             }
             // Run Playwright tests with streaming output
             console.log(`🚀 Running Playwright tests in ${testSuiteDir}...`);
+            if (playwrightArgs.length > 0) {
+                console.log(`🧪 Playwright extra args: ${playwrightArgs.join(' ')}`);
+            }
             return new Promise(async (resolve) => {
                 var _a, _b;
                 let stdout = '';
@@ -6254,7 +6329,7 @@ class TestSuiteRunner {
                 let lastStepsUpdate = 0;
                 const collectedSteps = [];
                 // Use spawn for streaming output
-                const testProcess = spawn('npx', ['playwright', 'test'], {
+                const testProcess = spawn('npx', ['playwright', 'test', ...playwrightArgs], {
                     cwd: testSuiteDir,
                     shell: true,
                     stdio: ['ignore', 'pipe', 'pipe'],