@probolabs/playwright 1.4.0-rc.2 → 1.4.0-rc.4

package/dist/index.d.ts

@@ -470,6 +470,7 @@ interface TestStatistics {
 interface TestSuiteRunOptions {
     outputDir?: string;
     includeReporter?: boolean;
+    playwrightArgs?: string[];
     onStatusUpdate?: (updates: Partial<{
         status: string;
         exit_code: number;

package/dist/index.js

@@ -1656,7 +1656,6 @@ export default defineConfig({
   // Keep Playwright's default console output, plus HTML report${includeReporter ? ', plus Probo live progress reporter' : ''}.
   reporter: ${JSON.stringify(reporters)},
   use: {
-    headless: true,
     ignoreHTTPSErrors: true,
     actionTimeout: 30000,
     navigationTimeout: 30000,
@@ -1665,7 +1664,6 @@ export default defineConfig({
     trace: 'on',
   },
   retries: 0,
-  workers: 1,
 });
 `;
 }
@@ -6069,6 +6067,9 @@ class TestSuiteRunner {
         const testSuiteDir = outputDir || getDefaultTestSuiteDir(testSuiteId, testSuiteName);
         // Generate code for all scenarios
         const codeGenResult = await ProboCodeGenerator.generateCodeForTestSuite(testSuiteId, apiToken, apiUrl);
+        if (codeGenResult.scenarios.length === 0) {
+            throw new Error(`No scenarios found in test suite ${testSuiteId}. Cannot generate test files.`);
+        }
         // Ensure directories exist
         ensureDirectoryExists(testSuiteDir);
         const testsDir = path.join(testSuiteDir, 'tests');
@@ -6094,8 +6095,35 @@ class TestSuiteRunner {
      */
     static async generatePackageJson(outputDir, codeGenResult) {
         // Check if any scenario has secrets by examining the generated code
-        // We'll check for dotenv imports in the generated code
-        const hasSecrets = codeGenResult.scenarios.some(scenario => scenario.code.includes("import { config } from 'dotenv'"));
+        // We'll check for dotenv imports in the generated code (check for multiple patterns to be robust)
+        let hasSecrets = codeGenResult.scenarios.some(scenario => {
+            const code = scenario.code;
+            return code.includes("from 'dotenv'") ||
+                code.includes('from "dotenv"') ||
+                code.includes("import { config } from 'dotenv'") ||
+                code.includes('import { config } from "dotenv"') ||
+                code.includes("require('dotenv')") ||
+                code.includes('require("dotenv")');
+        });
+        // Fallback: if not detected in codeGenResult, check the actual written files
+        // This handles edge cases where the code might have been modified or generated differently
+        if (!hasSecrets) {
+            const testsDir = path.join(outputDir, 'tests');
+            if (fs.existsSync(testsDir)) {
+                const specFiles = fs.readdirSync(testsDir).filter(f => f.endsWith('.spec.ts'));
+                for (const specFile of specFiles) {
+                    const filePath = path.join(testsDir, specFile);
+                    const content = fs.readFileSync(filePath, 'utf-8');
+                    if (content.includes("from 'dotenv'") ||
+                        content.includes('from "dotenv"') ||
+                        content.includes("import { config } from 'dotenv'") ||
+                        content.includes('import { config } from "dotenv"')) {
+                        hasSecrets = true;
+                        break;
+                    }
+                }
+            }
+        }
         const sanitizedName = slugify(codeGenResult.testSuiteName);
         const packageJsonContent = generatePackageJson({
             name: sanitizedName,
@@ -6129,7 +6157,7 @@ class TestSuiteRunner {
      * Generates files, installs dependencies, and executes tests
      */
     static async runTestSuite(testSuiteId, apiToken, apiUrl, testSuiteName, runId, options = {}) {
-        const { outputDir, includeReporter = true, onStatusUpdate, onStdout, onStderr, onReporterEvent, } = options;
+        const { outputDir, includeReporter = true, playwrightArgs = [], onStatusUpdate, onStdout, onStderr, onReporterEvent, } = options;
         const testSuiteDir = outputDir || getDefaultTestSuiteDir(testSuiteId, testSuiteName);
         let currentRunId = runId;
         try {
@@ -6208,6 +6236,9 @@ class TestSuiteRunner {
             }
             // Run Playwright tests with streaming output
             console.log(`🚀 Running Playwright tests in ${testSuiteDir}...`);
+            if (playwrightArgs.length > 0) {
+                console.log(`🧪 Playwright extra args: ${playwrightArgs.join(' ')}`);
+            }
             return new Promise(async (resolve) => {
                 var _a, _b;
                 let stdout = '';
@@ -6224,7 +6255,7 @@ class TestSuiteRunner {
                 let lastStepsUpdate = 0;
                 const collectedSteps = [];
                 // Use spawn for streaming output
-                const testProcess = spawn('npx', ['playwright', 'test'], {
+                const testProcess = spawn('npx', ['playwright', 'test', ...playwrightArgs], {
                     cwd: testSuiteDir,
                     shell: true,
                     stdio: ['ignore', 'pipe', 'pipe'],