@probelabs/visor 0.1.92 → 0.1.94

package/dist/sdk/sdk.js

@@ -2424,14 +2424,66 @@ var init_reviewer = __esm({
           "No configuration provided. Please create a .visor.yaml file with check definitions. Built-in prompts have been removed - all checks must be explicitly configured."
         );
       }
+      /**
+       * Helper to check if a schema definition has a "text" field in its properties
+       */
+      async schemaHasTextField(schema) {
+        try {
+          let schemaObj;
+          if (typeof schema === "object") {
+            schemaObj = schema;
+          } else {
+            const fs12 = require("fs").promises;
+            const path12 = require("path");
+            const sanitizedSchemaName = schema.replace(/[^a-zA-Z0-9-]/g, "");
+            if (!sanitizedSchemaName || sanitizedSchemaName !== schema) {
+              return false;
+            }
+            const schemaPath = path12.join(process.cwd(), "output", sanitizedSchemaName, "schema.json");
+            try {
+              const schemaContent = await fs12.readFile(schemaPath, "utf-8");
+              schemaObj = JSON.parse(schemaContent);
+            } catch {
+              return false;
+            }
+          }
+          const properties = schemaObj.properties;
+          return !!(properties && "text" in properties);
+        } catch {
+          return false;
+        }
+      }
+      /**
+       * Filter check results to only include those that should post GitHub comments
+       */
+      async filterCommentGeneratingChecks(checkResults, config) {
+        const filtered = [];
+        for (const r of checkResults) {
+          const cfg = config.checks?.[r.checkName];
+          const type = cfg?.type || "ai";
+          const schema = cfg?.schema;
+          let shouldPostComment = false;
+          const isAICheck = type === "ai" || type === "claude-code";
+          if (!schema || schema === "") {
+            shouldPostComment = isAICheck;
+          } else if (typeof schema === "string") {
+            if (schema === "text" || schema === "plain") {
+              shouldPostComment = true;
+            } else {
+              shouldPostComment = await this.schemaHasTextField(schema);
+            }
+          } else if (typeof schema === "object") {
+            shouldPostComment = await this.schemaHasTextField(schema);
+          }
+          if (shouldPostComment) {
+            filtered.push(r);
+          }
+        }
+        return filtered;
+      }
       async postReviewComment(owner, repo, prNumber, groupedResults, options = {}) {
         for (const [groupName, checkResults] of Object.entries(groupedResults)) {
-          const filteredResults = options.config ? checkResults.filter((r) => {
-            const cfg = options.config.checks?.[r.checkName];
-            const t = cfg?.type || "";
-            const isGitHubOps = t === "github" || r.group === "github" || t === "noop" || t === "command";
-            return !isGitHubOps;
-          }) : checkResults;
+          const filteredResults = options.config ? await this.filterCommentGeneratingChecks(checkResults, options.config) : checkResults;
           if (!filteredResults || filteredResults.length === 0) {
             continue;
           }
@@ -3923,8 +3975,19 @@ __export(liquid_extensions_exports, {
   ReadFileTag: () => ReadFileTag,
   configureLiquidWithExtensions: () => configureLiquidWithExtensions,
   createExtendedLiquid: () => createExtendedLiquid,
+  sanitizeLabel: () => sanitizeLabel,
+  sanitizeLabelList: () => sanitizeLabelList,
   withPermissionsContext: () => withPermissionsContext
 });
+function sanitizeLabel(value) {
+  if (value == null) return "";
+  const s = String(value);
+  return s.replace(/[^A-Za-z0-9:\/]/g, "").replace(/\/{2,}/g, "/");
+}
+function sanitizeLabelList(labels) {
+  if (!Array.isArray(labels)) return [];
+  return labels.map((v) => sanitizeLabel(v)).filter((s) => s.length > 0);
+}
 async function withPermissionsContext(ctx, fn) {
   return await permissionsALS.run(ctx, fn);
 }
@@ -3947,15 +4010,8 @@ function configureLiquidWithExtensions(liquid) {
       return "[Error: Unable to serialize to JSON]";
     }
   });
-  liquid.registerFilter("safe_label", (value) => {
-    if (value == null) return "";
-    const s = String(value);
-    return s.replace(/[^A-Za-z0-9:\/]/g, "").replace(/\/{2,}/g, "/");
-  });
-  liquid.registerFilter("safe_label_list", (value) => {
-    if (!Array.isArray(value)) return [];
-    return value.map((v) => v == null ? "" : String(v)).map((s) => s.replace(/[^A-Za-z0-9:\/]/g, "").replace(/\/{2,}/g, "/")).filter((s) => s.length > 0);
-  });
+  liquid.registerFilter("safe_label", (value) => sanitizeLabel(value));
+  liquid.registerFilter("safe_label_list", (value) => sanitizeLabelList(value));
   liquid.registerFilter("unescape_newlines", (value) => {
     if (value == null) return "";
     const s = String(value);
@@ -5123,7 +5179,8 @@ var init_log_check_provider = __esm({
           dependencyResults,
           includePrContext,
           includeDependencies,
-          includeMetadata
+          includeMetadata,
+          config.__outputHistory
         );
         const renderedMessage = await this.liquid.parseAndRender(message, templateContext);
         const logOutput = this.formatLogOutput(
@@ -5144,7 +5201,7 @@ var init_log_check_provider = __esm({
           logOutput
         };
       }
-      buildTemplateContext(prInfo, dependencyResults, _includePrContext = true, _includeDependencies = true, includeMetadata = true) {
+      buildTemplateContext(prInfo, dependencyResults, _includePrContext = true, _includeDependencies = true, includeMetadata = true, outputHistory) {
         const context2 = {};
         context2.pr = {
           number: prInfo.number,
@@ -5168,6 +5225,7 @@ var init_log_check_provider = __esm({
         if (dependencyResults) {
           const dependencies = {};
           const outputs = {};
+          const history = {};
           context2.dependencyCount = dependencyResults.size;
           for (const [checkName, result] of dependencyResults.entries()) {
             dependencies[checkName] = {
@@ -5178,6 +5236,12 @@ var init_log_check_provider = __esm({
             const summary = result;
             outputs[checkName] = summary.output !== void 0 ? summary.output : summary;
           }
+          if (outputHistory) {
+            for (const [checkName, historyArray] of outputHistory) {
+              history[checkName] = historyArray;
+            }
+          }
+          outputs.history = history;
           context2.dependencies = dependencies;
           context2.outputs = outputs;
         }
@@ -6080,7 +6144,10 @@ var init_command_check_provider = __esm({
           },
           files: prInfo.files,
           fileCount: prInfo.files.length,
-          outputs: this.buildOutputContext(dependencyResults),
+          outputs: this.buildOutputContext(
+            dependencyResults,
+            config.__outputHistory
+          ),
           env: this.getSafeEnvironmentVariables()
         };
         logger.debug(
@@ -6806,16 +6873,23 @@ ${stderrOutput}` : `Command execution failed: ${errorMessage}`;
           };
         }
       }
-      buildOutputContext(dependencyResults) {
+      buildOutputContext(dependencyResults, outputHistory) {
         if (!dependencyResults) {
           return {};
         }
         const outputs = {};
+        const history = {};
         for (const [checkName, result] of dependencyResults) {
           const summary = result;
           const value = summary.output !== void 0 ? summary.output : summary;
           outputs[checkName] = this.makeJsonSmart(value);
         }
+        if (outputHistory) {
+          for (const [checkName, historyArray] of outputHistory) {
+            history[checkName] = historyArray.map((val) => this.makeJsonSmart(val));
+          }
+        }
+        outputs.history = history;
         return outputs;
       }
       /**
@@ -7373,7 +7447,12 @@ var init_memory_check_provider = __esm({
         const key = config.key;
         const namespace = config.namespace;
         const memoryStore = MemoryStore.getInstance();
-        const templateContext = this.buildTemplateContext(prInfo, dependencyResults, memoryStore);
+        const templateContext = this.buildTemplateContext(
+          prInfo,
+          dependencyResults,
+          memoryStore,
+          config.__outputHistory
+        );
         let result;
         try {
           switch (operation) {
@@ -7656,7 +7735,7 @@ var init_memory_check_provider = __esm({
       /**
        * Build template context for Liquid and JS evaluation
        */
-      buildTemplateContext(prInfo, dependencyResults, memoryStore) {
+      buildTemplateContext(prInfo, dependencyResults, memoryStore, outputHistory) {
         const context2 = {};
         context2.pr = {
           number: prInfo.number,
@@ -7675,14 +7754,21 @@ var init_memory_check_provider = __esm({
             changes: f.changes
           }))
         };
+        const outputs = {};
+        const history = {};
         if (dependencyResults) {
-          const outputs = {};
           for (const [checkName, result] of dependencyResults.entries()) {
             const summary = result;
             outputs[checkName] = summary.output !== void 0 ? summary.output : summary;
           }
-          context2.outputs = outputs;
         }
+        if (outputHistory) {
+          for (const [checkName, historyArray] of outputHistory) {
+            history[checkName] = historyArray;
+          }
+        }
+        outputs.history = history;
+        context2.outputs = outputs;
         if (memoryStore) {
           context2.memory = {
             get: (key, ns) => memoryStore.get(key, ns),
@@ -10677,6 +10763,8 @@ var init_check_execution_engine = __esm({
       webhookContext;
       routingSandbox;
       executionStats = /* @__PURE__ */ new Map();
+      // Track history of all outputs for each check (useful for loops and goto)
+      outputHistory = /* @__PURE__ */ new Map();
       // Event override to simulate alternate event (used during routing goto)
       routingEventOverride;
       // Cached GitHub context for context elevation when running in Actions
@@ -10696,6 +10784,18 @@ var init_check_execution_engine = __esm({
         this.mockOctokit = this.createMockOctokit();
         this.reviewer = new PRReviewer(this.mockOctokit);
       }
+      /**
+       * Enrich event context with authenticated octokit instance
+       * @param eventContext - The event context to enrich
+       * @returns Enriched event context with octokit if available
+       */
+      enrichEventContext(eventContext) {
+        const baseContext = eventContext || {};
+        if (this.actionContext?.octokit) {
+          return { ...baseContext, octokit: this.actionContext.octokit };
+        }
+        return baseContext;
+      }
       /**
        * Lazily create a secure sandbox for routing JS (goto_js, run_js)
        */
@@ -10895,10 +10995,6 @@ ${expr}
           const providerType = targetCfg.type || "ai";
           const prov = this.providerRegistry.getProviderOrThrow(providerType);
           this.setProviderWebhookContext(prov);
-          const enrichedEventContext = {
-            ...prInfo.eventContext,
-            ...this.actionContext?.octokit ? { octokit: this.actionContext.octokit } : {}
-          };
           const provCfg = {
             type: providerType,
             prompt: targetCfg.prompt,
@@ -10907,11 +11003,13 @@ ${expr}
             schema: targetCfg.schema,
             group: targetCfg.group,
             checkName: target,
-            eventContext: enrichedEventContext,
+            eventContext: this.enrichEventContext(prInfo.eventContext),
             transform: targetCfg.transform,
             transform_js: targetCfg.transform_js,
             env: targetCfg.env,
             forEach: targetCfg.forEach,
+            // Pass output history for loop/goto scenarios
+            __outputHistory: this.outputHistory,
             // Include provider-specific keys (e.g., op/values for github)
             ...targetCfg,
             ai: {
@@ -10979,6 +11077,10 @@ ${expr}
             timestamp: Date.now()
           }));
           const enriched = { ...r, issues: enrichedIssues };
+          const enrichedWithOutput = enriched;
+          if (enrichedWithOutput.output !== void 0) {
+            this.trackOutputHistory(target, enrichedWithOutput.output);
+          }
           resultsMap?.set(target, enriched);
           if (debug) log2(`\u{1F527} Debug: inline executed '${target}', issues: ${enrichedIssues.length}`);
           return enriched;
@@ -11548,8 +11650,7 @@ ${expr}
             const providerConfig = {
               type: checks[0],
               prompt: "all",
-              eventContext: prInfo.eventContext,
-              // Pass event context for templates
+              eventContext: this.enrichEventContext(prInfo.eventContext),
               ai: timeout ? { timeout } : void 0
             };
             const result = await provider.execute(prInfo, providerConfig);
@@ -11583,8 +11684,7 @@ ${expr}
             type: "ai",
             prompt: focus2,
             focus: focus2,
-            eventContext: prInfo.eventContext,
-            // Pass event context for templates
+            eventContext: this.enrichEventContext(prInfo.eventContext),
             ai: timeout ? { timeout } : void 0,
             // Inherit global AI provider and model settings if config is available
             ai_provider: config?.ai_provider,
@@ -11739,8 +11839,7 @@ ${expr}
           focus: checkConfig.focus || this.mapCheckNameToFocus(checkName),
           schema: checkConfig.schema,
           group: checkConfig.group,
-          eventContext: prInfo.eventContext,
-          // Pass event context for templates
+          eventContext: this.enrichEventContext(prInfo.eventContext),
           ai: {
             timeout: timeout || 6e5,
             debug,
@@ -11750,6 +11849,8 @@ ${expr}
           ai_model: checkConfig.ai_model || config.ai_model,
           // Pass claude_code config if present
           claude_code: checkConfig.claude_code,
+          // Pass output history for loop/goto scenarios
+          __outputHistory: this.outputHistory,
           // Pass any provider-specific config
           ...checkConfig
         };
@@ -11786,10 +11887,14 @@ ${expr}
           }
         }
         const content = await this.renderCheckContent(checkName, result, checkConfig, prInfo);
+        let group = checkConfig.group || "default";
+        if (config?.output?.pr_comment?.group_by === "check" && !checkConfig.group) {
+          group = checkName;
+        }
         return {
           checkName,
           content,
-          group: checkConfig.group || "default",
+          group,
           output: result.output,
           debug: result.debug,
           issues: result.issues
@@ -11928,16 +12033,19 @@ ${expr}
               }
             ];
           }
+          let group = checkConfig.group || "default";
+          if (config?.output?.pr_comment?.group_by === "check" && !checkConfig.group) {
+            group = checkName;
+          }
           const checkResult = {
             checkName,
             content,
-            group: checkConfig.group || "default",
+            group,
             output: checkSummary.output,
             debug: reviewSummary.debug,
             issues: issuesForCheck
             // Include structured issues + rendering error if any
           };
-          const group = checkResult.group;
           if (!groupedResults[group]) {
             groupedResults[group] = [];
           }
@@ -12344,8 +12452,7 @@ ${expr}
                 group: checkConfig.group,
                 checkName,
                 // Add checkName for sessionID
-                eventContext: prInfo.eventContext,
-                // Pass event context for templates
+                eventContext: this.enrichEventContext(prInfo.eventContext),
                 transform: checkConfig.transform,
                 transform_js: checkConfig.transform_js,
                 // Important: pass through provider-level timeout from check config
@@ -12532,7 +12639,7 @@ ${expr}
                         schema: childCfg.schema,
                         group: childCfg.group,
                         checkName: childName,
-                        eventContext: prInfo.eventContext,
+                        eventContext: this.enrichEventContext(prInfo.eventContext),
                         transform: childCfg.transform,
                         transform_js: childCfg.transform_js,
                         env: childCfg.env,
@@ -12839,6 +12946,10 @@ ${expr}
                       itemResult.issues || [],
                       itemResult.output
                     );
+                    const itemOutput = itemResult.output;
+                    if (itemOutput !== void 0) {
+                      this.trackOutputHistory(checkName, itemOutput);
+                    }
                     const descendantSet = (() => {
                       const visited = /* @__PURE__ */ new Set();
                       const stack = [checkName];
@@ -12926,7 +13037,7 @@ ${expr}
                           schema: nodeCfg.schema,
                           group: nodeCfg.group,
                           checkName: node,
-                          eventContext: prInfo.eventContext,
+                          eventContext: this.enrichEventContext(prInfo.eventContext),
                           transform: nodeCfg.transform,
                           transform_js: nodeCfg.transform_js,
                           env: nodeCfg.env,
@@ -13469,6 +13580,10 @@ ${error.stack || ""}` : String(error);
                 ]);
               } catch {
               }
+              const reviewResultWithOutput = reviewResult;
+              if (reviewResultWithOutput.output !== void 0) {
+                this.trackOutputHistory(checkName, reviewResultWithOutput.output);
+              }
               results.set(checkName, reviewResult);
             } else {
               const errorSummary = {
@@ -13622,8 +13737,7 @@ ${error.stack || ""}` : String(error);
               focus: checkConfig.focus || this.mapCheckNameToFocus(checkName),
               schema: checkConfig.schema,
               group: checkConfig.group,
-              eventContext: prInfo.eventContext,
-              // Pass event context for templates
+              eventContext: this.enrichEventContext(prInfo.eventContext),
               ai: {
                 timeout: timeout || 6e5,
                 debug,
@@ -13699,8 +13813,7 @@ ${error.stack || ""}` : String(error);
           focus: checkConfig.focus || this.mapCheckNameToFocus(checkName),
           schema: checkConfig.schema,
           group: checkConfig.group,
-          eventContext: prInfo.eventContext,
-          // Pass event context for templates
+          eventContext: this.enrichEventContext(prInfo.eventContext),
           ai: {
             timeout: timeout || 6e5,
             ...checkConfig.ai || {}
@@ -14714,6 +14827,16 @@ ${result.value.result.debug.rawResponse}`;
           stats.outputsProduced = (stats.outputsProduced || 0) + 1;
         }
       }
+      /**
+       * Track output in history for loop/goto scenarios
+       */
+      trackOutputHistory(checkName, output) {
+        if (output === void 0) return;
+        if (!this.outputHistory.has(checkName)) {
+          this.outputHistory.set(checkName, []);
+        }
+        this.outputHistory.get(checkName).push(output);
+      }
       /**
        * Record that a check was skipped
        */
@@ -16817,8 +16940,10 @@ var ConfigManager = class {
   }
   /**
    * Validate configuration against schema
+   * @param config The config to validate
+   * @param strict If true, treat warnings as errors (default: false)
    */
-  validateConfig(config) {
+  validateConfig(config, strict = false) {
     const errors = [];
     const warnings = [];
     this.validateWithAjvSchema(config, errors, warnings);
@@ -16926,10 +17051,13 @@ var ConfigManager = class {
     if (config.tag_filter) {
       this.validateTagFilter(config.tag_filter, errors);
     }
+    if (strict && warnings.length > 0) {
+      errors.push(...warnings);
+    }
     if (errors.length > 0) {
       throw new Error(errors[0].message);
     }
-    if (warnings.length > 0) {
+    if (!strict && warnings.length > 0) {
       for (const w of warnings) {
         logger.warn(`\u26A0\uFE0F  Config warning [${w.field}]: ${w.message}`);
       }
@@ -17385,9 +17513,25 @@ var __ajvValidate = null;
 var __ajvErrors = null;
 
 // src/sdk.ts
-async function loadConfig(configPath) {
+async function loadConfig(configOrPath, options) {
   const cm = new ConfigManager();
-  if (configPath) return cm.loadConfig(configPath);
+  if (typeof configOrPath === "object" && configOrPath !== null) {
+    cm.validateConfig(configOrPath, options?.strict ?? false);
+    const defaultConfig = {
+      version: "1.0",
+      checks: {},
+      max_parallelism: 3,
+      fail_fast: false
+    };
+    return {
+      ...defaultConfig,
+      ...configOrPath,
+      checks: configOrPath.checks || {}
+    };
+  }
+  if (typeof configOrPath === "string") {
+    return cm.loadConfig(configOrPath);
+  }
   return cm.findAndLoadConfig();
 }
 function resolveChecks(checkIds, config) {
@@ -17413,7 +17557,15 @@ function resolveChecks(checkIds, config) {
 }
 async function runChecks(opts = {}) {
   const cm = new ConfigManager();
-  const config = opts.config ? opts.config : opts.configPath ? await cm.loadConfig(opts.configPath) : await cm.findAndLoadConfig();
+  let config;
+  if (opts.config) {
+    cm.validateConfig(opts.config, opts.strictValidation ?? false);
+    config = opts.config;
+  } else if (opts.configPath) {
+    config = await cm.loadConfig(opts.configPath);
+  } else {
+    config = await cm.findAndLoadConfig();
+  }
   const checks = opts.checks && opts.checks.length > 0 ? resolveChecks(opts.checks, config) : Object.keys(config.checks || {});
   const engine = new CheckExecutionEngine(opts.cwd);
   const result = await engine.executeChecks({