@probelabs/visor 0.1.86 → 0.1.88

package/dist/sdk/sdk.d.mts

@@ -59,6 +59,8 @@ interface ReviewIssue {
 interface ReviewSummary {
     issues?: ReviewIssue[];
     debug?: AIDebugInfo;
+    /** Session ID created for this check (for cleanup tracking) */
+    sessionId?: string;
 }
 
 /**
@@ -262,6 +264,8 @@ interface CheckConfig {
     if?: string;
     /** Check name to reuse AI session from, or true to use first dependency (only works with depends_on) */
     reuse_ai_session?: string | boolean;
+    /** How to reuse AI session: 'clone' (default, copy history) or 'append' (share history) */
+    session_mode?: 'clone' | 'append';
     /** Simple fail condition - fails check if expression evaluates to true */
     fail_if?: string;
     /** Check-specific failure conditions - optional (deprecated, use fail_if) */

package/dist/sdk/sdk.d.ts

@@ -59,6 +59,8 @@ interface ReviewIssue {
 interface ReviewSummary {
     issues?: ReviewIssue[];
     debug?: AIDebugInfo;
+    /** Session ID created for this check (for cleanup tracking) */
+    sessionId?: string;
 }
 
 /**
@@ -262,6 +264,8 @@ interface CheckConfig {
     if?: string;
     /** Check name to reuse AI session from, or true to use first dependency (only works with depends_on) */
     reuse_ai_session?: string | boolean;
+    /** How to reuse AI session: 'clone' (default, copy history) or 'append' (share history) */
+    session_mode?: 'clone' | 'append';
     /** Simple fail condition - fails check if expression evaluates to true */
     fail_if?: string;
     /** Check-specific failure conditions - optional (deprecated, use fail_if) */

package/dist/sdk/sdk.js

@@ -400,6 +400,47 @@ var init_session_registry = __esm({
       hasSession(sessionId) {
         return this.sessions.has(sessionId);
       }
+      /**
+       * Clone a session with a new session ID
+       * Creates a new ProbeAgent with a copy of the conversation history
+       */
+      async cloneSession(sourceSessionId, newSessionId) {
+        const sourceAgent = this.sessions.get(sourceSessionId);
+        if (!sourceAgent) {
+          console.error(`\u26A0\uFE0F  Cannot clone session: ${sourceSessionId} not found`);
+          return void 0;
+        }
+        try {
+          const sourceHistory = sourceAgent.conversationHistory || [];
+          const sourceOptions = sourceAgent.options || {};
+          const { ProbeAgent: ProbeAgentClass } = await import("@probelabs/probe");
+          const clonedAgent = new ProbeAgentClass({
+            ...sourceOptions,
+            sessionId: newSessionId
+          });
+          if (sourceHistory.length > 0) {
+            try {
+              const deepClonedHistory = JSON.parse(JSON.stringify(sourceHistory));
+              clonedAgent.conversationHistory = deepClonedHistory;
+              console.error(
+                `\u{1F4CB} Cloned session ${sourceSessionId} \u2192 ${newSessionId} (${sourceHistory.length} messages, deep copy)`
+              );
+            } catch (cloneError) {
+              console.error(
+                `\u26A0\uFE0F  Warning: Deep clone failed for session ${sourceSessionId}, using shallow copy: ${cloneError}`
+              );
+              clonedAgent.conversationHistory = [...sourceHistory];
+            }
+          } else {
+            console.error(`\u{1F4CB} Cloned session ${sourceSessionId} \u2192 ${newSessionId} (no history)`);
+          }
+          this.registerSession(newSessionId, clonedAgent);
+          return clonedAgent;
+        } catch (error) {
+          console.error(`\u26A0\uFE0F  Failed to clone session ${sourceSessionId}: ${error}`);
+          return void 0;
+        }
+      }
       /**
        * Register process exit handlers to cleanup sessions on exit
        */
@@ -671,8 +712,9 @@ var init_ai_review_service = __esm({
       }
       /**
        * Execute AI review using session reuse - reuses an existing ProbeAgent session
+       * @param sessionMode - 'clone' (default) clones history, 'append' shares history
        */
-      async executeReviewWithSessionReuse(prInfo, customPrompt, parentSessionId, schema, checkName) {
+      async executeReviewWithSessionReuse(prInfo, customPrompt, parentSessionId, schema, checkName, sessionMode = "clone") {
         const startTime = Date.now();
         const timestamp = (/* @__PURE__ */ new Date()).toISOString();
         const existingAgent = this.sessionRegistry.getSession(parentSessionId);
@@ -682,7 +724,24 @@ var init_ai_review_service = __esm({
           );
         }
         const prompt = await this.buildCustomPrompt(prInfo, customPrompt, schema);
-        log(`\u{1F504} Reusing AI session ${parentSessionId} for review...`);
+        let agentToUse;
+        let currentSessionId;
+        if (sessionMode === "clone") {
+          currentSessionId = `${parentSessionId}-clone-${Date.now()}`;
+          log(`\u{1F4CB} Cloning AI session ${parentSessionId} \u2192 ${currentSessionId}...`);
+          const clonedAgent = await this.sessionRegistry.cloneSession(
+            parentSessionId,
+            currentSessionId
+          );
+          if (!clonedAgent) {
+            throw new Error(`Failed to clone session ${parentSessionId}. Falling back to append mode.`);
+          }
+          agentToUse = clonedAgent;
+        } else {
+          log(`\u{1F504} Appending to AI session ${parentSessionId} (shared history)...`);
+          agentToUse = existingAgent;
+          currentSessionId = parentSessionId;
+        }
         log(`\u{1F527} Debug: Raw schema parameter: ${JSON.stringify(schema)} (type: ${typeof schema})`);
         log(`Schema type: ${schema || "none (no schema)"}`);
         let debugInfo;
@@ -706,7 +765,7 @@ var init_ai_review_service = __esm({
         }
         try {
           const { response, effectiveSchema } = await this.callProbeAgentWithExistingSession(
-            existingAgent,
+            agentToUse,
             prompt,
             schema,
             debugInfo,
@@ -722,6 +781,9 @@ var init_ai_review_service = __esm({
           if (debugInfo) {
             result.debug = debugInfo;
           }
+          if (sessionMode === "clone" && currentSessionId !== parentSessionId) {
+            result.sessionId = currentSessionId;
+          }
           return result;
         } catch (error) {
           if (debugInfo) {
@@ -810,7 +872,8 @@ ${prContext}
     <rule>For INCREMENTAL analysis, ONLY review changes in commit_diff section</rule>
     <rule>For FULL analysis, review all changes in full_diff section</rule>
     <rule>Reference specific XML elements like files_summary, metadata when providing context</rule>
-    <rule>SEVERITY ASSIGNMENT: All severity levels (critical, error, warning, info) should be based on the NEW code being introduced, not on what it fixes. When code INTRODUCES new problems (bugs, vulnerabilities, performance issues, breaking changes), assign appropriate severity (critical/error/warning). When code FIXES or IMPROVES existing issues, use lower severity (info/warning) to acknowledge the improvement. This applies to all issue types: security, performance, style, logic, documentation. The schema provides detailed severity level definitions.</rule>
+    <rule>STRICT OUTPUT POLICY: Report only actual problems, risks, or deficiencies. Do not write praise, congratulations, or celebratory text. Do not create issues that merely restate improvements or say "no action needed".</rule>
+    <rule>SEVERITY ASSIGNMENT: Assign severity ONLY to problems introduced or left unresolved by this change (critical/error/warning/info as appropriate). Do NOT create issue entries solely to acknowledge improvements; if no problems exist, return zero issues.</rule>
   </rules>
 </review_request>`;
         }
@@ -2713,9 +2776,10 @@ var init_ai_check_provider = __esm({
           }
           let result;
           if (sessionInfo?.reuseSession && sessionInfo.parentSessionId) {
+            const sessionMode = config.session_mode || "clone";
             if (aiConfig.debug) {
               console.error(
-                `\u{1F504} Debug: Using session reuse with parent session: ${sessionInfo.parentSessionId}`
+                `\u{1F504} Debug: Using session reuse with parent session: ${sessionInfo.parentSessionId} (mode: ${sessionMode})`
               );
             }
             result = await service.executeReviewWithSessionReuse(
@@ -2723,7 +2787,8 @@ var init_ai_check_provider = __esm({
               processedPrompt,
               sessionInfo.parentSessionId,
               schema,
-              config.checkName
+              config.checkName,
+              sessionMode
             );
           } else {
             if (aiConfig.debug) {
@@ -5460,26 +5525,36 @@ var init_failure_condition_evaluator = __esm({
           // eslint-disable-line @typescript-eslint/no-unused-vars
           ...otherFields
         } = reviewSummaryWithOutput;
+        const aggregatedOutput = {
+          issues: (issues || []).map((issue) => ({
+            file: issue.file,
+            line: issue.line,
+            endLine: issue.endLine,
+            ruleId: issue.ruleId,
+            message: issue.message,
+            severity: issue.severity,
+            category: issue.category,
+            group: issue.group,
+            schema: issue.schema,
+            suggestion: issue.suggestion,
+            replacement: issue.replacement
+          })),
+          // Include additional schema-specific data from reviewSummary
+          ...otherFields
+        };
+        if (Array.isArray(extractedOutput)) {
+          aggregatedOutput.items = extractedOutput;
+          const anyError = extractedOutput.find(
+            (it) => it && typeof it === "object" && it.error
+          );
+          if (anyError && anyError.error !== void 0) {
+            aggregatedOutput.error = anyError.error;
+          }
+        } else if (extractedOutput && typeof extractedOutput === "object") {
+          Object.assign(aggregatedOutput, extractedOutput);
+        }
         const context = {
-          output: {
-            issues: (issues || []).map((issue) => ({
-              file: issue.file,
-              line: issue.line,
-              endLine: issue.endLine,
-              ruleId: issue.ruleId,
-              message: issue.message,
-              severity: issue.severity,
-              category: issue.category,
-              group: issue.group,
-              schema: issue.schema,
-              suggestion: issue.suggestion,
-              replacement: issue.replacement
-            })),
-            // Include additional schema-specific data from reviewSummary
-            ...otherFields,
-            // Spread the extracted output directly (avoid output.output nesting)
-            ...extractedOutput && typeof extractedOutput === "object" ? extractedOutput : {}
-          },
+          output: aggregatedOutput,
           outputs: (() => {
             if (!previousOutputs) return {};
             const outputs = {};
@@ -5645,9 +5720,11 @@ var init_github_check_service = __esm({
             reviewIssues,
             executionError
           );
-          let filteredIssues = reviewIssues;
+          let filteredIssues = reviewIssues.filter(
+            (issue) => !(issue.file === "system" && issue.line === 0)
+          );
           if (filesChangedInCommit && filesChangedInCommit.length > 0) {
-            filteredIssues = reviewIssues.filter(
+            filteredIssues = filteredIssues.filter(
               (issue) => filesChangedInCommit.some((changedFile) => issue.file === changedFile)
             );
           }
@@ -7387,10 +7464,19 @@ ${expr}
                   const id = issue.ruleId || "";
                   return id.endsWith("/__skipped");
                 });
-                const hasFatalFailure = (depRes.issues || []).some((issue) => {
+                let hasFatalFailure = (depRes.issues || []).some((issue) => {
                   const id = issue.ruleId || "";
-                  return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error") || id.endsWith("/forEach/iteration_error") || id === "forEach/undefined_output" || id.endsWith("/forEach/undefined_output") || id.endsWith("_fail_if") || id.endsWith("/global_fail_if");
+                  return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/timeout" || id.endsWith("/command/timeout") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error") || id.endsWith("/forEach/iteration_error") || id === "forEach/undefined_output" || id.endsWith("/forEach/undefined_output") || id.endsWith("_fail_if") || id.endsWith("/global_fail_if");
                 });
+                if (!hasFatalFailure && config && (config.fail_if || config.checks[depId]?.fail_if)) {
+                  const failIfResults = await this.evaluateFailureConditions(depId, depRes, config);
+                  hasFatalFailure = failIfResults.some((r) => r.failed);
+                }
+                if (debug) {
+                  log2(
+                    `\u{1F527} Debug: gating check '${checkName}' against dep '${depId}': wasSkipped=${wasSkipped} hasFatalFailure=${hasFatalFailure}`
+                  );
+                }
                 if (wasSkipped || hasFatalFailure) failedDeps.push(depId);
               }
               if (failedDeps.length > 0) {
@@ -7622,6 +7708,24 @@ ${expr}
                     issues: allIssues,
                     ...finalOutput !== void 0 ? { output: finalOutput } : {}
                   };
+                  if (config && (config.fail_if || checkConfig.fail_if)) {
+                    const failureResults = await this.evaluateFailureConditions(
+                      checkName,
+                      finalResult,
+                      config
+                    );
+                    if (failureResults.length > 0) {
+                      const failureIssues = failureResults.filter((f) => f.failed).map((f) => ({
+                        file: "system",
+                        line: 0,
+                        ruleId: f.conditionName,
+                        message: f.message || `Failure condition met: ${f.expression}`,
+                        severity: f.severity || "error",
+                        category: "logic"
+                      }));
+                      finalResult.issues = [...finalResult.issues || [], ...failureIssues];
+                    }
+                  }
                   if (allOutputs.length > 0) {
                     finalResult.isForEach = true;
                     finalResult.forEachItems = allOutputs;
@@ -7668,9 +7772,27 @@ ${expr}
                   debug,
                   results
                 );
+                if (config && (config.fail_if || checkConfig.fail_if)) {
+                  const failureResults = await this.evaluateFailureConditions(
+                    checkName,
+                    finalResult,
+                    config
+                  );
+                  if (failureResults.length > 0) {
+                    const failureIssues = failureResults.filter((f) => f.failed).map((f) => ({
+                      file: "system",
+                      line: 0,
+                      ruleId: f.conditionName,
+                      message: f.message || `Failure condition met: ${f.expression}`,
+                      severity: f.severity || "error",
+                      category: "logic"
+                    }));
+                    finalResult.issues = [...finalResult.issues || [], ...failureIssues];
+                  }
+                }
                 const hadFatalError = (finalResult.issues || []).some((issue) => {
                   const id = issue.ruleId || "";
-                  return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error") || id === "forEach/undefined_output" || id.endsWith("/forEach/undefined_output");
+                  return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/timeout" || id.endsWith("/command/timeout") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error") || id === "forEach/undefined_output" || id.endsWith("/forEach/undefined_output");
                 });
                 this.recordIterationComplete(
                   checkName,
@@ -7693,6 +7815,12 @@ ${expr}
                     `\u{1F527} Debug: Completed check: ${checkName}, issues found: ${(finalResult.issues || []).length}`
                   );
                 }
+                if (finalResult.sessionId) {
+                  sessionIds.set(checkName, finalResult.sessionId);
+                  if (debug) {
+                    log2(`\u{1F527} Debug: Tracked cloned session for cleanup: ${finalResult.sessionId}`);
+                  }
+                }
               }
               const enrichedIssues = (finalResult.issues || []).map((issue) => ({
                 ...issue,
@@ -9530,6 +9658,11 @@ var init_config_schema = __esm({
               type: ["string", "boolean"],
               description: "Check name to reuse AI session from, or true to use first dependency (only works with depends_on)"
             },
+            session_mode: {
+              type: "string",
+              enum: ["clone", "append"],
+              description: "How to reuse AI session: 'clone' (default, copy history) or 'append' (share history)"
+            },
             fail_if: {
               type: "string",
               description: "Simple fail condition - fails check if expression evaluates to true"
@@ -11073,6 +11206,22 @@ var ConfigManager = class {
         }
       }
     }
+    if (checkConfig.session_mode !== void 0) {
+      if (checkConfig.session_mode !== "clone" && checkConfig.session_mode !== "append") {
+        errors.push({
+          field: `checks.${checkName}.session_mode`,
+          message: `Invalid session_mode value for "${checkName}": must be 'clone' or 'append'`,
+          value: checkConfig.session_mode
+        });
+      }
+      if (!checkConfig.reuse_ai_session) {
+        errors.push({
+          field: `checks.${checkName}.session_mode`,
+          message: `Check "${checkName}" has session_mode but no reuse_ai_session. session_mode requires reuse_ai_session to be set.`,
+          value: checkConfig.session_mode
+        });
+      }
+    }
     if (checkConfig.tags !== void 0) {
       if (!Array.isArray(checkConfig.tags)) {
         errors.push({