@probelabs/visor 0.1.86 → 0.1.87

package/dist/sdk/sdk.js

@@ -810,7 +810,8 @@ ${prContext}
     <rule>For INCREMENTAL analysis, ONLY review changes in commit_diff section</rule>
     <rule>For FULL analysis, review all changes in full_diff section</rule>
     <rule>Reference specific XML elements like files_summary, metadata when providing context</rule>
-    <rule>SEVERITY ASSIGNMENT: All severity levels (critical, error, warning, info) should be based on the NEW code being introduced, not on what it fixes. When code INTRODUCES new problems (bugs, vulnerabilities, performance issues, breaking changes), assign appropriate severity (critical/error/warning). When code FIXES or IMPROVES existing issues, use lower severity (info/warning) to acknowledge the improvement. This applies to all issue types: security, performance, style, logic, documentation. The schema provides detailed severity level definitions.</rule>
+    <rule>STRICT OUTPUT POLICY: Report only actual problems, risks, or deficiencies. Do not write praise, congratulations, or celebratory text. Do not create issues that merely restate improvements or say "no action needed".</rule>
+    <rule>SEVERITY ASSIGNMENT: Assign severity ONLY to problems introduced or left unresolved by this change (critical/error/warning/info as appropriate). Do NOT create issue entries solely to acknowledge improvements; if no problems exist, return zero issues.</rule>
   </rules>
 </review_request>`;
         }
@@ -5460,26 +5461,36 @@ var init_failure_condition_evaluator = __esm({
           // eslint-disable-line @typescript-eslint/no-unused-vars
           ...otherFields
         } = reviewSummaryWithOutput;
+        const aggregatedOutput = {
+          issues: (issues || []).map((issue) => ({
+            file: issue.file,
+            line: issue.line,
+            endLine: issue.endLine,
+            ruleId: issue.ruleId,
+            message: issue.message,
+            severity: issue.severity,
+            category: issue.category,
+            group: issue.group,
+            schema: issue.schema,
+            suggestion: issue.suggestion,
+            replacement: issue.replacement
+          })),
+          // Include additional schema-specific data from reviewSummary
+          ...otherFields
+        };
+        if (Array.isArray(extractedOutput)) {
+          aggregatedOutput.items = extractedOutput;
+          const anyError = extractedOutput.find(
+            (it) => it && typeof it === "object" && it.error
+          );
+          if (anyError && anyError.error !== void 0) {
+            aggregatedOutput.error = anyError.error;
+          }
+        } else if (extractedOutput && typeof extractedOutput === "object") {
+          Object.assign(aggregatedOutput, extractedOutput);
+        }
         const context = {
-          output: {
-            issues: (issues || []).map((issue) => ({
-              file: issue.file,
-              line: issue.line,
-              endLine: issue.endLine,
-              ruleId: issue.ruleId,
-              message: issue.message,
-              severity: issue.severity,
-              category: issue.category,
-              group: issue.group,
-              schema: issue.schema,
-              suggestion: issue.suggestion,
-              replacement: issue.replacement
-            })),
-            // Include additional schema-specific data from reviewSummary
-            ...otherFields,
-            // Spread the extracted output directly (avoid output.output nesting)
-            ...extractedOutput && typeof extractedOutput === "object" ? extractedOutput : {}
-          },
+          output: aggregatedOutput,
           outputs: (() => {
             if (!previousOutputs) return {};
             const outputs = {};
@@ -7387,10 +7398,19 @@ ${expr}
                   const id = issue.ruleId || "";
                   return id.endsWith("/__skipped");
                 });
-                const hasFatalFailure = (depRes.issues || []).some((issue) => {
+                let hasFatalFailure = (depRes.issues || []).some((issue) => {
                   const id = issue.ruleId || "";
-                  return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error") || id.endsWith("/forEach/iteration_error") || id === "forEach/undefined_output" || id.endsWith("/forEach/undefined_output") || id.endsWith("_fail_if") || id.endsWith("/global_fail_if");
+                  return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/timeout" || id.endsWith("/command/timeout") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error") || id.endsWith("/forEach/iteration_error") || id === "forEach/undefined_output" || id.endsWith("/forEach/undefined_output") || id.endsWith("_fail_if") || id.endsWith("/global_fail_if");
                 });
+                if (!hasFatalFailure && config && (config.fail_if || config.checks[depId]?.fail_if)) {
+                  const failIfResults = await this.evaluateFailureConditions(depId, depRes, config);
+                  hasFatalFailure = failIfResults.some((r) => r.failed);
+                }
+                if (debug) {
+                  log2(
+                    `\u{1F527} Debug: gating check '${checkName}' against dep '${depId}': wasSkipped=${wasSkipped} hasFatalFailure=${hasFatalFailure}`
+                  );
+                }
                 if (wasSkipped || hasFatalFailure) failedDeps.push(depId);
               }
               if (failedDeps.length > 0) {
@@ -7622,6 +7642,24 @@ ${expr}
                     issues: allIssues,
                     ...finalOutput !== void 0 ? { output: finalOutput } : {}
                   };
+                  if (config && (config.fail_if || checkConfig.fail_if)) {
+                    const failureResults = await this.evaluateFailureConditions(
+                      checkName,
+                      finalResult,
+                      config
+                    );
+                    if (failureResults.length > 0) {
+                      const failureIssues = failureResults.filter((f) => f.failed).map((f) => ({
+                        file: "system",
+                        line: 0,
+                        ruleId: f.conditionName,
+                        message: f.message || `Failure condition met: ${f.expression}`,
+                        severity: f.severity || "error",
+                        category: "logic"
+                      }));
+                      finalResult.issues = [...finalResult.issues || [], ...failureIssues];
+                    }
+                  }
                   if (allOutputs.length > 0) {
                     finalResult.isForEach = true;
                     finalResult.forEachItems = allOutputs;
@@ -7668,9 +7706,27 @@ ${expr}
                   debug,
                   results
                 );
+                if (config && (config.fail_if || checkConfig.fail_if)) {
+                  const failureResults = await this.evaluateFailureConditions(
+                    checkName,
+                    finalResult,
+                    config
+                  );
+                  if (failureResults.length > 0) {
+                    const failureIssues = failureResults.filter((f) => f.failed).map((f) => ({
+                      file: "system",
+                      line: 0,
+                      ruleId: f.conditionName,
+                      message: f.message || `Failure condition met: ${f.expression}`,
+                      severity: f.severity || "error",
+                      category: "logic"
+                    }));
+                    finalResult.issues = [...finalResult.issues || [], ...failureIssues];
+                  }
+                }
                 const hadFatalError = (finalResult.issues || []).some((issue) => {
                   const id = issue.ruleId || "";
-                  return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error") || id === "forEach/undefined_output" || id.endsWith("/forEach/undefined_output");
+                  return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/timeout" || id.endsWith("/command/timeout") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error") || id === "forEach/undefined_output" || id.endsWith("/forEach/undefined_output");
                 });
                 this.recordIterationComplete(
                   checkName,