@probelabs/visor 0.1.82 → 0.1.84

package/dist/output/code-review/schema.json

@@ -38,8 +38,8 @@
           },
           "severity": {
             "type": "string",
-            "enum": ["info", "warning", "error", "critical"],
-            "description": "Issue severity level based on the NEW CODE being introduced: info (suggestions/improvements), warning (should fix), error (must fix), critical (NEW security vulnerabilities, data loss risks, or breaking changes that block deployment). IMPORTANT: Use 'critical' ONLY when NEW problematic code is INTRODUCED, NOT when existing issues are being FIXED. Fixes and improvements should use 'info' or 'warning' severity."
+            "enum": ["warning", "error", "critical"],
+            "description": "Issue severity level based on the NEW CODE being introduced: info (suggestions/improvements), warning (should fix), error (must fix), critical (NEW security vulnerabilities, data loss risks, or breaking changes that block deployment). IMPORTANT: Use 'critical' ONLY when NEW problematic code is INTRODUCED, NOT when existing issues are being FIXED. "
           },
           "category": {
             "type": "string",

package/dist/providers/command-check-provider.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"command-check-provider.d.ts","sourceRoot":"","sources":["file:///home/runner/work/visor/visor/src/providers/command-check-provider.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,aAAa,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AAChF,OAAO,EAAE,MAAM,EAAE,MAAM,gBAAgB,CAAC;AACxC,OAAO,EAAE,aAAa,EAAe,MAAM,aAAa,CAAC;AAMzD;;;GAGG;AACH,qBAAa,oBAAqB,SAAQ,aAAa;IACrD,OAAO,CAAC,MAAM,CAAS;IACvB,OAAO,CAAC,OAAO,CAAC,CAAU;;IAY1B,OAAO,CAAC,mBAAmB;IAW3B,OAAO,IAAI,MAAM;IAIjB,cAAc,IAAI,MAAM;IAIlB,cAAc,CAAC,MAAM,EAAE,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC;IAejD,OAAO,CACX,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,mBAAmB,EAC3B,iBAAiB,CAAC,EAAE,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,GAC7C,OAAO,CAAC,aAAa,CAAC;IAyUzB,OAAO,CAAC,kBAAkB;IAkB1B;;;;;;OAMG;IACH,OAAO,CAAC,aAAa;IAgFrB;;;OAGG;IACH,OAAO,CAAC,kBAAkB;IAyB1B;;OAEG;IACH,OAAO,CAAC,oBAAoB;IAQ5B,OAAO,CAAC,2BAA2B;IAgBnC,sBAAsB,IAAI,MAAM,EAAE;IAgB5B,WAAW,IAAI,OAAO,CAAC,OAAO,CAAC;IAKrC,eAAe,IAAI,MAAM,EAAE;IAQ3B,OAAO,CAAC,uBAAuB;IAkD/B,OAAO,CAAC,uBAAuB;IAkB/B,OAAO,CAAC,mBAAmB;IAc3B,OAAO,CAAC,cAAc;IAmEtB,OAAO,CAAC,eAAe;IAYvB,OAAO,CAAC,QAAQ;YAWF,qBAAqB;IAiBnC,OAAO,CAAC,uBAAuB;CA6ChC"}
+{"version":3,"file":"command-check-provider.d.ts","sourceRoot":"","sources":["file:///home/runner/work/visor/visor/src/providers/command-check-provider.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,aAAa,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AAChF,OAAO,EAAE,MAAM,EAAE,MAAM,gBAAgB,CAAC;AACxC,OAAO,EAAE,aAAa,EAAe,MAAM,aAAa,CAAC;AAMzD;;;GAGG;AACH,qBAAa,oBAAqB,SAAQ,aAAa;IACrD,OAAO,CAAC,MAAM,CAAS;IACvB,OAAO,CAAC,OAAO,CAAC,CAAU;;IAY1B,OAAO,CAAC,mBAAmB;IAW3B,OAAO,IAAI,MAAM;IAIjB,cAAc,IAAI,MAAM;IAIlB,cAAc,CAAC,MAAM,EAAE,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC;IAejD,OAAO,CACX,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,mBAAmB,EAC3B,iBAAiB,CAAC,EAAE,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,GAC7C,OAAO,CAAC,aAAa,CAAC;IAuXzB,OAAO,CAAC,kBAAkB;IAkB1B;;;;;;OAMG;IACH,OAAO,CAAC,aAAa;IAgFrB;;;OAGG;IACH,OAAO,CAAC,kBAAkB;IAyB1B;;OAEG;IACH,OAAO,CAAC,oBAAoB;IAQ5B,OAAO,CAAC,2BAA2B;IAgBnC,sBAAsB,IAAI,MAAM,EAAE;IAgB5B,WAAW,IAAI,OAAO,CAAC,OAAO,CAAC;IAKrC,eAAe,IAAI,MAAM,EAAE;IAQ3B,OAAO,CAAC,uBAAuB;IAkD/B,OAAO,CAAC,uBAAuB;IAkB/B,OAAO,CAAC,mBAAmB;IAc3B,OAAO,CAAC,cAAc;IAmEtB,OAAO,CAAC,eAAe;IAYvB,OAAO,CAAC,QAAQ;YAWF,qBAAqB;IAiBnC,OAAO,CAAC,uBAAuB;CA6ChC"}

package/dist/sdk/{check-execution-engine-PO5XKTHP.mjs → check-execution-engine-X7VCV6KI.mjs}

@@ -1,9 +1,9 @@
 import {
   CheckExecutionEngine
-} from "./chunk-G24UL45Z.mjs";
+} from "./chunk-Q55L5EPS.mjs";
 import "./chunk-FIL2OGF6.mjs";
 import "./chunk-WMJKH4XE.mjs";
 export {
   CheckExecutionEngine
 };
-//# sourceMappingURL=check-execution-engine-PO5XKTHP.mjs.map
+//# sourceMappingURL=check-execution-engine-X7VCV6KI.mjs.map

package/dist/sdk/{chunk-G24UL45Z.mjs → chunk-Q55L5EPS.mjs}

@@ -1549,7 +1549,7 @@ var PRReviewer = class {
   async reviewPR(owner, repo, prNumber, prInfo, options = {}) {
     const { debug = false, config, checks } = options;
     if (config && checks && checks.length > 0) {
-      const { CheckExecutionEngine: CheckExecutionEngine2 } = await import("./check-execution-engine-PO5XKTHP.mjs");
+      const { CheckExecutionEngine: CheckExecutionEngine2 } = await import("./check-execution-engine-X7VCV6KI.mjs");
       const engine = new CheckExecutionEngine2();
       const { results } = await engine.executeGroupedChecks(
         prInfo,
@@ -3908,6 +3908,7 @@ var CommandCheckProvider = class extends CheckProvider {
       try {
         const parsed = JSON.parse(rawOutput);
         output = parsed;
+        logger.debug(`\u{1F527} Debug: Parsed entire output as JSON successfully`);
       } catch {
         const extracted2 = this.extractJsonFromEnd(rawOutput);
         if (extracted2) {
@@ -3916,13 +3917,28 @@ var CommandCheckProvider = class extends CheckProvider {
             logger.debug(
               `\u{1F527} Debug: Extracted and parsed JSON from end of output (${extracted2.length} chars from ${rawOutput.length} total)`
             );
-          } catch {
+            logger.debug(`\u{1F527} Debug: Extracted JSON content: ${extracted2.slice(0, 200)}`);
+          } catch (parseError) {
+            logger.debug(
+              `\u{1F527} Debug: Extracted text is not valid JSON: ${parseError instanceof Error ? parseError.message : "Unknown error"}`
+            );
             output = rawOutput;
           }
         } else {
+          logger.debug(`\u{1F527} Debug: No JSON found in output, keeping as string`);
           output = rawOutput;
         }
       }
+      if (output !== rawOutput) {
+        try {
+          const outputType = Array.isArray(output) ? `array[${output.length}]` : typeof output;
+          logger.debug(`\u{1F527} Debug: Parsed output type: ${outputType}`);
+          if (typeof output === "object" && output !== null) {
+            logger.debug(`\u{1F527} Debug: Parsed output keys: ${Object.keys(output).join(", ")}`);
+          }
+        } catch {
+        }
+      }
       let finalOutput = output;
       if (transform) {
         try {
@@ -4097,6 +4113,16 @@ return ${returnTarget};
       return result;
     } catch (error) {
       const errorMessage = error instanceof Error ? error.message : "Unknown error";
+      let isTimeout = false;
+      if (error && typeof error === "object") {
+        const execError = error;
+        if (execError.killed && execError.signal === "SIGTERM") {
+          isTimeout = true;
+        }
+        if (execError.code === "ETIMEDOUT") {
+          isTimeout = true;
+        }
+      }
       let stderrOutput = "";
       if (error && typeof error === "object") {
         const execError = error;
@@ -4104,17 +4130,32 @@ return ${returnTarget};
           stderrOutput = execError.stderr.trim();
         }
       }
-      const detailedMessage = stderrOutput ? `Command execution failed: ${errorMessage}
+      let detailedMessage;
+      let ruleId;
+      if (isTimeout) {
+        const timeoutSeconds = config.timeout || 60;
+        detailedMessage = `Command execution timed out after ${timeoutSeconds} seconds`;
+        if (stderrOutput) {
+          detailedMessage += `
+
+Stderr output:
+${stderrOutput}`;
+        }
+        ruleId = "command/timeout";
+      } else {
+        detailedMessage = stderrOutput ? `Command execution failed: ${errorMessage}
 
 Stderr output:
 ${stderrOutput}` : `Command execution failed: ${errorMessage}`;
+        ruleId = "command/execution_error";
+      }
       logger.error(`\u2717 ${detailedMessage}`);
       return {
         issues: [
           {
             file: "command",
             line: 0,
-            ruleId: "command/execution_error",
+            ruleId,
             message: detailedMessage,
             severity: "error",
             category: "logic"
@@ -5166,6 +5207,14 @@ var FailureConditionEvaluator = class _FailureConditionEvaluator {
    */
   buildEvaluationContext(checkName, checkSchema, checkGroup, reviewSummary, previousOutputs) {
     const { issues, debug } = reviewSummary;
+    const reviewSummaryWithOutput = reviewSummary;
+    const {
+      output: extractedOutput,
+      // Exclude issues from otherFields since we handle it separately
+      issues: _issues,
+      // eslint-disable-line @typescript-eslint/no-unused-vars
+      ...otherFields
+    } = reviewSummaryWithOutput;
     const context = {
       output: {
         issues: (issues || []).map((issue) => ({
@@ -5182,9 +5231,9 @@ var FailureConditionEvaluator = class _FailureConditionEvaluator {
           replacement: issue.replacement
         })),
         // Include additional schema-specific data from reviewSummary
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        ...reviewSummary
-        // Pass through any additional fields
+        ...otherFields,
+        // Spread the extracted output directly (avoid output.output nesting)
+        ...extractedOutput && typeof extractedOutput === "object" ? extractedOutput : {}
       },
       outputs: (() => {
         if (!previousOutputs) return {};
@@ -6600,6 +6649,31 @@ ${expr}
     };
     providerConfig.forEach = checkConfig.forEach;
     const result = await provider.execute(prInfo, providerConfig);
+    if (checkConfig.forEach && (!result.issues || result.issues.length === 0)) {
+      const reviewSummaryWithOutput = result;
+      const validation = this.validateAndNormalizeForEachOutput(
+        checkName,
+        reviewSummaryWithOutput.output,
+        checkConfig.group
+      );
+      if (!validation.isValid) {
+        return validation.error;
+      }
+    }
+    if (config && (config.fail_if || checkConfig.fail_if)) {
+      const failureResults = await this.evaluateFailureConditions(checkName, result, config);
+      if (failureResults.length > 0) {
+        const failureIssues = failureResults.filter((f) => f.failed).map((f) => ({
+          file: "system",
+          line: 0,
+          ruleId: f.conditionName,
+          message: f.message || `Failure condition met: ${f.expression}`,
+          severity: f.severity || "error",
+          category: "logic"
+        }));
+        result.issues = [...result.issues || [], ...failureIssues];
+      }
+    }
     const content = await this.renderCheckContent(checkName, result, checkConfig, prInfo);
     return {
       checkName,
@@ -6610,6 +6684,53 @@ ${expr}
       // Include structured issues
     };
   }
+  /**
+   * Validate and normalize forEach output
+   * Returns normalized array or throws validation error result
+   */
+  validateAndNormalizeForEachOutput(checkName, output, checkGroup) {
+    if (output === void 0) {
+      logger.error(`\u2717 forEach check "${checkName}" produced undefined output`);
+      return {
+        isValid: false,
+        error: {
+          checkName,
+          content: "",
+          group: checkGroup || "default",
+          issues: [
+            {
+              file: "system",
+              line: 0,
+              ruleId: "forEach/undefined_output",
+              message: `forEach check "${checkName}" produced undefined output. Verify your command outputs valid data and your transform_js returns a value.`,
+              severity: "error",
+              category: "logic"
+            }
+          ]
+        }
+      };
+    }
+    let normalizedOutput;
+    if (Array.isArray(output)) {
+      normalizedOutput = output;
+    } else if (typeof output === "string") {
+      try {
+        const parsed = JSON.parse(output);
+        normalizedOutput = Array.isArray(parsed) ? parsed : [parsed];
+      } catch {
+        normalizedOutput = [output];
+      }
+    } else if (output === null) {
+      normalizedOutput = [];
+    } else {
+      normalizedOutput = [output];
+    }
+    logger.info(`  Found ${normalizedOutput.length} items for forEach iteration`);
+    return {
+      isValid: true,
+      normalizedOutput
+    };
+  }
   /**
    * Execute multiple checks with dependency awareness - return grouped results with statistics
    */
@@ -6819,10 +6940,14 @@ ${expr}
       const checkConfig = config.checks[checkName];
       if (checkConfig) {
         dependencies[checkName] = checkConfig.depends_on || [];
-        if (checkConfig.reuse_ai_session === true) {
+        if (checkConfig.reuse_ai_session) {
           sessionReuseChecks.add(checkName);
-          if (checkConfig.depends_on && checkConfig.depends_on.length > 0) {
-            sessionProviders.set(checkName, checkConfig.depends_on[0]);
+          if (typeof checkConfig.reuse_ai_session === "string") {
+            sessionProviders.set(checkName, checkConfig.reuse_ai_session);
+          } else if (checkConfig.reuse_ai_session === true) {
+            if (checkConfig.depends_on && checkConfig.depends_on.length > 0) {
+              sessionProviders.set(checkName, checkConfig.depends_on[0]);
+            }
           }
         }
       } else {
@@ -7385,27 +7510,23 @@ ${expr}
           }
           const reviewResult = result.value.result;
           const reviewSummaryWithOutput = reviewResult;
-          if (checkConfig?.forEach && reviewSummaryWithOutput.output !== void 0) {
+          if (checkConfig?.forEach && (!reviewResult.issues || reviewResult.issues.length === 0)) {
+            const validation2 = this.validateAndNormalizeForEachOutput(
+              checkName,
+              reviewSummaryWithOutput.output,
+              checkConfig.group
+            );
+            if (!validation2.isValid) {
+              results.set(
+                checkName,
+                validation2.error.issues ? { issues: validation2.error.issues } : {}
+              );
+              continue;
+            }
+            const normalizedOutput = validation2.normalizedOutput;
             logger.debug(
               `\u{1F527} Debug: Raw output for forEach check ${checkName}: ${Array.isArray(reviewSummaryWithOutput.output) ? `array(${reviewSummaryWithOutput.output.length})` : typeof reviewSummaryWithOutput.output}`
             );
-            const rawOutput = reviewSummaryWithOutput.output;
-            let normalizedOutput;
-            if (Array.isArray(rawOutput)) {
-              normalizedOutput = rawOutput;
-            } else if (typeof rawOutput === "string") {
-              try {
-                const parsed = JSON.parse(rawOutput);
-                normalizedOutput = Array.isArray(parsed) ? parsed : [parsed];
-              } catch {
-                normalizedOutput = [rawOutput];
-              }
-            } else if (rawOutput === void 0 || rawOutput === null) {
-              normalizedOutput = [];
-            } else {
-              normalizedOutput = [rawOutput];
-            }
-            logger.info(`  Found ${normalizedOutput.length} items for forEach iteration`);
             try {
               const preview = JSON.stringify(normalizedOutput);
               logger.debug(
@@ -8648,4 +8769,4 @@ export {
   logger,
   CheckExecutionEngine
 };
-//# sourceMappingURL=chunk-G24UL45Z.mjs.map
+//# sourceMappingURL=chunk-Q55L5EPS.mjs.map