@probelabs/visor 0.1.29 → 0.1.30

package/dist/index.js

@@ -86257,7 +86257,7 @@ async function handleEvent(octokit, inputs, eventName, context, config) {
     // Handle different GitHub events
     switch (eventName) {
         case 'issue_comment':
-            await handleIssueComment(octokit, owner, repo, context, inputs);
+            await handleIssueComment(octokit, owner, repo, context, inputs, config, checksToRun);
             break;
         case 'pull_request':
             // Run the checks that are configured for this event
@@ -86383,7 +86383,7 @@ async function handleIssueEvent(octokit, owner, repo, context, inputs, config, c
         throw error;
     }
 }
-async function handleIssueComment(octokit, owner, repo, context, inputs) {
+async function handleIssueComment(octokit, owner, repo, context, inputs, actionConfig, _actionChecksToRun) {
     const comment = context.event?.comment;
     const issue = context.event?.issue;
     if (!comment || !issue) {
@@ -86399,33 +86399,42 @@ async function handleIssueComment(octokit, owner, repo, context, inputs) {
     }
     // Process comments on both issues and PRs
     // (issue.pull_request exists for PR comments, doesn't exist for issue comments)
+    const isPullRequest = !!issue.pull_request;
     // Load configuration to get available commands
     const configManager = new config_1.ConfigManager();
     let config;
     const commandRegistry = {};
-    try {
-        config = await configManager.findAndLoadConfig();
-        // Build command registry from config
-        if (config.checks) {
-            // Add 'review' command that runs all checks
-            commandRegistry['review'] = Object.keys(config.checks);
-            // Also add individual check names as commands
-            for (const [checkId, checkConfig] of Object.entries(config.checks)) {
-                // Legacy: check if it has old 'command' property
-                if (checkConfig.command) {
-                    if (!commandRegistry[checkConfig.command]) {
-                        commandRegistry[checkConfig.command] = [];
-                    }
-                    commandRegistry[checkConfig.command].push(checkId);
+    // Use provided config if available (from action), otherwise load it
+    if (actionConfig) {
+        config = actionConfig;
+    }
+    else {
+        try {
+            config = await configManager.findAndLoadConfig();
+        }
+        catch {
+            console.log('Could not load config, using defaults');
+            config = undefined;
+        }
+    }
+    // Build command registry from config
+    if (config?.checks) {
+        // Add 'review' command that runs all checks
+        commandRegistry['review'] = Object.keys(config.checks);
+        // Also add individual check names as commands
+        for (const [checkId, checkConfig] of Object.entries(config.checks)) {
+            // Legacy: check if it has old 'command' property
+            if (checkConfig.command) {
+                if (!commandRegistry[checkConfig.command]) {
+                    commandRegistry[checkConfig.command] = [];
                 }
-                // New: add check name as command
-                commandRegistry[checkId] = [checkId];
+                commandRegistry[checkConfig.command].push(checkId);
             }
+            // New: add check name as command
+            commandRegistry[checkId] = [checkId];
         }
     }
-    catch {
-        console.log('Could not load config, using defaults');
-        config = undefined;
+    else {
         // Default commands when no config is available
         commandRegistry['review'] = ['security', 'performance', 'style', 'architecture'];
     }
@@ -86442,22 +86451,40 @@ async function handleIssueComment(octokit, owner, repo, context, inputs) {
     const reviewer = new reviewer_1.PRReviewer(octokit);
     switch (command.type) {
         case 'status':
-            const statusPrInfo = await analyzer.fetchPRDiff(owner, repo, prNumber, undefined, 'issue_comment');
-            const statusComment = `## 📊 PR Status\n\n` +
-                `**Title:** ${statusPrInfo.title}\n` +
-                `**Author:** ${statusPrInfo.author}\n` +
-                `**Files Changed:** ${statusPrInfo.files.length}\n` +
-                `**Additions:** +${statusPrInfo.totalAdditions}\n` +
-                `**Deletions:** -${statusPrInfo.totalDeletions}\n` +
-                `**Base:** ${statusPrInfo.base} → **Head:** ${statusPrInfo.head}\n\n` +
-                `\n---\n\n` +
-                `*Powered by [Visor](https://probelabs.com/visor) from [Probelabs](https://probelabs.com)*`;
-            await octokit.rest.issues.createComment({
-                owner,
-                repo,
-                issue_number: prNumber,
-                body: statusComment,
-            });
+            if (isPullRequest) {
+                const statusPrInfo = await analyzer.fetchPRDiff(owner, repo, prNumber, undefined, 'issue_comment');
+                const statusComment = `## 📊 PR Status\n\n` +
+                    `**Title:** ${statusPrInfo.title}\n` +
+                    `**Author:** ${statusPrInfo.author}\n` +
+                    `**Files Changed:** ${statusPrInfo.files.length}\n` +
+                    `**Additions:** +${statusPrInfo.totalAdditions}\n` +
+                    `**Deletions:** -${statusPrInfo.totalDeletions}\n` +
+                    `**Base:** ${statusPrInfo.base} → **Head:** ${statusPrInfo.head}\n\n` +
+                    `\n---\n\n` +
+                    `*Powered by [Visor](https://probelabs.com/visor) from [Probelabs](https://probelabs.com)*`;
+                await octokit.rest.issues.createComment({
+                    owner,
+                    repo,
+                    issue_number: prNumber,
+                    body: statusComment,
+                });
+            }
+            else {
+                const statusComment = `## 📊 Issue Status\n\n` +
+                    `**Title:** ${issue.title || 'N/A'}\n` +
+                    `**Author:** ${issue.user?.login || 'unknown'}\n` +
+                    `**State:** ${issue.state || 'open'}\n` +
+                    `**Comments:** ${issue.comments || 0}\n` +
+                    `**Created:** ${issue.created_at || 'unknown'}\n` +
+                    `\n---\n\n` +
+                    `*Powered by [Visor](https://probelabs.com/visor) from [Probelabs](https://probelabs.com)*`;
+                await octokit.rest.issues.createComment({
+                    owner,
+                    repo,
+                    issue_number: prNumber,
+                    body: statusComment,
+                });
+            }
             break;
         case 'help':
             await octokit.rest.issues.createComment({
@@ -86474,7 +86501,28 @@ async function handleIssueComment(octokit, owner, repo, context, inputs) {
                 // Resolve all dependencies recursively
                 const checkIds = resolveDependencies(initialCheckIds, config);
                 console.log(`Running checks for command /${command.type} (initial: ${initialCheckIds.join(', ')}, resolved: ${checkIds.join(', ')})`);
-                const prInfo = await analyzer.fetchPRDiff(owner, repo, prNumber, undefined, 'issue_comment');
+                // Different handling for PRs vs Issues
+                let prInfo;
+                if (isPullRequest) {
+                    // It's a PR comment - fetch the PR diff
+                    prInfo = await analyzer.fetchPRDiff(owner, repo, prNumber, undefined, 'issue_comment');
+                }
+                else {
+                    // It's an issue comment - create a minimal PRInfo structure for issue assistant
+                    prInfo = {
+                        number: issue.number,
+                        title: issue.title || '',
+                        body: issue.body || '',
+                        author: issue.user?.login || 'unknown',
+                        base: 'main',
+                        head: 'issue',
+                        files: [],
+                        totalAdditions: 0,
+                        totalDeletions: 0,
+                        fullDiff: '',
+                        eventType: 'issue_comment'
+                    };
+                }
                 // Extract common arguments
                 const focus = command.args?.find(arg => arg.startsWith('--focus='))?.split('=')[1];
                 const format = command.args?.find(arg => arg.startsWith('--format='))?.split('=')[1];
@@ -86486,11 +86534,34 @@ async function handleIssueComment(octokit, owner, repo, context, inputs) {
                         }
                     }
                 }
+                // Only run checks that are appropriate for the context
+                const filteredCheckIds = checkIds.filter(checkId => {
+                    if (!config?.checks?.[checkId])
+                        return false;
+                    const checkConfig = config.checks[checkId];
+                    const checkEvents = checkConfig.on || ['pr_opened', 'pr_updated'];
+                    // For issue comments, only run checks that are configured for issue_comment events
+                    if (!isPullRequest) {
+                        return checkEvents.includes('issue_comment');
+                    }
+                    // For PR comments, run checks configured for PR events or issue_comment
+                    return checkEvents.includes('pr_updated') || checkEvents.includes('issue_comment');
+                });
+                if (filteredCheckIds.length === 0) {
+                    console.log(`No checks configured to run for ${isPullRequest ? 'PR' : 'issue'} comments`);
+                    await octokit.rest.issues.createComment({
+                        owner,
+                        repo,
+                        issue_number: prNumber,
+                        body: `⚠️ No checks are configured to run for ${isPullRequest ? 'PR' : 'issue'} comments with command /${command.type}\n\n*Powered by [Visor](https://probelabs.com/visor)*`,
+                    });
+                    return;
+                }
                 const groupedResults = await reviewer.reviewPR(owner, repo, prNumber, prInfo, {
                     focus,
                     format,
                     config: config,
-                    checks: checkIds,
+                    checks: filteredCheckIds,
                     parallelExecution: false,
                 });
                 // Check if commenting is enabled before posting
@@ -86502,7 +86573,7 @@ async function handleIssueComment(octokit, owner, repo, context, inputs) {
                     });
                 }
                 else {
-                    console.log('📝 Skipping PR comment (comment-on-pr is disabled)');
+                    console.log('📝 Skipping comment (comment-on-pr is disabled)');
                 }
                 // Calculate total check results from grouped results
                 const totalChecks = Object.values(groupedResults).flat().length;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@probelabs/visor",
-  "version": "0.1.29",
+  "version": "0.1.30",
   "main": "dist/index.js",
   "bin": {
     "visor": "./dist/index.js"