@probelabs/visor 0.1.178 → 0.1.179

package/defaults/assistant.yaml

@@ -270,11 +270,11 @@ inputs:
           allowed_commands:
             type: array
             items: { type: string }
-            description: Bash command patterns this skill is allowed to run (e.g., 'git:log:*')
+            description: Bash command patterns this skill is allowed to run (e.g., 'git:log:*'). Only applied for skills with non-workflow tools.
           disallowed_commands:
             type: array
             items: { type: string }
-            description: Bash command patterns this skill should not run (e.g., 'git:push:*')
+            description: Bash command patterns this skill should not run (e.g., 'git:push:*'). Only applied for skills with non-workflow tools.
           always:
             type: boolean
             description: Always activate this skill regardless of classification
@@ -293,7 +293,7 @@ inputs:
   - name: max_iterations
     required: false
     description: Maximum AI iterations
-    default: 30
+    default: 100
     schema:
       type: number
 
@@ -654,18 +654,34 @@ steps:
             }
           }
 
-          // Collect bash command patterns from active skills
-          if (Array.isArray(skill.allowed_commands)) {
-            for (let j = 0; j < skill.allowed_commands.length; j++) {
-              if (bashAllow.indexOf(skill.allowed_commands[j]) === -1) {
-                bashAllow.push(skill.allowed_commands[j]);
+          // Only merge bash command patterns from skills whose tools run in the
+          // parent orchestrator (MCP servers, built-ins). Skip skills that only have
+          // workflow-based tools — those are sub-workflows with their own bash config.
+          let hasNonWorkflowTools = false;
+          if (normalizedTools && typeof normalizedTools === 'object') {
+            const tNames = Object.keys(normalizedTools);
+            for (let i = 0; i < tNames.length; i++) {
+              const tc = normalizedTools[tNames[i]];
+              if (!tc || !tc.workflow) {
+                hasNonWorkflowTools = true;
+                break;
               }
             }
           }
-          if (Array.isArray(skill.disallowed_commands)) {
-            for (let j = 0; j < skill.disallowed_commands.length; j++) {
-              if (bashDeny.indexOf(skill.disallowed_commands[j]) === -1) {
-                bashDeny.push(skill.disallowed_commands[j]);
+
+          if (hasNonWorkflowTools) {
+            if (Array.isArray(skill.allowed_commands)) {
+              for (let j = 0; j < skill.allowed_commands.length; j++) {
+                if (bashAllow.indexOf(skill.allowed_commands[j]) === -1) {
+                  bashAllow.push(skill.allowed_commands[j]);
+                }
+              }
+            }
+            if (Array.isArray(skill.disallowed_commands)) {
+              for (let j = 0; j < skill.disallowed_commands.length; j++) {
+                if (bashDeny.indexOf(skill.disallowed_commands[j]) === -1) {
+                  bashDeny.push(skill.disallowed_commands[j]);
+                }
               }
             }
           }
@@ -871,6 +887,16 @@ steps:
       If you catch yourself about to use bash or file tools for code operations — STOP and
       delegate to the correct skill tool instead.
 
+      ## CRITICAL: Do Not Retry Failed Engineer Calls With the Same Approach
+      When the `engineer` tool fails or returns an error/partial result:
+      - **DO NOT call engineer again with the same task** — it will hit the same obstacles
+      - **Acknowledge the failure** to the user and explain what went wrong
+      - **Only retry if you have a fundamentally different approach** (different strategy,
+        different files, different technique — not just rephrasing the same request)
+      - If engineer hit its iteration limit or timed out, it means the task is too complex
+        for a single tool call — break it into smaller, independent pieces or report back
+      - Never poll/loop waiting for CI to pass — report the current status and let the user decide
+
       ## CRITICAL: Preserve Tool Output Details
       When tools return detailed data (lists, analytics, search results):
       - **DO NOT summarize or compress** the tool output
@@ -2244,10 +2270,6 @@ tests:
               request needs codebase exploration, understanding implementation details,
               code search, or documentation questions. READ-ONLY — cannot modify files,
               only investigate and answer questions.
-            allowed_commands:
-              - "git:log:*"
-              - "git:show:*"
-              - "git:diff:*"
             knowledge: |
               ## Code Explorer
               Use the code-talk tool to explore code repositories.

package/defaults/skills/code-explorer.yaml

@@ -18,23 +18,23 @@ description: >
   request needs codebase exploration, understanding implementation details,
   code search, or documentation questions. READ-ONLY — cannot modify files,
   only investigate and answer questions.
-allowed_commands:
-  - "git:log:*"
-  - "git:show:*"
-  - "git:diff:*"
 knowledge: |
-  ## Code Explorer
-  Use the code-talk tool to explore code repositories.
+  ## Code Explorer — MANDATORY for all code questions
+  The `code-explorer` tool is your ONLY way to read, search, or understand source code.
+  **DO NOT use bash** (git show, git diff, git log, cat, grep, find, etc.) for code tasks.
+  **ALWAYS call `code-explorer`** instead — it has full repository access and returns
+  structured answers with file references.
+
   The tool returns `confidence` ("high"/"medium"/"low") and `confidence_reason`.
   - If confidence "high", trust the answer — do NOT re-call with rephrased question
   - Only call again for a genuinely DIFFERENT aspect of the codebase
   - If confidence "medium" or "low", check confidence_reason for what to refine
 
   ## Usage Instructions
-  1. Call the code-explorer tool with the user's question
+  1. Call the `code-explorer` tool with the user's question — do NOT try to answer code questions yourself
   2. Use the answer from the tool result as your response
   3. Include the references (file paths with URLs) in your answer
-  4. Do NOT generate a generic response - relay what the tool found
+  4. Do NOT generate a generic response — relay what the tool found
 tools:
   code-explorer:
     workflow: code-talk

package/dist/agent-protocol/tasks-cli-handler.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"tasks-cli-handler.d.ts","sourceRoot":"","sources":["file:///home/runner/work/visor/visor/src/agent-protocol/tasks-cli-handler.ts"],"names":[],"mappings":"AAukBA,wBAAsB,kBAAkB,CAAC,IAAI,EAAE,MAAM,EAAE,GAAG,OAAO,CAAC,IAAI,CAAC,CA0CtE"}
+{"version":3,"file":"tasks-cli-handler.d.ts","sourceRoot":"","sources":["file:///home/runner/work/visor/visor/src/agent-protocol/tasks-cli-handler.ts"],"names":[],"mappings":"AAslBA,wBAAsB,kBAAkB,CAAC,IAAI,EAAE,MAAM,EAAE,GAAG,OAAO,CAAC,IAAI,CAAC,CA0CtE"}

package/dist/agent-protocol/track-execution.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"track-execution.d.ts","sourceRoot":"","sources":["file:///home/runner/work/visor/visor/src/agent-protocol/track-execution.ts"],"names":[],"mappings":"AAAA;;;;;;;;GAQG;AAOH,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,cAAc,CAAC;AAC9C,OAAO,KAAK,EAAgB,SAAS,EAAE,MAAM,SAAS,CAAC;AAEvD,MAAM,MAAM,UAAU,GAClB,KAAK,GACL,OAAO,GACP,UAAU,GACV,OAAO,GACP,UAAU,GACV,OAAO,GACP,KAAK,GACL,KAAK,GACL,WAAW,GACX,SAAS,CAAC;AAEd,MAAM,WAAW,qBAAqB;IACpC,SAAS,EAAE,SAAS,CAAC;IACrB,MAAM,EAAE,UAAU,CAAC;IACnB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,6EAA6E;IAC7E,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,QAAQ,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;IACnC,0DAA0D;IAC1D,WAAW,EAAE,MAAM,CAAC;CACrB;AAED;;;;;;GAMG;AACH,wBAAsB,cAAc,CAAC,CAAC,EACpC,IAAI,EAAE,qBAAqB,EAC3B,QAAQ,EAAE,MAAM,OAAO,CAAC,CAAC,CAAC,GACzB,OAAO,CAAC;IAAE,IAAI,EAAE,SAAS,CAAC;IAAC,MAAM,EAAE,CAAC,CAAA;CAAE,CAAC,CA0DzC"}
+{"version":3,"file":"track-execution.d.ts","sourceRoot":"","sources":["file:///home/runner/work/visor/visor/src/agent-protocol/track-execution.ts"],"names":[],"mappings":"AAAA;;;;;;;;GAQG;AAOH,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,cAAc,CAAC;AAC9C,OAAO,KAAK,EAAgB,SAAS,EAAE,MAAM,SAAS,CAAC;AAEvD,MAAM,MAAM,UAAU,GAClB,KAAK,GACL,OAAO,GACP,UAAU,GACV,OAAO,GACP,UAAU,GACV,OAAO,GACP,KAAK,GACL,KAAK,GACL,WAAW,GACX,SAAS,CAAC;AAEd,MAAM,WAAW,qBAAqB;IACpC,SAAS,EAAE,SAAS,CAAC;IACrB,MAAM,EAAE,UAAU,CAAC;IACnB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,6EAA6E;IAC7E,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,QAAQ,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;IACnC,0DAA0D;IAC1D,WAAW,EAAE,MAAM,CAAC;CACrB;AAED;;;;;;GAMG;AACH,wBAAsB,cAAc,CAAC,CAAC,EACpC,IAAI,EAAE,qBAAqB,EAC3B,QAAQ,EAAE,MAAM,OAAO,CAAC,CAAC,CAAC,GACzB,OAAO,CAAC;IAAE,IAAI,EAAE,SAAS,CAAC;IAAC,MAAM,EAAE,CAAC,CAAA;CAAE,CAAC,CAmFzC"}

package/dist/defaults/assistant.yaml

@@ -270,11 +270,11 @@ inputs:
           allowed_commands:
             type: array
             items: { type: string }
-            description: Bash command patterns this skill is allowed to run (e.g., 'git:log:*')
+            description: Bash command patterns this skill is allowed to run (e.g., 'git:log:*'). Only applied for skills with non-workflow tools.
           disallowed_commands:
             type: array
             items: { type: string }
-            description: Bash command patterns this skill should not run (e.g., 'git:push:*')
+            description: Bash command patterns this skill should not run (e.g., 'git:push:*'). Only applied for skills with non-workflow tools.
           always:
             type: boolean
             description: Always activate this skill regardless of classification
@@ -293,7 +293,7 @@ inputs:
   - name: max_iterations
     required: false
     description: Maximum AI iterations
-    default: 30
+    default: 100
     schema:
       type: number
 
@@ -654,18 +654,34 @@ steps:
             }
           }
 
-          // Collect bash command patterns from active skills
-          if (Array.isArray(skill.allowed_commands)) {
-            for (let j = 0; j < skill.allowed_commands.length; j++) {
-              if (bashAllow.indexOf(skill.allowed_commands[j]) === -1) {
-                bashAllow.push(skill.allowed_commands[j]);
+          // Only merge bash command patterns from skills whose tools run in the
+          // parent orchestrator (MCP servers, built-ins). Skip skills that only have
+          // workflow-based tools — those are sub-workflows with their own bash config.
+          let hasNonWorkflowTools = false;
+          if (normalizedTools && typeof normalizedTools === 'object') {
+            const tNames = Object.keys(normalizedTools);
+            for (let i = 0; i < tNames.length; i++) {
+              const tc = normalizedTools[tNames[i]];
+              if (!tc || !tc.workflow) {
+                hasNonWorkflowTools = true;
+                break;
               }
             }
           }
-          if (Array.isArray(skill.disallowed_commands)) {
-            for (let j = 0; j < skill.disallowed_commands.length; j++) {
-              if (bashDeny.indexOf(skill.disallowed_commands[j]) === -1) {
-                bashDeny.push(skill.disallowed_commands[j]);
+
+          if (hasNonWorkflowTools) {
+            if (Array.isArray(skill.allowed_commands)) {
+              for (let j = 0; j < skill.allowed_commands.length; j++) {
+                if (bashAllow.indexOf(skill.allowed_commands[j]) === -1) {
+                  bashAllow.push(skill.allowed_commands[j]);
+                }
+              }
+            }
+            if (Array.isArray(skill.disallowed_commands)) {
+              for (let j = 0; j < skill.disallowed_commands.length; j++) {
+                if (bashDeny.indexOf(skill.disallowed_commands[j]) === -1) {
+                  bashDeny.push(skill.disallowed_commands[j]);
+                }
               }
             }
           }
@@ -871,6 +887,16 @@ steps:
       If you catch yourself about to use bash or file tools for code operations — STOP and
       delegate to the correct skill tool instead.
 
+      ## CRITICAL: Do Not Retry Failed Engineer Calls With the Same Approach
+      When the `engineer` tool fails or returns an error/partial result:
+      - **DO NOT call engineer again with the same task** — it will hit the same obstacles
+      - **Acknowledge the failure** to the user and explain what went wrong
+      - **Only retry if you have a fundamentally different approach** (different strategy,
+        different files, different technique — not just rephrasing the same request)
+      - If engineer hit its iteration limit or timed out, it means the task is too complex
+        for a single tool call — break it into smaller, independent pieces or report back
+      - Never poll/loop waiting for CI to pass — report the current status and let the user decide
+
       ## CRITICAL: Preserve Tool Output Details
       When tools return detailed data (lists, analytics, search results):
       - **DO NOT summarize or compress** the tool output
@@ -2244,10 +2270,6 @@ tests:
               request needs codebase exploration, understanding implementation details,
               code search, or documentation questions. READ-ONLY — cannot modify files,
               only investigate and answer questions.
-            allowed_commands:
-              - "git:log:*"
-              - "git:show:*"
-              - "git:diff:*"
             knowledge: |
               ## Code Explorer
               Use the code-talk tool to explore code repositories.

package/dist/defaults/skills/code-explorer.yaml

@@ -18,23 +18,23 @@ description: >
   request needs codebase exploration, understanding implementation details,
   code search, or documentation questions. READ-ONLY — cannot modify files,
   only investigate and answer questions.
-allowed_commands:
-  - "git:log:*"
-  - "git:show:*"
-  - "git:diff:*"
 knowledge: |
-  ## Code Explorer
-  Use the code-talk tool to explore code repositories.
+  ## Code Explorer — MANDATORY for all code questions
+  The `code-explorer` tool is your ONLY way to read, search, or understand source code.
+  **DO NOT use bash** (git show, git diff, git log, cat, grep, find, etc.) for code tasks.
+  **ALWAYS call `code-explorer`** instead — it has full repository access and returns
+  structured answers with file references.
+
   The tool returns `confidence` ("high"/"medium"/"low") and `confidence_reason`.
   - If confidence "high", trust the answer — do NOT re-call with rephrased question
   - Only call again for a genuinely DIFFERENT aspect of the codebase
   - If confidence "medium" or "low", check confidence_reason for what to refine
 
   ## Usage Instructions
-  1. Call the code-explorer tool with the user's question
+  1. Call the `code-explorer` tool with the user's question — do NOT try to answer code questions yourself
   2. Use the answer from the tool result as your response
   3. Include the references (file paths with URLs) in your answer
-  4. Do NOT generate a generic response - relay what the tool found
+  4. Do NOT generate a generic response — relay what the tool found
 tools:
   code-explorer:
     workflow: code-talk

package/dist/frontends/slack-frontend.d.ts

@@ -48,6 +48,12 @@ export declare class SlackFrontend implements Frontend {
     private getInboundSlackEvent;
     private isTelemetryEnabled;
     private maybePostError;
+    /**
+     * Post error to Slack regardless of errorNotified flag.
+     * Used for fatal/shutdown errors that must always reach the user.
+     */
+    private forcePostError;
+    private postErrorToSlack;
     private isExecutionFailureIssue;
     private maybePostExecutionFailure;
     private ensureAcknowledgement;

package/dist/frontends/slack-frontend.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"slack-frontend.d.ts","sourceRoot":"","sources":["file:///home/runner/work/visor/visor/src/frontends/slack-frontend.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;GAoBG;AACH,OAAO,KAAK,EAAE,QAAQ,EAAE,eAAe,EAAE,MAAM,QAAQ,CAAC;AAYxD,KAAK,mBAAmB,GAAG;IACzB,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,aAAa,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IACvC,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,aAAa,CAAC,EAAE,OAAO,CAAC;IACxB,SAAS,CAAC,EAAE;QACV,OAAO,CAAC,EAAE,OAAO,CAAC;KACnB,CAAC;CACH,CAAC;AAEF,qBAAa,aAAc,YAAW,QAAQ;IAC5C,SAAgB,IAAI,WAAW;IAC/B,OAAO,CAAC,IAAI,CAAsC;IAClD,OAAO,CAAC,GAAG,CAAsB;IAEjC,OAAO,CAAC,KAAK,CAAkB;IAC/B,OAAO,CAAC,MAAM,CAAgD;IAC9D,OAAO,CAAC,OAAO,CAAkB;IACjC,OAAO,CAAC,QAAQ,CAAsB;IACtC,OAAO,CAAC,aAAa,CAAkB;IACvC,OAAO,CAAC,eAAe,CAAoD;gBAE/D,MAAM,CAAC,EAAE,mBAAmB;IAIxC,KAAK,CAAC,GAAG,EAAE,eAAe,GAAG,IAAI;IA6JjC,IAAI,IAAI,IAAI;IAKZ,OAAO,CAAC,QAAQ;IAchB,OAAO,CAAC,sBAAsB;IAY9B,OAAO,CAAC,oBAAoB;IAW5B,OAAO,CAAC,kBAAkB;YAcZ,cAAc;IA2D5B,OAAO,CAAC,uBAAuB;YAcjB,yBAAyB;YAgCzB,qBAAqB;YAsCrB,iBAAiB;IA6B/B;;;;OAIG;YACW,oBAAoB;IA0QlC,OAAO,CAAC,YAAY;CAWrB"}
+{"version":3,"file":"slack-frontend.d.ts","sourceRoot":"","sources":["file:///home/runner/work/visor/visor/src/frontends/slack-frontend.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;GAoBG;AACH,OAAO,KAAK,EAAE,QAAQ,EAAE,eAAe,EAAE,MAAM,QAAQ,CAAC;AAYxD,KAAK,mBAAmB,GAAG;IACzB,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,aAAa,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IACvC,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,aAAa,CAAC,EAAE,OAAO,CAAC;IACxB,SAAS,CAAC,EAAE;QACV,OAAO,CAAC,EAAE,OAAO,CAAC;KACnB,CAAC;CACH,CAAC;AAEF,qBAAa,aAAc,YAAW,QAAQ;IAC5C,SAAgB,IAAI,WAAW;IAC/B,OAAO,CAAC,IAAI,CAAsC;IAClD,OAAO,CAAC,GAAG,CAAsB;IAEjC,OAAO,CAAC,KAAK,CAAkB;IAC/B,OAAO,CAAC,MAAM,CAAgD;IAC9D,OAAO,CAAC,OAAO,CAAkB;IACjC,OAAO,CAAC,QAAQ,CAAsB;IACtC,OAAO,CAAC,aAAa,CAAkB;IACvC,OAAO,CAAC,eAAe,CAAoD;gBAE/D,MAAM,CAAC,EAAE,mBAAmB;IAIxC,KAAK,CAAC,GAAG,EAAE,eAAe,GAAG,IAAI;IAyKjC,IAAI,IAAI,IAAI;IAKZ,OAAO,CAAC,QAAQ;IAchB,OAAO,CAAC,sBAAsB;IAY9B,OAAO,CAAC,oBAAoB;IAW5B,OAAO,CAAC,kBAAkB;YAcZ,cAAc;IAU5B;;;OAGG;YACW,cAAc;YASd,gBAAgB;IA0D9B,OAAO,CAAC,uBAAuB;YAcjB,yBAAyB;YAgCzB,qBAAqB;YAsCrB,iBAAiB;IA6B/B;;;;OAIG;YACW,oBAAoB;IA0QlC,OAAO,CAAC,YAAY;CAWrB"}