@probelabs/probe 0.6.0-rc199 → 0.6.0-rc201

package/build/delegate.js

@@ -229,6 +229,9 @@ export async function delegate({
 			console.error(`[DELEGATE] Using ProbeAgent SDK with code-researcher prompt`);
 		}
 		// Create a new ProbeAgent instance for the delegated task
+		// IMPORTANT: We pass both path and cwd set to the same value (workspace root)
+		// to prevent path doubling issues. The parent's navigation context should not
+		// affect the subagent's path resolution - subagents always work from workspace root.
 		const subagent = new ProbeAgent({
 			sessionId,
 			promptType: 'code-researcher',  // Clean prompt, not inherited from parent
@@ -238,7 +241,8 @@ export async function delegate({
 			maxIterations: remainingIterations,
 			debug,
 			tracer,
-			path,       // Inherit from parent
+			path,       // Workspace root (from delegateTool)
+			cwd: path,  // Explicitly set cwd to workspace root to prevent path doubling
 			provider,   // Inherit from parent
 			model,      // Inherit from parent
 			enableBash, // Inherit from parent

package/build/tools/common.js

@@ -5,6 +5,7 @@
 
 import { z } from 'zod';
 import { resolve, isAbsolute } from 'path';
+import { editSchema, createSchema } from './edit.js';
 
 // Common schemas for tool parameters (used for internal execution after XML parsing)
 export const searchSchema = z.object({
@@ -359,14 +360,16 @@ export function buildToolTagPattern(tools = DEFAULT_VALID_TOOLS) {
  * @returns {string[]} - Array of valid parameter names for this tool
  */
 function getValidParamsForTool(toolName) {
-	// Map tool names to their schemas
+	// Map tool names to their schemas (supports both Zod and JSON Schema formats)
 	const schemaMap = {
 		search: searchSchema,
 		query: querySchema,
 		extract: extractSchema,
 		delegate: delegateSchema,
 		bash: bashSchema,
-		attempt_completion: attemptCompletionSchema
+		attempt_completion: attemptCompletionSchema,
+		edit: editSchema,
+		create: createSchema
 	};
 
 	const schema = schemaMap[toolName];
@@ -382,10 +385,15 @@ function getValidParamsForTool(toolName) {
 	}
 
 	// Extract keys from Zod schema
-	if (schema && schema._def && schema._def.shape) {
+	if (schema._def && schema._def.shape) {
 		return Object.keys(schema._def.shape());
 	}
 
+	// Extract keys from JSON Schema (used by edit and create tools)
+	if (schema.properties) {
+		return Object.keys(schema.properties);
+	}
+
 	// Fallback: return empty array if we can't extract schema keys
 	return [];
 }

package/build/tools/vercel.js

@@ -295,9 +295,22 @@ export const delegateTool = (options = {}) => {
 				throw new TypeError('model must be a string, null, or undefined');
 			}
 
-			// Use inherited path if not specified in AI call
-			// Priority: explicit path > cwd > first allowedFolder
-			const effectivePath = path || cwd || (allowedFolders && allowedFolders[0]);
+			// Determine the path to pass to the subagent
+			// NOTE: Delegation intentionally uses DIFFERENT priority than other tools.
+			//
+			// Other tools (search, extract, query, bash) use: cwd || allowedFolders[0]
+			// Delegation uses: path || allowedFolders[0] || cwd
+			//
+			// This is intentional because:
+			// - Other tools operate within the parent's navigation context (cwd is correct)
+			// - Subagents need a FRESH start from workspace root, not parent's navigation state
+			// - Using parent's cwd would cause "path doubling" (Issue #348) where paths like
+			//   /workspace/project/src/internal/build/src/internal/build/file.go get constructed
+			//
+			// The workspace root (allowedFolders[0]) is the security boundary and correct base
+			// for subagent operations. Parent navigation context should not leak to subagents.
+			const workspaceRoot = allowedFolders && allowedFolders[0];
+			const effectivePath = path || workspaceRoot || cwd;
 
 			if (debug) {
 				console.error(`Executing delegate with task: "${task.substring(0, 100)}${task.length > 100 ? '...' : ''}"`);
@@ -305,7 +318,7 @@ export const delegateTool = (options = {}) => {
 					console.error(`Parent session: ${parentSessionId}`);
 				}
 				if (effectivePath && effectivePath !== path) {
-					console.error(`Using inherited path: ${effectivePath}`);
+					console.error(`Using workspace root: ${effectivePath} (cwd was: ${cwd || 'not set'})`);
 				}
 			}