@prmichaelsen/remember-mcp 3.12.0 → 3.14.0

package/agent/tasks/milestone-17-remember-core-migration/task-200-code-cleanup-verification.md

@@ -0,0 +1,52 @@
+# Task 200: Code Cleanup & Verification
+
+**Milestone**: M17 — remember-core Migration
+**Status**: not_started
+**Dependencies**: Tasks 194-199 (all tool migrations complete)
+**Estimated Hours**: 3-4
+
+---
+
+## Objective
+
+Remove duplicated source files that are now provided by remember-core. Update all imports. Run full regression.
+
+## Files to Remove
+
+| File | Replaced by (core) |
+|------|-------------------|
+| `src/services/confirmation-token.service.ts` | `ConfirmationTokenService` |
+| `src/services/preferences-database.service.ts` | `PreferencesDatabaseService` |
+| `src/services/space-config.service.ts` | `getSpaceConfig` |
+| `src/services/credentials-provider.ts` | `credentialsProvider` |
+| `src/utils/weaviate-filters.ts` | `buildCombinedSearchFilters` etc. |
+| `src/collections/dot-notation.ts` | `getCollectionName` etc. |
+| `src/collections/composite-ids.ts` | `generateCompositeId` etc. |
+| `src/collections/tracking-arrays.ts` | tracking array utils |
+| `src/constants/content-types.ts` | `isValidContentType` etc. |
+
+## Files to KEEP (ghost system, not in core)
+
+- `src/types/auth.ts` — has `GhostModeContext`
+- `src/types/ghost-config.ts`, `access-result.ts`
+- `src/services/ghost-config.service.ts`, `trust-enforcement.ts`, `access-control.ts`, `escalation.service.ts`, `trust-validator.ts`
+- `src/tools/ghost-config.ts`, `search-memory.ts`, `query-memory.ts`
+- `src/utils/debug.ts`, `logger.ts`
+
+## Process
+
+1. Remove one file at a time
+2. Update all imports that referenced the removed file to use core imports
+3. `npm run build` after each removal
+4. After all removals: `npm test` full regression
+
+## Acceptance Criteria
+
+- [ ] All listed files removed
+- [ ] All imports updated to use `@prmichaelsen/remember-core`
+- [ ] Ghost system files untouched and working
+- [ ] `npm run build` passes with no errors
+- [ ] `npm test` — all 454+ tests pass
+- [ ] No unused imports or dead code remaining
+- [ ] CHANGELOG updated
+- [ ] Version bumped

package/dist/core-services.d.ts

@@ -0,0 +1,25 @@
+/**
+ * Bridge module: initializes remember-core services from remember-mcp infrastructure.
+ *
+ * Core services are scoped per-user (MemoryService, RelationshipService, SpaceService)
+ * except PreferencesDatabaseService and ConfirmationTokenService which are singletons.
+ */
+import { MemoryService, RelationshipService, SpaceService, PreferencesDatabaseService, ConfirmationTokenService } from '@prmichaelsen/remember-core';
+import type { Logger } from '@prmichaelsen/remember-core';
+export interface CoreServices {
+    memory: MemoryService;
+    relationship: RelationshipService;
+    space: SpaceService;
+    preferences: PreferencesDatabaseService;
+    token: ConfirmationTokenService;
+}
+declare const coreLogger: Logger;
+declare const tokenService: ConfirmationTokenService;
+declare const preferencesService: PreferencesDatabaseService;
+/**
+ * Create core services scoped to a specific user.
+ * Call after databases have been initialized (initWeaviateClient + initFirestore).
+ */
+export declare function createCoreServices(userId: string): CoreServices;
+export { coreLogger, tokenService, preferencesService };
+//# sourceMappingURL=core-services.d.ts.map