@prmichaelsen/remember-mcp 2.6.2 → 2.6.4

package/CHANGELOG.md

@@ -5,6 +5,67 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.6.4] - 2026-02-16
+
+### 🔧 Improved
+
+- **Enhanced Tool Descriptions to Prevent Over-Filtering**
+  - Added explicit warnings to all search/query tools about content type filtering
+  - Agents now instructed to NOT add content_type filters unless explicitly requested by user
+  - Prevents missed results from over-filtering by content type
+  - Improves search quality and user experience
+
+### 📝 Changed
+
+- Updated `remember_search_memory` description with content type filtering guidance
+- Updated `remember_query_memory` description with content type filtering guidance
+- Updated `remember_search_space` description with content type filtering guidance
+- Updated `remember_query_space` description with content type filtering guidance
+- Added ✅ CORRECT and ❌ WRONG examples to clarify when to filter
+
+### 🎯 Impact
+
+- **Better Search Results**: No more over-filtering by content type
+- **More Relevant Memories**: All types included unless user specifies
+- **Clearer Agent Behavior**: Explicit guidance on when to use filters
+- **Improved UX**: Users get comprehensive results by default
+
+---
+
+## [2.6.3] - 2026-02-16
+
+### 🐛 Fixed
+
+- **CRITICAL: Fixed Empty Published Memories Bug**
+  - Published memories were empty shells with no content, title, or properties
+  - Root cause: `fetchObjectById()` calls missing `returnProperties` parameter
+  - Fixed in `remember_publish` and `remember_confirm` (executePublishMemory)
+  - All published memories now include complete property data
+
+### ✨ Added
+
+- **New Utility Function**: `fetchMemoryWithAllProperties()`
+  - Centralized helper in `src/weaviate/client.ts`
+  - Ensures all memory properties are fetched consistently
+  - Prevents future bugs from missing properties
+  - Includes `ALL_MEMORY_PROPERTIES` constant (20+ properties)
+
+### 🔧 Improved
+
+- Enhanced debug logging in publish flow
+  - Added property count verification
+  - Added hasTitle and hasContent checks
+  - Better diagnostics for troubleshooting
+
+### 🎯 Impact
+
+- **Fixes**: All published memories since v2.4.0 were empty
+- **Search**: Published memories now searchable (have content)
+- **Discovery**: Space functionality now works as designed
+- **Note**: Existing empty memories need to be re-published
+
+---
+
 ## [2.6.2] - 2026-02-16
 
 ### 🔒 Security

package/agent/progress.yaml

@@ -2,10 +2,10 @@
 
 project:
   name: remember-mcp
-  version: 2.5.1
+  version: 2.6.3
   started: 2026-02-11
   status: in_progress
-  current_milestone: M11
+  current_milestone: M12
   last_updated: 2026-02-16
 
 milestones:
@@ -162,7 +162,26 @@ milestones:
       ✅ No memory duplication across spaces
       ✅ All tests passing with multi-space support
       ✅ Documentation updated with multi-space examples
-    
+     
+  - id: M12
+    name: Comment System (Phase 1)
+    status: in_progress
+    progress: 60%
+    started: 2026-02-16
+    completed: null
+    estimated_weeks: 1
+    tasks_completed: 3
+    tasks_total: 5
+    notes: |
+      ✅ Task 55: Added 3 comment fields to schema (parent_id, thread_root_id, moderation_flags)
+      ✅ Task 56: Updated remember_search_space with include_comments parameter
+      ✅ Task 57: Updated remember_query_space with include_comments parameter
+      📋 Task 58: Add Comment Unit Tests (pending)
+      📋 Task 59: Update Documentation for Comments (pending)
+      ✅ Zero new tools required - reuses existing infrastructure
+      ✅ Backward compatible - comments excluded by default
+      ✅ Released v2.6.0 with comment system foundation
+     
   - id: M7
     name: Trust & Permissions
     status: not_started
@@ -406,11 +425,97 @@ tasks:
         ✅ Context inclusion toggle
         ✅ Integrated into server.ts and server-factory.ts
 
+  milestone_12:
+    - id: task-55
+      name: Add Comment Fields to Weaviate Schema
+      status: completed
+      file: agent/tasks/task-55-add-comment-fields-to-schema.md
+      estimated_hours: 2
+      completed_date: 2026-02-16
+      notes: |
+        ✅ Added 3 fields to Memory schema: parent_id, thread_root_id, moderation_flags
+        ✅ Added same fields to Memory_public collection
+        ✅ Enables infinite comment nesting
+        ✅ Per-space moderation support
+        ✅ Released in v2.6.0
+      
+    - id: task-56
+      name: Update remember_search_space for Comments
+      status: completed
+      file: agent/tasks/task-56-update-search-space-for-comments.md
+      estimated_hours: 2
+      completed_date: 2026-02-16
+      notes: |
+        ✅ Added include_comments parameter (default: false)
+        ✅ Comments excluded from search by default
+        ✅ Opt-in via include_comments: true
+        ✅ Backward compatible
+        ✅ Released in v2.6.0
+      
+    - id: task-57
+      name: Update remember_query_space for Comments
+      status: completed
+      file: agent/tasks/task-57-update-query-space-for-comments.md
+      estimated_hours: 1
+      completed_date: 2026-02-16
+      notes: |
+        ✅ Added include_comments parameter (default: false)
+        ✅ Same filtering logic as search_space
+        ✅ Backward compatible
+        ✅ Released in v2.6.0
+      
+    - id: task-58
+      name: Add Comment Unit Tests
+      status: not_started
+      file: agent/tasks/task-58-add-comment-unit-tests.md
+      estimated_hours: 3
+      notes: |
+        📋 Pending: Schema tests, filtering tests, edge cases
+        📋 Test infinite nesting support
+        📋 Test moderation flags
+      
+    - id: task-59
+      name: Update Documentation for Comments
+      status: not_started
+      file: agent/tasks/task-59-update-documentation-for-comments.md
+      estimated_hours: 2
+      notes: |
+        📋 Pending: README updates, CHANGELOG entry, examples
+        📋 Document comment creation workflow
+        📋 Add threading examples
+      
+    - id: task-60
+      name: Standardize Structured Logging
+      status: completed
+      file: agent/tasks/task-60-standardize-structured-logging.md
+      estimated_hours: 3
+      completed_date: 2026-02-16
+      notes: |
+        ✅ Replaced 54 console.log/error/warn calls with structured logger
+        ✅ Updated 8 files: confirmation-token.service, publish, confirm, deny, weaviate client/schema/space-schema, firestore init, config
+        ✅ All logs include context objects (service, module, tool names)
+        ✅ Fixed circular dependency in config.ts with dynamic import
+        ✅ Released in v2.6.1
+      
+    - id: task-61
+      name: Enhance Confirmation Tool Safety Guidelines
+      status: completed
+      file: agent/tasks/task-61-enhance-confirmation-tool-descriptions.md
+      estimated_hours: 1
+      completed_date: 2026-02-16
+      notes: |
+        ✅ Enhanced remember_confirm tool description with 5 critical safety requirements
+        ✅ Enhanced remember_deny tool description with same safety guidelines
+        ✅ Added JSDoc comments explaining proper workflow
+        ✅ Prevents agents from bypassing user consent
+        ✅ Visual indicators (⚠️) for critical requirements
+        ✅ Released in v2.6.2
+
 documentation:
   design_documents: 23
-  milestone_documents: 10
+  milestone_documents: 11
   pattern_documents: 5
-  task_documents: 33
+  task_documents: 61
 
 progress:
   planning: 100%
@@ -418,6 +523,33 @@ progress:
   overall: 50%
 
 recent_work:
+  - date: 2026-02-16
+    description: Comment System, Structured Logging, and Safety Guidelines (v2.6.0-v2.6.2)
+    items:
+      - 🎉 M12 STARTED: Comment System (Phase 1) - 60% complete (3/5 tasks)
+      - ✅ Task 55: Added 3 comment fields to Weaviate schema
+      - ✅ parent_id, thread_root_id, moderation_flags fields added
+      - ✅ Enables infinite comment nesting with no depth limit
+      - ✅ Per-space moderation flags support
+      - ✅ Task 56: Updated remember_search_space with include_comments parameter
+      - ✅ Comments excluded by default for clean discovery
+      - ✅ Opt-in via include_comments: true
+      - ✅ Task 57: Updated remember_query_space with include_comments parameter
+      - ✅ Same filtering logic as search_space
+      - ✅ Released v2.6.0 with comment system foundation
+      - ✅ Task 60: Standardized structured logging across 8 files
+      - ✅ Replaced 54 console.log/error/warn calls with logger.info/error/warn/debug
+      - ✅ All logs include context objects (service, module, tool names)
+      - ✅ Fixed circular dependency in config.ts with dynamic import
+      - ✅ Released v2.6.1 with structured logging
+      - ✅ Task 61: Enhanced confirmation tool safety guidelines
+      - ✅ Added 5 critical safety requirements to remember_confirm and remember_deny
+      - ✅ Prevents agents from chaining confirmations without user consent
+      - ✅ Visual indicators (⚠️) and JSDoc comments added
+      - ✅ Released v2.6.2 with safety enhancements
+      - 📋 Next: Complete M12 with Tasks 58-59 (tests + documentation)
+      - 📋 6 commits ready to push to origin
+      
   - date: 2026-02-16
     description: ACP Initialization Complete - Multi-Space Architecture Verified (v2.5.1)
     items:
@@ -743,18 +875,21 @@ recent_work:
       - ✅ Build successful
 
 next_steps:
-  - Deploy v2.5.1 to Cloud Run and verify multi-space functionality
-  - Test multi-space publishing workflow end-to-end
-  - Test multi-space search across multiple spaces
-  - Verify Firestore request creation with enhanced error handling
-  - Check Cloud Run logs for diagnostic output from ConfirmationTokenService
-  - Consider implementing comment system (v2.6.0) - 3 schema fields only!
+  - Complete Task 58: Add Comment Unit Tests (3 hours)
+  - Complete Task 59: Update Documentation for Comments (2 hours)
+  - Push 6 commits to origin (v2.6.0, v2.6.1, v2.6.2)
+  - Deploy v2.6.2 to Cloud Run
+  - Test comment system end-to-end (create, search, thread fetching)
+  - Test structured logging in Cloud Run logs
+  - Verify confirmation tool safety guidelines in production
+  - Complete M12: Comment System (Phase 1)
   - Start M5: Template System (15 default templates + auto-suggestion)
   - Optional: Create integration tests (Task 6)
   - Optional: Add development documentation (Task 7)
   - Consider M6: Auth & Multi-Tenancy
 
 notes:
+  - 🚀 Milestone 12 (Comment System Phase 1) IN PROGRESS - 60% complete!
   - 🎉 Milestone 11 (Unified Public Collection) COMPLETED!
   - 🎉 Milestone 10 (Shared Spaces & Confirmation Flow) COMPLETED!
   - 🎉 Milestone 4 (User Preferences) COMPLETED!
@@ -769,6 +904,10 @@ notes:
   - ✅ M4: 2/2 preference tools complete (100% progress)
   - ✅ M10: 10/10 shared space tools complete (100% progress)
   - ✅ M11: 9/9 multi-space architecture tasks complete (100% progress)
+  - 🚀 M12: 3/5 comment system tasks complete (60% progress)
+  - ✅ Comment system foundation implemented (v2.6.0)
+  - ✅ Structured logging standardized (v2.6.1)
+  - ✅ Confirmation tool safety enhanced (v2.6.2)
   - ✅ Complete memory CRUD operations (create, read, update, delete)
   - ✅ Complete relationship CRUD operations (create, read, update, delete)
   - ✅ Advanced search capabilities (hybrid, similarity, RAG queries)
@@ -833,8 +972,10 @@ build_status:
   - ✅ Source maps generated
   - ✅ Type definitions generated (.d.ts files)
   - ✅ Package exports configured for both entry points
-  - ✅ Version 2.0.1 published (patch release - error logging)
-  - ✅ 30 TypeScript source files (added error-handler.ts)
+  - ✅ Version 2.6.2 published (patch release - safety guidelines)
+  - ✅ Version 2.6.1 published (patch release - structured logging)
+  - ✅ Version 2.6.0 published (minor release - comment system)
+  - ✅ 30 TypeScript source files
   - ✅ All 12 tools implemented
   - ✅ Weaviate v3 filter API implemented
   - ✅ Or/And operator validation implemented
@@ -857,6 +998,12 @@ tools_status:
   preference_tools:
     - ✅ remember_set_preference (src/tools/set-preference.ts)
     - ✅ remember_get_preferences (src/tools/get-preferences.ts)
+  space_tools:
+    - ✅ remember_publish (src/tools/publish.ts) - Multi-space support
+    - ✅ remember_confirm (src/tools/confirm.ts) - Enhanced safety guidelines
+    - ✅ remember_deny (src/tools/deny.ts) - Enhanced safety guidelines
+    - ✅ remember_search_space (src/tools/search-space.ts) - Comment filtering
+    - ✅ remember_query_space (src/tools/query-space.ts) - Comment filtering
 
 implementation_notes:
   - All 12 core tools implemented and integrated
@@ -899,3 +1046,6 @@ task_20_completion:
   releases:
     - v1.0.0: Major release with breaking change (async createServer)
     - v1.0.1: Patch release with Or operator bug fix
+    - v2.6.0: Minor release with comment system foundation
+    - v2.6.1: Patch release with structured logging
+    - v2.6.2: Patch release with confirmation tool safety guidelines

package/agent/tasks/task-62-fix-confirmation-response-storage.md

@@ -0,0 +1,323 @@
+# Task 62: Fix Confirmation Response Storage
+
+**Milestone**: M12 (Comment System / Bug Fixes)
+**Estimated Time**: 2 hours
+**Dependencies**: None
+**Status**: Not Started
+**Priority**: High
+
+---
+
+## Objective
+
+Fix bug where `remember_confirm` executes actions successfully but doesn't store the response data in the Firestore confirmation record. This prevents agents and users from verifying action results and breaks the audit trail.
+
+---
+
+## Context
+
+**Current Behavior:**
+1. `remember_confirm` validates token and marks request as "confirmed"
+2. Action executes successfully (e.g., `executePublishMemory`)
+3. Response data (space_memory_id, etc.) is returned to agent
+4. **BUG**: Response data is NOT saved to Firestore
+5. Database record shows `status: confirmed` but no response/result data
+
+**Impact:**
+- ⚠️ Agents cannot verify publication success
+- ⚠️ No space_memory_id available for reference
+- ⚠️ Audit trail incomplete
+- ⚠️ Cannot track what happened after confirmation
+
+**Root Cause:**
+- `ConfirmationRequest` interface lacks `response` field
+- `confirmRequest()` method only updates status, not response
+- `executePublishMemory()` returns data but doesn't persist it
+
+---
+
+## Steps
+
+### 1. Update ConfirmationRequest Interface
+
+Add response field to store action results:
+
+```typescript
+// src/services/confirmation-token.service.ts
+
+export interface ConfirmationRequest {
+  user_id: string;
+  token: string;
+  action: string;
+  target_collection?: string;
+  payload: any;
+  created_at: string;
+  expires_at: string;
+  status: 'pending' | 'confirmed' | 'denied' | 'expired' | 'retracted';
+  confirmed_at?: string;
+  response?: any;  // ✅ ADD THIS - Stores action execution result
+}
+```
+
+### 2. Add storeResponse Method
+
+Create method to store response data after action execution:
+
+```typescript
+// src/services/confirmation-token.service.ts
+
+/**
+ * Store response data for a confirmed request
+ * 
+ * @param userId - User ID
+ * @param requestId - Request ID
+ * @param response - Response data from action execution
+ */
+async storeResponse(
+  userId: string,
+  requestId: string,
+  response: any
+): Promise<void> {
+  logger.info('Storing confirmation response', {
+    service: 'ConfirmationTokenService',
+    userId,
+    requestId,
+    hasResponse: !!response,
+  });
+
+  const docPath = `users/${userId}/requests/${requestId}`;
+  
+  await updateDocument(docPath, {
+    response,
+    updated_at: new Date().toISOString(),
+  });
+  
+  logger.info('Response stored successfully', {
+    service: 'ConfirmationTokenService',
+    requestId,
+  });
+}
+```
+
+### 3. Update handleConfirm to Store Response
+
+Modify `remember_confirm` to persist response data:
+
+```typescript
+// src/tools/confirm.ts
+
+export async function handleConfirm(
+  args: ConfirmArgs,
+  userId: string
+): Promise<string> {
+  try {
+    logger.info('Starting confirmation', {
+      tool: 'remember_confirm',
+      userId,
+      token: args.token,
+    });
+    
+    // Validate and confirm token
+    const request = await confirmationTokenService.confirmRequest(userId, args.token);
+    
+    if (!request) {
+      logger.info('Token invalid or expired', {
+        tool: 'remember_confirm',
+        userId,
+      });
+      return JSON.stringify({
+        success: false,
+        error: 'Invalid or expired token',
+        message: 'The confirmation token is invalid, expired, or has already been used.',
+      }, null, 2);
+    }
+
+    logger.info('Executing confirmed action', {
+      tool: 'remember_confirm',
+      action: request.action,
+      userId,
+    });
+
+    // Execute action based on type
+    let responseJson: string;
+    if (request.action === 'publish_memory') {
+      responseJson = await executePublishMemory(request, userId);
+    } else {
+      throw new Error(`Unknown action type: ${request.action}`);
+    }
+
+    // ✅ NEW: Parse and store response data
+    try {
+      const responseData = JSON.parse(responseJson);
+      
+      logger.info('Storing action response', {
+        tool: 'remember_confirm',
+        requestId: request.request_id,
+        success: responseData.success,
+      });
+      
+      await confirmationTokenService.storeResponse(
+        userId,
+        request.request_id,
+        responseData
+      );
+      
+      logger.info('Response stored successfully', {
+        tool: 'remember_confirm',
+        requestId: request.request_id,
+      });
+    } catch (parseError) {
+      logger.warn('Failed to parse/store response', {
+        tool: 'remember_confirm',
+        error: parseError instanceof Error ? parseError.message : String(parseError),
+      });
+      // Don't fail the whole operation if storage fails
+    }
+
+    // Return response to agent
+    return responseJson;
+  } catch (error) {
+    handleToolError(error, {
+      toolName: 'remember_confirm',
+      userId,
+      operation: 'confirm action',
+      token: args.token,
+    });
+  }
+}
+```
+
+### 4. Update Tests
+
+Add tests for response storage:
+
+```typescript
+// tests/unit/confirmation-token.service.test.ts
+
+describe('ConfirmationTokenService', () => {
+  describe('storeResponse', () => {
+    it('should store response data for confirmed request', async () => {
+      const service = new ConfirmationTokenService();
+      const userId = 'test-user';
+      const requestId = 'test-request';
+      const response = {
+        success: true,
+        space_memory_id: 'space-123',
+        spaces: ['the_void'],
+      };
+
+      await service.storeResponse(userId, requestId, response);
+
+      // Verify response was stored
+      const request = await getDocument(`users/${userId}/requests/${requestId}`);
+      expect(request.response).toEqual(response);
+      expect(request.updated_at).toBeDefined();
+    });
+  });
+});
+```
+
+### 5. Update Documentation
+
+Document the response field in design docs:
+
+```markdown
+# agent/design/publish-tools-confirmation-flow.md
+
+## Confirmation Record Structure
+
+After confirmation, the record includes:
+- `status`: 'confirmed'
+- `confirmed_at`: ISO timestamp
+- `response`: Action execution result (NEW)
+  - For publish_memory: { success, space_memory_id, spaces }
+  - For other actions: Action-specific response data
+```
+
+---
+
+## Verification
+
+- [ ] ConfirmationRequest interface has `response?: any` field
+- [ ] `storeResponse()` method exists in ConfirmationTokenService
+- [ ] `handleConfirm` calls `storeResponse()` after action execution
+- [ ] Response data is persisted to Firestore
+- [ ] Agent receives response data in tool output
+- [ ] Database record contains response field after confirmation
+- [ ] Tests pass for response storage
+- [ ] TypeScript compiles without errors
+- [ ] Build successful
+- [ ] Manual test: Publish memory and verify response in Firestore
+
+---
+
+## Expected Output
+
+**Before Fix:**
+```json
+{
+  "status": "confirmed",
+  "confirmed_at": "2026-02-16T21:44:39.154Z",
+  "action": "publish_memory",
+  "payload": { "memory_id": "...", "spaces": ["the_void"] }
+  // ❌ No response field
+}
+```
+
+**After Fix:**
+```json
+{
+  "status": "confirmed",
+  "confirmed_at": "2026-02-16T21:44:39.154Z",
+  "action": "publish_memory",
+  "payload": { "memory_id": "...", "spaces": ["the_void"] },
+  "response": {
+    "success": true,
+    "space_memory_id": "9b536938-1188-4e69-b3cd-4362d84fff1c",
+    "spaces": ["the_void"]
+  }
+}
+```
+
+---
+
+## Common Issues and Solutions
+
+### Issue 1: Response not storing
+
+**Cause**: Parse error or Firestore write failure
+**Solution**: Check logs for errors, verify Firestore permissions
+
+### Issue 2: Response field undefined
+
+**Cause**: Old records don't have response field
+**Solution**: This is expected - only new confirmations will have response
+
+### Issue 3: Response too large for Firestore
+
+**Cause**: Response data exceeds Firestore document size limit (1MB)
+**Solution**: Store only essential fields (space_memory_id, success, spaces)
+
+---
+
+## Resources
+
+- [Firestore Document Limits](https://firebase.google.com/docs/firestore/quotas)
+- [ConfirmationTokenService](../src/services/confirmation-token.service.ts)
+- [remember_confirm Tool](../src/tools/confirm.ts)
+- [Confirmation Flow Design](../design/publish-tools-confirmation-flow.md)
+
+---
+
+## Notes
+
+- This is a backward-compatible change - old records without response field will continue to work
+- Response storage is best-effort - if it fails, the action still succeeds
+- Response data is primarily for audit trail and debugging
+- Agents receive response data regardless of storage success
+- Consider adding response field to remember_deny as well (for consistency)
+
+---
+
+**Status**: Not Started
+**Recommendation**: Implement this fix before completing M12 to ensure proper audit trail