@prmichaelsen/remember-mcp 2.5.1 → 2.6.1

package/CHANGELOG.md

@@ -5,6 +5,101 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.6.1] - 2026-02-16
+
+### 🔧 Improved
+
+- **Standardized Structured Logging**: Replaced all direct console calls with structured logger
+  - Replaced 54 console.log/error/warn calls across 8 files
+  - All logs now use structured JSON format with proper severity levels
+  - Logs respect LOG_LEVEL environment variable for filtering
+  - Better Cloud Run log aggregation and filtering
+  - Consistent context objects with relevant identifiers
+
+### 📝 Changed
+
+- Updated files with structured logging:
+  - `src/services/confirmation-token.service.ts` - 11 console calls replaced
+  - `src/tools/publish.ts` - 7 console calls replaced
+  - `src/tools/confirm.ts` - 11 console calls replaced
+  - `src/weaviate/client.ts` - 7 console calls replaced
+  - `src/weaviate/schema.ts` - 4 console calls replaced
+  - `src/weaviate/space-schema.ts` - 2 console calls replaced
+  - `src/firestore/init.ts` - 6 console calls replaced
+  - `src/config.ts` - 1 console call replaced
+
+### 🎯 Benefits
+
+- Log level filtering now works correctly (debug/info/warn/error)
+- Structured JSON logs for cloud environments
+- Consistent formatting across all services
+- Better integration with Cloud Logging filters
+- Easier to search and filter logs in production
+
+---
+
+## [2.6.0] - 2026-02-16
+
+### ✨ Added
+
+- **Comment System (Phase 1)**: Threaded discussions in shared spaces
+  - Added 3 schema fields: `parent_id`, `thread_root_id`, `moderation_flags`
+  - Comments support infinite nesting (no depth limit)
+  - Per-space moderation flags (format: `"{space_id}:{flag_type}"`)
+  - Zero new tools required - reuses existing `remember_create_memory`
+
+- **Comment Filtering**: Clean discovery experience
+  - Added `include_comments` parameter to `remember_search_space` (default: false)
+  - Added `include_comments` parameter to `remember_query_space` (default: false)
+  - Comments excluded from search by default for cleaner results
+  - Opt-in via `include_comments: true` to include discussions
+
+### 🔧 Changed
+
+- **Search behavior**: `remember_search_space` now excludes comments by default
+- **Query behavior**: `remember_query_space` now excludes comments by default
+- Tool descriptions updated to mention comment filtering
+
+### 📚 Documentation
+
+- Created Milestone 12: Comment System (Phase 1)
+- Created Tasks 55-59 for comment implementation
+- Updated design document with comment system architecture
+
+### 🎯 Usage
+
+```typescript
+// Create a comment
+remember_create_memory({
+  type: "comment",
+  content: "Great post!",
+  parent_id: "memory123",
+  thread_root_id: "memory123",
+  spaces: ["the_void"]
+})
+
+// Search without comments (default)
+remember_search_space({
+  spaces: ["the_void"],
+  query: "hiking"
+})
+
+// Search with comments (opt-in)
+remember_search_space({
+  spaces: ["the_void"],
+  query: "hiking",
+  include_comments: true
+})
+```
+
+### ⚠️ Notes
+
+- Backward compatible - no breaking changes
+- Comments are opt-in for search/query
+- Future phases will add voting, moderation tools, and notifications
+
+---
+
 ## [2.4.1] - 2026-02-16
 
 ### 🐛 Fixed

package/agent/milestones/milestone-12-comment-system.md

@@ -0,0 +1,239 @@
+# Milestone 12: Comment System (Phase 1 - Basic Comments)
+
+**Goal**: Enable threaded discussions in shared spaces using existing content type
+**Duration**: 1 week
+**Dependencies**: M11 (Unified Public Collection)
+**Status**: Not Started
+
+---
+
+## Overview
+
+Implement basic comment functionality for shared spaces using the existing `comment` content type. This milestone requires **zero new tools** - we'll extend the Weaviate schema with 3 new fields and add an `include_comments` parameter to existing search tools.
+
+**Key Innovation**: Reuse `remember_create_memory` with `type: "comment"` instead of creating new tools. This keeps the API surface small while enabling rich threaded discussions.
+
+---
+
+## Deliverables
+
+### 1. Schema Updates (3 new fields)
+- Add `parent_id` field (text) - ID of parent memory or comment
+- Add `thread_root_id` field (text) - Root memory ID for thread queries
+- Add `moderation_flags` field (text[]) - Per-space moderation flags
+
+### 2. Search Tool Updates (2 tools)
+- Update `remember_search_space` - Add `include_comments` parameter (default: false)
+- Update `remember_query_space` - Add `include_comments` parameter (default: false)
+
+### 3. Documentation Updates
+- Update design document with implementation details
+- Add comment examples to README
+- Document comment creation workflow
+- Add API examples for threaded discussions
+
+### 4. Testing
+- Unit tests for comment filtering
+- Unit tests for thread queries
+- Integration tests for comment workflows
+- Test infinite nesting support
+
+---
+
+## Success Criteria
+
+- [ ] Schema has 3 new fields: `parent_id`, `thread_root_id`, `moderation_flags`
+- [ ] Can create comments using `remember_create_memory` with `type: "comment"`
+- [ ] Comments have `parent_id` and `thread_root_id` populated
+- [ ] `remember_search_space` excludes comments by default
+- [ ] `remember_search_space` includes comments when `include_comments: true`
+- [ ] `remember_query_space` excludes comments by default
+- [ ] `remember_query_space` includes comments when `include_comments: true`
+- [ ] Can fetch entire thread by filtering on `thread_root_id`
+- [ ] Comments support infinite nesting (no depth limit)
+- [ ] Moderation flags are per-space (array field)
+- [ ] All existing tests still passing
+- [ ] New comment tests passing
+- [ ] TypeScript compiles without errors
+- [ ] Build successful
+- [ ] Documentation updated with examples
+
+---
+
+## Key Files to Modify
+
+```
+src/
+├── weaviate/
+│   ├── schema.ts                    # Add 3 new fields to schema
+│   └── space-schema.ts              # Add 3 new fields to public collection
+└── tools/
+    ├── search-space.ts              # Add include_comments parameter
+    └── query-space.ts               # Add include_comments parameter
+
+tests/
+└── unit/
+    ├── schema.test.ts               # Test new fields
+    ├── space-schema.test.ts         # Test new fields in public collection
+    ├── search-space.test.ts         # Test comment filtering
+    └── query-space.test.ts          # Test comment filtering
+
+agent/
+└── design/
+    └── comment-memory-type.md       # Update with implementation notes
+```
+
+---
+
+## Implementation Tasks
+
+See individual task documents:
+- Task 55: Add Comment Fields to Weaviate Schema
+- Task 56: Update remember_search_space for Comments
+- Task 57: Update remember_query_space for Comments
+- Task 58: Add Comment Unit Tests
+- Task 59: Update Documentation for Comments
+
+---
+
+## Architecture Notes
+
+### Zero New Tools Required
+
+**Create comment** (use existing tool):
+```typescript
+remember_create_memory({
+  type: "comment",              // ✅ Existing content type!
+  content: "Great post!",
+  parent_id: "memory123",       // ✅ New field
+  thread_root_id: "memory123",  // ✅ New field
+  spaces: ["the_void"]          // ✅ Inherited from parent
+})
+```
+
+**Fetch thread** (use existing search):
+```typescript
+remember_search_space({
+  spaces: ["the_void"],
+  query: "",
+  content_type: "comment",
+  // Filter by thread_root_id in Weaviate
+  limit: 100
+})
+```
+
+**Search without comments** (default behavior):
+```typescript
+remember_search_space({
+  spaces: ["the_void"],
+  query: "hiking trails"
+  // include_comments: false (default)
+})
+// Returns only memories, not comments
+```
+
+**Search with comments** (opt-in):
+```typescript
+remember_search_space({
+  spaces: ["the_void"],
+  query: "hiking trails",
+  include_comments: true  // ✅ Include comments in results
+})
+// Returns memories + comments
+```
+
+### Schema Changes
+
+**New Fields**:
+```typescript
+{
+  name: 'parent_id',
+  dataType: 'text' as any,
+  description: 'ID of parent memory or comment (for threading)'
+},
+{
+  name: 'thread_root_id',
+  dataType: 'text' as any,
+  description: 'Root memory ID for fetching entire thread'
+},
+{
+  name: 'moderation_flags',
+  dataType: 'text[]' as any,
+  description: 'Per-space moderation flags (e.g., ["the_void:hidden", "dogs:spam"])'
+}
+```
+
+### Moderation Flags (Per-Space)
+
+**Format**: `"{space_id}:{flag_type}"`
+
+**Examples**:
+- `"the_void:hidden"` - Hidden in The Void space
+- `"dogs:spam"` - Marked as spam in Dogs space
+- `"cats:flagged"` - Flagged for review in Cats space
+
+**Why per-space?**: A comment might be inappropriate in one space but fine in another. Moderators manage their own spaces independently.
+
+### Infinite Nesting Support
+
+**No depth limit**: Comments can nest infinitely
+- `parent_id` points to immediate parent
+- `thread_root_id` always points to root memory
+- UI builds tree structure from flat list
+
+**Example**:
+```
+Memory (root)
+├─ Comment 1 (parent_id: memory_id)
+│  ├─ Comment 2 (parent_id: comment1_id)
+│  │  └─ Comment 3 (parent_id: comment2_id)
+│  │     └─ Comment 4 (parent_id: comment3_id)
+│  │        └─ ... (infinite nesting)
+│  └─ Comment 5 (parent_id: comment1_id)
+└─ Comment 6 (parent_id: memory_id)
+```
+
+All comments have `thread_root_id: memory_id` for efficient thread fetching.
+
+---
+
+## Testing Strategy
+
+1. **Unit Tests**: Schema fields, filtering logic
+2. **Integration Tests**: Full comment workflow
+3. **Performance Tests**: Large threads (1000+ comments)
+4. **Edge Cases**: Infinite nesting, moderation flags
+
+---
+
+## Future Phases
+
+**Phase 2: Engagement (v2.7.0)** - Deferred
+- Voting system (requires ACL)
+- Sort by popularity
+- Vote tracking in Firestore
+
+**Phase 3: Moderation (v2.8.0)** - Deferred
+- Moderator tools (requires ACL)
+- Auto-hide spam
+- Moderator dashboard
+
+**Phase 4: Notifications (v2.9.0)** - Deferred
+- Notify authors of comments
+- Email/push notifications
+- Notification preferences
+
+---
+
+## Breaking Changes
+
+**None** - This is a backward-compatible addition:
+- Existing tools continue to work unchanged
+- New fields are optional
+- Default behavior (exclude comments) maintains current UX
+- Opt-in via `include_comments: true`
+
+---
+
+**Next Milestone**: M13 - Comment Engagement (Voting & Popularity)
+**Blockers**: None (builds on M11)

package/agent/progress.yaml

@@ -2,10 +2,10 @@
 
 project:
   name: remember-mcp
-  version: 2.3.0
+  version: 2.5.1
   started: 2026-02-11
   status: in_progress
-  current_milestone: M5
+  current_milestone: M11
   last_updated: 2026-02-16
 
 milestones:
@@ -125,16 +125,43 @@ milestones:
     
   - id: M10
     name: Shared Spaces & Confirmation Flow
-    status: not_started
-    progress: 0%
+    status: completed
+    progress: 100%
+    started: 2026-02-16
+    completed: 2026-02-16
     estimated_weeks: 2-3
-    tasks_completed: 0
+    tasks_completed: 10
     tasks_total: 10
     notes: |
-      Token-based confirmation pattern for secure publishing
-      5 new MCP tools for shared spaces
-      Space collections with snake_case naming
-      Firestore TTL for automatic token cleanup
+      ✅ Token-based confirmation pattern implemented
+      ✅ 5 new MCP tools for shared spaces (publish, confirm, deny, search_space, query_space)
+      ✅ Space collections with snake_case naming (Memory_the_void)
+      ✅ Firestore TTL configured for automatic token cleanup
+      ✅ Confirmation token service with 5-minute expiry
+      ✅ Space memory types and schema complete
+      ✅ All tools integrated into server.ts and server-factory.ts
+      ✅ Unit tests passing for all components
+      
+  - id: M11
+    name: Unified Public Collection
+    status: completed
+    progress: 100%
+    started: 2026-02-16
+    completed: 2026-02-16
+    estimated_weeks: 1-2
+    tasks_completed: 9
+    tasks_total: 9
+    notes: |
+      ✅ Multi-space architecture implemented (v2.4.0)
+      ✅ SpaceMemory type updated: space_id → spaces array
+      ✅ Memory_public unified collection created
+      ✅ remember_publish supports spaces array parameter
+      ✅ remember_search_space supports multi-space queries
+      ✅ remember_query_space supports multi-space RAG
+      ✅ Weaviate containsAny filter for array fields
+      ✅ No memory duplication across spaces
+      ✅ All tests passing with multi-space support
+      ✅ Documentation updated with multi-space examples
     
   - id: M7
     name: Trust & Permissions
@@ -391,6 +418,41 @@ progress:
   overall: 50%
 
 recent_work:
+  - date: 2026-02-16
+    description: ACP Initialization Complete - Multi-Space Architecture Verified (v2.5.1)
+    items:
+      - ✅ ACP initialization workflow executed via @acp.init command
+      - ✅ AGENT.md confirmed up-to-date (v1.0.3)
+      - ✅ All agent documentation reviewed (29 design docs, 11 milestones, 54 tasks, 5 patterns)
+      - ✅ Project status verified: M1-M4, M10-M11 complete (100%)
+      - ✅ Version 2.5.1 confirmed (latest release with error handling fix)
+      - ✅ All unit tests passing
+      - ✅ TypeScript compiles without errors
+      - ✅ Build successful (dual export: server + factory)
+      - ✅ All 17 MCP tools implemented and working
+      - 🎉 M10 COMPLETED: Shared Spaces & Confirmation Flow
+      - ✅ Token-based confirmation system operational
+      - ✅ 5 space tools: publish, confirm, deny, search_space, query_space
+      - ✅ Confirmation token service with 5-minute expiry and comprehensive error handling
+      - ✅ Firestore request validation and diagnostic logging
+      - 🎉 M11 COMPLETED: Unified Public Collection Architecture
+      - ✅ Multi-space architecture implemented (spaces: string[] array)
+      - ✅ Memory_public unified collection replaces per-space collections
+      - ✅ Multi-space search with containsAny filter
+      - ✅ No memory duplication across spaces
+      - ✅ remember_publish supports publishing to multiple spaces
+      - ✅ remember_search_space supports multi-space queries
+      - ✅ remember_query_space supports multi-space RAG
+      - ✅ All tests updated for multi-space support
+      - ✅ Documentation updated with multi-space examples
+      - ✅ Multi-tenant architecture with per-user isolation
+      - ✅ Vector search with Weaviate + metadata with Firestore
+      - ✅ 45 content types with dynamic descriptions
+      - ✅ N-way relationships with bidirectional tracking
+      - ✅ User preferences system (6 categories)
+      - 📋 Ready for deployment testing and verification
+      - 📋 Next: Deploy v2.5.1 and test multi-space functionality
+      
   - date: 2026-02-16
     description: ACP Initialization Complete - Project Status Verified
     items:
@@ -681,27 +743,32 @@ recent_work:
       - ✅ Build successful
 
 next_steps:
-  - ✅ Task 20 completed - Weaviate v3 filters fixed!
-  - Test search operations with actual Weaviate instance to verify filter fix works in production
+  - Deploy v2.5.1 to Cloud Run and verify multi-space functionality
+  - Test multi-space publishing workflow end-to-end
+  - Test multi-space search across multiple spaces
+  - Verify Firestore request creation with enhanced error handling
+  - Check Cloud Run logs for diagnostic output from ConfirmationTokenService
+  - Consider implementing comment system (v2.6.0) - 3 schema fields only!
   - Start M5: Template System (15 default templates + auto-suggestion)
-  - Test complete memory + relationship + preferences system with actual Weaviate instance
-  - Consider implementing template auto-suggestion
-  - Optional: Update find-similar.ts and search-relationship.ts with v3 filters (currently working)
   - Optional: Create integration tests (Task 6)
   - Optional: Add development documentation (Task 7)
   - Consider M6: Auth & Multi-Tenancy
 
 notes:
+  - 🎉 Milestone 11 (Unified Public Collection) COMPLETED!
+  - 🎉 Milestone 10 (Shared Spaces & Confirmation Flow) COMPLETED!
   - 🎉 Milestone 4 (User Preferences) COMPLETED!
   - 🎉 Milestone 3 (Relationships & Graph) COMPLETED!
   - 🎉 Milestone 2 (Core Memory System) COMPLETED!
   - 🎉 Milestone 1 (Project Foundation) COMPLETED!
-  - ✅ All 23 design documents complete and comprehensive
-  - ✅ All 9 milestones defined with clear deliverables
+  - ✅ All 29 design documents complete and comprehensive
+  - ✅ All 11 milestones defined with clear deliverables
   - ✅ M1: 7 tasks complete (Tasks 1-5, 9 complete; Tasks 6-7 deferred)
   - ✅ M2: 6/6 memory tools complete (100% progress)
   - ✅ M3: 4/4 relationship tools complete (100% progress)
   - ✅ M4: 2/2 preference tools complete (100% progress)
+  - ✅ M10: 10/10 shared space tools complete (100% progress)
+  - ✅ M11: 9/9 multi-space architecture tasks complete (100% progress)
   - ✅ Complete memory CRUD operations (create, read, update, delete)
   - ✅ Complete relationship CRUD operations (create, read, update, delete)
   - ✅ Advanced search capabilities (hybrid, similarity, RAG queries)

package/agent/tasks/task-55-add-comment-fields-to-schema.md

@@ -0,0 +1,171 @@
+# Task 55: Add Comment Fields to Weaviate Schema
+
+**Milestone**: M12 (Comment System - Phase 1)
+**Estimated Time**: 2 hours
+**Dependencies**: M11 (Unified Public Collection)
+**Status**: Not Started
+
+---
+
+## Objective
+
+Add 3 new fields to the Weaviate schema to support threaded comments: `parent_id`, `thread_root_id`, and `moderation_flags`. These fields enable infinite nesting, efficient thread queries, and per-space moderation.
+
+---
+
+## Steps
+
+### 1. Update Memory Schema ([`src/weaviate/schema.ts`](../../src/weaviate/schema.ts))
+
+Add 3 new properties to the Memory collection schema:
+
+```typescript
+{
+  name: 'parent_id',
+  dataType: 'text' as any,
+  description: 'ID of parent memory or comment (for threading)',
+},
+{
+  name: 'thread_root_id',
+  dataType: 'text' as any,
+  description: 'Root memory ID for fetching entire thread',
+},
+{
+  name: 'moderation_flags',
+  dataType: 'text[]' as any,
+  description: 'Per-space moderation flags (format: "{space_id}:{flag_type}")',
+}
+```
+
+**Location**: Add after existing properties, before the closing bracket
+
+### 2. Update Space Schema ([`src/weaviate/space-schema.ts`](../../src/weaviate/space-schema.ts))
+
+Add the same 3 properties to the public collection schema:
+
+```typescript
+{
+  name: 'parent_id',
+  dataType: 'text' as any,
+  description: 'ID of parent memory or comment (for threading)',
+},
+{
+  name: 'thread_root_id',
+  dataType: 'text' as any,
+  description: 'Root memory ID for fetching entire thread',
+},
+{
+  name: 'moderation_flags',
+  dataType: 'text[]' as any,
+  description: 'Per-space moderation flags (format: "{space_id}:{flag_type}")',
+}
+```
+
+**Location**: Add to `createSpaceCollection` function's properties array
+
+### 3. Verify Schema Updates
+
+**Check**:
+- Both schemas have all 3 new fields
+- Field names match exactly
+- Data types are correct (`text` for IDs, `text[]` for flags)
+- Descriptions are clear and consistent
+
+### 4. Test Schema Creation
+
+Run existing tests to ensure schema creation still works:
+
+```bash
+npm test -- schema.test.ts
+npm test -- space-schema.test.ts
+```
+
+**Expected**: All existing tests pass, no errors
+
+---
+
+## Verification
+
+- [ ] `parent_id` field added to both schemas
+- [ ] `thread_root_id` field added to both schemas
+- [ ] `moderation_flags` field added to both schemas
+- [ ] Field data types are correct
+- [ ] Descriptions are clear
+- [ ] TypeScript compiles without errors
+- [ ] All existing schema tests passing
+- [ ] No breaking changes to existing functionality
+
+---
+
+## Implementation Notes
+
+### Field Purposes
+
+**`parent_id`**:
+- Points to immediate parent (memory or comment)
+- Enables infinite nesting
+- Used by UI to build tree structure
+- Optional (null for root memories)
+
+**`thread_root_id`**:
+- Always points to root memory
+- Enables efficient "get all comments in thread" queries
+- Same as `parent_id` for direct replies to memories
+- Optional (null for root memories)
+
+**`moderation_flags`**:
+- Array of strings in format `"{space_id}:{flag_type}"`
+- Enables per-space moderation
+- Examples: `["the_void:hidden", "dogs:spam"]`
+- Empty array by default
+
+### Example Comment
+
+```typescript
+{
+  id: "comment123",
+  type: "comment",
+  content: "Great post!",
+  parent_id: "memory456",        // ✅ New field
+  thread_root_id: "memory456",   // ✅ New field
+  moderation_flags: [],          // ✅ New field
+  spaces: ["the_void"],
+  author_id: "user789",
+  // ... other standard fields
+}
+```
+
+### Example Nested Comment
+
+```typescript
+{
+  id: "comment789",
+  type: "comment",
+  content: "I agree!",
+  parent_id: "comment123",       // ✅ Points to parent comment
+  thread_root_id: "memory456",   // ✅ Still points to root memory
+  moderation_flags: [],
+  spaces: ["the_void"],
+  author_id: "user999",
+  // ... other standard fields
+}
+```
+
+---
+
+## Files Modified
+
+- [`src/weaviate/schema.ts`](../../src/weaviate/schema.ts) - Add 3 fields to Memory schema
+- [`src/weaviate/space-schema.ts`](../../src/weaviate/space-schema.ts) - Add 3 fields to public collection
+
+---
+
+## Files Created
+
+None (schema updates only)
+
+---
+
+## Next Task
+
+Task 56: Update remember_search_space for Comments