@prmichaelsen/remember-mcp 2.5.0 → 2.5.1

package/agent/scripts/update.sh

@@ -5,24 +5,34 @@
 
 set -e
 
-# Colors for output
-RED='\033[0;31m'
-GREEN='\033[0;32m'
-YELLOW='\033[1;33m'
-BLUE='\033[0;34m'
-NC='\033[0m' # No Color
+# Colors for output using tput (more reliable than ANSI codes)
+if command -v tput >/dev/null 2>&1 && [ -t 1 ]; then
+    RED=$(tput setaf 1)
+    GREEN=$(tput setaf 2)
+    YELLOW=$(tput setaf 3)
+    BLUE=$(tput setaf 4)
+    BOLD=$(tput bold)
+    NC=$(tput sgr0)
+else
+    RED=''
+    GREEN=''
+    YELLOW=''
+    BLUE=''
+    BOLD=''
+    NC=''
+fi
 
 # Repository details
 REPO_URL="https://github.com/prmichaelsen/agent-context-protocol.git"
 BRANCH="mainline"
 
-echo -e "${BLUE}Agent Context Protocol (ACP) Updater${NC}"
+echo "${BLUE}Agent Context Protocol (ACP) Updater${NC}"
 echo "======================================"
 echo ""
 
 # Check if AGENT.md exists
 if [ ! -f "AGENT.md" ]; then
-    echo -e "${RED}Error: AGENT.md not found in current directory${NC}"
+    echo "${RED}Error: AGENT.md not found in current directory${NC}"
     echo "This script should be run from your project root where AGENT.md is located."
     exit 1
 fi
@@ -33,12 +43,12 @@ trap "rm -rf $TEMP_DIR" EXIT
 
 echo "Fetching latest ACP files..."
 if ! git clone --depth 1 --branch "$BRANCH" "$REPO_URL" "$TEMP_DIR" &>/dev/null; then
-    echo -e "${RED}Error: Failed to fetch repository${NC}"
+    echo "${RED}Error: Failed to fetch repository${NC}"
     echo "Please check your internet connection and try again."
     exit 1
 fi
 
-echo -e "${GREEN}✓${NC} Latest files fetched"
+echo "${GREEN}✓${NC} Latest files fetched"
 echo ""
 
 # Ensure reports directory exists and is ignored
@@ -52,7 +62,7 @@ if [ ! -f "agent/.gitignore" ]; then
 # Reports directory - generated by @acp.report command
 reports/
 EOF
-    echo -e "${GREEN}✓${NC} Created agent/.gitignore"
+    echo "${GREEN}✓${NC} Created agent/.gitignore"
 fi
 
 echo "Updating ACP files..."
@@ -87,17 +97,17 @@ cp "$TEMP_DIR/agent/scripts/version.sh" "agent/scripts/"
 cp "$TEMP_DIR/agent/scripts/install.sh" "agent/scripts/"
 chmod +x agent/scripts/*.sh
 
-echo -e "${GREEN}✓${NC} All files updated"
+echo "${GREEN}✓${NC} All files updated"
 echo ""
-echo -e "${GREEN}Update complete!${NC}"
+echo "${GREEN}Update complete!${NC}"
 echo ""
-echo -e "${BLUE}What was updated:${NC}"
+echo "${BLUE}What was updated:${NC}"
 echo "  ✓ AGENT.md (methodology documentation)"
 echo "  ✓ Template files (design, milestone, task, pattern)"
 echo "  ✓ Command files (all ACP commands)"
 echo "  ✓ Utility scripts (update, check-for-updates, version, etc.)"
 echo ""
-echo -e "${BLUE}Next steps:${NC}"
+echo "${BLUE}Next steps:${NC}"
 echo "1. Review changes: git diff"
 echo "2. See what changed: git status"
 echo "3. Revert if needed: git checkout <file>"
@@ -105,7 +115,7 @@ echo ""
 echo "For detailed changelog:"
 echo "  https://github.com/prmichaelsen/agent-context-protocol/blob/mainline/CHANGELOG.md"
 echo ""
-echo -e "${BLUE}ACP Commands Available:${NC}"
+echo "${BLUE}ACP Commands Available:${NC}"
 echo ""
 echo "  ${GREEN}@acp.init${NC}                    - Initialize agent context (run after update!)"
 echo "  ${GREEN}@acp.proceed${NC}                 - Continue with next task"
@@ -119,6 +129,11 @@ echo "  ${GREEN}@acp.version-check-for-updates${NC} - Check for ACP updates"
 echo "  ${GREEN}@acp.version-update${NC}          - Update ACP to latest version"
 echo "  ${GREEN}@acp.package-install${NC}         - Install third-party command packages"
 echo ""
-echo -e "${BLUE}For AI agents:${NC}"
+echo "${BLUE}Git Commands Available:${NC}"
+echo ""
+echo "  ${GREEN}@git.init${NC}                    - Initialize git repository with smart .gitignore"
+echo "  ${GREEN}@git.commit${NC}                  - Intelligent version-aware git commit"
+echo ""
+echo "${BLUE}For AI agents:${NC}"
 echo "Type '${GREEN}@acp.init${NC}' to reload context with updated files."
 echo ""

package/agent/tasks/task-45-fix-publish-false-success-bug.md

@@ -1,230 +1,163 @@
-# Task 45: Fix remember_publish False Success Bug
+# Task 45: Fix Publish False Success Bug
 
-**Milestone**: M10 - Shared Spaces & Confirmation Flow (Bug Fix)
-**Estimated Time**: 2 hours
-**Dependencies**: M10 (Tasks 34-40)
+**Milestone**: M10 - Shared Spaces & Confirmation Flow
+**Estimated Time**: 1 hour
+**Dependencies**: None
 **Status**: Not Started
-**Priority**: HIGH - Critical bug, false positive
+**Priority**: CRITICAL
 
 ---
 
 ## Objective
 
-Fix the `remember_publish` and `remember_confirm` tools which report `success: true` but do not actually publish memories to The Void. The operation is completely non-functional - no write occurs, no duplication, no error thrown.
+Fix critical bug where `remember_publish` reports success even when Firestore request creation fails. The issue is a missing `return` statement in the error handler, causing the function to return `undefined` instead of an error response.
 
 ---
 
 ## Problem Statement
 
-### Symptoms
-- `remember_confirm` returns `success: true`
-- Database shows `Memory_the_void` collection has 0 objects
-- Memory only exists in personal collection (not copied)
-- No error is thrown
-- False positive misleads users and agents
+### Observed Behavior
 
-### Impact
-- Core feature completely non-functional
-- False success responses worse than errors (misleading)
-- Breaks agent reliability and user trust
-- No workaround available
+1. User calls `remember_publish`
+2. Token service tries to create request in Firestore
+3. Firestore operation fails (permissions, network, etc.)
+4. Error is caught but NOT returned
+5. Function returns `undefined`
+6. MCP interprets `undefined` as success
+7. User calls `remember_confirm` with token
+8. Token validation fails (no request exists)
+9. But user already thinks publish succeeded
 
----
-
-## Steps
-
-### 1. Verify Collection Exists
-
-Check if `Memory_the_void` collection exists in Weaviate.
-
-**Actions**:
-- Query Weaviate for collection list
-- Check if `Memory_the_void` exists
-- Verify collection schema if it exists
-- Check write permissions
-
-**Expected Outcome**: Collection status determined
-
-### 2. Review executePublishMemory Function
-
-Examine the publish execution logic in confirm.ts.
-
-**Actions**:
-- Open [`src/tools/confirm.ts`](../../src/tools/confirm.ts)
-- Review `executePublishMemory` function
-- Check if `targetCollection.data.insert()` is called
-- Verify result is returned correctly
-- Check error handling
-
-**Expected Outcome**: Code logic understood
-
-### 3. Add Debug Logging
+### Root Cause
 
-Add logging to track execution flow.
+**File**: `src/tools/publish.ts` line 203-210
 
-**Actions**:
-- Add log before collection fetch
-- Add log before memory fetch
-- Add log before insert operation
-- Add log after insert with result
-- Log any caught errors
-
-**Expected Outcome**: Execution flow visible
-
-### 4. Test Locally
-
-Run publish workflow with logging enabled.
-
-**Actions**:
-- Create test memory
-- Call remember_publish
-- Call remember_confirm with token
-- Check logs for execution flow
-- Verify if insert is called
-- Check Weaviate for result
-
-**Expected Outcome**: Root cause identified
-
-### 5. Fix the Bug
-
-Implement the fix based on root cause.
-
-**Possible Fixes**:
-- **If collection doesn't exist**: Ensure `ensureSpaceCollection()` creates it
-- **If insert not called**: Fix logic flow to reach insert
-- **If insert fails silently**: Add proper error handling
-- **If permissions issue**: Fix Weaviate configuration
-- **If wrong collection**: Fix collection name generation
-
-**Expected Outcome**: Bug fixed
-
-### 6. Verify Fix
+```typescript
+} catch (error) {
+  return handleToolError(error, {  // ✅ HAS return (fixed in v2.3.3)
+    toolName: 'remember_publish',
+    userId,
+    operation: 'publish memory',
+    memory_id: args.memory_id,
+    spaces: args.spaces,
+  });
+}
+```
 
-Test that publish actually works.
+**Status**: Actually this WAS fixed in v2.3.3! Let me check if there are other places...
 
-**Actions**:
-- Create test memory
-- Publish to The Void
-- Confirm publication
-- Query `Memory_the_void` collection
-- Verify memory exists in space
-- Verify original memory unchanged
-- Test search_space finds it
+### Additional Investigation Needed
 
-**Expected Outcome**: Publish works correctly
+1. **Check if `addDocument` is failing silently**
+   - Add try-catch in `confirmationTokenService.createRequest`
+   - Log success/failure explicitly
+   - Return error if Firestore operation fails
 
-### 7. Add Integration Test
+2. **Check Firebase Admin SDK initialization**
+   - Verify service account has Firestore permissions
+   - Check if initialization succeeds
+   - Log initialization status
 
-Create test for full publish workflow.
+3. **Check Firestore collection creation**
+   - Verify `users/{userId}/requests` collection can be created
+   - Check if parent document `users/{userId}` needs to exist first
+   - Test with actual Firebase project
 
-**Actions**:
-- Create integration test file
-- Test: create → publish → confirm → verify in space
-- Test: search_space finds published memory
-- Test: original memory still in personal collection
-- Requires live Weaviate instance
+---
 
-**Expected Outcome**: Integration test passing
+## Solution
 
-### 8. Update Error Handling
+### Step 1: Add Error Handling in Token Service
 
-Ensure errors are caught and reported.
+**File**: `src/services/confirmation-token.service.ts`
 
-**Actions**:
-- Add try-catch around insert operation
-- Return detailed error if insert fails
-- Include Weaviate error details
-- Test error scenarios
+```typescript
+async createRequest(
+  userId: string,
+  action: string,
+  payload: any,
+  targetCollection?: string
+): Promise<{ requestId: string; token: string }> {
+  try {
+    const token = randomUUID();
+    // ... create request object
+    
+    console.log('[ConfirmationTokenService] Attempting to create request in Firestore');
+    
+    const docRef = await addDocument(collectionPath, request);
+    
+    if (!docRef || !docRef.id) {
+      throw new Error('Failed to create Firestore document - no document ID returned');
+    }
+    
+    console.log('[ConfirmationTokenService] Request created successfully:', {
+      requestId: docRef.id,
+      token,
+    });
+    
+    return { requestId: docRef.id, token };
+  } catch (error) {
+    console.error('[ConfirmationTokenService] Failed to create request:', error);
+    console.error('[ConfirmationTokenService] Context:', {
+      userId,
+      action,
+      collectionPath: `users/${userId}/requests`,
+    });
+    throw error;  // Re-throw so caller can handle
+  }
+}
+```
 
-**Expected Outcome**: Errors reported accurately
+### Step 2: Verify Error Propagation
 
-### 9. Test Edge Cases
+Ensure errors from token service propagate to tool handler:
 
-Verify fix handles edge cases.
+**File**: `src/tools/publish.ts`
 
-**Actions**:
-- Test with large memory
-- Test with memory that has relationships
-- Test with memory that has special characters
-- Test concurrent publishes
-- Test expired token
+The error handler already has `return` (fixed in v2.3.3), so errors should propagate correctly.
 
-**Expected Outcome**: All edge cases handled
+### Step 3: Check Firebase Permissions
 
-### 10. Update Documentation
+**Use Firebase MCP tools**:
+```typescript
+// Check if service account has correct permissions
+// Verify Firestore database exists
+// Test write operation
+```
 
-Document the fix.
+### Step 4: Add Integration Test
 
-**Actions**:
-- Add to CHANGELOG (patch version)
-- Update any affected documentation
-- Note in progress.yaml
-- Document root cause for future reference
+**File**: `tests/integration/publish-flow.test.ts`
 
-**Expected Outcome**: Fix documented
+Test the full flow:
+1. Create request (should succeed or fail clearly)
+2. Verify request exists in Firestore
+3. Confirm request
+4. Verify memory published
 
 ---
 
 ## Verification
 
-- [ ] Root cause identified
-- [ ] Bug fixed in code
-- [ ] Memory actually written to `Memory_the_void`
-- [ ] Published memory discoverable via search_space
-- [ ] Original memory unchanged in personal collection
-- [ ] Error handling accurate (no false positives)
-- [ ] Integration test created
-- [ ] All tests passing
-- [ ] TypeScript compiles
-- [ ] Build successful
-- [ ] Changes committed and pushed
+- [ ] `addDocument` errors are caught and logged
+- [ ] Errors propagate from token service to tool handler
+- [ ] Tool returns error response (not undefined)
+- [ ] Firebase credentials verified
+- [ ] Service account has Firestore write permissions
+- [ ] Integration test passes
+- [ ] Production logs show clear error messages
 
 ---
 
-## Investigation Checklist
-
-- [ ] Check if `Memory_the_void` collection exists
-- [ ] Verify `ensureSpaceCollection()` is called
-- [ ] Verify `targetCollection.data.insert()` is called
-- [ ] Check if insert returns a result
-- [ ] Verify result is used in response
-- [ ] Check server logs for errors
-- [ ] Test with actual Weaviate instance
-- [ ] Verify Weaviate write permissions
-
----
+## Files Modified
 
-## Expected Fix
-
-The bug is likely in [`src/tools/confirm.ts`](../../src/tools/confirm.ts) in the `executePublishMemory` function. The insert operation may not be executing or may be failing silently.
-
-**Likely Issue**: Missing await, incorrect API usage, or silent error
-
-**Expected Code**:
-```typescript
-const result = await targetCollection.data.insert({
-  properties: publishedMemory as any,
-});
-
-// Verify result
-if (!result) {
-  throw new Error('Failed to insert memory into space collection');
-}
-
-return JSON.stringify({
-  success: true,
-  space_memory_id: result,
-}, null, 2);
-```
-
----
+- `src/services/confirmation-token.service.ts` - Add error handling
+- `src/tools/publish.ts` - Verify error propagation (already fixed)
 
-## Related Files
+## Files Created
 
-- Confirm Tool: [`src/tools/confirm.ts`](../../src/tools/confirm.ts)
-- Space Schema: [`src/weaviate/space-schema.ts`](../../src/weaviate/space-schema.ts)
-- Design: [`agent/design/publish-tools-confirmation-flow.md`](../design/publish-tools-confirmation-flow.md)
+- `tests/integration/publish-flow.test.ts` - Integration test (optional)
 
 ---
 
-**Next Task**: Investigate and fix immediately - blocks shared spaces feature
+**Next Task**: Investigate production logs to confirm root cause

package/dist/server-factory.js

@@ -3241,33 +3241,72 @@ var ConfirmationTokenService = class {
    * @returns Request ID and token
    */
   async createRequest(userId, action, payload, targetCollection) {
-    const token = randomUUID();
-    const now = /* @__PURE__ */ new Date();
-    const expiresAt = new Date(now.getTime() + this.EXPIRY_MINUTES * 60 * 1e3);
-    const request = {
-      user_id: userId,
-      token,
-      action,
-      target_collection: targetCollection,
-      payload,
-      created_at: now.toISOString(),
-      expires_at: expiresAt.toISOString(),
-      status: "pending"
-    };
-    const collectionPath = `users/${userId}/requests`;
-    console.log("[ConfirmationTokenService] Creating request:", {
-      userId,
-      action,
-      targetCollection,
-      collectionPath
-    });
-    const docRef = await addDocument(collectionPath, request);
-    console.log("[ConfirmationTokenService] Request created:", {
-      requestId: docRef.id,
-      token,
-      expiresAt: request.expires_at
-    });
-    return { requestId: docRef.id, token };
+    try {
+      const token = randomUUID();
+      const now = /* @__PURE__ */ new Date();
+      const expiresAt = new Date(now.getTime() + this.EXPIRY_MINUTES * 60 * 1e3);
+      const request = {
+        user_id: userId,
+        token,
+        action,
+        target_collection: targetCollection,
+        payload,
+        created_at: now.toISOString(),
+        expires_at: expiresAt.toISOString(),
+        status: "pending"
+      };
+      const collectionPath = `users/${userId}/requests`;
+      console.log("[ConfirmationTokenService] Creating request:", {
+        userId,
+        action,
+        targetCollection,
+        collectionPath,
+        requestData: {
+          token,
+          action,
+          payloadKeys: Object.keys(payload)
+        }
+      });
+      console.log("[ConfirmationTokenService] Calling addDocument...");
+      const docRef = await addDocument(collectionPath, request);
+      console.log("[ConfirmationTokenService] addDocument returned:", {
+        hasDocRef: !!docRef,
+        hasId: !!docRef?.id,
+        docRefId: docRef?.id
+      });
+      if (!docRef) {
+        const error = new Error("Firestore addDocument returned null/undefined");
+        console.error("[ConfirmationTokenService] CRITICAL: addDocument returned null", {
+          userId,
+          collectionPath
+        });
+        throw error;
+      }
+      if (!docRef.id) {
+        const error = new Error("Firestore addDocument returned docRef without ID");
+        console.error("[ConfirmationTokenService] CRITICAL: docRef has no ID", {
+          userId,
+          collectionPath,
+          docRef
+        });
+        throw error;
+      }
+      console.log("[ConfirmationTokenService] Request created successfully:", {
+        requestId: docRef.id,
+        token,
+        expiresAt: request.expires_at
+      });
+      return { requestId: docRef.id, token };
+    } catch (error) {
+      console.error("[ConfirmationTokenService] FAILED to create request:", {
+        error: error instanceof Error ? error.message : String(error),
+        stack: error instanceof Error ? error.stack : void 0,
+        userId,
+        action,
+        collectionPath: `users/${userId}/requests`
+      });
+      throw error;
+    }
   }
   /**
    * Validate and retrieve a confirmation request

package/dist/server.js

@@ -3283,33 +3283,72 @@ var ConfirmationTokenService = class {
    * @returns Request ID and token
    */
   async createRequest(userId, action, payload, targetCollection) {
-    const token = randomUUID();
-    const now = /* @__PURE__ */ new Date();
-    const expiresAt = new Date(now.getTime() + this.EXPIRY_MINUTES * 60 * 1e3);
-    const request = {
-      user_id: userId,
-      token,
-      action,
-      target_collection: targetCollection,
-      payload,
-      created_at: now.toISOString(),
-      expires_at: expiresAt.toISOString(),
-      status: "pending"
-    };
-    const collectionPath = `users/${userId}/requests`;
-    console.log("[ConfirmationTokenService] Creating request:", {
-      userId,
-      action,
-      targetCollection,
-      collectionPath
-    });
-    const docRef = await addDocument(collectionPath, request);
-    console.log("[ConfirmationTokenService] Request created:", {
-      requestId: docRef.id,
-      token,
-      expiresAt: request.expires_at
-    });
-    return { requestId: docRef.id, token };
+    try {
+      const token = randomUUID();
+      const now = /* @__PURE__ */ new Date();
+      const expiresAt = new Date(now.getTime() + this.EXPIRY_MINUTES * 60 * 1e3);
+      const request = {
+        user_id: userId,
+        token,
+        action,
+        target_collection: targetCollection,
+        payload,
+        created_at: now.toISOString(),
+        expires_at: expiresAt.toISOString(),
+        status: "pending"
+      };
+      const collectionPath = `users/${userId}/requests`;
+      console.log("[ConfirmationTokenService] Creating request:", {
+        userId,
+        action,
+        targetCollection,
+        collectionPath,
+        requestData: {
+          token,
+          action,
+          payloadKeys: Object.keys(payload)
+        }
+      });
+      console.log("[ConfirmationTokenService] Calling addDocument...");
+      const docRef = await addDocument(collectionPath, request);
+      console.log("[ConfirmationTokenService] addDocument returned:", {
+        hasDocRef: !!docRef,
+        hasId: !!docRef?.id,
+        docRefId: docRef?.id
+      });
+      if (!docRef) {
+        const error = new Error("Firestore addDocument returned null/undefined");
+        console.error("[ConfirmationTokenService] CRITICAL: addDocument returned null", {
+          userId,
+          collectionPath
+        });
+        throw error;
+      }
+      if (!docRef.id) {
+        const error = new Error("Firestore addDocument returned docRef without ID");
+        console.error("[ConfirmationTokenService] CRITICAL: docRef has no ID", {
+          userId,
+          collectionPath,
+          docRef
+        });
+        throw error;
+      }
+      console.log("[ConfirmationTokenService] Request created successfully:", {
+        requestId: docRef.id,
+        token,
+        expiresAt: request.expires_at
+      });
+      return { requestId: docRef.id, token };
+    } catch (error) {
+      console.error("[ConfirmationTokenService] FAILED to create request:", {
+        error: error instanceof Error ? error.message : String(error),
+        stack: error instanceof Error ? error.stack : void 0,
+        userId,
+        action,
+        collectionPath: `users/${userId}/requests`
+      });
+      throw error;
+    }
   }
   /**
    * Validate and retrieve a confirmation request

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@prmichaelsen/remember-mcp",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "description": "Multi-tenant memory system MCP server with vector search and relationships",
   "main": "dist/server.js",
   "type": "module",