@printpractical/cruze 0.0.9 → 0.0.10

package/src/domain/line_diff.ts

@@ -0,0 +1,56 @@
+/**
+ * A line diff of two texts as unified-diff lines: "  " for a kept line, "- " removed, "+ " added.
+ * Only the changes and `context` kept lines around each are shown; "…" marks the lines left out.
+ */
+export function lineDiff(before: string[], after: string[], context = 2): string[] {
+  const ops = diffOps(before, after);
+  const near = new Set<number>();
+  ops.forEach((op, i) => {
+    if (op.kind === " ") return;
+    for (let j = Math.max(0, i - context); j <= Math.min(ops.length - 1, i + context); j++) near.add(j);
+  });
+  const lines: string[] = [];
+  let skipped = false;
+  ops.forEach((op, i) => {
+    if (!near.has(i)) {
+      skipped = true;
+      return;
+    }
+    if (skipped && lines.length > 0) lines.push("…");
+    skipped = false;
+    lines.push(`${op.kind} ${op.line}`);
+  });
+  if (skipped && lines.length > 0) lines.push("…");
+  return lines;
+}
+
+interface Op {
+  kind: " " | "-" | "+";
+  line: string;
+}
+
+/** The edit script of a longest common subsequence: documents are small enough for the quadratic table. */
+function diffOps(a: string[], b: string[]): Op[] {
+  const width = b.length + 1;
+  const table = new Int32Array((a.length + 1) * width);
+  const at = (i: number, j: number): number => table[i * width + j] ?? 0;
+  for (let i = a.length - 1; i >= 0; i--) {
+    for (let j = b.length - 1; j >= 0; j--) {
+      table[i * width + j] = a[i] === b[j] ? at(i + 1, j + 1) + 1 : Math.max(at(i + 1, j), at(i, j + 1));
+    }
+  }
+  const ops: Op[] = [];
+  let i = 0;
+  let j = 0;
+  while (i < a.length || j < b.length) {
+    if (i < a.length && j < b.length && a[i] === b[j]) {
+      ops.push({ kind: " ", line: a[i++] ?? "" });
+      j++;
+    } else if (j >= b.length || (i < a.length && at(i + 1, j) >= at(i, j + 1))) {
+      ops.push({ kind: "-", line: a[i++] ?? "" });
+    } else {
+      ops.push({ kind: "+", line: b[j++] ?? "" });
+    }
+  }
+  return ops;
+}

package/src/domain/project/element_lookup.ts

@@ -0,0 +1,124 @@
+import { elementLines, factsOf, statusOf, type DeltaOp, type Element, type Status } from "../elements.ts";
+import { findIds, kindOf, scopeOf, type Kind } from "../ids.ts";
+import type { MarkdownDoc } from "../markdown.ts";
+import { readDelta } from "./deltas.ts";
+import { PATHS } from "./layout.ts";
+import type { ProjectView } from "./project_view.ts";
+import type { ShownElement } from "./scope_view.ts";
+import type { WorkItem } from "./work_items.ts";
+
+/**
+ * Elements one at a time, and an index of all of them, so a step that needs a few elements of a
+ * large architecture fetches those instead of reading the whole file. One project's architecture
+ * held 52k words, and a single architect run read all of it to find what it would extend.
+ */
+
+export interface IndexEntry {
+  id: string;
+  title: string;
+  kind: Kind;
+  /** The living document that holds it, or the work item that adds it. */
+  source: string;
+  status?: Status;
+  /** Where its code lives: the `Module` it names, or a module's `Path`. */
+  place?: string;
+  /** For a requirement, how many scenarios it holds. */
+  scenarios?: number;
+  /** Work in flight whose delta changes or removes it. */
+  changedBy: string[];
+  /** Set when only in-flight work defines it so far. */
+  addedBy?: string;
+}
+
+export interface ElementIndex {
+  /** The words in the living architecture and specs, so a step can judge whether to read them whole. */
+  words: { architecture: number; specs: number };
+  entries: IndexEntry[];
+}
+
+const DOCS_INDEXED = (path: string): boolean => path === PATHS.architecture || path.startsWith(`${PATHS.specsDir}/`);
+
+/**
+ * Every element of the living architecture and specs, one entry each, with what in-flight work
+ * adds. Without a scope, scenarios are counted under their requirement; with a context or
+ * capability name, only its elements are listed, scenarios included.
+ */
+export function elementIndex(view: ProjectView, scope?: string): ElementIndex {
+  const inScope = (id: string): boolean => scope === undefined || scopeOf(id) === scope || id === `CTX-${scope}`;
+  const entries: IndexEntry[] = [];
+  const byId = new Map<string, IndexEntry>();
+  for (const living of view.living.elements.values()) {
+    if (!DOCS_INDEXED(living.path) || !inScope(living.id) || (scope === undefined && kindOf(living.id) === "SCN")) continue;
+    const entry = entryOf(living.id, living.element, living.doc, living.path);
+    if (kindOf(living.id) === "REQ") entry.scenarios = scenarioCount(view, living.id);
+    entries.push(entry);
+    byId.set(entry.id, entry);
+  }
+  for (const item of inFlight(view)) {
+    for (const element of deltaElements(item)) {
+      if (!inScope(element.element.id) || (scope === undefined && element.element.kind === "SCN")) continue;
+      const known = byId.get(element.element.id);
+      if (known !== undefined) {
+        known.changedBy.push(item.ref);
+        continue;
+      }
+      const added = { ...entryOf(element.element.id, element.element, item.doc, item.ref), addedBy: item.ref };
+      entries.push(added);
+      byId.set(added.id, added);
+    }
+  }
+  return { words: livingWords(view), entries };
+}
+
+/** The bodies of the named elements: the living one, then each in-flight delta that changes it. */
+export function lookupElements(view: ProjectView, ids: string[]): { elements: ShownElement[]; missing: string[] } {
+  const elements: ShownElement[] = [];
+  const missing: string[] = [];
+  for (const id of ids) {
+    const found: ShownElement[] = [];
+    const living = view.living.elements.get(id);
+    if (living !== undefined) found.push(shown(living.doc, living.element, living.path));
+    for (const item of inFlight(view)) {
+      const delta = deltaElements(item).find((d) => d.element.id === id);
+      if (delta !== undefined) found.push({ ...shown(item.doc, delta.element, item.path), ...(delta.op === undefined ? {} : { op: delta.op }) });
+    }
+    if (found.length === 0) missing.push(id);
+    elements.push(...found);
+  }
+  return { elements, missing };
+}
+
+function entryOf(id: string, element: Element, doc: MarkdownDoc, source: string): IndexEntry {
+  const facts = factsOf(doc, element);
+  const place = (facts.get("Module") ?? []).flatMap(findIds)[0] ?? (facts.get("Path") ?? [])[0];
+  const status = statusOf(doc, element);
+  return { id, title: element.title, kind: kindOf(id), source, changedBy: [], ...(status === undefined ? {} : { status }), ...(place === undefined ? {} : { place }) };
+}
+
+function shown(doc: MarkdownDoc, element: Element, path: string): ShownElement {
+  return { id: element.id, title: element.title, source: `${path}:${element.start + 1}`, body: elementLines(doc, element) };
+}
+
+function inFlight(view: ProjectView): WorkItem[] {
+  return view.items.filter((item) => !item.archived && item.kind !== "change");
+}
+
+/** Each element a work item's delta defines or changes, scenarios under a requirement included. */
+function deltaElements(item: WorkItem): Array<{ element: Element; op?: DeltaOp }> {
+  return readDelta(item.doc).entries.flatMap((entry) => [
+    { element: entry.element, ...(entry.element.op === undefined ? {} : { op: entry.element.op }) },
+    ...entry.scenarios.map((scenario) => ({ element: scenario })),
+  ]);
+}
+
+function scenarioCount(view: ProjectView, requirement: string): number {
+  const living = view.living.elements.get(requirement);
+  if (living === undefined) return 0;
+  return [...view.living.elements.values()].filter((e) => e.path === living.path && e.id.startsWith("SCN-") && e.element.start > living.element.start && e.element.start < living.element.end).length;
+}
+
+function livingWords(view: ProjectView): { architecture: number; specs: number } {
+  const words = (path: string): number => (view.snapshot.get(path) ?? "").split(/\s+/).filter((w) => w !== "").length;
+  const specs = [...view.living.docs.keys()].filter((path) => path.startsWith(`${PATHS.specsDir}/`));
+  return { architecture: words(PATHS.architecture), specs: specs.reduce((sum, path) => sum + words(path), 0) };
+}

package/src/domain/project/living_model.ts

@@ -1,4 +1,5 @@
 import { headingElements, rowElements, type Element } from "../elements.ts";
+import { VISION_KINDS } from "../ids.ts";
 import { parseMarkdown, type MarkdownDoc } from "../markdown.ts";
 import { PATHS, childFiles, type Snapshot } from "./layout.ts";
 
@@ -49,6 +50,6 @@ function elementsOf(path: string, doc: MarkdownDoc): Element[] {
   if (path.startsWith(`${PATHS.adrDir}/`)) {
     return [{ id: adrId(path), kind: "ADR", title: doc.headings[0]?.text ?? "", form: "heading", level: 1, start: 0, end: doc.lines.length }];
   }
-  if (path === PATHS.vision) return rowElements(doc).filter((element) => element.kind === "GOAL");
+  if (path === PATHS.vision) return rowElements(doc).filter((element) => VISION_KINDS.includes(element.kind));
   return headingElements(doc);
 }

package/src/domain/project/notes.ts

@@ -0,0 +1,74 @@
+import { findSection, parseMarkdown } from "../markdown.ts";
+import { tablesIn } from "../markdown_tables.ts";
+import { PATHS } from "./layout.ts";
+import type { Snapshot } from "./layout.ts";
+
+/**
+ * Notes under `.cruze/notes/`: what the user brought, what explore captured, the evidence research
+ * gathered, and the hand-off envision wrote from them. Each says what it is about, so a step reads
+ * the notes for its work rather than guessing from file names: one project held 21 notes, and a
+ * 9,500-word seed whose design sections no step was told to read.
+ */
+
+export const NOTE_KINDS = ["input", "intake", "explore", "research"] as const;
+export type NoteKind = (typeof NOTE_KINDS)[number];
+
+/** The step an intake row hands a part to, besides a feature on the map. */
+export const HANDOFF_STEPS = ["vision", "architect", "roadmap", "user"] as const;
+
+export interface HandoffRow {
+  /** The part of the input, by its heading or a short quote. */
+  part: string;
+  /** Where it is: a note path and heading, or "below" for text saved in the intake note. */
+  source: string;
+  /** A step from HANDOFF_STEPS, or the slug of the feature that takes it up. */
+  goesTo: string;
+  /** `open` until the step that takes it up settles it with the user: `settled` or `dropped`. */
+  status: string;
+}
+
+export interface Note {
+  path: string;
+  title: string;
+  kind?: string;
+  /** `project`, feature slugs, or context and capability names. */
+  about: string[];
+  handoff: HandoffRow[];
+}
+
+export function readNotes(snapshot: Snapshot): Note[] {
+  return [...snapshot.keys()]
+    .filter((path) => path.startsWith(`${PATHS.notesDir}/`) && path.endsWith(".md"))
+    .sort()
+    .map((path) => readNote(path, snapshot.get(path) ?? ""));
+}
+
+function readNote(path: string, text: string): Note {
+  const doc = parseMarkdown(text);
+  const title = doc.headings.find((h) => h.level === 1)?.text ?? path.slice(path.lastIndexOf("/") + 1, -".md".length);
+  const firstSection = doc.headings.find((h) => h.level === 2)?.line ?? doc.lines.length;
+  const fact = (key: string): string | undefined =>
+    doc.lines.slice(0, firstSection).map((line) => new RegExp(`^- ${key}: (.+)$`).exec(line)?.[1]?.trim()).find((v) => v !== undefined);
+  const about = (fact("About") ?? "").split(",").map((a) => a.trim()).filter((a) => a !== "");
+  const kind = fact("Kind");
+  const section = findSection(doc, "Hand-off");
+  const rows = section === null ? [] : (tablesIn(doc.lines, doc.inFence, section.start, section.end)[0]?.rows ?? []);
+  const handoff = rows.map(({ cells }) => ({ part: cells[0] ?? "", source: cells[1] ?? "", goesTo: (cells[2] ?? "").replace(/`/g, ""), status: cells[3] ?? "open" }));
+  return { path, title, about, handoff, ...(kind === undefined ? {} : { kind }) };
+}
+
+export interface NotesFor {
+  /** Notes about one of the targets, or about the whole project when it is a target. */
+  notes: Note[];
+  /** Intake rows handed to one of the targets, with the intake note that holds them. */
+  handoffs: Array<HandoffRow & { note: string }>;
+}
+
+/** The notes and hand-off rows for a piece of work, named by its targets: `project`, a step, a feature slug or a context. */
+export function notesFor(notes: Note[], targets: string[]): NotesFor {
+  const wanted = new Set(targets);
+  return {
+    notes: notes.filter((note) => note.about.some((a) => wanted.has(a))),
+    handoffs: notes.flatMap((note) => note.handoff.filter((row) => wanted.has(row.goesTo)).map((row) => ({ ...row, note: note.path }))),
+  };
+}

package/src/domain/skill_budget.ts

@@ -0,0 +1,36 @@
+import type { SkillFiles } from "./skill_links.ts";
+
+/**
+ * The words one instruction file may hold. A longer file holds material only some runs need, so it
+ * splits by branch, as `docs/contributing/writing-skills.md` says, and each run reads only its part.
+ */
+export const MAX_FILE_WORDS = 2100;
+
+/**
+ * The words agents may read across the whole bundle. Every retro adds rules, and between 0.0.1 and
+ * 0.0.10 the skills grew by half while nothing was removed. Lower this when text is cut. Raising it
+ * is the maintainer's decision, with the reason in the commit that raises it.
+ */
+export const BUNDLE_WORD_BUDGET = 44500;
+
+/** Data the CLI reads or renders, rather than instructions an agent reads. */
+const NOT_INSTRUCTIONS = /(^|\/)(templates|notes)\//;
+
+export function wordCount(text: string): number {
+  return text.split(/\s+/).filter((word) => word !== "").length;
+}
+
+/** Instruction files over their limit, and the bundle when it is over its budget. */
+export function budgetProblems(skills: SkillFiles[]): string[] {
+  const files = skills.flatMap((skill) =>
+    skill.files.filter((f) => f.path.endsWith(".md") && !NOT_INSTRUCTIONS.test(f.path)).map((f) => ({ path: `${skill.folder}/${f.path}`, words: wordCount(f.text) })),
+  );
+  const problems = files
+    .filter((f) => f.words > MAX_FILE_WORDS)
+    .map((f) => `${f.path}: ${f.words} words, over ${MAX_FILE_WORDS}; move what only some runs need into a sibling file`);
+  const total = files.reduce((sum, f) => sum + f.words, 0);
+  if (total > BUNDLE_WORD_BUDGET) {
+    problems.push(`the skills hold ${total} words, over the budget of ${BUNDLE_WORD_BUDGET}; cut or merge text to make room, or raise the budget with the reason in the commit`);
+  }
+  return problems;
+}

package/src/domain/status/next_step.ts

@@ -1,4 +1,5 @@
-import { evaluateApproval } from "../approvals/evaluate.ts";
+import { evaluateApproval, type ApprovalStatus } from "../approvals/evaluate.ts";
+import { rebaseNeeded } from "../approvals/rebase.ts";
 import { PATHS } from "../project/layout.ts";
 import { isPlanned, readChangesTable } from "../project/plan_parts.ts";
 import { readProgress } from "../project/progress.ts";
@@ -7,6 +8,7 @@ import { readRoadmapItems, readRoadmapStatus } from "../project/roadmap.ts";
 import { changesOf, featureOf, type WorkItem } from "../project/work_items.ts";
 import { compareVersions } from "../versions/cruze_version.ts";
 import { FIRST_RELEASE } from "../versions/rule_versions.ts";
+import { pendingReason, pendingRethinks } from "./pending_rethink.ts";
 import { awaitsRethink, isVerified } from "./verification.ts";
 import { activeChange } from "./work_status.ts";
 
@@ -112,7 +114,9 @@ function itemSteps(view: ProjectView, item: WorkItem, branch: string | null): Ne
   const state = evaluateApproval(view, item.path);
   if (readChangesTable(item.doc).length === 0) return [{ step: "architect", target: item.ref, reason: "the feature has no design or changes yet" }];
   if (state.state === "unapproved") return [{ step: "architect", target: item.ref, reason: "review the feature's design and approve it" }];
-  if (state.state !== "approved") return [{ step: "rethink", target: item.ref, reason: `the feature changed since its approval${state.changed.length > 0 ? ` (${state.changed.join(", ")})` : ""}` }];
+  if (state.state !== "approved") return [{ step: "rethink", target: item.ref, reason: staleReason(view, item, "the feature", state) }];
+  const pending = pendingRethinks(view.journal, item);
+  if (pending.length > 0) return [{ step: "rethink", target: item.ref, reason: pendingReason(item, pending) }];
   const changes = changesOf(view.items, item);
   const landed = new Set(changes.filter((c) => readProgress(c.doc).landed !== undefined).map((c) => c.folderName));
   const steps: NextStep[] = [];
@@ -131,14 +135,17 @@ function changeStep(view: ProjectView, change: WorkItem, branch: string | null):
   const feature = featureOf(view.items, change);
   const featureState = feature === undefined ? undefined : evaluateApproval(view, feature.path);
   if (feature !== undefined && featureState !== undefined && featureState.state !== "approved") {
-    const why = featureState.changed.length > 0 ? ` (${featureState.changed.join(", ")})` : "";
-    return { step: "rethink", target: feature.ref, reason: `the feature of ${change.ref} changed since its approval${why}` };
+    return { step: "rethink", target: feature.ref, reason: staleReason(view, feature, `the feature of ${change.ref}`, featureState) };
+  }
+  for (const part of [feature, change]) {
+    const pending = part === undefined ? [] : pendingRethinks(view.journal, part);
+    if (part !== undefined && pending.length > 0) return { step: "rethink", target: part.ref, reason: pendingReason(part, pending) };
   }
   const bound = readProgress(change.doc).branch;
   const state = evaluateApproval(view, change.path);
   if (!isPlanned(change.doc)) return { step: "plan", target: change.ref, reason: "the change is designed but has no test plan or tasks yet" };
   if (state.state === "unapproved") return { step: "plan", target: change.ref, reason: "review the plan and approve it on the branch that will build it" };
-  if (state.state !== "approved") return { step: "rethink", target: change.ref, reason: `the change or something it cites changed since its approval${state.changed.length > 0 ? ` (${state.changed.join(", ")})` : ""}` };
+  if (state.state !== "approved") return { step: "rethink", target: change.ref, reason: staleReason(view, change, "the change", state) };
   if (awaitsRethink(view.journal, change, feature)) return { step: "rethink", target: feature?.ref ?? change.ref, reason: `verify sent ${change.ref} back for a design change` };
   if (bound !== undefined && bound !== branch) return { step: "switch-branch", target: bound, reason: `${change.ref} is built on branch ${bound}` };
   const progress = readProgress(change.doc);
@@ -147,6 +154,21 @@ function changeStep(view: ProjectView, change: WorkItem, branch: string | null):
   return { step: "land", target: change.ref, reason: "the change is verified and accepted" };
 }
 
+/**
+ * Why work went stale, and what the rethink will take: a rebase when its delta still changes an
+ * element whose living text moved, or only a check of the diff and a re-stamp when nothing it cites
+ * asks anything of its own text. One project expected a re-stamp and met rebase-required.
+ */
+function staleReason(view: ProjectView, item: WorkItem, label: string, state: ApprovalStatus): string {
+  if (state.state === "edited") return `${label} changed since its approval`;
+  const changed = state.changed.join(", ");
+  const rebase = rebaseNeeded(view, item);
+  const then = rebase.length > 0
+    ? `its delta changes ${rebase.join(", ")}, so rebase it, as cruze diff ${item.ref} shows`
+    : `read cruze diff ${item.ref}, and re-stamp it when the work still holds`;
+  return `something ${label} cites changed since its approval (${changed}); ${then}`;
+}
+
 /** The first roadmap item that hasn't started and whose blockers have all landed. */
 function roadmapStep(view: ProjectView): NextStep | null {
   const text = view.snapshot.get(PATHS.roadmap);

package/src/domain/status/pending_rethink.ts

@@ -0,0 +1,22 @@
+import type { JournalEntry } from "../journal.ts";
+import type { WorkItem } from "../project/work_items.ts";
+
+/**
+ * Findings decided `rethink` for a feature or change that no rethink of it has followed yet.
+ * One project's realign recorded seven design findings on a feature as fixed "by a rethink before
+ * its next change is planned"; nothing showed them, and they surfaced only in a commit message.
+ */
+export function pendingRethinks(journal: JournalEntry[], item: WorkItem): JournalEntry[] {
+  const lastRethink = journal
+    .filter((e) => e.event === "rethink" && e["item"] === item.ref)
+    .map((e) => e.at)
+    .sort()
+    .at(-1);
+  return journal.filter((e) => e.event === "disposition" && e["disposition"] === "rethink" && e["item"] === item.ref && (lastRethink === undefined || e.at > lastRethink));
+}
+
+/** Why work waits on a rethink, naming the first finding. */
+export function pendingReason(item: WorkItem, pending: JournalEntry[]): string {
+  const more = pending.length > 1 ? ` and ${pending.length - 1} more` : "";
+  return `${pending.length} finding(s) on ${item.ref} were decided for a rethink that hasn't happened yet: ${String(pending[0]?.["finding"] ?? "")}${more}`;
+}

package/src/domain/status/work_status.ts

@@ -5,6 +5,7 @@ import { readChangesTable, readScope } from "../project/plan_parts.ts";
 import { readProgress } from "../project/progress.ts";
 import type { ProjectView } from "../project/project_view.ts";
 import { changesOf, featureOf, type WorkItem } from "../project/work_items.ts";
+import { pendingReason, pendingRethinks } from "./pending_rethink.ts";
 
 export interface ChangeStatus {
   ref: string;
@@ -15,6 +16,8 @@ export interface ChangeStatus {
   tasksTotal: number;
   /** When and in which commit the change landed, once it has. */
   landed?: string;
+  /** Findings decided for a rethink of this change that hasn't happened yet. */
+  rethinkPending?: string[];
 }
 
 export interface FeatureStatus {
@@ -22,6 +25,8 @@ export interface FeatureStatus {
   path: string;
   approval: ApprovalStatus;
   changes: ChangeStatus[];
+  /** Findings decided for a rethink of this feature that hasn't happened yet. */
+  rethinkPending?: string[];
 }
 
 export interface ProjectStatus {
@@ -42,6 +47,7 @@ export function projectStatus(view: ProjectView, branch: string | null): Project
       path: feature.path,
       approval: evaluateApproval(view, feature.path),
       changes: changesOf(view.items, feature).map((change) => changeStatus(view, change)),
+      ...withPending(view, feature),
     }));
   const standalone = active.filter((item) => item.kind === "standalone").map((change) => changeStatus(view, change));
   const status: ProjectStatus = { documents, features, standalone };
@@ -69,7 +75,12 @@ function changeStatus(view: ProjectView, change: WorkItem): ChangeStatus {
   };
   if (progress.branch !== undefined) status.branch = progress.branch;
   if (progress.landed !== undefined) status.landed = progress.landed;
-  return status;
+  return { ...status, ...withPending(view, change) };
+}
+
+function withPending(view: ProjectView, item: WorkItem): { rethinkPending?: string[] } {
+  const pending = pendingRethinks(view.journal, item);
+  return pending.length === 0 ? {} : { rethinkPending: pending.map((e) => String(e["finding"] ?? "")) };
 }
 
 /** Why building may not start on this branch; empty when the build gate passes. */
@@ -86,7 +97,11 @@ export function buildGateReasons(view: ProjectView, branch: string | null): stri
     const detail = status.changed.length > 0 ? `: ${status.changed.join(", ")} changed` : status.unjournaled === true ? ": the approval has no journal entry" : "";
     return [`${path} is ${status.state}${detail}`];
   });
-  return [...approvals, ...unlandedDependencies(view, change, feature)];
+  const rethinks = [feature, change].flatMap((part) => {
+    const pending = part === undefined ? [] : pendingRethinks(view.journal, part);
+    return part === undefined || pending.length === 0 ? [] : [`${pendingReason(part, pending)}; run rethink`];
+  });
+  return [...approvals, ...rethinks, ...unlandedDependencies(view, change, feature)];
 }
 
 /** The changes this change's row in its feature's Changes table depends on that haven't landed on this branch. */

package/src/domain/validation/decision_rules.ts

@@ -0,0 +1,76 @@
+import { definedDecisions, findDecisionCitations, workItemSlugs, type DecisionCitation } from "../decision_citations.ts";
+import type { Element } from "../elements.ts";
+import { findSection, type MarkdownDoc } from "../markdown.ts";
+import { readDelta } from "../project/deltas.ts";
+import { PATHS } from "../project/layout.ts";
+import type { ProjectView } from "../project/project_view.ts";
+import type { WorkItem } from "../project/work_items.ts";
+import { warning, type Problem } from "./problem.ts";
+
+const INSTEAD = "write what it decided into this text, or cite the ADR that records it";
+
+/**
+ * The architecture cites only the decisions its own `## Decisions` defines. The other living docs
+ * cite none by number, and no living doc cites a feature's or change's, which is archived when it finishes.
+ */
+export function livingDecisionProblems(view: ProjectView): Problem[] {
+  const slugs = slugsOf(view);
+  const project = projectDecisions(view);
+  const problems: Problem[] = [];
+  for (const [path, doc] of view.living.docs) {
+    for (const citation of citationsIn(doc, slugs)) {
+      if (citation.qualifier !== undefined) {
+        problems.push(warning(path, citation.line, "decision-citation", `cites ${citation.text}, a decision of ${citation.qualifier}, which the living docs don't hold; ${INSTEAD}`));
+      } else if (path !== PATHS.architecture) {
+        problems.push(warning(path, citation.line, "decision-citation", `cites ${citation.text}, but only the architecture cites decisions by number, its own; ${INSTEAD}`));
+      } else {
+        const unknown = citation.numbers.filter((n) => !project.has(n));
+        if (unknown.length > 0) {
+          problems.push(warning(path, citation.line, "decision-citation", `cites ${unknown.map((n) => `D${n}`).join(", ")}, which "## Decisions" doesn't define; ${INSTEAD}`));
+        }
+      }
+    }
+  }
+  return problems;
+}
+
+/**
+ * A delta's elements merge into the living docs, where the work's own decisions don't follow them.
+ * They may cite a project decision the work doesn't renumber, or one the living element already cites.
+ */
+export function deltaDecisionProblems(view: ProjectView, item: WorkItem): Problem[] {
+  const slugs = slugsOf(view);
+  const project = projectDecisions(view);
+  const local = definedDecisions(sectionLines(item.doc, "Settled decisions"));
+  const problems: Problem[] = [];
+  for (const { element } of readDelta(item.doc).entries) {
+    const living = view.living.elements.get(element.id);
+    const carried = new Set(living === undefined ? [] : citationsIn(living.doc, slugs, living.element).flatMap((c) => (c.qualifier === undefined ? c.numbers : [])));
+    const allowed = (n: number): boolean => project.has(n) && (!local.has(n) || carried.has(n));
+    for (const citation of citationsIn(item.doc, slugs, element)) {
+      if (citation.qualifier === undefined && citation.numbers.every(allowed)) continue;
+      problems.push(warning(item.path, citation.line, "decision-citation", `${element.id} cites ${citation.text}, which won't mean the same in the living docs once this delta merges; ${INSTEAD}`));
+    }
+  }
+  return problems;
+}
+
+function citationsIn(doc: MarkdownDoc, slugs: Set<string>, element?: Element): DecisionCitation[] {
+  const from = element === undefined ? doc.bodyStart : element.start + 1;
+  const to = element === undefined ? doc.lines.length : element.end;
+  return findDecisionCitations(doc.lines, slugs, (line) => line < from || line >= to || doc.inFence[line] === true || doc.inManaged[line] === true);
+}
+
+function projectDecisions(view: ProjectView): Set<number> {
+  const architecture = view.living.docs.get(PATHS.architecture);
+  return architecture === undefined ? new Set() : definedDecisions(sectionLines(architecture, "Decisions"));
+}
+
+function sectionLines(doc: MarkdownDoc, title: string): string[] {
+  const range = findSection(doc, title);
+  return range === null ? [] : doc.lines.slice(range.start, range.end);
+}
+
+function slugsOf(view: ProjectView): Set<string> {
+  return workItemSlugs(view.items.map((item) => item.folderName));
+}

package/src/domain/validation/delta_rules.ts

@@ -4,6 +4,7 @@ import { specPath } from "../project/layout.ts";
 import { orphanDeltaElements, readDelta, type Delta } from "../project/deltas.ts";
 import type { ProjectView } from "../project/project_view.ts";
 import type { WorkItem } from "../project/work_items.ts";
+import { deltaDecisionProblems } from "./decision_rules.ts";
 import { elementProblems } from "./element_rules.ts";
 import { error, type Problem } from "./problem.ts";
 
@@ -44,6 +45,7 @@ export function deltaProblems(view: ProjectView, item: WorkItem): Problem[] {
       problems.push(error(path, op.start, "capability-exists", `capability ${op.capability} already has ${specPath(op.capability)}`));
     }
   }
+  problems.push(...deltaDecisionProblems(view, item));
   return problems;
 }
 

package/src/domain/validation/future_rules.ts

@@ -0,0 +1,40 @@
+import { factsOf, headingElements } from "../elements.ts";
+import { readRows } from "../edits/managed_tables.ts";
+import { findIds, kindOf } from "../ids.ts";
+import type { MarkdownDoc } from "../markdown.ts";
+import { PATHS } from "../project/layout.ts";
+import { readDelta } from "../project/deltas.ts";
+import type { ProjectView } from "../project/project_view.ts";
+import { readRoadmapItems } from "../project/roadmap.ts";
+import { warning, type Problem } from "./problem.ts";
+
+/**
+ * A `Future` fact keeps room for a need someone stated: a `LATER` capability of the vision, or a
+ * feature on the feature map or the roadmap. One that names neither reserves room for a need nobody
+ * stated, which the design reviewer treats as a finding; this makes it visible without a review.
+ */
+export function futureProblems(view: ProjectView): Problem[] {
+  const slugs = anchorSlugs(view);
+  const unanchored = (text: string): boolean =>
+    !findIds(text).some((id) => kindOf(id) === "LATER") && ![...slugs].some((slug) => new RegExp(`(^|[^a-z0-9-])${slug}([^a-z0-9-]|$)`).test(text));
+  const check = (path: string, doc: MarkdownDoc, from = 0, to = doc.lines.length): Problem[] =>
+    headingElements(doc, from, to).flatMap((element) =>
+      (factsOf(doc, element).get("Future") ?? [])
+        .filter(unanchored)
+        .map(() => warning(path, element.start, "future-unanchored", `${element.id} keeps room for a need its Future fact doesn't name; cite the LATER capability, or the feature on the map or roadmap, that it serves`)),
+    );
+  const living = view.living.docs.get(PATHS.architecture);
+  const deltas = view.items
+    .filter((item) => !item.archived && item.kind !== "change")
+    .flatMap((item) => readDelta(item.doc).entries.flatMap((entry) => check(item.path, item.doc, entry.element.start, entry.element.end)));
+  return [...(living === undefined ? [] : check(PATHS.architecture, living)), ...deltas];
+}
+
+/** Feature slugs a Future fact may name: the feature map's, implemented or future, and the roadmap's items. */
+function anchorSlugs(view: ProjectView): Set<string> {
+  const vision = view.snapshot.get(PATHS.vision) ?? "";
+  const roadmap = view.snapshot.get(PATHS.roadmap);
+  const mapped = ["Implemented", "Future"].flatMap((heading) => readRows(vision, heading).map((row) => row[0] ?? ""));
+  const planned = roadmap === undefined ? [] : readRoadmapItems(roadmap).map((item) => item.slug);
+  return new Set([...mapped, ...planned].map((slug) => slug.trim()).filter((slug) => /^[a-z0-9-]+$/.test(slug)));
+}

package/src/domain/validation/living_rules.ts

@@ -4,6 +4,7 @@ import { findIds, scopeOf, STATUS_KINDS } from "../ids.ts";
 import type { MarkdownDoc } from "../markdown.ts";
 import { PATHS } from "../project/layout.ts";
 import type { ProjectView } from "../project/project_view.ts";
+import { livingDecisionProblems } from "./decision_rules.ts";
 import { elementProblems } from "./element_rules.ts";
 import { error, warning, type Problem } from "./problem.ts";
 
@@ -26,6 +27,7 @@ export function livingProblems(view: ProjectView): Problem[] {
       if (!view.living.elements.has(id)) problems.push(error(path, lineOf(text, id), "unknown-id", `${id} is cited but not defined in the living docs`));
     }
   }
+  problems.push(...livingDecisionProblems(view));
   return problems;
 }
 

package/src/domain/validation/validate_project.ts

@@ -1,7 +1,9 @@
 import type { ProjectView } from "../project/project_view.ts";
+import { futureProblems } from "./future_rules.ts";
 import { livingProblems } from "./living_rules.ts";
 import { error, sortProblems, type Problem } from "./problem.ts";
 import { configProblems, readmeProblems, roadmapProblems, templateLeftovers } from "./project_rules.ts";
+import { visionProblems } from "./vision_rules.ts";
 import { workItemProblems } from "./work_item_rules.ts";
 
 /** Every rule in the cruze-formats skill, applied to the whole project. */
@@ -13,6 +15,8 @@ export function validateProject(view: ProjectView): Problem[] {
   return sortProblems([
     ...configProblems(view),
     ...livingProblems(view),
+    ...visionProblems(view),
+    ...futureProblems(view),
     ...roadmapProblems(view),
     ...workItemProblems(view),
     ...templateLeftovers(view),