@printpractical/cruze 0.0.14 → 0.0.15

package/README.md

@@ -10,7 +10,7 @@ It works with any agent that supports the [Agent Skills](https://agentskills.io)
 
 ## Status
 
-Version 0.0.14 is a rewrite. The earlier previews ran thirteen steps with design reviews, plans, verifiers, journals and merged living specs. Measured across nine projects, they took about twice the time of a plain design doc and plan for code of the same quality, and asked the user so many questions that most answers were a bare "agree". This version keeps what paid off and drops the rest. Nothing is compatible with 0.0.13 projects. Claude Code is the agent tested so far.
+Version 0.0.14 was a rewrite. The earlier previews ran thirteen steps with design reviews, plans, verifiers, journals and merged living specs. Measured across nine projects, they took about twice the time of a plain design doc and plan for code of the same quality, and asked the user so many questions that most answers were a bare "agree". It kept what paid off and dropped the rest. Nothing is compatible with 0.0.13 projects. Claude Code is the agent tested so far.
 
 ## The flow
 
@@ -48,7 +48,7 @@ The skills run `cruze` commands, so the agent needs `cruze` on its path. Install
 From a GitHub Release, without npm:
 
 ```sh
-npm install -g https://github.com/PrintPractical/cruze/releases/download/v0.0.14/printpractical-cruze-0.0.14.tgz
+npm install -g https://github.com/PrintPractical/cruze/releases/download/v0.0.15/printpractical-cruze-0.0.15.tgz
 ```
 
 From npm, once a version is published there:
@@ -60,7 +60,7 @@ npm install -g @printpractical/cruze
 From the git repository, at a tag or `#main`. npm 11 needs `--install-links` for a global git install, and the first `cruze` command builds the CLI:
 
 ```sh
-npm install -g --install-links github:PrintPractical/cruze#v0.0.14
+npm install -g --install-links github:PrintPractical/cruze#v0.0.15
 ```
 
 ### 2. Set up a repository
@@ -74,7 +74,7 @@ cruze init
 When you didn't install from npm, tell `init` where Cruze came from, so the CI it writes runs the same source:
 
 ```sh
-cruze init --package https://github.com/PrintPractical/cruze/releases/download/v0.0.14/printpractical-cruze-0.0.14.tgz
+cruze init --package https://github.com/PrintPractical/cruze/releases/download/v0.0.15/printpractical-cruze-0.0.15.tgz
 ```
 
 `init` asks for the project name and your coding agent: `claude` for Claude Code, or `other` for any agent that reads `AGENTS.md` and `.agents/skills/`. It creates `README.md`, `CHANGELOG.md`, `AGENTS.md` (and `CLAUDE.md` for Claude Code), `.cruze/config.yaml`, a CI workflow that runs `cruze validate`, `check` and `trace`, and the skills in `.agents/skills/`, linked into `.claude/skills/` for Claude Code. It never overwrites an existing file.
@@ -98,7 +98,7 @@ When the CLI you run differs from the version the project records, every command
 | `cruze init` | Sets up the repository and installs the skills |
 | `cruze install` | Installs or updates the skills |
 | `cruze new vision\|architecture\|feature <slug>` | Starts a document from its template |
-| `cruze validate` | Checks the documents: required sections, scenario IDs, the release's features and needs, size, leftover template text |
+| `cruze validate` | Checks the documents: required sections, scenario IDs, the release's features and needs, leftover template text |
 | `cruze approve <vision\|architecture\|slug>` | Records that you approved a document as it reads now |
 | `cruze status` | Each document's approval and each feature's progress, in release order, and the next step |
 | `cruze next` | The step to run next, and why |

package/dist/adapters/inbound/cli/commands/install.js

@@ -15,5 +15,6 @@ export function describeSkillInstall(report                     )           {
   if (from !== to) lines.push(`Recorded Cruze ${to} in .cruze/config.yaml${from === undefined ? "" : `, up from ${from}`}`);
   if (ci.repinned.length > 0) lines.push(`CI runs ${ci.repinned.join(", ")}`);
   for (const spec of ci.unrecognised) lines.push(`CI runs ${spec}, which Cruze can't move to ${to}; update .github/workflows/ci.yml yourself`);
+  for (const note of report.notes) lines.push(`Note: ${note}`);
   return lines;
 }

package/dist/app/use_cases/install_skills.js

@@ -1,9 +1,12 @@
 import { posix } from "node:path";
 import { CruzeError } from "../../domain/cruze_error.js";
 import { AGENT_SKILL_HOMES, SHARED_SKILLS_DIR, agentSkillHome, knownAgents } from "../../domain/agent_skill_homes.js";
+import { reviewSettingTemplate } from "../../domain/scaffold.js";
 import { SKILL_FILE, installedSkillName, isInstalledSkillName, skillProblems } from "../../domain/skill.js";
+import { reviewCommandProblems } from "../../domain/validation/review_rules.js";
                                                                
                                                               
+import { loadDocs } from "../project_context.js";
 import { recordVersion, refuseDowngrade,                    } from "./record_version.js";
 
                                        
@@ -18,6 +21,8 @@ import { recordVersion, refuseDowngrade,                    } from "./record_ver
                                                 
                                                                                      
                           
+                                                                                                  
+                  
  
 
 /**
@@ -55,7 +60,8 @@ export async function installSkills(
   }
 
   const recorded = await recordVersion(files, bundle.version);
-  return { version: bundle.version, installed: names, removed, linked, recorded };
+  const notes = reviewCommandProblems(await loadDocs(files), await bundle.template(reviewSettingTemplate("claude"))).map((problem) => problem.message);
+  return { version: bundle.version, installed: names, removed, linked, recorded, notes };
 }
 
 function assertValid(skills                )       {

package/dist/app/use_cases/validate_project.js

@@ -1,6 +1,8 @@
 import { hasErrors, validateProject } from "../../domain/validation/validate_project.js";
 import { warning,              } from "../../domain/validation/problem.js";
 import { PATHS } from "../../domain/project/layout.js";
+import { reviewSettingTemplate } from "../../domain/scaffold.js";
+import { reviewCommandProblems } from "../../domain/validation/review_rules.js";
 import { versionSkew } from "../../domain/versions/cruze_version.js";
                                                  
                                                               
@@ -13,12 +15,13 @@ import { loadDocs } from "../project_context.js";
                       
  
 
-/** Checks every document in the project against the cruze-formats rules, and that its skills match this CLI. */
+/** Checks every document in the project against the cruze-formats rules, that its skills match this CLI, and that its reviewer can run the tests. */
 export async function validate(deps                                         )                          {
   const docs = await loadDocs(deps.files);
   const config = docs.config?.config;
   const skew = config === null || config === undefined ? undefined : versionSkew(deps.bundle.version, config.cruze);
-  const problems = [...validateProject(docs), ...(skew === undefined ? [] : [warning(PATHS.config, undefined, "cruze-version", skew.message)])];
+  const review = reviewCommandProblems(docs, await deps.bundle.template(reviewSettingTemplate("claude")));
+  const problems = [...validateProject(docs), ...(skew === undefined ? [] : [warning(PATHS.config, undefined, "cruze-version", skew.message)]), ...review];
   return {
     valid: !hasErrors(problems),
     errors: problems.filter((p) => p.severity === "error").length,

package/dist/domain/check/check_source.js

@@ -37,7 +37,7 @@ export function checkSource(input            )                 {
       findings.push({ path, rule: "no-layer", severity: "warning", message: "the file is in no layer, so its imports are unchecked" });
     }
     if (layer !== undefined) {
-      for (const found of importsOf(path, text)) {
+      for (const found of importsOf(path, text, all)) {
         const target = resolveImport(found, all);
         const targetLayer = target === undefined ? undefined : layerOf(target);
         if (target === undefined || targetLayer === undefined || targetLayer.name === layer.name) continue;

package/dist/domain/check/imports.js

@@ -12,11 +12,11 @@ import { rustImportCandidates } from "./rust_imports.js";
 const JS = /\.(?:[cm]?[jt]sx?)$/;
 const JS_EXTENSIONS = ["", ".ts", ".tsx", ".js", ".jsx", ".mjs", ".cjs", "/index.ts", "/index.js"];
 
-/** Imports that point inside the project. Imports of libraries and the standard library are left out. */
-export function importsOf(path        , text        )                 {
+/** Imports that point inside the project, among `files`. Imports of libraries and the standard library are left out. */
+export function importsOf(path        , text        , files                   )                 {
   if (JS.test(path)) return jsImports(path, text);
   if (path.endsWith(".py")) return pythonImports(path, text);
-  if (path.endsWith(".rs")) return rustImportCandidates(path, text).map((i) => ({ ...i, bySuffix: false }));
+  if (path.endsWith(".rs")) return rustImportCandidates(path, text, files).map((i) => ({ ...i, bySuffix: false }));
   if (/\.(?:c|h|cc|cpp|cxx|hh|hpp|hxx)$/.test(path)) return matches(text, /^\s*#\s*include\s+"([^"]+)"/gm, (target) => [target], true);
   if (path.endsWith(".go")) return goImports(text);
   if (/\.(?:java|kt)$/.test(path)) return matches(text, /^import\s+(?:static\s+)?([\w.]+)(?:\.\*)?;?\s*$/gm, (t) => [`${t.replace(/\./g, "/")}.java`, `${t.replace(/\./g, "/")}.kt`], true);

package/dist/domain/check/rust_imports.js

@@ -1,10 +1,14 @@
-/** Resolves Rust `use` paths inside a crate to candidate source files. */
+/** Resolves Rust `use` paths, inside a crate and between a workspace's crates, to candidate source files. */
 
-/** Candidate files for each `use crate::…`, `use super::…` and `use self::…` path in a Rust file. */
-export function rustImportCandidates(path        , text        )                                                {
+/**
+ * Candidate files for each `use crate::…`, `use super::…` and `use self::…` path in a Rust file,
+ * and for each `use other_crate::…` that names a library crate among `files`.
+ */
+export function rustImportCandidates(path        , text        , files                   )                                                {
   const root = crateRoot(path);
   if (root === null) return [];
   const own = moduleSegments(path, root);
+  const crates = libraryCrates(files);
   const results                                                = [];
   const pattern = /^\s*(?:pub(?:\([^)]*\))?\s+)?use\s+([^;]+);/gms;
   for (const match of text.matchAll(pattern)) {
@@ -12,11 +16,29 @@ export function rustImportCandidates(path        , text        )
     for (const segments of expandUse((match[1] ?? "").replace(/\s+/g, ""))) {
       const absolute = absoluteSegments(segments, own);
       if (absolute !== null) results.push({ line, candidates: candidatesFor(root, absolute) });
+      else {
+        const [head, ...rest] = segments;
+        const other = head === undefined ? undefined : crates.get(head);
+        if (other !== undefined && other !== root) results.push({ line, candidates: candidatesFor(other, rest) });
+      }
     }
   }
   return results;
 }
 
+/**
+ * Each library crate in the project by the name code imports it as: the directory
+ * holding `src/lib.rs`, with hyphens as underscores, as Cargo names it by default.
+ */
+function libraryCrates(files                   )                      {
+  const crates = new Map                ();
+  for (const file of files) {
+    const match = /^(?:.*\/)?([^/]+)\/src\/lib\.rs$/.exec(file);
+    if (match !== null) crates.set((match[1] ?? "").replace(/-/g, "_"), file.slice(0, -"lib.rs".length));
+  }
+  return crates;
+}
+
 /** The directory holding the crate root: everything up to and including `src/`. */
 function crateRoot(path        )                {
   const index = path.lastIndexOf("src/");

package/dist/domain/skill_budget.js

@@ -11,7 +11,7 @@ export const MAX_FILE_WORDS = 2100;
  * as every fix added rules and nothing was removed; 0.0.14 cut them to this. Lower it when text is
  * cut. Raising it is the maintainer's decision, with the reason in the commit that raises it.
  */
-export const BUNDLE_WORD_BUDGET = 17605;
+export const BUNDLE_WORD_BUDGET = 17725;
 
 /** Data the CLI reads or renders, rather than instructions an agent reads. */
 const NOT_INSTRUCTIONS = /(^|\/)(templates|notes)\//;

package/dist/domain/validation/document_rules.js

@@ -3,34 +3,29 @@ import { findSection,                  } from "../markdown.js";
 import { FEATURE_SECTIONS, FEATURE_STATUSES, statusLine, strayScenarioIds,              } from "../project/features.js";
 import { PATHS } from "../project/layout.js";
                                                               
-import { error, warning,              } from "./problem.js";
+import { error,              } from "./problem.js";
 
-/** Each document's required sections, its size, its scenarios, and leftover template guides. */
+/** Each document's required sections, its scenarios, and leftover template guides. */
 
 const VISION_SECTIONS = ["Problem", "Users", "Release"];
 const ARCHITECTURE_SECTIONS = ["Overview", "Ports", "Adapters", "Runtime"];
 
-/** Words past which a document stops being something a person reads in one sitting. */
-export const WORD_LIMITS = { vision: 1500, architecture: 3000, feature: 2500 }         ;
-
 const GUIDE = /(?<!`)<(?!!--|\/|https?:|br\b)[A-Za-z][^<>\n]*>(?!`)/;
 const PLACEHOLDER = /\{\{[a-z_]+\}\}/;
 
 export function documentProblems(docs             )            {
   const problems            = [];
-  if (docs.vision !== undefined) problems.push(...shapeOf(PATHS.vision, docs.vision, VISION_SECTIONS, WORD_LIMITS.vision));
-  if (docs.architecture !== undefined) problems.push(...shapeOf(PATHS.architecture, docs.architecture, ARCHITECTURE_SECTIONS, WORD_LIMITS.architecture));
+  if (docs.vision !== undefined) problems.push(...shapeOf(PATHS.vision, docs.vision, VISION_SECTIONS));
+  if (docs.architecture !== undefined) problems.push(...shapeOf(PATHS.architecture, docs.architecture, ARCHITECTURE_SECTIONS));
   for (const feature of docs.features) {
-    problems.push(...shapeOf(feature.path, feature.doc, [...FEATURE_SECTIONS], WORD_LIMITS.feature), ...featureProblems(feature));
+    problems.push(...shapeOf(feature.path, feature.doc, [...FEATURE_SECTIONS]), ...featureProblems(feature));
   }
   problems.push(...duplicateScenarios(docs.features));
   return problems;
 }
 
-function shapeOf(path        , doc             , sections          , limit        )            {
+function shapeOf(path        , doc             , sections          )            {
   const problems            = sections.filter((title) => findSection(doc, title) === null).map((title) => error(path, undefined, "missing-section", `needs a ## ${title} section`));
-  const words = doc.lines.filter((_, i) => !doc.inFence[i]).join(" ").split(/\s+/).filter((w) => w !== "").length;
-  if (words > limit) problems.push(warning(path, undefined, "too-long", `${words} words, over the ${limit} a person reads in one sitting; cut what the agent decided and the user needn't read, or split it`));
   doc.lines.forEach((line, i) => {
     if (doc.inFence[i]) return;
     const withoutCode = line.replace(/`[^`]*`/g, "");

package/dist/domain/validation/review_rules.js

@@ -0,0 +1,21 @@
+import { parse as parseYaml } from "yaml";
+import { PATHS } from "../project/layout.js";
+                                                              
+import { warning,              } from "./problem.js";
+
+/**
+ * Warns when a feature is built but `review.command` is still the one `cruze init`
+ * wrote: the foundation never added the project's test commands, so the code
+ * reviewer can only read the code. `initSetting` is the review template init renders.
+ */
+export function reviewCommandProblems(docs             , initSetting        )            {
+  const command = docs.config?.config?.review.command;
+  if (command === undefined || !docs.features.some((feature) => feature.status === "built")) return [];
+  if (JSON.stringify(command) !== JSON.stringify(initCommand(initSetting))) return [];
+  return [warning(PATHS.config, undefined, "review-tests", "review.command is still the one cruze init wrote, so the code reviewer can't run the project's tests; add its test and lint commands as .agents/skills/cruze-formats/config.md shows")];
+}
+
+function initCommand(setting        )          {
+  const parsed          = parseYaml(setting);
+  return (parsed                                             )?.review?.command;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@printpractical/cruze",
-  "version": "0.0.14",
+  "version": "0.0.15",
   "description": "Spec-driven development for coding agents: one living model of the system, small deltas, convergent review.",
   "license": "Apache-2.0",
   "author": "Chris Buchter",

package/skills/envision/architecture.md

@@ -1,6 +1,6 @@
 # Designing the architecture map
 
-The architecture map is what every feature's shape and build read first. It says where things live and how the system runs, for the whole release, and leaves room for the future features. Keep it to what changes how code is written: under 3,000 words.
+The architecture map is what every feature's shape and build read first. It says where things live and how the system runs, for the whole release, and leaves room for the future features. Keep it to what changes how code is written.
 
 Read `.agents/skills/cruze-hexagonal-design/SKILL.md` and its language file, and `.agents/skills/cruze-dependency-approval/SKILL.md`. When a choice needs evidence, such as which library fits or whether a platform supports something, follow `.agents/skills/cruze-research/SKILL.md`.
 

package/skills/formats/SKILL.md

@@ -44,4 +44,4 @@ A later feature that changes an earlier one's behaviour edits that feature's fil
 
 ## Size
 
-A document is for a person to read in one sitting. `cruze validate` warns past 1,500 words for the vision, 3,000 for the architecture and 2,500 for a feature. Cut what the agent decided that the user needn't read, or split the feature.
+A document is for a person to read. Leave out what the agent decided that the user needn't read, and split a feature that has grown past one shape-and-build cycle. No length is enforced, so never trim a document to a word count.

package/skills/formats/config.md

@@ -4,7 +4,7 @@
 
 ```yaml
 version: 2
-cruze: "0.0.14"
+cruze: "0.0.15"
 project: "Console Access"
 
 source: ["src/**/*.rs"]
@@ -44,4 +44,4 @@ review:
 | `layers` | Each layer has a `name`, the `paths` it covers, and `may_import`, the layers it may depend on. |
 | `review.command` | The program and arguments `cruze review` runs to start an agent in a fresh context, with the prompt on standard input. Without it, `cruze review` hands the prompt back for the calling agent to run in a helper of its own. |
 
-A source file belongs to the first layer whose paths match it, and `cruze check` fails an import into a layer its own layer may not import. A layer may import itself, and code outside the project, such as the standard library and dependencies, is always allowed. Keep every source file in a layer: `cruze check` warns on one that isn't.
+A source file belongs to the first layer whose paths match it, and `cruze check` fails an import into a layer its own layer may not import. In a Cargo workspace it follows `use other_crate::…` into that crate, named by its directory. A layer may import itself, and code outside the project, such as the standard library and dependencies, is always allowed. Keep every source file in a layer: `cruze check` warns on one that isn't.

package/skills/review/SKILL.md

@@ -12,7 +12,7 @@ A reviewer who never saw the build reads the code against the approved feature.
 1. **Run the code reviewer** in a fresh context, as `.agents/skills/cruze-roles/SKILL.md` says, on this feature, with the diff from where the feature's branch left `main`: `cruze review code-reviewer --feature <slug> --base <merge-base>`, where the merge base is `git merge-base main HEAD`. Done when you have its report.
 2. **Check each finding** against the code before acting on it. Drop one whose evidence doesn't hold, and say why in one line.
 3. **Sort them.** A finding is the user's when fixing it would change a scenario, the public API they approved, or a significant dependency. Every other finding is yours, blockers included.
-4. **Fix yours.** Fix every blocker, and the concerns worth fixing, each with a test when it is a behaviour. Run the full suite, `cruze check --ci` and `cruze trace <slug>` again. Check your own fixes; don't run the reviewer a second time.
+4. **Fix yours.** Fix every blocker, and the concerns worth fixing, each with a test when it is a behaviour. Correct the documents where they no longer match the code, and show the user each change to an approved one with your report, for them to approve. Run the full suite, `cruze check --ci` and `cruze trace <slug>` again. Check your own fixes; don't run the reviewer a second time.
 5. **Bring the user theirs,** illustrated as `.agents/skills/cruze-asking/SKILL.md` says: the problem in plain words, who meets it and how, and the change to the feature you recommend, as code or output, before and after. Their answer goes through `shape` as a change to the approved feature, then back to build.
 6. **Report and open the pull request.** Tell the user, in a few lines:
    - what the feature now does;

package/skills/roles/code-reviewer.md

@@ -10,7 +10,7 @@ You review the code of one feature before it lands, in a fresh context. You ask
 - The output of `cruze check` and `cruze trace <slug>`.
 - The standards: `.agents/skills/cruze-hexagonal-design/SKILL.md`, its language file for the project's language when one exists, `.agents/skills/cruze-behavioural-testing/SKILL.md` and `.agents/skills/cruze-dependency-approval/SKILL.md`.
 
-You may run the project's tests.
+Run the project's tests and lints, one plain command at a time, with no pipes, `&&`, `;` or redirects: an agent's allowed commands match only a plain command. When a command is refused, say so in your report.
 
 ## Rubric
 
@@ -24,6 +24,7 @@ Review against these items and nothing else. Each finding names one.
 6. **Tests.** No test was weakened, skipped or deleted. Tests drive behaviour through public interfaces rather than restating what a fake was told.
 7. **Idiom.** The code is idiomatic for the language and follows its language file. Each `expect`, `unwrap` or panic has a reason its case can't happen.
 8. **Libraries.** Nothing hand-writes what a mature library does, and every significant dependency is in the architecture or approved.
+9. **Documents.** The feature's public API and stack sketch, and `docs/architecture.md` where the diff touches it, match the code: a port, operation, type, flag or claim the documents state that the code doesn't bear out, or the reverse.
 
 ## Findings
 

package/src/adapters/inbound/cli/commands/install.ts

@@ -15,5 +15,6 @@ export function describeSkillInstall(report: InstallSkillsReport): string[] {
   if (from !== to) lines.push(`Recorded Cruze ${to} in .cruze/config.yaml${from === undefined ? "" : `, up from ${from}`}`);
   if (ci.repinned.length > 0) lines.push(`CI runs ${ci.repinned.join(", ")}`);
   for (const spec of ci.unrecognised) lines.push(`CI runs ${spec}, which Cruze can't move to ${to}; update .github/workflows/ci.yml yourself`);
+  for (const note of report.notes) lines.push(`Note: ${note}`);
   return lines;
 }

package/src/app/use_cases/install_skills.ts

@@ -1,9 +1,12 @@
 import { posix } from "node:path";
 import { CruzeError } from "../../domain/cruze_error.ts";
 import { AGENT_SKILL_HOMES, SHARED_SKILLS_DIR, agentSkillHome, knownAgents } from "../../domain/agent_skill_homes.ts";
+import { reviewSettingTemplate } from "../../domain/scaffold.ts";
 import { SKILL_FILE, installedSkillName, isInstalledSkillName, skillProblems } from "../../domain/skill.ts";
+import { reviewCommandProblems } from "../../domain/validation/review_rules.ts";
 import type { Bundle, BundledSkill } from "../ports/bundle.ts";
 import type { ProjectFiles } from "../ports/project_files.ts";
+import { loadDocs } from "../project_context.ts";
 import { recordVersion, refuseDowngrade, type VersionRecord } from "./record_version.ts";
 
 export interface InstallSkillsRequest {
@@ -18,6 +21,8 @@ export interface InstallSkillsReport {
   linked: Array<{ agent: string; dir: string }>;
   /** The version recorded in .cruze/config.yaml, and the CI workflow's Cruze pin. */
   recorded: VersionRecord;
+  /** What the project still has to change by hand, such as letting the reviewer run its tests. */
+  notes: string[];
 }
 
 /**
@@ -55,7 +60,8 @@ export async function installSkills(
   }
 
   const recorded = await recordVersion(files, bundle.version);
-  return { version: bundle.version, installed: names, removed, linked, recorded };
+  const notes = reviewCommandProblems(await loadDocs(files), await bundle.template(reviewSettingTemplate("claude"))).map((problem) => problem.message);
+  return { version: bundle.version, installed: names, removed, linked, recorded, notes };
 }
 
 function assertValid(skills: BundledSkill[]): void {

package/src/app/use_cases/validate_project.ts

@@ -1,6 +1,8 @@
 import { hasErrors, validateProject } from "../../domain/validation/validate_project.ts";
 import { warning, type Problem } from "../../domain/validation/problem.ts";
 import { PATHS } from "../../domain/project/layout.ts";
+import { reviewSettingTemplate } from "../../domain/scaffold.ts";
+import { reviewCommandProblems } from "../../domain/validation/review_rules.ts";
 import { versionSkew } from "../../domain/versions/cruze_version.ts";
 import type { Bundle } from "../ports/bundle.ts";
 import type { ProjectFiles } from "../ports/project_files.ts";
@@ -13,12 +15,13 @@ export interface ValidateReport {
   problems: Problem[];
 }
 
-/** Checks every document in the project against the cruze-formats rules, and that its skills match this CLI. */
+/** Checks every document in the project against the cruze-formats rules, that its skills match this CLI, and that its reviewer can run the tests. */
 export async function validate(deps: { files: ProjectFiles; bundle: Bundle }): Promise<ValidateReport> {
   const docs = await loadDocs(deps.files);
   const config = docs.config?.config;
   const skew = config === null || config === undefined ? undefined : versionSkew(deps.bundle.version, config.cruze);
-  const problems = [...validateProject(docs), ...(skew === undefined ? [] : [warning(PATHS.config, undefined, "cruze-version", skew.message)])];
+  const review = reviewCommandProblems(docs, await deps.bundle.template(reviewSettingTemplate("claude")));
+  const problems = [...validateProject(docs), ...(skew === undefined ? [] : [warning(PATHS.config, undefined, "cruze-version", skew.message)]), ...review];
   return {
     valid: !hasErrors(problems),
     errors: problems.filter((p) => p.severity === "error").length,

package/src/domain/check/check_source.ts

@@ -37,7 +37,7 @@ export function checkSource(input: CheckInput): CheckFinding[] {
       findings.push({ path, rule: "no-layer", severity: "warning", message: "the file is in no layer, so its imports are unchecked" });
     }
     if (layer !== undefined) {
-      for (const found of importsOf(path, text)) {
+      for (const found of importsOf(path, text, all)) {
         const target = resolveImport(found, all);
         const targetLayer = target === undefined ? undefined : layerOf(target);
         if (target === undefined || targetLayer === undefined || targetLayer.name === layer.name) continue;

package/src/domain/check/imports.ts

@@ -12,11 +12,11 @@ export interface SourceImport {
 const JS = /\.(?:[cm]?[jt]sx?)$/;
 const JS_EXTENSIONS = ["", ".ts", ".tsx", ".js", ".jsx", ".mjs", ".cjs", "/index.ts", "/index.js"];
 
-/** Imports that point inside the project. Imports of libraries and the standard library are left out. */
-export function importsOf(path: string, text: string): SourceImport[] {
+/** Imports that point inside the project, among `files`. Imports of libraries and the standard library are left out. */
+export function importsOf(path: string, text: string, files: readonly string[]): SourceImport[] {
   if (JS.test(path)) return jsImports(path, text);
   if (path.endsWith(".py")) return pythonImports(path, text);
-  if (path.endsWith(".rs")) return rustImportCandidates(path, text).map((i) => ({ ...i, bySuffix: false }));
+  if (path.endsWith(".rs")) return rustImportCandidates(path, text, files).map((i) => ({ ...i, bySuffix: false }));
   if (/\.(?:c|h|cc|cpp|cxx|hh|hpp|hxx)$/.test(path)) return matches(text, /^\s*#\s*include\s+"([^"]+)"/gm, (target) => [target], true);
   if (path.endsWith(".go")) return goImports(text);
   if (/\.(?:java|kt)$/.test(path)) return matches(text, /^import\s+(?:static\s+)?([\w.]+)(?:\.\*)?;?\s*$/gm, (t) => [`${t.replace(/\./g, "/")}.java`, `${t.replace(/\./g, "/")}.kt`], true);

package/src/domain/check/rust_imports.ts

@@ -1,10 +1,14 @@
-/** Resolves Rust `use` paths inside a crate to candidate source files. */
+/** Resolves Rust `use` paths, inside a crate and between a workspace's crates, to candidate source files. */
 
-/** Candidate files for each `use crate::…`, `use super::…` and `use self::…` path in a Rust file. */
-export function rustImportCandidates(path: string, text: string): Array<{ line: number; candidates: string[] }> {
+/**
+ * Candidate files for each `use crate::…`, `use super::…` and `use self::…` path in a Rust file,
+ * and for each `use other_crate::…` that names a library crate among `files`.
+ */
+export function rustImportCandidates(path: string, text: string, files: readonly string[]): Array<{ line: number; candidates: string[] }> {
   const root = crateRoot(path);
   if (root === null) return [];
   const own = moduleSegments(path, root);
+  const crates = libraryCrates(files);
   const results: Array<{ line: number; candidates: string[] }> = [];
   const pattern = /^\s*(?:pub(?:\([^)]*\))?\s+)?use\s+([^;]+);/gms;
   for (const match of text.matchAll(pattern)) {
@@ -12,11 +16,29 @@ export function rustImportCandidates(path: string, text: string): Array<{ line:
     for (const segments of expandUse((match[1] ?? "").replace(/\s+/g, ""))) {
       const absolute = absoluteSegments(segments, own);
       if (absolute !== null) results.push({ line, candidates: candidatesFor(root, absolute) });
+      else {
+        const [head, ...rest] = segments;
+        const other = head === undefined ? undefined : crates.get(head);
+        if (other !== undefined && other !== root) results.push({ line, candidates: candidatesFor(other, rest) });
+      }
     }
   }
   return results;
 }
 
+/**
+ * Each library crate in the project by the name code imports it as: the directory
+ * holding `src/lib.rs`, with hyphens as underscores, as Cargo names it by default.
+ */
+function libraryCrates(files: readonly string[]): Map<string, string> {
+  const crates = new Map<string, string>();
+  for (const file of files) {
+    const match = /^(?:.*\/)?([^/]+)\/src\/lib\.rs$/.exec(file);
+    if (match !== null) crates.set((match[1] ?? "").replace(/-/g, "_"), file.slice(0, -"lib.rs".length));
+  }
+  return crates;
+}
+
 /** The directory holding the crate root: everything up to and including `src/`. */
 function crateRoot(path: string): string | null {
   const index = path.lastIndexOf("src/");

package/src/domain/skill_budget.ts

@@ -11,7 +11,7 @@ export const MAX_FILE_WORDS = 2100;
  * as every fix added rules and nothing was removed; 0.0.14 cut them to this. Lower it when text is
  * cut. Raising it is the maintainer's decision, with the reason in the commit that raises it.
  */
-export const BUNDLE_WORD_BUDGET = 17605;
+export const BUNDLE_WORD_BUDGET = 17725;
 
 /** Data the CLI reads or renders, rather than instructions an agent reads. */
 const NOT_INSTRUCTIONS = /(^|\/)(templates|notes)\//;

package/src/domain/validation/document_rules.ts

@@ -3,34 +3,29 @@ import { findSection, type MarkdownDoc } from "../markdown.ts";
 import { FEATURE_SECTIONS, FEATURE_STATUSES, statusLine, strayScenarioIds, type Feature } from "../project/features.ts";
 import { PATHS } from "../project/layout.ts";
 import type { ProjectDocs } from "../project/project_docs.ts";
-import { error, warning, type Problem } from "./problem.ts";
+import { error, type Problem } from "./problem.ts";
 
-/** Each document's required sections, its size, its scenarios, and leftover template guides. */
+/** Each document's required sections, its scenarios, and leftover template guides. */
 
 const VISION_SECTIONS = ["Problem", "Users", "Release"];
 const ARCHITECTURE_SECTIONS = ["Overview", "Ports", "Adapters", "Runtime"];
 
-/** Words past which a document stops being something a person reads in one sitting. */
-export const WORD_LIMITS = { vision: 1500, architecture: 3000, feature: 2500 } as const;
-
 const GUIDE = /(?<!`)<(?!!--|\/|https?:|br\b)[A-Za-z][^<>\n]*>(?!`)/;
 const PLACEHOLDER = /\{\{[a-z_]+\}\}/;
 
 export function documentProblems(docs: ProjectDocs): Problem[] {
   const problems: Problem[] = [];
-  if (docs.vision !== undefined) problems.push(...shapeOf(PATHS.vision, docs.vision, VISION_SECTIONS, WORD_LIMITS.vision));
-  if (docs.architecture !== undefined) problems.push(...shapeOf(PATHS.architecture, docs.architecture, ARCHITECTURE_SECTIONS, WORD_LIMITS.architecture));
+  if (docs.vision !== undefined) problems.push(...shapeOf(PATHS.vision, docs.vision, VISION_SECTIONS));
+  if (docs.architecture !== undefined) problems.push(...shapeOf(PATHS.architecture, docs.architecture, ARCHITECTURE_SECTIONS));
   for (const feature of docs.features) {
-    problems.push(...shapeOf(feature.path, feature.doc, [...FEATURE_SECTIONS], WORD_LIMITS.feature), ...featureProblems(feature));
+    problems.push(...shapeOf(feature.path, feature.doc, [...FEATURE_SECTIONS]), ...featureProblems(feature));
   }
   problems.push(...duplicateScenarios(docs.features));
   return problems;
 }
 
-function shapeOf(path: string, doc: MarkdownDoc, sections: string[], limit: number): Problem[] {
+function shapeOf(path: string, doc: MarkdownDoc, sections: string[]): Problem[] {
   const problems: Problem[] = sections.filter((title) => findSection(doc, title) === null).map((title) => error(path, undefined, "missing-section", `needs a ## ${title} section`));
-  const words = doc.lines.filter((_, i) => !doc.inFence[i]).join(" ").split(/\s+/).filter((w) => w !== "").length;
-  if (words > limit) problems.push(warning(path, undefined, "too-long", `${words} words, over the ${limit} a person reads in one sitting; cut what the agent decided and the user needn't read, or split it`));
   doc.lines.forEach((line, i) => {
     if (doc.inFence[i]) return;
     const withoutCode = line.replace(/`[^`]*`/g, "");

package/src/domain/validation/review_rules.ts

@@ -0,0 +1,21 @@
+import { parse as parseYaml } from "yaml";
+import { PATHS } from "../project/layout.ts";
+import type { ProjectDocs } from "../project/project_docs.ts";
+import { warning, type Problem } from "./problem.ts";
+
+/**
+ * Warns when a feature is built but `review.command` is still the one `cruze init`
+ * wrote: the foundation never added the project's test commands, so the code
+ * reviewer can only read the code. `initSetting` is the review template init renders.
+ */
+export function reviewCommandProblems(docs: ProjectDocs, initSetting: string): Problem[] {
+  const command = docs.config?.config?.review.command;
+  if (command === undefined || !docs.features.some((feature) => feature.status === "built")) return [];
+  if (JSON.stringify(command) !== JSON.stringify(initCommand(initSetting))) return [];
+  return [warning(PATHS.config, undefined, "review-tests", "review.command is still the one cruze init wrote, so the code reviewer can't run the project's tests; add its test and lint commands as .agents/skills/cruze-formats/config.md shows")];
+}
+
+function initCommand(setting: string): unknown {
+  const parsed: unknown = parseYaml(setting);
+  return (parsed as { review?: { command?: unknown } } | null)?.review?.command;
+}