@principles/pd-cli 1.152.5 → 1.152.7

package/tests/commands/pain-record.test.ts

@@ -566,6 +566,7 @@ describe('pd pain record', () => {
       status: 'unavailable',
       reasonCode: 'session_not_found',
       detail: 'session not present in trajectory.db sessions table',
+      binding: 'unverified',
     } as any);
     const logSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
     const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
@@ -579,6 +580,9 @@ describe('pd pain record', () => {
     expect(jsonOutput.status).toBe('failed');
     expect(jsonOutput.reason).toBe('session_not_found');
     expect(jsonOutput.nextAction).toBeTruthy();
+    // PRI-783: the next action must not recommend retrying the exact path
+    // that just failed (`pd pain record --session`).
+    expect(jsonOutput.nextAction).not.toMatch(/pd pain record --session/);
     // cli-2/cli-5: execution stopped — no service mutation, exit 1
     expect(lastRecordPainInput).toBeNull();
     expect(exitSpy).toHaveBeenCalledWith(1);
@@ -593,6 +597,7 @@ describe('pd pain record', () => {
       status: 'unavailable',
       reasonCode: 'session_not_found',
       detail: 'session not present',
+      binding: 'unverified',
     } as any);
     const logSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
     const exitSpy = mockProcessExit();
@@ -607,70 +612,105 @@ describe('pd pain record', () => {
     exitSpy.mockRestore();
   });
 
-  it('fails before mutation on empty_trajectory (CLI never claims host_context_bound without a verified session)', async () => {
-    // Per Evidence Over Assumption: the CLI does not own session identity
-    // the way the OpenClaw host command context does. Unverified sessions
-    // (any acquisition that does not yield 'available') must refuse before
-    // any LLM/task/candidate mutation.
+  it('degrades to a bound, honest empty-evidence submission on empty_trajectory (PRI-783: a verified session must not be refused)', async () => {
+    // SPEC §8.2: binding failure and evidence failure are separate axes — a
+    // real session with no usable evidence rows is bound + unavailable
+    // (row 4, degrade), not unbound (row 5, refuse). PRI-783 Owner
+    // directive: a correct current session id is sufficient; empty evidence
+    // must not hard-refuse the report.
     vi.mocked(acquireTrajectoryEvidenceFromDb).mockReturnValueOnce({
       status: 'unavailable',
       reasonCode: 'empty_trajectory',
       detail: 'session exists but no usable evidence',
+      binding: 'verified',
     } as any);
     const logSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
     const exitSpy = mockProcessExit();
 
     await handlePainRecord({ reason: 'test pain', session: 'quiet-session', json: true });
 
-    expect(lastRecordPainInput).toBeNull();
+    // Bound correlation with honest empty evidence — nothing fabricated.
+    expect(lastRecordPainInput).not.toBeNull();
+    expect(lastRecordPainInput!.sessionId).toBe('quiet-session');
+    expect(lastRecordPainInput!.hostKind).toBe('openclaw');
+    expect(lastRecordPainInput!.evidence).toEqual([]);
+    expect(lastRecordPainInput!.painIngress.correlation.status).toBe('bound');
+    expect(lastRecordPainInput!.painIngress.evidenceClass).toEqual({
+      status: 'unavailable',
+      reason: 'empty_trajectory',
+    });
+    // Degradation is disclosed, and the report is NOT refused.
     const jsonOutput = JSON.parse(logSpy.mock.calls[0][0]);
-    expect(jsonOutput.status).toBe('failed');
-    expect(jsonOutput.reason).toBe('empty_trajectory');
-    expect(exitSpy).toHaveBeenCalledWith(1);
+    expect(jsonOutput.status).toBe('succeeded');
+    expect(String(jsonOutput.warning ?? '')).toMatch(/empty_trajectory/);
+    expect(exitSpy).not.toHaveBeenCalledWith(1);
 
     logSpy.mockRestore();
     exitSpy.mockRestore();
   });
 
-  it('fails before mutation on evidence_read_failed (no LLM/no task when the CLI cannot verify binding)', async () => {
+  it('degrades on evidence_read_failed when the binding was verified (tables unreadable after the sessions check)', async () => {
+    // SPEC §8.2 note: a real session with an unreadable trajectory is
+    // bound + unavailable — the sessions row was found, only the evidence
+    // read failed.
     vi.mocked(acquireTrajectoryEvidenceFromDb).mockReturnValueOnce({
       status: 'unavailable',
       reasonCode: 'evidence_read_failed',
-      detail: 'trajectory.db unreadable',
+      detail: 'trajectory_tables_unreadable',
+      binding: 'verified',
     } as any);
     const logSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
     const exitSpy = mockProcessExit();
 
     await handlePainRecord({ reason: 'test pain', session: 'sess-x', json: true });
 
-    expect(lastRecordPainInput).toBeNull();
+    expect(lastRecordPainInput).not.toBeNull();
+    expect(lastRecordPainInput!.sessionId).toBe('sess-x');
+    expect(lastRecordPainInput!.evidence).toEqual([]);
+    expect(lastRecordPainInput!.painIngress.correlation.status).toBe('bound');
+    expect(lastRecordPainInput!.painIngress.evidenceClass).toEqual({
+      status: 'unavailable',
+      reason: 'evidence_read_failed',
+    });
     const jsonOutput = JSON.parse(logSpy.mock.calls[0][0]);
-    expect(jsonOutput.status).toBe('failed');
-    expect(jsonOutput.reason).toBe('evidence_read_failed');
-    expect(exitSpy).toHaveBeenCalledWith(1);
+    expect(jsonOutput.status).toBe('succeeded');
+    expect(String(jsonOutput.warning ?? '')).toMatch(/evidence_read_failed/);
+    expect(exitSpy).not.toHaveBeenCalledWith(1);
 
     logSpy.mockRestore();
     exitSpy.mockRestore();
   });
 
-  it('fails before mutation on trajectory_unavailable (CLI cannot fabricate a session)', async () => {
+  it.each([
+    ['trajectory_unavailable', 'no trajectory.db at workspace .state'],
+    ['evidence_read_failed', 'trajectory_db_unreadable: file is not a database'],
+  ] as const)('refuses %s when the binding is UNVERIFIED (PRI-783 review P1: no verified session, no bound claim)', async (reasonCode, detail) => {
+    // PRI-783 review P1: when trajectory.db is missing or unopenable the id
+    // could not be verified. Claiming bound here would let the observability
+    // writer persist the unverified id into a freshly created trajectory.db —
+    // a self-proving loop. It must refuse instead.
     vi.mocked(acquireTrajectoryEvidenceFromDb).mockReturnValueOnce({
       status: 'unavailable',
-      reasonCode: 'trajectory_unavailable',
-      detail: 'no trajectory.db at workspace .state',
+      reasonCode,
+      detail,
+      binding: 'unverified',
     } as any);
     const logSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
+    const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
     const exitSpy = mockProcessExit();
 
     await handlePainRecord({ reason: 'test pain', session: 'sess-x', json: true });
 
+    // Refused before any mutation, with honest next guidance.
     expect(lastRecordPainInput).toBeNull();
     const jsonOutput = JSON.parse(logSpy.mock.calls[0][0]);
     expect(jsonOutput.status).toBe('failed');
-    expect(jsonOutput.reason).toBe('trajectory_unavailable');
+    expect(jsonOutput.reason).toBe(reasonCode);
+    expect(jsonOutput.nextAction).not.toMatch(/pd pain record --session/);
     expect(exitSpy).toHaveBeenCalledWith(1);
 
     logSpy.mockRestore();
+    errorSpy.mockRestore();
     exitSpy.mockRestore();
   });