@principles/pd-cli 1.128.1 → 1.129.0

package/tests/services/rulehost-pipeline-e2e.test.ts

@@ -52,6 +52,18 @@ function writeConfig(workspaceDir: string, content: object): void {
   );
 }
 
+/** Type guard: narrows `unknown` to `Record<string, unknown>` without `as`. */
+function isRecord(value: unknown): value is Record<string, unknown> {
+  return typeof value === 'object' && value !== null && !Array.isArray(value);
+}
+
+function requireRecord(value: unknown, label: string): Record<string, unknown> {
+  if (!isRecord(value)) {
+    throw new Error(`${label} is not a record`);
+  }
+  return value;
+}
+
 /** Config with both artificer+evaluator enabled, pi-ai profile, API key env set. */
 function makeCapabilityOnConfig(workspaceDir: string): object {
   return {
@@ -90,17 +102,19 @@ function makeCapabilityOnConfig(workspaceDir: string): object {
 
 /** Config with artificer disabled (capability must be OFF). */
 function makeArtificerDisabledConfig(workspaceDir: string): object {
-  const cfg = makeCapabilityOnConfig(workspaceDir) as Record<string, unknown>;
-  const internalAgents = cfg.internalAgents as { agents: Record<string, { enabled: boolean; runtimeProfile?: string }> };
-  internalAgents.agents.artificer = { enabled: false };
+  const cfg = makeCapabilityOnConfig(workspaceDir);
+  const internalAgents = requireRecord(Reflect.get(cfg, 'internalAgents'), 'internalAgents');
+  const agents = requireRecord(Reflect.get(internalAgents, 'agents'), 'internalAgents.agents');
+  Reflect.set(agents, 'artificer', { enabled: false });
   return cfg;
 }
 
 /** Config with evaluator disabled (capability must be OFF). */
 function makeEvaluatorDisabledConfig(workspaceDir: string): object {
-  const cfg = makeCapabilityOnConfig(workspaceDir) as Record<string, unknown>;
-  const internalAgents = cfg.internalAgents as { agents: Record<string, { enabled: boolean; runtimeProfile?: string }> };
-  internalAgents.agents.evaluator = { enabled: false };
+  const cfg = makeCapabilityOnConfig(workspaceDir);
+  const internalAgents = requireRecord(Reflect.get(cfg, 'internalAgents'), 'internalAgents');
+  const agents = requireRecord(Reflect.get(internalAgents, 'agents'), 'internalAgents.agents');
+  Reflect.set(agents, 'evaluator', { enabled: false });
   return cfg;
 }
 
@@ -158,10 +172,11 @@ describe('runRuleHost production-wiring (PRI-429) — deterministic, no LLM', ()
   }
 
   /** Extract the single JSON object written to stdout. Fails if not exactly one write. */
-  function parseJsonOutput(): unknown {
+  function parseJsonOutput(): Record<string, unknown> {
     expect(stdoutSpy).toHaveBeenCalledTimes(1);
     const raw = stdoutSpy.mock.calls[0][0] as string;
-    return JSON.parse(raw);
+    const parsed: unknown = JSON.parse(raw);
+    return requireRecord(parsed, 'stdout JSON');
   }
 
   // ── Capability ON: both agents enabled, API key set ──────────────────────
@@ -178,14 +193,11 @@ describe('runRuleHost production-wiring (PRI-429) — deterministic, no LLM', ()
     });
 
     const output = parseJsonOutput();
-    expect(typeof output).toBe('object');
-    expect(output).not.toBeNull();
-    const obj = output as { status: string; codeRuleCapability?: { enabled: boolean; disabledReason?: string }; capabilityStatus?: string };
-    expect(obj.status).toBe('dry_run');
-    expect(obj.codeRuleCapability).toBeDefined();
-    expect(obj.codeRuleCapability?.enabled).toBe(true);
-    expect(obj.codeRuleCapability?.disabledReason).toBeUndefined();
-    expect(obj.capabilityStatus).toContain('ON');
+    const codeRuleCapability = requireRecord(output.codeRuleCapability, 'codeRuleCapability');
+    expect(output.status).toBe('dry_run');
+    expect(codeRuleCapability.enabled).toBe(true);
+    expect(codeRuleCapability.disabledReason).toBeUndefined();
+    expect(String(output.capabilityStatus)).toContain('ON');
     // exitCode must NOT be set for dry_run success
     expect(process.exitCode).toBeUndefined();
   });
@@ -203,16 +215,13 @@ describe('runRuleHost production-wiring (PRI-429) — deterministic, no LLM', ()
     await handleRunRuleHost({ workspace, painId: 'pain-flag-default', dryRun: true, json: true });
 
     const output = parseJsonOutput();
-    // PRI-435 (CodeRabbit P3): narrow unknown before property access
-    expect(typeof output).toBe('object');
-    expect(output).not.toBeNull();
-    const obj = output as { status: string; codeRuleCapability?: { enabled: boolean; disabledReason?: string }; capabilityStatus?: string };
-    expect(obj.status).toBe('dry_run');
+    const codeRuleCapability = requireRecord(output.codeRuleCapability, 'codeRuleCapability');
+    expect(output.status).toBe('dry_run');
     // PRI-435: code_rule_capability is now a core flag — defaults ON even when omitted from config.
     // It cannot be disabled by config. The capability is ON when artificer+evaluator are configured.
-    expect(obj.codeRuleCapability).toEqual(expect.objectContaining({ enabled: true }));
-    expect(obj.codeRuleCapability?.disabledReason).toBeUndefined();
-    expect(String(obj.capabilityStatus)).toContain('ON');
+    expect(codeRuleCapability).toEqual(expect.objectContaining({ enabled: true }));
+    expect(codeRuleCapability.disabledReason).toBeUndefined();
+    expect(String(output.capabilityStatus)).toContain('ON');
   });
 
   it('PRI-435: explicit emergency disable via code_rule_capability.enabled=false is observable', async () => {
@@ -229,16 +238,13 @@ describe('runRuleHost production-wiring (PRI-429) — deterministic, no LLM', ()
     await handleRunRuleHost({ workspace, painId: 'pain-emergency-disable', dryRun: true, json: true });
 
     const output = parseJsonOutput();
-    // PRI-435 (CodeRabbit P3): narrow unknown before property access
-    expect(typeof output).toBe('object');
-    expect(output).not.toBeNull();
-    const obj = output as { status: string; codeRuleCapability?: { enabled: boolean; disabledReason?: string }; capabilityStatus?: string };
-    expect(obj.status).toBe('dry_run');
+    const codeRuleCapability = requireRecord(output.codeRuleCapability, 'codeRuleCapability');
+    expect(output.status).toBe('dry_run');
     // PRI-435: Emergency disable via code_rule_capability.enabled=false is preserved.
     // The capability is OFF with a structured reason.
-    expect(obj.codeRuleCapability).toEqual(expect.objectContaining({ enabled: false }));
-    expect(String(obj.codeRuleCapability?.disabledReason)).toContain('feature flag');
-    expect(String(obj.capabilityStatus)).toContain('OFF');
+    expect(codeRuleCapability).toEqual(expect.objectContaining({ enabled: false }));
+    expect(String(codeRuleCapability.disabledReason)).toContain('feature flag');
+    expect(String(output.capabilityStatus)).toContain('OFF');
   });
 
   it('reports the resolved runtime profile for every executed agent', async () => {
@@ -271,10 +277,17 @@ describe('runRuleHost production-wiring (PRI-429) — deterministic, no LLM', ()
 
     await handleRunRuleHost({ workspace, painId: 'pain-disabled-philosopher', confirm: true, json: true });
 
+    // PRI-461: readiness gate catches disabled required agents BEFORE adapter
+    // construction, returning status='refused' with a structured reason instead
+    // of the old opaque 'agent_runtime_resolution_failed' error.
     const output = parseJsonOutput();
-    expect(output.status).toBe('failed');
-    expect(output.reason).toBe('agent_runtime_resolution_failed');
-    expect(String(output.message)).toContain('philosopher');
+    expect(isRecord(output)).toBe(true);
+    if (!isRecord(output)) {
+      throw new Error('output is not a record');
+    }
+    expect(output.status).toBe('refused');
+    expect(String(output.reason)).toContain('philosopher');
+    expect(typeof output.nextAction).toBe('string');
     expect(process.exitCode).toBe(1);
     expect(fs.existsSync(path.join(workspace, '.state', 'runtime-v2.sqlite'))).toBe(false);
   });
@@ -308,10 +321,10 @@ describe('runRuleHost production-wiring (PRI-429) — deterministic, no LLM', ()
     });
 
     const output = parseJsonOutput();
-    const obj = output as { status: string; codeRuleCapability: { enabled: boolean; disabledReason?: string } };
-    expect(obj.status).toBe('dry_run');
-    expect(obj.codeRuleCapability.enabled).toBe(false);
-    expect(obj.codeRuleCapability.disabledReason).toContain('artificer');
+    const codeRuleCapability = requireRecord(output.codeRuleCapability, 'codeRuleCapability');
+    expect(output.status).toBe('dry_run');
+    expect(codeRuleCapability.enabled).toBe(false);
+    expect(String(codeRuleCapability.disabledReason)).toContain('artificer');
   });
 
   // ── Capability OFF: evaluator disabled ───────────────────────────────────
@@ -328,10 +341,10 @@ describe('runRuleHost production-wiring (PRI-429) — deterministic, no LLM', ()
     });
 
     const output = parseJsonOutput();
-    const obj = output as { status: string; codeRuleCapability: { enabled: boolean; disabledReason?: string } };
-    expect(obj.status).toBe('dry_run');
-    expect(obj.codeRuleCapability.enabled).toBe(false);
-    expect(obj.codeRuleCapability.disabledReason).toContain('evaluator');
+    const codeRuleCapability = requireRecord(output.codeRuleCapability, 'codeRuleCapability');
+    expect(output.status).toBe('dry_run');
+    expect(codeRuleCapability.enabled).toBe(false);
+    expect(String(codeRuleCapability.disabledReason)).toContain('evaluator');
   });
 
   // ── Capability OFF: API key not set ──────────────────────────────────────
@@ -393,10 +406,11 @@ describe('runRuleHost production-wiring (PRI-429) — deterministic, no LLM', ()
     });
 
     const output = parseJsonOutput();
-    const obj = output as { status: string; codeRuleCapability: { enabled: boolean; disabledReason?: string } };
-    expect(obj.status).toBe('dry_run');
-    expect(obj.codeRuleCapability.enabled).toBe(false);
-    expect(obj.codeRuleCapability.disabledReason).toContain('apiKeyEnv');
+    const codeRuleCapability = requireRecord(output.codeRuleCapability, 'codeRuleCapability');
+    expect(output.status).toBe('dry_run');
+    expect(codeRuleCapability.enabled).toBe(false);
+    expect(String(codeRuleCapability.disabledReason)).toContain('TEST_RULEHOST_ARTIFICER_KEY');
+    expect(String(codeRuleCapability.disabledReason)).toContain('not set');
   });
 
   // ── CLI gate: mutual exclusivity ─────────────────────────────────────────
@@ -414,10 +428,9 @@ describe('runRuleHost production-wiring (PRI-429) — deterministic, no LLM', ()
     });
 
     const output = parseJsonOutput();
-    const obj = output as { status: string; reason: string; nextAction: string };
-    expect(obj.status).toBe('failed');
-    expect(obj.reason).toContain('mutually exclusive');
-    expect(obj.nextAction).toBeTruthy();
+    expect(output.status).toBe('failed');
+    expect(String(output.reason)).toContain('mutually exclusive');
+    expect(output.nextAction).toBeTruthy();
     expect(process.exitCode).toBe(1);
   });
 
@@ -435,10 +448,9 @@ describe('runRuleHost production-wiring (PRI-429) — deterministic, no LLM', ()
     });
 
     const output = parseJsonOutput();
-    const obj = output as { status: string; reason: string; nextAction: string };
-    expect(obj.status).toBe('failed');
-    expect(obj.reason).toContain('painId');
-    expect(obj.nextAction).toBeTruthy();
+    expect(output.status).toBe('failed');
+    expect(String(output.reason)).toContain('painId');
+    expect(output.nextAction).toBeTruthy();
     expect(process.exitCode).toBe(1);
   });
 
@@ -480,8 +492,7 @@ describe('runRuleHost production-wiring (PRI-429) — deterministic, no LLM', ()
     });
 
     const output = parseJsonOutput();
-    const obj = output as { status: string };
-    expect(obj.status).toBe('dry_run');
+    expect(output.status).toBe('dry_run');
     // Must NOT set exitCode for dry_run
     expect(process.exitCode).toBeUndefined();
   });
@@ -501,10 +512,9 @@ describe('runRuleHost production-wiring (PRI-429) — deterministic, no LLM', ()
     });
 
     const output = parseJsonOutput();
-    const obj = output as { status: string; reason: string; nextAction: string };
-    expect(obj.status).toBe('failed');
-    expect(obj.reason).toContain('unsupported channel');
-    expect(obj.nextAction).toBeTruthy();
+    expect(output.status).toBe('failed');
+    expect(String(output.reason)).toContain('unsupported channel');
+    expect(output.nextAction).toBeTruthy();
     expect(process.exitCode).toBe(1);
   });
 });

package/dist/commands/central-sync.d.ts

@@ -1,10 +0,0 @@
-/**
- * pd central sync command implementation.
- *
- * Usage: pd central sync
- *
- * Triggers a sync cycle via CentralDatabase.syncAll() and reports
- * per-workspace sync results with exit code 0 on success, non-zero on failure.
- */
-export declare function handleCentralSync(): Promise<void>;
-//# sourceMappingURL=central-sync.d.ts.map

package/dist/commands/central-sync.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"central-sync.d.ts","sourceRoot":"","sources":["../../src/commands/central-sync.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAeH,wBAAsB,iBAAiB,IAAI,OAAO,CAAC,IAAI,CAAC,CAqBvD"}

package/dist/commands/central-sync.js

@@ -1,32 +0,0 @@
-/**
- * pd central sync command implementation.
- *
- * Usage: pd central sync
- *
- * Triggers a sync cycle via CentralDatabase.syncAll() and reports
- * per-workspace sync results with exit code 0 on success, non-zero on failure.
- */
-async function loadCentralDatabase() {
-    const importModule = Function('specifier', 'return import(specifier)');
-    return importModule('../../../openclaw-plugin/src/service/central-database.js');
-}
-export async function handleCentralSync() {
-    try {
-        const { CentralDatabase } = await loadCentralDatabase();
-        const centralDb = new CentralDatabase();
-        const results = centralDb.syncAll();
-        const totalRecords = Array.from(results.values()).reduce((sum, count) => sum + count, 0);
-        const workspaceCount = results.size;
-        console.log(`Sync complete — ${totalRecords} records across ${workspaceCount} workspace(s).`);
-        for (const [workspaceName, count] of results.entries()) {
-            console.log(`  ${workspaceName}: ${count} records`);
-        }
-        centralDb.dispose();
-    }
-    catch (err) {
-        const message = err instanceof Error ? err.message : String(err);
-        console.error(`Error: Sync failed — ${message}`);
-        process.exit(1);
-    }
-}
-//# sourceMappingURL=central-sync.js.map

package/dist/commands/central-sync.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"central-sync.js","sourceRoot":"","sources":["../../src/commands/central-sync.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,KAAK,UAAU,mBAAmB;IAIhC,MAAM,YAAY,GAAG,QAAQ,CAAC,WAAW,EAAE,0BAA0B,CAKnE,CAAC;IACH,OAAO,YAAY,CAAC,0DAA0D,CAAC,CAAC;AAClF,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,iBAAiB;IACrC,IAAI,CAAC;QACH,MAAM,EAAE,eAAe,EAAE,GAAG,MAAM,mBAAmB,EAAE,CAAC;QACxD,MAAM,SAAS,GAAG,IAAI,eAAe,EAAE,CAAC;QACxC,MAAM,OAAO,GAAG,SAAS,CAAC,OAAO,EAAE,CAAC;QAEpC,MAAM,YAAY,GAAG,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC,CAAC,MAAM,CAAC,CAAC,GAAG,EAAE,KAAK,EAAE,EAAE,CAAC,GAAG,GAAG,KAAK,EAAE,CAAC,CAAC,CAAC;QACzF,MAAM,cAAc,GAAG,OAAO,CAAC,IAAI,CAAC;QAEpC,OAAO,CAAC,GAAG,CAAC,mBAAmB,YAAY,mBAAmB,cAAc,gBAAgB,CAAC,CAAC;QAE9F,KAAK,MAAM,CAAC,aAAa,EAAE,KAAK,CAAC,IAAI,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC;YACvD,OAAO,CAAC,GAAG,CAAC,KAAK,aAAa,KAAK,KAAK,UAAU,CAAC,CAAC;QACtD,CAAC;QAED,SAAS,CAAC,OAAO,EAAE,CAAC;IACtB,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,OAAO,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;QACjE,OAAO,CAAC,KAAK,CAAC,wBAAwB,OAAO,EAAE,CAAC,CAAC;QACjD,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;AACH,CAAC"}

package/src/commands/central-sync.ts

@@ -1,44 +0,0 @@
-/**
- * pd central sync command implementation.
- *
- * Usage: pd central sync
- *
- * Triggers a sync cycle via CentralDatabase.syncAll() and reports
- * per-workspace sync results with exit code 0 on success, non-zero on failure.
- */
-
-async function loadCentralDatabase(): Promise<{ CentralDatabase: new () => {
-  syncAll(): Map<string, number>;
-  dispose(): void;
-} }> {
-  const importModule = Function('specifier', 'return import(specifier)') as (specifier: string) => Promise<{
-    CentralDatabase: new () => {
-      syncAll(): Map<string, number>;
-      dispose(): void;
-    };
-  }>;
-  return importModule('../../../openclaw-plugin/src/service/central-database.js');
-}
-
-export async function handleCentralSync(): Promise<void> {
-  try {
-    const { CentralDatabase } = await loadCentralDatabase();
-    const centralDb = new CentralDatabase();
-    const results = centralDb.syncAll();
-
-    const totalRecords = Array.from(results.values()).reduce((sum, count) => sum + count, 0);
-    const workspaceCount = results.size;
-
-    console.log(`Sync complete — ${totalRecords} records across ${workspaceCount} workspace(s).`);
-
-    for (const [workspaceName, count] of results.entries()) {
-      console.log(`  ${workspaceName}: ${count} records`);
-    }
-
-    centralDb.dispose();
-  } catch (err) {
-    const message = err instanceof Error ? err.message : String(err);
-    console.error(`Error: Sync failed — ${message}`);
-    process.exit(1);
-  }
-}