@principles/pd-cli 1.128.0 → 1.128.2

package/tests/commands/cli-skill-contract.test.ts

@@ -0,0 +1,121 @@
+/**
+ * PRI-455: SKILL ↔ CLI contract test.
+ *
+ * Parses SKILL.md templates for `pd <command>` references and verifies
+ * that each referenced command path exists in the CLI command tree.
+ *
+ * This prevents SKILL templates from referencing deleted or renamed commands.
+ *
+ * Covers BOTH `en` and `zh` skill directories so bilingual template updates
+ * are validated. Fails explicitly (does not silently skip) when the expected
+ * skills directory is missing — a missing directory is a real contract break.
+ */
+import { describe, it, expect } from 'vitest';
+import { execFileSync } from 'node:child_process';
+import { readFileSync, readdirSync, existsSync } from 'node:fs';
+import { join, resolve } from 'node:path';
+import { getBuiltPdCliPath } from '../helpers/pd-cli-path.js';
+
+/**
+ * Resolve the skills directory for a given language.
+ * Tests run from packages/pd-cli, so the plugin templates live one level up.
+ */
+function resolveSkillsDir(lang: 'en' | 'zh'): string {
+  return resolve(
+    process.cwd(),
+    '..',
+    'openclaw-plugin',
+    'templates',
+    'langs',
+    lang,
+    'skills',
+  );
+}
+
+/**
+ * Extract `pd <command> [subcommand] ...` patterns from SKILL.md content.
+ * Matches lines like:
+ *   pd pain record --reason ...
+ *   pd runtime probe --json
+ *   pd candidate list --workspace ...
+ * Returns full command paths (e.g. "pain record", "runtime probe").
+ */
+function extractPdCommands(markdown: string): string[] {
+  const commands: string[] = [];
+  // Match `pd <words>` in code blocks and inline code
+  const pdPattern = /`pd\s+([\w-]+(?:\s+[\w-]+)*)/g;
+  let match: RegExpExecArray | null;
+  while ((match = pdPattern.exec(markdown)) !== null) {
+    // Take up to 3 path segments (e.g. "runtime internalization queue")
+    const parts = match[1].split(/\s+/).slice(0, 3);
+    // Filter out flags and options
+    const cleanParts = parts.filter((p) => !p.startsWith('--') && !p.startsWith('<'));
+    if (cleanParts.length > 0) {
+      commands.push(cleanParts.join(' '));
+    }
+  }
+  return [...new Set(commands)];
+}
+
+/**
+ * Check if a command path exists by running `pd <path> --help`.
+ * Returns true if the command is registered (exit code 0 or help output contains "Usage:").
+ */
+function commandExists(commandPath: string): boolean {
+  const args = commandPath.split(' ');
+  try {
+    const output = execFileSync('node', [getBuiltPdCliPath(), ...args, '--help'], {
+      encoding: 'utf8',
+      cwd: process.cwd(),
+      timeout: 10000,
+      stdio: ['pipe', 'pipe', 'pipe'],
+    });
+    return output.includes('Usage:') || output.includes('Options:');
+  } catch {
+    return false;
+  }
+}
+
+// Collect (lang, skill, command) triples across both en and zh.
+// A missing skills directory is a real contract break — fail explicitly.
+const LANGS = ['en', 'zh'] as const;
+const skillCommandPairs: { lang: string; skill: string; command: string }[] = [];
+const missingLangDirs: string[] = [];
+
+for (const lang of LANGS) {
+  const skillsDir = resolveSkillsDir(lang);
+  if (!existsSync(skillsDir)) {
+    missingLangDirs.push(lang);
+    continue;
+  }
+  const skillDirs = readdirSync(skillsDir).filter((dir) =>
+    existsSync(join(skillsDir, dir, 'SKILL.md')),
+  );
+  for (const dir of skillDirs) {
+    const skillPath = join(skillsDir, dir, 'SKILL.md');
+    const content = readFileSync(skillPath, 'utf8');
+    const commands = extractPdCommands(content);
+    for (const cmd of commands) {
+      skillCommandPairs.push({ lang, skill: dir, command: cmd });
+    }
+  }
+}
+
+describe('PRI-455: SKILL ↔ CLI contract', () => {
+  it('both en and zh skills directories exist', () => {
+    // Explicit failure instead of silent skip — a missing directory means
+    // the contract is no longer being validated for that language.
+    expect(missingLangDirs, `missing skills directories: ${missingLangDirs.join(', ')}`).toEqual([]);
+  });
+
+  it('found SKILL files that reference pd commands', () => {
+    expect(skillCommandPairs.length).toBeGreaterThan(0);
+  });
+
+  // Test each SKILL-referenced command exists in the CLI
+  for (const { lang, skill, command } of skillCommandPairs) {
+    it(`[${lang}] SKILL "${skill}" references valid command: pd ${command}`, () => {
+      expect(commandExists(command)).toBe(true);
+    });
+  }
+});

package/tests/commands/runtime-internalization.test.ts

@@ -46,8 +46,8 @@ describe('CLI command tree: pd runtime internalization', () => {
     expect(output).toContain('--json');
   });
 
-  it('runtime subcommand list includes internalization', () => {
+  it('runtime subcommand list does NOT include internalization (PRI-455: hidden from --help)', () => {
     const output = runPdHelp(['runtime', '--help']);
-    expect(output).toMatch(/internalization\s/);
+    expect(output).not.toMatch(/internalization\s/);
   });
 });

package/dist/commands/central-sync.d.ts

@@ -1,10 +0,0 @@
-/**
- * pd central sync command implementation.
- *
- * Usage: pd central sync
- *
- * Triggers a sync cycle via CentralDatabase.syncAll() and reports
- * per-workspace sync results with exit code 0 on success, non-zero on failure.
- */
-export declare function handleCentralSync(): Promise<void>;
-//# sourceMappingURL=central-sync.d.ts.map

package/dist/commands/central-sync.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"central-sync.d.ts","sourceRoot":"","sources":["../../src/commands/central-sync.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAeH,wBAAsB,iBAAiB,IAAI,OAAO,CAAC,IAAI,CAAC,CAqBvD"}

package/dist/commands/central-sync.js

@@ -1,32 +0,0 @@
-/**
- * pd central sync command implementation.
- *
- * Usage: pd central sync
- *
- * Triggers a sync cycle via CentralDatabase.syncAll() and reports
- * per-workspace sync results with exit code 0 on success, non-zero on failure.
- */
-async function loadCentralDatabase() {
-    const importModule = Function('specifier', 'return import(specifier)');
-    return importModule('../../../openclaw-plugin/src/service/central-database.js');
-}
-export async function handleCentralSync() {
-    try {
-        const { CentralDatabase } = await loadCentralDatabase();
-        const centralDb = new CentralDatabase();
-        const results = centralDb.syncAll();
-        const totalRecords = Array.from(results.values()).reduce((sum, count) => sum + count, 0);
-        const workspaceCount = results.size;
-        console.log(`Sync complete — ${totalRecords} records across ${workspaceCount} workspace(s).`);
-        for (const [workspaceName, count] of results.entries()) {
-            console.log(`  ${workspaceName}: ${count} records`);
-        }
-        centralDb.dispose();
-    }
-    catch (err) {
-        const message = err instanceof Error ? err.message : String(err);
-        console.error(`Error: Sync failed — ${message}`);
-        process.exit(1);
-    }
-}
-//# sourceMappingURL=central-sync.js.map

package/dist/commands/central-sync.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"central-sync.js","sourceRoot":"","sources":["../../src/commands/central-sync.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,KAAK,UAAU,mBAAmB;IAIhC,MAAM,YAAY,GAAG,QAAQ,CAAC,WAAW,EAAE,0BAA0B,CAKnE,CAAC;IACH,OAAO,YAAY,CAAC,0DAA0D,CAAC,CAAC;AAClF,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,iBAAiB;IACrC,IAAI,CAAC;QACH,MAAM,EAAE,eAAe,EAAE,GAAG,MAAM,mBAAmB,EAAE,CAAC;QACxD,MAAM,SAAS,GAAG,IAAI,eAAe,EAAE,CAAC;QACxC,MAAM,OAAO,GAAG,SAAS,CAAC,OAAO,EAAE,CAAC;QAEpC,MAAM,YAAY,GAAG,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC,CAAC,MAAM,CAAC,CAAC,GAAG,EAAE,KAAK,EAAE,EAAE,CAAC,GAAG,GAAG,KAAK,EAAE,CAAC,CAAC,CAAC;QACzF,MAAM,cAAc,GAAG,OAAO,CAAC,IAAI,CAAC;QAEpC,OAAO,CAAC,GAAG,CAAC,mBAAmB,YAAY,mBAAmB,cAAc,gBAAgB,CAAC,CAAC;QAE9F,KAAK,MAAM,CAAC,aAAa,EAAE,KAAK,CAAC,IAAI,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC;YACvD,OAAO,CAAC,GAAG,CAAC,KAAK,aAAa,KAAK,KAAK,UAAU,CAAC,CAAC;QACtD,CAAC;QAED,SAAS,CAAC,OAAO,EAAE,CAAC;IACtB,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,OAAO,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;QACjE,OAAO,CAAC,KAAK,CAAC,wBAAwB,OAAO,EAAE,CAAC,CAAC;QACjD,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAClB,CAAC;AACH,CAAC"}

package/src/commands/central-sync.ts

@@ -1,44 +0,0 @@
-/**
- * pd central sync command implementation.
- *
- * Usage: pd central sync
- *
- * Triggers a sync cycle via CentralDatabase.syncAll() and reports
- * per-workspace sync results with exit code 0 on success, non-zero on failure.
- */
-
-async function loadCentralDatabase(): Promise<{ CentralDatabase: new () => {
-  syncAll(): Map<string, number>;
-  dispose(): void;
-} }> {
-  const importModule = Function('specifier', 'return import(specifier)') as (specifier: string) => Promise<{
-    CentralDatabase: new () => {
-      syncAll(): Map<string, number>;
-      dispose(): void;
-    };
-  }>;
-  return importModule('../../../openclaw-plugin/src/service/central-database.js');
-}
-
-export async function handleCentralSync(): Promise<void> {
-  try {
-    const { CentralDatabase } = await loadCentralDatabase();
-    const centralDb = new CentralDatabase();
-    const results = centralDb.syncAll();
-
-    const totalRecords = Array.from(results.values()).reduce((sum, count) => sum + count, 0);
-    const workspaceCount = results.size;
-
-    console.log(`Sync complete — ${totalRecords} records across ${workspaceCount} workspace(s).`);
-
-    for (const [workspaceName, count] of results.entries()) {
-      console.log(`  ${workspaceName}: ${count} records`);
-    }
-
-    centralDb.dispose();
-  } catch (err) {
-    const message = err instanceof Error ? err.message : String(err);
-    console.error(`Error: Sync failed — ${message}`);
-    process.exit(1);
-  }
-}