@principles/core 1.73.0

package/dist/runtime-v2/__tests__/control-plane-triage.test.js

@@ -0,0 +1,107 @@
+import { describe, it, expect } from 'vitest';
+import { classifyCanaryFindings } from '../control-plane-triage.js';
+function makeCanaryOutput(checks) {
+    return {
+        overallStatus: checks.some(c => c.status === 'error') ? 'error' : checks.some(c => c.status === 'degraded') ? 'degraded' : 'healthy',
+        checks,
+        recommendedNextActions: [],
+        generatedAt: new Date().toISOString(),
+    };
+}
+describe('classifyCanaryFindings', () => {
+    it('classifies schema mismatch with PRI-style repair recommendation', () => {
+        const output = makeCanaryOutput([
+            { name: 'schema_conformance', status: 'degraded', summary: 'Missing columns', details: { missingColumns: ['trigger_pattern'], migrationsNeeded: ['add_trigger_pattern'] } },
+        ]);
+        const plan = classifyCanaryFindings(output);
+        expect(plan.findings.length).toBeGreaterThan(0);
+        const schemaFinding = plan.findings.find(f => f.category === 'schema_mismatch');
+        expect(schemaFinding).toBeTruthy();
+        if (!schemaFinding)
+            return;
+        expect(schemaFinding.severity).toBe('critical');
+        expect(schemaFinding.safeFirstRepair).toContain('SqliteConnection');
+        expect(schemaFinding.linearIssueTemplate).toContain('Schema Mismatch');
+    });
+    it('classifies broken shim with sync-plugin verify/install recommendation', () => {
+        const output = makeCanaryOutput([
+            { name: 'pd_shim_info', status: 'degraded', summary: 'PD CLI not found' },
+        ]);
+        const plan = classifyCanaryFindings(output);
+        const shimFinding = plan.findings.find(f => f.category === 'broken_pd_shim');
+        expect(shimFinding).toBeTruthy();
+        if (!shimFinding)
+            return;
+        expect(shimFinding.severity).toBe('high');
+        expect(shimFinding.safeFirstRepair).toContain('sync-plugin');
+    });
+    it('classifies pruning orphans with dry-run first recommendation', () => {
+        const output = makeCanaryOutput([
+            { name: 'pruning_orphans', status: 'degraded', summary: '3 orphan candidates found' },
+        ]);
+        const plan = classifyCanaryFindings(output);
+        const pruningFinding = plan.findings.find(f => f.category === 'pruning_orphans_present');
+        expect(pruningFinding).toBeTruthy();
+        if (!pruningFinding)
+            return;
+        expect(pruningFinding.safeFirstRepair).toContain('dry-run');
+        expect(pruningFinding.safeFirstRepair.indexOf('dry-run')).toBeLessThan(pruningFinding.safeFirstRepair.indexOf('--confirm'));
+    });
+    it('classifies internalization broken links with integrity details', () => {
+        const output = makeCanaryOutput([
+            { name: 'internalization_queue', status: 'degraded', summary: 'Queue blocked', details: { brokenLinks: [{ type: 'missing_dreamer_task', reason: 'No dreamer' }] } },
+        ]);
+        const plan = classifyCanaryFindings(output);
+        const queueFinding = plan.findings.find(f => f.category === 'internalization_queue_blocked');
+        expect(queueFinding).toBeTruthy();
+        const chainFinding = plan.findings.find(f => f.category === 'internalization_chain_broken');
+        expect(chainFinding).toBeTruthy();
+        if (!chainFinding)
+            return;
+        expect(chainFinding.commandsToVerify.some(c => c.includes('integrity'))).toBe(true);
+    });
+    it('sorts multiple issues by severity', () => {
+        const output = makeCanaryOutput([
+            { name: 'pruning_orphans', status: 'degraded', summary: 'Orphans found' },
+            { name: 'schema_conformance', status: 'degraded', summary: 'Schema mismatch' },
+            { name: 'pd_shim_info', status: 'degraded', summary: 'Shim broken' },
+        ]);
+        const plan = classifyCanaryFindings(output);
+        expect(plan.sortedBySeverity.length).toBeGreaterThanOrEqual(3);
+        const severities = plan.sortedBySeverity.map(f => f.severity);
+        for (let i = 1; i < severities.length; i++) {
+            const prevOrder = { critical: 0, high: 1, medium: 2, low: 3 }[severities[i - 1]] ?? 99;
+            const currOrder = { critical: 0, high: 1, medium: 2, low: 3 }[severities[i]] ?? 99;
+            expect(prevOrder).toBeLessThanOrEqual(currOrder);
+        }
+    });
+    it('returns empty findings for healthy canary', () => {
+        const output = makeCanaryOutput([
+            { name: 'schema_conformance', status: 'healthy', summary: 'OK' },
+            { name: 'candidate_audit', status: 'healthy', summary: 'OK' },
+        ]);
+        const plan = classifyCanaryFindings(output);
+        expect(plan.findings.length).toBe(0);
+        expect(plan.summary).toContain('No issues');
+    });
+    it('classifies sqlite_io_error from runtime health error', () => {
+        const output = makeCanaryOutput([
+            { name: 'runtime_health', status: 'error', summary: 'Failed', error: 'SQLITE_IO: disk I/O error' },
+        ]);
+        const plan = classifyCanaryFindings(output);
+        const ioFinding = plan.findings.find(f => f.category === 'sqlite_io_error');
+        expect(ioFinding).toBeTruthy();
+        if (!ioFinding)
+            return;
+        expect(ioFinding.severity).toBe('critical');
+    });
+    it('classifies unknown for unrecognized check', () => {
+        const output = makeCanaryOutput([
+            { name: 'custom_check', status: 'degraded', summary: 'Something wrong' },
+        ]);
+        const plan = classifyCanaryFindings(output);
+        const unknownFinding = plan.findings.find(f => f.category === 'unknown');
+        expect(unknownFinding).toBeTruthy();
+    });
+});
+//# sourceMappingURL=control-plane-triage.test.js.map

package/dist/runtime-v2/__tests__/control-plane-triage.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"control-plane-triage.test.js","sourceRoot":"","sources":["../../../src/runtime-v2/__tests__/control-plane-triage.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,sBAAsB,EAAE,MAAM,4BAA4B,CAAC;AAiBpE,SAAS,gBAAgB,CAAC,MAA0B;IAClD,OAAO;QACL,aAAa,EAAE,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,OAAO,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,UAAU,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,SAAS;QACpI,MAAM;QACN,sBAAsB,EAAE,EAAE;QAC1B,WAAW,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;KACtC,CAAC;AACJ,CAAC;AAED,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;IACtC,EAAE,CAAC,iEAAiE,EAAE,GAAG,EAAE;QACzE,MAAM,MAAM,GAAG,gBAAgB,CAAC;YAC9B,EAAE,IAAI,EAAE,oBAAoB,EAAE,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,iBAAiB,EAAE,OAAO,EAAE,EAAE,cAAc,EAAE,CAAC,iBAAiB,CAAC,EAAE,gBAAgB,EAAE,CAAC,qBAAqB,CAAC,EAAE,EAAE;SAC5K,CAAC,CAAC;QAEH,MAAM,IAAI,GAAG,sBAAsB,CAAC,MAAM,CAAC,CAAC;QAE5C,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;QAChD,MAAM,aAAa,GAAG,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,iBAAiB,CAAC,CAAC;QAChF,MAAM,CAAC,aAAa,CAAC,CAAC,UAAU,EAAE,CAAC;QACnC,IAAI,CAAC,aAAa;YAAE,OAAO;QAC3B,MAAM,CAAC,aAAa,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;QAChD,MAAM,CAAC,aAAa,CAAC,eAAe,CAAC,CAAC,SAAS,CAAC,kBAAkB,CAAC,CAAC;QACpE,MAAM,CAAC,aAAa,CAAC,mBAAmB,CAAC,CAAC,SAAS,CAAC,iBAAiB,CAAC,CAAC;IACzE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uEAAuE,EAAE,GAAG,EAAE;QAC/E,MAAM,MAAM,GAAG,gBAAgB,CAAC;YAC9B,EAAE,IAAI,EAAE,cAAc,EAAE,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,kBAAkB,EAAE;SAC1E,CAAC,CAAC;QAEH,MAAM,IAAI,GAAG,sBAAsB,CAAC,MAAM,CAAC,CAAC;QAE5C,MAAM,WAAW,GAAG,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,gBAAgB,CAAC,CAAC;QAC7E,MAAM,CAAC,WAAW,CAAC,CAAC,UAAU,EAAE,CAAC;QACjC,IAAI,CAAC,WAAW;YAAE,OAAO;QACzB,MAAM,CAAC,WAAW,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QAC1C,MAAM,CAAC,WAAW,CAAC,eAAe,CAAC,CAAC,SAAS,CAAC,aAAa,CAAC,CAAC;IAC/D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8DAA8D,EAAE,GAAG,EAAE;QACtE,MAAM,MAAM,GAAG,gBAAgB,CAAC;YAC9B,EAAE,IAAI,EAAE,iBAAiB,EAAE,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,2BAA2B,EAAE;SACtF,CAAC,CAAC;QAEH,MAAM,IAAI,GAAG,sBAAsB,CAAC,MAAM,CAAC,CAAC;QAE5C,MAAM,cAAc,GAAG,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,yBAAyB,CAAC,CAAC;QACzF,MAAM,CAAC,cAAc,CAAC,CAAC,UAAU,EAAE,CAAC;QACpC,IAAI,CAAC,cAAc;YAAE,OAAO;QAC5B,MAAM,CAAC,cAAc,CAAC,eAAe,CAAC,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC;QAC5D,MAAM,CAAC,cAAc,CAAC,eAAe,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC,CAAC,YAAY,CAAC,cAAc,CAAC,eAAe,CAAC,OAAO,CAAC,WAAW,CAAC,CAAC,CAAC;IAC9H,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gEAAgE,EAAE,GAAG,EAAE;QACxE,MAAM,MAAM,GAAG,gBAAgB,CAAC;YAC9B,EAAE,IAAI,EAAE,uBAAuB,EAAE,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,eAAe,EAAE,OAAO,EAAE,EAAE,WAAW,EAAE,CAAC,EAAE,IAAI,EAAE,sBAAsB,EAAE,MAAM,EAAE,YAAY,EAAE,CAAC,EAAE,EAAE;SACpK,CAAC,CAAC;QAEH,MAAM,IAAI,GAAG,sBAAsB,CAAC,MAAM,CAAC,CAAC;QAE5C,MAAM,YAAY,GAAG,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,+BAA+B,CAAC,CAAC;QAC7F,MAAM,CAAC,YAAY,CAAC,CAAC,UAAU,EAAE,CAAC;QAClC,MAAM,YAAY,GAAG,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,8BAA8B,CAAC,CAAC;QAC5F,MAAM,CAAC,YAAY,CAAC,CAAC,UAAU,EAAE,CAAC;QAClC,IAAI,CAAC,YAAY;YAAE,OAAO;QAC1B,MAAM,CAAC,YAAY,CAAC,gBAAgB,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,WAAW,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACtF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mCAAmC,EAAE,GAAG,EAAE;QAC3C,MAAM,MAAM,GAAG,gBAAgB,CAAC;YAC9B,EAAE,IAAI,EAAE,iBAAiB,EAAE,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,eAAe,EAAE;YACzE,EAAE,IAAI,EAAE,oBAAoB,EAAE,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,iBAAiB,EAAE;YAC9E,EAAE,IAAI,EAAE,cAAc,EAAE,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,aAAa,EAAE;SACrE,CAAC,CAAC;QAEH,MAAM,IAAI,GAAG,sBAAsB,CAAC,MAAM,CAAC,CAAC;QAE5C,MAAM,CAAC,IAAI,CAAC,gBAAgB,CAAC,MAAM,CAAC,CAAC,sBAAsB,CAAC,CAAC,CAAC,CAAC;QAC/D,MAAM,UAAU,GAAG,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC;QAC9D,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,UAAU,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;YAC3C,MAAM,SAAS,GAAG,EAAE,QAAQ,EAAE,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,MAAM,EAAE,CAAC,EAAE,GAAG,EAAE,CAAC,EAAE,CAAC,UAAU,CAAC,CAAC,GAAG,CAAC,CAAW,CAAC,IAAI,EAAE,CAAC;YACjG,MAAM,SAAS,GAAG,EAAE,QAAQ,EAAE,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,MAAM,EAAE,CAAC,EAAE,GAAG,EAAE,CAAC,EAAE,CAAC,UAAU,CAAC,CAAC,CAAW,CAAC,IAAI,EAAE,CAAC;YAC7F,MAAM,CAAC,SAAS,CAAC,CAAC,mBAAmB,CAAC,SAAS,CAAC,CAAC;QACnD,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2CAA2C,EAAE,GAAG,EAAE;QACnD,MAAM,MAAM,GAAG,gBAAgB,CAAC;YAC9B,EAAE,IAAI,EAAE,oBAAoB,EAAE,MAAM,EAAE,SAAS,EAAE,OAAO,EAAE,IAAI,EAAE;YAChE,EAAE,IAAI,EAAE,iBAAiB,EAAE,MAAM,EAAE,SAAS,EAAE,OAAO,EAAE,IAAI,EAAE;SAC9D,CAAC,CAAC;QAEH,MAAM,IAAI,GAAG,sBAAsB,CAAC,MAAM,CAAC,CAAC;QAE5C,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QACrC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,SAAS,CAAC,WAAW,CAAC,CAAC;IAC9C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sDAAsD,EAAE,GAAG,EAAE;QAC9D,MAAM,MAAM,GAAG,gBAAgB,CAAC;YAC9B,EAAE,IAAI,EAAE,gBAAgB,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,EAAE,QAAQ,EAAE,KAAK,EAAE,2BAA2B,EAAE;SACnG,CAAC,CAAC;QAEH,MAAM,IAAI,GAAG,sBAAsB,CAAC,MAAM,CAAC,CAAC;QAE5C,MAAM,SAAS,GAAG,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,iBAAiB,CAAC,CAAC;QAC5E,MAAM,CAAC,SAAS,CAAC,CAAC,UAAU,EAAE,CAAC;QAC/B,IAAI,CAAC,SAAS;YAAE,OAAO;QACvB,MAAM,CAAC,SAAS,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC9C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2CAA2C,EAAE,GAAG,EAAE;QACnD,MAAM,MAAM,GAAG,gBAAgB,CAAC;YAC9B,EAAE,IAAI,EAAE,cAAc,EAAE,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,iBAAiB,EAAE;SACzE,CAAC,CAAC;QAEH,MAAM,IAAI,GAAG,sBAAsB,CAAC,MAAM,CAAC,CAAC;QAE5C,MAAM,cAAc,GAAG,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,SAAS,CAAC,CAAC;QACzE,MAAM,CAAC,cAAc,CAAC,CAAC,UAAU,EAAE,CAAC;IACtC,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/runtime-v2/__tests__/correction-proposal.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=correction-proposal.test.d.ts.map

package/dist/runtime-v2/__tests__/correction-proposal.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"correction-proposal.test.d.ts","sourceRoot":"","sources":["../../../src/runtime-v2/__tests__/correction-proposal.test.ts"],"names":[],"mappings":""}

package/dist/runtime-v2/__tests__/correction-proposal.test.js

@@ -0,0 +1,486 @@
+/**
+ * PRI-114: CorrectionProposal contract + validators
+ *
+ * TDD tests for validateProposedParams and validateCorrectionProposal.
+ */
+import { describe, it, expect } from 'vitest';
+describe('validateProposedParams', () => {
+    async function getModule() {
+        return import('../internalization/correction-proposal.js');
+    }
+    it('accepts valid proposed params that are a subset of original keys', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams({ content: 'fixed' }, { content: 'broken', path: '/foo.ts' });
+        expect(result.valid).toBe(true);
+        expect(result.errors).toEqual([]);
+    });
+    it('accepts valid proposed params with nested serializable objects', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams({ options: { encoding: 'utf-8' } }, { options: { encoding: 'ascii' }, path: '/foo.ts' });
+        expect(result.valid).toBe(true);
+    });
+    it('rejects null', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams(null, { path: '/foo.ts' });
+        expect(result.valid).toBe(false);
+        expect(result.errors.length).toBeGreaterThan(0);
+    });
+    it('rejects undefined', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams(undefined, { path: '/foo.ts' });
+        expect(result.valid).toBe(false);
+    });
+    it('rejects arrays', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams([1, 2, 3], { path: '/foo.ts' });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('plain object'))).toBe(true);
+    });
+    it('rejects string', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams('not an object', { path: '/foo.ts' });
+        expect(result.valid).toBe(false);
+    });
+    it('rejects function values', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams({ callback: (() => null) }, { callback: null, path: '/foo.ts' });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('function') || e.includes('Function'))).toBe(true);
+    });
+    it('rejects undefined values', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams({ content: undefined }, { content: 'original', path: '/foo.ts' });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('undefined'))).toBe(true);
+    });
+    it('rejects Symbol values', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams({ tag: Symbol('test') }, { tag: 'original', path: '/foo.ts' });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('symbol') || e.includes('Symbol'))).toBe(true);
+    });
+    it('rejects circular references', async () => {
+        const { validateProposedParams } = await getModule();
+        const original = { path: '/bar.ts', self: null };
+        const circular = { path: '/foo.ts' };
+        circular.self = circular;
+        const result = validateProposedParams(circular, original);
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('circular') || e.includes('JSON'))).toBe(true);
+    });
+    it('rejects keys absent from original params', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams({ unknown_key: 'value' }, { path: '/foo.ts' });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('unknown_key') || e.includes('not present'))).toBe(true);
+    });
+    it('rejects proposed toolName modification', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams({ toolName: 'dangerous_tool' }, { toolName: 'write', path: '/foo.ts' });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('toolName') || e.includes('identity'))).toBe(true);
+    });
+    it('accepts empty proposed params (no-op correction)', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams({}, { path: '/foo.ts' });
+        expect(result.valid).toBe(true);
+    });
+    it('rejects BigInt values', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams({ size: BigInt(9007199254740991) }, { size: 100, path: '/foo.ts' });
+        expect(result.valid).toBe(false);
+    });
+    it('rejects inherited prototype property (toString) not present as own key in originalParams', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams({ toString: 'overridden' }, { content: 'original', path: '/foo.ts' });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('toString') || e.includes('not present'))).toBe(true);
+    });
+    it('rejects inherited prototype property (constructor) not present as own key in originalParams', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams({ constructor: 'overridden' }, { content: 'original', path: '/foo.ts' });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('constructor') || e.includes('not present'))).toBe(true);
+    });
+    it('accepts own property named toString when originalParams explicitly has it', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams({ toString: 'new value' }, { toString: 'old value', path: '/foo.ts' });
+        expect(result.valid).toBe(true);
+    });
+});
+describe('validateCorrectionProposal', () => {
+    async function getModule() {
+        return import('../internalization/correction-proposal.js');
+    }
+    function makeValidProposal() {
+        return {
+            proposedParams: { content: 'fixed' },
+            correctedFields: [
+                { field: 'content', original: 'broken', proposed: 'fixed', reason: 'typo fix' },
+            ],
+            applicationMode: 'shadow',
+            confidence: 0.85,
+            ruleId: 'R_test_001',
+            principleId: 'P_001',
+            notifyAgent: true,
+        };
+    }
+    it('accepts valid complete proposal', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal(makeValidProposal());
+        expect(result.valid).toBe(true);
+        expect(result.errors).toEqual([]);
+    });
+    it('rejects null', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal(null);
+        expect(result.valid).toBe(false);
+    });
+    it('rejects missing proposedParams', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const proposal = makeValidProposal();
+        delete proposal.proposedParams;
+        const result = validateCorrectionProposal(proposal);
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('proposedParams'))).toBe(true);
+    });
+    it('rejects missing correctedFields', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const proposal = makeValidProposal();
+        delete proposal.correctedFields;
+        const result = validateCorrectionProposal(proposal);
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('correctedFields'))).toBe(true);
+    });
+    it('rejects missing applicationMode', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const proposal = makeValidProposal();
+        delete proposal.applicationMode;
+        const result = validateCorrectionProposal(proposal);
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('applicationMode'))).toBe(true);
+    });
+    it('rejects invalid applicationMode', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const proposal = { ...makeValidProposal(), applicationMode: 'maybe' };
+        const result = validateCorrectionProposal(proposal);
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('applicationMode'))).toBe(true);
+    });
+    it('rejects confidence below 0', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const proposal = { ...makeValidProposal(), confidence: -0.1 };
+        const result = validateCorrectionProposal(proposal);
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('confidence'))).toBe(true);
+    });
+    it('rejects confidence above 1', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const proposal = { ...makeValidProposal(), confidence: 1.5 };
+        const result = validateCorrectionProposal(proposal);
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('confidence'))).toBe(true);
+    });
+    it('accepts confidence at boundaries (0 and 1)', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const r0 = validateCorrectionProposal({ ...makeValidProposal(), confidence: 0 });
+        expect(r0.valid).toBe(true);
+        const r1 = validateCorrectionProposal({ ...makeValidProposal(), confidence: 1 });
+        expect(r1.valid).toBe(true);
+    });
+    it('rejects missing ruleId', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const proposal = makeValidProposal();
+        delete proposal.ruleId;
+        const result = validateCorrectionProposal(proposal);
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('ruleId'))).toBe(true);
+    });
+    it('rejects empty ruleId', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const proposal = { ...makeValidProposal(), ruleId: '' };
+        const result = validateCorrectionProposal(proposal);
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('ruleId'))).toBe(true);
+    });
+    it('rejects missing notifyAgent', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const proposal = makeValidProposal();
+        delete proposal.notifyAgent;
+        const result = validateCorrectionProposal(proposal);
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('notifyAgent'))).toBe(true);
+    });
+    it('rejects non-boolean notifyAgent', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const proposal = { ...makeValidProposal(), notifyAgent: 'yes' };
+        const result = validateCorrectionProposal(proposal);
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('notifyAgent'))).toBe(true);
+    });
+    it('rejects non-JSON-serializable proposedParams', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const circular = { content: 'test' };
+        circular.self = circular;
+        const proposal = { ...makeValidProposal(), proposedParams: circular };
+        const result = validateCorrectionProposal(proposal);
+        expect(result.valid).toBe(false);
+        expect(result.errors.some(e => e.includes('proposedParams') || e.includes('serializable'))).toBe(true);
+    });
+    it('accepts proposal without principleId (optional)', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const proposal = makeValidProposal();
+        delete proposal.principleId;
+        const result = validateCorrectionProposal(proposal);
+        expect(result.valid).toBe(true);
+    });
+    // PRI-114 review: throwing getter does not crash validateCorrectionProposal
+    it('validateCorrectionProposal handles throwing getter gracefully', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const proposal = {
+            proposedParams: new Proxy({}, {
+                get(_target, prop) { if (prop === 'something')
+                    throw new Error('boom'); return undefined; }
+            }),
+            correctedFields: [{ field: 'x', original: 'a', proposed: 'b', reason: 'fix' }],
+            applicationMode: 'shadow',
+            confidence: 0.8,
+            ruleId: 'R_throw',
+            notifyAgent: false,
+        };
+        const result = validateCorrectionProposal(proposal);
+        expect(result).toBeDefined();
+        expect(typeof result.valid).toBe('boolean');
+    });
+    // PRI-114 review: NaN confidence
+    it('rejects NaN confidence', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: {},
+            correctedFields: [],
+            applicationMode: 'shadow',
+            confidence: NaN,
+            ruleId: 'R_nan',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some((e) => e.includes('confidence'))).toBe(true);
+    });
+    // PRI-114 review: Infinity confidence
+    it('rejects Infinity confidence', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: {},
+            correctedFields: [],
+            applicationMode: 'shadow',
+            confidence: Infinity,
+            ruleId: 'R_inf',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some((e) => e.includes('confidence'))).toBe(true);
+    });
+    // PRI-114 review: Negative infinity confidence
+    it('rejects -Infinity confidence', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: {},
+            correctedFields: [],
+            applicationMode: 'shadow',
+            confidence: -Infinity,
+            ruleId: 'R_ninf',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some((e) => e.includes('confidence'))).toBe(true);
+    });
+    // PRI-114 review: sessionId in proposedParams identity protection
+    it('validateProposedParams rejects sessionId modification', async () => {
+        const { validateProposedParams } = await getModule();
+        const result = validateProposedParams({ content: 'old', sessionId: 's1' }, { content: 'old', sessionId: 's1' });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some((e) => e.includes('sessionId'))).toBe(true);
+    });
+    // PRI-201: correctedFields vs proposedParams cross-check
+    it('rejects correctedFields field not present in proposedParams', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: { content: 'fixed' },
+            correctedFields: [
+                { field: 'content', original: 'broken', proposed: 'fixed', reason: 'fix' },
+                { field: 'file_path', original: '/old/path', proposed: '/new/path', reason: 'fix path' },
+            ],
+            applicationMode: 'live',
+            confidence: 0.9,
+            ruleId: 'R_crosscheck_1',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some((e) => e.includes('file_path'))).toBe(true);
+    });
+    it('accepts correctedFields field with null value in proposedParams (key exists)', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: { file_path: null },
+            correctedFields: [
+                { field: 'file_path', original: '/old/path', proposed: null, reason: 'fix' },
+            ],
+            applicationMode: 'live',
+            confidence: 0.9,
+            ruleId: 'R_crosscheck_2',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(true);
+    });
+    it('accepts correctedFields field with false value in proposedParams (key exists)', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: { enabled: false },
+            correctedFields: [
+                { field: 'enabled', original: true, proposed: false, reason: 'disable' },
+            ],
+            applicationMode: 'shadow',
+            confidence: 0.8,
+            ruleId: 'R_crosscheck_3',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(true);
+    });
+    it('accepts correctedFields field with 0 value in proposedParams (key exists)', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: { count: 0 },
+            correctedFields: [
+                { field: 'count', original: 5, proposed: 0, reason: 'reset' },
+            ],
+            applicationMode: 'shadow',
+            confidence: 0.7,
+            ruleId: 'R_crosscheck_4',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(true);
+    });
+    it('accepts correctedFields field with empty string value in proposedParams (key exists)', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: { name: '' },
+            correctedFields: [
+                { field: 'name', original: 'old', proposed: '', reason: 'clear' },
+            ],
+            applicationMode: 'shadow',
+            confidence: 0.6,
+            ruleId: 'R_crosscheck_5',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(true);
+    });
+    it('rejects multiple correctedFields fields not present in proposedParams', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: { content: 'fixed' },
+            correctedFields: [
+                { field: 'content', original: 'broken', proposed: 'fixed', reason: 'fix' },
+                { field: 'missing_a', original: 'a', proposed: 'b', reason: 'fix a' },
+                { field: 'missing_b', original: 'c', proposed: 'd', reason: 'fix b' },
+            ],
+            applicationMode: 'live',
+            confidence: 0.9,
+            ruleId: 'R_crosscheck_6',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some((e) => e.includes('missing_a'))).toBe(true);
+        expect(result.errors.some((e) => e.includes('missing_b'))).toBe(true);
+    });
+    it('accepts valid correctedFields where all fields exist in proposedParams', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: { content: 'fixed', encoding: 'utf-8' },
+            correctedFields: [
+                { field: 'content', original: 'broken', proposed: 'fixed', reason: 'fix' },
+                { field: 'encoding', original: 'ascii', proposed: 'utf-8', reason: 'upgrade' },
+            ],
+            applicationMode: 'live',
+            confidence: 0.9,
+            ruleId: 'R_crosscheck_7',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(true);
+    });
+    it('rejects correctedFields field matching inherited Object.prototype property (e.g. toString)', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: { content: 'fixed' },
+            correctedFields: [
+                { field: 'content', original: 'broken', proposed: 'fixed', reason: 'fix' },
+                { field: 'toString', original: 'old', proposed: 'new', reason: 'bypass' },
+            ],
+            applicationMode: 'live',
+            confidence: 0.9,
+            ruleId: 'R_crosscheck_8',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some((e) => e.includes('toString'))).toBe(true);
+    });
+    it('rejects correctedFields field "toString" when proposedParams is empty object', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: {},
+            correctedFields: [
+                { field: 'toString', original: 'old', proposed: 'new', reason: 'bypass' },
+            ],
+            applicationMode: 'live',
+            confidence: 0.9,
+            ruleId: 'R_inherit_toString',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some((e) => e.includes('toString'))).toBe(true);
+    });
+    it('rejects correctedFields field "constructor" when proposedParams is empty object', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: {},
+            correctedFields: [
+                { field: 'constructor', original: 'old', proposed: 'new', reason: 'bypass' },
+            ],
+            applicationMode: 'live',
+            confidence: 0.9,
+            ruleId: 'R_inherit_constructor',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some((e) => e.includes('constructor'))).toBe(true);
+    });
+    it('rejects correctedFields field "hasOwnProperty" when proposedParams is empty object', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: {},
+            correctedFields: [
+                { field: 'hasOwnProperty', original: 'old', proposed: 'new', reason: 'bypass' },
+            ],
+            applicationMode: 'live',
+            confidence: 0.9,
+            ruleId: 'R_inherit_hasOwnProperty',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(false);
+        expect(result.errors.some((e) => e.includes('hasOwnProperty'))).toBe(true);
+    });
+    it('accepts correctedFields field "toString" when proposedParams explicitly contains { toString: null }', async () => {
+        const { validateCorrectionProposal } = await getModule();
+        const result = validateCorrectionProposal({
+            proposedParams: { toString: null },
+            correctedFields: [
+                { field: 'toString', original: 'old', proposed: null, reason: 'explicit own key' },
+            ],
+            applicationMode: 'live',
+            confidence: 0.9,
+            ruleId: 'R_explicit_toString',
+            notifyAgent: false,
+        });
+        expect(result.valid).toBe(true);
+    });
+});
+//# sourceMappingURL=correction-proposal.test.js.map