@principles/core 1.287.1 → 1.287.3

package/dist/runtime-v2/store/task/__tests__/sqlite-task-store-cas.test.js

@@ -1,114 +0,0 @@
-/**
- * PRI-629 — SqliteTaskStore.updateTaskIfDiagnosticJsonUnchanged (narrow CAS)。
- *
- * 单 SQL conditional mutation: diagnostic_json 前置字节比较。并发语义:
- *   - expected 与当前一致 → 应用 patch 并返回更新后的行
- *   - 不一致 / 任务缺失 → 返回 null (调用方重读重估,无 partial write)
- *   - NULL 列与 expected=null 匹配 (SQLite IS 语义)
- */
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
-import * as fs from 'fs';
-import * as path from 'path';
-import * as os from 'os';
-import { SqliteConnection } from '../../sqlite-connection.js';
-import { SqliteTaskStore } from '../sqlite-task-store.js';
-describe('SqliteTaskStore.updateTaskIfDiagnosticJsonUnchanged (PRI-629 CAS)', () => {
-    let dir;
-    let store;
-    let connection;
-    beforeEach(async () => {
-        dir = fs.mkdtempSync(path.join(os.tmpdir(), 'pd-cas-test-'));
-        connection = new SqliteConnection(dir);
-        connection.getDb();
-        store = new SqliteTaskStore(connection);
-    });
-    afterEach(async () => {
-        connection.close();
-        fs.rmSync(dir, { recursive: true, force: true });
-    });
-    async function createTask(diagnosticJson) {
-        const record = await store.createTask({
-            taskId: `task-cas-${Math.random().toString(36).slice(2, 8)}`,
-            taskKind: 'evaluator',
-            status: 'needs_human_review',
-            attemptCount: 2,
-            maxAttempts: 3,
-            diagnosticJson,
-        });
-        return record.taskId;
-    }
-    it('applies the patch when diagnostic_json matches the expectation', async () => {
-        const taskId = await createTask('{"pi_metadata":{"v":1}}');
-        const updated = await store.updateTaskIfDiagnosticJsonUnchanged(taskId, '{"pi_metadata":{"v":1}}', {
-            status: 'pending',
-            attemptCount: 0,
-            diagnosticJson: '{"pi_metadata":{"v":2}}',
-        });
-        expect(updated?.status).toBe('pending');
-        expect(updated?.attemptCount).toBe(0);
-        expect((await store.getTask(taskId))?.diagnosticJson).toBe('{"pi_metadata":{"v":2}}');
-    });
-    it('returns null (no write) when diagnostic_json changed concurrently', async () => {
-        const taskId = await createTask('{"pi_metadata":{"v":1}}');
-        // 另一个写入者先改了 diagnostic_json
-        await store.updateTask(taskId, { diagnosticJson: '{"pi_metadata":{"v":"other-writer"}}' });
-        const result = await store.updateTaskIfDiagnosticJsonUnchanged(taskId, '{"pi_metadata":{"v":1}}', {
-            status: 'pending',
-            diagnosticJson: '{"pi_metadata":{"v":2}}',
-        });
-        expect(result).toBeNull();
-        // 行保持并发写者的内容 — 无 partial write
-        const row = await store.getTask(taskId);
-        expect(row?.status).toBe('needs_human_review');
-        expect(row?.diagnosticJson).toBe('{"pi_metadata":{"v":"other-writer"}}');
-    });
-    it('matches expected=null against a NULL column and rejects string-expected on NULL', async () => {
-        const taskId = await createTask(undefined);
-        const ok = await store.updateTaskIfDiagnosticJsonUnchanged(taskId, null, { status: 'pending' });
-        expect(ok?.status).toBe('pending');
-        const taskId2 = await createTask(undefined);
-        const mismatch = await store.updateTaskIfDiagnosticJsonUnchanged(taskId2, 'not-null', { status: 'pending' });
-        expect(mismatch).toBeNull();
-    });
-    it('returns null for a missing task (no throw, no partial state)', async () => {
-        const result = await store.updateTaskIfDiagnosticJsonUnchanged('task-does-not-exist', null, { status: 'pending' });
-        expect(result).toBeNull();
-    });
-    it('does not write when bound evidence content or lineage changed after review', async () => {
-        const taskId = await createTask('{"pi_metadata":{"v":1}}');
-        const db = connection.getDb();
-        db.prepare(`
-      INSERT INTO pi_artifacts (
-        artifact_id, artifact_kind, source_task_id, lineage_artifact_ids,
-        validation_status, content_json, created_at, updated_at
-      ) VALUES (?, ?, ?, ?, ?, ?, ?, ?)
-    `).run('artifact-bound', 'principle', taskId, '["scribe-a"]', 'pending', '{"summary":"Evidence A"}', '2026-08-31T00:00:00.000Z', '2026-08-31T00:00:00.000Z');
-        const expectedEvidence = [{
-                artifactId: 'artifact-bound',
-                sourceTaskId: taskId,
-                lineageArtifactIdsJson: '["scribe-a"]',
-                contentJson: '{"summary":"Evidence A"}',
-            }];
-        db.prepare('UPDATE pi_artifacts SET content_json = ? WHERE artifact_id = ?')
-            .run('{"summary":"Evidence B"}', 'artifact-bound');
-        const contentRace = await store.updateTaskIfDiagnosticJsonAndArtifactsUnchanged({
-            taskId,
-            expectedDiagnosticJson: '{"pi_metadata":{"v":1}}',
-            artifacts: expectedEvidence,
-            patch: { status: 'pending' },
-        });
-        expect(contentRace).toBeNull();
-        expect((await store.getTask(taskId))?.status).toBe('needs_human_review');
-        db.prepare('UPDATE pi_artifacts SET content_json = ?, lineage_artifact_ids = ? WHERE artifact_id = ?')
-            .run('{"summary":"Evidence A"}', '["scribe-b"]', 'artifact-bound');
-        const lineageRace = await store.updateTaskIfDiagnosticJsonAndArtifactsUnchanged({
-            taskId,
-            expectedDiagnosticJson: '{"pi_metadata":{"v":1}}',
-            artifacts: expectedEvidence,
-            patch: { status: 'pending' },
-        });
-        expect(lineageRace).toBeNull();
-        expect((await store.getTask(taskId))?.status).toBe('needs_human_review');
-    });
-});
-//# sourceMappingURL=sqlite-task-store-cas.test.js.map

package/dist/runtime-v2/store/task/__tests__/sqlite-task-store-cas.test.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"sqlite-task-store-cas.test.js","sourceRoot":"","sources":["../../../../../src/runtime-v2/store/task/__tests__/sqlite-task-store-cas.test.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AACH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAC;AACrE,OAAO,KAAK,EAAE,MAAM,IAAI,CAAC;AACzB,OAAO,KAAK,IAAI,MAAM,MAAM,CAAC;AAC7B,OAAO,KAAK,EAAE,MAAM,IAAI,CAAC;AACzB,OAAO,EAAE,gBAAgB,EAAE,MAAM,4BAA4B,CAAC;AAC9D,OAAO,EAAE,eAAe,EAAE,MAAM,yBAAyB,CAAC;AAE1D,QAAQ,CAAC,mEAAmE,EAAE,GAAG,EAAE;IACjF,IAAI,GAAW,CAAC;IAChB,IAAI,KAAsB,CAAC;IAC3B,IAAI,UAA4B,CAAC;IAEjC,UAAU,CAAC,KAAK,IAAI,EAAE;QACpB,GAAG,GAAG,EAAE,CAAC,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,cAAc,CAAC,CAAC,CAAC;QAC7D,UAAU,GAAG,IAAI,gBAAgB,CAAC,GAAG,CAAC,CAAC;QACvC,UAAU,CAAC,KAAK,EAAE,CAAC;QACnB,KAAK,GAAG,IAAI,eAAe,CAAC,UAAU,CAAC,CAAC;IAC1C,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,KAAK,IAAI,EAAE;QACnB,UAAU,CAAC,KAAK,EAAE,CAAC;QACnB,EAAE,CAAC,MAAM,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;IACnD,CAAC,CAAC,CAAC;IAEH,KAAK,UAAU,UAAU,CAAC,cAAuB;QAC/C,MAAM,MAAM,GAAG,MAAM,KAAK,CAAC,UAAU,CAAC;YACpC,MAAM,EAAE,YAAY,IAAI,CAAC,MAAM,EAAE,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,EAAE;YAC5D,QAAQ,EAAE,WAAW;YACrB,MAAM,EAAE,oBAAoB;YAC5B,YAAY,EAAE,CAAC;YACf,WAAW,EAAE,CAAC;YACd,cAAc;SACf,CAAC,CAAC;QACH,OAAO,MAAM,CAAC,MAAM,CAAC;IACvB,CAAC;IAED,EAAE,CAAC,gEAAgE,EAAE,KAAK,IAAI,EAAE;QAC9E,MAAM,MAAM,GAAG,MAAM,UAAU,CAAC,yBAAyB,CAAC,CAAC;QAC3D,MAAM,OAAO,GAAG,MAAM,KAAK,CAAC,mCAAmC,CAAC,MAAM,EAAE,yBAAyB,EAAE;YACjG,MAAM,EAAE,SAAS;YACjB,YAAY,EAAE,CAAC;YACf,cAAc,EAAE,yBAAyB;SAC1C,CAAC,CAAC;QACH,MAAM,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QACxC,MAAM,CAAC,OAAO,EAAE,YAAY,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QACtC,MAAM,CAAC,CAAC,MAAM,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,EAAE,cAAc,CAAC,CAAC,IAAI,CAAC,yBAAyB,CAAC,CAAC;IACxF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mEAAmE,EAAE,KAAK,IAAI,EAAE;QACjF,MAAM,MAAM,GAAG,MAAM,UAAU,CAAC,yBAAyB,CAAC,CAAC;QAC3D,4BAA4B;QAC5B,MAAM,KAAK,CAAC,UAAU,CAAC,MAAM,EAAE,EAAE,cAAc,EAAE,sCAAsC,EAAE,CAAC,CAAC;QAC3F,MAAM,MAAM,GAAG,MAAM,KAAK,CAAC,mCAAmC,CAAC,MAAM,EAAE,yBAAyB,EAAE;YAChG,MAAM,EAAE,SAAS;YACjB,cAAc,EAAE,yBAAyB;SAC1C,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;QAC1B,+BAA+B;QAC/B,MAAM,GAAG,GAAG,MAAM,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC;QACxC,MAAM,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,oBAAoB,CAAC,CAAC;QAC/C,MAAM,CAAC,GAAG,EAAE,cAAc,CAAC,CAAC,IAAI,CAAC,sCAAsC,CAAC,CAAC;IAC3E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iFAAiF,EAAE,KAAK,IAAI,EAAE;QAC/F,MAAM,MAAM,GAAG,MAAM,UAAU,CAAC,SAAS,CAAC,CAAC;QAC3C,MAAM,EAAE,GAAG,MAAM,KAAK,CAAC,mCAAmC,CAAC,MAAM,EAAE,IAAI,EAAE,EAAE,MAAM,EAAE,SAAS,EAAE,CAAC,CAAC;QAChG,MAAM,CAAC,EAAE,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QACnC,MAAM,OAAO,GAAG,MAAM,UAAU,CAAC,SAAS,CAAC,CAAC;QAC5C,MAAM,QAAQ,GAAG,MAAM,KAAK,CAAC,mCAAmC,CAAC,OAAO,EAAE,UAAU,EAAE,EAAE,MAAM,EAAE,SAAS,EAAE,CAAC,CAAC;QAC7G,MAAM,CAAC,QAAQ,CAAC,CAAC,QAAQ,EAAE,CAAC;IAC9B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8DAA8D,EAAE,KAAK,IAAI,EAAE;QAC5E,MAAM,MAAM,GAAG,MAAM,KAAK,CAAC,mCAAmC,CAAC,qBAAqB,EAAE,IAAI,EAAE,EAAE,MAAM,EAAE,SAAS,EAAE,CAAC,CAAC;QACnH,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;IAC5B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4EAA4E,EAAE,KAAK,IAAI,EAAE;QAC1F,MAAM,MAAM,GAAG,MAAM,UAAU,CAAC,yBAAyB,CAAC,CAAC;QAC3D,MAAM,EAAE,GAAG,UAAU,CAAC,KAAK,EAAE,CAAC;QAC9B,EAAE,CAAC,OAAO,CAAC;;;;;KAKV,CAAC,CAAC,GAAG,CACJ,gBAAgB,EAAE,WAAW,EAAE,MAAM,EAAE,cAAc,EACrD,SAAS,EAAE,0BAA0B,EAAE,0BAA0B,EAAE,0BAA0B,CAC9F,CAAC;QAEF,MAAM,gBAAgB,GAAG,CAAC;gBACxB,UAAU,EAAE,gBAAgB;gBAC5B,YAAY,EAAE,MAAM;gBACpB,sBAAsB,EAAE,cAAc;gBACtC,WAAW,EAAE,0BAA0B;aACxC,CAAC,CAAC;QACH,EAAE,CAAC,OAAO,CAAC,gEAAgE,CAAC;aACzE,GAAG,CAAC,0BAA0B,EAAE,gBAAgB,CAAC,CAAC;QAErD,MAAM,WAAW,GAAG,MAAM,KAAK,CAAC,+CAA+C,CAAC;YAC9E,MAAM;YACN,sBAAsB,EAAE,yBAAyB;YACjD,SAAS,EAAE,gBAAgB;YAC3B,KAAK,EAAE,EAAE,MAAM,EAAE,SAAS,EAAE;SAC7B,CAAC,CAAC;QACH,MAAM,CAAC,WAAW,CAAC,CAAC,QAAQ,EAAE,CAAC;QAC/B,MAAM,CAAC,CAAC,MAAM,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,oBAAoB,CAAC,CAAC;QAEzE,EAAE,CAAC,OAAO,CAAC,0FAA0F,CAAC;aACnG,GAAG,CAAC,0BAA0B,EAAE,cAAc,EAAE,gBAAgB,CAAC,CAAC;QACrE,MAAM,WAAW,GAAG,MAAM,KAAK,CAAC,+CAA+C,CAAC;YAC9E,MAAM;YACN,sBAAsB,EAAE,yBAAyB;YACjD,SAAS,EAAE,gBAAgB;YAC3B,KAAK,EAAE,EAAE,MAAM,EAAE,SAAS,EAAE;SAC7B,CAAC,CAAC;QACH,MAAM,CAAC,WAAW,CAAC,CAAC,QAAQ,EAAE,CAAC;QAC/B,MAAM,CAAC,CAAC,MAAM,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,oBAAoB,CAAC,CAAC;IAC3E,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/runtime-v2/store/task/__tests__/sqlite-task-store.failed-tasks.test.d.ts

@@ -1,2 +0,0 @@
-export {};
-//# sourceMappingURL=sqlite-task-store.failed-tasks.test.d.ts.map

package/dist/runtime-v2/store/task/__tests__/sqlite-task-store.failed-tasks.test.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"sqlite-task-store.failed-tasks.test.d.ts","sourceRoot":"","sources":["../../../../../src/runtime-v2/store/task/__tests__/sqlite-task-store.failed-tasks.test.ts"],"names":[],"mappings":""}

package/dist/runtime-v2/store/task/__tests__/sqlite-task-store.failed-tasks.test.js

@@ -1,485 +0,0 @@
-/**
- * SqliteTaskStore failed-task observability tests (Task 8).
- *
- * Covers listFailedTasks / getFailedTaskDetail / countFailedTasks:
- * - status filtering (failed / needs_human_review vs succeeded)
- * - kind filter
- * - since filter (derived from runs.started_at)
- * - limit / offset pagination
- * - sort order (lastAttemptAt DESC)
- * - painId extraction from diagnostic_json
- * - getFailedTaskDetail run history + null pendingAgentDraft
- * - countFailedTasks matches listFailedTasks length
- *
- * Uses a real in-memory SqliteConnection (tmpdir) for isolation.
- */
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
-import * as fs from 'fs';
-import * as path from 'path';
-import * as os from 'os';
-import { SqliteConnection } from '../../sqlite-connection.js';
-import { SqliteTaskStore } from '../sqlite-task-store.js';
-import { SqliteRunStore } from '../../run/sqlite-run-store.js';
-function makeTaskInput(overrides = {}) {
-    return {
-        taskId: overrides.taskId ?? `task_${Date.now()}_${Math.random().toString(36).slice(2)}`,
-        taskKind: overrides.taskKind ?? 'diagnostician',
-        status: overrides.status ?? 'pending',
-        attemptCount: overrides.attemptCount ?? 0,
-        maxAttempts: overrides.maxAttempts ?? 3,
-        inputRef: overrides.inputRef,
-        resultRef: overrides.resultRef,
-        leaseOwner: overrides.leaseOwner,
-        leaseExpiresAt: overrides.leaseExpiresAt,
-        lastError: overrides.lastError,
-        diagnosticJson: overrides.diagnosticJson,
-    };
-}
-function makeRunInput(overrides = {}) {
-    return {
-        runId: overrides.runId ?? `run_${Date.now()}_${Math.random().toString(36).slice(2)}`,
-        taskId: overrides.taskId ?? 'task-unknown',
-        runtimeKind: overrides.runtimeKind ?? 'test-double',
-        executionStatus: overrides.executionStatus ?? 'failed',
-        startedAt: overrides.startedAt ?? new Date().toISOString(),
-        attemptNumber: overrides.attemptNumber ?? 1,
-        endedAt: overrides.endedAt,
-        reason: overrides.reason,
-        outputRef: overrides.outputRef,
-        inputPayload: overrides.inputPayload,
-        outputPayload: overrides.outputPayload,
-        errorCategory: overrides.errorCategory,
-    };
-}
-describe('SqliteTaskStore failed-task observability', () => {
-    const tmpDir = path.join(os.tmpdir(), `pd-failed-test-${process.pid}-${Date.now()}`);
-    let connection;
-    let store;
-    let runStore;
-    beforeEach(() => {
-        const testDir = path.join(tmpDir, `t-${Date.now()}-${Math.random().toString(36).slice(2)}`);
-        fs.mkdirSync(testDir, { recursive: true });
-        connection = new SqliteConnection(testDir);
-        store = new SqliteTaskStore(connection);
-        runStore = new SqliteRunStore(connection);
-    });
-    afterEach(() => {
-        connection.close();
-        try {
-            fs.rmSync(tmpDir, { recursive: true, force: true });
-        }
-        catch {
-            // ignore cleanup errors on Windows
-        }
-    });
-    // ── listFailedTasks: status filtering ──────────────────────────────────────
-    describe('listFailedTasks — status filtering', () => {
-        it('returns only failed and needs_human_review tasks (excludes succeeded)', async () => {
-            await store.createTask(makeTaskInput({ taskId: 't-failed', status: 'failed', lastError: 'runtime_unavailable' }));
-            await store.createTask(makeTaskInput({ taskId: 't-review', status: 'needs_human_review' }));
-            await store.createTask(makeTaskInput({ taskId: 't-ok', status: 'succeeded' }));
-            const results = await store.listFailedTasks();
-            const ids = results.map((r) => r.taskId);
-            expect(ids).toContain('t-failed');
-            expect(ids).toContain('t-review');
-            expect(ids).not.toContain('t-ok');
-            expect(results).toHaveLength(2);
-        });
-        it('returns empty array when no failed tasks exist', async () => {
-            await store.createTask(makeTaskInput({ taskId: 't-ok', status: 'succeeded' }));
-            const results = await store.listFailedTasks();
-            expect(results).toEqual([]);
-        });
-        it('each summary has correct status type (failed or needs_human_review)', async () => {
-            await store.createTask(makeTaskInput({ taskId: 't-f1', status: 'failed' }));
-            await store.createTask(makeTaskInput({ taskId: 't-r1', status: 'needs_human_review' }));
-            const results = await store.listFailedTasks();
-            for (const r of results) {
-                expect(r.status === 'failed' || r.status === 'needs_human_review').toBe(true);
-            }
-        });
-    });
-    // ── listFailedTasks: kind filter ───────────────────────────────────────────
-    describe('listFailedTasks — kind filter', () => {
-        it('filters by taskKind', async () => {
-            await store.createTask(makeTaskInput({ taskId: 't-d1', status: 'failed', taskKind: 'diagnostician' }));
-            await store.createTask(makeTaskInput({ taskId: 't-d2', status: 'failed', taskKind: 'diagnostician' }));
-            await store.createTask(makeTaskInput({ taskId: 't-s1', status: 'failed', taskKind: 'scribe' }));
-            const diags = await store.listFailedTasks({ kind: 'diagnostician' });
-            const ids = diags.map((r) => r.taskId);
-            expect(ids).toContain('t-d1');
-            expect(ids).toContain('t-d2');
-            expect(ids).not.toContain('t-s1');
-            expect(diags).toHaveLength(2);
-        });
-        it('returns all failed tasks when kind is undefined', async () => {
-            await store.createTask(makeTaskInput({ taskId: 't-a', status: 'failed', taskKind: 'diagnostician' }));
-            await store.createTask(makeTaskInput({ taskId: 't-b', status: 'failed', taskKind: 'scribe' }));
-            const results = await store.listFailedTasks();
-            expect(results).toHaveLength(2);
-        });
-    });
-    // ── listFailedTasks: since filter ──────────────────────────────────────────
-    describe('listFailedTasks — since filter', () => {
-        it('filters by lastAttemptAt >= since (derived from runs.started_at)', async () => {
-            const oldTime = new Date(Date.now() - 10 * 24 * 60 * 60 * 1000).toISOString(); // 10 days ago
-            const recentTime = new Date(Date.now() - 1 * 24 * 60 * 60 * 1000).toISOString(); // 1 day ago
-            // Task with an old run
-            await store.createTask(makeTaskInput({ taskId: 't-old', status: 'failed' }));
-            await runStore.createRun(makeRunInput({ taskId: 't-old', startedAt: oldTime }));
-            // Task with a recent run
-            await store.createTask(makeTaskInput({ taskId: 't-recent', status: 'failed' }));
-            await runStore.createRun(makeRunInput({ taskId: 't-recent', startedAt: recentTime }));
-            // since = 5 days ago → only 't-recent' should be included
-            const sinceMs = Date.now() - 5 * 24 * 60 * 60 * 1000;
-            const results = await store.listFailedTasks({ since: sinceMs });
-            const ids = results.map((r) => r.taskId);
-            expect(ids).toContain('t-recent');
-            expect(ids).not.toContain('t-old');
-        });
-        it('excludes tasks with no runs when since is specified', async () => {
-            // Task with no runs
-            await store.createTask(makeTaskInput({ taskId: 't-no-runs', status: 'failed' }));
-            // Task with a recent run
-            await store.createTask(makeTaskInput({ taskId: 't-with-run', status: 'failed' }));
-            await runStore.createRun(makeRunInput({ taskId: 't-with-run', startedAt: new Date().toISOString() }));
-            const sinceMs = Date.now() - 60 * 1000; // 1 minute ago
-            const results = await store.listFailedTasks({ since: sinceMs });
-            const ids = results.map((r) => r.taskId);
-            expect(ids).toContain('t-with-run');
-            expect(ids).not.toContain('t-no-runs');
-        });
-        it('includes tasks with no runs when since is not specified', async () => {
-            await store.createTask(makeTaskInput({ taskId: 't-no-runs', status: 'failed' }));
-            const results = await store.listFailedTasks();
-            const ids = results.map((r) => r.taskId);
-            expect(ids).toContain('t-no-runs');
-        });
-    });
-    // ── listFailedTasks: limit / offset pagination ─────────────────────────────
-    describe('listFailedTasks — pagination', () => {
-        it('applies limit', async () => {
-            for (let i = 0; i < 5; i++) {
-                await store.createTask(makeTaskInput({ taskId: `t-page-${i}`, status: 'failed' }));
-            }
-            const results = await store.listFailedTasks({ limit: 2 });
-            expect(results).toHaveLength(2);
-        });
-        it('applies offset for pagination', async () => {
-            for (let i = 0; i < 5; i++) {
-                await store.createTask(makeTaskInput({ taskId: `t-page-${i}`, status: 'failed' }));
-            }
-            const page1 = await store.listFailedTasks({ limit: 2, offset: 0 });
-            const page2 = await store.listFailedTasks({ limit: 2, offset: 2 });
-            expect(page1).toHaveLength(2);
-            expect(page2).toHaveLength(2);
-            const p1Ids = page1.map((r) => r.taskId);
-            const p2Ids = page2.map((r) => r.taskId);
-            // No overlap between pages
-            for (const id of p1Ids) {
-                expect(p2Ids).not.toContain(id);
-            }
-        });
-        it('returns empty for offset beyond result count', async () => {
-            await store.createTask(makeTaskInput({ taskId: 't-only', status: 'failed' }));
-            const results = await store.listFailedTasks({ limit: 10, offset: 10 });
-            expect(results).toEqual([]);
-        });
-    });
-    // ── listFailedTasks: sort order ────────────────────────────────────────────
-    describe('listFailedTasks — sort order', () => {
-        it('sorts by lastAttemptAt DESC (most recent first)', async () => {
-            const t1 = new Date(Date.now() - 30 * 24 * 60 * 60 * 1000).toISOString(); // 30 days ago
-            const t2 = new Date(Date.now() - 1 * 24 * 60 * 60 * 1000).toISOString(); // 1 day ago
-            const t3 = new Date(Date.now() - 10 * 24 * 60 * 60 * 1000).toISOString(); // 10 days ago
-            await store.createTask(makeTaskInput({ taskId: 't-oldest', status: 'failed' }));
-            await runStore.createRun(makeRunInput({ taskId: 't-oldest', startedAt: t1 }));
-            await store.createTask(makeTaskInput({ taskId: 't-newest', status: 'failed' }));
-            await runStore.createRun(makeRunInput({ taskId: 't-newest', startedAt: t2 }));
-            await store.createTask(makeTaskInput({ taskId: 't-middle', status: 'failed' }));
-            await runStore.createRun(makeRunInput({ taskId: 't-middle', startedAt: t3 }));
-            const results = await store.listFailedTasks();
-            expect(results).toHaveLength(3);
-            // Most recent first
-            const [newest, middle, oldest] = results;
-            if (!newest || !middle || !oldest) {
-                throw new Error('expected 3 results');
-            }
-            expect(newest.taskId).toBe('t-newest');
-            expect(middle.taskId).toBe('t-middle');
-            expect(oldest.taskId).toBe('t-oldest');
-        });
-        it('tasks with no runs (NULL lastAttemptAt) sort last', async () => {
-            // Task with a run
-            await store.createTask(makeTaskInput({ taskId: 't-with-run', status: 'failed' }));
-            await runStore.createRun(makeRunInput({ taskId: 't-with-run', startedAt: new Date().toISOString() }));
-            // Task without runs
-            await store.createTask(makeTaskInput({ taskId: 't-no-run', status: 'failed' }));
-            const results = await store.listFailedTasks();
-            expect(results).toHaveLength(2);
-            // Task with run comes first (non-NULL lastAttemptAt sorts before NULL in DESC)
-            const [withRun, noRun] = results;
-            if (!withRun || !noRun) {
-                throw new Error('expected 2 results');
-            }
-            expect(withRun.taskId).toBe('t-with-run');
-            expect(withRun.lastAttemptAt).not.toBeNull();
-            expect(noRun.taskId).toBe('t-no-run');
-            expect(noRun.lastAttemptAt).toBeNull();
-        });
-    });
-    // ── listFailedTasks: painId extraction ─────────────────────────────────────
-    describe('listFailedTasks — painId extraction', () => {
-        it('extracts painId from diagnostic_json.sourcePainId', async () => {
-            await store.createTask(makeTaskInput({
-                taskId: 't-with-pain',
-                status: 'failed',
-                diagnosticJson: JSON.stringify({ sourcePainId: 'pain-abc-123', other: 'data' }),
-            }));
-            const results = await store.listFailedTasks();
-            const found = results.find((r) => r.taskId === 't-with-pain');
-            expect(found).toBeDefined();
-            if (!found)
-                return;
-            expect(found.painId).toBe('pain-abc-123');
-        });
-        it('returns null painId when diagnostic_json has no sourcePainId', async () => {
-            await store.createTask(makeTaskInput({
-                taskId: 't-no-pain-field',
-                status: 'failed',
-                diagnosticJson: JSON.stringify({ otherField: 'value' }),
-            }));
-            const results = await store.listFailedTasks();
-            const found = results.find((r) => r.taskId === 't-no-pain-field');
-            expect(found).toBeDefined();
-            if (!found)
-                return;
-            expect(found.painId).toBeNull();
-        });
-        it('returns null painId when diagnostic_json is not set', async () => {
-            await store.createTask(makeTaskInput({ taskId: 't-no-diag', status: 'failed' }));
-            const results = await store.listFailedTasks();
-            const found = results.find((r) => r.taskId === 't-no-diag');
-            expect(found).toBeDefined();
-            if (!found)
-                return;
-            expect(found.painId).toBeNull();
-        });
-        // PRI-863: the consumer path now shares the canonical reader, so the
-        // reader's trim/blank normalization is the store's contract. Lock it at
-        // this boundary — the inline copy it replaced returned padded values
-        // verbatim, so this test pins the intentional tightening.
-        it('normalizes sourcePainId via the canonical reader (trim; blank → null)', async () => {
-            await store.createTask(makeTaskInput({
-                taskId: 't-padded-pain',
-                status: 'failed',
-                diagnosticJson: JSON.stringify({ sourcePainId: '  pain-pad  ' }),
-            }));
-            await store.createTask(makeTaskInput({
-                taskId: 't-blank-pain',
-                status: 'failed',
-                diagnosticJson: JSON.stringify({ sourcePainId: '   ' }),
-            }));
-            const results = await store.listFailedTasks();
-            expect(results.find((r) => r.taskId === 't-padded-pain')?.painId).toBe('pain-pad');
-            expect(results.find((r) => r.taskId === 't-blank-pain')?.painId).toBeNull();
-        });
-        // diagnostic_json is valid JSON (passes the session-id-hint expression
-        // index), but sourcePainId is a number, not a string.
-        it('returns null painId when sourcePainId is not a string (graceful degradation)', async () => {
-            await store.createTask(makeTaskInput({
-                taskId: 't-bad-pain-type',
-                status: 'failed',
-                diagnosticJson: JSON.stringify({ sourcePainId: 123 }),
-            }));
-            const results = await store.listFailedTasks();
-            const found = results.find((r) => r.taskId === 't-bad-pain-type');
-            expect(found).toBeDefined();
-            if (!found)
-                return;
-            expect(found.painId).toBeNull();
-        });
-        it('returns null painId when diagnostic_json is a JSON array (not an object)', async () => {
-            await store.createTask(makeTaskInput({
-                taskId: 't-array-json',
-                status: 'failed',
-                diagnosticJson: JSON.stringify([1, 2, 3]),
-            }));
-            const results = await store.listFailedTasks();
-            const found = results.find((r) => r.taskId === 't-array-json');
-            expect(found).toBeDefined();
-            if (!found)
-                return;
-            expect(found.painId).toBeNull();
-        });
-    });
-    // ── listFailedTasks: field correctness ─────────────────────────────────────
-    describe('listFailedTasks — field correctness', () => {
-        it('returns correct lastError (PDErrorCategory), attemptCount and maxAttempts', async () => {
-            await store.createTask(makeTaskInput({
-                taskId: 't-fields',
-                status: 'failed',
-                lastError: 'capability_missing',
-                attemptCount: 3,
-                maxAttempts: 3,
-            }));
-            const results = await store.listFailedTasks();
-            const found = results.find((r) => r.taskId === 't-fields');
-            expect(found).toBeDefined();
-            if (!found)
-                return;
-            expect(found.lastError).toBe('capability_missing');
-            expect(found.attemptCount).toBe(3);
-            // maxAttempts must round-trip so consumers can detect exhaustion
-            // (attemptCount >= maxAttempts) without a per-row detail fetch
-            expect(found.maxAttempts).toBe(3);
-            expect(found.taskKind).toBe('diagnostician');
-            expect(found.createdAt).toBeTruthy();
-        });
-        it('returns null lastError when not set', async () => {
-            await store.createTask(makeTaskInput({ taskId: 't-no-err', status: 'failed' }));
-            const results = await store.listFailedTasks();
-            const found = results.find((r) => r.taskId === 't-no-err');
-            expect(found).toBeDefined();
-            if (!found)
-                return;
-            expect(found.lastError).toBeNull();
-        });
-        it('throws storage_unavailable for a corrupted max_attempts column (rc-3 fail loud)', async () => {
-            await store.createTask(makeTaskInput({ taskId: 't-corrupt-max', status: 'failed', attemptCount: 1, maxAttempts: 3 }));
-            // Corrupt the row below the TaskRecordSchema bound (minimum: 1) the way
-            // only an external write/damaged DB could — the store's own createTask
-            // validates. prepare/run avoids raw SQL string concatenation.
-            connection.getDb()
-                .prepare('UPDATE tasks SET max_attempts = 0 WHERE task_id = ?')
-                .run('t-corrupt-max');
-            // Exhaustion detection (attemptCount >= maxAttempts) must never run on
-            // a budget that violates the schema — fail loud instead.
-            await expect(store.listFailedTasks()).rejects.toThrow(/invalid max_attempts/);
-        });
-        // PRI-863 note: the diagnostic_json non-string branch of
-        // readNullableStringField (storage_unavailable) cannot be exercised at
-        // this boundary on the current schema — TEXT affinity coerces numbers to
-        // strings and the json_extract session-id-hint expression index rejects
-        // BLOBs at UPDATE time ("malformed JSON"). The branch is reachable only
-        // via a damaged DB file; the pre-convergence inline copy was equally
-        // untestable here, so the refactor preserves it byte-for-byte instead of
-        // pretending the negative path is covered.
-    });
-    // ── getFailedTaskDetail ────────────────────────────────────────────────────
-    describe('getFailedTaskDetail', () => {
-        it('returns task + runs (DESC) + lastError + null pendingAgentDraft', async () => {
-            await store.createTask(makeTaskInput({
-                taskId: 't-detail',
-                status: 'failed',
-                lastError: 'input_invalid',
-                attemptCount: 2,
-            }));
-            // Create two runs with different started_at
-            const oldRun = await runStore.createRun(makeRunInput({
-                taskId: 't-detail',
-                runId: 'run-old',
-                startedAt: new Date(Date.now() - 60_000).toISOString(),
-                attemptNumber: 1,
-            }));
-            const newRun = await runStore.createRun(makeRunInput({
-                taskId: 't-detail',
-                runId: 'run-new',
-                startedAt: new Date().toISOString(),
-                attemptNumber: 2,
-            }));
-            void oldRun;
-            void newRun;
-            const detail = await store.getFailedTaskDetail('t-detail');
-            expect(detail).not.toBeNull();
-            if (!detail)
-                return;
-            expect(detail.task.taskId).toBe('t-detail');
-            expect(detail.task.status).toBe('failed');
-            expect(detail.lastError).toBe('input_invalid');
-            expect(detail.pendingAgentDraft).toBeNull();
-            // Runs sorted DESC (most recent first)
-            expect(detail.runs).toHaveLength(2);
-            const [latestRun, earlierRun] = detail.runs;
-            if (!latestRun || !earlierRun) {
-                throw new Error('expected 2 runs');
-            }
-            expect(latestRun.runId).toBe('run-new');
-            expect(earlierRun.runId).toBe('run-old');
-        });
-        it('returns task with empty runs array when no runs exist', async () => {
-            await store.createTask(makeTaskInput({ taskId: 't-no-runs-detail', status: 'failed' }));
-            const detail = await store.getFailedTaskDetail('t-no-runs-detail');
-            expect(detail).not.toBeNull();
-            if (!detail)
-                return;
-            expect(detail.runs).toEqual([]);
-            expect(detail.task.taskId).toBe('t-no-runs-detail');
-        });
-        it('returns null for non-existent taskId', async () => {
-            const detail = await store.getFailedTaskDetail('does-not-exist');
-            expect(detail).toBeNull();
-        });
-        it('returns null for a succeeded task (wrong status)', async () => {
-            await store.createTask(makeTaskInput({ taskId: 't-succeeded', status: 'succeeded' }));
-            const detail = await store.getFailedTaskDetail('t-succeeded');
-            expect(detail).toBeNull();
-        });
-        it('returns null for a pending task (wrong status)', async () => {
-            await store.createTask(makeTaskInput({ taskId: 't-pending', status: 'pending' }));
-            const detail = await store.getFailedTaskDetail('t-pending');
-            expect(detail).toBeNull();
-        });
-        it('returns detail for needs_human_review status', async () => {
-            await store.createTask(makeTaskInput({ taskId: 't-review-detail', status: 'needs_human_review' }));
-            const detail = await store.getFailedTaskDetail('t-review-detail');
-            expect(detail).not.toBeNull();
-            if (!detail)
-                return;
-            expect(detail.task.status).toBe('needs_human_review');
-        });
-    });
-    // ── countFailedTasks ───────────────────────────────────────────────────────
-    describe('countFailedTasks', () => {
-        it('counts all failed + needs_human_review tasks', async () => {
-            await store.createTask(makeTaskInput({ taskId: 'c-1', status: 'failed' }));
-            await store.createTask(makeTaskInput({ taskId: 'c-2', status: 'needs_human_review' }));
-            await store.createTask(makeTaskInput({ taskId: 'c-3', status: 'succeeded' }));
-            await store.createTask(makeTaskInput({ taskId: 'c-4', status: 'pending' }));
-            const count = await store.countFailedTasks();
-            expect(count).toBe(2);
-        });
-        it('counts zero when no failed tasks', async () => {
-            await store.createTask(makeTaskInput({ taskId: 'c-ok', status: 'succeeded' }));
-            const count = await store.countFailedTasks();
-            expect(count).toBe(0);
-        });
-        it('counts with kind filter', async () => {
-            await store.createTask(makeTaskInput({ taskId: 'c-d1', status: 'failed', taskKind: 'diagnostician' }));
-            await store.createTask(makeTaskInput({ taskId: 'c-d2', status: 'failed', taskKind: 'diagnostician' }));
-            await store.createTask(makeTaskInput({ taskId: 'c-s1', status: 'failed', taskKind: 'scribe' }));
-            const diagCount = await store.countFailedTasks({ kind: 'diagnostician' });
-            expect(diagCount).toBe(2);
-        });
-        it('counts with since filter', async () => {
-            const oldTime = new Date(Date.now() - 10 * 24 * 60 * 60 * 1000).toISOString();
-            const recentTime = new Date(Date.now() - 1 * 24 * 60 * 60 * 1000).toISOString();
-            await store.createTask(makeTaskInput({ taskId: 'c-old', status: 'failed' }));
-            await runStore.createRun(makeRunInput({ taskId: 'c-old', startedAt: oldTime }));
-            await store.createTask(makeTaskInput({ taskId: 'c-recent', status: 'failed' }));
-            await runStore.createRun(makeRunInput({ taskId: 'c-recent', startedAt: recentTime }));
-            const sinceMs = Date.now() - 5 * 24 * 60 * 60 * 1000;
-            const count = await store.countFailedTasks({ since: sinceMs });
-            expect(count).toBe(1);
-        });
-        it('count matches listFailedTasks length', async () => {
-            for (let i = 0; i < 5; i++) {
-                await store.createTask(makeTaskInput({ taskId: `c-match-${i}`, status: 'failed' }));
-            }
-            const list = await store.listFailedTasks();
-            const count = await store.countFailedTasks();
-            expect(count).toBe(list.length);
-        });
-    });
-});
-//# sourceMappingURL=sqlite-task-store.failed-tasks.test.js.map