@principles/core 1.287.1 → 1.287.2

package/dist/runtime-v2/feature-flags/__tests__/surface-guard-policy.test.js

@@ -1,246 +0,0 @@
-import { describe, it, expect, vi, beforeEach } from 'vitest';
-import { checkSurfaceGuard, isSurfaceEnabled, guardHook, guardService, getSurfaceIdForHook, getSurfaceIdForService, __resetSurfaceGuardSkipLogStateForTests, } from '../surface-guard-policy.js';
-import { PLUGIN_SURFACE_REGISTRY } from '../plugin-surface-registry.js';
-describe('surface-guard', () => {
-    beforeEach(() => {
-        // Each test starts with a clean surface-guard skip log state so the
-        // first-fire assertions are deterministic (PRI-298).
-        __resetSurfaceGuardSkipLogStateForTests();
-        vi.clearAllMocks();
-    });
-    describe('getSurfaceIdForHook', () => {
-        it('generates correct surface id without label', () => {
-            expect(getSurfaceIdForHook('before_tool_call')).toBe('hook:before_tool_call');
-        });
-        it('generates correct surface id with label', () => {
-            expect(getSurfaceIdForHook('after_tool_call', 'trajectory')).toBe('hook:after_tool_call.trajectory');
-        });
-    });
-    describe('getSurfaceIdForService', () => {
-        it('generates correct surface id for service', () => {
-            expect(getSurfaceIdForService('evolution-worker')).toBe('service:evolution-worker');
-        });
-    });
-    describe('checkSurfaceGuard', () => {
-        it('returns passed=true when registry is valid', () => {
-            const result = checkSurfaceGuard();
-            expect(result.passed).toBe(true);
-            expect(result.violations).toEqual([]);
-        });
-        it('includes enabled core surfaces', () => {
-            const result = checkSurfaceGuard();
-            expect(result.enabledCoreSurfaces.length).toBeGreaterThan(0);
-            for (const surfaceId of result.enabledCoreSurfaces) {
-                const entry = PLUGIN_SURFACE_REGISTRY.find(s => s.id === surfaceId);
-                expect(entry).toBeDefined();
-                expect(entry?.category).toBe('core');
-            }
-        });
-        it('includes disabled non-core surfaces', () => {
-            const result = checkSurfaceGuard();
-            expect(result.disabledNonCoreSurfaces.length).toBeGreaterThan(0);
-            for (const surfaceId of result.disabledNonCoreSurfaces) {
-                const entry = PLUGIN_SURFACE_REGISTRY.find(s => s.id === surfaceId);
-                expect(entry).toBeDefined();
-                expect(entry?.category).not.toBe('core');
-                expect(entry?.enabledByDefault).toBe(false);
-            }
-        });
-        it('returns violations when non-core surface is enabledByDefault', () => {
-            const result = checkSurfaceGuard();
-            const nonCoreEnabled = PLUGIN_SURFACE_REGISTRY.filter(s => s.category !== 'core' && s.enabledByDefault);
-            if (nonCoreEnabled.length > 0) {
-                expect(result.violations.length).toBeGreaterThan(0);
-            }
-        });
-    });
-    describe('isSurfaceEnabled', () => {
-        it('returns enabled=true for core surface without override', () => {
-            const result = isSurfaceEnabled('hook:before_prompt_build');
-            expect(result.enabled).toBe(true);
-            expect(result.reason).toBeUndefined();
-        });
-        it('returns enabled=false for quiet surface without override', () => {
-            const result = isSurfaceEnabled('hook:after_tool_call.trajectory');
-            expect(result.enabled).toBe(false);
-            expect(result.reason).toBeDefined();
-        });
-        it('returns reason when surface not found', () => {
-            const result = isSurfaceEnabled('hook:nonexistent_hook');
-            expect(result.enabled).toBe(false);
-            expect(result.reason).toContain('not found in registry');
-        });
-        it('allows override for quiet surface', () => {
-            const result = isSurfaceEnabled('hook:before_reset', {
-                'hook:before_reset': true,
-            });
-            expect(result.enabled).toBe(true);
-        });
-        it('ignores non-boolean override', () => {
-            const result = isSurfaceEnabled('hook:before_prompt_build', {
-                'hook:before_prompt_build': 'yes',
-            });
-            expect(result.enabled).toBe(true);
-        });
-        it('cannot disable core surface', () => {
-            const result = isSurfaceEnabled('hook:before_prompt_build', {
-                'hook:before_prompt_build': false,
-            });
-            expect(result.enabled).toBe(true);
-            expect(result.reason).toContain('core');
-        });
-        it('returns disabledReason for disabled surface', () => {
-            const result = isSurfaceEnabled('service:pd-task');
-            expect(result.enabled).toBe(false);
-            expect(result.reason).toContain('pd-task');
-        });
-    });
-    describe('guardHook', () => {
-        beforeEach(() => {
-            vi.clearAllMocks();
-        });
-        it('returns original handler for enabled surface', () => {
-            const mockHandler = vi.fn().mockReturnValue('result');
-            const guarded = guardHook('hook:before_prompt_build', undefined, mockHandler);
-            const result = guarded({}, {});
-            expect(mockHandler).toHaveBeenCalled();
-            expect(result).toBe('result');
-        });
-        it('returns no-op for disabled surface without logger', () => {
-            const mockHandler = vi.fn();
-            const guarded = guardHook('hook:after_tool_call.trajectory', undefined, mockHandler);
-            const result = guarded({}, {});
-            expect(mockHandler).not.toHaveBeenCalled();
-            expect(result).toBeUndefined();
-        });
-        it('logs when surface is disabled with logger', () => {
-            const mockLogger = { info: vi.fn(), debug: vi.fn() };
-            const mockHandler = vi.fn();
-            const guarded = guardHook('hook:after_tool_call.trajectory', mockLogger, mockHandler);
-            guarded({}, {});
-            expect(mockLogger.info).toHaveBeenCalled();
-            expect(mockHandler).not.toHaveBeenCalled();
-        });
-        it('does not log at guardHook construction time (PRI-298 / chatgpt P2)', () => {
-            const mockLogger = { info: vi.fn(), debug: vi.fn() };
-            guardHook('hook:after_tool_call.trajectory', mockLogger, vi.fn());
-            expect(mockLogger.info).not.toHaveBeenCalled();
-        });
-        it('logger undefined on first fire does not consume the one-shot slot (PRI-298 / coderabbit Major)', () => {
-            const handler1 = guardHook('hook:after_tool_call.trajectory', undefined, vi.fn());
-            handler1({}, {});
-            const mockLogger = { info: vi.fn(), debug: vi.fn() };
-            const handler2 = guardHook('hook:after_tool_call.trajectory', mockLogger, vi.fn());
-            handler2({}, {});
-            expect(mockLogger.info).toHaveBeenCalledTimes(1);
-            expect(mockLogger.info).toHaveBeenCalledWith(expect.stringContaining('[PD:surface-guard] SKIP hook:after_tool_call.trajectory'));
-            const handler3 = guardHook('hook:after_tool_call.trajectory', mockLogger, vi.fn());
-            handler3({}, {});
-            expect(mockLogger.info).toHaveBeenCalledTimes(1);
-        });
-        it('does not log for enabled surface', () => {
-            const mockLogger = { info: vi.fn(), debug: vi.fn() };
-            const mockHandler = vi.fn();
-            const guarded = guardHook('hook:before_prompt_build', mockLogger, mockHandler);
-            guarded({}, {});
-            expect(mockLogger.info).not.toHaveBeenCalled();
-        });
-        it('guards unknown surface with not-found reason', () => {
-            const mockLogger = { info: vi.fn(), debug: vi.fn() };
-            const guarded = guardHook('hook:unknown_hook', mockLogger, vi.fn());
-            guarded({}, {});
-            expect(mockLogger.info).toHaveBeenCalledWith(expect.stringContaining('not found in registry'));
-        });
-        it('logs once on first fire and stays silent on subsequent fires (PRI-298 rate-limit)', () => {
-            const mockLogger = { info: vi.fn(), debug: vi.fn() };
-            const mockHandler = vi.fn();
-            const guarded = guardHook('hook:after_tool_call.trajectory', mockLogger, mockHandler);
-            guarded({}, {});
-            expect(mockLogger.info).toHaveBeenCalledTimes(1);
-            expect(mockLogger.info).toHaveBeenCalledWith(expect.stringContaining('[PD:surface-guard] SKIP hook:after_tool_call.trajectory'));
-            for (let i = 0; i < 5; i += 1) {
-                guarded({}, {});
-            }
-            expect(mockLogger.info).toHaveBeenCalledTimes(1);
-            expect(mockHandler).not.toHaveBeenCalled();
-        });
-        it('logs first fire per surfaceId independently (one log per quiet surface)', () => {
-            const mockLogger = { info: vi.fn(), debug: vi.fn() };
-            const handler1 = guardHook('hook:after_tool_call.trajectory', mockLogger, vi.fn());
-            const handler2 = guardHook('hook:llm_output.trajectory', mockLogger, vi.fn());
-            const handler3 = guardHook('hook:subagent_spawning', mockLogger, vi.fn());
-            handler1({}, {});
-            handler2({}, {});
-            handler3({}, {});
-            expect(mockLogger.info).toHaveBeenCalledTimes(3);
-            const calls = mockLogger.info.mock.calls.map(c => String(c[0]));
-            expect(calls.some(c => c.includes('hook:after_tool_call.trajectory'))).toBe(true);
-            expect(calls.some(c => c.includes('hook:llm_output.trajectory'))).toBe(true);
-            expect(calls.some(c => c.includes('hook:subagent_spawning'))).toBe(true);
-        });
-    });
-    describe('guardService', () => {
-        beforeEach(() => {
-            vi.clearAllMocks();
-        });
-        it('returns original service for enabled surface', () => {
-            const mockService = { id: 'test-service' };
-            const result = guardService('hook:before_prompt_build', mockService);
-            expect(result).toBe(mockService);
-        });
-        it('returns null for disabled surface without logger', () => {
-            const mockService = { id: 'test-service' };
-            const result = guardService('hook:after_tool_call.trajectory', mockService);
-            expect(result).toBeNull();
-        });
-        it('logs when surface is disabled with logger', () => {
-            const mockLogger = { info: vi.fn(), debug: vi.fn() };
-            const mockService = { id: 'test-service' };
-            const result = guardService('hook:after_tool_call.trajectory', mockService, mockLogger);
-            expect(result).toBeNull();
-            expect(mockLogger.info).toHaveBeenCalledWith(expect.stringContaining('SKIP service'));
-        });
-        it('returns null for unknown surface', () => {
-            const mockService = { id: 'test-service' };
-            const result = guardService('service:nonexistent', mockService);
-            expect(result).toBeNull();
-        });
-        it('logs once per service surface on first registration (PRI-298 rate-limit)', () => {
-            const mockLogger = { info: vi.fn(), debug: vi.fn() };
-            const service = { id: 'test-service' };
-            const first = guardService('service:evolution-worker', service, mockLogger);
-            expect(first).toBeNull();
-            expect(mockLogger.info).toHaveBeenCalledTimes(1);
-            expect(mockLogger.info).toHaveBeenCalledWith(expect.stringContaining('SKIP service service:evolution-worker'));
-            guardService('service:evolution-worker', service, mockLogger);
-            guardService('service:evolution-worker', service, mockLogger);
-            expect(mockLogger.info).toHaveBeenCalledTimes(1);
-        });
-    });
-    describe('PRI-298 disabledReason copy', () => {
-        it('no quiet surface disabledReason references "Story A" or "Story A\'"', () => {
-            const quietOrNonCore = PLUGIN_SURFACE_REGISTRY.filter(s => s.category === 'quiet' || s.category === 'gone' || s.category === 'legacy_retire');
-            expect(quietOrNonCore.length).toBeGreaterThan(0);
-            for (const surface of quietOrNonCore) {
-                expect(surface.disabledReason).toBeDefined();
-                expect(surface.disabledReason).not.toMatch(/Story A/);
-                expect(surface.disabledReason).not.toMatch(/MVP\s*验收/);
-                expect(surface.disabledReason).not.toMatch(/测试任务/);
-            }
-        });
-        it('subagent/shadow hooks removed from registry (PRI-448)', () => {
-            const subagent = PLUGIN_SURFACE_REGISTRY.find(s => s.id === 'hook:subagent_spawning');
-            expect(subagent).toBeUndefined();
-        });
-        it('no quiet surface disabledReason promises a feature flag override (PRI-298 / chatgpt P2)', () => {
-            const quiet = PLUGIN_SURFACE_REGISTRY.filter(s => s.category === 'quiet');
-            expect(quiet.length).toBeGreaterThan(0);
-            for (const surface of quiet) {
-                const reason = (surface.disabledReason ?? '').toLowerCase();
-                expect(reason).not.toContain('enable via feature flag');
-                expect(reason).not.toMatch(/enable via .* override/);
-            }
-        });
-    });
-});
-//# sourceMappingURL=surface-guard-policy.test.js.map

package/dist/runtime-v2/feature-flags/__tests__/surface-guard-policy.test.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"surface-guard-policy.test.js","sourceRoot":"","sources":["../../../../src/runtime-v2/feature-flags/__tests__/surface-guard-policy.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,UAAU,EAAE,MAAM,QAAQ,CAAC;AAC9D,OAAO,EACL,iBAAiB,EACjB,gBAAgB,EAChB,SAAS,EACT,YAAY,EACZ,mBAAmB,EACnB,sBAAsB,EACtB,uCAAuC,GACxC,MAAM,4BAA4B,CAAC;AACpC,OAAO,EAAE,uBAAuB,EAAE,MAAM,+BAA+B,CAAC;AAExE,QAAQ,CAAC,eAAe,EAAE,GAAG,EAAE;IAC7B,UAAU,CAAC,GAAG,EAAE;QACd,oEAAoE;QACpE,qDAAqD;QACrD,uCAAuC,EAAE,CAAC;QAC1C,EAAE,CAAC,aAAa,EAAE,CAAC;IACrB,CAAC,CAAC,CAAC;IACH,QAAQ,CAAC,qBAAqB,EAAE,GAAG,EAAE;QACnC,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;YACpD,MAAM,CAAC,mBAAmB,CAAC,kBAAkB,CAAC,CAAC,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC;QAChF,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,yCAAyC,EAAE,GAAG,EAAE;YACjD,MAAM,CAAC,mBAAmB,CAAC,iBAAiB,EAAE,YAAY,CAAC,CAAC,CAAC,IAAI,CAAC,iCAAiC,CAAC,CAAC;QACvG,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;QACtC,EAAE,CAAC,0CAA0C,EAAE,GAAG,EAAE;YAClD,MAAM,CAAC,sBAAsB,CAAC,kBAAkB,CAAC,CAAC,CAAC,IAAI,CAAC,0BAA0B,CAAC,CAAC;QACtF,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,mBAAmB,EAAE,GAAG,EAAE;QACjC,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;YACpD,MAAM,MAAM,GAAG,iBAAiB,EAAE,CAAC;YACnC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACjC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QACxC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,gCAAgC,EAAE,GAAG,EAAE;YACxC,MAAM,MAAM,GAAG,iBAAiB,EAAE,CAAC;YACnC,MAAM,CAAC,MAAM,CAAC,mBAAmB,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;YAC7D,KAAK,MAAM,SAAS,IAAI,MAAM,CAAC,mBAAmB,EAAE,CAAC;gBACnD,MAAM,KAAK,GAAG,uBAAuB,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,SAAS,CAAC,CAAC;gBACpE,MAAM,CAAC,KAAK,CAAC,CAAC,WAAW,EAAE,CAAC;gBAC5B,MAAM,CAAC,KAAK,EAAE,QAAQ,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;YACvC,CAAC;QACH,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,qCAAqC,EAAE,GAAG,EAAE;YAC7C,MAAM,MAAM,GAAG,iBAAiB,EAAE,CAAC;YACnC,MAAM,CAAC,MAAM,CAAC,uBAAuB,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;YACjE,KAAK,MAAM,SAAS,IAAI,MAAM,CAAC,uBAAuB,EAAE,CAAC;gBACvD,MAAM,KAAK,GAAG,uBAAuB,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,SAAS,CAAC,CAAC;gBACpE,MAAM,CAAC,KAAK,CAAC,CAAC,WAAW,EAAE,CAAC;gBAC5B,MAAM,CAAC,KAAK,EAAE,QAAQ,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;gBACzC,MAAM,CAAC,KAAK,EAAE,gBAAgB,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YAC9C,CAAC;QACH,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,8DAA8D,EAAE,GAAG,EAAE;YACtE,MAAM,MAAM,GAAG,iBAAiB,EAAE,CAAC;YACnC,MAAM,cAAc,GAAG,uBAAuB,CAAC,MAAM,CACnD,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,MAAM,IAAI,CAAC,CAAC,gBAAgB,CACjD,CAAC;YACF,IAAI,cAAc,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;gBAC9B,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;YACtD,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,kBAAkB,EAAE,GAAG,EAAE;QAChC,EAAE,CAAC,wDAAwD,EAAE,GAAG,EAAE;YAChE,MAAM,MAAM,GAAG,gBAAgB,CAAC,0BAA0B,CAAC,CAAC;YAC5D,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAClC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,aAAa,EAAE,CAAC;QACxC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,0DAA0D,EAAE,GAAG,EAAE;YAClE,MAAM,MAAM,GAAG,gBAAgB,CAAC,iCAAiC,CAAC,CAAC;YACnE,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACnC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,WAAW,EAAE,CAAC;QACtC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;YAC/C,MAAM,MAAM,GAAG,gBAAgB,CAAC,uBAAuB,CAAC,CAAC;YACzD,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACnC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,uBAAuB,CAAC,CAAC;QAC3D,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,mCAAmC,EAAE,GAAG,EAAE;YAC3C,MAAM,MAAM,GAAG,gBAAgB,CAAC,mBAAmB,EAAE;gBACnD,mBAAmB,EAAE,IAAI;aAC1B,CAAC,CAAC;YACH,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACpC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,8BAA8B,EAAE,GAAG,EAAE;YACtC,MAAM,MAAM,GAAG,gBAAgB,CAAC,0BAA0B,EAAE;gBAC1D,0BAA0B,EAAE,KAA2B;aACxD,CAAC,CAAC;YACH,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACpC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,6BAA6B,EAAE,GAAG,EAAE;YACrC,MAAM,MAAM,GAAG,gBAAgB,CAAC,0BAA0B,EAAE;gBAC1D,0BAA0B,EAAE,KAAK;aAClC,CAAC,CAAC;YACH,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAClC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QAC1C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,6CAA6C,EAAE,GAAG,EAAE;YACrD,MAAM,MAAM,GAAG,gBAAgB,CAAC,iBAAiB,CAAC,CAAC;YACnD,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACnC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC;QAC7C,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,WAAW,EAAE,GAAG,EAAE;QACzB,UAAU,CAAC,GAAG,EAAE;YACd,EAAE,CAAC,aAAa,EAAE,CAAC;QACrB,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,8CAA8C,EAAE,GAAG,EAAE;YACtD,MAAM,WAAW,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC;YACtD,MAAM,OAAO,GAAG,SAAS,CAAC,0BAA0B,EAAE,SAAS,EAAE,WAAW,CAAC,CAAC;YAC9E,MAAM,MAAM,GAAG,OAAO,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;YAC/B,MAAM,CAAC,WAAW,CAAC,CAAC,gBAAgB,EAAE,CAAC;YACvC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAChC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,mDAAmD,EAAE,GAAG,EAAE;YAC3D,MAAM,WAAW,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;YAC5B,MAAM,OAAO,GAAG,SAAS,CAAC,iCAAiC,EAAE,SAAS,EAAE,WAAW,CAAC,CAAC;YACrF,MAAM,MAAM,GAAG,OAAO,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;YAC/B,MAAM,CAAC,WAAW,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;YAC3C,MAAM,CAAC,MAAM,CAAC,CAAC,aAAa,EAAE,CAAC;QACjC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,2CAA2C,EAAE,GAAG,EAAE;YACnD,MAAM,UAAU,GAAG,EAAE,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,CAAC;YACrD,MAAM,WAAW,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;YAC5B,MAAM,OAAO,GAAG,SAAS,CAAC,iCAAiC,EAAE,UAAU,EAAE,WAAW,CAAC,CAAC;YACtF,OAAO,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;YAChB,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,gBAAgB,EAAE,CAAC;YAC3C,MAAM,CAAC,WAAW,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QAC7C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,oEAAoE,EAAE,GAAG,EAAE;YAC5E,MAAM,UAAU,GAAG,EAAE,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,CAAC;YACrD,SAAS,CAAC,iCAAiC,EAAE,UAAU,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC;YAClE,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QACjD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,gGAAgG,EAAE,GAAG,EAAE;YACxG,MAAM,QAAQ,GAAG,SAAS,CAAC,iCAAiC,EAAE,SAAS,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC;YAClF,QAAQ,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;YAEjB,MAAM,UAAU,GAAG,EAAE,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,CAAC;YACrD,MAAM,QAAQ,GAAG,SAAS,CAAC,iCAAiC,EAAE,UAAU,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC;YACnF,QAAQ,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;YAEjB,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;YACjD,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,oBAAoB,CAC1C,MAAM,CAAC,gBAAgB,CAAC,yDAAyD,CAAC,CACnF,CAAC;YAEF,MAAM,QAAQ,GAAG,SAAS,CAAC,iCAAiC,EAAE,UAAU,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC;YACnF,QAAQ,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;YACjB,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;QACnD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,kCAAkC,EAAE,GAAG,EAAE;YAC1C,MAAM,UAAU,GAAG,EAAE,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,CAAC;YACrD,MAAM,WAAW,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;YAC5B,MAAM,OAAO,GAAG,SAAS,CAAC,0BAA0B,EAAE,UAAU,EAAE,WAAW,CAAC,CAAC;YAC/E,OAAO,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;YAChB,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QACjD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,8CAA8C,EAAE,GAAG,EAAE;YACtD,MAAM,UAAU,GAAG,EAAE,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,CAAC;YACrD,MAAM,OAAO,GAAG,SAAS,CAAC,mBAAmB,EAAE,UAAU,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC;YACpE,OAAO,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;YAChB,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,oBAAoB,CAC1C,MAAM,CAAC,gBAAgB,CAAC,uBAAuB,CAAC,CACjD,CAAC;QACJ,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,mFAAmF,EAAE,GAAG,EAAE;YAC3F,MAAM,UAAU,GAAG,EAAE,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,CAAC;YACrD,MAAM,WAAW,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;YAC5B,MAAM,OAAO,GAAG,SAAS,CAAC,iCAAiC,EAAE,UAAU,EAAE,WAAW,CAAC,CAAC;YAEtF,OAAO,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;YAChB,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;YACjD,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,oBAAoB,CAC1C,MAAM,CAAC,gBAAgB,CAAC,yDAAyD,CAAC,CACnF,CAAC;YAEF,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,CAAC,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC9B,OAAO,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;YAClB,CAAC;YACD,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;YACjD,MAAM,CAAC,WAAW,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QAC7C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,yEAAyE,EAAE,GAAG,EAAE;YACjF,MAAM,UAAU,GAAG,EAAE,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,CAAC;YACrD,MAAM,QAAQ,GAAG,SAAS,CAAC,iCAAiC,EAAE,UAAU,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC;YACnF,MAAM,QAAQ,GAAG,SAAS,CAAC,4BAA4B,EAAE,UAAU,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC;YAC9E,MAAM,QAAQ,GAAG,SAAS,CAAC,wBAAwB,EAAE,UAAU,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC;YAE1E,QAAQ,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;YACjB,QAAQ,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;YACjB,QAAQ,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;YAEjB,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;YACjD,MAAM,KAAK,GAAG,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;YAChE,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,iCAAiC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAClF,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,4BAA4B,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAC7E,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,wBAAwB,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC3E,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,cAAc,EAAE,GAAG,EAAE;QAC5B,UAAU,CAAC,GAAG,EAAE;YACd,EAAE,CAAC,aAAa,EAAE,CAAC;QACrB,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,8CAA8C,EAAE,GAAG,EAAE;YACtD,MAAM,WAAW,GAAG,EAAE,EAAE,EAAE,cAAc,EAAE,CAAC;YAC3C,MAAM,MAAM,GAAG,YAAY,CAAC,0BAA0B,EAAE,WAAW,CAAC,CAAC;YACrE,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QACnC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,kDAAkD,EAAE,GAAG,EAAE;YAC1D,MAAM,WAAW,GAAG,EAAE,EAAE,EAAE,cAAc,EAAE,CAAC;YAC3C,MAAM,MAAM,GAAG,YAAY,CAAC,iCAAiC,EAAE,WAAW,CAAC,CAAC;YAC5E,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;QAC5B,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,2CAA2C,EAAE,GAAG,EAAE;YACnD,MAAM,UAAU,GAAG,EAAE,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,CAAC;YACrD,MAAM,WAAW,GAAG,EAAE,EAAE,EAAE,cAAc,EAAE,CAAC;YAC3C,MAAM,MAAM,GAAG,YAAY,CAAC,iCAAiC,EAAE,WAAW,EAAE,UAAU,CAAC,CAAC;YACxF,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;YAC1B,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,oBAAoB,CAC1C,MAAM,CAAC,gBAAgB,CAAC,cAAc,CAAC,CACxC,CAAC;QACJ,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,kCAAkC,EAAE,GAAG,EAAE;YAC1C,MAAM,WAAW,GAAG,EAAE,EAAE,EAAE,cAAc,EAAE,CAAC;YAC3C,MAAM,MAAM,GAAG,YAAY,CAAC,qBAAqB,EAAE,WAAW,CAAC,CAAC;YAChE,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;QAC5B,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,0EAA0E,EAAE,GAAG,EAAE;YAClF,MAAM,UAAU,GAAG,EAAE,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,CAAC;YACrD,MAAM,OAAO,GAAG,EAAE,EAAE,EAAE,cAAc,EAAE,CAAC;YAEvC,MAAM,KAAK,GAAG,YAAY,CAAC,0BAA0B,EAAE,OAAO,EAAE,UAAU,CAAC,CAAC;YAC5E,MAAM,CAAC,KAAK,CAAC,CAAC,QAAQ,EAAE,CAAC;YACzB,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;YACjD,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,oBAAoB,CAC1C,MAAM,CAAC,gBAAgB,CAAC,uCAAuC,CAAC,CACjE,CAAC;YAEF,YAAY,CAAC,0BAA0B,EAAE,OAAO,EAAE,UAAU,CAAC,CAAC;YAC9D,YAAY,CAAC,0BAA0B,EAAE,OAAO,EAAE,UAAU,CAAC,CAAC;YAC9D,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;QACnD,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,6BAA6B,EAAE,GAAG,EAAE;QAC3C,EAAE,CAAC,qEAAqE,EAAE,GAAG,EAAE;YAC7E,MAAM,cAAc,GAAG,uBAAuB,CAAC,MAAM,CACnD,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,IAAI,CAAC,CAAC,QAAQ,KAAK,MAAM,IAAI,CAAC,CAAC,QAAQ,KAAK,eAAe,CACvF,CAAC;YACF,MAAM,CAAC,cAAc,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;YACjD,KAAK,MAAM,OAAO,IAAI,cAAc,EAAE,CAAC;gBACrC,MAAM,CAAC,OAAO,CAAC,cAAc,CAAC,CAAC,WAAW,EAAE,CAAC;gBAC7C,MAAM,CAAC,OAAO,CAAC,cAAc,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC;gBACtD,MAAM,CAAC,OAAO,CAAC,cAAc,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;gBACvD,MAAM,CAAC,OAAO,CAAC,cAAc,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC;YACrD,CAAC;QACH,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;YAC/D,MAAM,QAAQ,GAAG,uBAAuB,CAAC,IAAI,CAC3C,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,KAAK,wBAAwB,CACvC,CAAC;YACF,MAAM,CAAC,QAAQ,CAAC,CAAC,aAAa,EAAE,CAAC;QACnC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,yFAAyF,EAAE,GAAG,EAAE;YACjG,MAAM,KAAK,GAAG,uBAAuB,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC;YAC1E,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;YACxC,KAAK,MAAM,OAAO,IAAI,KAAK,EAAE,CAAC;gBAC5B,MAAM,MAAM,GAAG,CAAC,OAAO,CAAC,cAAc,IAAI,EAAE,CAAC,CAAC,WAAW,EAAE,CAAC;gBAC5D,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,yBAAyB,CAAC,CAAC;gBACxD,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,wBAAwB,CAAC,CAAC;YACvD,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/runtime-v2/feedback/__tests__/create-report-agent-draft.test.d.ts

@@ -1,2 +0,0 @@
-export {};
-//# sourceMappingURL=create-report-agent-draft.test.d.ts.map

package/dist/runtime-v2/feedback/__tests__/create-report-agent-draft.test.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"create-report-agent-draft.test.d.ts","sourceRoot":"","sources":["../../../../src/runtime-v2/feedback/__tests__/create-report-agent-draft.test.ts"],"names":[],"mappings":""}

package/dist/runtime-v2/feedback/__tests__/create-report-agent-draft.test.js

@@ -1,221 +0,0 @@
-/**
- * Task 13 tests: createFeedbackReport agentDraft merge from PendingAgentDraftStore.
- *
- * Verifies:
- * - taskId without store → normal report, no agentDraft
- * - taskId with store but no pending draft → normal report, no agentDraft
- * - taskId with store + pending draft → report merges agentDraft, marks consumed
- * - user-provided agentDraft takes priority over store draft, but store draft still consumed
- * - store.getUnconsumedByTaskId throws → rc-9: report still created, error in redactionNotes
- * - store.markConsumed throws → rc-9: report still created, error in redactionNotes
- * - no taskId with store provided → store is not queried
- *
- * ERR checklist:
- * - EP-01 / ERR-001, ERR-005: no `as` casts on untrusted input. Test inputs are
- *   plain objects passed as `unknown` to createFeedbackReport.
- * - EP-03 / ERR-002, rc-9: store operation failures do not silently swallow —
- *   errors are recorded in report.privacy.redactionNotes.
- * - EP-03 / ERR-009, ERR-010: corrupt agent_draft JSON in the store fails loud
- *   inside getUnconsumedByTaskId (throws), caught by createFeedbackReport.
- */
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
-import * as path from 'node:path';
-import * as os from 'node:os';
-import * as fs from 'node:fs';
-import { SqliteConnection } from '../../store/sqlite-connection.js';
-import { PendingAgentDraftStore, } from '../pending-agent-draft-store.js';
-import { createFeedbackReport } from '../create-report.js';
-const baseInput = {
-    type: 'bug',
-    title: 'Test feedback',
-    description: 'Something went wrong during task execution',
-};
-const diagnostics = {};
-/**
- * Test-only subclass of PendingAgentDraftStore whose markConsumed always
- * throws. Used to verify the rc-9 defensive path in createFeedbackReport.
- * getUnconsumedByTaskId is inherited unchanged (works against the real DB).
- */
-class ThrowingMarkConsumedStore extends PendingAgentDraftStore {
-    // eslint-disable-next-line @typescript-eslint/class-methods-use-this
-    markConsumed(_id) {
-        throw new Error('mock markConsumed failure');
-    }
-}
-describe('createFeedbackReport — Task 13 agentDraft merge', () => {
-    let connection;
-    let store;
-    let tmpDir;
-    beforeEach(() => {
-        tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pd-test-create-report-'));
-        connection = new SqliteConnection(tmpDir);
-        connection.getDb(); // triggers initSchema (creates pending_agent_drafts table)
-        store = new PendingAgentDraftStore(connection);
-    });
-    afterEach(() => {
-        try {
-            connection?.close();
-        }
-        catch {
-            // best-effort close
-        }
-    });
-    describe('taskId without store', () => {
-        it('creates a normal report without agentDraft when store is not provided', () => {
-            const input = { ...baseInput, taskId: 'task-123' };
-            const result = createFeedbackReport(input, diagnostics, undefined, undefined);
-            expect(result.ok).toBe(true);
-            if (result.ok) {
-                expect(result.report.agentDraft).toBeUndefined();
-            }
-        });
-    });
-    describe('taskId with store but no pending draft', () => {
-        it('creates a normal report without agentDraft and does not call markConsumed', () => {
-            const input = { ...baseInput, taskId: 'task-no-draft' };
-            const result = createFeedbackReport(input, diagnostics, undefined, store);
-            expect(result.ok).toBe(true);
-            if (result.ok) {
-                expect(result.report.agentDraft).toBeUndefined();
-            }
-            // No draft existed, so none should be consumed
-            expect(store.getUnconsumedByTaskId('task-no-draft')).toBeNull();
-        });
-    });
-    describe('taskId with store and pending draft', () => {
-        it('merges the pending agent draft into the report and marks it consumed', () => {
-            const taskId = 'task-with-draft';
-            const draft = {
-                summary: 'Agent observed a timeout',
-                observedFailure: 'Error: connection timeout after 30s',
-                commandSummary: 'last command: pd runtime exec --task task-with-draft',
-            };
-            const insertResult = store.insertPendingDraft({ taskId, agentDraft: draft });
-            expect(insertResult.ok).toBe(true);
-            const input = { ...baseInput, taskId };
-            const result = createFeedbackReport(input, diagnostics, undefined, store);
-            expect(result.ok).toBe(true);
-            if (result.ok) {
-                expect(result.report.agentDraft).toBeDefined();
-                if (!result.report.agentDraft)
-                    throw new Error('agentDraft is null');
-                expect(result.report.agentDraft.summary).toBe('Agent observed a timeout');
-                expect(result.report.agentDraft.observedFailure).toBe('Error: connection timeout after 30s');
-                expect(result.report.agentDraft.commandSummary).toBe('last command: pd runtime exec --task task-with-draft');
-            }
-            // The draft should be consumed (consumedAt set)
-            expect(store.getUnconsumedByTaskId(taskId)).toBeNull();
-        });
-        it('merges a minimal draft (summary only) correctly', () => {
-            const taskId = 'task-minimal-draft';
-            store.insertPendingDraft({
-                taskId,
-                agentDraft: { summary: 'Minimal agent summary' },
-            });
-            const input = { ...baseInput, taskId };
-            const result = createFeedbackReport(input, diagnostics, undefined, store);
-            expect(result.ok).toBe(true);
-            if (result.ok) {
-                expect(result.report.agentDraft).toBeDefined();
-                if (!result.report.agentDraft)
-                    throw new Error('agentDraft is null');
-                expect(result.report.agentDraft.summary).toBe('Minimal agent summary');
-                expect(result.report.agentDraft.observedFailure).toBeUndefined();
-                expect(result.report.agentDraft.commandSummary).toBeUndefined();
-            }
-            expect(store.getUnconsumedByTaskId(taskId)).toBeNull();
-        });
-    });
-    describe('user-provided agentDraft takes priority', () => {
-        it('uses the user-provided agentDraft but still marks the store draft as consumed', () => {
-            const taskId = 'task-priority';
-            const storeDraft = {
-                summary: 'Agent summary (should not be used)',
-            };
-            store.insertPendingDraft({ taskId, agentDraft: storeDraft });
-            const input = {
-                ...baseInput,
-                taskId,
-                agentDraft: {
-                    summary: 'User-provided summary',
-                    observedFailure: 'User-provided failure',
-                },
-            };
-            const result = createFeedbackReport(input, diagnostics, undefined, store);
-            expect(result.ok).toBe(true);
-            if (result.ok) {
-                expect(result.report.agentDraft).toBeDefined();
-                if (!result.report.agentDraft)
-                    throw new Error('agentDraft is null');
-                expect(result.report.agentDraft.summary).toBe('User-provided summary');
-                expect(result.report.agentDraft.observedFailure).toBe('User-provided failure');
-            }
-            // The store draft should still be consumed (user's report supersedes it)
-            expect(store.getUnconsumedByTaskId(taskId)).toBeNull();
-        });
-    });
-    describe('no taskId with store provided', () => {
-        it('does not query the store when taskId is not provided', () => {
-            // Insert a draft for some task — it should NOT be touched
-            store.insertPendingDraft({
-                taskId: 'task-untouched',
-                agentDraft: { summary: 'should not be consumed' },
-            });
-            const input = { ...baseInput }; // no taskId
-            const result = createFeedbackReport(input, diagnostics, undefined, store);
-            expect(result.ok).toBe(true);
-            if (result.ok) {
-                expect(result.report.agentDraft).toBeUndefined();
-            }
-            // The draft should still be unconsumed
-            const row = store.getUnconsumedByTaskId('task-untouched');
-            expect(row).not.toBeNull();
-            if (!row)
-                throw new Error('row is null');
-            expect(row.agentDraft.summary).toBe('should not be consumed');
-        });
-    });
-    describe('store.getUnconsumedByTaskId throws (rc-9: no silent fallback)', () => {
-        it('creates the report without agentDraft and records the error in redactionNotes', () => {
-            const taskId = 'task-corrupt';
-            // Insert a row with corrupt JSON directly via raw SQL — the store's
-            // getUnconsumedByTaskId will throw when parsing the corrupt agent_draft.
-            const db = connection.getDb();
-            db.prepare('INSERT INTO pending_agent_drafts (id, task_id, pain_id, agent_draft, created_at, consumed_at) VALUES (?, ?, ?, ?, ?, ?)').run('pad-corrupt', taskId, null, '{not valid json', '2026-07-04T00:00:00Z', null);
-            const input = { ...baseInput, taskId };
-            const result = createFeedbackReport(input, diagnostics, undefined, store);
-            expect(result.ok).toBe(true);
-            if (result.ok) {
-                // No agentDraft merged — the store threw before returning a draft
-                expect(result.report.agentDraft).toBeUndefined();
-                // rc-9: error must be recorded in redactionNotes (not silently swallowed)
-                const notes = result.report.privacy.redactionNotes;
-                expect(notes.some((n) => n.includes('agent draft lookup failed'))).toBe(true);
-            }
-        });
-    });
-    describe('store.markConsumed throws (rc-9: no silent fallback)', () => {
-        it('creates the report with agentDraft and records the markConsumed error in redactionNotes', () => {
-            const throwingStore = new ThrowingMarkConsumedStore(connection);
-            const taskId = 'task-mark-throws';
-            const draft = {
-                summary: 'Agent summary for markConsumed test',
-            };
-            throwingStore.insertPendingDraft({ taskId, agentDraft: draft });
-            const input = { ...baseInput, taskId };
-            const result = createFeedbackReport(input, diagnostics, undefined, throwingStore);
-            expect(result.ok).toBe(true);
-            if (result.ok) {
-                // agentDraft was merged BEFORE markConsumed was called
-                expect(result.report.agentDraft).toBeDefined();
-                if (!result.report.agentDraft)
-                    throw new Error('agentDraft is null');
-                expect(result.report.agentDraft.summary).toBe('Agent summary for markConsumed test');
-                // rc-9: markConsumed error must be recorded in redactionNotes
-                const notes = result.report.privacy.redactionNotes;
-                expect(notes.some((n) => n.includes('agent draft markConsumed failed'))).toBe(true);
-            }
-        });
-    });
-});
-//# sourceMappingURL=create-report-agent-draft.test.js.map

package/dist/runtime-v2/feedback/__tests__/create-report-agent-draft.test.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"create-report-agent-draft.test.js","sourceRoot":"","sources":["../../../../src/runtime-v2/feedback/__tests__/create-report-agent-draft.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;GAmBG;AACH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAC;AACrE,OAAO,KAAK,IAAI,MAAM,WAAW,CAAC;AAClC,OAAO,KAAK,EAAE,MAAM,SAAS,CAAC;AAC9B,OAAO,KAAK,EAAE,MAAM,SAAS,CAAC;AAC9B,OAAO,EAAE,gBAAgB,EAAE,MAAM,kCAAkC,CAAC;AACpE,OAAO,EACL,sBAAsB,GAEvB,MAAM,iCAAiC,CAAC;AACzC,OAAO,EAAE,oBAAoB,EAAE,MAAM,qBAAqB,CAAC;AAE3D,MAAM,SAAS,GAAG;IAChB,IAAI,EAAE,KAAc;IACpB,KAAK,EAAE,eAAe;IACtB,WAAW,EAAE,4CAA4C;CAC1D,CAAC;AAEF,MAAM,WAAW,GAAG,EAAE,CAAC;AAEvB;;;;GAIG;AACH,MAAM,yBAA0B,SAAQ,sBAAsB;IAC5D,qEAAqE;IAC5D,YAAY,CAAC,GAAW;QAC/B,MAAM,IAAI,KAAK,CAAC,2BAA2B,CAAC,CAAC;IAC/C,CAAC;CACF;AAED,QAAQ,CAAC,iDAAiD,EAAE,GAAG,EAAE;IAC/D,IAAI,UAA4B,CAAC;IACjC,IAAI,KAA6B,CAAC;IAClC,IAAI,MAAc,CAAC;IAEnB,UAAU,CAAC,GAAG,EAAE;QACd,MAAM,GAAG,EAAE,CAAC,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,wBAAwB,CAAC,CAAC,CAAC;QAC1E,UAAU,GAAG,IAAI,gBAAgB,CAAC,MAAM,CAAC,CAAC;QAC1C,UAAU,CAAC,KAAK,EAAE,CAAC,CAAC,2DAA2D;QAC/E,KAAK,GAAG,IAAI,sBAAsB,CAAC,UAAU,CAAC,CAAC;IACjD,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,GAAG,EAAE;QACb,IAAI,CAAC;YACH,UAAU,EAAE,KAAK,EAAE,CAAC;QACtB,CAAC;QAAC,MAAM,CAAC;YACP,oBAAoB;QACtB,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,sBAAsB,EAAE,GAAG,EAAE;QACpC,EAAE,CAAC,uEAAuE,EAAE,GAAG,EAAE;YAC/E,MAAM,KAAK,GAAG,EAAE,GAAG,SAAS,EAAE,MAAM,EAAE,UAAU,EAAE,CAAC;YACnD,MAAM,MAAM,GAAG,oBAAoB,CAAC,KAAK,EAAE,WAAW,EAAE,SAAS,EAAE,SAAS,CAAC,CAAC;YAC9E,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAC7B,IAAI,MAAM,CAAC,EAAE,EAAE,CAAC;gBACd,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,aAAa,EAAE,CAAC;YACnD,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,wCAAwC,EAAE,GAAG,EAAE;QACtD,EAAE,CAAC,2EAA2E,EAAE,GAAG,EAAE;YACnF,MAAM,KAAK,GAAG,EAAE,GAAG,SAAS,EAAE,MAAM,EAAE,eAAe,EAAE,CAAC;YACxD,MAAM,MAAM,GAAG,oBAAoB,CAAC,KAAK,EAAE,WAAW,EAAE,SAAS,EAAE,KAAK,CAAC,CAAC;YAC1E,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAC7B,IAAI,MAAM,CAAC,EAAE,EAAE,CAAC;gBACd,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,aAAa,EAAE,CAAC;YACnD,CAAC;YACD,+CAA+C;YAC/C,MAAM,CAAC,KAAK,CAAC,qBAAqB,CAAC,eAAe,CAAC,CAAC,CAAC,QAAQ,EAAE,CAAC;QAClE,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,qCAAqC,EAAE,GAAG,EAAE;QACnD,EAAE,CAAC,sEAAsE,EAAE,GAAG,EAAE;YAC9E,MAAM,MAAM,GAAG,iBAAiB,CAAC;YACjC,MAAM,KAAK,GAAsB;gBAC/B,OAAO,EAAE,0BAA0B;gBACnC,eAAe,EAAE,qCAAqC;gBACtD,cAAc,EAAE,sDAAsD;aACvE,CAAC;YACF,MAAM,YAAY,GAAG,KAAK,CAAC,kBAAkB,CAAC,EAAE,MAAM,EAAE,UAAU,EAAE,KAAK,EAAE,CAAC,CAAC;YAC7E,MAAM,CAAC,YAAY,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAEnC,MAAM,KAAK,GAAG,EAAE,GAAG,SAAS,EAAE,MAAM,EAAE,CAAC;YACvC,MAAM,MAAM,GAAG,oBAAoB,CAAC,KAAK,EAAE,WAAW,EAAE,SAAS,EAAE,KAAK,CAAC,CAAC;YAC1E,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAC7B,IAAI,MAAM,CAAC,EAAE,EAAE,CAAC;gBACd,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,WAAW,EAAE,CAAC;gBAC/C,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU;oBAAE,MAAM,IAAI,KAAK,CAAC,oBAAoB,CAAC,CAAC;gBACrE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,0BAA0B,CAAC,CAAC;gBAC1E,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,eAAe,CAAC,CAAC,IAAI,CAAC,qCAAqC,CAAC,CAAC;gBAC7F,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,sDAAsD,CAAC,CAAC;YAC/G,CAAC;YACD,gDAAgD;YAChD,MAAM,CAAC,KAAK,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC,CAAC,QAAQ,EAAE,CAAC;QACzD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,iDAAiD,EAAE,GAAG,EAAE;YACzD,MAAM,MAAM,GAAG,oBAAoB,CAAC;YACpC,KAAK,CAAC,kBAAkB,CAAC;gBACvB,MAAM;gBACN,UAAU,EAAE,EAAE,OAAO,EAAE,uBAAuB,EAAE;aACjD,CAAC,CAAC;YAEH,MAAM,KAAK,GAAG,EAAE,GAAG,SAAS,EAAE,MAAM,EAAE,CAAC;YACvC,MAAM,MAAM,GAAG,oBAAoB,CAAC,KAAK,EAAE,WAAW,EAAE,SAAS,EAAE,KAAK,CAAC,CAAC;YAC1E,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAC7B,IAAI,MAAM,CAAC,EAAE,EAAE,CAAC;gBACd,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,WAAW,EAAE,CAAC;gBAC/C,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU;oBAAE,MAAM,IAAI,KAAK,CAAC,oBAAoB,CAAC,CAAC;gBACrE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC;gBACvE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,eAAe,CAAC,CAAC,aAAa,EAAE,CAAC;gBACjE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,cAAc,CAAC,CAAC,aAAa,EAAE,CAAC;YAClE,CAAC;YACD,MAAM,CAAC,KAAK,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC,CAAC,QAAQ,EAAE,CAAC;QACzD,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,yCAAyC,EAAE,GAAG,EAAE;QACvD,EAAE,CAAC,+EAA+E,EAAE,GAAG,EAAE;YACvF,MAAM,MAAM,GAAG,eAAe,CAAC;YAC/B,MAAM,UAAU,GAAsB;gBACpC,OAAO,EAAE,oCAAoC;aAC9C,CAAC;YACF,KAAK,CAAC,kBAAkB,CAAC,EAAE,MAAM,EAAE,UAAU,EAAE,UAAU,EAAE,CAAC,CAAC;YAE7D,MAAM,KAAK,GAAG;gBACZ,GAAG,SAAS;gBACZ,MAAM;gBACN,UAAU,EAAE;oBACV,OAAO,EAAE,uBAAuB;oBAChC,eAAe,EAAE,uBAAuB;iBACzC;aACF,CAAC;YACF,MAAM,MAAM,GAAG,oBAAoB,CAAC,KAAK,EAAE,WAAW,EAAE,SAAS,EAAE,KAAK,CAAC,CAAC;YAC1E,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAC7B,IAAI,MAAM,CAAC,EAAE,EAAE,CAAC;gBACd,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,WAAW,EAAE,CAAC;gBAC/C,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU;oBAAE,MAAM,IAAI,KAAK,CAAC,oBAAoB,CAAC,CAAC;gBACrE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC;gBACvE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,eAAe,CAAC,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC;YACjF,CAAC;YACD,yEAAyE;YACzE,MAAM,CAAC,KAAK,CAAC,qBAAqB,CAAC,MAAM,CAAC,CAAC,CAAC,QAAQ,EAAE,CAAC;QACzD,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,+BAA+B,EAAE,GAAG,EAAE;QAC7C,EAAE,CAAC,sDAAsD,EAAE,GAAG,EAAE;YAC9D,0DAA0D;YAC1D,KAAK,CAAC,kBAAkB,CAAC;gBACvB,MAAM,EAAE,gBAAgB;gBACxB,UAAU,EAAE,EAAE,OAAO,EAAE,wBAAwB,EAAE;aAClD,CAAC,CAAC;YAEH,MAAM,KAAK,GAAG,EAAE,GAAG,SAAS,EAAE,CAAC,CAAC,YAAY;YAC5C,MAAM,MAAM,GAAG,oBAAoB,CAAC,KAAK,EAAE,WAAW,EAAE,SAAS,EAAE,KAAK,CAAC,CAAC;YAC1E,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAC7B,IAAI,MAAM,CAAC,EAAE,EAAE,CAAC;gBACd,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,aAAa,EAAE,CAAC;YACnD,CAAC;YACD,uCAAuC;YACvC,MAAM,GAAG,GAAG,KAAK,CAAC,qBAAqB,CAAC,gBAAgB,CAAC,CAAC;YAC1D,MAAM,CAAC,GAAG,CAAC,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAC;YAC3B,IAAI,CAAC,GAAG;gBAAE,MAAM,IAAI,KAAK,CAAC,aAAa,CAAC,CAAC;YACzC,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,wBAAwB,CAAC,CAAC;QAChE,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,+DAA+D,EAAE,GAAG,EAAE;QAC7E,EAAE,CAAC,+EAA+E,EAAE,GAAG,EAAE;YACvF,MAAM,MAAM,GAAG,cAAc,CAAC;YAC9B,oEAAoE;YACpE,yEAAyE;YACzE,MAAM,EAAE,GAAG,UAAU,CAAC,KAAK,EAAE,CAAC;YAC9B,EAAE,CAAC,OAAO,CACR,yHAAyH,CAC1H,CAAC,GAAG,CAAC,aAAa,EAAE,MAAM,EAAE,IAAI,EAAE,iBAAiB,EAAE,sBAAsB,EAAE,IAAI,CAAC,CAAC;YAEpF,MAAM,KAAK,GAAG,EAAE,GAAG,SAAS,EAAE,MAAM,EAAE,CAAC;YACvC,MAAM,MAAM,GAAG,oBAAoB,CAAC,KAAK,EAAE,WAAW,EAAE,SAAS,EAAE,KAAK,CAAC,CAAC;YAC1E,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAC7B,IAAI,MAAM,CAAC,EAAE,EAAE,CAAC;gBACd,kEAAkE;gBAClE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,aAAa,EAAE,CAAC;gBACjD,0EAA0E;gBAC1E,MAAM,KAAK,GAAG,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,cAAc,CAAC;gBACnD,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,2BAA2B,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAChF,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,sDAAsD,EAAE,GAAG,EAAE;QACpE,EAAE,CAAC,yFAAyF,EAAE,GAAG,EAAE;YACjG,MAAM,aAAa,GAAG,IAAI,yBAAyB,CAAC,UAAU,CAAC,CAAC;YAEhE,MAAM,MAAM,GAAG,kBAAkB,CAAC;YAClC,MAAM,KAAK,GAAsB;gBAC/B,OAAO,EAAE,qCAAqC;aAC/C,CAAC;YACF,aAAa,CAAC,kBAAkB,CAAC,EAAE,MAAM,EAAE,UAAU,EAAE,KAAK,EAAE,CAAC,CAAC;YAEhE,MAAM,KAAK,GAAG,EAAE,GAAG,SAAS,EAAE,MAAM,EAAE,CAAC;YACvC,MAAM,MAAM,GAAG,oBAAoB,CAAC,KAAK,EAAE,WAAW,EAAE,SAAS,EAAE,aAAa,CAAC,CAAC;YAClF,MAAM,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAC7B,IAAI,MAAM,CAAC,EAAE,EAAE,CAAC;gBACd,uDAAuD;gBACvD,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,WAAW,EAAE,CAAC;gBAC/C,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU;oBAAE,MAAM,IAAI,KAAK,CAAC,oBAAoB,CAAC,CAAC;gBACrE,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,qCAAqC,CAAC,CAAC;gBACrF,8DAA8D;gBAC9D,MAAM,KAAK,GAAG,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,cAAc,CAAC;gBACnD,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,iCAAiC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACtF,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/runtime-v2/feedback/__tests__/fingerprint.test.d.ts

@@ -1,2 +0,0 @@
-export {};
-//# sourceMappingURL=fingerprint.test.d.ts.map

package/dist/runtime-v2/feedback/__tests__/fingerprint.test.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"fingerprint.test.d.ts","sourceRoot":"","sources":["../../../../src/runtime-v2/feedback/__tests__/fingerprint.test.ts"],"names":[],"mappings":""}