@principles/core 1.278.5 → 1.278.7

package/dist/runtime-v2/__tests__/recovery-sweep-service.test.js

@@ -5,6 +5,9 @@ const mockRecoverTask = vi.fn();
 const mockStateManagerClose = vi.fn();
 const mockInitialize = vi.fn();
 const mockAssertInitialized = vi.fn();
+const mockListTasks = vi.fn();
+const mockGetTask = vi.fn();
+const mockUpdateTask = vi.fn();
 vi.mock('../store/runtime-state-manager.js', () => ({
     RuntimeStateManager: vi.fn().mockImplementation(function () {
         this.initialize = mockInitialize;
@@ -13,8 +16,23 @@ vi.mock('../store/runtime-state-manager.js', () => ({
         this.recoverTask = mockRecoverTask;
         this.assertInitialized = mockAssertInitialized;
         this.isInitialized = true;
+        this.listTasks = mockListTasks;
+        this.getTask = mockGetTask;
+        this.updateTask = mockUpdateTask;
     }),
 }));
+function makeTask(overrides = {}) {
+    return {
+        taskId: 'task-x',
+        taskKind: 'dreamer',
+        status: 'failed',
+        createdAt: '2026-09-08T00:00:00.000Z',
+        updatedAt: '2026-09-08T00:00:00.000Z',
+        attemptCount: 1,
+        maxAttempts: 3,
+        ...overrides,
+    };
+}
 describe('createRecoverySweepService', () => {
     beforeEach(() => {
         vi.clearAllMocks();
@@ -80,4 +98,116 @@ describe('createRecoverySweepService', () => {
             .rejects.toThrow('DB init failed');
     });
 });
+describe('detectFailedTasks — recovery discovery (PRI-674)', () => {
+    beforeEach(() => {
+        vi.clearAllMocks();
+        vi.restoreAllMocks();
+        mockInitialize.mockResolvedValue(undefined);
+        mockStateManagerClose.mockResolvedValue(undefined);
+        mockAssertInitialized.mockReturnValue(undefined);
+        mockListTasks.mockResolvedValue([]);
+    });
+    it('returns failed diagnostician parent and diag_* stage tasks (GAP-1 regression)', async () => {
+        mockListTasks.mockResolvedValue([
+            makeTask({ taskId: 'diag-parent', taskKind: 'diagnostician', inputRef: 'pain-001' }),
+            makeTask({ taskId: 'diag-a', taskKind: 'diag_rootcause', inputRef: 'diag-parent' }),
+            makeTask({ taskId: 'diag-b', taskKind: 'diag_distiller', inputRef: 'diag-parent' }),
+            makeTask({ taskId: 'diag-c', taskKind: 'diag_router', inputRef: 'diag-parent' }),
+        ]);
+        const handle = await createRecoverySweepService({ workspaceDir: '/tmp/test-ws' });
+        const results = await handle.service.detectFailedTasks();
+        expect(results.map((r) => r.taskId).sort())
+            .toEqual(['diag-a', 'diag-b', 'diag-c', 'diag-parent']);
+        // inputRef is the persisted stage→parent linkage consumed by CLI
+        // execution guidance (PRI-674 review P2).
+        expect(results.find((r) => r.taskId === 'diag-a')?.inputRef).toBe('diag-parent');
+        expect(results.find((r) => r.taskId === 'diag-parent')?.inputRef).toBe('pain-001');
+    });
+    it('returns inputRef null when the task record has none', async () => {
+        mockListTasks.mockResolvedValue([
+            makeTask({ taskId: 'no-ref', taskKind: 'diag_router', inputRef: undefined }),
+        ]);
+        const handle = await createRecoverySweepService({ workspaceDir: '/tmp/test-ws' });
+        const results = await handle.service.detectFailedTasks();
+        expect(results).toHaveLength(1);
+        expect(results[0]?.inputRef).toBeNull();
+    });
+    it('still returns peer runner kinds with isExhausted computed', async () => {
+        mockListTasks.mockResolvedValue([
+            makeTask({ taskId: 'peer-dreamer', taskKind: 'dreamer', attemptCount: 1, maxAttempts: 3 }),
+            makeTask({ taskId: 'peer-rollout', taskKind: 'rollout_reviewer', attemptCount: 3, maxAttempts: 3 }),
+        ]);
+        const handle = await createRecoverySweepService({ workspaceDir: '/tmp/test-ws' });
+        const results = await handle.service.detectFailedTasks();
+        expect(results.map((r) => r.taskId).sort()).toEqual(['peer-dreamer', 'peer-rollout']);
+        expect(results.find((r) => r.taskId === 'peer-dreamer')?.isExhausted).toBe(false);
+        expect(results.find((r) => r.taskId === 'peer-rollout')?.isExhausted).toBe(true);
+    });
+    it('excludes failed tasks of unrelated kinds', async () => {
+        mockListTasks.mockResolvedValue([
+            makeTask({ taskId: 'other', taskKind: 'principle_candidate_intake' }),
+        ]);
+        const handle = await createRecoverySweepService({ workspaceDir: '/tmp/test-ws' });
+        const results = await handle.service.detectFailedTasks();
+        expect(results).toEqual([]);
+    });
+});
+describe('recoverFailedTask — reset semantics unchanged (PRI-674)', () => {
+    beforeEach(() => {
+        vi.clearAllMocks();
+        vi.restoreAllMocks();
+        mockInitialize.mockResolvedValue(undefined);
+        mockStateManagerClose.mockResolvedValue(undefined);
+        mockAssertInitialized.mockReturnValue(undefined);
+    });
+    it('resets a failed diagnostician task to pending with lease/attempts/result cleared', async () => {
+        mockGetTask.mockResolvedValue(makeTask({
+            taskId: 'diag-parent',
+            taskKind: 'diagnostician',
+            attemptCount: 1,
+            maxAttempts: 3,
+            lastError: 'max_attempts_exceeded',
+            leaseOwner: 'runner-1',
+            leaseExpiresAt: '2026-09-08T01:00:00.000Z',
+            resultRef: 'artifact://partial',
+        }));
+        mockUpdateTask.mockImplementation(async (taskId, patch) => makeTask({ taskId, taskKind: 'diagnostician', ...patch }));
+        const handle = await createRecoverySweepService({ workspaceDir: '/tmp/test-ws' });
+        const result = await handle.service.recoverFailedTask('diag-parent');
+        expect(mockUpdateTask).toHaveBeenCalledWith('diag-parent', {
+            status: 'pending',
+            attemptCount: 0,
+            maxAttempts: 3,
+            lastError: null,
+            leaseOwner: null,
+            leaseExpiresAt: null,
+            resultRef: null,
+        });
+        expect(result).toMatchObject({
+            taskId: 'diag-parent',
+            previousStatus: 'failed',
+            newStatus: 'pending',
+            forceApplied: false,
+        });
+    });
+    it('refuses an exhausted task without force (retry guard unchanged)', async () => {
+        mockGetTask.mockResolvedValue(makeTask({
+            taskId: 'diag-exhausted',
+            taskKind: 'diagnostician',
+            attemptCount: 3,
+            maxAttempts: 3,
+        }));
+        const handle = await createRecoverySweepService({ workspaceDir: '/tmp/test-ws' });
+        await expect(handle.service.recoverFailedTask('diag-exhausted'))
+            .rejects.toThrow(/exhausted max attempts/);
+        expect(mockUpdateTask).not.toHaveBeenCalled();
+    });
+    it('returns null for a task that is not failed', async () => {
+        mockGetTask.mockResolvedValue(makeTask({ taskId: 'diag-ok', status: 'succeeded' }));
+        const handle = await createRecoverySweepService({ workspaceDir: '/tmp/test-ws' });
+        const result = await handle.service.recoverFailedTask('diag-ok');
+        expect(result).toBeNull();
+        expect(mockUpdateTask).not.toHaveBeenCalled();
+    });
+});
 //# sourceMappingURL=recovery-sweep-service.test.js.map

package/dist/runtime-v2/__tests__/recovery-sweep-service.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"recovery-sweep-service.test.js","sourceRoot":"","sources":["../../../src/runtime-v2/__tests__/recovery-sweep-service.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,UAAU,EAAE,MAAM,QAAQ,CAAC;AAC9D,OAAO,EAAE,0BAA0B,EAAE,MAAM,8BAA8B,CAAC;AAE1E,MAAM,uBAAuB,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AACxC,MAAM,eAAe,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AAChC,MAAM,qBAAqB,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AACtC,MAAM,cAAc,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AAC/B,MAAM,qBAAqB,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AAEtC,EAAE,CAAC,IAAI,CAAC,mCAAmC,EAAE,GAAG,EAAE,CAAC,CAAC;IAClD,mBAAmB,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,kBAAkB,CAAC;QAC9C,IAAI,CAAC,UAAU,GAAG,cAAc,CAAC;QACjC,IAAI,CAAC,KAAK,GAAG,qBAAqB,CAAC;QACnC,IAAI,CAAC,mBAAmB,GAAG,uBAAuB,CAAC;QACnD,IAAI,CAAC,WAAW,GAAG,eAAe,CAAC;QACnC,IAAI,CAAC,iBAAiB,GAAG,qBAAqB,CAAC;QAC/C,IAAI,CAAC,aAAa,GAAG,IAAI,CAAC;IAC5B,CAAC,CAAC;CACH,CAAC,CAAC,CAAC;AAEJ,QAAQ,CAAC,4BAA4B,EAAE,GAAG,EAAE;IAC1C,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,aAAa,EAAE,CAAC;QACnB,EAAE,CAAC,eAAe,EAAE,CAAC;QACrB,cAAc,CAAC,iBAAiB,CAAC,SAAS,CAAC,CAAC;QAC5C,uBAAuB,CAAC,iBAAiB,CAAC,EAAE,CAAC,CAAC;QAC9C,eAAe,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;QACxC,qBAAqB,CAAC,iBAAiB,CAAC,SAAS,CAAC,CAAC;QACnD,qBAAqB,CAAC,eAAe,CAAC,SAAS,CAAC,CAAC;IACnD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,KAAK,IAAI,EAAE;QAClE,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,WAAW,EAAE,CAAC;QACrC,MAAM,CAAC,OAAO,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC/C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+CAA+C,EAAE,KAAK,IAAI,EAAE;QAC7D,uBAAuB,CAAC,iBAAiB,CAAC,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC,CAAC;QAChE,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,OAAO,GAAG,MAAM,MAAM,CAAC,OAAO,CAAC,mBAAmB,EAAE,CAAC;QAC3D,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC,CAAC;QAC9C,MAAM,CAAC,uBAAuB,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;IAC3D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uEAAuE,EAAE,KAAK,IAAI,EAAE;QACrF,eAAe,CAAC,iBAAiB,CAAC;YAChC,MAAM,EAAE,QAAQ;YAChB,WAAW,EAAE,0BAA0B;YACvC,cAAc,EAAE,QAAQ;YACxB,SAAS,EAAE,YAAY;YACvB,eAAe,EAAE,IAAI;SACtB,CAAC,CAAC;QACH,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,MAAM,GAAG,MAAM,MAAM,CAAC,OAAO,CAAC,WAAW,CAAC,QAAQ,CAAC,CAAC;QAC1D,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC;YACrB,MAAM,EAAE,QAAQ;YAChB,WAAW,EAAE,0BAA0B;YACvC,cAAc,EAAE,QAAQ;YACxB,SAAS,EAAE,YAAY;YACvB,eAAe,EAAE,IAAI;SACtB,CAAC,CAAC;QACH,MAAM,CAAC,eAAe,CAAC,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC;IACzD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4CAA4C,EAAE,KAAK,IAAI,EAAE;QAC1D,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,MAAM,CAAC,KAAK,EAAE,CAAC;QACrB,MAAM,MAAM,CAAC,KAAK,EAAE,CAAC;QACrB,MAAM,MAAM,CAAC,KAAK,EAAE,CAAC;QACrB,MAAM,CAAC,qBAAqB,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;IACzD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yDAAyD,EAAE,KAAK,IAAI,EAAE;QACvE,eAAe,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;QACxC,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,MAAM,GAAG,MAAM,MAAM,CAAC,OAAO,CAAC,WAAW,CAAC,kBAAkB,CAAC,CAAC;QACpE,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;IAC5B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4CAA4C,EAAE,KAAK,IAAI,EAAE;QAC1D,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,MAAM,CAAC,OAAO,CAAC,KAAK,EAAE,CAAC;QAC7B,MAAM,CAAC,qBAAqB,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IACvD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4DAA4D,EAAE,KAAK,IAAI,EAAE;QAC1E,cAAc,CAAC,qBAAqB,CAAC,IAAI,KAAK,CAAC,gBAAgB,CAAC,CAAC,CAAC;QAClE,MAAM,MAAM,CAAC,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;aACvE,OAAO,CAAC,OAAO,CAAC,gBAAgB,CAAC,CAAC;IACvC,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
+{"version":3,"file":"recovery-sweep-service.test.js","sourceRoot":"","sources":["../../../src/runtime-v2/__tests__/recovery-sweep-service.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,UAAU,EAAE,MAAM,QAAQ,CAAC;AAC9D,OAAO,EAAE,0BAA0B,EAAE,MAAM,8BAA8B,CAAC;AAG1E,MAAM,uBAAuB,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AACxC,MAAM,eAAe,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AAChC,MAAM,qBAAqB,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AACtC,MAAM,cAAc,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AAC/B,MAAM,qBAAqB,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AACtC,MAAM,aAAa,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AAC9B,MAAM,WAAW,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AAC5B,MAAM,cAAc,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AAE/B,EAAE,CAAC,IAAI,CAAC,mCAAmC,EAAE,GAAG,EAAE,CAAC,CAAC;IAClD,mBAAmB,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,kBAAkB,CAAC;QAC9C,IAAI,CAAC,UAAU,GAAG,cAAc,CAAC;QACjC,IAAI,CAAC,KAAK,GAAG,qBAAqB,CAAC;QACnC,IAAI,CAAC,mBAAmB,GAAG,uBAAuB,CAAC;QACnD,IAAI,CAAC,WAAW,GAAG,eAAe,CAAC;QACnC,IAAI,CAAC,iBAAiB,GAAG,qBAAqB,CAAC;QAC/C,IAAI,CAAC,aAAa,GAAG,IAAI,CAAC;QAC1B,IAAI,CAAC,SAAS,GAAG,aAAa,CAAC;QAC/B,IAAI,CAAC,OAAO,GAAG,WAAW,CAAC;QAC3B,IAAI,CAAC,UAAU,GAAG,cAAc,CAAC;IACnC,CAAC,CAAC;CACH,CAAC,CAAC,CAAC;AAEJ,SAAS,QAAQ,CAAC,SAAS,GAAwB,EAAE;IACnD,OAAO;QACL,MAAM,EAAE,QAAQ;QAChB,QAAQ,EAAE,SAAS;QACnB,MAAM,EAAE,QAAQ;QAChB,SAAS,EAAE,0BAA0B;QACrC,SAAS,EAAE,0BAA0B;QACrC,YAAY,EAAE,CAAC;QACf,WAAW,EAAE,CAAC;QACd,GAAG,SAAS;KACb,CAAC;AACJ,CAAC;AAED,QAAQ,CAAC,4BAA4B,EAAE,GAAG,EAAE;IAC1C,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,aAAa,EAAE,CAAC;QACnB,EAAE,CAAC,eAAe,EAAE,CAAC;QACrB,cAAc,CAAC,iBAAiB,CAAC,SAAS,CAAC,CAAC;QAC5C,uBAAuB,CAAC,iBAAiB,CAAC,EAAE,CAAC,CAAC;QAC9C,eAAe,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;QACxC,qBAAqB,CAAC,iBAAiB,CAAC,SAAS,CAAC,CAAC;QACnD,qBAAqB,CAAC,eAAe,CAAC,SAAS,CAAC,CAAC;IACnD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,KAAK,IAAI,EAAE;QAClE,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,WAAW,EAAE,CAAC;QACrC,MAAM,CAAC,OAAO,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC/C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+CAA+C,EAAE,KAAK,IAAI,EAAE;QAC7D,uBAAuB,CAAC,iBAAiB,CAAC,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC,CAAC;QAChE,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,OAAO,GAAG,MAAM,MAAM,CAAC,OAAO,CAAC,mBAAmB,EAAE,CAAC;QAC3D,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC,CAAC;QAC9C,MAAM,CAAC,uBAAuB,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;IAC3D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uEAAuE,EAAE,KAAK,IAAI,EAAE;QACrF,eAAe,CAAC,iBAAiB,CAAC;YAChC,MAAM,EAAE,QAAQ;YAChB,WAAW,EAAE,0BAA0B;YACvC,cAAc,EAAE,QAAQ;YACxB,SAAS,EAAE,YAAY;YACvB,eAAe,EAAE,IAAI;SACtB,CAAC,CAAC;QACH,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,MAAM,GAAG,MAAM,MAAM,CAAC,OAAO,CAAC,WAAW,CAAC,QAAQ,CAAC,CAAC;QAC1D,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC;YACrB,MAAM,EAAE,QAAQ;YAChB,WAAW,EAAE,0BAA0B;YACvC,cAAc,EAAE,QAAQ;YACxB,SAAS,EAAE,YAAY;YACvB,eAAe,EAAE,IAAI;SACtB,CAAC,CAAC;QACH,MAAM,CAAC,eAAe,CAAC,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC;IACzD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4CAA4C,EAAE,KAAK,IAAI,EAAE;QAC1D,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,MAAM,CAAC,KAAK,EAAE,CAAC;QACrB,MAAM,MAAM,CAAC,KAAK,EAAE,CAAC;QACrB,MAAM,MAAM,CAAC,KAAK,EAAE,CAAC;QACrB,MAAM,CAAC,qBAAqB,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;IACzD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yDAAyD,EAAE,KAAK,IAAI,EAAE;QACvE,eAAe,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;QACxC,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,MAAM,GAAG,MAAM,MAAM,CAAC,OAAO,CAAC,WAAW,CAAC,kBAAkB,CAAC,CAAC;QACpE,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;IAC5B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4CAA4C,EAAE,KAAK,IAAI,EAAE;QAC1D,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,MAAM,CAAC,OAAO,CAAC,KAAK,EAAE,CAAC;QAC7B,MAAM,CAAC,qBAAqB,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IACvD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4DAA4D,EAAE,KAAK,IAAI,EAAE;QAC1E,cAAc,CAAC,qBAAqB,CAAC,IAAI,KAAK,CAAC,gBAAgB,CAAC,CAAC,CAAC;QAClE,MAAM,MAAM,CAAC,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;aACvE,OAAO,CAAC,OAAO,CAAC,gBAAgB,CAAC,CAAC;IACvC,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,kDAAkD,EAAE,GAAG,EAAE;IAChE,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,aAAa,EAAE,CAAC;QACnB,EAAE,CAAC,eAAe,EAAE,CAAC;QACrB,cAAc,CAAC,iBAAiB,CAAC,SAAS,CAAC,CAAC;QAC5C,qBAAqB,CAAC,iBAAiB,CAAC,SAAS,CAAC,CAAC;QACnD,qBAAqB,CAAC,eAAe,CAAC,SAAS,CAAC,CAAC;QACjD,aAAa,CAAC,iBAAiB,CAAC,EAAE,CAAC,CAAC;IACtC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+EAA+E,EAAE,KAAK,IAAI,EAAE;QAC7F,aAAa,CAAC,iBAAiB,CAAC;YAC9B,QAAQ,CAAC,EAAE,MAAM,EAAE,aAAa,EAAE,QAAQ,EAAE,eAAe,EAAE,QAAQ,EAAE,UAAU,EAAE,CAAC;YACpF,QAAQ,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ,EAAE,gBAAgB,EAAE,QAAQ,EAAE,aAAa,EAAE,CAAC;YACnF,QAAQ,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ,EAAE,gBAAgB,EAAE,QAAQ,EAAE,aAAa,EAAE,CAAC;YACnF,QAAQ,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ,EAAE,aAAa,EAAE,QAAQ,EAAE,aAAa,EAAE,CAAC;SACjF,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,OAAO,GAAG,MAAM,MAAM,CAAC,OAAO,CAAC,iBAAiB,EAAE,CAAC;QAEzD,MAAM,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,CAAC;aACxC,OAAO,CAAC,CAAC,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,aAAa,CAAC,CAAC,CAAC;QAC1D,iEAAiE;QACjE,0CAA0C;QAC1C,MAAM,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,QAAQ,CAAC,EAAE,QAAQ,CAAC,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC;QACjF,MAAM,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,aAAa,CAAC,EAAE,QAAQ,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IACrF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qDAAqD,EAAE,KAAK,IAAI,EAAE;QACnE,aAAa,CAAC,iBAAiB,CAAC;YAC9B,QAAQ,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,QAAQ,EAAE,aAAa,EAAE,QAAQ,EAAE,SAAS,EAAE,CAAC;SAC7E,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,OAAO,GAAG,MAAM,MAAM,CAAC,OAAO,CAAC,iBAAiB,EAAE,CAAC;QAEzD,MAAM,CAAC,OAAO,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,QAAQ,CAAC,CAAC,QAAQ,EAAE,CAAC;IAC1C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2DAA2D,EAAE,KAAK,IAAI,EAAE;QACzE,aAAa,CAAC,iBAAiB,CAAC;YAC9B,QAAQ,CAAC,EAAE,MAAM,EAAE,cAAc,EAAE,QAAQ,EAAE,SAAS,EAAE,YAAY,EAAE,CAAC,EAAE,WAAW,EAAE,CAAC,EAAE,CAAC;YAC1F,QAAQ,CAAC,EAAE,MAAM,EAAE,cAAc,EAAE,QAAQ,EAAE,kBAAkB,EAAE,YAAY,EAAE,CAAC,EAAE,WAAW,EAAE,CAAC,EAAE,CAAC;SACpG,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,OAAO,GAAG,MAAM,MAAM,CAAC,OAAO,CAAC,iBAAiB,EAAE,CAAC;QAEzD,MAAM,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,cAAc,EAAE,cAAc,CAAC,CAAC,CAAC;QACtF,MAAM,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,cAAc,CAAC,EAAE,WAAW,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAClF,MAAM,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,cAAc,CAAC,EAAE,WAAW,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACnF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0CAA0C,EAAE,KAAK,IAAI,EAAE;QACxD,aAAa,CAAC,iBAAiB,CAAC;YAC9B,QAAQ,CAAC,EAAE,MAAM,EAAE,OAAO,EAAE,QAAQ,EAAE,4BAA4B,EAAE,CAAC;SACtE,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,OAAO,GAAG,MAAM,MAAM,CAAC,OAAO,CAAC,iBAAiB,EAAE,CAAC;QAEzD,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IAC9B,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,yDAAyD,EAAE,GAAG,EAAE;IACvE,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,aAAa,EAAE,CAAC;QACnB,EAAE,CAAC,eAAe,EAAE,CAAC;QACrB,cAAc,CAAC,iBAAiB,CAAC,SAAS,CAAC,CAAC;QAC5C,qBAAqB,CAAC,iBAAiB,CAAC,SAAS,CAAC,CAAC;QACnD,qBAAqB,CAAC,eAAe,CAAC,SAAS,CAAC,CAAC;IACnD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kFAAkF,EAAE,KAAK,IAAI,EAAE;QAChG,WAAW,CAAC,iBAAiB,CAAC,QAAQ,CAAC;YACrC,MAAM,EAAE,aAAa;YACrB,QAAQ,EAAE,eAAe;YACzB,YAAY,EAAE,CAAC;YACf,WAAW,EAAE,CAAC;YACd,SAAS,EAAE,uBAAuB;YAClC,UAAU,EAAE,UAAU;YACtB,cAAc,EAAE,0BAA0B;YAC1C,SAAS,EAAE,oBAAoB;SAChC,CAAC,CAAC,CAAC;QACJ,cAAc,CAAC,kBAAkB,CAAC,KAAK,EAAE,MAAc,EAAE,KAA0B,EAAE,EAAE,CACrF,QAAQ,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,eAAe,EAAE,GAAG,KAAK,EAAE,CAAC,CAAC,CAAC;QAE7D,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,MAAM,GAAG,MAAM,MAAM,CAAC,OAAO,CAAC,iBAAiB,CAAC,aAAa,CAAC,CAAC;QAErE,MAAM,CAAC,cAAc,CAAC,CAAC,oBAAoB,CAAC,aAAa,EAAE;YACzD,MAAM,EAAE,SAAS;YACjB,YAAY,EAAE,CAAC;YACf,WAAW,EAAE,CAAC;YACd,SAAS,EAAE,IAAI;YACf,UAAU,EAAE,IAAI;YAChB,cAAc,EAAE,IAAI;YACpB,SAAS,EAAE,IAAI;SAChB,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,CAAC,aAAa,CAAC;YAC3B,MAAM,EAAE,aAAa;YACrB,cAAc,EAAE,QAAQ;YACxB,SAAS,EAAE,SAAS;YACpB,YAAY,EAAE,KAAK;SACpB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iEAAiE,EAAE,KAAK,IAAI,EAAE;QAC/E,WAAW,CAAC,iBAAiB,CAAC,QAAQ,CAAC;YACrC,MAAM,EAAE,gBAAgB;YACxB,QAAQ,EAAE,eAAe;YACzB,YAAY,EAAE,CAAC;YACf,WAAW,EAAE,CAAC;SACf,CAAC,CAAC,CAAC;QAEJ,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,iBAAiB,CAAC,gBAAgB,CAAC,CAAC;aAC7D,OAAO,CAAC,OAAO,CAAC,wBAAwB,CAAC,CAAC;QAC7C,MAAM,CAAC,cAAc,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IAChD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4CAA4C,EAAE,KAAK,IAAI,EAAE;QAC1D,WAAW,CAAC,iBAAiB,CAAC,QAAQ,CAAC,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,EAAE,WAAW,EAAE,CAAC,CAAC,CAAC;QAEpF,MAAM,MAAM,GAAG,MAAM,0BAA0B,CAAC,EAAE,YAAY,EAAE,cAAc,EAAE,CAAC,CAAC;QAClF,MAAM,MAAM,GAAG,MAAM,MAAM,CAAC,OAAO,CAAC,iBAAiB,CAAC,SAAS,CAAC,CAAC;QAEjE,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;QAC1B,MAAM,CAAC,cAAc,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IAChD,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/runtime-v2/adapter/__tests__/pi-ai-runtime-adapter.test.js

@@ -1937,5 +1937,162 @@ describe('PiAiRuntimeAdapter', () => {
             expect(output?.payload).toMatchObject({ diagnosisId: 'diag-test-1' });
         });
     });
+    // ── PRI-707: finish metadata preservation + truncation classification ──
+    //
+    // Before PRI-707 the provider's stopReason/usage were dropped whenever any
+    // text was extractable, so a token-limit cut was indistinguishable from a
+    // true format error ("No valid JSON found in LLM response"). These tests
+    // pin the preserved evidence surfaces: error details (→ durable
+    // diagnosticJson via the runner's classifyError path), telemetry payloads,
+    // and the repair-prompt truncation notice.
+    describe('PRI-707: finish metadata preservation and truncation classification', () => {
+        function makeSchemaInput(overrides = {}) {
+            return {
+                agentSpec: { agentId: 'diagnostician', schemaVersion: 'v1' },
+                inputPayload: 'Diagnose this pain signal',
+                contextItems: [],
+                timeoutMs: 60_000,
+                outputSchemaRef: 'diagnostician-output-v1',
+                ...overrides,
+            };
+        }
+        /** Type-guard the repair prompt out of a completeSimple mock call (rc-2). */
+        function repairPromptFromCall(call) {
+            if (!Array.isArray(call) || call.length < 2)
+                return undefined;
+            const [context] = call.slice(1, 2);
+            if (typeof context !== 'object' || context === null || !Object.hasOwn(context, 'messages'))
+                return undefined;
+            const { messages } = context;
+            if (!Array.isArray(messages) || messages.length === 0)
+                return undefined;
+            const [first] = messages;
+            if (typeof first !== 'object' || first === null || !Object.hasOwn(first, 'content'))
+                return undefined;
+            const { content } = first;
+            return typeof content === 'string' ? content : undefined;
+        }
+        function usageWith(output) {
+            return { input: 120, output, cacheRead: 0, cacheWrite: 0, totalTokens: 120 + output, cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, total: 0 } };
+        }
+        it('T3+T4: finish_reason=length + usage → extraction failure carries truncated evidence (details + telemetry)', async () => {
+            mockComplete.mockResolvedValueOnce(makeAssistantMessage('{"diagnosisId":"diag-trunc', {
+                stopReason: 'length',
+                usage: usageWith(64),
+            }));
+            const adapter = makeAdapter(); // free_form_only → Path 3 directly
+            let caught;
+            try {
+                await adapter.startRun(makeSchemaInput());
+            }
+            catch (err) {
+                caught = err instanceof PDRuntimeError ? err : undefined;
+            }
+            expect(caught?.category).toBe('output_invalid');
+            expect(caught?.message).toContain('finish_reason=length');
+            // The runner persists err.details into diagnosticJson.output_failure_details
+            // (PRI-559 P0-2) — so these fields become durable failure evidence.
+            expect(caught?.details).toMatchObject({
+                truncated: true,
+                stopReason: 'length',
+                outputTokens: 64,
+            });
+            expect(typeof caught?.details?.nextAction).toBe('string');
+            const extractionEvent = findTelemetryEvent('output_extraction_failed');
+            expect(extractionEvent?.payload).toMatchObject({
+                stopReason: 'length',
+                outputTokens: 64,
+                truncated: true,
+            });
+        });
+        it('T5: finish_reason=stop + no extractable JSON → conservative legacy classification, no truncation claim', async () => {
+            mockComplete.mockResolvedValueOnce(makeAssistantMessage('I cannot answer that.'));
+            const adapter = makeAdapter();
+            let caught;
+            try {
+                await adapter.startRun(makeSchemaInput());
+            }
+            catch (err) {
+                caught = err instanceof PDRuntimeError ? err : undefined;
+            }
+            expect(caught?.category).toBe('output_invalid');
+            expect(caught?.message).toBe('[output_invalid] No valid JSON found in LLM response');
+            expect(caught?.details).toBeUndefined();
+            const extractionEvent = findTelemetryEvent('output_extraction_failed');
+            const payload = extractionEvent?.payload;
+            expect(payload?.truncated).toBeUndefined();
+        });
+        it('T2: valid JSON + schema violation with finish_reason=stop → schema-invalid, never claimed as truncation', async () => {
+            mockComplete.mockResolvedValueOnce(makeAssistantMessage('{"unexpected":true}'));
+            // Repair attempts fail (unparseable) → exhausted.
+            mockComplete.mockResolvedValue(makeAssistantMessage('still not json'));
+            const adapter = makeAdapter();
+            let caught;
+            try {
+                await adapter.startRun(makeSchemaInput());
+            }
+            catch (err) {
+                caught = err instanceof PDRuntimeError ? err : undefined;
+            }
+            expect(caught?.category).toBe('output_invalid');
+            expect(caught?.message).toContain('does not match');
+            const evidencePack = caught?.details?.evidencePack;
+            expect(evidencePack).toBeDefined();
+            // The PRI-621 RC3 heuristic fires (object matches no required key)…
+            expect(evidencePack?.truncationSuspected).toBe(true);
+            // …but the definitive finish-metadata signal must NOT claim truncation.
+            expect(evidencePack?.truncated).toBeUndefined();
+            expect(evidencePack?.stopReason).toBe('stop');
+        });
+        it('T8: finish_reason=length + schema violation → repair prompt carries truncation notice and evidencePack marks truncated', async () => {
+            mockComplete.mockResolvedValueOnce(makeAssistantMessage('{"unexpected":true}', { stopReason: 'length' }));
+            mockComplete.mockResolvedValue(makeAssistantMessage('still not json'));
+            const adapter = makeAdapter();
+            let caught;
+            try {
+                await adapter.startRun(makeSchemaInput());
+            }
+            catch (err) {
+                caught = err instanceof PDRuntimeError ? err : undefined;
+            }
+            const evidencePack = caught?.details?.evidencePack;
+            expect(evidencePack?.truncated).toBe(true);
+            expect(evidencePack?.stopReason).toBe('length');
+            // Terminal telemetry must carry the same truncation evidence so
+            // monitoring can distinguish a token-limit cut from an ordinary
+            // schema failure (PR #1574 review finding). Default helper usage
+            // reports output: 5.
+            const exhaustedEvent = findTelemetryEvent('output_repair_exhausted');
+            expect(exhaustedEvent?.payload).toMatchObject({
+                stopReason: 'length',
+                truncated: true,
+                outputTokens: 5,
+            });
+            // The FIRST completeSimple call is the original generation; repair
+            // calls follow. Their user message must carry the truncation notice so
+            // the repair LLM stops treating a cut fragment as a misunderstanding.
+            const repairCalls = mockComplete.mock.calls.slice(1);
+            expect(repairCalls.length).toBeGreaterThan(0);
+            const firstRepairPrompt = repairPromptFromCall(repairCalls[0]);
+            expect(firstRepairPrompt).toContain('TRUNCATION NOTICE');
+            expect(firstRepairPrompt).toContain('finish_reason=length');
+        });
+        it('truncation notice absent when finish metadata shows a clean stop (repair prompt unchanged)', async () => {
+            mockComplete.mockResolvedValueOnce(makeAssistantMessage('{"unexpected":true}'));
+            mockComplete.mockResolvedValue(makeAssistantMessage('still not json'));
+            const adapter = makeAdapter();
+            try {
+                await adapter.startRun(makeSchemaInput());
+            }
+            catch {
+                // output_invalid expected — assertion is on the prompt below.
+            }
+            const repairCalls = mockComplete.mock.calls.slice(1);
+            expect(repairCalls.length).toBeGreaterThan(0);
+            const firstRepairPrompt = repairPromptFromCall(repairCalls[0]);
+            expect(firstRepairPrompt).toBeDefined();
+            expect(firstRepairPrompt).not.toContain('TRUNCATION NOTICE');
+        });
+    });
 });
 //# sourceMappingURL=pi-ai-runtime-adapter.test.js.map