@principles/core 1.271.0 → 1.273.0

package/dist/runtime-v2/internalization/__tests__/owner-decision-review.test.js

@@ -0,0 +1,229 @@
+import { describe, expect, it } from 'vitest';
+import { createPITaskDiagnosticJson } from '../pitask-metadata.js';
+import { HUMAN_REVIEW_REASON } from '../owner-review.js';
+import { buildOwnerDecisionReview, } from '../owner-decision-review.js';
+const EVALUATOR_ID = 'evaluator-review-1';
+const ARTIFICER_TASK_ID = 'artificer-review-1';
+const SCRIBE_TASK_ID = 'scribe-review-1';
+const EVALUATOR_ARTIFACT_ID = 'pi-art-evaluator-review-1-run-1';
+const ARTIFICER_ARTIFACT_ID = 'pi-art-artificer-review-1-run-1';
+const SCRIBE_ARTIFACT_ID = 'pi-art-scribe-review-1-run-1';
+function metadata(taskKind) {
+    const dependencyTaskIds = taskKind === 'evaluator'
+        ? [ARTIFICER_TASK_ID]
+        : taskKind === 'artificer' ? [SCRIBE_TASK_ID] : [];
+    return {
+        dependencyTaskIds,
+        channel: 'code_tool_hook',
+        timeoutMs: 300_000,
+        inputArtifactRefs: [],
+        outputArtifactRefs: [],
+        ...(taskKind === 'evaluator'
+            ? {
+                runnerDecision: 'needs_revision',
+                revisionCount: 0,
+                completionIntent: {
+                    decision: 'needs_revision',
+                    sourceRunId: 'run-1',
+                    revisionEpoch: 0,
+                    status: 'pending',
+                },
+                humanReviewContext: {
+                    reasonCode: HUMAN_REVIEW_REASON.evaluatorRepairBudgetExhausted,
+                    sourceRunId: 'run-1',
+                    sourceArtifactId: EVALUATOR_ARTIFACT_ID,
+                    revisionEpoch: 0,
+                    createdAt: '2026-08-31T00:00:00.000Z',
+                },
+            }
+            : {}),
+    };
+}
+function task(taskId, taskKind) {
+    return {
+        taskId,
+        taskKind,
+        status: taskKind === 'evaluator' ? 'needs_human_review' : 'succeeded',
+        attemptCount: 1,
+        maxAttempts: 3,
+        createdAt: '2026-08-31T00:00:00.000Z',
+        updatedAt: '2026-08-31T00:05:00.000Z',
+        diagnosticJson: createPITaskDiagnosticJson(metadata(taskKind)),
+    };
+}
+function artifact(input) {
+    return {
+        artifactId: input.artifactId,
+        artifactKind: 'principle',
+        sourceTaskId: input.sourceTaskId,
+        lineageArtifactIds: input.lineageArtifactIds,
+        validationStatus: 'pending',
+        contentJson: JSON.stringify(input.content),
+        createdAt: '2026-08-31T00:00:00.000Z',
+    };
+}
+function makeStore(options = {}) {
+    const oldArtificerArtifactId = 'pi-art-artificer-review-old-run-1';
+    const oldScribeArtifactId = 'pi-art-scribe-review-old-run-1';
+    const records = [
+        ...(options.includeOlderRepair ? [
+            artifact({ artifactId: oldScribeArtifactId, sourceTaskId: 'scribe-review-old', lineageArtifactIds: [], content: {
+                    principleDraft: { statement: 'OLD principle must not be shown.' },
+                } }),
+            artifact({ artifactId: oldArtificerArtifactId, sourceTaskId: 'artificer-review-old', lineageArtifactIds: [oldScribeArtifactId], content: {
+                    sourceScribeArtifactId: oldScribeArtifactId,
+                    sourceTrace: { scribeArtifactId: oldScribeArtifactId },
+                    implementationSummary: 'OLD implementation must not be shown.',
+                } }),
+        ] : []),
+        artifact({ artifactId: SCRIBE_ARTIFACT_ID, sourceTaskId: SCRIBE_TASK_ID, lineageArtifactIds: [], content: {
+                principleDraft: {
+                    title: 'Confirm destructive changes',
+                    statement: 'Before destructive changes, confirm the exact target with the Owner.',
+                    rationale: 'Prevents irreversible work against an ambiguous target.',
+                    applicability: ['filesystem writes'],
+                    antiPatterns: ['guessing the target'],
+                },
+            } }),
+        artifact({ artifactId: ARTIFICER_ARTIFACT_ID, sourceTaskId: ARTIFICER_TASK_ID, lineageArtifactIds: [SCRIBE_ARTIFACT_ID], content: {
+                ...(options.codeBearingArtificer
+                    ? {
+                        taskId: ARTIFICER_TASK_ID,
+                        implementationCode: 'export function confirmTarget() { return true; }',
+                        goldenTraceCases: [
+                            {
+                                caseId: 'allows-confirmed-target',
+                                kind: 'positive',
+                                toolName: 'write_file',
+                                params: { confirmed: true },
+                                expectedDecision: 'allow',
+                            },
+                            {
+                                caseId: 'blocks-unconfirmed-target',
+                                kind: 'negative',
+                                toolName: 'write_file',
+                                params: { confirmed: false },
+                                expectedDecision: 'block',
+                            },
+                        ],
+                        generatedAt: '2026-08-31T00:00:00.000Z',
+                    }
+                    : {}),
+                sourceScribeArtifactId: SCRIBE_ARTIFACT_ID,
+                sourceTrace: { scribeArtifactId: SCRIBE_ARTIFACT_ID },
+                implementationSummary: 'Adds a confirmation gate before destructive writes.',
+                affectedTools: ['write_file', 'apply_patch'],
+                risks: ['May add one interaction before a destructive action.'],
+                ...options.artificerExtra,
+            } }),
+        artifact({ artifactId: EVALUATOR_ARTIFACT_ID, sourceTaskId: EVALUATOR_ID, lineageArtifactIds: [
+                ...(options.includeOlderRepair ? [oldArtificerArtifactId] : []),
+                ARTIFICER_ARTIFACT_ID,
+            ], content: {
+                sourceArtificerArtifactId: ARTIFICER_ARTIFACT_ID,
+                sourceTrace: { artificerArtifactId: ARTIFICER_ARTIFACT_ID },
+                evaluation: {
+                    decision: 'needs_revision',
+                    score: 0.72,
+                    strengths: ['The target check is deterministic.'],
+                    concerns: [options.concern ?? 'The confirmation copy is ambiguous.'],
+                    requiredChanges: ['Clarify the confirmation copy.'],
+                },
+                ...(options.adversarialPassed === undefined
+                    ? {}
+                    : { adversarialResult: { passed: options.adversarialPassed, failedCases: [] } }),
+                ...options.evaluatorExtra,
+            } }),
+    ].filter((record) => options.includeScribe !== false || record.artifactId !== SCRIBE_ARTIFACT_ID);
+    const tasks = [
+        task(EVALUATOR_ID, 'evaluator'),
+        ...(options.includeOlderRepair ? [
+            task('artificer-review-old', 'artificer'),
+            task('scribe-review-old', 'scribe'),
+        ] : []),
+        task(ARTIFICER_TASK_ID, 'artificer'),
+        ...(options.includeScribe === false ? [] : [task(SCRIBE_TASK_ID, 'scribe')]),
+    ];
+    return {
+        getTask: async (id) => tasks.find((entry) => entry.taskId === id) ?? null,
+        listArtifactsBySourceTask: async (id) => records.filter((entry) => entry.sourceTaskId === id),
+        getArtifactById: async (id) => records.find((entry) => entry.artifactId === id) ?? null,
+    };
+}
+describe('Owner Decision Review Snapshot', () => {
+    it('builds a distinct evidence-rich evaluator brief and reports an absent adversarial result as not_run', async () => {
+        const snapshot = await buildOwnerDecisionReview(makeStore(), EVALUATOR_ID);
+        expect(snapshot?.brief.kind).toBe('evaluator');
+        if (snapshot?.brief.kind !== 'evaluator')
+            throw new Error('expected evaluator brief');
+        expect(snapshot.brief.principle.statement).toContain('confirm the exact target');
+        expect(snapshot.brief.implementation.summary).toContain('confirmation gate');
+        expect(snapshot.brief.implementation.affectedTools).toEqual(['write_file', 'apply_patch']);
+        expect(snapshot.brief.concerns).toEqual(['The confirmation copy is ambiguous.']);
+        expect(snapshot.evidence.deterministicChecks).toEqual([
+            { check: 'adversarial_hard_gate', status: 'not_run' },
+        ]);
+        expect(snapshot.evidence.completeness).toBe('complete');
+    });
+    it('requires acknowledgement for a partial but still identifiable review', async () => {
+        const snapshot = await buildOwnerDecisionReview(makeStore({ includeScribe: false }), EVALUATOR_ID);
+        expect(snapshot?.evidence.completeness).toBe('partial');
+        expect(snapshot?.capability.acceptRequirement).toEqual({
+            kind: 'acknowledge_partial_evidence',
+        });
+        expect(snapshot?.capability.finalOfferedActions).toContain('accept_current');
+    });
+    it('forbids accept when the deterministic adversarial hard gate explicitly failed', async () => {
+        const snapshot = await buildOwnerDecisionReview(makeStore({ adversarialPassed: false }), EVALUATOR_ID);
+        expect(snapshot?.evidence.deterministicChecks).toEqual([
+            { check: 'adversarial_hard_gate', status: 'failed' },
+        ]);
+        expect(snapshot?.capability.finalOfferedActions).not.toContain('accept_current');
+        expect(snapshot?.capability.acceptRequirement).toEqual({
+            kind: 'forbidden',
+            reasonCode: 'adversarial_hard_gate_failed',
+        });
+    });
+    it('forbids accept when a validated code-bearing Artificer output has not passed the hard gate', async () => {
+        const snapshot = await buildOwnerDecisionReview(makeStore({ codeBearingArtificer: true }), EVALUATOR_ID);
+        expect(snapshot?.evidence.deterministicChecks[0]?.status).toBe('not_run');
+        expect(snapshot?.capability.finalOfferedActions).not.toContain('accept_current');
+        expect(snapshot?.capability.acceptRequirement).toEqual({
+            kind: 'forbidden',
+            reasonCode: 'adversarial_hard_gate_not_passed',
+        });
+    });
+    it('uses the canonical code-bearing assessment when affectedTools is omitted', async () => {
+        const snapshot = await buildOwnerDecisionReview(makeStore({
+            codeBearingArtificer: true,
+            artificerExtra: { affectedTools: undefined },
+        }), EVALUATOR_ID);
+        expect(snapshot?.evidence.deterministicChecks[0]?.status).toBe('not_run');
+        expect(snapshot?.capability.finalOfferedActions).not.toContain('accept_current');
+        expect(snapshot?.capability.acceptRequirement).toEqual({
+            kind: 'forbidden',
+            reasonCode: 'adversarial_hard_gate_not_passed',
+        });
+    });
+    it('keeps legacy compatibility when the Artificer artifact is not a validated code-bearing output', async () => {
+        const snapshot = await buildOwnerDecisionReview(makeStore(), EVALUATOR_ID);
+        expect(snapshot?.capability.finalOfferedActions).toContain('accept_current');
+    });
+    it('uses the evaluator-declared repair lineage instead of the first reachable artificer', async () => {
+        const snapshot = await buildOwnerDecisionReview(makeStore({ includeOlderRepair: true }), EVALUATOR_ID);
+        expect(snapshot?.brief.kind).toBe('evaluator');
+        if (snapshot?.brief.kind !== 'evaluator')
+            throw new Error('expected evaluator brief');
+        expect(snapshot.brief.principle.statement).toContain('confirm the exact target');
+        expect(snapshot.brief.implementation.summary).toContain('confirmation gate');
+        expect(snapshot.evidence.manifest.sources.map((source) => source.stableId))
+            .not.toContain('pi-art-artificer-review-old-run-1');
+    });
+    it('changes the evidence digest when visible decision semantics change', async () => {
+        const first = await buildOwnerDecisionReview(makeStore({ concern: 'Concern A' }), EVALUATOR_ID);
+        const second = await buildOwnerDecisionReview(makeStore({ concern: 'Concern B' }), EVALUATOR_ID);
+        expect(first?.evidence.digest).toMatch(/^[a-f0-9]{64}$/);
+        expect(second?.evidence.digest).not.toBe(first?.evidence.digest);
+    });
+});
+//# sourceMappingURL=owner-decision-review.test.js.map

package/dist/runtime-v2/internalization/__tests__/owner-decision-review.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"owner-decision-review.test.js","sourceRoot":"","sources":["../../../../src/runtime-v2/internalization/__tests__/owner-decision-review.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAE9C,OAAO,EAAE,0BAA0B,EAAuB,MAAM,uBAAuB,CAAC;AACxF,OAAO,EAAE,mBAAmB,EAAE,MAAM,oBAAoB,CAAC;AACzD,OAAO,EACL,wBAAwB,GAEzB,MAAM,6BAA6B,CAAC;AAErC,MAAM,YAAY,GAAG,oBAAoB,CAAC;AAC1C,MAAM,iBAAiB,GAAG,oBAAoB,CAAC;AAC/C,MAAM,cAAc,GAAG,iBAAiB,CAAC;AACzC,MAAM,qBAAqB,GAAG,iCAAiC,CAAC;AAChE,MAAM,qBAAqB,GAAG,iCAAiC,CAAC;AAChE,MAAM,kBAAkB,GAAG,8BAA8B,CAAC;AAE1D,SAAS,QAAQ,CAAC,QAA8C;IAC9D,MAAM,iBAAiB,GAAG,QAAQ,KAAK,WAAW;QAChD,CAAC,CAAC,CAAC,iBAAiB,CAAC;QACrB,CAAC,CAAC,QAAQ,KAAK,WAAW,CAAC,CAAC,CAAC,CAAC,cAAc,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;IACrD,OAAO;QACL,iBAAiB;QACjB,OAAO,EAAE,gBAAgB;QACzB,SAAS,EAAE,OAAO;QAClB,iBAAiB,EAAE,EAAE;QACrB,kBAAkB,EAAE,EAAE;QACtB,GAAG,CAAC,QAAQ,KAAK,WAAW;YAC1B,CAAC,CAAC;gBACE,cAAc,EAAE,gBAAyB;gBACzC,aAAa,EAAE,CAAC;gBAChB,gBAAgB,EAAE;oBAChB,QAAQ,EAAE,gBAAyB;oBACnC,WAAW,EAAE,OAAO;oBACpB,aAAa,EAAE,CAAC;oBAChB,MAAM,EAAE,SAAkB;iBAC3B;gBACD,kBAAkB,EAAE;oBAClB,UAAU,EAAE,mBAAmB,CAAC,8BAA8B;oBAC9D,WAAW,EAAE,OAAO;oBACpB,gBAAgB,EAAE,qBAAqB;oBACvC,aAAa,EAAE,CAAC;oBAChB,SAAS,EAAE,0BAA0B;iBACtC;aACF;YACH,CAAC,CAAC,EAAE,CAAC;KACR,CAAC;AACJ,CAAC;AAED,SAAS,IAAI,CAAC,MAAc,EAAE,QAA8C;IAC1E,OAAO;QACL,MAAM;QACN,QAAQ;QACR,MAAM,EAAE,QAAQ,KAAK,WAAW,CAAC,CAAC,CAAC,oBAAoB,CAAC,CAAC,CAAC,WAAW;QACrE,YAAY,EAAE,CAAC;QACf,WAAW,EAAE,CAAC;QACd,SAAS,EAAE,0BAA0B;QACrC,SAAS,EAAE,0BAA0B;QACrC,cAAc,EAAE,0BAA0B,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC;KAC/D,CAAC;AACJ,CAAC;AAED,SAAS,QAAQ,CAAC,KAKjB;IACC,OAAO;QACL,UAAU,EAAE,KAAK,CAAC,UAAU;QAC5B,YAAY,EAAE,WAAW;QACzB,YAAY,EAAE,KAAK,CAAC,YAAY;QAChC,kBAAkB,EAAE,KAAK,CAAC,kBAAkB;QAC5C,gBAAgB,EAAE,SAAS;QAC3B,WAAW,EAAE,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,OAAO,CAAC;QAC1C,SAAS,EAAE,0BAA0B;KACtC,CAAC;AACJ,CAAC;AAED,SAAS,SAAS,CAAC,OAAO,GAQtB,EAAE;IACJ,MAAM,sBAAsB,GAAG,mCAAmC,CAAC;IACnE,MAAM,mBAAmB,GAAG,gCAAgC,CAAC;IAC7D,MAAM,OAAO,GAAG;QACd,GAAG,CAAC,OAAO,CAAC,kBAAkB,CAAC,CAAC,CAAC;YAC/B,QAAQ,CAAC,EAAE,UAAU,EAAE,mBAAmB,EAAE,YAAY,EAAE,mBAAmB,EAAE,kBAAkB,EAAE,EAAE,EAAE,OAAO,EAAE;oBAC9G,cAAc,EAAE,EAAE,SAAS,EAAE,kCAAkC,EAAE;iBAClE,EAAC,CAAC;YACH,QAAQ,CAAC,EAAE,UAAU,EAAE,sBAAsB,EAAE,YAAY,EAAE,sBAAsB,EAAE,kBAAkB,EAAE,CAAC,mBAAmB,CAAC,EAAE,OAAO,EAAE;oBACvI,sBAAsB,EAAE,mBAAmB;oBAC3C,WAAW,EAAE,EAAE,gBAAgB,EAAE,mBAAmB,EAAE;oBACtD,qBAAqB,EAAE,uCAAuC;iBAC/D,EAAC,CAAC;SACJ,CAAC,CAAC,CAAC,EAAE,CAAC;QACP,QAAQ,CAAC,EAAE,UAAU,EAAE,kBAAkB,EAAE,YAAY,EAAE,cAAc,EAAE,kBAAkB,EAAE,EAAE,EAAE,OAAO,EAAE;gBACxG,cAAc,EAAE;oBACd,KAAK,EAAE,6BAA6B;oBACpC,SAAS,EAAE,sEAAsE;oBACjF,SAAS,EAAE,yDAAyD;oBACpE,aAAa,EAAE,CAAC,mBAAmB,CAAC;oBACpC,YAAY,EAAE,CAAC,qBAAqB,CAAC;iBACtC;aACF,EAAC,CAAC;QACH,QAAQ,CAAC,EAAE,UAAU,EAAE,qBAAqB,EAAE,YAAY,EAAE,iBAAiB,EAAE,kBAAkB,EAAE,CAAC,kBAAkB,CAAC,EAAE,OAAO,EAAE;gBAChI,GAAG,CAAC,OAAO,CAAC,oBAAoB;oBAC9B,CAAC,CAAC;wBACE,MAAM,EAAE,iBAAiB;wBACzB,kBAAkB,EAAE,kDAAkD;wBACtE,gBAAgB,EAAE;4BAChB;gCACE,MAAM,EAAE,yBAAyB;gCACjC,IAAI,EAAE,UAAU;gCAChB,QAAQ,EAAE,YAAY;gCACtB,MAAM,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE;gCAC3B,gBAAgB,EAAE,OAAO;6BAC1B;4BACD;gCACE,MAAM,EAAE,2BAA2B;gCACnC,IAAI,EAAE,UAAU;gCAChB,QAAQ,EAAE,YAAY;gCACtB,MAAM,EAAE,EAAE,SAAS,EAAE,KAAK,EAAE;gCAC5B,gBAAgB,EAAE,OAAO;6BAC1B;yBACF;wBACD,WAAW,EAAE,0BAA0B;qBACxC;oBACH,CAAC,CAAC,EAAE,CAAC;gBACP,sBAAsB,EAAE,kBAAkB;gBAC1C,WAAW,EAAE,EAAE,gBAAgB,EAAE,kBAAkB,EAAE;gBACrD,qBAAqB,EAAE,qDAAqD;gBAC5E,aAAa,EAAE,CAAC,YAAY,EAAE,aAAa,CAAC;gBAC5C,KAAK,EAAE,CAAC,sDAAsD,CAAC;gBAC/D,GAAG,OAAO,CAAC,cAAc;aAC1B,EAAC,CAAC;QACH,QAAQ,CAAC,EAAE,UAAU,EAAE,qBAAqB,EAAE,YAAY,EAAE,YAAY,EAAE,kBAAkB,EAAE;gBAC5F,GAAG,CAAC,OAAO,CAAC,kBAAkB,CAAC,CAAC,CAAC,CAAC,sBAAsB,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;gBAC/D,qBAAqB;aACtB,EAAE,OAAO,EAAE;gBACV,yBAAyB,EAAE,qBAAqB;gBAChD,WAAW,EAAE,EAAE,mBAAmB,EAAE,qBAAqB,EAAE;gBAC3D,UAAU,EAAE;oBACV,QAAQ,EAAE,gBAAgB;oBAC1B,KAAK,EAAE,IAAI;oBACX,SAAS,EAAE,CAAC,oCAAoC,CAAC;oBACjD,QAAQ,EAAE,CAAC,OAAO,CAAC,OAAO,IAAI,qCAAqC,CAAC;oBACpE,eAAe,EAAE,CAAC,gCAAgC,CAAC;iBACpD;gBACD,GAAG,CAAC,OAAO,CAAC,iBAAiB,KAAK,SAAS;oBACzC,CAAC,CAAC,EAAE;oBACJ,CAAC,CAAC,EAAE,iBAAiB,EAAE,EAAE,MAAM,EAAE,OAAO,CAAC,iBAAiB,EAAE,WAAW,EAAE,EAAE,EAAE,EAAE,CAAC;gBAClF,GAAG,OAAO,CAAC,cAAc;aAC1B,EAAC,CAAC;KACJ,CAAC,MAAM,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,OAAO,CAAC,aAAa,KAAK,KAAK,IAAI,MAAM,CAAC,UAAU,KAAK,kBAAkB,CAAC,CAAC;IAClG,MAAM,KAAK,GAAG;QACZ,IAAI,CAAC,YAAY,EAAE,WAAW,CAAC;QAC/B,GAAG,CAAC,OAAO,CAAC,kBAAkB,CAAC,CAAC,CAAC;YAC/B,IAAI,CAAC,sBAAsB,EAAE,WAAW,CAAC;YACzC,IAAI,CAAC,mBAAmB,EAAE,QAAQ,CAAC;SACpC,CAAC,CAAC,CAAC,EAAE,CAAC;QACP,IAAI,CAAC,iBAAiB,EAAE,WAAW,CAAC;QACpC,GAAG,CAAC,OAAO,CAAC,aAAa,KAAK,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,cAAc,EAAE,QAAQ,CAAC,CAAC,CAAC;KAC7E,CAAC;IACF,OAAO;QACL,OAAO,EAAE,KAAK,EAAE,EAAE,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,MAAM,KAAK,EAAE,CAAC,IAAI,IAAI;QACzE,yBAAyB,EAAE,KAAK,EAAE,EAAE,EAAE,EAAE,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,YAAY,KAAK,EAAE,CAAC;QAC7F,eAAe,EAAE,KAAK,EAAE,EAAE,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,UAAU,KAAK,EAAE,CAAC,IAAI,IAAI;KACxF,CAAC;AACJ,CAAC;AAED,QAAQ,CAAC,gCAAgC,EAAE,GAAG,EAAE;IAC9C,EAAE,CAAC,qGAAqG,EAAE,KAAK,IAAI,EAAE;QACnH,MAAM,QAAQ,GAAG,MAAM,wBAAwB,CAAC,SAAS,EAAE,EAAE,YAAY,CAAC,CAAC;QAE3E,MAAM,CAAC,QAAQ,EAAE,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QAC/C,IAAI,QAAQ,EAAE,KAAK,CAAC,IAAI,KAAK,WAAW;YAAE,MAAM,IAAI,KAAK,CAAC,0BAA0B,CAAC,CAAC;QACtF,MAAM,CAAC,QAAQ,CAAC,KAAK,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC,SAAS,CAAC,0BAA0B,CAAC,CAAC;QACjF,MAAM,CAAC,QAAQ,CAAC,KAAK,CAAC,cAAc,CAAC,OAAO,CAAC,CAAC,SAAS,CAAC,mBAAmB,CAAC,CAAC;QAC7E,MAAM,CAAC,QAAQ,CAAC,KAAK,CAAC,cAAc,CAAC,aAAa,CAAC,CAAC,OAAO,CAAC,CAAC,YAAY,EAAE,aAAa,CAAC,CAAC,CAAC;QAC3F,MAAM,CAAC,QAAQ,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,CAAC,qCAAqC,CAAC,CAAC,CAAC;QACjF,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,mBAAmB,CAAC,CAAC,OAAO,CAAC;YACpD,EAAE,KAAK,EAAE,uBAAuB,EAAE,MAAM,EAAE,SAAS,EAAE;SACtD,CAAC,CAAC;QACH,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,YAAY,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAC1D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sEAAsE,EAAE,KAAK,IAAI,EAAE;QACpF,MAAM,QAAQ,GAAG,MAAM,wBAAwB,CAC7C,SAAS,CAAC,EAAE,aAAa,EAAE,KAAK,EAAE,CAAC,EACnC,YAAY,CACb,CAAC;QAEF,MAAM,CAAC,QAAQ,EAAE,QAAQ,CAAC,YAAY,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QACxD,MAAM,CAAC,QAAQ,EAAE,UAAU,CAAC,iBAAiB,CAAC,CAAC,OAAO,CAAC;YACrD,IAAI,EAAE,8BAA8B;SACrC,CAAC,CAAC;QACH,MAAM,CAAC,QAAQ,EAAE,UAAU,CAAC,mBAAmB,CAAC,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAC;IAC/E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+EAA+E,EAAE,KAAK,IAAI,EAAE;QAC7F,MAAM,QAAQ,GAAG,MAAM,wBAAwB,CAC7C,SAAS,CAAC,EAAE,iBAAiB,EAAE,KAAK,EAAE,CAAC,EACvC,YAAY,CACb,CAAC;QAEF,MAAM,CAAC,QAAQ,EAAE,QAAQ,CAAC,mBAAmB,CAAC,CAAC,OAAO,CAAC;YACrD,EAAE,KAAK,EAAE,uBAAuB,EAAE,MAAM,EAAE,QAAQ,EAAE;SACrD,CAAC,CAAC;QACH,MAAM,CAAC,QAAQ,EAAE,UAAU,CAAC,mBAAmB,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAC;QACjF,MAAM,CAAC,QAAQ,EAAE,UAAU,CAAC,iBAAiB,CAAC,CAAC,OAAO,CAAC;YACrD,IAAI,EAAE,WAAW;YACjB,UAAU,EAAE,8BAA8B;SAC3C,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4FAA4F,EAAE,KAAK,IAAI,EAAE;QAC1G,MAAM,QAAQ,GAAG,MAAM,wBAAwB,CAC7C,SAAS,CAAC,EAAE,oBAAoB,EAAE,IAAI,EAAE,CAAC,EACzC,YAAY,CACb,CAAC;QAEF,MAAM,CAAC,QAAQ,EAAE,QAAQ,CAAC,mBAAmB,CAAC,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC1E,MAAM,CAAC,QAAQ,EAAE,UAAU,CAAC,mBAAmB,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAC;QACjF,MAAM,CAAC,QAAQ,EAAE,UAAU,CAAC,iBAAiB,CAAC,CAAC,OAAO,CAAC;YACrD,IAAI,EAAE,WAAW;YACjB,UAAU,EAAE,kCAAkC;SAC/C,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0EAA0E,EAAE,KAAK,IAAI,EAAE;QACxF,MAAM,QAAQ,GAAG,MAAM,wBAAwB,CAC7C,SAAS,CAAC;YACR,oBAAoB,EAAE,IAAI;YAC1B,cAAc,EAAE,EAAE,aAAa,EAAE,SAAS,EAAE;SAC7C,CAAC,EACF,YAAY,CACb,CAAC;QAEF,MAAM,CAAC,QAAQ,EAAE,QAAQ,CAAC,mBAAmB,CAAC,CAAC,CAAC,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC1E,MAAM,CAAC,QAAQ,EAAE,UAAU,CAAC,mBAAmB,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAC;QACjF,MAAM,CAAC,QAAQ,EAAE,UAAU,CAAC,iBAAiB,CAAC,CAAC,OAAO,CAAC;YACrD,IAAI,EAAE,WAAW;YACjB,UAAU,EAAE,kCAAkC;SAC/C,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+FAA+F,EAAE,KAAK,IAAI,EAAE;QAC7G,MAAM,QAAQ,GAAG,MAAM,wBAAwB,CAAC,SAAS,EAAE,EAAE,YAAY,CAAC,CAAC;QAC3E,MAAM,CAAC,QAAQ,EAAE,UAAU,CAAC,mBAAmB,CAAC,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAC;IAC/E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qFAAqF,EAAE,KAAK,IAAI,EAAE;QACnG,MAAM,QAAQ,GAAG,MAAM,wBAAwB,CAC7C,SAAS,CAAC,EAAE,kBAAkB,EAAE,IAAI,EAAE,CAAC,EACvC,YAAY,CACb,CAAC;QAEF,MAAM,CAAC,QAAQ,EAAE,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QAC/C,IAAI,QAAQ,EAAE,KAAK,CAAC,IAAI,KAAK,WAAW;YAAE,MAAM,IAAI,KAAK,CAAC,0BAA0B,CAAC,CAAC;QACtF,MAAM,CAAC,QAAQ,CAAC,KAAK,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC,SAAS,CAAC,0BAA0B,CAAC,CAAC;QACjF,MAAM,CAAC,QAAQ,CAAC,KAAK,CAAC,cAAc,CAAC,OAAO,CAAC,CAAC,SAAS,CAAC,mBAAmB,CAAC,CAAC;QAC7E,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,QAAQ,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC;aACxE,GAAG,CAAC,SAAS,CAAC,mCAAmC,CAAC,CAAC;IACxD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oEAAoE,EAAE,KAAK,IAAI,EAAE;QAClF,MAAM,KAAK,GAAG,MAAM,wBAAwB,CAC1C,SAAS,CAAC,EAAE,OAAO,EAAE,WAAW,EAAE,CAAC,EACnC,YAAY,CACb,CAAC;QACF,MAAM,MAAM,GAAG,MAAM,wBAAwB,CAC3C,SAAS,CAAC,EAAE,OAAO,EAAE,WAAW,EAAE,CAAC,EACnC,YAAY,CACb,CAAC;QAEF,MAAM,CAAC,KAAK,EAAE,QAAQ,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC,gBAAgB,CAAC,CAAC;QACzD,MAAM,CAAC,MAAM,EAAE,QAAQ,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,KAAK,EAAE,QAAQ,CAAC,MAAM,CAAC,CAAC;IACnE,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/runtime-v2/internalization/__tests__/owner-decision.test.js

@@ -13,10 +13,12 @@
  *   I. transition 仲裁使用 effective decision
  *   K. evaluator 收敛 schema 不变量 (SPEC §18.4)
  */
+/* eslint-disable @typescript-eslint/no-non-null-assertion -- legacy fixture assertions predate staged-file linting. */
 import { describe, it, expect } from 'vitest';
 import { serializePITaskMetadata, parsePITaskMetadata, hydratePITaskRecord, createPITaskDiagnosticJson, } from '../pitask-metadata.js';
 import { HUMAN_REVIEW_REASON, LEGACY_EVALUATOR_BUDGET_EXHAUSTED, buildOwnerReviewKey, collectOwnerDecisionFacts, deriveOwnerDecisionCapability, resolveEffectiveRunnerDecision, effectiveDecisionFor, planOwnerVerdictOverrideResume, detectHardGateFailureFromArtifact, } from '../owner-review.js';
-import { applyOwnerResolution, sanitizeOwnerInstruction } from '../owner-resolution-service.js';
+import { applyOwnerResolution, reviewStoreFromStateManager, sanitizeOwnerInstruction, } from '../owner-resolution-service.js';
+import { buildOwnerDecisionReview } from '../owner-decision-review.js';
 import { buildRepairRevisionCauseId, reopenTaskForRevision, resolveRolloutRevisionTarget } from '../revision-reopen.js';
 import { decideInternalizationTransition, transitionInputFromTask } from '../internalization-transition-decision.js';
 import { ownerRetryNeedsHumanReviewTask } from '../owner-retry.js';
@@ -157,6 +159,17 @@ function makeInMemoryStateManager(tasks, artifacts) {
         async updateTaskIfDiagnosticJsonUnchanged(id, expected, patch) {
             return store.updateTaskIfDiagnosticJsonUnchanged(id, expected, patch);
         },
+        async updateTaskIfDiagnosticJsonAndArtifactsUnchanged(input) {
+            for (const bound of input.artifacts) {
+                const current = await artifacts.getArtifactById(bound.artifactId);
+                if (!current
+                    || current.sourceTaskId !== bound.sourceTaskId
+                    || JSON.stringify(current.lineageArtifactIds) !== bound.lineageArtifactIdsJson
+                    || current.contentJson !== bound.contentJson)
+                    return null;
+            }
+            return store.updateTaskIfDiagnosticJsonUnchanged(input.taskId, input.expectedDiagnosticJson, input.patch);
+        },
         async markTaskSucceeded(id, resultRef) { await store.updateTask(id, { status: 'succeeded', resultRef }); },
     };
     return sm;
@@ -193,6 +206,27 @@ describe('PRI-629 metadata: humanReviewContext + ownerResolutions round-trip', (
         const json = serializePITaskMetadata(baseMeta({ ownerResolutions: [bad] }));
         expect(parsePITaskMetadata(json)).toBeNull();
     });
+    it('PRI-634: humanReviewContext.detail round-trips through serialize → parse (legacy 无 detail 照常 hydrate)', () => {
+        const json = serializePITaskMetadata(baseMeta({
+            humanReviewContext: { ...nhrContext(), detail: '1 rule/validated artifact(s) rejected: pi-art-x (missing: goldenTrace)' },
+        }));
+        const parsed = parsePITaskMetadata(json);
+        expect(parsed?.humanReviewContext?.detail)
+            .toBe('1 rule/validated artifact(s) rejected: pi-art-x (missing: goldenTrace)');
+        // legacy: 无 detail 的 context 照常 hydrate,字段为 undefined 而非空串
+        const legacy = parsePITaskMetadata(serializePITaskMetadata(baseMeta({ humanReviewContext: nhrContext() })));
+        expect(legacy?.humanReviewContext?.detail).toBeUndefined();
+    });
+    it('PRI-634: malformed humanReviewContext.detail fails closed (rc-1/rc-2 trust boundary)', () => {
+        // detail 一旦存在必须是 non-empty string;object/array/number/空串一律
+        // 整条 metadata fail closed,禁止静默 hydrate 成类型谎言 (detail?: string)。
+        for (const badDetail of [{}, [], 123, '']) {
+            const json = serializePITaskMetadata(baseMeta({
+                humanReviewContext: { ...nhrContext(), detail: badDetail },
+            }));
+            expect(parsePITaskMetadata(json)).toBeNull();
+        }
+    });
     it('rejects duplicate reviewKey within ownerResolutions (authority corruption fails closed)', () => {
         const rec = (id) => ({
             resolutionId: id, reviewKey: 'odk_same', action: 'reject_current', status: 'applied',
@@ -396,6 +430,143 @@ describe('PRI-629 applyOwnerResolution (SPEC §7/§10/§11)', () => {
         const pi = hydratePITaskRecord((await sm.getTask(EVAL_ID)));
         expect(pi?.ownerResolutions?.length).toBe(1); // 无第二条记录
     });
+    it('same reviewKey/action with changed lineage evidence digest is not an idempotent replay', async () => {
+        const { sm, deps, req } = await setup();
+        const decision = await sm.piArtifactStore.getArtifactById(ARTIFACT_ID);
+        expect(decision).not.toBeNull();
+        await sm.piArtifactStore.upsertArtifact({
+            ...decision,
+            lineageArtifactIds: ['pi-art-artificer-old'],
+        });
+        await sm.piArtifactStore.upsertArtifact({
+            artifactId: 'pi-art-artificer-old',
+            artifactKind: 'principle',
+            sourceTaskId: ARTIFER_ID,
+            lineageArtifactIds: [],
+            validationStatus: 'pending',
+            contentJson: JSON.stringify({
+                implementationSummary: 'Implementation A',
+                affectedTools: ['write_file'],
+                risks: [],
+            }),
+            createdAt: '2026-08-30T00:00:00.000Z',
+            updatedAt: '2026-08-30T00:00:00.000Z',
+        });
+        const firstReview = await buildOwnerDecisionReview(reviewStoreFromStateManager(sm), EVAL_ID);
+        expect(firstReview).not.toBeNull();
+        const artificer = await sm.piArtifactStore.getArtifactById('pi-art-artificer-old');
+        await sm.piArtifactStore.upsertArtifact({
+            ...artificer,
+            contentJson: JSON.stringify({
+                implementationSummary: 'Implementation B',
+                affectedTools: ['write_file'],
+                risks: [],
+            }),
+            updatedAt: '2026-08-30T00:01:00.000Z',
+        });
+        const secondReview = await buildOwnerDecisionReview(reviewStoreFromStateManager(sm), EVAL_ID);
+        expect(secondReview?.reviewKey).toBe(firstReview?.reviewKey);
+        expect(secondReview?.evidence.digest).not.toBe(firstReview?.evidence.digest);
+        await sm.piArtifactStore.upsertArtifact(artificer);
+        const firstRequest = req('reject_current', {
+            expectedEvidenceDigest: firstReview.evidence.digest,
+        });
+        const first = await applyOwnerResolution(deps, {
+            taskId: EVAL_ID,
+            request: firstRequest,
+            identity,
+        });
+        expect(first.status).toBe('resolved');
+        await sm.piArtifactStore.upsertArtifact({
+            ...artificer,
+            contentJson: JSON.stringify({
+                implementationSummary: 'Implementation B',
+                affectedTools: ['write_file'],
+                risks: [],
+            }),
+            updatedAt: '2026-08-30T00:01:00.000Z',
+        });
+        const replay = await applyOwnerResolution(deps, {
+            taskId: EVAL_ID,
+            request: req('reject_current', {
+                expectedEvidenceDigest: secondReview.evidence.digest,
+            }),
+            identity,
+        });
+        expect(replay.status).toBe('stale_owner_decision');
+    });
+    it('revalidates independently persisted evidence after the CAS read and refuses a raced digest', async () => {
+        const { sm, deps, req } = await setup();
+        const decision = await sm.piArtifactStore.getArtifactById(ARTIFACT_ID);
+        await sm.piArtifactStore.upsertArtifact({
+            ...decision,
+            lineageArtifactIds: ['pi-art-artificer-old'],
+        });
+        await sm.piArtifactStore.upsertArtifact({
+            artifactId: 'pi-art-artificer-old',
+            artifactKind: 'principle',
+            sourceTaskId: ARTIFER_ID,
+            lineageArtifactIds: [],
+            validationStatus: 'pending',
+            contentJson: JSON.stringify({ implementationSummary: 'Evidence A', affectedTools: ['write_file'] }),
+            createdAt: '2026-08-30T00:00:00.000Z',
+            updatedAt: '2026-08-30T00:00:00.000Z',
+        });
+        const rendered = await buildOwnerDecisionReview(reviewStoreFromStateManager(sm), EVAL_ID);
+        expect(rendered).not.toBeNull();
+        const originalGetTask = sm.getTask.bind(sm);
+        let evaluatorReads = 0;
+        sm.getTask = async (id) => {
+            const task = await originalGetTask(id);
+            if (id === EVAL_ID && ++evaluatorReads === 3) {
+                const artifact = await sm.piArtifactStore.getArtifactById('pi-art-artificer-old');
+                await sm.piArtifactStore.upsertArtifact({
+                    ...artifact,
+                    contentJson: JSON.stringify({ implementationSummary: 'Evidence B', affectedTools: ['write_file'] }),
+                    updatedAt: '2026-08-30T00:01:00.000Z',
+                });
+            }
+            return task;
+        };
+        const outcome = await applyOwnerResolution(deps, {
+            taskId: EVAL_ID,
+            request: req('reject_current', { expectedEvidenceDigest: rendered.evidence.digest }),
+            identity,
+        });
+        expect(outcome.status).toBe('stale_owner_decision');
+        const unchanged = hydratePITaskRecord((await originalGetTask(EVAL_ID)));
+        expect(unchanged?.status).toBe('needs_human_review');
+        expect(unchanged?.ownerResolutions).toBeUndefined();
+    });
+    it('does not persist when evidence changes after the final review rebuild but before the task mutation', async () => {
+        const { sm, deps, req } = await setup();
+        const rendered = await buildOwnerDecisionReview(reviewStoreFromStateManager(sm), EVAL_ID);
+        expect(rendered).not.toBeNull();
+        const originalAtomicUpdate = sm.updateTaskIfDiagnosticJsonAndArtifactsUnchanged.bind(sm);
+        let intercepted = false;
+        sm.updateTaskIfDiagnosticJsonAndArtifactsUnchanged = async (...args) => {
+            if (!intercepted) {
+                intercepted = true;
+                const decision = await sm.piArtifactStore.getArtifactById(ARTIFACT_ID);
+                await sm.piArtifactStore.upsertArtifact({
+                    ...decision,
+                    contentJson: JSON.stringify({ changedAfterFinalReview: true }),
+                    updatedAt: '2026-08-30T00:02:00.000Z',
+                });
+            }
+            return originalAtomicUpdate(...args);
+        };
+        const outcome = await applyOwnerResolution(deps, {
+            taskId: EVAL_ID,
+            request: req('reject_current', { expectedEvidenceDigest: rendered.evidence.digest }),
+            identity,
+        });
+        expect(intercepted).toBe(true);
+        expect(outcome.status).toBe('stale_owner_decision');
+        const unchanged = hydratePITaskRecord((await sm.getTask(EVAL_ID)));
+        expect(unchanged?.status).toBe('needs_human_review');
+        expect(unchanged?.ownerResolutions).toBeUndefined();
+    });
     it('same reviewKey + different action → already_resolved (conflict)', async () => {
         const { deps, req } = await setup();
         await applyOwnerResolution(deps, { taskId: EVAL_ID, request: req('accept_current'), identity });