@principal-ai/subsystems-react 0.17.0 → 0.19.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (108) hide show
  1. package/README.md +11 -85
  2. package/dist/index.d.ts +7 -44
  3. package/dist/index.d.ts.map +1 -1
  4. package/dist/index.js +6 -32
  5. package/dist/index.js.map +1 -1
  6. package/dist/subsystem/SubsystemCarousel.d.ts +36 -0
  7. package/dist/subsystem/SubsystemCarousel.d.ts.map +1 -0
  8. package/dist/subsystem/SubsystemCarousel.js +163 -0
  9. package/dist/subsystem/SubsystemCarousel.js.map +1 -0
  10. package/dist/subsystem/SubsystemComponentGraph.d.ts +25 -0
  11. package/dist/subsystem/SubsystemComponentGraph.d.ts.map +1 -1
  12. package/dist/subsystem/SubsystemComponentGraph.js +329 -68
  13. package/dist/subsystem/SubsystemComponentGraph.js.map +1 -1
  14. package/package.json +4 -4
  15. package/src/index.ts +9 -199
  16. package/src/subsystem/SubsystemComponentGraph.tsx +396 -50
  17. package/src/components/ConfigurationSelector.tsx +0 -133
  18. package/src/components/GraphRenderer.tsx +0 -3195
  19. package/src/components/MultiCanvasRenderer.tsx +0 -295
  20. package/src/components/NodeTooltip.tsx +0 -279
  21. package/src/components/PendingChanges.test.tsx +0 -375
  22. package/src/components/SelectionSidebar.tsx +0 -352
  23. package/src/components/SequenceDiagramRenderer.tsx +0 -1156
  24. package/src/components/WorkflowSequenceDiagram.tsx +0 -270
  25. package/src/components/dashboard/DashboardRenderer.tsx +0 -317
  26. package/src/components/dashboard/MetricPanel.tsx +0 -254
  27. package/src/components/dashboard/MockDataProvider.ts +0 -330
  28. package/src/components/dashboard/components/BarChart.tsx +0 -299
  29. package/src/components/dashboard/components/LineChart.tsx +0 -279
  30. package/src/components/dashboard/components/MetricCard.tsx +0 -270
  31. package/src/components/dashboard/components/SourceLink.tsx +0 -63
  32. package/src/components/dashboard/components/TimeRangeSelector.tsx +0 -280
  33. package/src/components/dashboard/components/index.ts +0 -5
  34. package/src/components/dashboard/index.ts +0 -47
  35. package/src/components/dashboard/types.ts +0 -126
  36. package/src/components/state-view/PipelineView.tsx +0 -347
  37. package/src/components/state-view/index.ts +0 -14
  38. package/src/components/state-view/types.ts +0 -261
  39. package/src/components/state-view/useStateView.ts +0 -205
  40. package/src/contexts/GraphEditContext.tsx +0 -27
  41. package/src/contexts/TooltipPortalContext.ts +0 -8
  42. package/src/edges/CustomEdge.tsx +0 -402
  43. package/src/edges/GenericEdge.tsx +0 -36
  44. package/src/hooks/usePathBasedEvents.ts +0 -192
  45. package/src/hooks/useSequenceLayout.ts +0 -543
  46. package/src/hooks/useUndoRedo.ts +0 -144
  47. package/src/nodes/CustomNode.tsx +0 -1231
  48. package/src/nodes/GenericNode.tsx +0 -55
  49. package/src/nodes/otel/OtelBoundaryNode.tsx +0 -224
  50. package/src/nodes/otel/OtelEventNode.tsx +0 -225
  51. package/src/nodes/otel/OtelResourceNode.tsx +0 -251
  52. package/src/nodes/otel/OtelScopeNode.tsx +0 -221
  53. package/src/nodes/otel/OtelSpanConventionNode.tsx +0 -295
  54. package/src/nodes/otel/index.ts +0 -23
  55. package/src/nodes/otel/shared/NodeBadges.tsx +0 -295
  56. package/src/nodes/otel/shared/NodeContent.tsx +0 -204
  57. package/src/nodes/otel/shared/index.ts +0 -8
  58. package/src/nodes/otel/shared/types.ts +0 -138
  59. package/src/nodes/otel/shared/useNodeBehavior.ts +0 -114
  60. package/src/stories/Audit/BoundaryNodes.stories.tsx +0 -385
  61. package/src/stories/Audit/CanvasEdgeTypes.stories.tsx +0 -1448
  62. package/src/stories/Audit/CanvasNodeTypes.stories.tsx +0 -1049
  63. package/src/stories/Audit/ColorPriority.stories.tsx +0 -895
  64. package/src/stories/Audit/DiamondBadges.stories.tsx +0 -629
  65. package/src/stories/Audit/NodeDimensionsTesting.stories.tsx +0 -724
  66. package/src/stories/Audit/NodeFieldsAudit.stories.tsx +0 -996
  67. package/src/stories/Audit/NodeFontSizeTesting.stories.tsx +0 -715
  68. package/src/stories/Audit/NodeShapes.stories.tsx +0 -1208
  69. package/src/stories/Audit/WideNodesTesting.stories.tsx +0 -1045
  70. package/src/stories/Components/DashboardRenderer.stories.tsx +0 -263
  71. package/src/stories/Components/GraphRenderer.stories.tsx +0 -3236
  72. package/src/stories/Components/MultiCanvasRenderer.stories.tsx +0 -370
  73. package/src/stories/Components/SequenceDiagram.stories.tsx +0 -255
  74. package/src/stories/Components/StateView.stories.tsx +0 -417
  75. package/src/stories/Components/TraceViewer.stories.tsx +0 -442
  76. package/src/stories/Components/WorkflowSequenceDiagram.stories.tsx +0 -802
  77. package/src/stories/Features/AnimationWorkshop.stories.tsx +0 -727
  78. package/src/stories/Features/ChangeTypeVisual.stories.tsx +0 -67
  79. package/src/stories/Features/EventDrivenAnimations.stories.tsx +0 -513
  80. package/src/stories/Features/MultiConfig.stories.tsx +0 -539
  81. package/src/stories/Layout/ElkEdgeRouting.stories.tsx +0 -539
  82. package/src/stories/Layout/GraphOrientation.stories.tsx +0 -500
  83. package/src/stories/Layout/MultiDirectionalConnections.stories.tsx +0 -352
  84. package/src/stories/Nodes/NodeDefinitionComparison.stories.tsx +0 -560
  85. package/src/stories/Nodes/NodeNameFallbacks.stories.tsx +0 -491
  86. package/src/stories/Nodes/NumericColors.stories.tsx +0 -440
  87. package/src/stories/OTEL/EventNameDisplay.stories.tsx +0 -694
  88. package/src/stories/OTEL/EventNameFallback.stories.tsx +0 -578
  89. package/src/stories/OTEL/OtelComponents.stories.tsx +0 -422
  90. package/src/stories/OTEL/OtelNodeTypesPrototype.stories.tsx +0 -806
  91. package/src/stories/OTEL/RawEventCards.stories.tsx +0 -57
  92. package/src/stories/OTEL/SpanBadges.stories.tsx +0 -840
  93. package/src/stories/OTEL/ValidationEventsCanvas.stories.tsx +0 -209
  94. package/src/stories/RealWorld/BacklogMdCanvases.stories.tsx +0 -721
  95. package/src/stories/RealWorld/FileCitySequence.stories.tsx +0 -516
  96. package/src/stories/RealWorld/RealCanvasFiles.stories.tsx +0 -336
  97. package/src/stories/__traces__/test-run.canvas.json +0 -241
  98. package/src/stories/data/activity-feed-analytics.dashboard.json +0 -300
  99. package/src/stories/data/file-city-images-transformed.otel.canvas.json +0 -295
  100. package/src/stories/data/file-city-workflows.json +0 -269
  101. package/src/stories/data/graph-converter-test-execution.json +0 -443
  102. package/src/stories/data/graph-converter-test.workflow.json +0 -105
  103. package/src/stories/data/graph-converter-validated-execution.json +0 -58
  104. package/src/utils/animationMapping.ts +0 -166
  105. package/src/utils/canvasBounds.ts +0 -146
  106. package/src/utils/graphConverter.ts +0 -148
  107. package/src/utils/iconResolver.tsx +0 -53
  108. package/src/utils/orientationUtils.ts +0 -73
@@ -1,806 +0,0 @@
1
- import type { Meta, StoryObj } from '@storybook/react';
2
- import React from 'react';
3
- import { ThemeProvider, defaultEditorTheme } from '@principal-ade/industry-theme';
4
- import { GraphRenderer } from '../../components/GraphRenderer';
5
- import type { ExtendedCanvas, ComponentLibrary } from '@principal-ai/subsystems-core';
6
-
7
- /**
8
- * =============================================================================
9
- * OTEL Node Types - Examples
10
- * =============================================================================
11
- *
12
- * This story demonstrates the implemented OTEL canvas node types:
13
- * - otel-event: Telemetry events in workflows
14
- * - otel-span-convention: Span naming patterns
15
- * - otel-scope: Instrumentation scopes
16
- * - otel-resource: Service/deployment resources
17
- * - otel-boundary: External system interfaces
18
- *
19
- * See: docs/NODE_TYPE_MIGRATION.md for migration details.
20
- *
21
- * The new format uses:
22
- * - Semantic `type` values (otel-event, otel-span-convention, etc.)
23
- * - `label` for display text (required)
24
- * - Top-level fields (no `pv` wrapper needed)
25
- * - Consistent identifier display below label
26
- */
27
-
28
- // =============================================================================
29
- // PROPOSED NEW FORMAT (what we want to migrate to)
30
- // =============================================================================
31
-
32
- /**
33
- * This is what the NEW format would look like.
34
- * Note: `type` is semantic, no `text` field, no `pv` wrapper
35
- */
36
- const proposedNewFormat = {
37
- nodes: [
38
- // otel-event: Telemetry events in workflows
39
- {
40
- type: 'otel-event',
41
- id: 'analysis-started',
42
- x: 100,
43
- y: 100,
44
- width: 180,
45
- height: 80,
46
- color: '4', // green
47
- label: 'Analysis Started',
48
- event: {
49
- name: 'analysis.started',
50
- attributes: {
51
- 'file.count': { type: 'number', required: true, description: 'Number of files' },
52
- },
53
- },
54
- otel: {
55
- status: 'implemented',
56
- scope: 'validation',
57
- files: ['src/validation/analyzer.ts'],
58
- },
59
- },
60
-
61
- // otel-span-convention: Span naming patterns
62
- {
63
- type: 'otel-span-convention',
64
- id: 'validate-span',
65
- x: 100,
66
- y: 220,
67
- width: 180,
68
- height: 80,
69
- color: '5', // cyan
70
- label: 'Validation Operations',
71
- description: 'All validation-related spans',
72
- otel: {
73
- status: 'approved',
74
- spanPattern: 'validate.*',
75
- spanKind: 'INTERNAL',
76
- },
77
- },
78
-
79
- // otel-scope: Instrumentation scopes
80
- {
81
- type: 'otel-scope',
82
- id: 'validation-scope',
83
- x: 100,
84
- y: 340,
85
- width: 180,
86
- height: 80,
87
- color: '6', // purple
88
- label: 'Validation Scope',
89
- description: 'Tracer for validation operations',
90
- otel: {
91
- status: 'implemented',
92
- scope: 'validation',
93
- },
94
- },
95
-
96
- // otel-resource: Service/deployment resources
97
- {
98
- type: 'otel-resource',
99
- id: 'cli-resource',
100
- x: 100,
101
- y: 460,
102
- width: 180,
103
- height: 80,
104
- color: '2', // orange
105
- label: 'CLI Service',
106
- description: 'Principal View CLI tool',
107
- otel: {
108
- status: 'implemented',
109
- resourceMatch: {
110
- 'service.name': 'principal-view.cli',
111
- },
112
- },
113
- },
114
-
115
- // otel-boundary: External system interfaces
116
- {
117
- type: 'otel-boundary',
118
- id: 'github-webhook',
119
- x: 100,
120
- y: 580,
121
- width: 180,
122
- height: 80,
123
- color: '1', // red
124
- label: 'GitHub Webhook',
125
- description: 'Incoming webhook from GitHub',
126
- otel: {
127
- status: 'draft',
128
- origin: 'external',
129
- references: ['https://docs.github.com/webhooks'],
130
- },
131
- boundary: {
132
- direction: 'inbound',
133
- node: {
134
- 'pv.event.name': 'webhook.repository-created',
135
- 'pv.event.namespace': 'github',
136
- },
137
- },
138
- },
139
- ],
140
- edges: [],
141
- pv: {
142
- version: '1.0.0',
143
- name: 'New OTEL Node Types Prototype',
144
- description: 'Demonstrates the proposed new node type format',
145
- },
146
- };
147
-
148
- // =============================================================================
149
- // LIBRARY: Define scopes for scope-based coloring
150
- // =============================================================================
151
-
152
- const libraryWithScopes: ComponentLibrary = {
153
- version: '1.0.0',
154
- name: 'OTEL Node Types Library',
155
- description: 'Scope definitions for OTEL node types',
156
- scopes: {
157
- validation: {
158
- description: 'Validation instrumentation scope',
159
- color: '#8b5cf6', // purple - matches otel-scope node type
160
- },
161
- },
162
- nodeComponents: {},
163
- edgeComponents: {},
164
- };
165
-
166
- // =============================================================================
167
- // ADAPTER: Convert new format to current format for rendering
168
- // =============================================================================
169
-
170
- interface NewFormatNode {
171
- type: string;
172
- id: string;
173
- x: number;
174
- y: number;
175
- width: number;
176
- height: number;
177
- color?: string;
178
- label: string;
179
- description?: string;
180
- icon?: string;
181
- fill?: string;
182
- event?: {
183
- name: string;
184
- attributes?: Record<string, unknown>;
185
- };
186
- otel?: {
187
- status?: string;
188
- scope?: string;
189
- files?: string[];
190
- spanPattern?: string;
191
- spanKind?: string;
192
- resourceMatch?: Record<string, string>;
193
- origin?: string;
194
- references?: string[];
195
- };
196
- boundary?: {
197
- direction: string;
198
- node: Record<string, string>;
199
- };
200
- }
201
-
202
- /**
203
- * Get the identifier that should be displayed under the label for each node type
204
- */
205
- function getNodeIdentifier(node: NewFormatNode): string | undefined {
206
- switch (node.type) {
207
- case 'otel-event':
208
- return node.event?.name;
209
- case 'otel-span-convention':
210
- return node.otel?.spanPattern;
211
- case 'otel-scope':
212
- return node.otel?.scope;
213
- case 'otel-resource':
214
- // Show the primary resource match key/value
215
- if (node.otel?.resourceMatch) {
216
- const entries = Object.entries(node.otel.resourceMatch);
217
- if (entries.length > 0) {
218
- const [key, value] = entries[0];
219
- return `${key}: ${value}`;
220
- }
221
- }
222
- return undefined;
223
- case 'otel-boundary':
224
- return node.boundary?.direction;
225
- default:
226
- return undefined;
227
- }
228
- }
229
-
230
- function adaptNewFormatToCurrentFormat(newFormat: {
231
- nodes: NewFormatNode[];
232
- edges: unknown[];
233
- pv: unknown;
234
- }): ExtendedCanvas {
235
- const nodeTypeToIcon: Record<string, string> = {
236
- 'otel-event': 'Zap',
237
- 'otel-span-convention': 'GitCommit',
238
- 'otel-scope': 'Layers',
239
- 'otel-resource': 'Server',
240
- 'otel-boundary': 'ArrowRightLeft',
241
- };
242
-
243
- const nodeTypeToShape: Record<string, string> = {
244
- 'otel-event': 'rectangle',
245
- 'otel-span-convention': 'hexagon',
246
- 'otel-scope': 'circle',
247
- 'otel-resource': 'diamond',
248
- 'otel-boundary': 'rectangle',
249
- };
250
-
251
- return {
252
- nodes: newFormat.nodes.map((node) => {
253
- const identifier = getNodeIdentifier(node);
254
-
255
- // For the prototype, we use the existing event.name mechanism to show identifiers
256
- // by populating a synthetic event object with the identifier as the name.
257
- // This gives us the same styling (75% size, monospace, 50% opacity) for all node types.
258
- const syntheticEvent = identifier
259
- ? { name: identifier, attributes: {} }
260
- : node.event;
261
-
262
- return {
263
- id: node.id,
264
- type: 'text' as const,
265
- text: node.label,
266
- x: node.x,
267
- y: node.y,
268
- width: node.width,
269
- height: node.height,
270
- color: node.color,
271
- pv: {
272
- nodeType: node.type,
273
- name: node.label, // Just the label, identifier shown via event.name styling
274
- description: buildDescription(node),
275
- icon: node.icon || nodeTypeToIcon[node.type] || 'Circle',
276
- shape: nodeTypeToShape[node.type] || 'rectangle',
277
- status: node.otel?.status as 'draft' | 'approved' | 'implemented' | undefined,
278
- otel: node.otel
279
- ? {
280
- scope: node.otel.scope,
281
- files: node.otel.files,
282
- spanPattern: node.otel.spanPattern,
283
- spanKind: node.otel.spanKind as
284
- | 'UNSPECIFIED'
285
- | 'INTERNAL'
286
- | 'SERVER'
287
- | 'CLIENT'
288
- | 'PRODUCER'
289
- | 'CONSUMER'
290
- | undefined,
291
- resourceMatch: node.otel.resourceMatch,
292
- }
293
- : undefined,
294
- // Use synthetic event to show identifier with same styling as event names
295
- event: syntheticEvent,
296
- boundary: node.boundary as
297
- | {
298
- direction: 'inbound' | 'outbound';
299
- node: Record<string, string>;
300
- }
301
- | undefined,
302
- origin: node.otel?.origin as 'internal' | 'external' | undefined,
303
- references: node.otel?.references,
304
- },
305
- };
306
- }),
307
- edges: newFormat.edges as ExtendedCanvas['edges'],
308
- pv: {
309
- ...(newFormat.pv as object),
310
- nodeTypes: {
311
- 'otel-event': {
312
- label: 'Event',
313
- description: 'Telemetry event emitted during execution',
314
- color: '#22c55e',
315
- },
316
- 'otel-span-convention': {
317
- label: 'Span Convention',
318
- description: 'Naming pattern for spans',
319
- color: '#06b6d4',
320
- },
321
- 'otel-scope': {
322
- label: 'Scope',
323
- description: 'Instrumentation scope (tracer)',
324
- color: '#8b5cf6',
325
- },
326
- 'otel-resource': {
327
- label: 'Resource',
328
- description: 'Service or deployment resource',
329
- color: '#f97316',
330
- },
331
- 'otel-boundary': {
332
- label: 'Boundary',
333
- description: 'External system interface',
334
- color: '#ef4444',
335
- },
336
- },
337
- } as ExtendedCanvas['pv'],
338
- };
339
- }
340
-
341
- function buildDescription(node: NewFormatNode): string {
342
- const parts: string[] = [];
343
-
344
- if (node.description) {
345
- parts.push(node.description);
346
- }
347
-
348
- // Add type-specific info
349
- if (node.type === 'otel-event' && node.event) {
350
- parts.push(`\n\n**Event:** \`${node.event.name}\``);
351
- if (node.event.attributes) {
352
- const attrs = Object.entries(node.event.attributes)
353
- .map(([key, val]) => {
354
- const v = val as { type?: string; required?: boolean; description?: string };
355
- return `- \`${key}\`: ${v.type || 'unknown'}${v.required ? ' (required)' : ''}`;
356
- })
357
- .join('\n');
358
- parts.push(`\n**Attributes:**\n${attrs}`);
359
- }
360
- }
361
-
362
- if (node.type === 'otel-span-convention' && node.otel?.spanPattern) {
363
- parts.push(`\n\n**Pattern:** \`${node.otel.spanPattern}\``);
364
- if (node.otel.spanKind) {
365
- parts.push(`**SpanKind:** ${node.otel.spanKind}`);
366
- }
367
- }
368
-
369
- if (node.type === 'otel-scope' && node.otel?.scope) {
370
- parts.push(`\n\n**Scope:** \`${node.otel.scope}\``);
371
- }
372
-
373
- if (node.type === 'otel-resource' && node.otel?.resourceMatch) {
374
- const matches = Object.entries(node.otel.resourceMatch)
375
- .map(([k, v]) => `- \`${k}\`: ${v}`)
376
- .join('\n');
377
- parts.push(`\n\n**Resource Match:**\n${matches}`);
378
- }
379
-
380
- if (node.type === 'otel-boundary' && node.boundary) {
381
- parts.push(`\n\n**Direction:** ${node.boundary.direction}`);
382
- }
383
-
384
- // Add status
385
- if (node.otel?.status) {
386
- const statusEmoji: Record<string, string> = {
387
- draft: '\u{1F4DD}',
388
- approved: '\u2705',
389
- implemented: '\u{1F680}',
390
- };
391
- parts.push(`\n\n**Status:** ${statusEmoji[node.otel.status] || ''} ${node.otel.status}`);
392
- }
393
-
394
- return parts.join('');
395
- }
396
-
397
- // =============================================================================
398
- // STORIES
399
- // =============================================================================
400
-
401
- const meta: Meta = {
402
- title: 'OTEL/OtelNodeTypesPrototype',
403
- parameters: {
404
- layout: 'fullscreen',
405
- },
406
- };
407
-
408
- export default meta;
409
-
410
- /**
411
- * Shows all proposed OTEL node types rendered in the graph.
412
- *
413
- * Each node demonstrates:
414
- * - Semantic type (otel-event, otel-span-convention, etc.)
415
- * - Required `label` field
416
- * - Type-specific fields (event, spanPattern, resourceMatch, etc.)
417
- * - OTEL metadata grouped in `otel` field
418
- *
419
- * Hover over nodes to see the full metadata in tooltips.
420
- */
421
- export const AllNodeTypes: StoryObj = {
422
- render: () => {
423
- const canvas = adaptNewFormatToCurrentFormat(
424
- proposedNewFormat as {
425
- nodes: NewFormatNode[];
426
- edges: unknown[];
427
- pv: unknown;
428
- }
429
- );
430
-
431
- return (
432
- <ThemeProvider theme={defaultEditorTheme}>
433
- <div style={{ width: '100%', height: '800px' }}>
434
- <GraphRenderer canvas={canvas} library={libraryWithScopes} initialViewport={{ x: 50, y: 20, zoom: 1 }} />
435
- </div>
436
- </ThemeProvider>
437
- );
438
- },
439
- };
440
-
441
- /**
442
- * Shows the proposed JSON format for each node type.
443
- * Use this as a reference for the migration.
444
- */
445
- export const FormatReference: StoryObj = {
446
- render: () => {
447
- // Helper to get identifier for each node type
448
- const getIdentifier = (node: (typeof proposedNewFormat.nodes)[number]) => {
449
- const n = node as NewFormatNode;
450
- switch (n.type) {
451
- case 'otel-event':
452
- return n.event?.name;
453
- case 'otel-span-convention':
454
- return n.otel?.spanPattern;
455
- case 'otel-scope':
456
- return n.otel?.scope;
457
- case 'otel-resource':
458
- if (n.otel?.resourceMatch) {
459
- const [key, value] = Object.entries(n.otel.resourceMatch)[0] || [];
460
- return key ? `${key}: ${value}` : undefined;
461
- }
462
- return undefined;
463
- case 'otel-boundary':
464
- return n.boundary?.direction;
465
- default:
466
- return undefined;
467
- }
468
- };
469
-
470
- return (
471
- <ThemeProvider theme={defaultEditorTheme}>
472
- <div style={{ padding: '24px', maxWidth: '1200px', margin: '0 auto' }}>
473
- <h1 style={{ marginBottom: '24px' }}>Proposed OTEL Node Type Formats</h1>
474
- <p style={{ marginBottom: '24px', color: '#666' }}>
475
- See <code>docs/NODE_TYPE_MIGRATION.md</code> for full documentation.
476
- </p>
477
-
478
- {proposedNewFormat.nodes.map((node, i) => {
479
- const identifier = getIdentifier(node);
480
- return (
481
- <div
482
- key={i}
483
- style={{
484
- marginBottom: '32px',
485
- padding: '16px',
486
- backgroundColor: '#f8f9fa',
487
- borderRadius: '8px',
488
- border: '1px solid #e9ecef',
489
- }}
490
- >
491
- <div style={{ display: 'flex', alignItems: 'flex-start', gap: '24px', marginBottom: '12px' }}>
492
- <div>
493
- <h3 style={{ margin: 0, color: '#333' }}>
494
- <code>{node.type}</code>
495
- </h3>
496
- </div>
497
- <div
498
- style={{
499
- padding: '8px 16px',
500
- backgroundColor: '#fff',
501
- border: '2px solid #ddd',
502
- borderRadius: '6px',
503
- textAlign: 'center',
504
- minWidth: '140px',
505
- }}
506
- >
507
- <div style={{ fontWeight: 600, fontSize: '14px' }}>{node.label}</div>
508
- {identifier && (
509
- <div style={{ fontSize: '11px', color: '#666', fontFamily: 'monospace', marginTop: '4px' }}>
510
- {identifier}
511
- </div>
512
- )}
513
- </div>
514
- </div>
515
- <pre
516
- style={{
517
- backgroundColor: '#1e1e1e',
518
- color: '#d4d4d4',
519
- padding: '16px',
520
- borderRadius: '4px',
521
- overflow: 'auto',
522
- fontSize: '13px',
523
- lineHeight: '1.5',
524
- }}
525
- >
526
- {JSON.stringify(node, null, 2)}
527
- </pre>
528
- </div>
529
- );
530
- })}
531
- </div>
532
- </ThemeProvider>
533
- );
534
- },
535
- };
536
-
537
- /**
538
- * Side-by-side comparison of old format vs new format.
539
- */
540
- export const FormatComparison: StoryObj = {
541
- render: () => {
542
- const oldFormat = {
543
- type: 'text',
544
- text: 'Analysis Started',
545
- id: 'analysis-started',
546
- x: 100,
547
- y: 100,
548
- width: 180,
549
- height: 80,
550
- color: '4',
551
- pv: {
552
- nodeType: 'event',
553
- name: 'Analysis Started',
554
- description: 'Codebase composition analysis begins',
555
- status: 'implemented',
556
- event: {
557
- name: 'analysis.started',
558
- description: 'Analysis event',
559
- attributes: {
560
- 'file.count': { type: 'number', required: true },
561
- },
562
- },
563
- otel: {
564
- scope: 'validation',
565
- files: ['src/validation/analyzer.ts'],
566
- },
567
- },
568
- };
569
-
570
- const newFormat = {
571
- type: 'otel-event',
572
- id: 'analysis-started',
573
- x: 100,
574
- y: 100,
575
- width: 180,
576
- height: 80,
577
- color: '4',
578
- label: 'Analysis Started',
579
- event: {
580
- name: 'analysis.started',
581
- attributes: {
582
- 'file.count': { type: 'number', required: true, description: 'Number of files' },
583
- },
584
- },
585
- otel: {
586
- status: 'implemented',
587
- scope: 'validation',
588
- files: ['src/validation/analyzer.ts'],
589
- },
590
- };
591
-
592
- return (
593
- <ThemeProvider theme={defaultEditorTheme}>
594
- <div style={{ padding: '24px', maxWidth: '1400px', margin: '0 auto' }}>
595
- <h1 style={{ marginBottom: '24px' }}>Format Comparison</h1>
596
-
597
- <div style={{ display: 'grid', gridTemplateColumns: '1fr 1fr', gap: '24px' }}>
598
- <div>
599
- <h2 style={{ marginBottom: '16px', color: '#dc3545' }}>
600
- Old Format (current)
601
- </h2>
602
- <ul style={{ marginBottom: '16px', color: '#666' }}>
603
- <li>
604
- <code>type: "text"</code> - not semantic
605
- </li>
606
- <li>
607
- <code>text</code> field - duplicates pv.name
608
- </li>
609
- <li>
610
- <code>pv</code> wrapper - extra nesting
611
- </li>
612
- <li>
613
- <code>pv.description</code> - duplicates event.description
614
- </li>
615
- </ul>
616
- <pre
617
- style={{
618
- backgroundColor: '#1e1e1e',
619
- color: '#d4d4d4',
620
- padding: '16px',
621
- borderRadius: '4px',
622
- overflow: 'auto',
623
- fontSize: '12px',
624
- lineHeight: '1.5',
625
- }}
626
- >
627
- {JSON.stringify(oldFormat, null, 2)}
628
- </pre>
629
- </div>
630
-
631
- <div>
632
- <h2 style={{ marginBottom: '16px', color: '#28a745' }}>
633
- New Format (proposed)
634
- </h2>
635
- <ul style={{ marginBottom: '16px', color: '#666' }}>
636
- <li>
637
- <code>type: "otel-event"</code> - semantic
638
- </li>
639
- <li>
640
- <code>label</code> - single display field
641
- </li>
642
- <li>No <code>pv</code> wrapper - flat structure</li>
643
- <li>
644
- <code>otel</code> - instrumentation metadata only
645
- </li>
646
- </ul>
647
- <pre
648
- style={{
649
- backgroundColor: '#1e1e1e',
650
- color: '#d4d4d4',
651
- padding: '16px',
652
- borderRadius: '4px',
653
- overflow: 'auto',
654
- fontSize: '12px',
655
- lineHeight: '1.5',
656
- }}
657
- >
658
- {JSON.stringify(newFormat, null, 2)}
659
- </pre>
660
- </div>
661
- </div>
662
-
663
- <div style={{ marginTop: '32px', padding: '16px', backgroundColor: '#e8f5e9', borderRadius: '8px' }}>
664
- <h3 style={{ marginBottom: '8px' }}>Key Changes</h3>
665
- <ul style={{ marginBottom: 0 }}>
666
- <li><strong>-15 lines</strong> (from 29 to 14 lines)</li>
667
- <li><strong>No duplication</strong> - single source of truth for label, event name</li>
668
- <li><strong>Semantic typing</strong> - <code>type</code> describes the node's purpose</li>
669
- <li><strong>Flat structure</strong> - no more <code>pv.</code> prefix everywhere</li>
670
- </ul>
671
- </div>
672
-
673
- <div style={{ marginTop: '32px' }}>
674
- <h2 style={{ marginBottom: '16px' }}>Node Display: Label + Identifier</h2>
675
- <p style={{ marginBottom: '16px', color: '#666' }}>
676
- Each node shows its label plus identifier on the canvas:
677
- </p>
678
- <div style={{ display: 'flex', gap: '24px', flexWrap: 'wrap' }}>
679
- {[
680
- { type: 'otel-event', label: 'Analysis Started', identifier: 'analysis.started' },
681
- { type: 'otel-span-convention', label: 'Validation Ops', identifier: 'validate.*' },
682
- { type: 'otel-scope', label: 'Validation', identifier: 'validation' },
683
- { type: 'otel-resource', label: 'CLI Service', identifier: 'service.name: pv.cli' },
684
- { type: 'otel-boundary', label: 'GitHub Webhook', identifier: 'inbound' },
685
- ].map((n, i) => (
686
- <div
687
- key={i}
688
- style={{
689
- padding: '12px 20px',
690
- backgroundColor: '#fff',
691
- border: '2px solid #ddd',
692
- borderRadius: '8px',
693
- textAlign: 'center',
694
- minWidth: '140px',
695
- }}
696
- >
697
- <div style={{ fontSize: '10px', color: '#999', marginBottom: '4px' }}>{n.type}</div>
698
- <div style={{ fontWeight: 600, fontSize: '14px' }}>{n.label}</div>
699
- <div style={{ fontSize: '11px', color: '#666', fontFamily: 'monospace', marginTop: '4px' }}>
700
- {n.identifier}
701
- </div>
702
- </div>
703
- ))}
704
- </div>
705
- </div>
706
- </div>
707
- </ThemeProvider>
708
- );
709
- },
710
- };
711
-
712
- /**
713
- * Interactive workflow example using the new node types.
714
- */
715
- export const WorkflowExample: StoryObj = {
716
- render: () => {
717
- const workflowCanvas = adaptNewFormatToCurrentFormat({
718
- nodes: [
719
- {
720
- type: 'otel-scope',
721
- id: 'validation-scope',
722
- x: 50,
723
- y: 50,
724
- width: 160,
725
- height: 70,
726
- color: '6',
727
- label: 'Validation',
728
- description: 'Validation instrumentation scope',
729
- otel: { status: 'implemented', scope: 'validation' },
730
- },
731
- {
732
- type: 'otel-event',
733
- id: 'validation-started',
734
- x: 250,
735
- y: 50,
736
- width: 160,
737
- height: 70,
738
- color: '4',
739
- label: 'Validation Started',
740
- event: { name: 'validation.started', attributes: {} },
741
- otel: { status: 'implemented', scope: 'validation' },
742
- },
743
- {
744
- type: 'otel-event',
745
- id: 'file-parsed',
746
- x: 450,
747
- y: 50,
748
- width: 160,
749
- height: 70,
750
- color: '4',
751
- label: 'File Parsed',
752
- event: {
753
- name: 'validation.file.parsed',
754
- attributes: { 'file.path': { type: 'string', required: true } },
755
- },
756
- otel: { status: 'implemented', scope: 'validation' },
757
- },
758
- {
759
- type: 'otel-event',
760
- id: 'validation-complete',
761
- x: 650,
762
- y: 50,
763
- width: 160,
764
- height: 70,
765
- color: '4',
766
- label: 'Validation Complete',
767
- event: {
768
- name: 'validation.complete',
769
- attributes: { 'error.count': { type: 'number', required: true } },
770
- },
771
- otel: { status: 'implemented', scope: 'validation' },
772
- },
773
- {
774
- type: 'otel-span-convention',
775
- id: 'validate-span',
776
- x: 350,
777
- y: 170,
778
- width: 180,
779
- height: 70,
780
- color: '5',
781
- label: 'validate.*',
782
- description: 'All validation operation spans',
783
- otel: { status: 'approved', spanPattern: 'validate.*', spanKind: 'INTERNAL' },
784
- },
785
- ],
786
- edges: [
787
- { id: 'e1', fromNode: 'validation-scope', toNode: 'validation-started', fromSide: 'right', toSide: 'left' },
788
- { id: 'e2', fromNode: 'validation-started', toNode: 'file-parsed', fromSide: 'right', toSide: 'left' },
789
- { id: 'e3', fromNode: 'file-parsed', toNode: 'validation-complete', fromSide: 'right', toSide: 'left' },
790
- { id: 'e4', fromNode: 'validate-span', toNode: 'file-parsed', fromSide: 'top', toSide: 'bottom', label: 'governs' },
791
- ],
792
- pv: {
793
- version: '1.0.0',
794
- name: 'Validation Workflow',
795
- },
796
- } as { nodes: NewFormatNode[]; edges: unknown[]; pv: unknown });
797
-
798
- return (
799
- <ThemeProvider theme={defaultEditorTheme}>
800
- <div style={{ width: '100%', height: '400px' }}>
801
- <GraphRenderer canvas={workflowCanvas} library={libraryWithScopes} initialViewport={{ x: 20, y: 50, zoom: 1 }} />
802
- </div>
803
- </ThemeProvider>
804
- );
805
- },
806
- };