@principal-ai/principal-view-cli 0.2.1 → 0.2.2

package/dist/commands/validate.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"validate.d.ts","sourceRoot":"","sources":["../../src/commands/validate.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAunCpC,wBAAgB,qBAAqB,IAAI,OAAO,CAsH/C"}
+{"version":3,"file":"validate.d.ts","sourceRoot":"","sources":["../../src/commands/validate.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AA+pCpC,wBAAgB,qBAAqB,IAAI,OAAO,CAiI/C"}

package/dist/commands/validate.js

@@ -396,8 +396,9 @@ function hasOtelFeatures(canvas) {
  * - Edge types reference defined types in pv.edgeTypes or library.edgeComponents
  * - Node types reference defined types in pv.nodeTypes or library.nodeComponents
  * - Canvas has pv extension with name and version
+ * - OTEL nodes have source file references and the files exist
  */
-function validateCanvas(canvas, filePath, library) {
+function validateCanvas(canvas, filePath, library, repositoryPath) {
     const issues = [];
     if (!canvas || typeof canvas !== 'object') {
         issues.push({ type: 'error', message: 'Canvas must be an object' });
@@ -633,6 +634,37 @@ function validateCanvas(canvas, filePath, library) {
                 if (nodePv.otel && typeof nodePv.otel === 'object') {
                     checkUnknownFields(nodePv.otel, ALLOWED_CANVAS_FIELDS.nodePvOtel, `${nodePath}.pv.otel`, issues);
                 }
+                // Validate source file references for OTEL event nodes
+                const hasOtelFeatures = nodePv.otel !== undefined || nodePv.events !== undefined;
+                if (hasOtelFeatures) {
+                    // OTEL nodes must have at least one source file reference
+                    if (!Array.isArray(nodePv.sources) || nodePv.sources.length === 0) {
+                        issues.push({
+                            type: 'error',
+                            message: `Node "${nodeLabel}" has OTEL features but is missing required "pv.sources" field`,
+                            path: `${nodePath}.pv.sources`,
+                            suggestion: 'Add at least one source file reference, e.g.: "sources": ["src/services/MyService.ts"]',
+                        });
+                    }
+                }
+                // Validate that all source files exist (if repository path is provided)
+                if (Array.isArray(nodePv.sources) && repositoryPath) {
+                    nodePv.sources.forEach((source, sourceIndex) => {
+                        if (typeof source === 'string') {
+                            // Remove glob patterns (* characters) to get the base path
+                            const cleanPath = source.replace(/\*/g, '');
+                            const fullPath = resolve(repositoryPath, cleanPath);
+                            if (!existsSync(fullPath)) {
+                                issues.push({
+                                    type: 'error',
+                                    message: `Node "${nodeLabel}" references non-existent source file: ${source}`,
+                                    path: `${nodePath}.pv.sources[${sourceIndex}]`,
+                                    suggestion: `Verify the file path is correct relative to repository root: ${repositoryPath}`,
+                                });
+                            }
+                        }
+                    });
+                }
                 if (Array.isArray(nodePv.actions)) {
                     nodePv.actions.forEach((action, actionIndex) => {
                         if (action && typeof action === 'object') {
@@ -855,7 +887,7 @@ function validateCanvas(canvas, filePath, library) {
 /**
  * Validate a single .canvas file
  */
-function validateFile(filePath, library) {
+function validateFile(filePath, library, repositoryPath) {
     const absolutePath = resolve(filePath);
     const relativePath = relative(process.cwd(), absolutePath);
     if (!existsSync(absolutePath)) {
@@ -868,7 +900,7 @@ function validateFile(filePath, library) {
     try {
         const content = readFileSync(absolutePath, 'utf8');
         const canvas = JSON.parse(content);
-        const issues = validateCanvas(canvas, relativePath, library);
+        const issues = validateCanvas(canvas, relativePath, library, repositoryPath);
         const hasErrors = issues.some((i) => i.type === 'error');
         return {
             file: relativePath,
@@ -892,6 +924,7 @@ export function createValidateCommand() {
         .argument('[files...]', 'Files or glob patterns to validate (defaults to .principal-views/*.canvas)')
         .option('-q, --quiet', 'Only output errors')
         .option('--json', 'Output results as JSON')
+        .option('-r, --repository <path>', 'Repository root path for validating source file references (defaults to current directory)')
         .action(async (files, options) => {
         try {
             // Default to .principal-views/*.canvas if no files specified
@@ -914,6 +947,10 @@ export function createValidateCommand() {
             // Load library from .principal-views directory (used for type validation)
             const principalViewsDir = resolve(process.cwd(), '.principal-views');
             const library = loadLibrary(principalViewsDir);
+            // Determine repository path for source file validation
+            const repositoryPath = options.repository
+                ? resolve(options.repository)
+                : process.cwd();
             // Validate library if present
             let libraryResult = null;
             if (library && Object.keys(library.raw).length > 0) {
@@ -926,7 +963,7 @@ export function createValidateCommand() {
                 };
             }
             // Validate all canvas files
-            const results = matchedFiles.map((f) => validateFile(f, library));
+            const results = matchedFiles.map((f) => validateFile(f, library, repositoryPath));
             // Combine results
             const allResults = libraryResult ? [libraryResult, ...results] : results;
             const validCount = allResults.filter((r) => r.isValid).length;

package/dist/index.cjs

@@ -228747,7 +228747,7 @@ function hasOtelFeatures(canvas) {
   }
   return false;
 }
-function validateCanvas(canvas, filePath, library) {
+function validateCanvas(canvas, filePath, library, repositoryPath) {
   const issues = [];
   if (!canvas || typeof canvas !== "object") {
     issues.push({ type: "error", message: "Canvas must be an object" });
@@ -229019,6 +229019,33 @@ function validateCanvas(canvas, filePath, library) {
             issues
           );
         }
+        const hasOtelFeatures2 = nodePv.otel !== void 0 || nodePv.events !== void 0;
+        if (hasOtelFeatures2) {
+          if (!Array.isArray(nodePv.sources) || nodePv.sources.length === 0) {
+            issues.push({
+              type: "error",
+              message: `Node "${nodeLabel}" has OTEL features but is missing required "pv.sources" field`,
+              path: `${nodePath2}.pv.sources`,
+              suggestion: 'Add at least one source file reference, e.g.: "sources": ["src/services/MyService.ts"]'
+            });
+          }
+        }
+        if (Array.isArray(nodePv.sources) && repositoryPath) {
+          nodePv.sources.forEach((source, sourceIndex) => {
+            if (typeof source === "string") {
+              const cleanPath = source.replace(/\*/g, "");
+              const fullPath = (0, import_node_path5.resolve)(repositoryPath, cleanPath);
+              if (!(0, import_node_fs4.existsSync)(fullPath)) {
+                issues.push({
+                  type: "error",
+                  message: `Node "${nodeLabel}" references non-existent source file: ${source}`,
+                  path: `${nodePath2}.pv.sources[${sourceIndex}]`,
+                  suggestion: `Verify the file path is correct relative to repository root: ${repositoryPath}`
+                });
+              }
+            }
+          });
+        }
         if (Array.isArray(nodePv.actions)) {
           nodePv.actions.forEach((action, actionIndex) => {
             if (action && typeof action === "object") {
@@ -229230,7 +229257,7 @@ function validateCanvas(canvas, filePath, library) {
   }
   return issues;
 }
-function validateFile(filePath, library) {
+function validateFile(filePath, library, repositoryPath) {
   const absolutePath = (0, import_node_path5.resolve)(filePath);
   const relativePath = (0, import_node_path5.relative)(process.cwd(), absolutePath);
   if (!(0, import_node_fs4.existsSync)(absolutePath)) {
@@ -229243,7 +229270,7 @@ function validateFile(filePath, library) {
   try {
     const content = (0, import_node_fs4.readFileSync)(absolutePath, "utf8");
     const canvas = JSON.parse(content);
-    const issues = validateCanvas(canvas, relativePath, library);
+    const issues = validateCanvas(canvas, relativePath, library, repositoryPath);
     const hasErrors = issues.some((i) => i.type === "error");
     return {
       file: relativePath,
@@ -229264,7 +229291,10 @@ function createValidateCommand() {
   command.description("Validate .canvas configuration files").argument(
     "[files...]",
     "Files or glob patterns to validate (defaults to .principal-views/*.canvas)"
-  ).option("-q, --quiet", "Only output errors").option("--json", "Output results as JSON").action(async (files, options) => {
+  ).option("-q, --quiet", "Only output errors").option("--json", "Output results as JSON").option(
+    "-r, --repository <path>",
+    "Repository root path for validating source file references (defaults to current directory)"
+  ).action(async (files, options) => {
     try {
       const patterns = files.length > 0 ? files : [".principal-views/*.canvas"];
       const matchedFiles = await globby(patterns, {
@@ -229282,6 +229312,7 @@ function createValidateCommand() {
       }
       const principalViewsDir = (0, import_node_path5.resolve)(process.cwd(), ".principal-views");
       const library = loadLibrary(principalViewsDir);
+      const repositoryPath = options.repository ? (0, import_node_path5.resolve)(options.repository) : process.cwd();
       let libraryResult = null;
       if (library && Object.keys(library.raw).length > 0) {
         const libraryIssues = validateLibrary(library);
@@ -229292,7 +229323,9 @@ function createValidateCommand() {
           issues: libraryIssues
         };
       }
-      const results = matchedFiles.map((f) => validateFile(f, library));
+      const results = matchedFiles.map(
+        (f) => validateFile(f, library, repositoryPath)
+      );
       const allResults = libraryResult ? [libraryResult, ...results] : results;
       const validCount = allResults.filter((r) => r.isValid).length;
       const invalidCount = allResults.length - validCount;