@principal-ai/principal-view-cli 0.1.29 → 0.1.30

package/dist/commands/lint.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"lint.d.ts","sourceRoot":"","sources":["../../src/commands/lint.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AA2PpC,wBAAgB,iBAAiB,IAAI,OAAO,CA6L3C"}
+{"version":3,"file":"lint.d.ts","sourceRoot":"","sources":["../../src/commands/lint.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAwTpC,wBAAgB,iBAAiB,IAAI,OAAO,CAwQ3C"}

package/dist/commands/lint.js

@@ -7,7 +7,7 @@ import { resolve, relative, dirname, basename } from 'node:path';
 import chalk from 'chalk';
 import { globby } from 'globby';
 import yaml from 'js-yaml';
-import { createDefaultRulesEngine, validatePrivuConfig, mergeConfigs, getDefaultConfig, } from '@principal-ai/principal-view-core';
+import { createDefaultRulesEngine, validatePrivuConfig, mergeConfigs, getDefaultConfig, createNarrativeValidator, } from '@principal-ai/principal-view-core';
 // ============================================================================
 // Config File Loading
 // ============================================================================
@@ -116,6 +116,56 @@ function loadGraphConfig(filePath) {
         return null;
     }
 }
+/**
+ * Load a narrative template file
+ */
+function loadNarrativeTemplate(filePath) {
+    if (!existsSync(filePath)) {
+        return null;
+    }
+    try {
+        const raw = readFileSync(filePath, 'utf8');
+        const narrative = JSON.parse(raw);
+        return { narrative, raw };
+    }
+    catch {
+        return null;
+    }
+}
+/**
+ * Load a canvas file for narrative validation
+ */
+function loadCanvas(filePath) {
+    if (!existsSync(filePath)) {
+        return null;
+    }
+    try {
+        const content = readFileSync(filePath, 'utf8');
+        const ext = filePath.toLowerCase();
+        if (ext.endsWith('.json')) {
+            return JSON.parse(content);
+        }
+        else {
+            return yaml.load(content);
+        }
+    }
+    catch {
+        return null;
+    }
+}
+/**
+ * Determine file type
+ */
+function getFileType(filePath) {
+    const name = basename(filePath).toLowerCase();
+    if (name.endsWith('.narrative.json')) {
+        return 'narrative';
+    }
+    if (name.endsWith('.canvas') || name.endsWith('.otel.canvas')) {
+        return 'canvas';
+    }
+    return 'config';
+}
 // ============================================================================
 // Output Formatting
 // ============================================================================
@@ -282,15 +332,14 @@ export function createLintCommand() {
                 ignore: privuConfig.exclude || ['**/node_modules/**'],
                 expandDirectories: false,
             });
-            // Filter out library files, config files, canvas files, narrative templates, and execution artifacts
+            // Filter out library files, config files, and execution artifacts
+            // INCLUDE both canvas files and narrative templates for linting
             const configFiles = matchedFiles.filter((f) => {
                 const name = basename(f).toLowerCase();
                 const isLibraryFile = name.startsWith('library.');
                 const isConfigFile = name.startsWith('.privurc');
-                const isCanvasFile = f.toLowerCase().endsWith('.canvas');
-                const isNarrativeTemplate = name.endsWith('.narrative.json');
                 const isExecutionArtifact = f.includes('__executions__/');
-                return !isLibraryFile && !isConfigFile && !isCanvasFile && !isNarrativeTemplate && !isExecutionArtifact;
+                return !isLibraryFile && !isConfigFile && !isExecutionArtifact;
             });
             if (configFiles.length === 0) {
                 if (options.json) {
@@ -315,44 +364,116 @@ export function createLintCommand() {
                     console.log(chalk.yellow(`Warning: Could not load library from ${libraryPath}`));
                 }
             }
-            // Create rules engine
+            // Helper function to count violations by rule
+            function countByRule(violations) {
+                const counts = {};
+                for (const v of violations) {
+                    counts[v.ruleId] = (counts[v.ruleId] || 0) + 1;
+                }
+                return counts;
+            }
+            // Create validators
             const engine = createDefaultRulesEngine();
+            const narrativeValidator = createNarrativeValidator();
             // Lint each file
             const results = new Map();
             for (const filePath of configFiles) {
                 const absolutePath = resolve(cwd, filePath);
                 const relativePath = relative(cwd, absolutePath);
-                const loaded = loadGraphConfig(absolutePath);
-                if (!loaded) {
-                    // File couldn't be loaded - report as error
+                const fileType = getFileType(absolutePath);
+                if (fileType === 'narrative') {
+                    // Validate narrative template
+                    const loaded = loadNarrativeTemplate(absolutePath);
+                    if (!loaded) {
+                        // File couldn't be loaded - report as error
+                        results.set(relativePath, {
+                            violations: [
+                                {
+                                    ruleId: 'parse-error',
+                                    severity: 'error',
+                                    file: relativePath,
+                                    message: `Could not parse narrative file: ${filePath}`,
+                                    impact: 'File cannot be validated',
+                                    fixable: false,
+                                },
+                            ],
+                            errorCount: 1,
+                            warningCount: 0,
+                            fixableCount: 0,
+                            byCategory: { schema: 1, reference: 0, structure: 0, pattern: 0, library: 0 },
+                            byRule: { 'parse-error': 1 },
+                        });
+                        continue;
+                    }
+                    // Load the referenced canvas if it exists
+                    const canvasPath = loaded.narrative.canvas
+                        ? resolve(dirname(absolutePath), loaded.narrative.canvas)
+                        : undefined;
+                    const canvas = canvasPath ? loadCanvas(canvasPath) : undefined;
+                    // Run narrative validation
+                    const narrativeResult = await narrativeValidator.validate({
+                        narrative: loaded.narrative,
+                        narrativePath: relativePath,
+                        canvas: canvas ?? undefined,
+                        canvasPath: canvasPath ? relative(cwd, canvasPath) : undefined,
+                        basePath: dirname(absolutePath),
+                        rawContent: loaded.raw,
+                    });
+                    // Convert narrative violations to graph violations format
+                    const violations = narrativeResult.violations.map((v) => ({
+                        ruleId: v.ruleId,
+                        severity: v.severity,
+                        file: v.file,
+                        line: v.line,
+                        path: v.path,
+                        message: v.message,
+                        impact: v.impact,
+                        suggestion: v.suggestion,
+                        fixable: v.fixable,
+                    }));
                     results.set(relativePath, {
-                        violations: [
-                            {
-                                ruleId: 'parse-error',
-                                severity: 'error',
-                                file: relativePath,
-                                message: `Could not parse file: ${filePath}`,
-                                impact: 'File cannot be validated',
-                                fixable: false,
-                            },
-                        ],
-                        errorCount: 1,
-                        warningCount: 0,
-                        fixableCount: 0,
-                        byCategory: { schema: 1, reference: 0, structure: 0, pattern: 0, library: 0 },
-                        byRule: { 'parse-error': 1 },
+                        violations,
+                        errorCount: narrativeResult.errorCount,
+                        warningCount: narrativeResult.warningCount,
+                        fixableCount: narrativeResult.fixableCount,
+                        byCategory: { schema: 0, reference: 0, structure: 0, pattern: 0, library: 0 }, // Could categorize narrative rules
+                        byRule: countByRule(violations),
+                    });
+                }
+                else {
+                    // Validate canvas/graph configuration
+                    const loaded = loadGraphConfig(absolutePath);
+                    if (!loaded) {
+                        // File couldn't be loaded - report as error
+                        results.set(relativePath, {
+                            violations: [
+                                {
+                                    ruleId: 'parse-error',
+                                    severity: 'error',
+                                    file: relativePath,
+                                    message: `Could not parse file: ${filePath}`,
+                                    impact: 'File cannot be validated',
+                                    fixable: false,
+                                },
+                            ],
+                            errorCount: 1,
+                            warningCount: 0,
+                            fixableCount: 0,
+                            byCategory: { schema: 1, reference: 0, structure: 0, pattern: 0, library: 0 },
+                            byRule: { 'parse-error': 1 },
+                        });
+                        continue;
+                    }
+                    // Run linting
+                    const result = await engine.lintWithConfig(loaded.config, privuConfig, {
+                        library,
+                        configPath: relativePath,
+                        rawContent: loaded.raw,
+                        enabledRules: options.rule,
+                        disabledRules: options.ignoreRule,
                     });
-                    continue;
+                    results.set(relativePath, result);
                 }
-                // Run linting
-                const result = await engine.lintWithConfig(loaded.config, privuConfig, {
-                    library,
-                    configPath: relativePath,
-                    rawContent: loaded.raw,
-                    enabledRules: options.rule,
-                    disabledRules: options.ignoreRule,
-                });
-                results.set(relativePath, result);
             }
             // Output results
             if (options.json) {