@primer/view-components 0.31.1-rc.0b9baf9f → 0.31.1-rc.681ebd27

package/app/components/primer/alpha/select_panel_element.js

@@ -692,10 +692,10 @@ _SelectPanelElement_updateItemVisibility = function _SelectPanelElement_updateIt
             }
         }
         else if (value && !__classPrivateFieldGet(this, _SelectPanelElement_selectedItems, "f").has(value) && this.isItemChecked(item)) {
-            __classPrivateFieldSet(this, _SelectPanelElement_hasLoadedData, true, "f");
             __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_addSelectedItem).call(this, item);
         }
     }
+    __classPrivateFieldSet(this, _SelectPanelElement_hasLoadedData, true, "f");
     if (!this.noResults)
         return;
     if (__classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_inErrorState).call(this)) {
@@ -824,7 +824,8 @@ _SelectPanelElement_handleItemActivated = function _SelectPanelElement_handleIte
     // interfere with events fired by menu items whose behavior is specified outside the library.
     if (this.selectVariant !== 'multiple' && this.selectVariant !== 'single')
         return;
-    const checked = !this.isItemChecked(item);
+    const currentlyChecked = this.isItemChecked(item);
+    const checked = !currentlyChecked;
     const activationSuccess = this.dispatchEvent(new CustomEvent('beforeItemActivated', {
         bubbles: true,
         detail: { item, checked },
@@ -834,18 +835,18 @@ _SelectPanelElement_handleItemActivated = function _SelectPanelElement_handleIte
         return;
     const itemContent = __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_getItemContent).call(this, item);
     if (this.selectVariant === 'single') {
-        const value = this.selectedItems[0]?.value;
-        const element = this.visibleItems.find(el => __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_getItemContent).call(this, el)?.getAttribute('data-value') === value);
-        if (element) {
-            __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_getItemContent).call(this, element)?.setAttribute(this.ariaSelectionType, 'false');
-        }
-        __classPrivateFieldGet(this, _SelectPanelElement_selectedItems, "f").clear();
-        // Only check, never uncheck here. Single-select mode does not allow unchecking a checked item.
-        if (checked) {
-            __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_addSelectedItem).call(this, item);
-            itemContent?.setAttribute(this.ariaSelectionType, 'true');
+        // disallow unchecking checked item in single-select mode
+        if (!currentlyChecked) {
+            for (const el of this.items) {
+                __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_getItemContent).call(this, el)?.setAttribute(this.ariaSelectionType, 'false');
+            }
+            __classPrivateFieldGet(this, _SelectPanelElement_selectedItems, "f").clear();
+            if (checked) {
+                __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_addSelectedItem).call(this, item);
+                itemContent?.setAttribute(this.ariaSelectionType, 'true');
+            }
+            __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_setDynamicLabel).call(this);
         }
-        __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_setDynamicLabel).call(this);
     }
     else {
         // multi-select mode allows unchecking a checked item

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@primer/view-components",
-  "version": "0.31.1-rc.0b9baf9f",
+  "version": "0.31.1-rc.681ebd27",
   "description": "ViewComponents for the Primer Design System",
   "main": "app/assets/javascripts/primer_view_components.js",
   "module": "app/components/primer/primer.js",
@@ -92,7 +92,9 @@
     "stylelint": "^16.1.0",
     "stylelint-config-standard": "^36.0.0",
     "tslib": "^2.4.0",
-    "typescript": "^5.2.2"
+    "typescript": "^5.2.2",
+    "vite": "^5.3.5",
+    "vite-plugin-ruby": "^5.0.0"
   },
   "prettier": "@github/prettier-config",
   "browserslist": "extends @github/browserslist-config"