@primer/view-components 0.31.0-rc.b5696d3b → 0.31.0-rc.dab49dc3

package/app/components/primer/alpha/select_panel_element.d.ts

@@ -6,7 +6,6 @@ type SelectedItem = {
     label: string | null | undefined;
     value: string | null | undefined;
     inputName: string | null | undefined;
-    element: SelectPanelItem;
 };
 export type SelectPanelItem = HTMLLIElement;
 export type FilterFn = (item: SelectPanelItem, query: string) => boolean;

package/app/components/primer/alpha/select_panel_element.js

@@ -55,6 +55,7 @@ const updateWhenVisible = (() => {
         }));
         resizeObserver.observe(el.ownerDocument.documentElement);
         el.addEventListener('dialog:close', () => {
+            el.invokerElement?.setAttribute('aria-expanded', 'false');
             anchors.delete(el);
         });
         el.addEventListener('dialog:open', () => {
@@ -252,6 +253,7 @@ let SelectPanelElement = class SelectPanelElement extends HTMLElement {
         if (event.target === this.dialog && event.type === 'close') {
             // Remove data-ready so it can be set the next time the panel is opened
             this.dialog.removeAttribute('data-ready');
+            this.invokerElement?.setAttribute('aria-expanded', 'false');
             this.dispatchEvent(new CustomEvent('panelClosed', {
                 detail: { panel: this },
                 bubbles: true,
@@ -301,6 +303,7 @@ let SelectPanelElement = class SelectPanelElement extends HTMLElement {
     show() {
         this.updateAnchorPosition();
         this.dialog.showModal();
+        this.invokerElement?.setAttribute('aria-expanded', 'true');
         const event = new CustomEvent('dialog:open', {
             detail: { dialog: this.dialog },
         });
@@ -499,7 +502,6 @@ _SelectPanelElement_addSelectedItem = function _SelectPanelElement_addSelectedIt
             value,
             label: itemContent.querySelector('.ActionListItem-label')?.textContent?.trim(),
             inputName: itemContent.getAttribute('data-input-name'),
-            element: item,
         });
     }
 };
@@ -609,7 +611,9 @@ _SelectPanelElement_handleSearchFieldEvent = function _SelectPanelElement_handle
         if (key === 'Enter') {
             const item = this.visibleItems[0];
             if (item) {
-                __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_handleItemActivated).call(this, item, false);
+                const itemContent = __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_getItemContent).call(this, item);
+                if (itemContent)
+                    itemContent.click();
             }
         }
         else if (key === 'ArrowDown') {
@@ -622,14 +626,18 @@ _SelectPanelElement_handleSearchFieldEvent = function _SelectPanelElement_handle
         else if (key === 'Home') {
             const item = this.visibleItems[0];
             if (item) {
-                __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_getItemContent).call(this, item).focus();
+                const itemContent = __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_getItemContent).call(this, item);
+                if (itemContent)
+                    itemContent.focus();
                 event.preventDefault();
             }
         }
         else if (key === 'End') {
             if (this.visibleItems.length > 0) {
                 const item = this.visibleItems[this.visibleItems.length - 1];
-                __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_getItemContent).call(this, item).focus();
+                const itemContent = __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_getItemContent).call(this, item);
+                if (itemContent)
+                    itemContent.focus();
                 event.preventDefault();
             }
         }
@@ -797,7 +805,7 @@ _SelectPanelElement_handleDialogItemActivated = function _SelectPanelElement_han
     dialog.addEventListener('close', handleDialogClose, { signal });
     dialog.addEventListener('cancel', handleDialogClose, { signal });
 };
-_SelectPanelElement_handleItemActivated = function _SelectPanelElement_handleItemActivated(item, shouldClose = true) {
+_SelectPanelElement_handleItemActivated = function _SelectPanelElement_handleItemActivated(item) {
     // Hide popover after current event loop to prevent changes in focus from
     // altering the target of the event. Not doing this specifically affects
     // <a> tags. It causes the event to be sent to the currently focused element
@@ -806,7 +814,7 @@ _SelectPanelElement_handleItemActivated = function _SelectPanelElement_handleIte
     // works fine.
     if (this.selectVariant !== 'multiple') {
         setTimeout(() => {
-            if (this.open && shouldClose) {
+            if (this.open) {
                 this.hide();
             }
         });
@@ -825,7 +833,8 @@ _SelectPanelElement_handleItemActivated = function _SelectPanelElement_handleIte
         return;
     const itemContent = __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_getItemContent).call(this, item);
     if (this.selectVariant === 'single') {
-        const element = this.selectedItems[0]?.element;
+        const value = this.selectedItems[0]?.value;
+        const element = this.visibleItems.find(el => __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_getItemContent).call(this, el)?.getAttribute('data-value') === value);
         if (element) {
             __classPrivateFieldGet(this, _SelectPanelElement_instances, "m", _SelectPanelElement_getItemContent).call(this, element)?.setAttribute(this.ariaSelectionType, 'false');
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@primer/view-components",
-  "version": "0.31.0-rc.b5696d3b",
+  "version": "0.31.0-rc.dab49dc3",
   "description": "ViewComponents for the Primer Design System",
   "main": "app/assets/javascripts/primer_view_components.js",
   "module": "app/components/primer/primer.js",

package/static/info_arch.json

@@ -991,6 +991,12 @@
             "name": "description",
             "description": "Description content that complements the item's label, with optional test_selector.\nSee `ActionList`'s `description_scheme` argument for layout options.",
             "parameters": [
+              {
+                "name": "legacy_content",
+                "type": "String",
+                "default": "N/A",
+                "description": "Slot content, provided for backwards-compatibility. Pass a content block instead, or call `with_content`, eg. `component.with_description { \"My description\" }` or `component.with_description.with_content(\"My description\")`."
+              },
               {
                 "name": "test_selector",
                 "type": "String",
@@ -5554,6 +5560,12 @@
             "name": "description",
             "description": "Description content that complements the item's label, with optional test_selector.\nSee `ActionList`'s `description_scheme` argument for layout options.",
             "parameters": [
+              {
+                "name": "legacy_content",
+                "type": "String",
+                "default": "N/A",
+                "description": "Slot content, provided for backwards-compatibility. Pass a content block instead, or call `with_content`, eg. `component.with_description { \"My description\" }` or `component.with_description.with_content(\"My description\")`."
+              },
               {
                 "name": "test_selector",
                 "type": "String",
@@ -8093,6 +8105,19 @@
             "color-contrast"
           ]
         }
+      },
+      {
+        "preview_path": "primer/alpha/select_panel/list_of_links",
+        "name": "list_of_links",
+        "snapshot": "interactive",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
       }
     ],
     "subcomponents": [
@@ -14699,6 +14724,12 @@
             "name": "description",
             "description": "Description content that complements the item's label, with optional test_selector.\nSee `ActionList`'s `description_scheme` argument for layout options.",
             "parameters": [
+              {
+                "name": "legacy_content",
+                "type": "String",
+                "default": "N/A",
+                "description": "Slot content, provided for backwards-compatibility. Pass a content block instead, or call `with_content`, eg. `component.with_description { \"My description\" }` or `component.with_description.with_content(\"My description\")`."
+              },
               {
                 "name": "test_selector",
                 "type": "String",

package/static/previews.json

@@ -6160,6 +6160,19 @@
             "color-contrast"
           ]
         }
+      },
+      {
+        "preview_path": "primer/alpha/select_panel/list_of_links",
+        "name": "list_of_links",
+        "snapshot": "interactive",
+        "skip_rules": {
+          "wont_fix": [
+            "region"
+          ],
+          "will_fix": [
+            "color-contrast"
+          ]
+        }
       }
     ]
   },