@primer/view-components 0.1.9 → 0.1.10-rc.598d85b7

package/app/components/primer/alpha/action_menu/action_menu_element.js

@@ -9,17 +9,8 @@ var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (
     if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot read private member from an object whose class did not declare it");
     return kind === "m" ? f : kind === "a" ? f.call(receiver) : f ? f.value : state.get(receiver);
 };
-var _ActionMenuElement_instances, _ActionMenuElement_abortController, _ActionMenuElement_originalLabel, _ActionMenuElement_inputName, _ActionMenuElement_setDynamicLabel, _ActionMenuElement_updateInput, _ActionMenuElement_isEnterKeydown, _ActionMenuElement_firstItem_get;
+var _ActionMenuElement_instances, _ActionMenuElement_abortController, _ActionMenuElement_originalLabel, _ActionMenuElement_inputName, _ActionMenuElement_setDynamicLabel, _ActionMenuElement_updateInput, _ActionMenuElement_isActivationKeydown, _ActionMenuElement_firstItem_get;
 import '@github/include-fragment-element';
-const popoverSelector = (() => {
-    try {
-        document.querySelector(':open');
-        return ':open';
-    }
-    catch (_a) {
-        return '.\\:open';
-    }
-})();
 const menuItemSelectors = ['[role="menuitem"]', '[role="menuitemcheckbox"]', '[role="menuitemradio"]'];
 export class ActionMenuElement extends HTMLElement {
     constructor() {
@@ -101,7 +92,7 @@ export class ActionMenuElement extends HTMLElement {
     }
     handleEvent(event) {
         var _a, _b, _c, _d;
-        if (event.target === this.invokerElement && __classPrivateFieldGet(this, _ActionMenuElement_instances, "m", _ActionMenuElement_isEnterKeydown).call(this, event)) {
+        if (event.target === this.invokerElement && __classPrivateFieldGet(this, _ActionMenuElement_instances, "m", _ActionMenuElement_isActivationKeydown).call(this, event)) {
             if (__classPrivateFieldGet(this, _ActionMenuElement_instances, "a", _ActionMenuElement_firstItem_get)) {
                 event.preventDefault();
                 (_a = this.popoverElement) === null || _a === void 0 ? void 0 : _a.showPopover();
@@ -109,12 +100,12 @@ export class ActionMenuElement extends HTMLElement {
                 return;
             }
         }
-        if (!((_b = this.popoverElement) === null || _b === void 0 ? void 0 : _b.matches(popoverSelector)))
+        if (!((_b = this.popoverElement) === null || _b === void 0 ? void 0 : _b.matches(':popover-open')))
             return;
         if (event.type === 'focusout' && !this.contains(event.relatedTarget)) {
             (_c = this.popoverElement) === null || _c === void 0 ? void 0 : _c.hidePopover();
         }
-        else if (__classPrivateFieldGet(this, _ActionMenuElement_instances, "m", _ActionMenuElement_isEnterKeydown).call(this, event) || (event instanceof MouseEvent && event.type === 'click')) {
+        else if (__classPrivateFieldGet(this, _ActionMenuElement_instances, "m", _ActionMenuElement_isActivationKeydown).call(this, event) || (event instanceof MouseEvent && event.type === 'click')) {
             const item = (_d = event.target.closest(menuItemSelectors.join(','))) === null || _d === void 0 ? void 0 : _d.closest('li');
             if (!item)
                 return;
@@ -203,11 +194,11 @@ _ActionMenuElement_abortController = new WeakMap(), _ActionMenuElement_originalL
             input.remove();
         }
     }
-}, _ActionMenuElement_isEnterKeydown = function _ActionMenuElement_isEnterKeydown(event) {
+}, _ActionMenuElement_isActivationKeydown = function _ActionMenuElement_isActivationKeydown(event) {
     return (event instanceof KeyboardEvent &&
         event.type === 'keydown' &&
         !(event.ctrlKey || event.altKey || event.metaKey || event.shiftKey) &&
-        event.key === 'Enter');
+        (event.key === 'Enter' || event.key === ' '));
 }, _ActionMenuElement_firstItem_get = function _ActionMenuElement_firstItem_get() {
     return this.querySelector(menuItemSelectors.join(','));
 };

package/app/components/primer/focus_group.js

@@ -12,15 +12,6 @@ var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (
 var _FocusGroupElement_instances, _FocusGroupElement_abortController, _FocusGroupElement_items_get;
 import '@oddbird/popover-polyfill';
 const menuItemSelector = '[role="menuitem"],[role="menuitemcheckbox"],[role="menuitemradio"]';
-const popoverSelector = (() => {
-    try {
-        document.querySelector(':popover-open');
-        return ':popover-open';
-    }
-    catch (_a) {
-        return '.\\:popover-open';
-    }
-})();
 const getMnemonicFor = (item) => { var _a; return (_a = item.textContent) === null || _a === void 0 ? void 0 : _a.trim()[0].toLowerCase(); };
 const printable = /^\S$/;
 export default class FocusGroupElement extends HTMLElement {
@@ -128,7 +119,7 @@ export default class FocusGroupElement extends HTMLElement {
             {
                 let el = focusEl;
                 do {
-                    el = el.closest(`[popover]:not(${popoverSelector})`);
+                    el = el.closest(`[popover]:not(:popover-open)`);
                     if ((el === null || el === void 0 ? void 0 : el.popover) === 'auto') {
                         el.showPopover();
                     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@primer/view-components",
-  "version": "0.1.9",
+  "version": "0.1.10-rc.598d85b7",
   "description": "ViewComponents for the Primer Design System",
   "main": "app/assets/javascripts/primer_view_components.js",
   "module": "app/components/primer/primer.js",
@@ -54,12 +54,13 @@
     "@github/mini-throttle": "^2.1.0",
     "@github/relative-time-element": "^4.0.0",
     "@github/tab-container-element": "^3.1.2",
-    "@oddbird/popover-polyfill": "^0.1.1",
+    "@oddbird/popover-polyfill": "^0.2.1",
     "@primer/behaviors": "^1.3.4"
   },
   "devDependencies": {
     "@changesets/changelog-github": "^0.4.6",
     "@changesets/cli": "^2.24.1",
+    "@github/axe-github": "^0.5.0",
     "@github/browserslist-config": "^1.0.0",
     "@github/markdownlint-github": "^0.2.2",
     "@github/prettier-config": "0.0.4",
@@ -70,7 +71,7 @@
     "@rollup/plugin-typescript": "^8.3.3",
     "@typescript-eslint/eslint-plugin": "^5.31.0",
     "@typescript-eslint/parser": "^5.31.0",
-    "axe-core": "^4.6.2",
+    "axe-core": "^4.7.1",
     "chokidar-cli": "^3.0.0",
     "cssnano": "^5.1.13",
     "eslint": "^8.23.1",