@primer/view-components 0.1.9-rc.ed6f20bc → 0.1.10-rc.fdc6a7e6

package/app/components/primer/alpha/action_menu/action_menu_element.js

@@ -11,15 +11,6 @@ var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (
 };
 var _ActionMenuElement_instances, _ActionMenuElement_abortController, _ActionMenuElement_originalLabel, _ActionMenuElement_inputName, _ActionMenuElement_setDynamicLabel, _ActionMenuElement_updateInput, _ActionMenuElement_isEnterKeydown, _ActionMenuElement_firstItem_get;
 import '@github/include-fragment-element';
-const popoverSelector = (() => {
-    try {
-        document.querySelector(':open');
-        return ':open';
-    }
-    catch (_a) {
-        return '.\\:open';
-    }
-})();
 const menuItemSelectors = ['[role="menuitem"]', '[role="menuitemcheckbox"]', '[role="menuitemradio"]'];
 export class ActionMenuElement extends HTMLElement {
     constructor() {
@@ -109,7 +100,7 @@ export class ActionMenuElement extends HTMLElement {
                 return;
             }
         }
-        if (!((_b = this.popoverElement) === null || _b === void 0 ? void 0 : _b.matches(popoverSelector)))
+        if (!((_b = this.popoverElement) === null || _b === void 0 ? void 0 : _b.matches(':popover-open')))
             return;
         if (event.type === 'focusout' && !this.contains(event.relatedTarget)) {
             (_c = this.popoverElement) === null || _c === void 0 ? void 0 : _c.hidePopover();

package/app/components/primer/alpha/modal_dialog.js

@@ -31,6 +31,10 @@ function clickHandler(event) {
         if (dialog instanceof ModalDialogElement) {
             dialog.openButton = button;
             dialog.show();
+            // A buttons default behaviour in some browsers it to send a pointer event
+            // If the behaviour is allowed through the dialog will be shown but then
+            // quickly hidden- as if it were never shown. This prevents that.
+            event.preventDefault();
             return;
         }
     }

package/app/components/primer/focus_group.js

@@ -12,15 +12,6 @@ var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (
 var _FocusGroupElement_instances, _FocusGroupElement_abortController, _FocusGroupElement_items_get;
 import '@oddbird/popover-polyfill';
 const menuItemSelector = '[role="menuitem"],[role="menuitemcheckbox"],[role="menuitemradio"]';
-const popoverSelector = (() => {
-    try {
-        document.querySelector(':open');
-        return ':open';
-    }
-    catch (_a) {
-        return '.\\:open';
-    }
-})();
 const getMnemonicFor = (item) => { var _a; return (_a = item.textContent) === null || _a === void 0 ? void 0 : _a.trim()[0].toLowerCase(); };
 const printable = /^\S$/;
 export default class FocusGroupElement extends HTMLElement {
@@ -128,13 +119,11 @@ export default class FocusGroupElement extends HTMLElement {
             {
                 let el = focusEl;
                 do {
-                    el = el.closest(`[popover]:not(${popoverSelector})`);
+                    el = el.closest(`[popover]:not(:popover-open)`);
                     if ((el === null || el === void 0 ? void 0 : el.popover) === 'auto') {
                         el.showPopover();
                     }
-                    else {
-                        el = (el === null || el === void 0 ? void 0 : el.parentElement) || null;
-                    }
+                    el = (el === null || el === void 0 ? void 0 : el.parentElement) || null;
                 } while (el);
             }
             focusEl === null || focusEl === void 0 ? void 0 : focusEl.focus();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@primer/view-components",
-  "version": "0.1.9-rc.ed6f20bc",
+  "version": "0.1.10-rc.fdc6a7e6",
   "description": "ViewComponents for the Primer Design System",
   "main": "app/assets/javascripts/primer_view_components.js",
   "module": "app/components/primer/primer.js",
@@ -54,8 +54,8 @@
     "@github/mini-throttle": "^2.1.0",
     "@github/relative-time-element": "^4.0.0",
     "@github/tab-container-element": "^3.1.2",
-    "@oddbird/popover-polyfill": "^0.1.1",
-    "@primer/behaviors": "^1.2.0"
+    "@oddbird/popover-polyfill": "^0.2.0",
+    "@primer/behaviors": "^1.3.4"
   },
   "devDependencies": {
     "@changesets/changelog-github": "^0.4.6",