@primer/stylelint-config 13.0.1-rc.5358628 → 13.0.1-rc.6de0604

package/dist/index.cjs

@@ -292,7 +292,7 @@ for (const variable of variables$2) {
 }
 
 /** @type {import('stylelint').Rule} */
-const ruleFunction$3 = (primary, secondaryOptions, context) => {
+const ruleFunction$3 = primary => {
   return (root, result) => {
     const validOptions = validateOptions$3(result, ruleName$5, {
       actual: primary,
@@ -308,8 +308,6 @@ const ruleFunction$3 = (primary, secondaryOptions, context) => {
       if (/^border(-(top|right|bottom|left|block-start|block-end|inline-start|inline-end))?-color$/.test(prop)) return
       if (valueList$1.some(valueToIgnore => value.includes(valueToIgnore))) return
 
-      const problems = [];
-
       const parsedValue = walkGroups$1(valueParser(value), node => {
         const checkForVariable = (vars, nodeValue) =>
           vars.some(variable =>
@@ -387,36 +385,26 @@ const ruleFunction$3 = (primary, secondaryOptions, context) => {
           variable.values.includes(node.value.replace('-', '')),
         );
         const fixable = replacement && valueUnit && !valueUnit.number.includes('-');
-
-        if (fixable && context.fix) {
-          node.value = node.value.replace(node.value, `var(${replacement['name']})`);
-        } else {
-          problems.push({
-            index: declarationValueIndex(declNode) + node.sourceIndex,
-            endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
-            message: messages$5.rejected(node.value, replacement, prop),
-          });
+        let fix = undefined;
+        if (fixable) {
+          fix = () => {
+            node.value = node.value.replace(node.value, `var(${replacement['name']})`);
+          };
         }
+        report$3({
+          index: declarationValueIndex(declNode) + node.sourceIndex,
+          endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
+          message: messages$5.rejected(node.value, replacement, prop),
+          node: declNode,
+          result,
+          ruleName: ruleName$5,
+          fix,
+        });
 
         return
       });
 
-      if (context.fix) {
-        declNode.value = parsedValue.toString();
-      }
-
-      if (problems.length) {
-        for (const err of problems) {
-          report$3({
-            index: err.index,
-            endIndex: err.endIndex,
-            message: err.message,
-            node: declNode,
-            result,
-            ruleName: ruleName$5,
-          });
-        }
-      }
+      declNode.value = parsedValue.toString();
     });
   }
 };
@@ -459,7 +447,7 @@ for (const variable of variables$1) {
 }
 
 /** @type {import('stylelint').Rule} */
-const ruleFunction$2 = (primary, secondaryOptions, context) => {
+const ruleFunction$2 = primary => {
   return (root, result) => {
     const validOptions = validateOptions$2(result, ruleName$4, {
       actual: primary,
@@ -476,8 +464,6 @@ const ruleFunction$2 = (primary, secondaryOptions, context) => {
 
       if (value === 'none') return
 
-      const problems = [];
-
       const checkForVariable = (vars, nodeValue) => {
         return vars.some(variable =>
           new RegExp(`${variable['name'].replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\b`).test(nodeValue),
@@ -489,29 +475,22 @@ const ruleFunction$2 = (primary, secondaryOptions, context) => {
       }
 
       const replacement = validValues.find(variable => variable.values.includes(value));
-
-      if (replacement && context.fix) {
-        declNode.value = value.replace(value, `var(${replacement['name']})`);
-      } else {
-        problems.push({
-          index: declarationValueIndex(declNode),
-          endIndex: declarationValueIndex(declNode) + value.length,
-          message: messages$4.rejected(value, replacement),
-        });
+      let fix = undefined;
+      if (replacement) {
+        fix = () => {
+          declNode.value = value.replace(value, `var(${replacement['name']})`);
+        };
       }
 
-      if (problems.length) {
-        for (const err of problems) {
-          report$2({
-            index: err.index,
-            endIndex: err.endIndex,
-            message: err.message,
-            node: declNode,
-            result,
-            ruleName: ruleName$4,
-          });
-        }
-      }
+      report$2({
+        index: declarationValueIndex(declNode),
+        endIndex: declarationValueIndex(declNode) + value.length,
+        message: messages$4.rejected(value, replacement),
+        node: declNode,
+        result,
+        ruleName: ruleName$4,
+        fix,
+      });
     });
   }
 };
@@ -783,7 +762,7 @@ function createVariableRule(ruleName, rules, url) {
 
     // The stylelint docs suggest respecting a "disableFix" rule option that
     // overrides the "global" context.fix (--fix) linting option.
-    const {verbose = false, disableFix} = options;
+    const {disableFix} = options;
     const fixEnabled = context && context.fix && !disableFix;
     const seen = new WeakMap();
 
@@ -799,16 +778,10 @@ function createVariableRule(ruleName, rules, url) {
           const validated = validate(decl);
           const {valid, fixable, replacement, errors} = validated;
           if (valid) {
-            // eslint-disable-next-line no-console
-            if (verbose) console.warn(`valid: "${decl.toString()}" in: "${rule.selector}"`);
             return
           } else if (fixEnabled && fixable) {
-            // eslint-disable-next-line no-console
-            if (verbose) console.warn(`  fixed: ${replacement}`);
             decl.value = replacement;
           } else {
-            // eslint-disable-next-line no-console
-            if (verbose) console.warn(`  ${errors.length} error(s)`);
             for (const error of errors) {
               const message = stylelint.utils
                 .ruleMessages(ruleName, {
@@ -1008,7 +981,7 @@ for (const size of sizes) {
 }
 
 /** @type {import('stylelint').Rule} */
-const ruleFunction$1 = (primary, secondaryOptions, context) => {
+const ruleFunction$1 = primary => {
   return (root, result) => {
     const validOptions = validateOptions$1(result, ruleName$2, {
       actual: primary,
@@ -1023,8 +996,6 @@ const ruleFunction$1 = (primary, secondaryOptions, context) => {
       if (!propList$1.some(spacingProp => prop.startsWith(spacingProp))) return
       if (valueList.some(valueToIgnore => value.includes(valueToIgnore))) return
 
-      const problems = [];
-
       const parsedValue = walkGroups$1(valueParser(value), node => {
         // Only check word types. https://github.com/TrySound/postcss-value-parser#word
         if (node.type !== 'word') {
@@ -1058,36 +1029,24 @@ const ruleFunction$1 = (primary, secondaryOptions, context) => {
 
         const replacement = sizes.find(variable => variable.values.includes(node.value.replace('-', '')));
         const fixable = replacement && valueUnit && !valueUnit.number.includes('-');
-
-        if (fixable && context.fix) {
-          node.value = node.value.replace(node.value, `var(${replacement['name']})`);
-        } else {
-          problems.push({
-            index: declarationValueIndex(declNode) + node.sourceIndex,
-            endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
-            message: messages$2.rejected(node.value, replacement),
-          });
+        let fix = undefined;
+        if (fixable) {
+          fix = () => {
+            node.value = node.value.replace(node.value, `var(${replacement['name']})`);
+          };
         }
-
-        return
+        report$1({
+          index: declarationValueIndex(declNode) + node.sourceIndex,
+          endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
+          message: messages$2.rejected(node.value, replacement),
+          node: declNode,
+          result,
+          ruleName: ruleName$2,
+          fix,
+        });
       });
 
-      if (context.fix) {
-        declNode.value = parsedValue.toString();
-      }
-
-      if (problems.length) {
-        for (const err of problems) {
-          report$1({
-            index: err.index,
-            endIndex: err.endIndex,
-            message: err.message,
-            node: declNode,
-            result,
-            ruleName: ruleName$2,
-          });
-        }
-      }
+      declNode.value = parsedValue.toString();
     });
   }
 };
@@ -1185,8 +1144,6 @@ const ruleFunction = primary => {
 
       if (!propList.some(typographyProp => prop === typographyProp)) return
 
-      const problems = [];
-
       const checkForVariable = (vars, nodeValue) =>
         vars.some(variable =>
           new RegExp(`${variable['name'].replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\b`).test(nodeValue),
@@ -1244,34 +1201,22 @@ const ruleFunction = primary => {
       };
       const replacement = getReplacements();
       const fixable = replacement && !replacement.length;
-      let fixedValue = '';
+      let fix = undefined;
       if (fixable) {
-        fixedValue = value.replace(value, `var(${replacement['name']})`);
+        fix = () => {
+          declNode.value = value.replace(value, `var(${replacement['name']})`);
+        };
       }
 
-      problems.push({
+      report({
         index: declarationValueIndex(declNode),
         endIndex: declarationValueIndex(declNode) + value.length,
         message: messages$1.rejected(value, replacement, prop),
-        fix: () => {
-          if (!fixable) return
-          declNode.value = fixedValue;
-        },
+        node: declNode,
+        result,
+        ruleName: ruleName$1,
+        fix,
       });
-
-      if (problems.length) {
-        for (const err of problems) {
-          report({
-            index: err.index,
-            endIndex: err.endIndex,
-            message: err.message,
-            node: declNode,
-            result,
-            ruleName: ruleName$1,
-            fix: err.fix,
-          });
-        }
-      }
     });
   }
 };

package/dist/index.mjs

@@ -289,7 +289,7 @@ for (const variable of variables$2) {
 }
 
 /** @type {import('stylelint').Rule} */
-const ruleFunction$3 = (primary, secondaryOptions, context) => {
+const ruleFunction$3 = primary => {
   return (root, result) => {
     const validOptions = validateOptions$3(result, ruleName$5, {
       actual: primary,
@@ -305,8 +305,6 @@ const ruleFunction$3 = (primary, secondaryOptions, context) => {
       if (/^border(-(top|right|bottom|left|block-start|block-end|inline-start|inline-end))?-color$/.test(prop)) return
       if (valueList$1.some(valueToIgnore => value.includes(valueToIgnore))) return
 
-      const problems = [];
-
       const parsedValue = walkGroups$1(valueParser(value), node => {
         const checkForVariable = (vars, nodeValue) =>
           vars.some(variable =>
@@ -384,36 +382,26 @@ const ruleFunction$3 = (primary, secondaryOptions, context) => {
           variable.values.includes(node.value.replace('-', '')),
         );
         const fixable = replacement && valueUnit && !valueUnit.number.includes('-');
-
-        if (fixable && context.fix) {
-          node.value = node.value.replace(node.value, `var(${replacement['name']})`);
-        } else {
-          problems.push({
-            index: declarationValueIndex(declNode) + node.sourceIndex,
-            endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
-            message: messages$5.rejected(node.value, replacement, prop),
-          });
+        let fix = undefined;
+        if (fixable) {
+          fix = () => {
+            node.value = node.value.replace(node.value, `var(${replacement['name']})`);
+          };
         }
+        report$3({
+          index: declarationValueIndex(declNode) + node.sourceIndex,
+          endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
+          message: messages$5.rejected(node.value, replacement, prop),
+          node: declNode,
+          result,
+          ruleName: ruleName$5,
+          fix,
+        });
 
         return
       });
 
-      if (context.fix) {
-        declNode.value = parsedValue.toString();
-      }
-
-      if (problems.length) {
-        for (const err of problems) {
-          report$3({
-            index: err.index,
-            endIndex: err.endIndex,
-            message: err.message,
-            node: declNode,
-            result,
-            ruleName: ruleName$5,
-          });
-        }
-      }
+      declNode.value = parsedValue.toString();
     });
   }
 };
@@ -456,7 +444,7 @@ for (const variable of variables$1) {
 }
 
 /** @type {import('stylelint').Rule} */
-const ruleFunction$2 = (primary, secondaryOptions, context) => {
+const ruleFunction$2 = primary => {
   return (root, result) => {
     const validOptions = validateOptions$2(result, ruleName$4, {
       actual: primary,
@@ -473,8 +461,6 @@ const ruleFunction$2 = (primary, secondaryOptions, context) => {
 
       if (value === 'none') return
 
-      const problems = [];
-
       const checkForVariable = (vars, nodeValue) => {
         return vars.some(variable =>
           new RegExp(`${variable['name'].replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\b`).test(nodeValue),
@@ -486,29 +472,22 @@ const ruleFunction$2 = (primary, secondaryOptions, context) => {
       }
 
       const replacement = validValues.find(variable => variable.values.includes(value));
-
-      if (replacement && context.fix) {
-        declNode.value = value.replace(value, `var(${replacement['name']})`);
-      } else {
-        problems.push({
-          index: declarationValueIndex(declNode),
-          endIndex: declarationValueIndex(declNode) + value.length,
-          message: messages$4.rejected(value, replacement),
-        });
+      let fix = undefined;
+      if (replacement) {
+        fix = () => {
+          declNode.value = value.replace(value, `var(${replacement['name']})`);
+        };
       }
 
-      if (problems.length) {
-        for (const err of problems) {
-          report$2({
-            index: err.index,
-            endIndex: err.endIndex,
-            message: err.message,
-            node: declNode,
-            result,
-            ruleName: ruleName$4,
-          });
-        }
-      }
+      report$2({
+        index: declarationValueIndex(declNode),
+        endIndex: declarationValueIndex(declNode) + value.length,
+        message: messages$4.rejected(value, replacement),
+        node: declNode,
+        result,
+        ruleName: ruleName$4,
+        fix,
+      });
     });
   }
 };
@@ -780,7 +759,7 @@ function createVariableRule(ruleName, rules, url) {
 
     // The stylelint docs suggest respecting a "disableFix" rule option that
     // overrides the "global" context.fix (--fix) linting option.
-    const {verbose = false, disableFix} = options;
+    const {disableFix} = options;
     const fixEnabled = context && context.fix && !disableFix;
     const seen = new WeakMap();
 
@@ -796,16 +775,10 @@ function createVariableRule(ruleName, rules, url) {
           const validated = validate(decl);
           const {valid, fixable, replacement, errors} = validated;
           if (valid) {
-            // eslint-disable-next-line no-console
-            if (verbose) console.warn(`valid: "${decl.toString()}" in: "${rule.selector}"`);
             return
           } else if (fixEnabled && fixable) {
-            // eslint-disable-next-line no-console
-            if (verbose) console.warn(`  fixed: ${replacement}`);
             decl.value = replacement;
           } else {
-            // eslint-disable-next-line no-console
-            if (verbose) console.warn(`  ${errors.length} error(s)`);
             for (const error of errors) {
               const message = stylelint.utils
                 .ruleMessages(ruleName, {
@@ -1005,7 +978,7 @@ for (const size of sizes) {
 }
 
 /** @type {import('stylelint').Rule} */
-const ruleFunction$1 = (primary, secondaryOptions, context) => {
+const ruleFunction$1 = primary => {
   return (root, result) => {
     const validOptions = validateOptions$1(result, ruleName$2, {
       actual: primary,
@@ -1020,8 +993,6 @@ const ruleFunction$1 = (primary, secondaryOptions, context) => {
       if (!propList$1.some(spacingProp => prop.startsWith(spacingProp))) return
       if (valueList.some(valueToIgnore => value.includes(valueToIgnore))) return
 
-      const problems = [];
-
       const parsedValue = walkGroups$1(valueParser(value), node => {
         // Only check word types. https://github.com/TrySound/postcss-value-parser#word
         if (node.type !== 'word') {
@@ -1055,36 +1026,24 @@ const ruleFunction$1 = (primary, secondaryOptions, context) => {
 
         const replacement = sizes.find(variable => variable.values.includes(node.value.replace('-', '')));
         const fixable = replacement && valueUnit && !valueUnit.number.includes('-');
-
-        if (fixable && context.fix) {
-          node.value = node.value.replace(node.value, `var(${replacement['name']})`);
-        } else {
-          problems.push({
-            index: declarationValueIndex(declNode) + node.sourceIndex,
-            endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
-            message: messages$2.rejected(node.value, replacement),
-          });
+        let fix = undefined;
+        if (fixable) {
+          fix = () => {
+            node.value = node.value.replace(node.value, `var(${replacement['name']})`);
+          };
         }
-
-        return
+        report$1({
+          index: declarationValueIndex(declNode) + node.sourceIndex,
+          endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
+          message: messages$2.rejected(node.value, replacement),
+          node: declNode,
+          result,
+          ruleName: ruleName$2,
+          fix,
+        });
       });
 
-      if (context.fix) {
-        declNode.value = parsedValue.toString();
-      }
-
-      if (problems.length) {
-        for (const err of problems) {
-          report$1({
-            index: err.index,
-            endIndex: err.endIndex,
-            message: err.message,
-            node: declNode,
-            result,
-            ruleName: ruleName$2,
-          });
-        }
-      }
+      declNode.value = parsedValue.toString();
     });
   }
 };
@@ -1182,8 +1141,6 @@ const ruleFunction = primary => {
 
       if (!propList.some(typographyProp => prop === typographyProp)) return
 
-      const problems = [];
-
       const checkForVariable = (vars, nodeValue) =>
         vars.some(variable =>
           new RegExp(`${variable['name'].replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\b`).test(nodeValue),
@@ -1241,34 +1198,22 @@ const ruleFunction = primary => {
       };
       const replacement = getReplacements();
       const fixable = replacement && !replacement.length;
-      let fixedValue = '';
+      let fix = undefined;
       if (fixable) {
-        fixedValue = value.replace(value, `var(${replacement['name']})`);
+        fix = () => {
+          declNode.value = value.replace(value, `var(${replacement['name']})`);
+        };
       }
 
-      problems.push({
+      report({
         index: declarationValueIndex(declNode),
         endIndex: declarationValueIndex(declNode) + value.length,
         message: messages$1.rejected(value, replacement, prop),
-        fix: () => {
-          if (!fixable) return
-          declNode.value = fixedValue;
-        },
+        node: declNode,
+        result,
+        ruleName: ruleName$1,
+        fix,
       });
-
-      if (problems.length) {
-        for (const err of problems) {
-          report({
-            index: err.index,
-            endIndex: err.endIndex,
-            message: err.message,
-            node: declNode,
-            result,
-            ruleName: ruleName$1,
-            fix: err.fix,
-          });
-        }
-      }
     });
   }
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@primer/stylelint-config",
-  "version": "13.0.1-rc.5358628",
+  "version": "13.0.1-rc.6de0604",
   "description": "Sharable stylelint config used by GitHub's CSS",
   "author": "GitHub, Inc.",
   "license": "MIT",

package/plugins/borders.js

@@ -59,7 +59,7 @@ for (const variable of variables) {
 }
 
 /** @type {import('stylelint').Rule} */
-const ruleFunction = (primary, secondaryOptions, context) => {
+const ruleFunction = primary => {
   return (root, result) => {
     const validOptions = validateOptions(result, ruleName, {
       actual: primary,
@@ -75,8 +75,6 @@ const ruleFunction = (primary, secondaryOptions, context) => {
       if (/^border(-(top|right|bottom|left|block-start|block-end|inline-start|inline-end))?-color$/.test(prop)) return
       if (valueList.some(valueToIgnore => value.includes(valueToIgnore))) return
 
-      const problems = []
-
       const parsedValue = walkGroups(valueParser(value), node => {
         const checkForVariable = (vars, nodeValue) =>
           vars.some(variable =>
@@ -154,36 +152,26 @@ const ruleFunction = (primary, secondaryOptions, context) => {
           variable.values.includes(node.value.replace('-', '')),
         )
         const fixable = replacement && valueUnit && !valueUnit.number.includes('-')
-
-        if (fixable && context.fix) {
-          node.value = node.value.replace(node.value, `var(${replacement['name']})`)
-        } else {
-          problems.push({
-            index: declarationValueIndex(declNode) + node.sourceIndex,
-            endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
-            message: messages.rejected(node.value, replacement, prop),
-          })
+        let fix = undefined
+        if (fixable) {
+          fix = () => {
+            node.value = node.value.replace(node.value, `var(${replacement['name']})`)
+          }
         }
+        report({
+          index: declarationValueIndex(declNode) + node.sourceIndex,
+          endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
+          message: messages.rejected(node.value, replacement, prop),
+          node: declNode,
+          result,
+          ruleName,
+          fix,
+        })
 
         return
       })
 
-      if (context.fix) {
-        declNode.value = parsedValue.toString()
-      }
-
-      if (problems.length) {
-        for (const err of problems) {
-          report({
-            index: err.index,
-            endIndex: err.endIndex,
-            message: err.message,
-            node: declNode,
-            result,
-            ruleName,
-          })
-        }
-      }
+      declNode.value = parsedValue.toString()
     })
   }
 }

package/plugins/box-shadow.js

@@ -32,7 +32,7 @@ for (const variable of variables) {
 }
 
 /** @type {import('stylelint').Rule} */
-const ruleFunction = (primary, secondaryOptions, context) => {
+const ruleFunction = primary => {
   return (root, result) => {
     const validOptions = validateOptions(result, ruleName, {
       actual: primary,
@@ -49,8 +49,6 @@ const ruleFunction = (primary, secondaryOptions, context) => {
 
       if (value === 'none') return
 
-      const problems = []
-
       const checkForVariable = (vars, nodeValue) => {
         return vars.some(variable =>
           new RegExp(`${variable['name'].replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\b`).test(nodeValue),
@@ -62,29 +60,22 @@ const ruleFunction = (primary, secondaryOptions, context) => {
       }
 
       const replacement = validValues.find(variable => variable.values.includes(value))
-
-      if (replacement && context.fix) {
-        declNode.value = value.replace(value, `var(${replacement['name']})`)
-      } else {
-        problems.push({
-          index: declarationValueIndex(declNode),
-          endIndex: declarationValueIndex(declNode) + value.length,
-          message: messages.rejected(value, replacement),
-        })
-      }
-
-      if (problems.length) {
-        for (const err of problems) {
-          report({
-            index: err.index,
-            endIndex: err.endIndex,
-            message: err.message,
-            node: declNode,
-            result,
-            ruleName,
-          })
+      let fix = undefined
+      if (replacement) {
+        fix = () => {
+          declNode.value = value.replace(value, `var(${replacement['name']})`)
         }
       }
+
+      report({
+        index: declarationValueIndex(declNode),
+        endIndex: declarationValueIndex(declNode) + value.length,
+        message: messages.rejected(value, replacement),
+        node: declNode,
+        result,
+        ruleName,
+        fix,
+      })
     })
   }
 }

package/plugins/lib/variable-rules.js

@@ -30,7 +30,7 @@ export function createVariableRule(ruleName, rules, url) {
 
     // The stylelint docs suggest respecting a "disableFix" rule option that
     // overrides the "global" context.fix (--fix) linting option.
-    const {verbose = false, disableFix} = options
+    const {disableFix} = options
     const fixEnabled = context && context.fix && !disableFix
     const seen = new WeakMap()
 
@@ -46,16 +46,10 @@ export function createVariableRule(ruleName, rules, url) {
           const validated = validate(decl)
           const {valid, fixable, replacement, errors} = validated
           if (valid) {
-            // eslint-disable-next-line no-console
-            if (verbose) console.warn(`valid: "${decl.toString()}" in: "${rule.selector}"`)
             return
           } else if (fixEnabled && fixable) {
-            // eslint-disable-next-line no-console
-            if (verbose) console.warn(`  fixed: ${replacement}`)
             decl.value = replacement
           } else {
-            // eslint-disable-next-line no-console
-            if (verbose) console.warn(`  ${errors.length} error(s)`)
             for (const error of errors) {
               const message = stylelint.utils
                 .ruleMessages(ruleName, {

package/plugins/spacing.js

@@ -37,7 +37,7 @@ for (const size of sizes) {
 }
 
 /** @type {import('stylelint').Rule} */
-const ruleFunction = (primary, secondaryOptions, context) => {
+const ruleFunction = primary => {
   return (root, result) => {
     const validOptions = validateOptions(result, ruleName, {
       actual: primary,
@@ -52,8 +52,6 @@ const ruleFunction = (primary, secondaryOptions, context) => {
       if (!propList.some(spacingProp => prop.startsWith(spacingProp))) return
       if (valueList.some(valueToIgnore => value.includes(valueToIgnore))) return
 
-      const problems = []
-
       const parsedValue = walkGroups(valueParser(value), node => {
         // Only check word types. https://github.com/TrySound/postcss-value-parser#word
         if (node.type !== 'word') {
@@ -87,36 +85,24 @@ const ruleFunction = (primary, secondaryOptions, context) => {
 
         const replacement = sizes.find(variable => variable.values.includes(node.value.replace('-', '')))
         const fixable = replacement && valueUnit && !valueUnit.number.includes('-')
-
-        if (fixable && context.fix) {
-          node.value = node.value.replace(node.value, `var(${replacement['name']})`)
-        } else {
-          problems.push({
-            index: declarationValueIndex(declNode) + node.sourceIndex,
-            endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
-            message: messages.rejected(node.value, replacement),
-          })
+        let fix = undefined
+        if (fixable) {
+          fix = () => {
+            node.value = node.value.replace(node.value, `var(${replacement['name']})`)
+          }
         }
-
-        return
+        report({
+          index: declarationValueIndex(declNode) + node.sourceIndex,
+          endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
+          message: messages.rejected(node.value, replacement),
+          node: declNode,
+          result,
+          ruleName,
+          fix,
+        })
       })
 
-      if (context.fix) {
-        declNode.value = parsedValue.toString()
-      }
-
-      if (problems.length) {
-        for (const err of problems) {
-          report({
-            index: err.index,
-            endIndex: err.endIndex,
-            message: err.message,
-            node: declNode,
-            result,
-            ruleName,
-          })
-        }
-      }
+      declNode.value = parsedValue.toString()
     })
   }
 }

package/plugins/typography.js

@@ -87,8 +87,6 @@ const ruleFunction = primary => {
 
       if (!propList.some(typographyProp => prop === typographyProp)) return
 
-      const problems = []
-
       const checkForVariable = (vars, nodeValue) =>
         vars.some(variable =>
           new RegExp(`${variable['name'].replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\b`).test(nodeValue),
@@ -146,34 +144,22 @@ const ruleFunction = primary => {
       }
       const replacement = getReplacements()
       const fixable = replacement && !replacement.length
-      let fixedValue = ''
+      let fix = undefined
       if (fixable) {
-        fixedValue = value.replace(value, `var(${replacement['name']})`)
+        fix = () => {
+          declNode.value = value.replace(value, `var(${replacement['name']})`)
+        }
       }
 
-      problems.push({
+      report({
         index: declarationValueIndex(declNode),
         endIndex: declarationValueIndex(declNode) + value.length,
         message: messages.rejected(value, replacement, prop),
-        fix: () => {
-          if (!fixable) return
-          declNode.value = fixedValue
-        },
+        node: declNode,
+        result,
+        ruleName,
+        fix,
       })
-
-      if (problems.length) {
-        for (const err of problems) {
-          report({
-            index: err.index,
-            endIndex: err.endIndex,
-            message: err.message,
-            node: declNode,
-            result,
-            ruleName,
-            fix: err.fix,
-          })
-        }
-      }
     })
   }
 }