@primer/stylelint-config 13.0.0 → 13.0.1-rc.5358628

package/dist/index.cjs

@@ -1125,7 +1125,7 @@ const messages$1 = ruleMessages(ruleName$1, {
 
 const fontWeightKeywordMap = {
   normal: 400,
-  bold: 600,
+  bold: 700,
   bolder: 600,
   lighter: 300,
 };
@@ -1170,7 +1170,7 @@ for (const variable of variables) {
 }
 
 /** @type {import('stylelint').Rule} */
-const ruleFunction = (primary, secondaryOptions, context) => {
+const ruleFunction = primary => {
   return (root, result) => {
     const validOptions = validateOptions(result, ruleName$1, {
       actual: primary,
@@ -1183,7 +1183,7 @@ const ruleFunction = (primary, secondaryOptions, context) => {
     root.walkDecls(declNode => {
       const {prop, value} = declNode;
 
-      if (!propList.some(typographyProp => prop.startsWith(typographyProp))) return
+      if (!propList.some(typographyProp => prop === typographyProp)) return
 
       const problems = [];
 
@@ -1240,25 +1240,25 @@ const ruleFunction = (primary, secondaryOptions, context) => {
           return
         }
 
-        if (replacementTokens.length > 1) {
-          return replacementTokens
-        }
-
         return replacementTokens[0]
       };
       const replacement = getReplacements();
       const fixable = replacement && !replacement.length;
-
-      if (fixable && context.fix) {
-        declNode.value = value.replace(value, `var(${replacement['name']})`);
-      } else {
-        problems.push({
-          index: declarationValueIndex(declNode),
-          endIndex: declarationValueIndex(declNode) + value.length,
-          message: messages$1.rejected(value, replacement, prop),
-        });
+      let fixedValue = '';
+      if (fixable) {
+        fixedValue = value.replace(value, `var(${replacement['name']})`);
       }
 
+      problems.push({
+        index: declarationValueIndex(declNode),
+        endIndex: declarationValueIndex(declNode) + value.length,
+        message: messages$1.rejected(value, replacement, prop),
+        fix: () => {
+          if (!fixable) return
+          declNode.value = fixedValue;
+        },
+      });
+
       if (problems.length) {
         for (const err of problems) {
           report({
@@ -1268,6 +1268,7 @@ const ruleFunction = (primary, secondaryOptions, context) => {
             node: declNode,
             result,
             ruleName: ruleName$1,
+            fix: err.fix,
           });
         }
       }
@@ -1385,7 +1386,6 @@ var index = {
     'declaration-property-value-disallowed-list': {
       '/^transition/': ['/all/'],
       '/^background/': ['http:', 'https:'],
-      '/^border/': ['none'],
       '/.+/': ['initial'],
     },
     'function-calc-no-unspaced-operator': true,

package/dist/index.mjs

@@ -1122,7 +1122,7 @@ const messages$1 = ruleMessages(ruleName$1, {
 
 const fontWeightKeywordMap = {
   normal: 400,
-  bold: 600,
+  bold: 700,
   bolder: 600,
   lighter: 300,
 };
@@ -1167,7 +1167,7 @@ for (const variable of variables) {
 }
 
 /** @type {import('stylelint').Rule} */
-const ruleFunction = (primary, secondaryOptions, context) => {
+const ruleFunction = primary => {
   return (root, result) => {
     const validOptions = validateOptions(result, ruleName$1, {
       actual: primary,
@@ -1180,7 +1180,7 @@ const ruleFunction = (primary, secondaryOptions, context) => {
     root.walkDecls(declNode => {
       const {prop, value} = declNode;
 
-      if (!propList.some(typographyProp => prop.startsWith(typographyProp))) return
+      if (!propList.some(typographyProp => prop === typographyProp)) return
 
       const problems = [];
 
@@ -1237,25 +1237,25 @@ const ruleFunction = (primary, secondaryOptions, context) => {
           return
         }
 
-        if (replacementTokens.length > 1) {
-          return replacementTokens
-        }
-
         return replacementTokens[0]
       };
       const replacement = getReplacements();
       const fixable = replacement && !replacement.length;
-
-      if (fixable && context.fix) {
-        declNode.value = value.replace(value, `var(${replacement['name']})`);
-      } else {
-        problems.push({
-          index: declarationValueIndex(declNode),
-          endIndex: declarationValueIndex(declNode) + value.length,
-          message: messages$1.rejected(value, replacement, prop),
-        });
+      let fixedValue = '';
+      if (fixable) {
+        fixedValue = value.replace(value, `var(${replacement['name']})`);
       }
 
+      problems.push({
+        index: declarationValueIndex(declNode),
+        endIndex: declarationValueIndex(declNode) + value.length,
+        message: messages$1.rejected(value, replacement, prop),
+        fix: () => {
+          if (!fixable) return
+          declNode.value = fixedValue;
+        },
+      });
+
       if (problems.length) {
         for (const err of problems) {
           report({
@@ -1265,6 +1265,7 @@ const ruleFunction = (primary, secondaryOptions, context) => {
             node: declNode,
             result,
             ruleName: ruleName$1,
+            fix: err.fix,
           });
         }
       }
@@ -1382,7 +1383,6 @@ var index = {
     'declaration-property-value-disallowed-list': {
       '/^transition/': ['/all/'],
       '/^background/': ['http:', 'https:'],
-      '/^border/': ['none'],
       '/.+/': ['initial'],
     },
     'function-calc-no-unspaced-operator': true,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@primer/stylelint-config",
-  "version": "13.0.0",
+  "version": "13.0.1-rc.5358628",
   "description": "Sharable stylelint config used by GitHub's CSS",
   "author": "GitHub, Inc.",
   "license": "MIT",

package/plugins/typography.js

@@ -27,7 +27,7 @@ export const messages = ruleMessages(ruleName, {
 
 const fontWeightKeywordMap = {
   normal: 400,
-  bold: 600,
+  bold: 700,
   bolder: 600,
   lighter: 300,
 }
@@ -72,7 +72,7 @@ for (const variable of variables) {
 }
 
 /** @type {import('stylelint').Rule} */
-const ruleFunction = (primary, secondaryOptions, context) => {
+const ruleFunction = primary => {
   return (root, result) => {
     const validOptions = validateOptions(result, ruleName, {
       actual: primary,
@@ -85,7 +85,7 @@ const ruleFunction = (primary, secondaryOptions, context) => {
     root.walkDecls(declNode => {
       const {prop, value} = declNode
 
-      if (!propList.some(typographyProp => prop.startsWith(typographyProp))) return
+      if (!propList.some(typographyProp => prop === typographyProp)) return
 
       const problems = []
 
@@ -142,25 +142,25 @@ const ruleFunction = (primary, secondaryOptions, context) => {
           return
         }
 
-        if (replacementTokens.length > 1) {
-          return replacementTokens
-        }
-
         return replacementTokens[0]
       }
       const replacement = getReplacements()
       const fixable = replacement && !replacement.length
-
-      if (fixable && context.fix) {
-        declNode.value = value.replace(value, `var(${replacement['name']})`)
-      } else {
-        problems.push({
-          index: declarationValueIndex(declNode),
-          endIndex: declarationValueIndex(declNode) + value.length,
-          message: messages.rejected(value, replacement, prop),
-        })
+      let fixedValue = ''
+      if (fixable) {
+        fixedValue = value.replace(value, `var(${replacement['name']})`)
       }
 
+      problems.push({
+        index: declarationValueIndex(declNode),
+        endIndex: declarationValueIndex(declNode) + value.length,
+        message: messages.rejected(value, replacement, prop),
+        fix: () => {
+          if (!fixable) return
+          declNode.value = fixedValue
+        },
+      })
+
       if (problems.length) {
         for (const err of problems) {
           report({
@@ -170,6 +170,7 @@ const ruleFunction = (primary, secondaryOptions, context) => {
             node: declNode,
             result,
             ruleName,
+            fix: err.fix,
           })
         }
       }