@primer/stylelint-config 13.0.0-rc.fe9ab86 → 13.0.0

package/dist/index.mjs

@@ -5,7 +5,7 @@ import valueParser from 'postcss-value-parser';
 import { createRequire } from 'node:module';
 import anymatch from 'anymatch';
 import TapMap from 'tap-map';
-import variables$1 from '@primer/css/dist/variables.json' assert { type: 'json' };
+import variables$3 from '@primer/css/dist/variables.json' with { type: 'json' };
 import matchAll from 'string.prototype.matchall';
 
 var propertyOrder = [
@@ -194,6 +194,14 @@ function primitivesVariables(type) {
     case 'border':
       files.push('functional/size/border.json');
       break
+    case 'typography':
+      files.push('base/typography/typography.json');
+      files.push('functional/typography/typography.json');
+      break
+    case 'box-shadow':
+      files.push('functional/themes/light.json');
+      files.push('functional/size/border.json');
+      break
   }
 
   for (const file of files) {
@@ -226,12 +234,12 @@ function walkGroups$1(root, validate) {
 }
 
 const {
-  createPlugin: createPlugin$1,
-  utils: {report: report$1, ruleMessages: ruleMessages$1, validateOptions: validateOptions$1},
+  createPlugin: createPlugin$3,
+  utils: {report: report$3, ruleMessages: ruleMessages$3, validateOptions: validateOptions$3},
 } = stylelint;
 
-const ruleName$3 = 'primer/borders';
-const messages$3 = ruleMessages$1(ruleName$3, {
+const ruleName$5 = 'primer/borders';
+const messages$5 = ruleMessages$3(ruleName$5, {
   rejected: (value, replacement, propName) => {
     if (propName && propName.includes('radius') && value.includes('borderWidth')) {
       return `Border radius variables can not be used for border widths`
@@ -249,19 +257,19 @@ const messages$3 = ruleMessages$1(ruleName$3, {
   },
 });
 
-const variables = primitivesVariables('border');
+const variables$2 = primitivesVariables('border');
 const sizes$1 = [];
 const radii = [];
 
 // Props that we want to check
-const propList$1 = ['border', 'border-width', 'border-radius'];
+const propList$2 = ['border', 'border-width', 'border-radius'];
 // Values that we want to ignore
 const valueList$1 = ['${'];
 
 const borderShorthand = prop =>
   /^border(-(top|right|bottom|left|block-start|block-end|inline-start|inline-end))?$/.test(prop);
 
-for (const variable of variables) {
+for (const variable of variables$2) {
   const name = variable['name'];
 
   if (name.includes('borderWidth')) {
@@ -281,9 +289,9 @@ for (const variable of variables) {
 }
 
 /** @type {import('stylelint').Rule} */
-const ruleFunction$1 = (primary, secondaryOptions, context) => {
+const ruleFunction$3 = (primary, secondaryOptions, context) => {
   return (root, result) => {
-    const validOptions = validateOptions$1(result, ruleName$3, {
+    const validOptions = validateOptions$3(result, ruleName$5, {
       actual: primary,
       possible: [true],
     });
@@ -293,7 +301,7 @@ const ruleFunction$1 = (primary, secondaryOptions, context) => {
     root.walkDecls(declNode => {
       const {prop, value} = declNode;
 
-      if (!propList$1.some(borderProp => prop.startsWith(borderProp))) return
+      if (!propList$2.some(borderProp => prop.startsWith(borderProp))) return
       if (/^border(-(top|right|bottom|left|block-start|block-end|inline-start|inline-end))?-color$/.test(prop)) return
       if (valueList$1.some(valueToIgnore => value.includes(valueToIgnore))) return
 
@@ -383,7 +391,7 @@ const ruleFunction$1 = (primary, secondaryOptions, context) => {
           problems.push({
             index: declarationValueIndex(declNode) + node.sourceIndex,
             endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
-            message: messages$3.rejected(node.value, replacement, prop),
+            message: messages$5.rejected(node.value, replacement, prop),
           });
         }
 
@@ -396,13 +404,13 @@ const ruleFunction$1 = (primary, secondaryOptions, context) => {
 
       if (problems.length) {
         for (const err of problems) {
-          report$1({
+          report$3({
             index: err.index,
             endIndex: err.endIndex,
             message: err.message,
             node: declNode,
             result,
-            ruleName: ruleName$3,
+            ruleName: ruleName$5,
           });
         }
       }
@@ -410,13 +418,108 @@ const ruleFunction$1 = (primary, secondaryOptions, context) => {
   }
 };
 
-ruleFunction$1.ruleName = ruleName$3;
-ruleFunction$1.messages = messages$3;
-ruleFunction$1.meta = {
+ruleFunction$3.ruleName = ruleName$5;
+ruleFunction$3.messages = messages$5;
+ruleFunction$3.meta = {
+  fixable: true,
+};
+
+var borders = createPlugin$3(ruleName$5, ruleFunction$3);
+
+const {
+  createPlugin: createPlugin$2,
+  utils: {report: report$2, ruleMessages: ruleMessages$2, validateOptions: validateOptions$2},
+} = stylelint;
+
+const ruleName$4 = 'primer/box-shadow';
+const messages$4 = ruleMessages$2(ruleName$4, {
+  rejected: (value, replacement) => {
+    if (!replacement) {
+      return `Please use a Primer box-shadow variable instead of '${value}'. Consult the primer docs for a suitable replacement. https://primer.style/foundations/primitives/color#shadow or https://primer.style/foundations/primitives/size#border-size`
+    }
+
+    return `Please replace '${value}' with a Primer box-shadow variable '${replacement['name']}'. https://primer.style/foundations/primitives/color#shadow or https://primer.style/foundations/primitives/size#border-size`
+  },
+});
+
+const variables$1 = primitivesVariables('box-shadow');
+const shadows = [];
+
+for (const variable of variables$1) {
+  const name = variable['name'];
+
+  // TODO: Decide if this is safe. Someday we might have variables that
+  // have 'shadow' in the name but aren't full box-shadows.
+  if (name.includes('shadow') || name.includes('boxShadow')) {
+    shadows.push(variable);
+  }
+}
+
+/** @type {import('stylelint').Rule} */
+const ruleFunction$2 = (primary, secondaryOptions, context) => {
+  return (root, result) => {
+    const validOptions = validateOptions$2(result, ruleName$4, {
+      actual: primary,
+      possible: [true],
+    });
+    const validValues = shadows;
+
+    if (!validOptions) return
+
+    root.walkDecls(declNode => {
+      const {prop, value} = declNode;
+
+      if (prop !== 'box-shadow') return
+
+      if (value === 'none') return
+
+      const problems = [];
+
+      const checkForVariable = (vars, nodeValue) => {
+        return vars.some(variable =>
+          new RegExp(`${variable['name'].replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\b`).test(nodeValue),
+        )
+      };
+
+      if (checkForVariable(validValues, value)) {
+        return
+      }
+
+      const replacement = validValues.find(variable => variable.values.includes(value));
+
+      if (replacement && context.fix) {
+        declNode.value = value.replace(value, `var(${replacement['name']})`);
+      } else {
+        problems.push({
+          index: declarationValueIndex(declNode),
+          endIndex: declarationValueIndex(declNode) + value.length,
+          message: messages$4.rejected(value, replacement),
+        });
+      }
+
+      if (problems.length) {
+        for (const err of problems) {
+          report$2({
+            index: err.index,
+            endIndex: err.endIndex,
+            message: err.message,
+            node: declNode,
+            result,
+            ruleName: ruleName$4,
+          });
+        }
+      }
+    });
+  }
+};
+
+ruleFunction$2.ruleName = ruleName$4;
+ruleFunction$2.messages = messages$4;
+ruleFunction$2.meta = {
   fixable: true,
 };
 
-var borders = createPlugin$1(ruleName$3, ruleFunction$1);
+var boxShadow = createPlugin$2(ruleName$4, ruleFunction$2);
 
 const SKIP_VALUE_NODE_TYPES = new Set(['space', 'div']);
 const SKIP_AT_RULE_NAMES = new Set(['each', 'for', 'function', 'mixin']);
@@ -662,18 +765,18 @@ function createVariableRule(ruleName, rules, url) {
     let actualRules = rules;
     let overrides = options.rules;
     if (typeof rules === 'function') {
-      actualRules = rules({variables: variables$1, options, ruleName});
+      actualRules = rules({variables: variables$3, options, ruleName});
     } else {
       actualRules = Object.assign({}, rules);
     }
     if (typeof overrides === 'function') {
       delete options.rules;
-      overrides = overrides({rules: actualRules, options, ruleName, variables: variables$1});
+      overrides = overrides({rules: actualRules, options, ruleName, variables: variables$3});
     }
     if (overrides) {
       Object.assign(actualRules, overrides);
     }
-    const validate = declarationValidator(actualRules, {variables: variables$1});
+    const validate = declarationValidator(actualRules, {variables: variables$3});
 
     // The stylelint docs suggest respecting a "disableFix" rule option that
     // overrides the "global" context.fix (--fix) linting option.
@@ -707,10 +810,9 @@ function createVariableRule(ruleName, rules, url) {
               const message = stylelint.utils
                 .ruleMessages(ruleName, {
                   rejected: m => {
-                    if (url) {
+                    {
                       return `${m}. See ${url}.`
                     }
-                    return `${m}.`
                   },
                 })
                 .rejected(error);
@@ -735,27 +837,6 @@ function createVariableRule(ruleName, rules, url) {
 
 function noop$2() {}
 
-var boxShadow = createVariableRule(
-  'primer/box-shadow',
-  {
-    'box shadow': {
-      expects: 'a box-shadow variable',
-      props: 'box-shadow',
-      values: [
-        '$box-shadow*',
-        '$*-shadow',
-        'none',
-        // Match variables in any of the following formats: --color-shadow-*, --color-*-shadow-*, --color-*-shadow, --shadow-*, *shadow*
-        /var\(--color-(.+-)*shadow(-.+)*\)/,
-        /var\(--shadow(-.+)*\)/,
-        /var\((.+-)*shadow(-.+)*\)/,
-      ],
-      singular: true,
-    },
-  },
-  'https://primer.style/css/utilities/box-shadow',
-);
-
 const bgVars = [
   '$bg-*',
   '$tooltip-background-color',
@@ -798,9 +879,9 @@ var colors = createVariableRule(
   'https://primer.style/primitives/colors',
 );
 
-const ruleName$2 = 'primer/responsive-widths';
+const ruleName$3 = 'primer/responsive-widths';
 
-const messages$2 = stylelint.utils.ruleMessages(ruleName$2, {
+const messages$3 = stylelint.utils.ruleMessages(ruleName$3, {
   rejected: value => {
     return `A value larger than the smallest viewport could break responsive pages. Use a width value smaller than ${value}. https://primer.style/css/support/breakpoints`
   },
@@ -820,7 +901,7 @@ const walkGroups = (root, validate) => {
 };
 
 // eslint-disable-next-line no-unused-vars
-var responsiveWidths = stylelint.createPlugin(ruleName$2, (enabled, options = {}, context) => {
+var responsiveWidths = stylelint.createPlugin(ruleName$3, (enabled, options = {}, context) => {
   if (!enabled) {
     return noop$1
   }
@@ -856,7 +937,7 @@ var responsiveWidths = stylelint.createPlugin(ruleName$2, (enabled, options = {}
             if (parseInt(valueUnit.number) > 320) {
               problems.push({
                 index: declarationValueIndex(decl) + node.sourceIndex,
-                message: messages$2.rejected(node.value),
+                message: messages$3.rejected(node.value),
               });
             }
             break
@@ -864,7 +945,7 @@ var responsiveWidths = stylelint.createPlugin(ruleName$2, (enabled, options = {}
             if (parseInt(valueUnit.number) > 100) {
               problems.push({
                 index: declarationValueIndex(decl) + node.sourceIndex,
-                message: messages$2.rejected(node.value),
+                message: messages$3.rejected(node.value),
               });
             }
             break
@@ -878,7 +959,7 @@ var responsiveWidths = stylelint.createPlugin(ruleName$2, (enabled, options = {}
             message: err.message,
             node: decl,
             result,
-            ruleName: ruleName$2,
+            ruleName: ruleName$3,
           });
         }
       }
@@ -891,12 +972,12 @@ var responsiveWidths = stylelint.createPlugin(ruleName$2, (enabled, options = {}
 function noop$1() {}
 
 const {
-  createPlugin,
-  utils: {report, ruleMessages, validateOptions},
+  createPlugin: createPlugin$1,
+  utils: {report: report$1, ruleMessages: ruleMessages$1, validateOptions: validateOptions$1},
 } = stylelint;
 
-const ruleName$1 = 'primer/spacing';
-const messages$1 = ruleMessages(ruleName$1, {
+const ruleName$2 = 'primer/spacing';
+const messages$2 = ruleMessages$1(ruleName$2, {
   rejected: (value, replacement) => {
     if (!replacement) {
       return `Please use a primer size variable instead of '${value}'. Consult the primer docs for a suitable replacement. https://primer.style/foundations/primitives/size`
@@ -907,7 +988,7 @@ const messages$1 = ruleMessages(ruleName$1, {
 });
 
 // Props that we want to check
-const propList = ['padding', 'margin', 'top', 'right', 'bottom', 'left'];
+const propList$1 = ['padding', 'margin', 'top', 'right', 'bottom', 'left'];
 // Values that we want to ignore
 const valueList = ['${'];
 
@@ -924,9 +1005,9 @@ for (const size of sizes) {
 }
 
 /** @type {import('stylelint').Rule} */
-const ruleFunction = (primary, secondaryOptions, context) => {
+const ruleFunction$1 = (primary, secondaryOptions, context) => {
   return (root, result) => {
-    const validOptions = validateOptions(result, ruleName$1, {
+    const validOptions = validateOptions$1(result, ruleName$2, {
       actual: primary,
       possible: [true],
     });
@@ -936,7 +1017,7 @@ const ruleFunction = (primary, secondaryOptions, context) => {
     root.walkDecls(declNode => {
       const {prop, value} = declNode;
 
-      if (!propList.some(spacingProp => prop.startsWith(spacingProp))) return
+      if (!propList$1.some(spacingProp => prop.startsWith(spacingProp))) return
       if (valueList.some(valueToIgnore => value.includes(valueToIgnore))) return
 
       const problems = [];
@@ -981,7 +1062,7 @@ const ruleFunction = (primary, secondaryOptions, context) => {
           problems.push({
             index: declarationValueIndex(declNode) + node.sourceIndex,
             endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
-            message: messages$1.rejected(node.value, replacement),
+            message: messages$2.rejected(node.value, replacement),
           });
         }
 
@@ -992,6 +1073,189 @@ const ruleFunction = (primary, secondaryOptions, context) => {
         declNode.value = parsedValue.toString();
       }
 
+      if (problems.length) {
+        for (const err of problems) {
+          report$1({
+            index: err.index,
+            endIndex: err.endIndex,
+            message: err.message,
+            node: declNode,
+            result,
+            ruleName: ruleName$2,
+          });
+        }
+      }
+    });
+  }
+};
+
+ruleFunction$1.ruleName = ruleName$2;
+ruleFunction$1.messages = messages$2;
+ruleFunction$1.meta = {
+  fixable: true,
+};
+
+var spacing = createPlugin$1(ruleName$2, ruleFunction$1);
+
+const {
+  createPlugin,
+  utils: {report, ruleMessages, validateOptions},
+} = stylelint;
+
+const ruleName$1 = 'primer/typography';
+const messages$1 = ruleMessages(ruleName$1, {
+  rejected: (value, replacement) => {
+    // no possible replacement
+    if (!replacement) {
+      return `Please use a Primer typography variable instead of '${value}'. Consult the primer docs for a suitable replacement. https://primer.style/foundations/primitives/typography`
+    }
+
+    // multiple possible replacements
+    if (replacement.length) {
+      return `Please use one of the following Primer typography variables instead of '${value}': ${replacement.map(replacementObj => `'${replacementObj.name}'`).join(', ')}. https://primer.style/foundations/primitives/typography`
+    }
+
+    // one possible replacement
+    return `Please replace '${value}' with Primer typography variable '${replacement['name']}'. https://primer.style/foundations/primitives/typography`
+  },
+});
+
+const fontWeightKeywordMap = {
+  normal: 400,
+  bold: 600,
+  bolder: 600,
+  lighter: 300,
+};
+const getClosestFontWeight = (goalWeightNumber, fontWeightsTokens) => {
+  return fontWeightsTokens.reduce((prev, curr) =>
+    Math.abs(curr.values - goalWeightNumber) < Math.abs(prev.values - goalWeightNumber) ? curr : prev,
+  ).values
+};
+
+const variables = primitivesVariables('typography');
+const fontSizes = [];
+const fontWeights = [];
+const lineHeights = [];
+const fontStacks = [];
+const fontShorthands = [];
+
+// Props that we want to check for typography variables
+const propList = ['font-size', 'font-weight', 'line-height', 'font-family', 'font'];
+
+for (const variable of variables) {
+  const name = variable['name'];
+
+  if (name.includes('size')) {
+    fontSizes.push(variable);
+  }
+
+  if (name.includes('weight')) {
+    fontWeights.push(variable);
+  }
+
+  if (name.includes('lineHeight')) {
+    lineHeights.push(variable);
+  }
+
+  if (name.includes('fontStack')) {
+    fontStacks.push(variable);
+  }
+
+  if (name.includes('shorthand')) {
+    fontShorthands.push(variable);
+  }
+}
+
+/** @type {import('stylelint').Rule} */
+const ruleFunction = (primary, secondaryOptions, context) => {
+  return (root, result) => {
+    const validOptions = validateOptions(result, ruleName$1, {
+      actual: primary,
+      possible: [true],
+    });
+    let validValues = [];
+
+    if (!validOptions) return
+
+    root.walkDecls(declNode => {
+      const {prop, value} = declNode;
+
+      if (!propList.some(typographyProp => prop.startsWith(typographyProp))) return
+
+      const problems = [];
+
+      const checkForVariable = (vars, nodeValue) =>
+        vars.some(variable =>
+          new RegExp(`${variable['name'].replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\b`).test(nodeValue),
+        );
+
+      // Exact values to ignore.
+      if (value === 'inherit') {
+        return
+      }
+
+      switch (prop) {
+        case 'font-size':
+          validValues = fontSizes;
+          break
+        case 'font-weight':
+          validValues = fontWeights;
+          break
+        case 'line-height':
+          validValues = lineHeights;
+          break
+        case 'font-family':
+          validValues = fontStacks;
+          break
+        case 'font':
+          validValues = fontShorthands;
+          break
+        default:
+          validValues = [];
+      }
+
+      if (checkForVariable(validValues, value)) {
+        return
+      }
+
+      const getReplacements = () => {
+        const replacementTokens = validValues.filter(variable => {
+          if (!(variable.values instanceof Array)) {
+            let nodeValue = value;
+
+            if (prop === 'font-weight') {
+              nodeValue = getClosestFontWeight(fontWeightKeywordMap[value] || value, fontWeights);
+            }
+
+            return variable.values.toString() === nodeValue.toString()
+          }
+
+          return variable.values.includes(value.replace('-', ''))
+        });
+
+        if (!replacementTokens.length) {
+          return
+        }
+
+        if (replacementTokens.length > 1) {
+          return replacementTokens
+        }
+
+        return replacementTokens[0]
+      };
+      const replacement = getReplacements();
+      const fixable = replacement && !replacement.length;
+
+      if (fixable && context.fix) {
+        declNode.value = value.replace(value, `var(${replacement['name']})`);
+      } else {
+        problems.push({
+          index: declarationValueIndex(declNode),
+          endIndex: declarationValueIndex(declNode) + value.length,
+          message: messages$1.rejected(value, replacement, prop),
+        });
+      }
+
       if (problems.length) {
         for (const err of problems) {
           report({
@@ -1014,30 +1278,7 @@ ruleFunction.meta = {
   fixable: true,
 };
 
-var spacing = createPlugin(ruleName$1, ruleFunction);
-
-var typography = createVariableRule(
-  'primer/typography',
-  {
-    'font-size': {
-      expects: 'a font-size variable',
-      values: ['$body-font-size', '$h{000,00,0,1,2,3,4,5,6}-size', '$font-size-*', '1', '1em', 'inherit'],
-    },
-    'font-weight': {
-      props: 'font-weight',
-      values: ['$font-weight-*', 'inherit'],
-      replacements: {
-        bold: '$font-weight-bold',
-        normal: '$font-weight-normal',
-      },
-    },
-    'line-height': {
-      props: 'line-height',
-      values: ['$body-line-height', '$lh-*', '0', '1', '1em', 'inherit'],
-    },
-  },
-  'https://primer.style/css/utilities/typography',
-);
+var typography = createPlugin(ruleName$1, ruleFunction);
 
 const ruleName = 'primer/no-display-colors';
 const messages = stylelint.utils.ruleMessages(ruleName, {
@@ -1222,8 +1463,6 @@ var index = {
         'length-zero-no-unit': null,
         'selector-max-type': null,
         'primer/colors': null,
-        'primer/typography': null,
-        'primer/box-shadow': null,
       },
     },
     {
@@ -1248,7 +1487,6 @@ var index = {
     },
     {
       files: ['**/*.module.css'],
-      plugins: ['stylelint-css-modules-no-global-scoped-selector'],
       rules: {
         'property-no-unknown': [
           true,
@@ -1273,10 +1511,6 @@ var index = {
             ignoreFunctions: ['global'],
           },
         ],
-        'css-modules/no-global-scoped-selector': true,
-        // temporarily disabiling Primer plugins while we work on upgrades https://github.com/github/primer/issues/3165
-        'primer/typography': null,
-        'primer/box-shadow': null,
       },
     },
   ],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@primer/stylelint-config",
-  "version": "13.0.0-rc.fe9ab86",
+  "version": "13.0.0",
   "description": "Sharable stylelint config used by GitHub's CSS",
   "author": "GitHub, Inc.",
   "license": "MIT",
@@ -45,7 +45,7 @@
   "dependencies": {
     "@github/browserslist-config": "^1.0.0",
     "@primer/css": "^21.0.8",
-    "@primer/primitives": "^8.2.0",
+    "@primer/primitives": "^9.0.1",
     "anymatch": "^3.1.1",
     "postcss-scss": "^4.0.2",
     "postcss-styled-syntax": "^0.6.4",
@@ -53,38 +53,32 @@
     "string.prototype.matchall": "^4.0.2",
     "stylelint": "^16.3.1",
     "stylelint-config-standard": "^36.0.0",
-    "stylelint-css-modules-no-global-scoped-selector": "^1.0.2",
     "stylelint-no-unsupported-browser-features": "^8.0.0",
     "stylelint-order": "^6.0.4",
     "stylelint-scss": "^6.2.0",
     "stylelint-value-no-unknown-custom-properties": "^6.0.1",
     "tap-map": "^1.0.0"
   },
-  "overrides": {
-    "stylelint-css-modules-no-global-scoped-selector": {
-      "stylelint": "$stylelint",
-      "postcss-modules-local-by-default": "^4.0.0"
-    }
-  },
   "prettier": "@github/prettier-config",
   "devDependencies": {
     "@changesets/changelog-github": "^0.5.0",
-    "@changesets/cli": "2.27.1",
+    "@changesets/cli": "2.27.7",
     "@github/prettier-config": "^0.0.6",
-    "@rollup/plugin-commonjs": "^25.0.7",
+    "@rollup/plugin-commonjs": "^26.0.1",
     "@rollup/plugin-json": "^6.1.0",
     "@rollup/plugin-node-resolve": "^15.2.3",
-    "@typescript-eslint/parser": "^7.7.0",
+    "@typescript-eslint/parser": "^8.0.1",
     "dedent": "^1.5.3",
-    "eslint": "^8.0.1",
-    "eslint-plugin-github": "^4.10.2",
+    "eslint": "^8.57.0",
+    "eslint-plugin-github": "^5.0.1",
+    "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-jest": "^28.2.0",
     "eslint-plugin-prettier": "^5.1.3",
     "jest": "^29.7.0",
     "jest-preset-stylelint": "^7.0.0",
     "prettier": "^3.2.5",
-    "rimraf": "^5.0.5",
-    "rollup": "^4.14.3"
+    "rimraf": "^6.0.1",
+    "rollup": "^4.21.1"
   },
   "jest": {
     "transform": {},