@primer/stylelint-config 12.9.2 → 13.0.0-rc.0a1e1bd

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json CHANGED
@@ -1,12 +1,22 @@
1
1
  {
2
2
  "name": "@primer/stylelint-config",
3
- "version": "12.9.2",
3
+ "version": "13.0.0-rc.0a1e1bd",
4
4
  "description": "Sharable stylelint config used by GitHub's CSS",
5
- "homepage": "http://primer.style/css/tools/linting",
6
5
  "author": "GitHub, Inc.",
7
6
  "license": "MIT",
8
- "main": "index.js",
9
- "repository": "primer/stylelint-config",
7
+ "type": "module",
8
+ "main": "dist/index.cjs",
9
+ "exports": {
10
+ ".": {
11
+ "import": "./dist/index.mjs",
12
+ "require": "./dist/index.cjs"
13
+ }
14
+ },
15
+ "browserslist": "extends @github/browserslist-config",
16
+ "repository": {
17
+ "type": "git",
18
+ "url": "git+https://github.com/primer/stylelint-config.git"
19
+ },
10
20
  "keywords": [
11
21
  "github",
12
22
  "primer",
@@ -15,44 +25,68 @@
15
25
  "stylelint"
16
26
  ],
17
27
  "files": [
28
+ "dist/",
18
29
  "property-order.js",
19
- "browsers.js",
20
30
  "plugins/"
21
31
  ],
32
+ "engines": {
33
+ "node": ">16.0.0"
34
+ },
22
35
  "scripts": {
23
- "test": "jest --coverage false",
36
+ "pretest": "npm run build",
37
+ "build": "rollup -c",
38
+ "clean": "rimraf dist",
39
+ "test": "npm run test:jest && npm run test:stylelint",
40
+ "test:jest": "NODE_OPTIONS=\"$NODE_OPTIONS --experimental-vm-modules\" jest --coverage false",
41
+ "test:stylelint": "stylelint __tests__/__fixtures__/good/",
24
42
  "lint": "eslint .",
25
43
  "release": "changeset publish"
26
44
  },
27
45
  "dependencies": {
46
+ "@github/browserslist-config": "^1.0.0",
47
+ "@primer/css": "^21.0.8",
48
+ "@primer/primitives": "^7.17.1",
28
49
  "anymatch": "^3.1.1",
29
- "globby": "^11.0.1",
30
50
  "postcss-scss": "^4.0.2",
51
+ "postcss-styled-syntax": "^0.6.4",
31
52
  "postcss-value-parser": "^4.0.2",
32
53
  "string.prototype.matchall": "^4.0.2",
33
- "stylelint": "^15.10.2",
34
- "stylelint-config-standard": "^34.0.0",
35
- "stylelint-no-unsupported-browser-features": "^7.0.0",
36
- "stylelint-order": "^6.0.3",
37
- "stylelint-scss": "^5.1.0",
54
+ "stylelint": "^16.3.1",
55
+ "stylelint-config-standard": "^36.0.0",
56
+ "stylelint-css-modules-no-global-scoped-selector": "^1.0.2",
57
+ "stylelint-no-unsupported-browser-features": "^8.0.0",
58
+ "stylelint-order": "^6.0.4",
59
+ "stylelint-scss": "^6.2.0",
60
+ "stylelint-value-no-unknown-custom-properties": "^6.0.1",
38
61
  "tap-map": "^1.0.0"
39
62
  },
63
+ "overrides": {
64
+ "stylelint-css-modules-no-global-scoped-selector": {
65
+ "stylelint": "$stylelint"
66
+ }
67
+ },
68
+ "prettier": "@github/prettier-config",
40
69
  "devDependencies": {
41
- "@changesets/changelog-github": "0.4.7",
42
- "@changesets/cli": "2.26.1",
43
- "@github/prettier-config": "0.0.6",
44
- "@primer/css": "^21.0.8",
45
- "@primer/primitives": "^7.11.11",
46
- "dedent": "1.5.1",
47
- "eslint": "8.39.0",
48
- "eslint-plugin-github": "4.8.0",
49
- "eslint-plugin-jest": "27.2.3",
50
- "eslint-plugin-prettier": "4.2.1",
51
- "jest": "29.4.3",
52
- "jest-preset-stylelint": "6.1.0",
53
- "prettier": "2.8.1"
70
+ "@changesets/changelog-github": "^0.5.0",
71
+ "@changesets/cli": "2.27.1",
72
+ "@github/prettier-config": "^0.0.6",
73
+ "@rollup/plugin-commonjs": "^25.0.7",
74
+ "@rollup/plugin-json": "^6.1.0",
75
+ "@rollup/plugin-node-resolve": "^15.2.3",
76
+ "@typescript-eslint/parser": "^7.7.0",
77
+ "dedent": "^1.5.3",
78
+ "eslint": "^8.0.1",
79
+ "eslint-plugin-github": "^4.10.2",
80
+ "eslint-plugin-jest": "^28.2.0",
81
+ "eslint-plugin-prettier": "^5.1.3",
82
+ "jest": "^29.7.0",
83
+ "jest-preset-stylelint": "^7.0.0",
84
+ "prettier": "^3.2.5",
85
+ "rimraf": "^5.0.5",
86
+ "rollup": "^4.14.3"
54
87
  },
55
88
  "jest": {
89
+ "transform": {},
56
90
  "preset": "jest-preset-stylelint",
57
91
  "collectCoverage": true,
58
92
  "collectCoverageFrom": [
@@ -64,7 +98,8 @@
64
98
  ],
65
99
  "testPathIgnorePatterns": [
66
100
  "/node_modules/",
67
- "__tests__/utils"
101
+ "__tests__/utils",
102
+ "__tests__/__fixtures__"
68
103
  ]
69
104
  }
70
105
  }
package/plugins/README.md CHANGED
@@ -7,11 +7,6 @@ This directory contains all of our custom stylelint plugins, each of which provi
7
7
  - [Primer stylelint plugins](#primer-stylelint-plugins)
8
8
  - [Rules](#rules)
9
9
  - [Usage](#usage)
10
- - [`primer/no-override`](#primerno-override)
11
- - [`primer/no-unused-vars`](#primerno-unused-vars)
12
- - [`primer/no-deprecated-colors`](#primerno-deprecated-colors)
13
- - [`primer/no-undefined-vars`](#primerno-undefined-vars)
14
- - [`primer/no-scale-colors`](#primerno-scale-colors)
15
10
  - [`primer/colors`](#primercolors)
16
11
  - [`primer/spacing`](#primerspacing)
17
12
  - [`primer/typography`](#primertypography)
@@ -33,131 +28,7 @@ If you're _not_ using or extending `@primer/stylelint-config`, you can still ref
33
28
  ```js
34
29
  // stylelint.config.js
35
30
  module.exports = {
36
- plugins: ['@primer/stylelint-config/plugins/no-override', '@primer/stylelint-config/plugins/no-unused-vars']
37
- }
38
- ```
39
-
40
- ## `primer/no-override`
41
-
42
- This rule prohibits "overriding" class selectors defined in [Primer CSS]. By default, it will only fail selectors that target utility classes:
43
-
44
- ```scss
45
- // FAIL
46
- .mt-0 {
47
- /* literally anything */
48
- }
49
- ```
50
-
51
- You can further constrain overrides to exclude _any_ class selector in Primer by providing additional names in the `bundles` option:
52
-
53
- ```js
54
- // stylelint.config.js
55
- module.exports = {
56
- // ...
57
- rules: {
58
- 'primer/no-override': [
59
- true,
60
- {
61
- bundles: ['utilities', core', 'product', 'marketing']
62
- }
63
- ]
64
- }
65
- }
66
- ```
67
-
68
- ## `primer/no-unused-vars`
69
-
70
- This rule helps you find SCSS variables that _may_ not be used, and can be safely deleted. It works by scanning all of the SCSS files in your project and looking for anything that appears to be either a Sass variable declaration or reference:
71
-
72
- ```scss
73
- $name: value;
74
- /** ↑
75
- * The colon is what makes this a declaration */
76
-
77
- /* Anything starting with a $ and followed by word chars or hyphens
78
- * and _not_ followed by a colon is considered a reference: */
79
-
80
- margin: $value;
81
- /** ↑
82
- * Not a colon */
83
- padding: $value 1px;
84
- /** ↑
85
- * Not a colon */
86
-
87
- @media screen and (max-width: $break-lg) {
88
- /** ↑
89
- * Also not a colon */
90
- ```
91
-
92
- Equipped with a list of all the variable declarations and references, the linting rule walks all of the declarations in the
93
- file being linted, finds any that look like declarations (using the same pattern as the project-wide scan), and generates a warning for any that have zero references in the files it's scanned.
94
-
95
- Because there isn't any good way for a stylelint plugin to know all of the files being linted, it needs to be told where to find all of the declarations and references in its options:
96
-
97
- - `files` is a single path, glob, or array of paths and globs, that tells the plugin which files to scan relative to the current working directory. The default is `['**/*.scss', '!node_modules']`, which tells [globby] to find all the `.scss` files recursively and ignore the `node_modules` directory.
98
-
99
- - `variablePattern` is a regular expression that matches a single variable in either a source file string or the `prop` of a postcss Declaration node (`{type: 'decl'}`). The default matches Sass/SCSS variables: `/\$[-\w]/g`. Note that the `g` ("global") flag is _required_ to match multiple variable references on a single line.
100
-
101
- - `verbose` is a boolean that enables chatty `console.warn()` messages telling you what the plugin found, which can aid in debugging more complicated project layouts.
102
-
103
- ## `primer/no-deprecated-colors`
104
-
105
- This rule identifies deprecated color variables from [primer/primitives]](https://github.com/primer/primitives) deprecated.json file and suggests replacements.
106
-
107
- ```scss
108
- body {
109
- color: var(--color-fg-default);
110
- }
111
- /** ↑
112
- * OK: --color-text-primary is defined */
113
-
114
- body {
115
- color: var(--color-text-primary);
116
- }
117
- /** ↑
118
- * FAIL: --color-text-primary is deprecated. */
119
- ```
120
-
121
- ## `primer/no-undefined-vars`
122
-
123
- This rule prohibits any usages of undefined CSS variables.
124
-
125
- ```scss
126
- :root {
127
- --color-text-primary: #000;
128
- }
129
-
130
- body {
131
- color: var(--color-text-primary);
132
- }
133
- /** ↑
134
- * OK: --color-text-primary is defined */
135
-
136
- body {
137
- color: var(--color-foo);
138
- }
139
- /** ↑
140
- * FAIL: --color-foo is not defined */
141
- ```
142
-
143
- For the purposes of this rule, a CSS variable declaration is any text starting with `--` and immediately followed by a colon.
144
-
145
- Because there isn't a good way for a stylelint plugin to know what CSS variables are defined, it needs to be told where to look for declarations in its options:
146
-
147
- - `files` is a single path, glob, or array of paths and globs, that tells the plugin which files (relative to the current working directory) to scan for CSS variable declarations. The default is `['**/*.scss', '!node_modules']`, which tells [globby] to find all the `.scss` files recursively and ignore the `node_modules` directory.
148
- - `verbose` is a boolean that enables chatty `console.warn()` messages telling you what the plugin found, which can aid in debugging more complicated project layouts.
149
-
150
- ## `primer/no-scale-colors`
151
-
152
- This rule prohibits the use of [non-functional scale CSS variables](https://primer.style/css/support/color-system#color-palette) like `var(--color-scale-blue-1)` in all cases except the `color-variables` mixin.
153
-
154
- ```scss
155
- // Okay; using scale colors while defining new variables
156
- @include color-scale-var('new-var-name', var(--color-scale-blue-1), var(--color-scale-blue-2))
157
-
158
- // Fail; using scale colors directly as a property value
159
- .selector {
160
- color: var(--color-scale-blue-1)
31
+ plugins: ['@primer/stylelint-config/plugins/colors']
161
32
  }
162
33
  ```
163
34
 
@@ -377,5 +248,4 @@ module.exports = {
377
248
  - `disableFix` is a boolean that can disable auto-fixing of this rule when running `stylelint --fix` to auto-fix other rules.
378
249
 
379
250
  [primer css]: https://primer.style/css
380
- [globby]: https://www.npmjs.com/package/globby
381
251
  [glob patterns]: http://tldp.org/LDP/GNU-Linux-Tools-Summary/html/x11655.htm
@@ -1,6 +1,6 @@
1
- const {createVariableRule} = require('./lib/variable-rules')
1
+ import {createVariableRule} from './lib/variable-rules.js'
2
2
 
3
- module.exports = createVariableRule(
3
+ export default createVariableRule(
4
4
  'primer/borders',
5
5
  {
6
6
  border: {
@@ -1,6 +1,6 @@
1
- const {createVariableRule} = require('./lib/variable-rules')
1
+ import {createVariableRule} from './lib/variable-rules.js'
2
2
 
3
- module.exports = createVariableRule(
3
+ export default createVariableRule(
4
4
  'primer/box-shadow',
5
5
  {
6
6
  'box shadow': {
package/plugins/colors.js CHANGED
@@ -1,4 +1,4 @@
1
- const {createVariableRule} = require('./lib/variable-rules')
1
+ import {createVariableRule} from './lib/variable-rules.js'
2
2
 
3
3
  const bgVars = [
4
4
  '$bg-*',
@@ -12,7 +12,7 @@ const bgVars = [
12
12
  /var\((.+-)*iconColor(-.+)*\)/,
13
13
  ]
14
14
 
15
- module.exports = createVariableRule(
15
+ export default createVariableRule(
16
16
  'primer/colors',
17
17
  {
18
18
  'background-color': {
@@ -1,11 +1,11 @@
1
- const anymatch = require('anymatch')
2
- const valueParser = require('postcss-value-parser')
3
- const TapMap = require('tap-map')
1
+ import anymatch from 'anymatch'
2
+ import valueParser from 'postcss-value-parser'
3
+ import TapMap from 'tap-map'
4
4
 
5
5
  const SKIP_VALUE_NODE_TYPES = new Set(['space', 'div'])
6
6
  const SKIP_AT_RULE_NAMES = new Set(['each', 'for', 'function', 'mixin'])
7
7
 
8
- module.exports = function declarationValidator(rules, options = {}) {
8
+ export default function declarationValidator(rules, options = {}) {
9
9
  const {formatMessage = defaultMessageFormatter, variables, verbose = false} = options
10
10
  const variableReplacements = new TapMap()
11
11
  if (variables) {
@@ -1,7 +1,7 @@
1
1
  // Meant as temp until we can move to primitives or css
2
2
  const colorTypes = ['accent', 'success', 'attention', 'severe', 'danger', 'open', 'closed', 'done', 'sponsors']
3
3
 
4
- module.exports = {
4
+ export default {
5
5
  color: [
6
6
  {
7
7
  value: 'var(--color-fg-default)',
@@ -0,0 +1,33 @@
1
+ import {createRequire} from 'node:module'
2
+
3
+ const require = createRequire(import.meta.url)
4
+
5
+ export async function primitivesVariables(type) {
6
+ const variables = []
7
+
8
+ const files = []
9
+ switch (type) {
10
+ case 'size':
11
+ files.push('base/size/size.json')
12
+ break
13
+ }
14
+
15
+ for (const file of files) {
16
+ // eslint-disable-next-line import/no-dynamic-require
17
+ const data = require(`@primer/primitives/dist/styleLint/${file}`)
18
+
19
+ for (const key of Object.keys(data)) {
20
+ const size = data[key]
21
+ const values = size['value']
22
+ values.push(`${parseInt(size['original']['value']) + 1}px`)
23
+ values.push(`${parseInt(size['original']['value']) - 1}px`)
24
+
25
+ variables.push({
26
+ name: `--${size['name']}`,
27
+ values,
28
+ })
29
+ }
30
+ }
31
+
32
+ return variables
33
+ }
@@ -1,27 +1,12 @@
1
- const stylelint = require('stylelint')
2
- const {requirePrimerFile} = require('./primer')
3
- const declarationValidator = require('./decl-validator')
1
+ import stylelint from 'stylelint'
2
+ import declarationValidator from './decl-validator.js'
3
+ import variables from '@primer/css/dist/variables.json' with {type: 'json'}
4
4
 
5
- const CSS_IMPORTANT = '!important'
6
- const CSS_DIRECTIONS = ['top', 'right', 'bottom', 'left']
7
- const CSS_CORNERS = ['top-right', 'bottom-right', 'bottom-left', 'top-left']
8
-
9
- module.exports = {
10
- createVariableRule,
11
- CSS_DIRECTIONS,
12
- CSS_CORNERS,
13
- CSS_IMPORTANT,
14
- }
15
-
16
- function createVariableRule(ruleName, rules, url) {
17
- let variables = {}
18
- try {
19
- variables = requirePrimerFile('dist/variables.json')
20
- } catch (error) {
21
- // eslint-disable-next-line no-console
22
- console.warn(`Unable to get variables.json from @primer/css. Replacements will need to be specified manually.`)
23
- }
5
+ export const CSS_IMPORTANT = '!important'
6
+ export const CSS_DIRECTIONS = ['top', 'right', 'bottom', 'left']
7
+ export const CSS_CORNERS = ['top-right', 'bottom-right', 'bottom-left', 'top-left']
24
8
 
9
+ export function createVariableRule(ruleName, rules, url) {
25
10
  const plugin = stylelint.createPlugin(ruleName, (enabled, options = {}, context) => {
26
11
  if (enabled === false) {
27
12
  return noop
@@ -1,8 +1,8 @@
1
- const stylelint = require('stylelint')
2
- const matchAll = require('string.prototype.matchall')
1
+ import stylelint from 'stylelint'
2
+ import matchAll from 'string.prototype.matchall'
3
3
 
4
- const ruleName = 'primer/no-display-colors'
5
- const messages = stylelint.utils.ruleMessages(ruleName, {
4
+ export const ruleName = 'primer/no-display-colors'
5
+ export const messages = stylelint.utils.ruleMessages(ruleName, {
6
6
  rejected: varName => `${varName} is in alpha and should be used with caution with approval from the Primer team`,
7
7
  })
8
8
 
@@ -10,7 +10,7 @@ const messages = stylelint.utils.ruleMessages(ruleName, {
10
10
  // eslint-disable-next-line no-useless-escape
11
11
  const variableReferenceRegex = /var\(([^\),]+)(,.*)?\)/g
12
12
 
13
- module.exports = stylelint.createPlugin(ruleName, (enabled, options = {}) => {
13
+ export default stylelint.createPlugin(ruleName, (enabled, options = {}) => {
14
14
  if (!enabled) {
15
15
  return noop
16
16
  }
@@ -48,6 +48,3 @@ module.exports = stylelint.createPlugin(ruleName, (enabled, options = {}) => {
48
48
  })
49
49
 
50
50
  function noop() {}
51
-
52
- module.exports.ruleName = ruleName
53
- module.exports.messages = messages
@@ -1,10 +1,10 @@
1
- const stylelint = require('stylelint')
2
- const declarationValueIndex = require('stylelint/lib/utils/declarationValueIndex')
3
- const valueParser = require('postcss-value-parser')
1
+ import stylelint from 'stylelint'
2
+ import declarationValueIndex from 'stylelint/lib/utils/declarationValueIndex.cjs'
3
+ import valueParser from 'postcss-value-parser'
4
4
 
5
- const ruleName = 'primer/responsive-widths'
5
+ export const ruleName = 'primer/responsive-widths'
6
6
 
7
- const messages = stylelint.utils.ruleMessages(ruleName, {
7
+ export const messages = stylelint.utils.ruleMessages(ruleName, {
8
8
  rejected: value => {
9
9
  return `A value larger than the smallest viewport could break responsive pages. Use a width value smaller than ${value}. https://primer.style/css/support/breakpoints`
10
10
  },
@@ -24,7 +24,7 @@ const walkGroups = (root, validate) => {
24
24
  }
25
25
 
26
26
  // eslint-disable-next-line no-unused-vars
27
- module.exports = stylelint.createPlugin(ruleName, (enabled, options = {}, context) => {
27
+ export default stylelint.createPlugin(ruleName, (enabled, options = {}, context) => {
28
28
  if (!enabled) {
29
29
  return noop
30
30
  }
@@ -93,6 +93,3 @@ module.exports = stylelint.createPlugin(ruleName, (enabled, options = {}, contex
93
93
  })
94
94
 
95
95
  function noop() {}
96
-
97
- module.exports.ruleName = ruleName
98
- module.exports.messages = messages
@@ -1,39 +1,12 @@
1
- const stylelint = require('stylelint')
2
- const declarationValueIndex = require('stylelint/lib/utils/declarationValueIndex')
3
- const valueParser = require('postcss-value-parser')
4
-
5
- // TODO: Pull this in from primer/primitives
6
- const spacerValues = {
7
- '$spacer-1': '4px',
8
- '$spacer-2': '8px',
9
- '$spacer-3': '16px',
10
- '$spacer-4': '24px',
11
- '$spacer-5': '32px',
12
- '$spacer-6': '40px',
13
- '$spacer-7': '48px',
14
- '$spacer-8': '64px',
15
- '$spacer-9': '80px',
16
- '$spacer-10': '96px',
17
- '$spacer-11': '112px',
18
- '$spacer-12': '128px',
19
- '$em-spacer-1': '0.0625em',
20
- '$em-spacer-2': '0.125em',
21
- '$em-spacer-3': '0.25em',
22
- '$em-spacer-4': '0.375em',
23
- '$em-spacer-5': '0.5em',
24
- '$em-spacer-6': '0.75em',
25
- }
1
+ import stylelint from 'stylelint'
2
+ import declarationValueIndex from 'stylelint/lib/utils/declarationValueIndex.cjs'
3
+ import valueParser from 'postcss-value-parser'
4
+ import {primitivesVariables} from './lib/primitives.js'
26
5
 
27
- const ruleName = 'primer/spacing'
28
- const messages = stylelint.utils.ruleMessages(ruleName, {
29
- rejected: (value, replacement) => {
30
- if (replacement === null) {
31
- return `Please use a primer spacer variable instead of '${value}'. Consult the primer docs for a suitable replacement. https://primer.style/css/support/spacing`
32
- }
33
-
34
- return `Please replace ${value} with spacing variable '${replacement}'.`
35
- },
36
- })
6
+ const {
7
+ createPlugin,
8
+ utils: {report, ruleMessages, validateOptions},
9
+ } = stylelint
37
10
 
38
11
  const walkGroups = (root, validate) => {
39
12
  for (const node of root.nodes) {
@@ -46,24 +19,47 @@ const walkGroups = (root, validate) => {
46
19
  return root
47
20
  }
48
21
 
49
- // eslint-disable-next-line no-unused-vars
50
- module.exports = stylelint.createPlugin(ruleName, (enabled, options = {}, context) => {
51
- if (!enabled) {
52
- return noop
53
- }
22
+ export const ruleName = 'primer/spacing'
23
+ export const messages = ruleMessages(ruleName, {
24
+ rejected: (value, replacement) => {
25
+ if (!replacement) {
26
+ return `Please use a primer size variable instead of '${value}'. Consult the primer docs for a suitable replacement. https://primer.style/foundations/primitives/size`
27
+ }
54
28
 
55
- const lintResult = (root, result) => {
56
- root.walk(decl => {
57
- if (decl.type !== 'decl' || !decl.prop.match(/^(padding|margin)/)) {
58
- return noop
59
- }
29
+ return `Please replace '${value}' with size variable '${replacement['name']}'. https://primer.style/foundations/primitives/size`
30
+ },
31
+ })
60
32
 
61
- const problems = []
33
+ const meta = {
34
+ fixable: true,
35
+ }
62
36
 
63
- const parsedValue = walkGroups(valueParser(decl.value), node => {
64
- // Remove leading negative sign, if any.
65
- const cleanValue = node.value.replace(/^-/g, '')
37
+ /** @type {import('stylelint').Rule} */
38
+ const ruleFunction = (primary, secondaryOptions, context) => {
39
+ return async (root, result) => {
40
+ // Props that we want to check
41
+ const propList = ['padding', 'margin', 'top', 'right', 'bottom', 'left']
42
+ // Values that we want to ignore
43
+ const valueList = ['${']
66
44
 
45
+ const sizes = await primitivesVariables('size')
46
+
47
+ const validOptions = validateOptions(result, ruleName, {
48
+ actual: primary,
49
+ possible: [true],
50
+ })
51
+
52
+ if (!validOptions) return
53
+
54
+ root.walkDecls(declNode => {
55
+ const {prop, value} = declNode
56
+
57
+ if (!propList.some(spacingProp => prop.startsWith(spacingProp))) return
58
+ if (valueList.some(valueToIgnore => value.includes(valueToIgnore))) return
59
+
60
+ const problems = []
61
+
62
+ const parsedValue = walkGroups(valueParser(value), node => {
67
63
  // Only check word types. https://github.com/TrySound/postcss-value-parser#word
68
64
  if (node.type !== 'word') {
69
65
  return
@@ -74,30 +70,36 @@ module.exports = stylelint.createPlugin(ruleName, (enabled, options = {}, contex
74
70
  return
75
71
  }
76
72
 
77
- const valueUnit = valueParser.unit(cleanValue)
73
+ const valueUnit = valueParser.unit(node.value)
74
+
75
+ if (valueUnit && (valueUnit.unit === '' || !/^-?[0-9.]+$/.test(valueUnit.number))) {
76
+ return
77
+ }
78
78
 
79
- if (valueUnit && (valueUnit.unit === '' || !/^[0-9.]+$/.test(valueUnit.number))) {
79
+ // Skip if the value unit isn't a supported unit.
80
+ if (valueUnit && !['px', 'rem', 'em'].includes(valueUnit.unit)) {
80
81
  return
81
82
  }
82
83
 
83
- // If the a variable is found in the value, skip it.
84
+ // If the variable is found in the value, skip it.
84
85
  if (
85
- Object.keys(spacerValues).some(variable =>
86
- new RegExp(`${variable.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\b`).test(cleanValue),
86
+ sizes.some(variable =>
87
+ new RegExp(`${variable['name'].replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}\\b`).test(node.value),
87
88
  )
88
89
  ) {
89
90
  return
90
91
  }
91
92
 
92
- const replacement = Object.keys(spacerValues).find(spacer => spacerValues[spacer] === cleanValue) || null
93
- const valueMatch = replacement ? spacerValues[replacement] : node.value
93
+ const replacement = sizes.find(variable => variable.values.includes(node.value.replace('-', '')))
94
+ const fixable = replacement && valueUnit && !valueUnit.number.includes('-')
94
95
 
95
- if (replacement && context.fix) {
96
- node.value = node.value.replace(valueMatch, replacement)
96
+ if (fixable && context.fix) {
97
+ node.value = node.value.replace(node.value, `var(${replacement['name']})`)
97
98
  } else {
98
99
  problems.push({
99
- index: declarationValueIndex(decl) + node.sourceIndex,
100
- message: messages.rejected(valueMatch, replacement),
100
+ index: declarationValueIndex(declNode) + node.sourceIndex,
101
+ endIndex: declarationValueIndex(declNode) + node.sourceIndex + node.value.length,
102
+ message: messages.rejected(node.value, replacement),
101
103
  })
102
104
  }
103
105
 
@@ -105,15 +107,16 @@ module.exports = stylelint.createPlugin(ruleName, (enabled, options = {}, contex
105
107
  })
106
108
 
107
109
  if (context.fix) {
108
- decl.value = parsedValue.toString()
110
+ declNode.value = parsedValue.toString()
109
111
  }
110
112
 
111
113
  if (problems.length) {
112
114
  for (const err of problems) {
113
- stylelint.utils.report({
115
+ report({
114
116
  index: err.index,
117
+ endIndex: err.endIndex,
115
118
  message: err.message,
116
- node: decl,
119
+ node: declNode,
117
120
  result,
118
121
  ruleName,
119
122
  })
@@ -121,11 +124,10 @@ module.exports = stylelint.createPlugin(ruleName, (enabled, options = {}, contex
121
124
  }
122
125
  })
123
126
  }
127
+ }
124
128
 
125
- return lintResult
126
- })
127
-
128
- function noop() {}
129
+ ruleFunction.ruleName = ruleName
130
+ ruleFunction.messages = messages
131
+ ruleFunction.meta = meta
129
132
 
130
- module.exports.ruleName = ruleName
131
- module.exports.messages = messages
133
+ export default createPlugin(ruleName, ruleFunction)