@primer/react 38.46.0-rc.18db27ff8 → 38.46.0-rc.4633160f8
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md
CHANGED
|
@@ -8,8 +8,12 @@
|
|
|
8
8
|
|
|
9
9
|
### Patch Changes
|
|
10
10
|
|
|
11
|
+
- [#8679](https://github.com/primer/react/pull/8679) [`dbf2ac1`](https://github.com/primer/react/commit/dbf2ac1d758a0aae69f37ad1bd789480ce58ff4c) Thanks [@llastflowers](https://github.com/llastflowers)! - Breadcrumbs: Close the overflow menu when Escape is pressed while its tooltip is open.
|
|
12
|
+
|
|
11
13
|
- [#8628](https://github.com/primer/react/pull/8628) [`41f29c8`](https://github.com/primer/react/commit/41f29c845663936043618af29dcb71de4c9384b2) Thanks [@joshblack](https://github.com/joshblack)! - SkeletonAvatar, SkeletonText: Preserve the requested size and shape regardless of stylesheet load order
|
|
12
14
|
|
|
15
|
+
- [#8562](https://github.com/primer/react/pull/8562) [`ee46232`](https://github.com/primer/react/commit/ee46232fafa24701415b21eed60cca68e589cf1c) Thanks [@joshblack](https://github.com/joshblack)! - useOnEscapePress, useOnOutsideClick: Improve performance when callbacks change between renders.
|
|
16
|
+
|
|
13
17
|
## 38.45.0
|
|
14
18
|
|
|
15
19
|
### Minor Changes
|
|
@@ -128,6 +128,7 @@ const BreadcrumbsMenuItem = /*#__PURE__*/ React.forwardRef((t0, menuRefCallback)
|
|
|
128
128
|
role: "button",
|
|
129
129
|
ref: menuButtonRef,
|
|
130
130
|
"aria-label": t8,
|
|
131
|
+
"aria-haspopup": "true",
|
|
131
132
|
"aria-expanded": t9,
|
|
132
133
|
onClick: handleSummaryClick,
|
|
133
134
|
variant: "invisible",
|
|
@@ -82,7 +82,7 @@ const isInteractive = (element) => {
|
|
|
82
82
|
};
|
|
83
83
|
const emptyKeybindingHints = [];
|
|
84
84
|
const Tooltip = /*#__PURE__*/ React.forwardRef((t0, forwardedRef) => {
|
|
85
|
-
const $ = c(
|
|
85
|
+
const $ = c(60);
|
|
86
86
|
let children;
|
|
87
87
|
let className;
|
|
88
88
|
let id;
|
|
@@ -240,33 +240,37 @@ const Tooltip = /*#__PURE__*/ React.forwardRef((t0, forwardedRef) => {
|
|
|
240
240
|
} else t10 = $[26];
|
|
241
241
|
useEffect(t9, t10);
|
|
242
242
|
let t11;
|
|
243
|
-
if ($[27] !==
|
|
243
|
+
if ($[27] !== _privateDisableTooltip || $[28] !== closeTooltip || $[29] !== isPopoverOpen) {
|
|
244
244
|
t11 = (event) => {
|
|
245
245
|
if (isPopoverOpen) {
|
|
246
|
-
|
|
247
|
-
|
|
246
|
+
if (!_privateDisableTooltip) {
|
|
247
|
+
event.stopImmediatePropagation();
|
|
248
|
+
event.preventDefault();
|
|
249
|
+
}
|
|
248
250
|
closeTooltip();
|
|
249
251
|
}
|
|
250
252
|
};
|
|
251
|
-
$[27] =
|
|
252
|
-
$[28] =
|
|
253
|
-
$[29] =
|
|
254
|
-
|
|
253
|
+
$[27] = _privateDisableTooltip;
|
|
254
|
+
$[28] = closeTooltip;
|
|
255
|
+
$[29] = isPopoverOpen;
|
|
256
|
+
$[30] = t11;
|
|
257
|
+
} else t11 = $[30];
|
|
255
258
|
let t12;
|
|
256
|
-
if ($[
|
|
257
|
-
t12 = [isPopoverOpen];
|
|
258
|
-
$[
|
|
259
|
-
$[
|
|
260
|
-
|
|
259
|
+
if ($[31] !== _privateDisableTooltip || $[32] !== isPopoverOpen) {
|
|
260
|
+
t12 = [isPopoverOpen, _privateDisableTooltip];
|
|
261
|
+
$[31] = _privateDisableTooltip;
|
|
262
|
+
$[32] = isPopoverOpen;
|
|
263
|
+
$[33] = t12;
|
|
264
|
+
} else t12 = $[33];
|
|
261
265
|
useOnEscapePress(t11, t12);
|
|
262
266
|
const platform = usePlatform();
|
|
263
267
|
const hasAriaLabel_0 = "aria-label" in rest;
|
|
264
268
|
let t13;
|
|
265
|
-
if ($[
|
|
269
|
+
if ($[34] !== keybindingHint) {
|
|
266
270
|
t13 = Array.isArray(keybindingHint) ? keybindingHint : [keybindingHint];
|
|
267
|
-
$[
|
|
268
|
-
$[
|
|
269
|
-
} else t13 = $[
|
|
271
|
+
$[34] = keybindingHint;
|
|
272
|
+
$[35] = t13;
|
|
273
|
+
} else t13 = $[35];
|
|
270
274
|
const keybindingHints = t13;
|
|
271
275
|
if (isFragmentTrigger) return child;
|
|
272
276
|
const t14 = TooltipContext;
|
|
@@ -313,15 +317,15 @@ const Tooltip = /*#__PURE__*/ React.forwardRef((t0, forwardedRef) => {
|
|
|
313
317
|
}
|
|
314
318
|
});
|
|
315
319
|
let t17;
|
|
316
|
-
if ($[
|
|
320
|
+
if ($[36] !== className) {
|
|
317
321
|
t17 = clsx(className, Tooltip_module_css_default.Tooltip);
|
|
318
|
-
$[
|
|
319
|
-
$[
|
|
320
|
-
} else t17 = $[
|
|
322
|
+
$[36] = className;
|
|
323
|
+
$[37] = t17;
|
|
324
|
+
} else t17 = $[37];
|
|
321
325
|
const t18 = type === "description" ? "tooltip" : void 0;
|
|
322
326
|
const t19 = hasAriaLabel_0 || keybindingHints.length === 0 ? tooltipId : void 0;
|
|
323
327
|
let t20;
|
|
324
|
-
if ($[
|
|
328
|
+
if ($[38] !== hasAriaLabel_0 || $[39] !== keybindingHints || $[40] !== platform || $[41] !== text || $[42] !== tooltipId) {
|
|
325
329
|
t20 = keybindingHints.length > 0 ? /* @__PURE__ */ jsxs(Fragment$1, { children: [/* @__PURE__ */ jsxs("span", {
|
|
326
330
|
id: hasAriaLabel_0 ? void 0 : tooltipId,
|
|
327
331
|
children: [text, /* @__PURE__ */ jsxs(VisuallyHidden, { children: [
|
|
@@ -335,15 +339,15 @@ const Tooltip = /*#__PURE__*/ React.forwardRef((t0, forwardedRef) => {
|
|
|
335
339
|
"data-component": "Tooltip.KeybindingHintContainer",
|
|
336
340
|
children: keybindingHints.map(_temp4)
|
|
337
341
|
})] }) : text;
|
|
338
|
-
$[
|
|
339
|
-
$[
|
|
340
|
-
$[
|
|
341
|
-
$[
|
|
342
|
-
$[
|
|
343
|
-
$[
|
|
344
|
-
} else t20 = $[
|
|
342
|
+
$[38] = hasAriaLabel_0;
|
|
343
|
+
$[39] = keybindingHints;
|
|
344
|
+
$[40] = platform;
|
|
345
|
+
$[41] = text;
|
|
346
|
+
$[42] = tooltipId;
|
|
347
|
+
$[43] = t20;
|
|
348
|
+
} else t20 = $[43];
|
|
345
349
|
let t21;
|
|
346
|
-
if ($[
|
|
350
|
+
if ($[44] !== calculatedDirection || $[45] !== closeTooltip || $[46] !== openTooltip || $[47] !== rest || $[48] !== t17 || $[49] !== t18 || $[50] !== t19 || $[51] !== t20) {
|
|
347
351
|
t21 = /* @__PURE__ */ jsx("span", {
|
|
348
352
|
className: t17,
|
|
349
353
|
ref: tooltipElRef,
|
|
@@ -357,34 +361,34 @@ const Tooltip = /*#__PURE__*/ React.forwardRef((t0, forwardedRef) => {
|
|
|
357
361
|
id: t19,
|
|
358
362
|
children: t20
|
|
359
363
|
});
|
|
360
|
-
$[
|
|
361
|
-
$[
|
|
362
|
-
$[
|
|
363
|
-
$[
|
|
364
|
-
$[
|
|
365
|
-
$[
|
|
366
|
-
$[
|
|
367
|
-
$[
|
|
368
|
-
$[
|
|
369
|
-
} else t21 = $[
|
|
364
|
+
$[44] = calculatedDirection;
|
|
365
|
+
$[45] = closeTooltip;
|
|
366
|
+
$[46] = openTooltip;
|
|
367
|
+
$[47] = rest;
|
|
368
|
+
$[48] = t17;
|
|
369
|
+
$[49] = t18;
|
|
370
|
+
$[50] = t19;
|
|
371
|
+
$[51] = t20;
|
|
372
|
+
$[52] = t21;
|
|
373
|
+
} else t21 = $[52];
|
|
370
374
|
let t22;
|
|
371
|
-
if ($[
|
|
375
|
+
if ($[53] !== t15 || $[54] !== t21) {
|
|
372
376
|
t22 = /* @__PURE__ */ jsxs(Fragment$1, { children: [t15, t21] });
|
|
373
|
-
$[
|
|
374
|
-
$[
|
|
375
|
-
$[
|
|
376
|
-
} else t22 = $[
|
|
377
|
+
$[53] = t15;
|
|
378
|
+
$[54] = t21;
|
|
379
|
+
$[55] = t22;
|
|
380
|
+
} else t22 = $[55];
|
|
377
381
|
let t23;
|
|
378
|
-
if ($[
|
|
382
|
+
if ($[56] !== t14.Provider || $[57] !== t22 || $[58] !== value) {
|
|
379
383
|
t23 = /* @__PURE__ */ jsx(t14.Provider, {
|
|
380
384
|
value,
|
|
381
385
|
children: t22
|
|
382
386
|
});
|
|
383
|
-
$[
|
|
384
|
-
$[
|
|
385
|
-
$[
|
|
386
|
-
$[
|
|
387
|
-
} else t23 = $[
|
|
387
|
+
$[56] = t14.Provider;
|
|
388
|
+
$[57] = t22;
|
|
389
|
+
$[58] = value;
|
|
390
|
+
$[59] = t23;
|
|
391
|
+
} else t23 = $[59];
|
|
388
392
|
return t23;
|
|
389
393
|
});
|
|
390
394
|
Tooltip.__SLOT__ = Symbol("Tooltip");
|
|
@@ -12,6 +12,8 @@
|
|
|
12
12
|
* callback. Each callback has the chance to call `.preventDefault()` on the
|
|
13
13
|
* event to prevent further callbacks.
|
|
14
14
|
*
|
|
15
|
+
* Callback changes do not re-register the document listener.
|
|
16
|
+
*
|
|
15
17
|
* @param callback {(e: KeyboardEvent) => void} The callback that gets executed
|
|
16
18
|
* when the Escape key is pressed. The KeyboardEvent generated by the Escape
|
|
17
19
|
* keypress is passed as the only argument.
|
|
@@ -1,4 +1,5 @@
|
|
|
1
|
-
import {
|
|
1
|
+
import { useEffectCallback } from "../internal/hooks/useEffectCallback.js";
|
|
2
|
+
import { useCallback, useEffect, useState } from "react";
|
|
2
3
|
//#region src/hooks/useOnEscapePress.ts
|
|
3
4
|
/**
|
|
4
5
|
* Calls all handlers in reverse order
|
|
@@ -31,6 +32,8 @@ let handlerId = 0;
|
|
|
31
32
|
* callback. Each callback has the chance to call `.preventDefault()` on the
|
|
32
33
|
* event to prevent further callbacks.
|
|
33
34
|
*
|
|
35
|
+
* Callback changes do not re-register the document listener.
|
|
36
|
+
*
|
|
34
37
|
* @param callback {(e: KeyboardEvent) => void} The callback that gets executed
|
|
35
38
|
* when the Escape key is pressed. The KeyboardEvent generated by the Escape
|
|
36
39
|
* keypress is passed as the only argument.
|
|
@@ -41,10 +44,14 @@ let handlerId = 0;
|
|
|
41
44
|
*/
|
|
42
45
|
const useOnEscapePress = (onEscape, callbackDependencies = [onEscape]) => {
|
|
43
46
|
const escapeCallback = useCallback(onEscape, callbackDependencies);
|
|
44
|
-
const handler =
|
|
47
|
+
const handler = useEffectCallback((event) => {
|
|
45
48
|
if (event.key === "Escape") escapeCallback(event);
|
|
46
|
-
}
|
|
47
|
-
const id =
|
|
49
|
+
});
|
|
50
|
+
const [id] = useState(() => {
|
|
51
|
+
const id = handlerId;
|
|
52
|
+
handlerId += 1;
|
|
53
|
+
return id;
|
|
54
|
+
});
|
|
48
55
|
useEffect(() => {
|
|
49
56
|
if (Object.keys(registry).length === 0) document.addEventListener("keydown", handleEscape);
|
|
50
57
|
register(id, handler);
|
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
import { c } from "../utils/react-compiler-runtime.js";
|
|
2
|
+
import { useEffectCallback } from "../internal/hooks/useEffectCallback.js";
|
|
2
3
|
import { useEffect, useState } from "react";
|
|
3
4
|
//#region src/hooks/useOnOutsideClick.tsx
|
|
4
5
|
const stopPropagation = true;
|
|
@@ -40,7 +41,7 @@ const useOnOutsideClick = (t0) => {
|
|
|
40
41
|
$[2] = onClickOutside;
|
|
41
42
|
$[3] = t1;
|
|
42
43
|
} else t1 = $[3];
|
|
43
|
-
const handler = t1;
|
|
44
|
+
const handler = useEffectCallback(t1);
|
|
44
45
|
let t2;
|
|
45
46
|
let t3;
|
|
46
47
|
if ($[4] !== handler || $[5] !== id_0) {
|
package/package.json
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@primer/react",
|
|
3
3
|
"type": "module",
|
|
4
|
-
"version": "38.46.0-rc.
|
|
4
|
+
"version": "38.46.0-rc.4633160f8",
|
|
5
5
|
"description": "An implementation of GitHub's Primer Design System using React",
|
|
6
6
|
"main": "./dist/index.js",
|
|
7
7
|
"module": "./dist/index.js",
|
|
@@ -169,7 +169,7 @@
|
|
|
169
169
|
"rolldown-plugin-dts": "^0.26.0",
|
|
170
170
|
"rolldown-plugin-import-css": "^0.0.0",
|
|
171
171
|
"rolldown-plugin-preserve-directives": "^0.0.0",
|
|
172
|
-
"storybook": "10.
|
|
172
|
+
"storybook": "10.6.6",
|
|
173
173
|
"terser": "5.36.0",
|
|
174
174
|
"ts-toolbelt": "9.6.0",
|
|
175
175
|
"tsx": "4.20.3",
|