@primer/react 38.29.0 → 38.29.1-rc.4254fa28f
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md
CHANGED
|
@@ -1,5 +1,11 @@
|
|
|
1
1
|
# @primer/react
|
|
2
2
|
|
|
3
|
+
## 38.29.1
|
|
4
|
+
|
|
5
|
+
### Patch Changes
|
|
6
|
+
|
|
7
|
+
- [#7935](https://github.com/primer/react/pull/7935) [`5b3c806`](https://github.com/primer/react/commit/5b3c806305cfa09d33d42fc2957d55105725ea3b) Thanks [@copilot-swe-agent](https://github.com/apps/copilot-swe-agent)! - ConfirmationDialog: `useConfirm`/`confirm` now removes its host element from `document.body` after the dialog is closed, and uses a fresh host element per call, so the empty container no longer lingers or leaks into other components and tests
|
|
8
|
+
|
|
3
9
|
## 38.29.0
|
|
4
10
|
|
|
5
11
|
### Minor Changes
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"useConfirm.d.ts","sourceRoot":"","sources":["../../src/ConfirmationDialog/useConfirm.ts"],"names":[],"mappings":"AAAA,OAAO,KAAoB,MAAM,OAAO,CAAA;AAGxC,OAAO,EAAqB,KAAK,uBAAuB,EAAC,MAAM,sBAAsB,CAAA;
|
|
1
|
+
{"version":3,"file":"useConfirm.d.ts","sourceRoot":"","sources":["../../src/ConfirmationDialog/useConfirm.ts"],"names":[],"mappings":"AAAA,OAAO,KAAoB,MAAM,OAAO,CAAA;AAGxC,OAAO,EAAqB,KAAK,uBAAuB,EAAC,MAAM,sBAAsB,CAAA;AAErF,MAAM,MAAM,cAAc,GAAG,IAAI,CAAC,uBAAuB,EAAE,SAAS,CAAC,GAAG;IAAC,OAAO,EAAE,KAAK,CAAC,SAAS,CAAA;CAAC,CAAA;AAuBlG;;;;GAIG;AACH,wBAAgB,UAAU,cACa,cAAc,sBAIpD"}
|
|
@@ -3,23 +3,19 @@ import { createRoot } from 'react-dom/client';
|
|
|
3
3
|
import BaseStyles from '../BaseStyles.js';
|
|
4
4
|
import { ConfirmationDialog } from './ConfirmationDialog.js';
|
|
5
5
|
|
|
6
|
-
let hostElement = null;
|
|
7
6
|
async function confirm(options) {
|
|
8
7
|
const {
|
|
9
8
|
content,
|
|
10
9
|
...confirmationDialogProps
|
|
11
10
|
} = options;
|
|
12
11
|
return new Promise(resolve => {
|
|
13
|
-
hostElement
|
|
14
|
-
|
|
12
|
+
const hostElement = document.createElement('div');
|
|
13
|
+
document.body.append(hostElement);
|
|
15
14
|
const root = createRoot(hostElement);
|
|
16
15
|
const onClose = gesture => {
|
|
17
16
|
root.unmount();
|
|
18
|
-
|
|
19
|
-
|
|
20
|
-
} else {
|
|
21
|
-
resolve(false);
|
|
22
|
-
}
|
|
17
|
+
hostElement.remove();
|
|
18
|
+
resolve(gesture === 'confirm');
|
|
23
19
|
};
|
|
24
20
|
root.render(/*#__PURE__*/React.createElement(BaseStyles, null, /*#__PURE__*/React.createElement(ConfirmationDialog, {
|
|
25
21
|
...confirmationDialogProps,
|
package/package.json
CHANGED