@primer/css 0.0.0-20220302025458 → 0.0.0-20220302084732

package/CHANGELOG.md

@@ -1,12 +1,66 @@
 # @primer/css
 
-## 0.0.0-20220302025458
+## 0.0.0-20220302084732
+
+### Minor Changes
+
+- [#1948](https://github.com/primer/css/pull/1948) [`2f897845`](https://github.com/primer/css/commit/2f89784559e4c0ec323dfef20930dcb4dbab3320) Thanks [@simurai](https://github.com/simurai)! - Add `open` and `closed` color roles
+
+* [#1961](https://github.com/primer/css/pull/1961) [`a35a8bdc`](https://github.com/primer/css/commit/a35a8bdcc17906848fcb486842d2345db0441c7c) Thanks [@jonrohan](https://github.com/jonrohan)! - Default .PageLayout to display block
+
+### Patch Changes
+
+- [#1954](https://github.com/primer/css/pull/1954) [`30f29d38`](https://github.com/primer/css/commit/30f29d383256a7d4023a859fdeee44471307159d) Thanks [@simurai](https://github.com/simurai)! - Fix `input-block` in `form-group`
+
+* [#1956](https://github.com/primer/css/pull/1956) [`39063461`](https://github.com/primer/css/commit/3906346182ed983d9725fd95da41b21424378b3e) Thanks [@jonrohan](https://github.com/jonrohan)! - Upgrading @primer/stylelint-config@12.3.2
+
+- [#1931](https://github.com/primer/css/pull/1931) [`e5c5312e`](https://github.com/primer/css/commit/e5c5312ec8bf139f6c94d2f70ceecd4b3cd9fd82) Thanks [@vdepizzol](https://github.com/vdepizzol)! - Page layout api updates renaming spacing options in storybook
+
+* Fake entry to force publishing
+
+- [#1950](https://github.com/primer/css/pull/1950) [`7c85c500`](https://github.com/primer/css/commit/7c85c500569fe6e1b29665c2eed37d58625ab06f) Thanks [@hectahertz](https://github.com/hectahertz)! - Fix sequence of content in Subhead
+
+* [#1942](https://github.com/primer/css/pull/1942) [`0450ccbb`](https://github.com/primer/css/commit/0450ccbb86104564c7d4038eb68989f370014fa1) Thanks [@reeceatkinson](https://github.com/reeceatkinson)! - Added line break to docs
+
+- [#1953](https://github.com/primer/css/pull/1953) [`3a91a29a`](https://github.com/primer/css/commit/3a91a29a822a28ea9679fbbb90250fc039057f23) Thanks [@hectahertz](https://github.com/hectahertz)! - Use `<h2>` instead of `<div>` on Subhead-heading docs
+
+* [#1949](https://github.com/primer/css/pull/1949) [`dab83198`](https://github.com/primer/css/commit/dab83198c3bf1c7e03826b8cd498b8c48c9a2869) Thanks [@heiskr](https://github.com/heiskr)! - Render headings inline when in a `<summary>`
+
+## 19.4.0
+
+### Minor Changes
+
+- [#1937](https://github.com/primer/css/pull/1937) [`67f08009`](https://github.com/primer/css/commit/67f08009ef458088b9fda6267ab25ad6d0a514aa) Thanks [@langermank](https://github.com/langermank)! - TreeView single item nesting
+
+* [#1905](https://github.com/primer/css/pull/1905) [`50221a54`](https://github.com/primer/css/commit/50221a5486d28c54dc1f578b459addd867bd01d3) Thanks [@langermank](https://github.com/langermank)! - Refactors NavigationList to better handle accessibility. Backwards compatible for TreeView CSS.
+
+- [#1936](https://github.com/primer/css/pull/1936) [`c53ecdff`](https://github.com/primer/css/commit/c53ecdff5442cf4ac5da0d1e2ba45871ab662855) Thanks [@khiga8](https://github.com/khiga8)! - Deprecating `.tooltipped` CSS classes
+
+### Patch Changes
+
+- [#1928](https://github.com/primer/css/pull/1928) [`0fb67895`](https://github.com/primer/css/commit/0fb6789555652860cfa5178b60433eb2c3d2575c) Thanks [@simurai](https://github.com/simurai)! - Fix `<sup><a>` from getting wrapped with `[ ]`
+
+## 19.3.0
+
+### Minor Changes
+
+- [#1876](https://github.com/primer/css/pull/1876) [`bcf447ab`](https://github.com/primer/css/commit/bcf447ab226e6043dd47c1fcc395ba104af866d4) Thanks [@vdepizzol](https://github.com/vdepizzol)! - Add mono font stack to <samp> tag
+
+* [#1919](https://github.com/primer/css/pull/1919) [`21085f5c`](https://github.com/primer/css/commit/21085f5c6cc538b5014a47de76642554a4291cc6) Thanks [@hectahertz](https://github.com/hectahertz)! - Add blankslate classes to replace utilities
 
 ### Patch Changes
 
-- Fake entry to force publishing
+- [#1892](https://github.com/primer/css/pull/1892) [`55bd498b`](https://github.com/primer/css/commit/55bd498b7357e86659ac574f0f745f7b420fb6d3) Thanks [@langermank](https://github.com/langermank)! - Patch: Fix ActionList--divided for label with inline description scenarios
+
+* [#1906](https://github.com/primer/css/pull/1906) [`f02d9a3e`](https://github.com/primer/css/commit/f02d9a3e4e86c2659a9f507995bcb90c5226e34e) Thanks [@jonrohan](https://github.com/jonrohan)! - Upgrading @primer/stylelint-config@12.3.0 and fixing violations
+
+- [#1908](https://github.com/primer/css/pull/1908) [`84581e96`](https://github.com/primer/css/commit/84581e96aee50ff3883907dfe1069701edd1c24a) Thanks [@simurai](https://github.com/simurai)! - Reduce size of `Label--inline`
+
+* [#1890](https://github.com/primer/css/pull/1890) [`74d0438b`](https://github.com/primer/css/commit/74d0438bd4dbaed447b553c5d3c8b945da282836) Thanks [@andrialexandrou](https://github.com/andrialexandrou)! - Adds --color-accent-emphasis and --color-fg-on-emphasis rules for Windows High Contrast Mode
+
+- [#1882](https://github.com/primer/css/pull/1882) [`4a06aba1`](https://github.com/primer/css/commit/4a06aba1d3f80bcc228ff4360d0e02d5ace158ff) Thanks [@tqwewe](https://github.com/tqwewe)! - Fix layout gutter none styles
 
-* [#1882](https://github.com/primer/css/pull/1882) [`4a06aba1`](https://github.com/primer/css/commit/4a06aba1d3f80bcc228ff4360d0e02d5ace158ff) Thanks [@tqwewe](https://github.com/tqwewe)! - Fix layout gutter none styles
+* [#1894](https://github.com/primer/css/pull/1894) [`d1adf595`](https://github.com/primer/css/commit/d1adf595308afb97f83c5ca172222944189a5961) Thanks [@simurai](https://github.com/simurai)! - Make `pagination` responsive by default
 
 ## 19.2.0
 

package/README.md

@@ -1,5 +1,5 @@
 <p align="center">
-  <img width="300px" src="./docs/src/readme.png">
+  <img width="300px" alt="" src="./docs/src/readme.png">
 </p>
 
 <h1 align="center">Primer CSS</h1>
@@ -14,7 +14,7 @@
     <img alt="" src="https://github.com/primer/css/actions/workflows/ci.yml/badge.svg">
   </a>
   <a aria-label="contributors graph" href="https://github.com/primer/css/graphs/contributors">
-    <img src="https://img.shields.io/github/contributors/primer/css.svg">
+    <img alt="" src="https://img.shields.io/github/contributors/primer/css.svg">
   </a>
   <a aria-label="last commit" href="https://github.com/primer/css/commits/main">
     <img alt="" src="https://img.shields.io/github/last-commit/primer/css.svg">

package/actionlist/action-list-item-divider.scss

@@ -4,7 +4,6 @@
   // has children
   &:not(:empty) {
     display: flex;
-    // stylelint-disable-next-line primer/spacing
     padding: ($spacer-1 * 1.5) $spacer-2;
     font-size: $font-size-small;
     font-weight: $font-weight-bold;
@@ -14,6 +13,7 @@
 
   // no children
   &:empty {
+    display: block;
     height: 1px;
     padding: 0;
     // stylelint-disable-next-line primer/spacing
@@ -22,6 +22,12 @@
     background: var(--color-action-list-item-inline-divider);
     border: 0;
   }
+
+  .ActionList-sectionDivider-title {
+    font-size: $font-size-small;
+    font-weight: $font-weight-bold;
+    color: var(--color-fg-muted);
+  }
 }
 
 .ActionList-sectionDivider--filled {

package/actionlist/action-list-item.scss

@@ -24,17 +24,10 @@
   list-style: none;
   background-color: transparent;
   border-radius: $border-radius;
-  touch-action: manipulation;
-  -webkit-tap-highlight-color: transparent;
 
   &:hover,
   &:active {
     cursor: pointer;
-
-    // a href
-    .ActionList-content {
-      text-decoration: none;
-    }
   }
 
   // only hover li without list as children
@@ -92,6 +85,11 @@
         + .ActionList-item .ActionList-item-label::before {
           visibility: hidden;
         }
+
+        .ActionList-item-descriptionWrap--inline::before,
+        + .ActionList-item .ActionList-item-descriptionWrap--inline::before {
+          visibility: hidden;
+        }
       }
     }
     // stylelint-disable-next-line no-duplicate-selectors
@@ -152,98 +150,6 @@
     }
   }
 
-  // collapsible item [aria-expanded]
-
-  // nesting (single level)
-  // target items inside expanded subgroups
-  &[aria-expanded] {
-    .ActionList--subGroup {
-      @media screen and (prefers-reduced-motion: no-preference) {
-        transition: opacity 160ms cubic-bezier(0.25, 1, 0.5, 1), transform 160ms cubic-bezier(0.25, 1, 0.5, 1);
-      }
-
-      .ActionList-content {
-        padding-left: $spacer-4;
-      }
-    }
-
-    // has 16px leading visual
-    .ActionList-content--visual16 + .ActionList--subGroup {
-      .ActionList-content {
-        padding-left: $spacer-5;
-      }
-    }
-
-    // has 20px leading visual
-    .ActionList-content--visual20 + .ActionList--subGroup {
-      .ActionList-content {
-        padding-left: $spacer-2 * 4.5; // 36px
-      }
-    }
-
-    // has 24px leading visual
-    .ActionList-content--visual24 + .ActionList--subGroup {
-      .ActionList-content {
-        padding-left: $spacer-6;
-      }
-    }
-  }
-
-  &[aria-expanded='true'] {
-    .ActionList-item-collapseIcon {
-      transition: transform 120ms linear;
-      transform: scaleY(-1);
-    }
-
-    .ActionList--subGroup {
-      height: auto;
-      overflow: visible;
-      visibility: visible;
-      opacity: 1;
-      transform: translateY(0);
-    }
-
-    &.ActionList-item--hasActiveSubItem {
-      > .ActionList-content > .ActionList-item-label {
-        font-weight: $font-weight-bold;
-      }
-    }
-  }
-
-  &[aria-expanded='false'] {
-    .ActionList-item-collapseIcon {
-      transition: transform 120ms linear;
-      transform: scaleY(1);
-    }
-
-    .ActionList--subGroup {
-      height: 0;
-      overflow: hidden;
-      visibility: hidden;
-      opacity: 0;
-      transform: translateY(-$spacer-3);
-    }
-
-    // show active indicator on parent collapse if child is active
-    &.ActionList-item--hasActiveSubItem {
-      background: var(--color-action-list-item-default-selected-bg);
-
-      .ActionList-item-label {
-        font-weight: $font-weight-bold;
-      }
-
-      &::before,
-      + .ActionList-item::before {
-        visibility: hidden;
-      }
-
-      // blue accent line
-      &::after {
-        @include activeIndicatorLine;
-      }
-    }
-  }
-
   // checkbox item [aria-checked]
   // listbox [aria-selected]
 
@@ -358,26 +264,9 @@
       }
     }
 
-    &:active {
-      background: var(--color-action-list-item-danger-active-bg);
-    }
-  }
-
-  // disabled
-  &[aria-disabled='true'] {
-    .ActionList-item-label,
-    .ActionList-item-description {
-      color: var(--color-primer-fg-disabled);
-    }
-
-    .ActionList-item-visual {
-      fill: var(--color-primer-fg-disabled);
-    }
-
-    @media (hover: hover) {
-      &:hover {
-        cursor: not-allowed;
-        background-color: transparent;
+    .ActionList-content {
+      &:active {
+        background: var(--color-action-list-item-danger-active-bg);
       }
     }
   }
@@ -389,19 +278,26 @@
   }
 }
 
-// span or a href
+// button or a href
 .ActionList-content {
   position: relative;
   display: grid;
+  width: 100%;
   // stylelint-disable-next-line primer/spacing
   padding: $actionList-item-padding-vertical $actionList-item-padding-horizontal;
   font-size: $body-font-size;
   font-weight: $font-weight-normal;
   color: var(--color-fg-default);
+  text-align: left;
   user-select: none;
-  touch-action: manipulation;
+  background-color: transparent;
+  // stylelint-disable-next-line declaration-property-value-disallowed-list
+  border: none;
   border-radius: $border-radius;
   transition: $actionList-item-bg-transition;
+  touch-action: manipulation;
+  touch-action: manipulation;
+  -webkit-tap-highlight-color: transparent;
   grid-template-rows: min-content;
   grid-template-areas: 'leadingAction leadingVisual label trailingVisual trailingAction';
   grid-template-columns: min-content min-content minmax(0, auto) min-content min-content;
@@ -412,10 +308,127 @@
     margin-right: $spacer-2;
   }
 
+  // state
+
+  &:hover {
+    text-decoration: none;
+  }
+
   &:focus-visible {
     @include focusOutline;
   }
 
+  // disabled
+  &[aria-disabled='true'] {
+    .ActionList-item-label,
+    .ActionList-item-description {
+      color: var(--color-primer-fg-disabled);
+    }
+
+    .ActionList-item-visual {
+      fill: var(--color-primer-fg-disabled);
+    }
+
+    @media (hover: hover) {
+      &:hover {
+        cursor: not-allowed;
+        background-color: transparent;
+      }
+    }
+  }
+
+  // collapsible item [aria-expanded]
+
+  // nesting (single level)
+  // target items inside expanded subgroups
+  &[aria-expanded] {
+    + .ActionList--subGroup {
+      @media screen and (prefers-reduced-motion: no-preference) {
+        transition: opacity 160ms cubic-bezier(0.25, 1, 0.5, 1), transform 160ms cubic-bezier(0.25, 1, 0.5, 1);
+      }
+
+      .ActionList-content {
+        padding-left: $spacer-4;
+      }
+    }
+
+    // has 16px leading visual
+    &.ActionList-content--visual16 + .ActionList--subGroup {
+      .ActionList-content {
+        padding-left: $spacer-5;
+      }
+    }
+
+    // has 20px leading visual
+    &.ActionList-content--visual20 + .ActionList--subGroup {
+      .ActionList-content {
+        padding-left: $spacer-2 * 4.5; // 36px
+      }
+    }
+
+    // has 24px leading visual
+    &.ActionList-content--visual24 + .ActionList--subGroup {
+      .ActionList-content {
+        padding-left: $spacer-6;
+      }
+    }
+  }
+
+  &[aria-expanded='true'] {
+    .ActionList-item-collapseIcon {
+      transition: transform 120ms linear;
+      transform: scaleY(-1);
+    }
+
+    + .ActionList--subGroup {
+      height: auto;
+      overflow: visible;
+      visibility: visible;
+      opacity: 1;
+      transform: translateY(0);
+    }
+
+    &.ActionList-content--hasActiveSubItem {
+      > .ActionList-item-label {
+        font-weight: $font-weight-bold;
+      }
+    }
+  }
+
+  &[aria-expanded='false'] {
+    .ActionList-item-collapseIcon {
+      transition: transform 120ms linear;
+      transform: scaleY(1);
+    }
+
+    + .ActionList--subGroup {
+      height: 0;
+      overflow: hidden;
+      visibility: hidden;
+      opacity: 0;
+      transform: translateY(-$spacer-3);
+    }
+
+    // show active indicator on parent collapse if child is active
+    &.ActionList-content--hasActiveSubItem {
+      background: var(--color-action-list-item-default-selected-bg);
+
+      .ActionList-item-label {
+        font-weight: $font-weight-bold;
+      }
+
+      &::before,
+      + .ActionList-item::before {
+        visibility: hidden;
+      }
+
+      // blue accent line
+      &::after {
+        @include activeIndicatorLine;
+      }
+    }
+  }
+
   // sizes
 
   &.ActionList-content--sizeMedium {
@@ -488,6 +501,7 @@
 
 // inline
 .ActionList-item-descriptionWrap--inline {
+  position: relative;
   flex-direction: row;
   align-items: baseline;
 

package/actionlist/action-list-tree.scss

@@ -1,9 +1,21 @@
+// stylelint-disable max-nesting-depth, selector-max-compound-selectors, selector-max-specificity, no-duplicate-selectors, selector-max-type
 // tree-view variant
 // renders ActionList with default styling for tree-view
 // collapse/expand icons presents as leadingActions, rotate 90deg
 // connecting vertical lines between collapse groups
 // consistent font-size between nested groups
 
+@mixin activeIndicatorLine {
+  position: absolute;
+  top: calc(50% - 12px);
+  left: -$actionList-item-padding-horizontal;
+  width: $spacer-1;
+  height: $spacer-4;
+  content: '';
+  background: var(--color-accent-fg);
+  border-radius: $border-radius;
+}
+
 @mixin treeConnectingLine($left) {
   position: absolute;
   left: $left;
@@ -21,6 +33,94 @@
   }
 
   .ActionList-item {
+    // class for single tree items not within a group
+    &.ActionList-item--singleton {
+      .ActionList-content {
+        padding-left: $spacer-5;
+      }
+    }
+
+    // start: copy from ActionList proper- backwards compatible for treeview with different markup structure
+    &[aria-expanded] {
+      .ActionList--subGroup {
+        @media screen and (prefers-reduced-motion: no-preference) {
+          transition: opacity 160ms cubic-bezier(0.25, 1, 0.5, 1), transform 160ms cubic-bezier(0.25, 1, 0.5, 1);
+        }
+
+        .ActionList-content {
+          padding-left: $spacer-4;
+        }
+      }
+
+      // has 16px leading visual
+      .ActionList-content--visual16 + .ActionList--subGroup {
+        .ActionList-content {
+          padding-left: $spacer-5;
+        }
+      }
+
+      // has 20px leading visual
+      .ActionList-content--visual20 + .ActionList--subGroup {
+        .ActionList-content {
+          padding-left: $spacer-2 * 4.5; // 36px
+        }
+      }
+
+      // has 24px leading visual
+      .ActionList-content--visual24 + .ActionList--subGroup {
+        .ActionList-content {
+          padding-left: $spacer-6;
+        }
+      }
+    }
+
+    &[aria-expanded='true'] {
+      .ActionList-item-collapseIcon {
+        transition: transform 120ms linear;
+        transform: scaleY(-1);
+      }
+
+      .ActionList--subGroup {
+        height: auto;
+        overflow: visible;
+        visibility: visible;
+        opacity: 1;
+        transform: translateY(0);
+      }
+    }
+
+    &[aria-expanded='false'] {
+      .ActionList-item-collapseIcon {
+        transition: transform 120ms linear;
+        transform: scaleY(1);
+      }
+
+      .ActionList--subGroup {
+        height: 0;
+        overflow: hidden;
+        visibility: hidden;
+        opacity: 0;
+        transform: translateY(-$spacer-3);
+      }
+
+      // show active indicator on parent collapse if child is active
+      // this class changed in ActionList proper
+      &.ActionList-item--hasActiveSubItem {
+        background: var(--color-action-list-item-default-selected-bg);
+
+        &::before,
+        + .ActionList-item::before {
+          visibility: hidden;
+        }
+
+        // blue accent line
+        &::after {
+          @include activeIndicatorLine;
+        }
+      }
+    }
+    // end copy
+
     // nesting (infinate levels)
     // target items inside expanded subgroup
     &[aria-expanded] {
@@ -28,7 +128,6 @@
         position: relative;
 
         // --ActionList-tree-depth is defined as an inline style referencing the aria-level of each item ie: aria-level="2"
-        // stylelint-disable-next-line selector-max-specificity, max-nesting-depth, selector-max-compound-selectors
         .ActionList-content {
           // stylelint-disable-next-line primer/spacing
           padding-left: calc(#{$spacer-2} * var(--ActionList-tree-depth));
@@ -55,11 +154,9 @@
   // expand/collapse group
   .ActionList-item--hasSubItem {
     .ActionList-item--subItem:not(.ActionList-item--hasSubItem) {
-      // stylelint-disable-next-line selector-max-specificity, selector-max-compound-selectors
       .ActionList-content {
         // increase child padding by targeting content first child span (add to ActionList-content padding, not replace)
         // creates a slight indent of child items
-        // stylelint-disable-next-line selector-max-specificity, selector-max-type, max-nesting-depth, selector-max-compound-selectors
         > span:first-child {
           padding-left: $spacer-4;
         }
@@ -70,7 +167,6 @@
   // first subitem
   > [aria-level='1'].ActionList-item--hasSubItem {
     > .ActionList--subGroup {
-      // stylelint-disable-next-line selector-max-specificity
       &::before {
         @include treeConnectingLine($left: $spacer-3);
       }
@@ -81,7 +177,6 @@
   // center connecting line with parent (line is 1px (8px - 1px)
   .ActionList-item--hasSubItem:not([aria-level='1']) {
     > .ActionList--subGroup {
-      // stylelint-disable-next-line selector-max-specificity
       &::before {
         @include treeConnectingLine(
           $left: calc(#{$spacer-2} * (var(--ActionList-tree-depth)) + #{$spacer-2 - $border-width})

package/actionlist/action-list.scss

@@ -8,6 +8,11 @@
   padding: 0;
 }
 
+// nested list within main ActionList
+.ActionList--subGroup {
+  padding: 0;
+}
+
 // dividers
 
 .ActionList--divided {
@@ -21,6 +26,24 @@
     background: var(--color-action-list-item-inline-divider);
   }
 
+  // if descriptionWrap--inline exists, move pseudo divider to wrapper
+  .ActionList-item-descriptionWrap--inline {
+    &::before {
+      position: absolute;
+      top: -$actionList-item-padding-vertical;
+      display: block;
+      width: 100%;
+      height: $border-width;
+      content: '';
+      background: var(--color-action-list-item-inline-divider);
+    }
+
+    // unset the default label pseudo
+    .ActionList-item-label::before {
+      content: unset;
+    }
+  }
+
   // hide divider if item is active
   .ActionList-item--navActive {
     // stylelint-disable-next-line selector-max-specificity, selector-max-compound-selectors
@@ -36,3 +59,9 @@
 .ActionList-sectionDivider + .ActionList-item .ActionList-item-label::before {
   visibility: hidden;
 }
+
+// hide if item is first of type with label::before, or is the first item after a sectionDivider
+.ActionList-item:first-of-type .ActionList-item-descriptionWrap--inline::before,
+.ActionList-sectionDivider + .ActionList-item .ActionList-item-descriptionWrap--inline::before {
+  visibility: hidden;
+}

package/alerts/flash.scss

@@ -141,35 +141,6 @@
   background-color: var(--color-canvas-default);
 }
 
-// A flash banner inside an ApplicationFrame tray region
-
-.flash-tray {
-  margin: 0 -$border-width;
-  padding: 12px $spacer-3;
-  border-radius: 0;
-
-  @include breakpoint(md) {
-    margin: 0;
-    border-radius: $border-radius-2;
-    animation: flash-tray--appear 200ms 120ms both ease-out;
-
-    & + .flash-tray {
-      margin-top: $spacer-2;
-      animation-delay: 200ms;
-    }
-  }
-
-  @keyframes flash-tray--appear {
-    from {
-      opacity: 0;
-      transform: translateY(-$spacer-4);
-    }
-    to {
-      opacity: 1;
-    }
-  }
-}
-
 // FIXME deprecate this
 .warning {
   padding: $em-spacer-5;

package/base/kbd.scss

@@ -3,7 +3,6 @@
 
 kbd {
   display: inline-block;
-  // stylelint-disable-next-line primer/spacing
   padding: ($spacer-1 - 1) ($spacer-1 + 1);
   font: 11px $mono-font;
   // stylelint-disable-next-line primer/typography

package/base/normalize.scss

@@ -225,7 +225,7 @@ code,
 kbd,
 pre,
 samp {
-  font-family: monospace, monospace; /* 1 */
+  font-family: monospace; /* 1 */
   font-size: 1em; /* 2 */
 }