@primer/css 0.0.0-20220120184157 → 0.0.0-2022020193741

package/labels/index.scss

@@ -1,5 +1,6 @@
 @import '../support/index.scss';
 @import './mixins.scss';
+
 @import './issue-labels.scss';
 @import './labels.scss';
 @import './states.scss';

package/labels/labels.scss

@@ -10,7 +10,6 @@
 .label, // TODO: Deprecte
 .Label {
   @include labels-base;
-
   border-color: var(--color-border-default);
 
   &:hover {

package/layout/index.scss

@@ -1,7 +1,7 @@
 @import '../support/index.scss';
 @import './mixins.scss';
+
 @import './container.scss';
 @import './grid.scss';
 @import './grid-offset.scss';
 @import './layout.scss';
-@import './page-layout.scss';

package/layout/layout.scss

@@ -2,22 +2,21 @@
 
 .Layout {
   display: grid;
-
   --Layout-sidebar-width: #{map-get($sidebar-width, 'sm')};
   --Layout-gutter: 16px;
 
-  @media (max-width: calc(#{$width-sm} - 0.02px)) {
+  @media (max-width: calc(#{$width-sm} - 1px)) {
     @include flow-as-row;
   }
 
   &.Layout--flowRow-until-md {
-    @media (max-width: calc(#{$width-md} - 0.02px)) {
+    @media (max-width: calc(#{$width-md} - 1px)) {
       @include flow-as-row;
     }
   }
 
   &.Layout--flowRow-until-lg {
-    @media (max-width: calc(#{$width-lg} - 0.02px)) {
+    @media (max-width: calc(#{$width-lg} - 1px)) {
       @include flow-as-row;
     }
   }
@@ -25,7 +24,8 @@
   // Flow as column
 
   grid-auto-flow: column;
-  grid-template-columns: auto 0 minmax(0, calc(100% - var(--Layout-sidebar-width) - var(--Layout-gutter))); // sidebar column, separator, main column
+  grid-template-columns: auto 0 1fr; // sidebar column, separator, main column
+  // stylelint-disable-next-line primer/no-undefined-vars
   grid-gap: var(--Layout-gutter);
 
   .Layout-sidebar {
@@ -101,7 +101,7 @@
   }
 
   &.Layout--sidebarPosition-end {
-    grid-template-columns: minmax(0, calc(100% - var(--Layout-sidebar-width) - var(--Layout-gutter))) 0 auto;
+    grid-template-columns: 1fr 0 auto;
 
     .Layout-main {
       grid-column: 1;
@@ -146,6 +146,7 @@
 }
 
 .Layout-sidebar {
+  // stylelint-disable-next-line primer/no-undefined-vars
   width: var(--Layout-sidebar-width);
 }
 
@@ -168,14 +169,17 @@
   }
 
   .Layout-main-centered-md {
+    // stylelint-disable-next-line primer/no-undefined-vars
     max-width: calc(#{$container-md} + var(--Layout-sidebar-width) + var(--Layout-gutter));
   }
 
   .Layout-main-centered-lg {
+    // stylelint-disable-next-line primer/no-undefined-vars
     max-width: calc(#{$container-lg} + var(--Layout-sidebar-width) + var(--Layout-gutter));
   }
 
   .Layout-main-centered-xl {
+    // stylelint-disable-next-line primer/no-undefined-vars
     max-width: calc(#{$container-xl} + var(--Layout-sidebar-width) + var(--Layout-gutter));
   }
 }

package/layout/mixins.scss

@@ -1,4 +1,4 @@
-// Layout alpha mixins
+// Layout mixins
 
 @mixin flow-as-row {
   grid-auto-flow: row;
@@ -7,9 +7,9 @@
   .Layout-sidebar,
   .Layout-divider,
   .Layout-main {
-    width: 100% !important;
-    grid-column: 1 !important;
-  }
+      width: 100% !important;
+      grid-column: 1 !important;
+    }
 
   &.Layout--sidebarPosition-flowRow-start {
     .Layout-sidebar {
@@ -77,29 +77,3 @@
     }
   }
 }
-
-// Layout beta mixins
-
-// responsive region dividers
-
-@mixin Layout-line-divider {
-  position: absolute;
-  left: calc(var(--Layout-outer-spacing-x) * -1);
-  display: block;
-  width: calc(100% + (var(--Layout-outer-spacing-x) * 2));
-  height: 1px;
-  content: '';
-  background-color: $Layout-divider-color;
-}
-
-@mixin Layout-filled-divider {
-  position: absolute;
-  bottom: calc(#{$spacer-2} * -1); // -8px
-  left: calc(var(--Layout-outer-spacing-x) * -1);
-  display: block;
-  width: calc(100% + (var(--Layout-outer-spacing-x) * 2));
-  height: #{$spacer-2}; // 8px
-  content: '';
-  background-color: var(--color-canvas-inset);
-  box-shadow: inset 0 1px $Layout-divider-color, inset 0 -1px $Layout-divider-color;
-}

package/markdown/images.scss

@@ -10,12 +10,12 @@
     box-sizing: content-box;
     background-color: var(--color-canvas-default);
 
-    &[align='right'] {
+    &[align=right] {
       // stylelint-disable-next-line primer/spacing
       padding-left: 20px;
     }
 
-    &[align='left'] {
+    &[align=left] {
       // stylelint-disable-next-line primer/spacing
       padding-right: 20px;
     }

package/marketing/buttons/button.scss

@@ -38,7 +38,6 @@
   }
 
   &:hover {
-    text-decoration: none;
     box-shadow: var(--color-mktg-btn-shadow-hover) !important;
   }
 
@@ -69,13 +68,6 @@
       opacity: 0.5 !important;
     }
   }
-
-  &.disabled,
-  &[disabled] {
-    pointer-events: none;
-    cursor: default;
-    opacity: 0.5;
-  }
 }
 
 .btn-muted-mktg {

package/marketing/index.scss

@@ -11,5 +11,4 @@
 // marketing specific css modules
 @import './type/index.scss';
 @import './buttons/index.scss';
-@import './links/index.scss';
 @import './utilities/index.scss';

package/marketing/type/typography.scss

@@ -21,7 +21,6 @@
 
     font-size: map-get($pairing, 'size') !important;
     line-height: map-get($pairing, 'lh') !important;
-
     @if (map-get($pairing, 'size') >= $mktg-header-weight-threshold) { font-weight: $mktg-header-weight-large !important; }
 
     @if (nth($sizes, 1) != nth($sizes, 2)) {
@@ -76,9 +75,7 @@
 
     font-size: map-get($pairing, 'size') !important;
     line-height: map-get($pairing, 'lh') !important;
-
     @if (map-get($pairing, 'size') >= $mktg-body-spacing-threshold) { letter-spacing: $mktg-body-spacing-large !important; }
-
     @if (map-get($pairing, 'size') >= $mktg-body-weight-threshold) { font-weight: $font-weight-semibold; }
 
     @if (nth($sizes, 1) != nth($sizes, 2)) {

package/marketing/utilities/animations.scss

@@ -7,45 +7,3 @@
     transform: scale3d(1.025, 1.025, 1.025);
   }
 }
-
-// Animated arrow symbol, used in marketing links, buttons, etc.
-.btn-mktg,
-.link-mktg,
-.arrow-target-mktg {
-  .octicon {
-    width: 1em;
-    height: 1em;
-  }
-
-  .arrow-symbol-mktg {
-    transition: transform 0.2s;
-    transform: translateX(0);
-
-    // stylelint-disable-next-line selector-max-type
-    path:last-child {
-      stroke-dasharray: 10;
-      stroke-dashoffset: 10;
-      transition: stroke-dashoffset 0.2s;
-    }
-  }
-
-  @media screen and (prefers-reduced-motion: no-preference) {
-    &:hover,
-    &:focus {
-      .arrow-symbol-mktg {
-        transform: translateX(4px);
-
-        // stylelint-disable-next-line selector-max-type, selector-max-specificity, max-nesting-depth
-        path:last-child {
-          stroke-dashoffset: 20;
-        }
-      }
-    }
-
-    &:active {
-      .arrow-symbol-mktg {
-        transform: translateX(6px);
-      }
-    }
-  }
-}

package/navigation/filter-list.scss

@@ -41,8 +41,8 @@
   }
 
   &.selected,
-  &[aria-selected='true'],
-  &[aria-current]:not([aria-current='false']) {
+  &[aria-selected=true],
+  &[aria-current]:not([aria-current=false]) {
     color: var(--color-fg-on-emphasis);
     background-color: var(--color-accent-emphasis);
   }

package/navigation/menu.scss

@@ -49,8 +49,8 @@
   }
 
   &.selected,
-  &[aria-selected='true'],
-  &[aria-current]:not([aria-current='false']) {
+  &[aria-selected=true],
+  &[aria-current]:not([aria-current=false]) {
     cursor: default;
     background-color: var(--color-menu-bg-active);
 

package/navigation/sidenav.scss

@@ -59,7 +59,7 @@
   background-color: var(--color-canvas-subtle);
 }
 
-.SideNav-item[aria-current]:not([aria-current='false']),
+.SideNav-item[aria-current]:not([aria-current=false]),
 .SideNav-item[aria-selected='true'] {
   background-color: var(--color-sidenav-selected-bg);
 
@@ -101,7 +101,7 @@
   outline: none;
 }
 
-.SideNav-subItem[aria-current]:not([aria-current='false']),
+.SideNav-subItem[aria-current]:not([aria-current=false]),
 .SideNav-subItem[aria-selected='true'] {
   font-weight: $font-weight-semibold;
   color: var(--color-fg-default);

package/navigation/subnav.scss

@@ -40,8 +40,8 @@
   }
 
   &.selected,
-  &[aria-selected='true'],
-  &[aria-current]:not([aria-current='false']) {
+  &[aria-selected=true],
+  &[aria-current]:not([aria-current=false]) {
     z-index: 2;
     color: var(--color-fg-on-emphasis);
     background-color: var(--color-accent-emphasis);

package/navigation/tabnav.scss

@@ -28,8 +28,8 @@
   transition: color 0.2s cubic-bezier(0.3, 0, 0.5, 1);
 
   &.selected,
-  &[aria-selected='true'],
-  &[aria-current]:not([aria-current='false']) {
+  &[aria-selected=true],
+  &[aria-current]:not([aria-current=false]) {
     color: var(--color-fg-default);
     background-color: var(--color-canvas-default); // cover bottom border
     border-color: var(--color-border-default);

package/navigation/underline-nav.scss

@@ -35,8 +35,8 @@
   }
 
   &.selected,
-  &[role='tab'][aria-selected='true'],
-  &[aria-current]:not([aria-current='false']) {
+  &[role=tab][aria-selected=true],
+  &[aria-current]:not([aria-current=false]) {
     font-weight: $font-weight-bold;
     color: var(--color-fg-default);
     border-bottom-color: var(--color-primer-border-active);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@primer/css",
-  "version": "0.0.0-20220120184157",
+  "version": "0.0.0-2022020193741",
   "description": "The CSS implementation of GitHub's Primer Design System",
   "homepage": "https://primer.style/css",
   "author": "GitHub, Inc.",
@@ -35,36 +35,37 @@
     "storybook": "cd docs && yarn && yarn storybook"
   },
   "dependencies": {
-    "@primer/primitives": "^7.4.0"
+    "@primer/primitives": "^7.2.0"
   },
   "devDependencies": {
     "@changesets/changelog-github": "0.4.2",
-    "@changesets/cli": "2.19.0",
+    "@changesets/cli": "2.18.1",
     "@github/prettier-config": "0.0.4",
     "@koddsson/postcss-sass": "5.0.0",
-    "@primer/stylelint-config": "12.2.0",
-    "autoprefixer": "10.4.1",
+    "@primer/stylelint-config": "12.1.1",
+    "autoprefixer": "10.4.0",
     "cssstats": "4.0.2",
-    "eslint": "8.6.0",
+    "eslint": "8.3.0",
     "eslint-plugin-github": "4.3.5",
-    "eslint-plugin-jest": "25.3.3",
+    "eslint-plugin-jest": "25.3.0",
     "eslint-plugin-prettier": "4.0.0",
     "filesize": "8.0.6",
     "front-matter": "4.0.2",
     "fs-extra": "10.0.0",
     "globby": "12.0.2",
-    "jest": "27.4.5",
+    "jest": "27.4.2",
     "js-yaml": "4.1.0",
-    "postcss": "8.4.5",
+    "postcss": "8.4.4",
     "postcss-calc": "8.0.0",
     "postcss-import": "14.0.2",
     "postcss-load-config": "3.1.0",
     "postcss-scss": "4.0.2",
     "postcss-simple-vars": "6.0.3",
-    "prettier": "2.5.1",
+    "prettier": "2.5.0",
     "semver": "7.3.5",
-    "stylelint": "14.2.0",
-    "table": "6.7.5"
+    "stylelint": "14.1.0",
+    "stylelint-scss": "4.0.0",
+    "table": "6.7.3"
   },
   "jest": {
     "testEnvironment": "node",

package/pagination/pagination.scss

@@ -42,7 +42,7 @@
 
   .current,
   .current:hover,
-  [aria-current]:not([aria-current='false']) {
+  [aria-current]:not([aria-current=false]) {
     color: var(--color-fg-on-emphasis);
     background-color: var(--color-accent-emphasis);
     border-color: transparent;
@@ -50,10 +50,10 @@
 
   .gap,
   .disabled,
-  [aria-disabled='true'],
+  [aria-disabled=true],
   .gap:hover,
   .disabled:hover,
-  [aria-disabled='true']:hover {
+  [aria-disabled=true]:hover {
     color: var(--color-primer-fg-disabled);
     cursor: default;
     border-color: transparent;

package/popover/popover.scss

@@ -196,7 +196,7 @@
 // Responsive Popover
 // For < md it will show full-width anchored to the bottom
 
-@media (max-width: ($width-md - 0.02px)) {
+@media (max-width: ($width-md - 1px)) {
   .Popover {
     position: fixed;
     top: auto !important;

package/select-menu/select-menu.scss

@@ -386,7 +386,7 @@ $SelectMenu-max-height: 480px !default;
 //
 // Visible when a user clicks/taps on a list item
 
-.SelectMenu-item[aria-checked='true'] {
+.SelectMenu-item[aria-checked=true] {
   font-weight: $font-weight-semibold;
   color: var(--color-fg-default);
 
@@ -402,7 +402,7 @@ $SelectMenu-max-height: 480px !default;
 // Prevent list items to be selected
 
 .SelectMenu-item:disabled,
-.SelectMenu-item[aria-disabled='true'] {
+.SelectMenu-item[aria-disabled=true] {
   color: var(--color-primer-fg-disabled);
   pointer-events: none;
 }

package/stylelint.config.cjs

@@ -1,7 +1,16 @@
 module.exports = {
   extends: ['@primer/stylelint-config'],
-  ignoreFiles: ['**/*.js', '**/*.cjs'],
+  plugins: ['stylelint-scss'],
+  customSyntax: require('postcss-scss'),
+  ignoreFiles: ['src/fonts/**/*'],
   rules: {
-    'primer/no-override': false
+    'scss/dollar-variable-default': [true, {ignore: 'local'}],
+    'primer/no-override': false,
+    'primer/colors': true,
+    'primer/borders': true,
+    'primer/spacing': true,
+    'primer/typography': true,
+    'primer/box-shadow': true,
+    'primer/no-undefined-vars': [true, {files: 'node_modules/@primer/primitives/dist/scss/colors*/*.scss'}]
   }
 }

package/support/mixins/color-modes.scss

@@ -8,7 +8,6 @@
       /*! */ // This is a fix for a cssstats bug see https://github.com/cssstats/cssstats/issues/331
     }
   }
-
   @else {
     [data-color-mode="light"][data-light-theme="#{$theme-name}"],
     [data-color-mode="dark"][data-dark-theme="#{$theme-name}"] {
@@ -37,7 +36,6 @@
       @content;
     }
   }
-
   @else {
     [data-color-mode="light"][data-light-theme*="#{$mode}"],
     [data-color-mode="dark"][data-dark-theme*="#{$mode}"] {
@@ -86,7 +84,6 @@
       @if $type == dark {
         $dark-colors: append($dark-colors, (--color-#{$name}, #{$color}));
       }
-
       @else {
         $light-colors: append($light-colors, (--color-#{$name}, #{$color}));
       }

package/support/mixins/misc.scss

@@ -25,9 +25,18 @@
   }
 }
 
-// global focus styles (copy from open PR)
+// if min-width is undefined, return only min-height
+@mixin minTouchTarget($min-height: 48px, $min-width: '') {
+  position: absolute;
+  top: 50%;
+  left: 50%;
+  width: 100%;
+  height: 100%;
+  min-height: $min-height;
+  content: '';
+  transform: translateX(-50%) translateY(-50%);
 
-@mixin focusOutline {
-  outline: 2px solid var(--color-accent-fg);
-  outline-offset: 2px;
+  @if $min-width != '' {
+    min-width: $min-width;
+  }
 }

package/support/mixins/typography.scss

@@ -47,6 +47,7 @@
 
   // 32px on desktop
   @include breakpoint(md) { font-size: $h1-size; }
+
 }
 
 @mixin f2-responsive {
@@ -61,6 +62,7 @@
 
   // 20px on desktop
   @include breakpoint(md) { font-size: $h3-size; }
+
 }
 
 // These use the mixins from above for responsive heading sizes.
@@ -68,18 +70,15 @@
 // couple the responsive font-size with the font-weight.
 @mixin h1-responsive {
   @include f1-responsive;
-
   font-weight: $font-weight-bold;
 }
 
 @mixin h2-responsive {
   @include f2-responsive;
-
   font-weight: $font-weight-bold;
 }
 
 @mixin h3-responsive {
   @include f3-responsive;
-
   font-weight: $font-weight-bold;
 }

package/support/variables/layout.scss

@@ -178,8 +178,9 @@ $sidebar-narrow-width: (
 ) !default;
 
 $sidebar-wide-width: (
+  md: 296px,
   lg: 320px,
-  xl: 336px
+  xl: 344px
 ) !default;
 
 $gutter: (

package/utilities/visibility-display.scss

@@ -14,19 +14,19 @@
 
 // Hide utilities for each breakpoint
 // Each hide utility only applies to one breakpoint range.
-@media (max-width: $width-sm - 0.02px) {
+@media (max-width: $width-sm - 1px) {
   .hide-sm {
     display: none !important;
   }
 }
 
-@media (min-width: $width-sm) and (max-width: $width-md - 0.02px) {
+@media (min-width: $width-sm) and (max-width: $width-md - 1px) {
   .hide-md {
     display: none !important;
   }
 }
 
-@media (min-width: $width-md) and (max-width: $width-lg - 0.02px) {
+@media (min-width: $width-md) and (max-width: $width-lg - 1px) {
   .hide-lg {
     display: none !important;
   }

package/actionlist/action-list-tree.scss

@@ -1,92 +0,0 @@
-// tree-view variant
-// renders ActionList with default styling for tree-view
-// collapse/expand icons presents as leadingActions, rotate 90deg
-// connecting vertical lines between collapse groups
-// consistent font-size between nested groups
-
-@mixin treeConnectingLine($left) {
-  position: absolute;
-  left: $left;
-  width: 1px;
-  height: 100%;
-  content: '';
-  background: var(--color-action-list-item-inline-divider);
-}
-
-.ActionList--tree {
-  --ActionList-tree-depth: 1;
-  // TODO: remove with PVC implementation
-  .ActionList-item--subItem > .ActionList-content {
-    font-size: $body-font-size;
-  }
-
-  .ActionList-item {
-    // nesting (infinate levels)
-    // target items inside expanded subgroup
-    &[aria-expanded] {
-      .ActionList--subGroup {
-        position: relative;
-
-        // --ActionList-tree-depth is defined as an inline style referencing the aria-level of each item ie: aria-level="2"
-        // stylelint-disable-next-line selector-max-specificity, max-nesting-depth, selector-max-compound-selectors
-        .ActionList-content {
-          // stylelint-disable-next-line primer/spacing
-          padding-left: calc(#{$spacer-2} * var(--ActionList-tree-depth));
-        }
-      }
-    }
-
-    // tree-view specific collapse icon positioning/animation
-    &[aria-expanded='true'] {
-      .ActionList-item-collapseIcon {
-        transition: transform 120ms linear;
-        transform: rotate(0deg);
-      }
-    }
-
-    &[aria-expanded='false'] {
-      .ActionList-item-collapseIcon {
-        transition: transform 120ms linear;
-        transform: rotate(-90deg);
-      }
-    }
-  }
-
-  // expand/collapse group
-  .ActionList-item--hasSubItem {
-    .ActionList-item--subItem:not(.ActionList-item--hasSubItem) {
-      // stylelint-disable-next-line selector-max-specificity, selector-max-compound-selectors
-      .ActionList-content {
-        // increase child padding by targeting content first child span (add to ActionList-content padding, not replace)
-        // creates a slight indent of child items
-        // stylelint-disable-next-line selector-max-specificity, selector-max-type, max-nesting-depth, selector-max-compound-selectors
-        > span:first-child {
-          padding-left: $spacer-4;
-        }
-      }
-    }
-  }
-
-  // first subitem
-  > [aria-level='1'].ActionList-item--hasSubItem {
-    > .ActionList--subGroup {
-      // stylelint-disable-next-line selector-max-specificity
-      &::before {
-        @include treeConnectingLine($left: $spacer-3);
-      }
-    }
-  }
-
-  // all other subitems
-  // center connecting line with parent (line is 1px (8px - 1px)
-  .ActionList-item--hasSubItem:not([aria-level='1']) {
-    > .ActionList--subGroup {
-      // stylelint-disable-next-line selector-max-specificity
-      &::before {
-        @include treeConnectingLine(
-          $left: calc(#{$spacer-2} * (var(--ActionList-tree-depth)) + #{$spacer-2 - $border-width})
-        );
-      }
-    }
-  }
-}