@primer/components 32.1.1-rc.8eccc94b → 33.0.0-rc.af3001e7

package/src/Spinner.tsx

@@ -1,6 +1,5 @@
 import React from 'react'
 import styled from 'styled-components'
-import {COMMON, SystemCommonProps} from './constants'
 import sx, {SxProp} from './sx'
 import {ComponentProps} from './utils/types'
 
@@ -40,7 +39,7 @@ function Spinner({size: sizeKey = 'medium', ...props}: SpinnerInternalProps) {
   )
 }
 
-const StyledSpinner = styled(Spinner)<SystemCommonProps & SxProp>`
+const StyledSpinner = styled(Spinner)<SxProp>`
   @keyframes rotate-keyframes {
     100% {
       transform: rotate(360deg);
@@ -49,7 +48,6 @@ const StyledSpinner = styled(Spinner)<SystemCommonProps & SxProp>`
 
   animation: rotate-keyframes 1s linear infinite;
 
-  ${COMMON}
   ${sx}
 `
 

package/src/__tests__/Avatar.test.tsx

@@ -39,6 +39,6 @@ describe('Avatar', () => {
   })
 
   it('respects margin props', () => {
-    expect(render(<Avatar m={2} src="primer.png" alt="" />)).toHaveStyleRule('margin', px(theme.space[2]))
+    expect(render(<Avatar src="primer.png" alt="" sx={{m: 2}} />)).toHaveStyleRule('margin', px(theme.space[2]))
   })
 })

package/src/__tests__/Avatar.types.test.tsx

@@ -0,0 +1,11 @@
+import React from 'react'
+import Avatar from '../Avatar'
+
+export function shouldAcceptCallWithNoProps() {
+  return <Avatar src="https://avatars.githubusercontent.com/primer" />
+}
+
+export function shouldNotAcceptSystemProps() {
+  // @ts-expect-error system props should not be accepted
+  return <Avatar src="https://avatars.githubusercontent.com/primer" backgroundColor="thistle" />
+}

package/src/__tests__/BranchName.types.test.tsx

@@ -0,0 +1,11 @@
+import React from 'react'
+import BranchName from '../BranchName'
+
+export function shouldAcceptCallWithNoProps() {
+  return <BranchName />
+}
+
+export function shouldNotAcceptSystemProps() {
+  // @ts-expect-error system props should not be accepted
+  return <BranchName backgroundColor="thistle" />
+}

package/src/__tests__/Details.types.test.tsx

@@ -0,0 +1,11 @@
+import React from 'react'
+import Details from '../Details'
+
+export function shouldAcceptCallWithNoProps() {
+  return <Details />
+}
+
+export function shouldNotAcceptSystemProps() {
+  // @ts-expect-error system props should not be accepted
+  return <Details backgroundColor="thistle" />
+}

package/src/__tests__/Heading.test.tsx

@@ -4,6 +4,7 @@ import {render, behavesAsComponent, checkExports} from '../utils/testing'
 import {render as HTMLRender, cleanup} from '@testing-library/react'
 import {axe, toHaveNoViolations} from 'jest-axe'
 import 'babel-polyfill'
+import ThemeProvider from '../ThemeProvider'
 expect.extend(toHaveNoViolations)
 
 const theme = {
@@ -48,44 +49,89 @@ describe('Heading', () => {
   })
 
   it('respects fontWeight', () => {
-    expect(render(<Heading fontWeight="bold" theme={theme} />)).toHaveStyleRule('font-weight', theme.fontWeights.bold)
-    expect(render(<Heading fontWeight="normal" theme={theme} />)).toHaveStyleRule(
-      'font-weight',
-      theme.fontWeights.normal
-    )
-    expect(render(<Heading fontWeight="semibold" theme={theme} />)).toHaveStyleRule(
-      'font-weight',
-      theme.fontWeights.semibold
-    )
-    expect(render(<Heading fontWeight="light" theme={theme} />)).toHaveStyleRule('font-weight', theme.fontWeights.light)
+    expect(
+      render(
+        <ThemeProvider theme={theme}>
+          <Heading sx={{fontWeight: 'bold'}} />
+        </ThemeProvider>
+      )
+    ).toHaveStyleRule('font-weight', theme.fontWeights.bold)
+    expect(
+      render(
+        <ThemeProvider theme={theme}>
+          <Heading sx={{fontWeight: 'normal'}} />
+        </ThemeProvider>
+      )
+    ).toHaveStyleRule('font-weight', theme.fontWeights.normal)
+    expect(
+      render(
+        <ThemeProvider theme={theme}>
+          <Heading sx={{fontWeight: 'semibold'}} />
+        </ThemeProvider>
+      )
+    ).toHaveStyleRule('font-weight', theme.fontWeights.semibold)
+    expect(
+      render(
+        <ThemeProvider theme={theme}>
+          <Heading sx={{fontWeight: 'light'}} />
+        </ThemeProvider>
+      )
+    ).toHaveStyleRule('font-weight', theme.fontWeights.light)
   })
 
   it('respects lineHeight', () => {
-    expect(render(<Heading lineHeight="normal" theme={theme} />)).toHaveStyleRule(
-      'line-height',
-      String(theme.lineHeights.normal)
-    )
-    expect(render(<Heading lineHeight="condensed" theme={theme} />)).toHaveStyleRule(
-      'line-height',
-      String(theme.lineHeights.condensed)
-    )
-    expect(render(<Heading lineHeight="condensedUltra" theme={theme} />)).toHaveStyleRule(
-      'line-height',
-      String(theme.lineHeights.condensedUltra)
-    )
+    expect(
+      render(
+        <ThemeProvider theme={theme}>
+          <Heading sx={{lineHeight: 'normal'}} />
+        </ThemeProvider>
+      )
+    ).toHaveStyleRule('line-height', String(theme.lineHeights.normal))
+    expect(
+      render(
+        <ThemeProvider theme={theme}>
+          <Heading sx={{lineHeight: 'condensed'}} />
+        </ThemeProvider>
+      )
+    ).toHaveStyleRule('line-height', String(theme.lineHeights.condensed))
+    expect(
+      render(
+        <ThemeProvider theme={theme}>
+          <Heading sx={{lineHeight: 'condensedUltra'}} />
+        </ThemeProvider>
+      )
+    ).toHaveStyleRule('line-height', String(theme.lineHeights.condensedUltra))
   })
 
   it('respects fontFamily="mono"', () => {
-    expect(render(<Heading fontFamily="mono" theme={theme} />)).toHaveStyleRule('font-family', theme.fonts.mono)
+    expect(
+      render(
+        <ThemeProvider theme={theme}>
+          <Heading sx={{fontFamily: 'mono'}} />
+        </ThemeProvider>
+      )
+    ).toHaveStyleRule('font-family', theme.fonts.mono)
   })
 
   it('renders fontSize', () => {
     for (const fontSize of theme.fontSizes) {
-      expect(render(<Heading fontSize={fontSize} theme={theme} />)).toHaveStyleRule('font-size', `${fontSize}`)
+      expect(
+        render(
+          <ThemeProvider theme={theme}>
+            <Heading sx={{fontSize}} />
+          </ThemeProvider>
+        )
+      ).toHaveStyleRule('font-size', `${fontSize}`)
     }
   })
 
   it('respects the "fontStyle" prop', () => {
-    expect(render(<Heading fontStyle="italic" />)).toHaveStyleRule('font-style', 'italic')
+    expect(
+      render(
+        <ThemeProvider theme={theme}>
+          <Heading sx={{fontStyle: 'italic'}} />
+        </ThemeProvider>
+      )
+    ).toHaveStyleRule('font-style', 'italic')
   })
 })

package/src/__tests__/Heading.types.test.tsx

@@ -0,0 +1,11 @@
+import React from 'react'
+import Heading from '../Heading'
+
+export function shouldAcceptCallWithNoProps() {
+  return <Heading />
+}
+
+export function shouldNotAcceptSystemProps() {
+  // @ts-expect-error system props should not be accepted
+  return <Heading backgroundColor="thistle" />
+}

package/src/drafts.ts

@@ -8,3 +8,4 @@
 // Components
 export * from './ActionList2'
 export * from './NewButton'
+export * from './ActionMenu2'