@primer/behaviors 1.3.1 → 1.3.2-rc.b275ab5

package/CHANGELOG.md

@@ -0,0 +1,72 @@
+# @primer/behaviors
+
+## 1.3.2
+
+### Patch Changes
+
+- [#176](https://github.com/primer/behaviors/pull/176) [`5e74867`](https://github.com/primer/behaviors/commit/5e7486702074bbb89e6a7a96a4b0db71d763c74c) Thanks [@jbrown1618](https://github.com/jbrown1618)! - Use a binary search to find the insertion index for new elements managed by the focus zone.
+  For a use case with 1000 elements managed by the focus zone, added one at a time (by react),
+  this takes us from 500,000 calls to `compareDocumentPosition` over 1000ms to 8,000 calls
+  over 16ms.
+
+## 1.3.1
+
+### Patch Changes
+
+- [#155](https://github.com/primer/behaviors/pull/155) [`b14b5ac`](https://github.com/primer/behaviors/commit/b14b5ac5dc2ef9957e4b585e27acf7d5566edd5a) Thanks [@colebemis](https://github.com/colebemis)! - focusZone: Add Backspace key to list of FocusKeys
+
+## 1.3.0
+
+### Minor Changes
+
+- [#152](https://github.com/primer/behaviors/pull/152) [`afaf380`](https://github.com/primer/behaviors/commit/afaf380893cb858e6c85515bb490866d76d3d8b7) Thanks [@colebemis](https://github.com/colebemis)! - focusZone: Add `preventScroll` option
+
+## 1.2.0
+
+### Minor Changes
+
+- [#134](https://github.com/primer/behaviors/pull/134) [`cc5bf8e`](https://github.com/primer/behaviors/commit/cc5bf8e8404594bc6b3ff1493f253b171bfb03c0) Thanks [@jonrohan](https://github.com/jonrohan)! - Add Dimensions behavior
+
+## 1.1.3
+
+### Patch Changes
+
+- [#93](https://github.com/primer/behaviors/pull/93) [`e5aaf68`](https://github.com/primer/behaviors/commit/e5aaf688b084bf6e425c6bdb0963aa50aacf8fa4) Thanks [@siddharthkp](https://github.com/siddharthkp)! - Anchored position: Add check for boundary collision on left side
+
+## 1.1.2
+
+### Patch Changes
+
+- [#78](https://github.com/primer/behaviors/pull/78) [`62e5459`](https://github.com/primer/behaviors/commit/62e545913dae8ca42f88fd6184f190cdf3df9c4c) Thanks [@siddharthkp](https://github.com/siddharthkp)! - Anchored Position: Add alternative alignments to flip to if there isn't enough space
+
+## 1.1.1
+
+### Patch Changes
+
+- [#73](https://github.com/primer/behaviors/pull/73) [`a96d60f`](https://github.com/primer/behaviors/commit/a96d60fdb2a2ffdde71a22ea29fa2c788bf4c6aa) Thanks [@dgreif](https://github.com/dgreif)! - Add `import` conditional export type to the package for better NodeJS ESM compatibility
+
+## 1.1.0
+
+### Minor Changes
+
+- [#52](https://github.com/primer/behaviors/pull/52) [`1aa3027`](https://github.com/primer/behaviors/commit/1aa302782e3c833f9d9c27f602a046e81f05c3e5) Thanks [@owenniblock](https://github.com/owenniblock)! - Update focusTrap to use new methodology after accessibility discussions
+
+## 1.0.3
+
+### Patch Changes
+
+- [#42](https://github.com/primer/behaviors/pull/42) [`41945a3`](https://github.com/primer/behaviors/commit/41945a37ef07da82ce5a29feb03d7a7d96ec76ea) Thanks [@dgreif](https://github.com/dgreif)! - Build both esm and cjs output for the package
+
+## 1.0.2
+
+### Patch Changes
+
+- [#17](https://github.com/primer/behaviors/pull/17) [`9194ba4`](https://github.com/primer/behaviors/commit/9194ba403502b4acba0be03bed1a765c1ba81340) Thanks [@dgreif](https://github.com/dgreif)! - Correct margin orientation for `scrollIntoView`
+
+* [#18](https://github.com/primer/behaviors/pull/18) [`3b4dd41`](https://github.com/primer/behaviors/commit/3b4dd414175417f83bd144939fe74b2a01bc7136) Thanks [@dgreif](https://github.com/dgreif)! - Export utils as submodule
+
+## 1.0.1
+
+### Patch Changes
+
+- [#10](https://github.com/primer/behaviors/pull/10) [`88b6f34`](https://github.com/primer/behaviors/commit/88b6f34bf4874f3c81473020a01a58b197dd6e16) Thanks [@dgreif](https://github.com/dgreif)! - Set up changesets

package/dist/cjs/focus-zone.js

@@ -190,8 +190,7 @@ function focusZone(container, settings) {
         if (filteredElements.length === 0) {
             return;
         }
-        const insertIndex = focusableElements.findIndex(e => (e.compareDocumentPosition(filteredElements[0]) & Node.DOCUMENT_POSITION_PRECEDING) > 0);
-        focusableElements.splice(insertIndex === -1 ? focusableElements.length : insertIndex, 0, ...filteredElements);
+        focusableElements.splice(findInsertionIndex(filteredElements), 0, ...filteredElements);
         for (const element of filteredElements) {
             if (!savedTabIndex.has(element)) {
                 savedTabIndex.set(element, element.getAttribute('tabindex'));
@@ -202,6 +201,27 @@ function focusZone(container, settings) {
             updateFocusedElement(getFirstFocusableElement());
         }
     }
+    function findInsertionIndex(elementsToInsert) {
+        const firstElementToInsert = elementsToInsert[0];
+        if (focusableElements.length === 0)
+            return 0;
+        let iMin = 0;
+        let iMax = focusableElements.length - 1;
+        while (iMin <= iMax) {
+            const i = Math.floor((iMin + iMax) / 2);
+            const element = focusableElements[i];
+            if (followsInDocument(firstElementToInsert, element)) {
+                iMax = i - 1;
+            }
+            else {
+                iMin = i + 1;
+            }
+        }
+        return iMin;
+    }
+    function followsInDocument(first, second) {
+        return (second.compareDocumentPosition(first) & Node.DOCUMENT_POSITION_PRECEDING) > 0;
+    }
     function endFocusManagement(...elements) {
         for (const element of elements) {
             const focusableElementIndex = focusableElements.indexOf(element);

package/dist/esm/focus-zone.js

@@ -187,8 +187,7 @@ export function focusZone(container, settings) {
         if (filteredElements.length === 0) {
             return;
         }
-        const insertIndex = focusableElements.findIndex(e => (e.compareDocumentPosition(filteredElements[0]) & Node.DOCUMENT_POSITION_PRECEDING) > 0);
-        focusableElements.splice(insertIndex === -1 ? focusableElements.length : insertIndex, 0, ...filteredElements);
+        focusableElements.splice(findInsertionIndex(filteredElements), 0, ...filteredElements);
         for (const element of filteredElements) {
             if (!savedTabIndex.has(element)) {
                 savedTabIndex.set(element, element.getAttribute('tabindex'));
@@ -199,6 +198,27 @@ export function focusZone(container, settings) {
             updateFocusedElement(getFirstFocusableElement());
         }
     }
+    function findInsertionIndex(elementsToInsert) {
+        const firstElementToInsert = elementsToInsert[0];
+        if (focusableElements.length === 0)
+            return 0;
+        let iMin = 0;
+        let iMax = focusableElements.length - 1;
+        while (iMin <= iMax) {
+            const i = Math.floor((iMin + iMax) / 2);
+            const element = focusableElements[i];
+            if (followsInDocument(firstElementToInsert, element)) {
+                iMax = i - 1;
+            }
+            else {
+                iMin = i + 1;
+            }
+        }
+        return iMin;
+    }
+    function followsInDocument(first, second) {
+        return (second.compareDocumentPosition(first) & Node.DOCUMENT_POSITION_PRECEDING) > 0;
+    }
     function endFocusManagement(...elements) {
         for (const element of elements) {
             const focusableElementIndex = focusableElements.indexOf(element);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@primer/behaviors",
-  "version": "1.3.1",
+  "version": "1.3.2-rc.b275ab5",
   "description": "Shared behaviors for JavaScript components",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",
@@ -74,7 +74,7 @@
     "@testing-library/user-event": "^13.5.0",
     "@types/jest": "^27.0.3",
     "@types/react": "^17.0.37",
-    "esbuild": "^0.14.1",
+    "esbuild": "^0.15.16",
     "esbuild-jest": "^0.5.0",
     "eslint": "^8.3.0",
     "eslint-plugin-github": "^4.3.5",