@primer-io/react-native 2.30.0 → 2.30.2

package/android/.editorconfig

@@ -0,0 +1,2 @@
+[*.{kt,kts}]
+max_line_length = 120

package/android/build.gradle

@@ -6,6 +6,9 @@ buildscript {
     google()
     mavenCentral()
     mavenLocal()
+    maven {
+      url "https://plugins.gradle.org/m2/"
+    }
   }
 
   dependencies {
@@ -14,12 +17,14 @@ buildscript {
     classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
     classpath "org.jetbrains.kotlin:kotlin-serialization:$kotlin_version"
     classpath "org.jetbrains.kotlinx:kover-gradle-plugin:$kover_version"
+    classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.23.7"
   }
 }
 
 apply plugin: 'com.android.library'
 apply plugin: 'kotlin-android'
 apply plugin: 'kotlinx-serialization'
+apply plugin: 'io.gitlab.arturbosch.detekt'
 apply from: "./config/coverage-scripts/kover.gradle"
 
 def getExtOrDefault(name) {
@@ -147,14 +152,37 @@ repositories {
   }
 }
 
+detekt {
+    buildUponDefaultConfig = true
+    def defaultConfig = file("$rootDir/tooling/code-analysis/detekt.yml")
+
+    if (defaultConfig.exists()) {
+      config.setFrom(files(defaultConfig))
+    }
+
+    debug = true
+    parallel = true
+    disableDefaultRuleSets = false
+
+    ignoredBuildTypes = ["debug"]
+
+    reports {
+        html.required.set(true)
+        xml.required.set(false)
+        txt.required.set(true)
+        sarif.required.set(true)
+    }
+}
+
 def kotlin_version = getExtOrDefault('kotlinVersion')
 
 dependencies {
+  detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.23.7")
   // noinspection GradleDynamicVersion
   api 'com.facebook.react:react-native:+'
   implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
   implementation "org.jetbrains.kotlinx:kotlinx-serialization-json:1.5.1"
-  implementation 'io.primer:android:2.36.1'
+  implementation 'io.primer:android:2.36.3'
   testImplementation 'io.mockk:mockk:1.13.11'
   testImplementation 'org.junit.jupiter:junit-jupiter-api:5.10.2'
   testImplementation 'org.junit.jupiter:junit-jupiter-api:5.10.2'

package/android/detekt-baseline.xml

@@ -0,0 +1,24 @@
+<?xml version="1.0" ?>
+<SmellBaseline>
+  <ManuallySuppressedIssues></ManuallySuppressedIssues>
+  <CurrentIssues>
+    <ID>TooGenericExceptionCaught:PrimerRN.kt$PrimerRN$e: Exception</ID>
+    <ID>TooGenericExceptionCaught:PrimerRNHeadlessUniversalCheckout.kt$PrimerRNHeadlessUniversalCheckout$e: Exception</ID>
+    <ID>TooGenericExceptionCaught:PrimerRNHeadlessUniversalCheckoutAssetManager.kt$PrimerRNHeadlessUniversalCheckoutAssetManager$e: Exception</ID>
+    <ID>TooGenericExceptionCaught:PrimerRNHeadlessUniversalCheckoutNativeUiManager.kt$PrimerRNHeadlessUniversalCheckoutNativeUiManager$e: Exception</ID>
+    <ID>TooGenericExceptionCaught:PrimerRNHeadlessUniversalCheckoutRawManager.kt$PrimerRNHeadlessUniversalCheckoutRawManager$e: Exception</ID>
+    <ID>TooGenericExceptionCaught:PrimerRNHeadlessUniversalCheckoutVaultManager.kt$PrimerRNHeadlessUniversalCheckoutVaultManager$e: Exception</ID>
+    <ID>UnusedParameter:PrimerRN.kt$PrimerRN$count: Int?</ID>
+    <ID>UnusedParameter:PrimerRN.kt$PrimerRN$eventName: String?</ID>
+    <ID>UnusedParameter:PrimerRNHeadlessUniversalCheckout.kt$PrimerRNHeadlessUniversalCheckout$count: Int?</ID>
+    <ID>UnusedParameter:PrimerRNHeadlessUniversalCheckout.kt$PrimerRNHeadlessUniversalCheckout$eventName: String?</ID>
+    <ID>UnusedParameter:PrimerRNHeadlessUniversalCheckoutBanksComponent.kt$PrimerRNHeadlessUniversalCheckoutBanksComponent$count: Int?</ID>
+    <ID>UnusedParameter:PrimerRNHeadlessUniversalCheckoutBanksComponent.kt$PrimerRNHeadlessUniversalCheckoutBanksComponent$eventName: String?</ID>
+    <ID>UnusedParameter:PrimerRNHeadlessUniversalCheckoutKlarnaComponent.kt$PrimerRNHeadlessUniversalCheckoutKlarnaComponent$count: Int?</ID>
+    <ID>UnusedParameter:PrimerRNHeadlessUniversalCheckoutKlarnaComponent.kt$PrimerRNHeadlessUniversalCheckoutKlarnaComponent$eventName: String?</ID>
+    <ID>UnusedParameter:PrimerRNHeadlessUniversalCheckoutRawManager.kt$PrimerRNHeadlessUniversalCheckoutRawManager$count: Int?</ID>
+    <ID>UnusedParameter:PrimerRNHeadlessUniversalCheckoutRawManager.kt$PrimerRNHeadlessUniversalCheckoutRawManager$eventName: String?</ID>
+    <ID>UnusedParameter:PrimerRNHeadlessUniversalCheckoutStripeAchUserDetailsComponent.kt$PrimerRNHeadlessUniversalCheckoutStripeAchUserDetailsComponent$count: Int?</ID>
+    <ID>UnusedParameter:PrimerRNHeadlessUniversalCheckoutStripeAchUserDetailsComponent.kt$PrimerRNHeadlessUniversalCheckoutStripeAchUserDetailsComponent$eventName: String?</ID>
+  </CurrentIssues>
+</SmellBaseline>

package/android/src/main/java/com/primerioreactnative/PrimerRN.kt

@@ -1,9 +1,19 @@
 package com.primerioreactnative
 
 import android.util.Log
-import com.facebook.react.bridge.*
+import com.facebook.react.bridge.Arguments
+import com.facebook.react.bridge.Promise
+import com.facebook.react.bridge.ReactApplicationContext
+import com.facebook.react.bridge.ReactContextBaseJavaModule
+import com.facebook.react.bridge.ReactMethod
+import com.facebook.react.bridge.WritableMap
 import com.facebook.react.modules.core.DeviceEventManagerModule
-import com.primerioreactnative.datamodels.*
+import com.primerioreactnative.datamodels.ErrorTypeRN
+import com.primerioreactnative.datamodels.PrimerCheckoutDataRN
+import com.primerioreactnative.datamodels.PrimerErrorRN
+import com.primerioreactnative.datamodels.PrimerEvents
+import com.primerioreactnative.datamodels.PrimerSettingsRN
+import com.primerioreactnative.datamodels.toPrimerSettings
 import com.primerioreactnative.utils.PrimerImplementedRNCallbacks
 import com.primerioreactnative.utils.errorTo
 import com.primerioreactnative.utils.toWritableMap
@@ -14,201 +24,244 @@ import kotlinx.serialization.encodeToString
 import kotlinx.serialization.json.Json
 import org.json.JSONObject
 
+@Suppress("TooManyFunctions")
 class PrimerRN(private val reactContext: ReactApplicationContext, private val json: Json) :
-  ReactContextBaseJavaModule(reactContext) {
-  private val mListener = PrimerRNEventListener()
-
-  init {
-    mListener.sendEvent = { eventName, paramsJson -> sendEvent(eventName, paramsJson) }
-    mListener.sendError = { paramsJson -> onError(paramsJson) }
-    mListener.sendErrorWithCheckoutData =
-      { paramsJson, checkoutData -> onError(paramsJson, checkoutData) }
-    mListener.onDismissedEvent = { Primer.instance.dismiss(true) }
-  }
-
-  override fun getName(): String = "NativePrimer"
-
-  @ReactMethod
-  fun configure(settingsStr: String, promise: Promise) {
-    try {
-      Log.d("PrimerRN", "settings: $settingsStr")
-      val settings =
-        if (settingsStr.isBlank()) PrimerSettingsRN() else json.decodeFromString(
-          settingsStr
-        )
-      startSdk(settings.toPrimerSettings(reactContext))
-      promise.resolve(null)
-    } catch (e: Exception) {
-      Log.e("PrimerRN", "configure settings error: $e")
-      val exception = ErrorTypeRN.NativeBridgeFailed errorTo "failed to parse settings."
-      onError(exception)
-      promise.reject(exception.errorId, exception.description, e)
-    }
-  }
-
-  @ReactMethod
-  fun showUniversalCheckoutWithClientToken(
-    clientToken: String,
-    promise: Promise
-  ) {
-    try {
-      Primer.instance.showUniversalCheckout(reactApplicationContext.applicationContext, clientToken)
-      promise.resolve(null)
-    } catch (e: Exception) {
-      val exception = ErrorTypeRN.NativeBridgeFailed errorTo
-        "Primer SDK failed: ${e.message}"
-      onError(exception)
-      promise.reject(exception.errorId, exception.description, e)
-    }
-  }
-
-  @ReactMethod
-  fun showVaultManagerWithClientToken(clientToken: String, promise: Promise) {
-    try {
-      Primer.instance.showVaultManager(reactApplicationContext.applicationContext, clientToken)
-      promise.resolve(null)
-    } catch (e: Exception) {
-      val exception = ErrorTypeRN.NativeBridgeFailed errorTo
-        "Primer SDK failed: ${e.message}"
-      onError(exception)
-      promise.reject(exception.errorId, exception.description, e)
-    }
-  }
-
-  @ReactMethod
-  fun dismiss(promise: Promise) {
-    Primer.instance.dismiss(true)
-    promise.resolve(null)
-  }
-
-  @ReactMethod
-  fun cleanUp(promise: Promise) {
-    Primer.instance.dismiss(true)
-    promise.resolve(null)
-  }
-
-  // region tokenization handlers
-  @ReactMethod
-  fun handleTokenizationNewClientToken(newClientToken: String, promise: Promise) {
-    mListener.handleTokenizationNewClientToken(newClientToken)
-    promise.resolve(null)
-  }
-
-  @ReactMethod
-  fun handleTokenizationSuccess(promise: Promise) {
-    mListener.handleTokenizationSuccess()
-    promise.resolve(null)
-  }
-
-  @ReactMethod
-  fun handleTokenizationFailure(errorMessage: String?, promise: Promise) {
-    mListener.handleTokenizationFailure(errorMessage.orEmpty())
-    promise.resolve(null)
-  }
-  // endregion
-
-  // region resume handlers
-  @ReactMethod
-  fun handleResumeNewClientToken(newClientToken: String, promise: Promise) {
-    mListener.handleResumeNewClientToken(newClientToken)
-    promise.resolve(null)
-  }
-
-  @ReactMethod
-  fun handleResumeSuccess(promise: Promise) {
-    mListener.handleResumeSuccess()
-    promise.resolve(null)
-  }
-
-  @ReactMethod
-  fun handleResumeFailure(errorMessage: String?, promise: Promise) {
-    mListener.handleResumeFailure(errorMessage.orEmpty())
-    promise.resolve(null)
-  }
-  // endregion
-
-  // region payment handlers
-  @ReactMethod
-  fun handlePaymentCreationContinue(promise: Promise) {
-    mListener.handlePaymentCreationContinue()
-    promise.resolve(null)
-  }
-
-  @ReactMethod
-  fun handlePaymentCreationAbort(errorMessage: String?, promise: Promise) {
-    mListener.handlePaymentCreationAbort(errorMessage.orEmpty())
-    promise.resolve(null)
-  }
-  // endregion
-
-  // region error handlers
-  @ReactMethod
-  fun showErrorMessage(errorMessage: String?, promise: Promise) {
-    mListener.handleErrorMessage(errorMessage.orEmpty())
-    promise.resolve(null)
-  }
-  // endregion
-
-  @ReactMethod
-  fun setImplementedRNCallbacks(implementedRNCallbacksStr: String, promise: Promise) {
-    try {
-      Log.d("PrimerRN", "implementedRNCallbacks: $implementedRNCallbacksStr")
-      val implementedRNCallbacks =
-        json.decodeFromString<PrimerImplementedRNCallbacks>(implementedRNCallbacksStr)
-      this.mListener.setImplementedCallbacks(implementedRNCallbacks)
-      promise.resolve(null)
-    } catch (e: Exception) {
-      val exception =
-        ErrorTypeRN.NativeBridgeFailed errorTo "Implemented callbacks $implementedRNCallbacksStr is not valid."
-      onError(exception)
-      promise.reject(exception.errorId, exception.description, e)
-    }
-  }
-
-  @ReactMethod
-  fun addListener(eventName: String?) = Unit
-
-  @ReactMethod
-  fun removeListeners(count: Int?) = Unit
-
-  private fun startSdk(settings: PrimerSettings) {
-    Primer.instance.configure(settings, mListener)
-  }
-
-  private fun onError(exception: PrimerErrorRN, checkoutDataRN: PrimerCheckoutDataRN? = null) {
-    val params = Arguments.createMap()
-    val errorJson = JSONObject(Json.encodeToString(exception))
-    val errorData = prepareData(errorJson)
-    params.putMap(Keys.ERROR, errorData)
-    checkoutDataRN?.let {
-      val checkoutDataJson = JSONObject(Json.encodeToString(it))
-      val checkoutData = prepareData(checkoutDataJson)
-      params.putMap(Keys.CHECKOUT_DATA, checkoutData)
-    }
-    sendEvent(PrimerEvents.ON_ERROR.eventName, params)
-  }
-
-  private fun sendEvent(name: String, params: WritableMap) {
-    reactApplicationContext.getJSModule(
-      DeviceEventManagerModule.RCTDeviceEventEmitter::class.java
-    ).emit(name, params)
-  }
-
-  private fun sendEvent(name: String, data: JSONObject?) {
-    val params = prepareData(data)
-    reactApplicationContext.getJSModule(
-      DeviceEventManagerModule.RCTDeviceEventEmitter::class.java
-    ).emit(name, params)
-  }
-
-  private fun prepareData(data: JSONObject?): WritableMap {
-    return data.toWritableMap()
-  }
+    ReactContextBaseJavaModule(reactContext) {
+    private val mListener = PrimerRNEventListener()
+
+    init {
+        mListener.sendEvent = { eventName, paramsJson -> sendEvent(eventName, paramsJson) }
+        mListener.sendError = { paramsJson -> onError(paramsJson) }
+        mListener.sendErrorWithCheckoutData =
+            { paramsJson, checkoutData -> onError(paramsJson, checkoutData) }
+        mListener.onDismissedEvent = { Primer.instance.dismiss(true) }
+    }
+
+    override fun getName(): String = "NativePrimer"
+
+    @ReactMethod
+    fun configure(
+        settingsStr: String,
+        promise: Promise,
+    ) {
+        try {
+            Log.d("PrimerRN", "settings: $settingsStr")
+            val settings =
+                if (settingsStr.isBlank()) {
+                    PrimerSettingsRN()
+                } else {
+                    json.decodeFromString(
+                        settingsStr,
+                    )
+                }
+            startSdk(settings.toPrimerSettings(reactContext))
+            promise.resolve(null)
+        } catch (e: Exception) {
+            Log.e("PrimerRN", "configure settings error: $e")
+            val exception = ErrorTypeRN.NativeBridgeFailed errorTo "failed to parse settings."
+            onError(exception)
+            promise.reject(exception.errorId, exception.description, e)
+        }
+    }
+
+    @ReactMethod
+    fun showUniversalCheckoutWithClientToken(
+        clientToken: String,
+        promise: Promise,
+    ) {
+        try {
+            Primer.instance.showUniversalCheckout(reactApplicationContext.applicationContext, clientToken)
+            promise.resolve(null)
+        } catch (e: Exception) {
+            val exception =
+                ErrorTypeRN.NativeBridgeFailed errorTo
+                    "Primer SDK failed: ${e.message}"
+            onError(exception)
+            promise.reject(exception.errorId, exception.description, e)
+        }
+    }
+
+    @ReactMethod
+    fun showVaultManagerWithClientToken(
+        clientToken: String,
+        promise: Promise,
+    ) {
+        try {
+            Primer.instance.showVaultManager(reactApplicationContext.applicationContext, clientToken)
+            promise.resolve(null)
+        } catch (e: Exception) {
+            val exception =
+                ErrorTypeRN.NativeBridgeFailed errorTo
+                    "Primer SDK failed: ${e.message}"
+            onError(exception)
+            promise.reject(exception.errorId, exception.description, e)
+        }
+    }
+
+    @ReactMethod
+    fun dismiss(promise: Promise) {
+        Primer.instance.dismiss(true)
+        promise.resolve(null)
+    }
+
+    @ReactMethod
+    fun cleanUp(promise: Promise) {
+        Primer.instance.dismiss(true)
+        promise.resolve(null)
+    }
+
+    // region tokenization handlers
+    @ReactMethod
+    fun handleTokenizationNewClientToken(
+        newClientToken: String,
+        promise: Promise,
+    ) {
+        mListener.handleTokenizationNewClientToken(newClientToken)
+        promise.resolve(null)
+    }
+
+    @ReactMethod
+    fun handleTokenizationSuccess(promise: Promise) {
+        mListener.handleTokenizationSuccess()
+        promise.resolve(null)
+    }
+
+    @ReactMethod
+    fun handleTokenizationFailure(
+        errorMessage: String?,
+        promise: Promise,
+    ) {
+        mListener.handleTokenizationFailure(errorMessage.orEmpty())
+        promise.resolve(null)
+    }
+    // endregion
+
+    // region resume handlers
+    @ReactMethod
+    fun handleResumeNewClientToken(
+        newClientToken: String,
+        promise: Promise,
+    ) {
+        mListener.handleResumeNewClientToken(newClientToken)
+        promise.resolve(null)
+    }
+
+    @ReactMethod
+    fun handleResumeSuccess(promise: Promise) {
+        mListener.handleResumeSuccess()
+        promise.resolve(null)
+    }
+
+    @ReactMethod
+    fun handleResumeFailure(
+        errorMessage: String?,
+        promise: Promise,
+    ) {
+        mListener.handleResumeFailure(errorMessage.orEmpty())
+        promise.resolve(null)
+    }
+    // endregion
+
+    // region payment handlers
+    @ReactMethod
+    fun handlePaymentCreationContinue(promise: Promise) {
+        mListener.handlePaymentCreationContinue()
+        promise.resolve(null)
+    }
+
+    @ReactMethod
+    fun handlePaymentCreationAbort(
+        errorMessage: String?,
+        promise: Promise,
+    ) {
+        mListener.handlePaymentCreationAbort(errorMessage.orEmpty())
+        promise.resolve(null)
+    }
+    // endregion
+
+    // region error handlers
+    @ReactMethod
+    fun showErrorMessage(
+        errorMessage: String?,
+        promise: Promise,
+    ) {
+        mListener.handleErrorMessage(errorMessage.orEmpty())
+        promise.resolve(null)
+    }
+    // endregion
+
+    @ReactMethod
+    fun setImplementedRNCallbacks(
+        implementedRNCallbacksStr: String,
+        promise: Promise,
+    ) {
+        try {
+            Log.d("PrimerRN", "implementedRNCallbacks: $implementedRNCallbacksStr")
+            val implementedRNCallbacks =
+                json.decodeFromString<PrimerImplementedRNCallbacks>(implementedRNCallbacksStr)
+            this.mListener.setImplementedCallbacks(implementedRNCallbacks)
+            promise.resolve(null)
+        } catch (e: Exception) {
+            val exception =
+                ErrorTypeRN.NativeBridgeFailed errorTo "Implemented callbacks $implementedRNCallbacksStr is not valid."
+            onError(exception)
+            promise.reject(exception.errorId, exception.description, e)
+        }
+    }
+
+    @ReactMethod
+    fun addListener(eventName: String?) = Unit
+
+    @ReactMethod
+    fun removeListeners(count: Int?) = Unit
+
+    private fun startSdk(settings: PrimerSettings) {
+        Primer.instance.configure(settings, mListener)
+    }
+
+    private fun onError(
+        exception: PrimerErrorRN,
+        checkoutDataRN: PrimerCheckoutDataRN? = null,
+    ) {
+        val params = Arguments.createMap()
+        val errorJson = JSONObject(Json.encodeToString(exception))
+        val errorData = prepareData(errorJson)
+        params.putMap(Keys.ERROR, errorData)
+        checkoutDataRN?.let {
+            val checkoutDataJson = JSONObject(Json.encodeToString(it))
+            val checkoutData = prepareData(checkoutDataJson)
+            params.putMap(Keys.CHECKOUT_DATA, checkoutData)
+        }
+        sendEvent(PrimerEvents.ON_ERROR.eventName, params)
+    }
+
+    private fun sendEvent(
+        name: String,
+        params: WritableMap,
+    ) {
+        reactApplicationContext.getJSModule(
+            DeviceEventManagerModule.RCTDeviceEventEmitter::class.java,
+        ).emit(name, params)
+    }
+
+    private fun sendEvent(
+        name: String,
+        data: JSONObject?,
+    ) {
+        val params = prepareData(data)
+        reactApplicationContext.getJSModule(
+            DeviceEventManagerModule.RCTDeviceEventEmitter::class.java,
+        ).emit(name, params)
+    }
+
+    private fun prepareData(data: JSONObject?): WritableMap {
+        return data.toWritableMap()
+    }
 }
 
 internal object Keys {
-  const val ERROR = "error"
-  const val RESUME_TOKEN = "resumeToken"
-  const val CHECKOUT_DATA = "checkoutData"
-  const val ADDITIONAL_INFO = "additionalInfo"
+    const val ERROR = "error"
+    const val RESUME_TOKEN = "resumeToken"
+    const val CHECKOUT_DATA = "checkoutData"
+    const val ADDITIONAL_INFO = "additionalInfo"
 }