@preventive/triage 1.0.0-alpha.49 → 1.0.0-alpha.50

package/common/managed/finding-detail.d.ts

@@ -0,0 +1,2 @@
+export const FINDING_DETAIL_FIELDS: readonly string[]
+export function liteReportData(data: unknown): unknown

package/common/managed/finding-detail.js

@@ -0,0 +1,32 @@
+import { findingTitle } from '@preventive/report'
+
+// A finding's detail: what its popup, the views besides the board and an
+// export read, and the board does not. Its narrative and evidence, the hash
+// its Code button finds a bundle by, and the export it names. A team's
+// reports are first sent without it (server-managed/team-reports.ts), the
+// board drawn from them, and their findings filled in from the whole reports
+// (ui/view/managed-details.js).
+export const FINDING_DETAIL_FIELDS = Object.freeze(['description', 'evidence', 'impact', 'reproduction', 'recommendation',
+  'confidenceReason', 'revalidateVerdict', 'revalidateRecommendation', 'fileHash', 'exportName', 'methodName'])
+const DETAIL = new Set(FINDING_DETAIL_FIELDS)
+// More of a name than a board card's three lines show.
+const NAME_CHARS = 200
+
+// A finding without its detail. One without a title of its own is named by its
+// description's first line (findingTitle), which it keeps as its description,
+// as much of it as a card shows.
+function liteFinding(finding) {
+  if (!finding || typeof finding !== 'object' || Array.isArray(finding)) return finding
+  const lite = Object.fromEntries(Object.entries(finding).filter(([key]) => !DETAIL.has(key)))
+  const titled = typeof finding.title === 'string' && finding.title.trim() !== ''
+  const title = titled ? '' : findingTitle(finding)
+  if (title) lite.description = title.length > NAME_CHARS ? `${title.slice(0, NAME_CHARS - 1)}…` : title
+  return lite
+}
+
+// A report's data, its findings without their detail.
+export function liteReportData(data) {
+  const key = Array.isArray(data?.findings) ? 'findings' : Array.isArray(data?.groups) ? 'groups' : null
+  if (!key) return data
+  return { ...data, [key]: data[key].map(entry => Array.isArray(entry) ? entry.map(liteFinding) : liteFinding(entry)) }
+}

package/common/managed/github-agents.ts

@@ -20,7 +20,9 @@
 // in its address. GitHub's Agentic Workflows (gh-aw) post, and approve or
 // review pull requests, as GitHub Actions' bot, `github-actions` (41898282,
 // `[bot]` to the REST API), its mark the GitHub Actions App's avatar; other
-// workflows the bot runs are as much its own. Neo, its GitHub App (3115942),
+// workflows the bot runs are as much its own, and the commits workflows make
+// as the names they are commonly given, `github-actions` and `GitHub Action`,
+// GitHub naming no account for their addresses. Neo, its GitHub App (3115942),
 // as its account (274065190) and its App's bot (268952163), each known by
 // its id alone, whatever GitHub names it, and drawn by its App's avatar,
 // wherever either or its fingerprint names it. Cursor's agents commit as whoever ran them, with a
@@ -51,7 +53,8 @@ export const GITHUB_AGENTS = {
     { id: 175728472, logins: ['Copilot', 'copilot-pull-request-reviewer', 'copilot-pull-request-reviewer[bot]'] }], names: ['Copilot'], prefix: 'copilot/' },
   dependabot: { name: 'Dependabot', avatar: 'app-29110', accounts: [{ id: 49699333, logins: ['dependabot', 'dependabot[bot]'] }], names: ['dependabot[bot]'],
     prefix: 'dependabot/' },
-  actions: { name: 'GitHub Actions', avatar: 'app-15368', accounts: [{ id: 41898282, logins: ['github-actions', 'github-actions[bot]'] }], names: ['github-actions[bot]'] },
+  actions: { name: 'GitHub Actions', avatar: 'app-15368', accounts: [{ id: 41898282, logins: ['github-actions', 'github-actions[bot]'] }],
+    names: ['github-actions[bot]', 'github-actions', 'GitHub Action'] },
   cursor: { name: 'Cursor', accounts: [], names: ['Cursor Agent'], emails: ['cursoragent@cursor.com'] },
 } as const satisfies Record<string, GithubAgent>
 export type GithubAgentId = keyof typeof GITHUB_AGENTS
@@ -99,7 +102,7 @@ export function oneAgent(login: string, ids: Iterable<number>): boolean {
 // The accounts agents work as, a person's to GitHub, as the app is told of
 // them, each by its id and logins: the pull requests they open and the
 // commits they push to a branch directly are agents' (the Pulse's,
-// server-managed/agent-merges.ts agentMerges, repository-pulse.ts
+// server-managed/repository-pulls.ts readPulls, repository-pulse.ts
 // commitStats), whatever their branches and labels, the rest of what they do
 // theirs. Christopher Turing's.
 export const AGENT_OPERATED = [{ id: 188797125, logins: ['ChristopherTuring'] }] as const satisfies readonly GithubAgentAccount[]

package/common/managed/routes.js

@@ -146,7 +146,8 @@ function parseNpmRoute(path, hash) {
 // link opens, names its file by number and its lines in the fragment, as a
 // bundle's Code does: `/code/<file>#L4`. Compare names the commit compared
 // with, then its mode past the Overview, as an npm version's does:
-// `/compare/<commit>/code`. Without a commit,
+// `/compare/<commit>/code`. An Activity view names its sub-tab past the
+// first (isActivitySubtab): `/pulse/year`. Without a commit,
 // `/repo/<repo id>[?path=<directory>]`, it opens on the default
 // branch's head, or on the revision a route held in memory names (`ref`),
 // and its route then names the commit it opened. Links from before it moved
@@ -155,6 +156,15 @@ export const REPOSITORY_CODE_TABS = new Set(['code', 'search', 'treemap', 'compa
 // The tabs reading none of the directory's files, which a directory at a
 // commit shows alone.
 export const REPOSITORY_FILELESS_TABS = new Set(['commits', 'issues', 'pulls', 'agents', 'pulse', 'replay'])
+// The Activity views' sub-tabs past their first: Issues' and Pull requests'
+// closed ones (open, the first), Pulse's periods (a month, the first),
+// Replay's commits played (the last 300, the first), and one agent's
+// sessions, by its id (every agent's, `all`, the first).
+const ACTIVITY_SUBTABS = new Map([['issues', new Set(['closed'])], ['pulls', new Set(['closed'])],
+  ['pulse', new Set(['week', 'quarter', 'year'])], ['replay', new Set(['100', '1000'])]])
+const AGENT_ID = /^[a-z][a-z\d-]{0,31}$/u
+export const isActivitySubtab = (tab, subtab) => tab === 'agents' ? typeof subtab === 'string' && AGENT_ID.test(subtab) && subtab !== 'all'
+  : ACTIVITY_SUBTABS.get(tab)?.has(subtab) === true
 const COMMIT = /^[a-f\d]{40}$/u
 const MAX_DIRECTORY = 500
 const isRepoId = value => Number.isSafeInteger(value) && value > 0
@@ -176,9 +186,10 @@ function repositoryCodePath(route) {
   if (route.commit == null) return `/repo/${route.repoId}${directory}`
   const file = tab === 'code' && isLineNumber(route.file) ? `/code/${route.file}` : tab === 'code' ? '' : `/${tab}`
   const compare = tab === 'compare' && route.compareCommit != null ? `/${route.compareCommit}${compareModeSuffix(route.compareMode)}` : ''
+  const subtab = isActivitySubtab(tab, route.subtab) ? `/${route.subtab}` : ''
   const lines = tab === 'code' && isLineNumber(route.file) && isLineNumber(route.line)
     ? `#L${route.line}${isLineNumber(route.endLine) && route.endLine > route.line ? `-L${route.endLine}` : ''}` : ''
-  return `/repo/${route.repoId}/${route.commit}${file}${compare}${directory}${lines}`
+  return `/repo/${route.repoId}/${route.commit}${file}${compare}${subtab}${directory}${lines}`
 }
 
 function parseRepositoryCodeRoute(url) {
@@ -195,6 +206,7 @@ function parseRepositoryCodeRoute(url) {
   if (tab === 'compare') {
     return COMMIT.test(match[4]) && (match[5] == null || COMPARE_MODES.has(match[5])) ? { ...route, compareCommit: match[4], ...compareModeField(match[5]) } : null
   }
+  if (REPOSITORY_FILELESS_TABS.has(tab)) return match[5] == null && isActivitySubtab(tab, match[4]) ? { ...route, subtab: match[4] } : null
   const file = Number(match[4])
   return tab === 'code' && match[5] == null && /^[1-9]\d*$/u.test(match[4]) && Number.isSafeInteger(file) ? { ...route, file, ...codeLines(url.hash) } : null
 }