@preventive/triage 1.0.0-alpha.47 → 1.0.0-alpha.48

package/client/dependency-paths.d.ts

@@ -1,2 +1,3 @@
 export function isDependencyFile(file: unknown, directory: string): boolean
-export function dependencyDirectory(reports: Iterable<{ groups?: Iterable<Iterable<{ file?: unknown }>>; tree?: unknown }>): 'node_modules' | 'vendor' | 'dependencies'
+export function dependencyDirectory(reports: Iterable<{ groups?: Iterable<Iterable<{ file?: unknown }>>; tree?: unknown; treeDependencies?: unknown }>): 'node_modules' | 'vendor' | 'dependencies'
+export function treeDependencyDirectory(tree: unknown): 'node_modules' | 'vendor' | null

package/client/dependency-paths.js

@@ -6,6 +6,8 @@ export function isDependencyFile(file, directory) {
   return path.startsWith(`${directory}/`) || path.includes(`/${directory}/`)
 }
 
+// A team's reports tell the one their tree names (`treeDependencies`) in place
+// of the tree, which is asked for apart (server-managed/team-reports.ts).
 export function dependencyDirectory(reports) {
   let vendor = false
   for (const report of reports) {
@@ -15,10 +17,20 @@ export function dependencyDirectory(reports) {
         if (isDependencyFile(finding.file, 'vendor')) vendor = true
       }
     }
-    for (const file of Object.keys(report.tree ?? {})) {
-      if (isDependencyFile(file, 'node_modules')) return 'node_modules'
-      if (isDependencyFile(file, 'vendor')) vendor = true
-    }
+    const named = report.tree ? treeDependencyDirectory(report.tree) : report.treeDependencies
+    if (named === 'node_modules') return 'node_modules'
+    if (named === 'vendor') vendor = true
   }
   return vendor ? 'vendor' : 'dependencies'
 }
+
+// The dependency directory a report's file tree names: node_modules, else
+// vendor, else none.
+export function treeDependencyDirectory(tree) {
+  let vendor = false
+  for (const file of Object.keys(tree ?? {})) {
+    if (isDependencyFile(file, 'node_modules')) return 'node_modules'
+    if (isDependencyFile(file, 'vendor')) vendor = true
+  }
+  return vendor ? 'vendor' : null
+}

package/common/managed/agent-tasks.ts

@@ -13,14 +13,16 @@
 // requests are one session, and a commit its own.
 //
 // The agents are Claude and Codex, and those the server knows by their GitHub
-// Apps or accounts (repository-agents.ts APP_AGENTS): each told by its
-// fingerprint, a line of its texts, by the account its work is authored by,
-// or by its branches' prefix, the server's to read, and named to the client
+// Apps or accounts (server-managed/app-agents.ts APP_AGENTS): each told by its
+// fingerprint, a line of its texts, by the account its work is authored by
+// (github-agents.ts githubAgent), or by its branches' prefix, the server's to
+// read, and named to the client
 // by its id, name and avatar (AppAgent). Such an agent names no session:
 // a pull request of its is a session alone, with its branch; Claude's or
 // Codex's marks on its work show those as its tools. A pull request labelled
 // for an agent (labelAgents) is that agent's too, where its own texts and
 // branch name none: the mark one who ran it gives work it left unmarked.
+import { githubAgent } from './github-agents.ts'
 
 // 'claude', 'codex', or an app agent's id.
 export type Agent = string
@@ -30,11 +32,10 @@ export type Agent = string
 // `app-<id>` a GitHub App's, `user-<id>` a GitHub account's), where the app
 // draws no mark of its own for it (Copilot's, ui/view/repository-tiles.js).
 export interface AppAgent { id: string; name: string; avatar?: string }
-// How the server tells one: its fingerprint, a line of an artifact's texts
-// starting with it; the GitHub account its work is authored by, its id and
-// the logins GitHub names it by, none for one known by its id alone; its
-// branches' prefix.
-export interface AppAgentMarks { id: string; fingerprint?: string; account?: { id: number; logins: readonly string[] }; prefix: string }
+// How the server tells one, beside the accounts its work is authored by (its
+// id githubAgent's): its fingerprint, a line of an artifact's texts starting
+// with it; its branches' prefix.
+export interface AppAgentMarks { id: string; fingerprint?: string; prefix: string }
 // An artifact's author, as GitHub names its account: its login and id.
 export interface AgentAuthor { login: string; id: number }
 
@@ -121,22 +122,19 @@ export function labelAgents(labels: unknown[], ids: readonly string[]): Agent[]
 // The sessions and tasks `texts` link, whether they carry Claude's marks and
 // Codex's, and the agents of `apps` whose fingerprints start a line of them
 // (not one a text quotes, as one describing it may), whose account `author`
-// is, by its id and login both (its id alone where it names no login), or
-// whose prefix the branch `branch` is under;
+// is (githubAgent), or whose prefix the branch `branch` is under;
 // Claude, Codex or the agents of `apps` its `labels` name (labelAgents).
 export function agentSignals(texts: unknown[], apps: readonly AppAgentMarks[] = [], branch: string | null = null,
   author: AgentAuthor | null = null, labels: unknown[] = []): AgentSignals {
   const strings = texts.filter((text): text is string => typeof text === 'string')
   const found = (pattern: RegExp) => [...new Set(strings.flatMap(text => [...text.matchAll(pattern)].map(match => match[1]!)))].slice(0, MAX_LINKS)
   const lines = strings.flatMap(text => text.split('\n').map(line => line.trimStart()))
-  const login = author?.login.toLowerCase()
-  const authored = ({ account }: AppAgentMarks) => author !== null && account !== undefined && account.id === author.id
-    && (account.logins.length === 0 || account.logins.some(name => name.toLowerCase() === login))
+  const authored = author ? githubAgent(author.login, author.id) : null
   const labelled = labelAgents(labels, ['claude', 'codex', ...apps.map(app => app.id)])
   return { sessions: found(SESSION), tasks: found(CODEX_TASK), claude: labelled.includes('claude') || strings.some(text => CLAUDE_MARK.test(text)),
     codex: labelled.includes('codex') || strings.some(text => CODEX_MARK.test(trailerBlock(text))),
     agents: apps.filter(app => (app.fingerprint && lines.some(line => line.startsWith(app.fingerprint!)))
-      || authored(app) || branch?.startsWith(app.prefix) || labelled.includes(app.id)).map(app => app.id) }
+      || authored === app.id || branch?.startsWith(app.prefix) || labelled.includes(app.id)).map(app => app.id) }
 }
 
 // The agent a branch's name says made it, and the issue or pull request the

package/common/managed/github-agents.ts

@@ -21,9 +21,9 @@
 // review pull requests, as GitHub Actions' bot, `github-actions` (41898282,
 // `[bot]` to the REST API), its mark the GitHub Actions App's avatar; other
 // workflows the bot runs are as much its own. Neo, its GitHub App (3115942),
-// as its account (274065190), known by its id alone, whatever GitHub names
-// it, and drawn by its App's avatar, wherever its account or its fingerprint
-// names it. Cursor's agents commit as whoever ran them, with a
+// as its account (274065190) and its App's bot (268952163), each known by
+// its id alone, whatever GitHub names it, and drawn by its App's avatar,
+// wherever either or its fingerprint names it. Cursor's agents commit as whoever ran them, with a
 // `Co-authored-by: Cursor Agent <cursoragent@cursor.com>` trailer; the app
 // has no mark of Cursor's, and draws it by its name's letter. Each by the
 // addresses (`emails`) its commits name it by, as author or co-author.
@@ -31,8 +31,8 @@
 // Those the Agents tab tells beside Claude and Codex (whose sessions and
 // tasks it tells them by, common/managed/agent-tasks.ts), the server's app
 // agents (server-managed/app-agents.ts APP_AGENTS), by their branches'
-// prefix (`prefix`), their first account, the one their work is authored by,
-// and the fingerprint (`fingerprint`) they leave as a line of their pull
+// prefix (`prefix`), the accounts their work is authored by, and the
+// fingerprint (`fingerprint`) they leave as a line of their pull
 // requests' bodies and their commits' messages, where they leave one:
 // Neo's, on `neo/` branches; Copilot's coding agent's, on `copilot/`;
 // Dependabot's, on `dependabot/<ecosystem>/…`. Their work may carry
@@ -45,7 +45,8 @@ export const GITHUB_AGENTS = {
   claude: { name: 'Claude', mark: 'anthropic', accounts: [{ id: 81847, logins: ['claude'] }, { logins: ['claude[bot]'] }], names: ['Claude'], emails: ['noreply@anthropic.com'] },
   codex: { name: 'Codex', mark: 'openai', accounts: [{ id: 199175422, logins: ['chatgpt-codex-connector', 'chatgpt-codex-connector[bot]'] }], names: ['Codex'],
     emails: ['codex@openai.com'] },
-  neo: { name: 'Neo', avatar: 'app-3115942', accounts: [{ id: 274065190, logins: [] }], names: [], prefix: 'neo/', fingerprint: '🤖 Generated with [Neo](' },
+  neo: { name: 'Neo', avatar: 'app-3115942', accounts: [{ id: 274065190, logins: [] }, { id: 268952163, logins: [] }], names: [], prefix: 'neo/',
+    fingerprint: '🤖 Generated with [Neo](' },
   copilot: { name: 'Copilot', mark: 'github-copilot', accounts: [{ id: 198982749, logins: ['Copilot', 'copilot-swe-agent'] },
     { id: 175728472, logins: ['Copilot', 'copilot-pull-request-reviewer', 'copilot-pull-request-reviewer[bot]'] }], names: ['Copilot'], prefix: 'copilot/' },
   dependabot: { name: 'Dependabot', avatar: 'app-29110', accounts: [{ id: 49699333, logins: ['dependabot', 'dependabot[bot]'] }], names: ['dependabot[bot]'],